Re: [Qemu-devel] [PATCH qemu v7 06/14] spapr_iommu: Introduce "enabled" state for TCE table

2015-05-27 Thread Paolo Bonzini
On 27/05/2015 01:55, Alexey Kardashevskiy wrote: > One step back :) Whole dance is what here? There are: > 1) del+set_size(0) > 2) set_size(not zero)+add Then no need for begin/commit. :) Paolo

Re: [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest

2015-05-27 Thread Denis V. Lunev
On 02/05/15 13:13, Denis V. Lunev wrote: Functionality match with Linux. Patches 1 and 2 are very useful for consistent backups of Windows guests. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Michael Roth ping

Re: [Qemu-devel] [PATCH v3 0/6] qemu: guest agent: implement guest-exec command

2015-05-27 Thread Denis V. Lunev
On 21/05/15 08:49, Denis V. Lunev wrote: These patches for guest-agent add the functionality to execute commands on a guest UNIX machine. These patches add the following interfaces: guest-pipe-open guest-exec guest-exec-status With these interfaces it's possible to: * Open an anonymous pipe a

[Qemu-devel] [RFC PATCH 3/4] virtio-blk: Use aio_set_io_event_notifier in dataplane

2015-05-27 Thread Fam Zheng
Currently the host notifier is checked by all aio_poll, which is not safe. For example, in a qmp transaction that takes snapshots or starts drive-backup on multiple dataplane disks, the atomicity could be broken: There could be one or more bdrv_drain_all() calls in each transaction opeartion, which

[Qemu-devel] [RFC PATCH 0/4] aio: Don't poll ioeventfd in nested aio_poll()

2015-05-27 Thread Fam Zheng
This series looks at the other side of the broken "qmp transaction" problem with dataplane [1] - the event loop. Before, an ioeventfd of a non-dataplane device is registered via qemu_set_fd_handler, which is only polled directly by main_loop_wait(), not in aio_poll(); an ioeventfd of a dataplane d

[Qemu-devel] [RFC PATCH 1/4] aio-posix: Introduce aio_set_io_event_notifier

2015-05-27 Thread Fam Zheng
This function will register the fd handler similar to aio_set_event_notifier, but the difference is the fd will only be polled in the outmost aio_poll. This is useful in some cases like device ioeventfd, where the handler typically processes a guest request, therefore nested aio_poll shouldn't inc

[Qemu-devel] [RFC PATCH 2/4] aio-win32: Implement aio_set_io_event_notifier

2015-05-27 Thread Fam Zheng
Signed-off-by: Fam Zheng --- aio-win32.c | 56 +++- 1 file changed, 47 insertions(+), 9 deletions(-) diff --git a/aio-win32.c b/aio-win32.c index 233d8f5..52867ab 100644 --- a/aio-win32.c +++ b/aio-win32.c @@ -27,15 +27,17 @@ struct AioHandler

Re: [Qemu-devel] [RFC 0/5] Slow-path for atomic instruction translation

2015-05-27 Thread alvise rigo
I'm going to respin these patches soon, I've found some issues that I'm addressing now. Thank you for your feedback, alvise On Tue, May 26, 2015 at 11:51 PM, Emilio G. Cota wrote: > On Mon, May 11, 2015 at 11:10:05 +0200, alvise rigo wrote: >> the last commit was b8df9208f357d2b36e1b19634aea9736

[Qemu-devel] [RFC PATCH 4/4] virtio-scsi-dataplane: User aio_set_io_event_notifier

2015-05-27 Thread Fam Zheng
For the same reason as previous commit. Signed-off-by: Fam Zheng --- hw/scsi/virtio-scsi-dataplane.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c index 5575648..e602da7 100644 --- a/hw/sc

Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too,

2015-05-27 Thread Markus Armbruster
Thomas Huth writes: > On Tue, 26 May 2015 17:43:09 +0100 > Stefan Hajnoczi wrote: > >> On Tue, May 26, 2015 at 3:36 PM, Daniel P. Berrange >> wrote: >> > On Tue, May 26, 2015 at 04:29:51PM +0200, Markus Armbruster wrote: >> >> Stefan Hajnoczi writes: >> >> >> >> > On Fri, May 22, 2015 at 09:22

[Qemu-devel] Questions regarding ITS implementation

2015-05-27 Thread Pavel Fedin
Hello! I am working on GICv3 ITS implementation for qemu and i ran into a (big) problem. I need some advice. As far as i can understand from the documentation i have and Linux source code, ITS uses per-device logical IDs as MSI data. These IDs are not global, they are actually a relative IRQ n

Re: [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send

2015-05-27 Thread Fam Zheng
On Tue, 05/26 10:18, Stefan Hajnoczi wrote: > On Mon, May 25, 2015 at 11:51:23AM +0800, Fam Zheng wrote: > > On Tue, 05/19 15:54, Stefan Hajnoczi wrote: > > > On Tue, May 19, 2015 at 10:51:01AM +, Fam Zheng wrote: > > > > This callback is called by main loop before polling s->fd, if it returns

[Qemu-devel] [PATCH v2 00/14] arm: Steps towards EL2 support round 3

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, This is round 3 of our series towards support for EL2 for AArch64. This series depends on Gregs and Peters exception target el infrastructure patch series that is not yet upstream. While adding the AArch32 versions of some of these regs I ran into issues with the o

[Qemu-devel] [PATCH v2 02/14] target-arm: Add MAIR_EL2

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index a0b414c..427cfab 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2517,6 +2517,13

[Qemu-devel] [PATCH v2 01/14] target-arm: Break down TLB_LOCKDOWN

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Break down the overly broad wildcard definition of TLB_LOCKDOWN down to v7 level. Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c b/target

[Qemu-devel] [PATCH v2 03/14] target-arm: Add TCR_EL2

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 427cfab..7dadc8a 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2524,6 +2524,9 @@ static

[Qemu-devel] [PATCH v2 04/14] target-arm: Add SCTLR_EL2

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7dadc8a..334e008 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2527,6 +2527,9 @@ static

[Qemu-devel] [PATCH v2 05/14] target-arm: Add TPIDR_EL2

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 334e008..df07a6a 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2530,6 +2530,9 @@ static

[Qemu-devel] [PATCH v2 06/14] target-arm: Add TTBR0_EL2

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index df07a6a..193750b 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2533,6 +2533,12

[Qemu-devel] [PATCH v2 07/14] target-arm: Add TLBI_ALLE1{IS}

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 193750b..826df50 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2368,6 +2368,14 @@ stati

[Qemu-devel] [PATCH v2 08/14] target-arm: Add TLBI_ALLE2

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 826df50..bf198e9 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2647,6 +2647,10 @@ static co

[Qemu-devel] [PATCH v2 09/14] target-arm: Add TLBI_VAE2{IS}

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index bf198e9..a5c0363 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2651,6 +2651,14 @@ stati

[Qemu-devel] [PATCH v1 1/1] xilinx_axidma.c: Fix up the stream_running() function

2015-05-27 Thread Alistair Francis
Previously the stream_running() function didn't check if the DMA was halted. This caused hangs in recent versions of MicroBlaze u-boot. Correct stream_running() to check DMASR_HALTED as well as DMACR_RUNSTOP. Signed-off-by: Alistair Francis Reviewed-by: Sai Pavan Boddu --- hw/dma/xilinx_axidma.

[Qemu-devel] [PATCH v2 10/14] target-arm: Add CNTVOFF_EL2

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 1 + target-arm/helper.c | 47 +-- 2 files changed, 42 insertions(+), 6 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index dd7a90b..24a910b 100644

[Qemu-devel] [PATCH v2 13/14] target-arm: Add HYP timer

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu-qom.h | 1 + target-arm/cpu.c | 2 ++ target-arm/cpu.h | 3 ++- target-arm/helper.c | 64 4 files changed, 69 insertions(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH v2 11/14] target-arm: Add CNTHCTL_EL2

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 1 + target-arm/helper.c | 32 ++-- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 24a910b..68ef363 100644 --- a/target-ar

[Qemu-devel] [PATCH v2 12/14] target-arm: Pass timeridx as argument to various timer functions

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 98 + 1 file changed, 76 insertions(+), 22 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 299fbb9..ed4bbd5 100644 --- a/target-arm

[Qemu-devel] [PATCH v2 14/14] hw/arm/virt: Connect the Hypervisor timer

2015-05-27 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/arm/virt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index a7f9a10..76b6b2e 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -384,6 +384,9 @@ static uint32_t create_gic(const VirtBoardI

Re: [Qemu-devel] [PATCH v3 03/29] display: enable DIRTY_MEMORY_VGA tracking explicitly

2015-05-27 Thread Fam Zheng
On Tue, 05/26 18:54, Paolo Bonzini wrote: > This will be required soon by the memory core. > > Cc: Peter Maydell > Cc: Mark Cave-Ayland > Cc: Aurelien Jarno > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v3 04/29] display: add memory_region_sync_dirty_bitmap calls

2015-05-27 Thread Fam Zheng
On Tue, 05/26 18:54, Paolo Bonzini wrote: > These are strictly speaking only needed for KVM and Xen, but it's still > nice to be consistent. > > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v3 07/29] framebuffer: check memory_region_is_logging

2015-05-27 Thread Fam Zheng
On Tue, 05/26 18:54, Paolo Bonzini wrote: > framebuffer.c expects DIRTY_MEMORY_VGA logging to be always on, but that > will not be the case soon. Because framebuffer.c computes the memory > region on the fly for every update (with memory_region_find), it cannot > enable/disable logging by itself.

Re: [Qemu-devel] [PATCH v3 14/29] exec: use memory_region_get_dirty_log_mask to optimize dirty tracking

2015-05-27 Thread Fam Zheng
On Tue, 05/26 18:54, Paolo Bonzini wrote: > The memory API can now return the exact set of bitmaps that have to > be tracked. Use it instead of the in_migration variable. > > In the next patches, we will also use it to set only DIRTY_MEMORY_VGA > or DIRTY_MEMORY_MIGRATION if necessary. This can

Re: [Qemu-devel] [PATCH] iov: don't touch iov in iov_send_recv()

2015-05-27 Thread Wen Congyang
Ping... On 05/21/2015 09:50 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > include/qemu/iov.h | 2 +- > util/iov.c | 14 +- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/include/qemu/iov.h b/include/qemu/iov.h > index 68d25f2..569b2c2 1

Re: [Qemu-devel] [PATCH v3 23/29] bitmap: add atomic set functions

2015-05-27 Thread Fam Zheng
On Tue, 05/26 18:54, Paolo Bonzini wrote: > From: Stefan Hajnoczi > > Use atomic_or() for atomic bitmaps where several threads may set bits at > the same time. This avoids the race condition between threads loading > an element, bitwise ORing, and then storing the element. > > When setting all

Re: [Qemu-devel] [PATCH v2] util/hbitmap: Add an API to reset all set bits in hbitmap

2015-05-27 Thread Wen Congyang
Hi, Paolo, Kevin Who will take this patch? Thanks Wen Congyang On 05/22/2015 09:29 AM, Wen Congyang wrote: > The function bdrv_clear_dirty_bitmap() is updated to use > faster hbitmap_reset_all() call. > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > A

Re: [Qemu-devel] [PATCH v3 24/29] bitmap: add atomic test and clear

2015-05-27 Thread Fam Zheng
On Tue, 05/26 18:55, Paolo Bonzini wrote: > From: Stefan Hajnoczi > > The new bitmap_test_and_clear_atomic() function clears a range and > returns whether or not the bits were set. > > Signed-off-by: Stefan Hajnoczi > Message-Id: <1417519399-3166-3-git-send-email-stefa...@redhat.com> > [Test be

Re: [Qemu-devel] [PATCH v9 02/24] hw/arm/virt: Move common definitions to virt.h

2015-05-27 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Move some common definitions to virt.h. These will be used by > generating ACPI tables. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée > --- > hw/arm/virt.c | 21 +-- > include/hw

Re: [Qemu-devel] [PATCH v2 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-27 Thread Markus Armbruster
Bandan Das writes: > There's too much going on in monitor_parse_command(). > Split up the arguments parsing bits into a separate function > monitor_parse_arguments(). Let the original function check for > command validity and sub-commands if any and return data (*cmd) > that the newly introduced

Re: [Qemu-devel] [PATCH v2 2/2] monitor: suggest running "help" for command errors

2015-05-27 Thread Markus Armbruster
Bandan Das writes: > When a command fails due to incorrect syntax or input, > suggest using the "help" command to get more information > about the command. This is only applicable for HMP. > > Before: > (qemu) drive_add usb_flash_drive > drive_add: string expected > After: > (qemu) drive_add usb_

Re: [Qemu-devel] [PATCH v9 03/24] hw/arm/virt: Record PCIe ranges in MemMapEntry array

2015-05-27 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > To generate ACPI table for PCIe controller, we need the base and size of > the PCIe ranges. Record these ranges in MemMapEntry array, then we could > share and use them for generating ACPI table. > > Signed-off-by: Shannon Zhao > Signed-off-by: Sha

Re: [Qemu-devel] [PATCH v3 26/29] migration: move dirty bitmap sync to ram_addr.h

2015-05-27 Thread Fam Zheng
On Tue, 05/26 18:55, Paolo Bonzini wrote: > From: Stefan Hajnoczi > > The dirty memory bitmap is managed by ram_addr.h and copied to > migration_bitmap[] periodically during live migration. > > Move the code to sync the bitmap to ram_addr.h where related code lives. > > Signed-off-by: Stefan Ha

Re: [Qemu-devel] [PATCH v9 08/24] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers

2015-05-27 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > In the case of mach virt, it is used to set the Hardware Reduced bit > and enable PSCI SMP booting through HVC. So ignore FACS and FADT > points to DSDT. > > Update the header definitions for FADT taking into account the new > additions of ACPI v5.1

[Qemu-devel] [PATCH] virtio-pci: don't try to mask or unmask vqs without notifiers

2015-05-27 Thread Jason Wang
We should validate the vq index against nvqs_with_notifiers. Otherwise we may try to mask or unmask vector for vqs without notifiers (e.g control vq). This will lead qemu abort on kvm_irqchip_commit_routes() when trying to boot win8.1 guest. Fixes 851c2a75a6e80c8aa5e713864d98cfb512e7229b ("virtio-

Re: [Qemu-devel] [PATCH v9 08/24] hw/arm/virt-acpi-build: Generate FADT table and update ACPI headers

2015-05-27 Thread Shannon Zhao
On 2015/5/27 16:25, Alex Bennée wrote: > > Shannon Zhao writes: > >> From: Shannon Zhao >> >> In the case of mach virt, it is used to set the Hardware Reduced bit >> and enable PSCI SMP booting through HVC. So ignore FACS and FADT >> points to DSDT. >> >> Update the header definitions for FAD

Re: [Qemu-devel] [PATCH v9 23/24] ACPI: split CONFIG_ACPI into 4 pieces

2015-05-27 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > As core.c, piix4.c, ich9.c and pcihp.c are for x86, add CONFIG_ACPI_X86 > to make it only for x86. ARM doesn't support cpu and memory hotplug, add > CONFIG_ACPI_CPU_HOTPLUG and CONFIG_ACPI_MEMORY_HOTPLUG to exclude them > for target-arm. > > Signed-

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Jason Wang
On 05/27/2015 02:26 PM, Pankaj Gupta wrote: > Ping. > > Can I get any suggestions on this patch. > > Best regards, > Pankaj > >> vhostforce was added to enable vhost when >> guest don't have MSI-X support. >> Now, we have scenarios like DPDK in Guest which dont use >> interrupts and still use

Re: [Qemu-devel] [PATCH v9 03/24] hw/arm/virt: Record PCIe ranges in MemMapEntry array

2015-05-27 Thread Shannon Zhao
On 2015/5/27 16:17, Alex Bennée wrote: > > Shannon Zhao writes: > >> From: Shannon Zhao >> >> To generate ACPI table for PCIe controller, we need the base and size of >> the PCIe ranges. Record these ranges in MemMapEntry array, then we could >> share and use them for generating ACPI table. >

[Qemu-devel] [RESEND PATCH v12 1/4] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2015-05-27 Thread Eric Auger
This new C module will be used by ARM machine files to generate platform bus node and their dynamic sysbus device tree nodes. Dynamic sysbus device node addition is done in a machine init done notifier. arm_register_platform_bus_fdt_creator does the registration of this latter and is supposed to b

[Qemu-devel] [RESEND PATCH v12 0/4] machvirt dynamic sysbus device instantiation

2015-05-27 Thread Eric Auger
This patch series enables machvirt to dynamically instantiate sysbus devices from command line (using -device option). All those sysbus devices are plugged onto a platform bus. This latter device is instantiated in machvirt and takes care of the binding of children sysbus devices on a machine init

[Qemu-devel] [RESEND PATCH v12 2/4] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-05-27 Thread Eric Auger
Device tree nodes for the platform bus and its children dynamic sysbus devices are added in a machine init done notifier. To load the dtb once, after those latter nodes are built and before ROM freeze, the actual arm_load_kernel existing code is moved into a notifier notify function, arm_load_kerne

[Qemu-devel] [RESEND PATCH v12 3/4] hw/arm/virt: add dynamic sysbus device support

2015-05-27 Thread Eric Auger
Allows sysbus devices to be instantiated from command line by using -device option. Machvirt creates a platform bus at init. The dynamic sysbus devices are attached to this platform bus device. The platform bus device registers a machine init done notifier whose role will be to bind the dynamic sy

[Qemu-devel] [RESEND PATCH v12 4/4] hw/arm/virt: change indentation in a15memmap

2015-05-27 Thread Eric Auger
Re-indent in a15memmap after VIRT_PLATFORM_BUS introduction Signed-off-by: Eric Auger Reviewed-by: Alex Bennée --- v11 -> v12: - Add Alex R-b --- hw/arm/virt.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

Re: [Qemu-devel] [RFC 0/5] Slow-path for atomic instruction translation

2015-05-27 Thread Alex Bennée
alvise rigo writes: > I'm going to respin these patches soon, I've found some issues that > I'm addressing now. Thanks, please feel free to add me to your CC list. > > Thank you for your feedback, > alvise > > On Tue, May 26, 2015 at 11:51 PM, Emilio G. Cota wrote: >> On Mon, May 11, 2015 at

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type "device IO"

2015-05-27 Thread Kevin Wolf
Am 26.05.2015 um 16:24 hat Max Reitz geschrieben: > On 26.05.2015 16:22, Kevin Wolf wrote: > >Am 21.05.2015 um 08:42 hat Fam Zheng geschrieben: > >>It blocks device IO. > >What I'm missing here is a description of the case that it protects > >against. Blocking device I/O doesn't sound like a valid

[Qemu-devel] [PATCH v16 1/9] hw/vfio/platform: vfio-platform skeleton

2015-05-27 Thread Eric Auger
Minimal VFIO platform implementation supporting register space user mapping but not IRQ assignment. Signed-off-by: Kim Phillips Signed-off-by: Eric Auger Tested-by: Vikram Sethi --- v15 -> v16: - added Vikram's T-b v14 -> v15: - vfio_platform_compute_needs_reset now returns true while vfio_

[Qemu-devel] [PATCH v16 5/9] kvm: rename kvm_irqchip_[add, remove]_irqfd_notifier with gsi suffix

2015-05-27 Thread Eric Auger
Anticipating for the introduction of new add/remove functions taking a qemu_irq parameter, let's rename existing ones with a gsi suffix. Signed-off-by: Eric Auger Tested-by: Vikram Sethi --- v15 -> v16: - added Vikram's T-b - resolve rebase conflict in kvm.h --- hw/s390x/virtio-ccw.c | 8 +++

[Qemu-devel] [PATCH v16 2/9] hw/vfio/platform: add irq assignment

2015-05-27 Thread Eric Auger
This patch adds the code requested to assign interrupts to a guest. The interrupts are mediated through user handled eventfds only. Signed-off-by: Eric Auger Tested-by: Vikram Sethi --- v15 -> v16: - added Vikram's T-b v13 -> v14: - remove virtualID field in header v12 -> v13: - start user-si

[Qemu-devel] [PATCH v16 9/9] hw/vfio/platform: add irqfd support

2015-05-27 Thread Eric Auger
This patch aims at optimizing IRQ handling using irqfd framework. Instead of handling the eventfds on user-side they are handled on kernel side using - the KVM irqfd framework, - the VFIO driver virqfd framework. the virtual IRQ completion is trapped at interrupt controller This removes the need

[Qemu-devel] [PATCH v16 3/9] hw/vfio/platform: calxeda xgmac device

2015-05-27 Thread Eric Auger
The platform device class has become abstract. This patch introduces a calxeda xgmac device that derives from it. Signed-off-by: Eric Auger Reviewed-by: Alex Bennée --- v15 -> v16: - added Vikram's T-b v10 -> v11: - add Alex Reviewed-by - move virt modifications in a separate patch v8 -> v9:

[Qemu-devel] [PATCH v16 8/9] sysbus: add irq_routing_notifier

2015-05-27 Thread Eric Auger
Add a new connect_irq_notifier notifier in the SysBusDeviceClass. This notifier, if populated, is called after sysbus_connect_irq. This mechanism is used to setup VFIO signaling once VFIO platform devices get attached to their platform bus, on a machine init done notifier. Signed-off-by: Eric Aug

[Qemu-devel] [PATCH v16 0/9] KVM platform device passthrough

2015-05-27 Thread Eric Auger
This series aims at enabling KVM platform device passthrough. On kernel side, the vfio platform driver is needed, available from 4.1-rc1 onwards. This series now only relies on the following QEMU series, for dynamic instantiation of the VFIO platform device from qemu command line: [1] [PATCH v12

[Qemu-devel] [PATCH v16 6/9] kvm-all.c: add qemu_irq/gsi hash table and utility routines

2015-05-27 Thread Eric Auger
VFIO platform device needs to setup irqfd but it does not know the gsi corresponding to the device qemu_irq. This series proposes to store a hash table in kvm_state using the qemu_irq as key and the gsi as a value. kvm_irqchip_set_qemuirq_gsi allows to insert such a pair. The interrupt controller

[Qemu-devel] [PATCH v16 4/9] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-05-27 Thread Eric Auger
This patch allows the instantiation of the vfio-calxeda-xgmac device from the QEMU command line (-device vfio-calxeda-xgmac,host=""). A specialized device tree node is created for the guest, containing compat, dma-coherent, reg and interrupts properties. Signed-off-by: Eric Auger --- v15 -> v16

[Qemu-devel] [PATCH v16 7/9] intc: arm_gic_kvm: set the qemu_irq/gsi mapping

2015-05-27 Thread Eric Auger
The arm_gic_kvm now calls kvm_irqchip_set_qemuirq_gsi to build the hash table storing qemu_irq/gsi mappings. From that point on irqfd can be setup directly from the qemu_irq using kvm_irqchip_add_irqfd_notifier. Signed-off-by: Eric Auger Tested-by: Vikram Sethi --- v15 -> v16: - added Vikram's

Re: [Qemu-devel] [PATCH v5 2/3] softmmu: Add probe_write()

2015-05-27 Thread Yongbok Kim
On 26/05/2015 18:33, Richard Henderson wrote: > On 05/26/2015 09:53 AM, Peter Maydell wrote: >> On 26 May 2015 at 17:49, Yongbok Kim wrote: >>> Add probe_write() forces a tlb_fill if the specified guest virtual >>> index isn't in the TCG softmmu TLB. >> >> Surely the point is not to fill the TLB b

Re: [Qemu-devel] [PATCH 4/4] movement: reduce include files

2015-05-27 Thread Juan Quintela
Eric Blake wrote: > On 05/08/2015 06:43 AM, Juan Quintela wrote: > > do you want s/movement/migration/ in the subject? > >> To make changes easier, with the copy, I maintained almost all include >> files. Now I remove the not needed ones on this patch. This complies > > s/not needed/unnecessary/

Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

2015-05-27 Thread Joao Luis Meloni Assirati
On 26-05-2015 10:58, Gerd Hoffmann wrote: This patch adds the two extra brazilian keys to the evdev keymap for X11. This patch gets the two keys going with the gtk and sdl1 UIs. With vnc (remote-viewer) only one of the two works correctly. Probably a client-side issue. Not investigated in deta

Re: [Qemu-devel] Announcing qboot, a minimal x86 firmware for QEMU

2015-05-27 Thread Paolo Bonzini
On 26/05/2015 23:25, Christopher Covington wrote: > On 05/25/2015 08:53 AM, Paolo Bonzini wrote: >> >> On 22/05/2015 13:12, Daniel P. Berrange wrote: >>> In >>> particular I don't see why we need to have a SATA controller and ISA/LPC >>> bridge in every virt machine - root PCI bus only should be

Re: [Qemu-devel] [PATCH] ich9: initialise RCBA register through LPC interface

2015-05-27 Thread Paolo Bonzini
On 27/05/2015 02:28, Paulo Alcantara wrote: > This patch initialises root complex register block BAR in order to > support TCO watchdog emulation features on QEMU. > > Signed-off-by: Paulo Alcantara > --- > src/fw/dev-q35.h | 3 +++ > src/fw/pciinit.c | 4 > 2 files changed, 7 insertions(

Re: [Qemu-devel] Announcing qboot, a minimal x86 firmware for QEMU

2015-05-27 Thread Avi Kivity
On 05/27/2015 12:30 PM, Paolo Bonzini wrote: On 26/05/2015 23:25, Christopher Covington wrote: On 05/25/2015 08:53 AM, Paolo Bonzini wrote: On 22/05/2015 13:12, Daniel P. Berrange wrote: In particular I don't see why we need to have a SATA controller and ISA/LPC bridge in every virt machine

Re: [Qemu-devel] [RFC PATCH 0/4] aio: Don't poll ioeventfd in nested aio_poll()

2015-05-27 Thread Paolo Bonzini
On 27/05/2015 09:19, Fam Zheng wrote: > This series looks at the other side of the broken "qmp transaction" problem > with dataplane [1] - the event loop. > > Before, an ioeventfd of a non-dataplane device is registered via > qemu_set_fd_handler, which is only polled directly by main_loop_wait()

Re: [Qemu-devel] [PATCH v3 23/29] bitmap: add atomic set functions

2015-05-27 Thread Paolo Bonzini
On 27/05/2015 09:58, Fam Zheng wrote: > On Tue, 05/26 18:54, Paolo Bonzini wrote: >> From: Stefan Hajnoczi >> >> Use atomic_or() for atomic bitmaps where several threads may set bits at >> the same time. This avoids the race condition between threads loading >> an element, bitwise ORing, and th

Re: [Qemu-devel] [PATCH v9 00/24] Generate ACPI v5.1 tables and expose them to guest over fw_cfg on ARM

2015-05-27 Thread Igor Mammedov
On Mon, 25 May 2015 10:54:56 +0800 Shannon Zhao wrote: > From: Shannon Zhao ... > Shannon Zhao (24): > hw/acpi/aml-build: Make enum values to be upper case to match coding > style ... > hw/acpi/aml-build: Add aml_memory32_fixed() term > hw/acpi/aml-build: Add aml_interrupt() term ... >

[Qemu-devel] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

2015-05-27 Thread Alberto Garcia
Changing the current ordering saves 8 bytes per cache entry in x86_64. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index a215f5

[Qemu-devel] [PATCH v3 0/3] Clean unused entries in the qcow2 L2/refcount cache

2015-05-27 Thread Alberto Garcia
v3: - Add 'cache-clean-interval' field to ImageInfoSpecificQCow2. v2: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg05316.html - Clarify that the block-commit mentioned in the first patch refers to the HMP commit command. - Check the value of cache_clean_interval and cast it according

[Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time

2015-05-27 Thread Alberto Garcia
This adds a new 'cache-clean-interval' option that cleans all qcow2 cache entries that haven't been used in a certain interval, given in seconds. This allows setting a large L2 cache size so it can handle scenarios with lots of I/O and at the same time use little memory during periods of inactivit

[Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()

2015-05-27 Thread Alberto Garcia
After having emptied the cache, the data in the cache tables is no longer useful, so we can tell the kernel that we are done with it. In Linux this frees the resources associated with it. The effect of this can be seen in the HMP commit operation: it moves data from the top to the base image (and

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type "device IO"

2015-05-27 Thread Paolo Bonzini
On 27/05/2015 11:07, Kevin Wolf wrote: > This is the first part of what's troubling me with this series, as it > makes me doubtful if op blockers are the right tool to implement what > the commit message says (block device I/O). This is "are we doing the > thing right?" > > The second part shoul

[Qemu-devel] [PULL 05/17] net/dump: Improve -net/host_net_add dump error reporting

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster When -net dump fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net dump,id=foo,file=/eperm qemu-system-x86_64: -net dump,id=foo,file=/eperm: -net dump: can't open /eperm qemu-system-x86_64: -net dump,id=foo,file=

[Qemu-devel] [PULL 00/17] Net patches

2015-05-27 Thread Stefan Hajnoczi
The following changes since commit 0915aed5842bd4dbe396b92d4f3b846ae29ad663: Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2015-05-26 11:31:03 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you

[Qemu-devel] [PULL 01/17] net: Change help text to list -netdev instead of -net by default

2015-05-27 Thread Stefan Hajnoczi
From: Thomas Huth Looking at the output of "qemu-system-xxx -help", you easily get the impression that "-net" is the preferred way instead of "-netdev" to specify host network interface, since the "-net" option is omnipresent but the "-netdev" option is only listed as a one-liner at the end. This

[Qemu-devel] [PULL 07/17] tap: Improve -netdev/netdev_add/-net/... bridge error reporting

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster When -netdev bridge fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -netdev bridge,id=foo failed to launch bridge helper qemu-system-x86_64: -netdev bridge,id=foo: Device 'bridge' could not be initialized The fir

[Qemu-devel] [PULL 04/17] net: Improve -net nic error reporting

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster When -net nic fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net nic,netdev=nonexistent qemu-system-x86_64: -net nic,netdev=nonexistent: netdev 'nonexistent' not found qemu-system-x86_64: -net nic,netdev=nonexis

[Qemu-devel] [PULL 02/17] net: Improve error message for -net hubport a bit

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Type "hubport" is valid only with -netdev. Unfortunately, that's detected late and the error message doesn't explain why: $ qemu-system-i386 -net hubport,id=foo,hubid=0 qemu-system-i386: -net hubport,id=foo,hubid=0: Device 'hubport' could not be initialized Imp

[Qemu-devel] [PULL 06/17] tap: net_tap_fd_init() can't fail, drop dead error handling

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-6-git-send-email-arm...@redhat.com Signed-off-by: Stefan Hajnoczi --- net/tap.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/net/tap.c b/net/tap.c

[Qemu-devel] [PULL 03/17] net: Permit incremental conversion of init functions to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Error reporting for netdev_add is broken: the net_client_init_fun[] report the actual errors with (at best) error_report(), and their caller net_client_init1() makes up a generic error on top. For command line and HMP, this produces an mildly ugly error cascade. In QMP,

[Qemu-devel] [PULL 10/17] tap: Convert launch_script() to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Fixes inappropriate use of stderr in monitor command handler. While there, improve the messages some. [Fixed Error **err -> Error *err local variable that broke the build. --Stefan] Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-1

[Qemu-devel] [PULL 11/17] tap: Permit incremental conversion of tap_open() to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Convert the trivial ones immediately: tap-aix and tap-haiku. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-11-git-send-email-arm...@redhat.com Signed-off-by: Stefan Hajnoczi --- net/tap-aix.c | 4 ++-- net/tap-bsd.c | 6

[Qemu-devel] [PULL 08/17] tap: Convert tap_set_sndbuf() to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-8-git-send-email-arm...@redhat.com Signed-off-by: Stefan Hajnoczi --- net/tap-aix.c | 3 +-- net/tap-bsd.c | 3 +-- net/tap-haiku.c | 3 +-- net/tap-linux.c | 6 ++ net

[Qemu-devel] [PULL 09/17] tap: Convert net_init_tap_one() to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster [Dropped %s from "tap: open vhost char device failed: %s" since error_setg_errno() already prints a human-readable error string and there is no format string argument. --Stefan] Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-9-git-s

[Qemu-devel] [PULL 14/17] tap-solaris: Convert tap_open() to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Fixes inappropriate use of syslog(). Not fixed: leaks on error paths, suspicious non-fatal errors. FIXMEs added instead. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-14-git-send-email-arm...@redhat.com Signed-off-by: Stefan Hajn

[Qemu-devel] [PULL 12/17] tap-linux: Convert tap_open() to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-12-git-send-email-arm...@redhat.com Signed-off-by: Stefan Hajnoczi --- net/tap-linux.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/tap-lin

[Qemu-devel] [PULL 16/17] tap: Improve -netdev/netdev_add/-net/... tap error reporting

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster When -netdev tap fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -netdev tap,id=foo qemu-system-x86_64: -netdev tap,id=foo: could not configure /dev/net/tun: Operation not permitted qemu-system-x86_64: -netdev tap

Re: [Qemu-devel] [PATCH v9 16/24] hw/acpi/aml-build: Add aml_or() term

2015-05-27 Thread Michael S. Tsirkin
On Mon, May 25, 2015 at 10:55:12AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin > --- > hw/acpi/aml-build.c | 10 ++ > include/hw/acpi/aml-build.h |

[Qemu-devel] [PULL 13/17] tap-bsd: Convert tap_open() to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Fixes inappropriate use of stderr in monitor command handler. While there, improve some of the messages a bit. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-13-git-send-email-arm...@redhat.com Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PULL 15/17] tap: Finish conversion of tap_open() to Error

2015-05-27 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1431691143-1015-15-git-send-email-arm...@redhat.com Signed-off-by: Stefan Hajnoczi --- net/tap.c | 4 1 file changed, 4 deletions(-) diff --git a/net/tap.c b/net/tap.c index 362df42..c1ee4f1 100

Re: [Qemu-devel] [PATCH v9 14/24] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec

2015-05-27 Thread Michael S. Tsirkin
On Mon, May 25, 2015 at 10:55:10AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > According to ACPI spec, DefBuffer can take two parameters: BufferSize > and ByteList. Make it consistent with the spec. Uninitialized buffer > could be requested by passing ByteList as NULL to reserve space. >

Re: [Qemu-devel] [PATCH v9 19/24] hw/acpi/aml-build: Add aml_create_dword_field() term

2015-05-27 Thread Michael S. Tsirkin
On Mon, May 25, 2015 at 10:55:15AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Alex Bennée > Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin > --- > hw/acpi/aml-build.c | 11 +++ >

Re: [Qemu-devel] [PATCH v9 20/24] hw/acpi/aml-build: Add aml_dword_io() term

2015-05-27 Thread Michael S. Tsirkin
On Mon, May 25, 2015 at 10:55:16AM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Alex Bennée > Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin > --- > hw/acpi/aml-build.c | 18 +++

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type "device IO"

2015-05-27 Thread Kevin Wolf
Am 27.05.2015 um 11:50 hat Paolo Bonzini geschrieben: > > > On 27/05/2015 11:07, Kevin Wolf wrote: > > This is the first part of what's troubling me with this series, as it > > makes me doubtful if op blockers are the right tool to implement what > > the commit message says (block device I/O). Th

  1   2   3   4   >