From: Mark Cave-Ayland
This considerably helps simplify the complexity of the macio read routines and
by switching macio CDROM accesses to use the new code, fixes the issue with
the CDROM device being detected intermittently by Darwin/OS X.
[Maintainer edit: printf format codes adjusted for 32/6
Like a makefile, try to skip tests if we know they have already been
executed using the current set of external dependencies.
If a user passes the -ts option to ./check, if a test or its output
or its dependencies (qemu, qemu-nbd, qemu-io, qemu-img,
socket-scm-helper) have been modified, the test
Split the help text to highlight the groups of options
a little better, carving out a clear "format" and
"protocols" section.
Signed-off-by: John Snow
---
tests/qemu-iotests/common | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iot
On Thu, 14 May 2015 19:31:19 +0200 Andrea Arcangeli wrote:
> If the rwsem starves writers it wasn't strictly a bug but lockdep
> doesn't like it and this avoids depending on lowlevel implementation
> details of the lock.
>
> ...
>
> @@ -229,13 +246,33 @@ static __always_inline ssize_t __mcopy_at
This patchset is a little off the beaten path, but:
Add the ability to skip tests that have already been run whose external
dependencies have remained unchanged since the last test run.
This is useful for, say, re-running a test set to see if a failure was
a one-off or is reproducible by just re-
If you are running out-of-tree, the -x option to exclude
a certain iotest is broken.
Replace porcelain usage of ls with a sturdier grep command.
Signed-off-by: John Snow
---
tests/qemu-iotests/common | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common
Add a few external dependency groups to the iotests groups list,
such as "qemu", "nbd", and "scm".
This will assist us in knowing which tests need to be re-run
when those dependencies are updated, or by helping us to avoid
tests that we know are broken for a certain file.
qemu-img and qemu-io are
On 05/21/2015 09:40 PM, Fam Zheng wrote:
> If guest discards a source cluster, mirroring with bdrv_aio_readv is overkill.
> Some protocols do zero upon discard, where it's best to use
> bdrv_aio_write_zeroes, otherwise, bdrv_aio_discard will be enough.
>
> Signed-off-by: Fam Zheng
> ---
> block/
On 05/21/2015 09:40 PM, Fam Zheng wrote:
> Unsetting dirty globally with discard is not very correct. The discard may
> zero
> out sectors (depending on can_write_zeroes_with_unmap), we should replicate
> this change to destinition side to make sure that the guest sees the same
> data.
s/destini
Am 22.05.2015 um 18:56 schrieb Eduardo Habkost:
> On Fri, May 22, 2015 at 03:44:53PM +0800, Chen Fan wrote:
>> static void x86_cpu_apic_realize(X86CPU *cpu, Error **errp)
>> @@ -2801,8 +2793,6 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
>> **errp)
>> }
>>
>> #ifndef CONFIG_USER_
On 05/22/2015 02:17 PM, John Snow wrote:
> If you are running out-of-tree, the -x option to exclude
> a certain iotest is broken.
>
> Replace porcelain usage of ls with a sturdier grep command.
>
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/common | 3 ++-
> 1 file changed, 2 insertion
On 05/22/2015 04:31 PM, Eric Blake wrote:
> On 05/22/2015 02:17 PM, John Snow wrote:
>> If you are running out-of-tree, the -x option to exclude a
>> certain iotest is broken.
>>
>> Replace porcelain usage of ls with a sturdier grep command.
>>
>> Signed-off-by: John Snow ---
>> tests/qemu-io
Where it makes sense, use the new faster primitives.
For generally small reads/writes such as for the PRDT
and FIS packets, stick with the more wasteful but
easier to debug memread/memwrite.
For ahci-test (before migration tests):
With this patch:
real0m3.675s
user0m2.582s
sys 0m1.718s
Instead of converting each byte one-at-a-time and then sending each byte
over the wire, use sprintf() to pre-compute all of the hex nibs into a
single buffer, then send the entire buffer all at once.
This gives a moderate speed boost to memread() and memwrite() functions.
Signed-off-by: John Snow
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> The asynchronous monitor command interface goes back to commit 940cc30
> (Jan 2010). Added a third case to command execution. The hope back
> then according to the commit message was that all commands get
> converted to the asynchronous interface
There's a more serious failure with i386 allmodconfig:
fs/userfaultfd.c:145:2: note: in expansion of macro 'BUILD_BUG_ON'
BUILD_BUG_ON(sizeof(struct uffd_msg) != 32);
I'm surprised the feature is even reachable on i386 builds?
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
Commit message is sparse; I would have mentioned [1] and [2].
> monitor.c | 40 +++-
> 1 file changed, 11 insertions(+), 29 deletions(-)
>
>
> -static void handler_au
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Protocol must be spice, vnc isn't implemented. Fix up documentation.
>
> Attempts to use vnc or any other unknown protocol yield the misleading
> error message "Invalid parameter 'protocol'". Improve it to
> "Parameter 'protocol' expects spice".
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> hmp-commands.hx | 3 +--
> hmp.c| 17 +
> hmp.h| 1 +
> monitor.c| 42 ++
> qapi-schema.json | 20
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> All QMP commands use the "new" handler interface (mhandler.cmd_new).
> Most HMP commands still use the traditional interface (mhandler.cmd),
> but a few use the "new" one. Complicates handle_user_command() for no
> gain, so I'm converting these to
The goal of stateless, and thus this change, is to separate OS configuration
from system administrator configuration. With this change we will read the
default configuration data from /usr/share/defaults/qemu, in the absence of
an overriding site administrator configuration in /etc/qemu.
A key adv
> 22.05.2015 13:01, Gerd Hoffmann wrote:
[...]
The solution appears to be trivial (see also some background
at http://blog.nielshorn.net/2011/03/qemu-and-brazilian-keyboards/ ),
but the problem is definitely still here.
This is the patch that works:
--- ui/x_keymap.c~
+++ ui/x_ke
On Sat, May 23, 2015 at 12:13 AM, Peter Maydell
wrote:
> On 22 May 2015 at 16:36, Jun Koi wrote:
> > In general, we would have timer & code execution run in parallel,
>
> No code has to actually run when there's an active timer;
> the event loop thread mostly sits blocked waiting for
> something
>> > Anyone having such a keyboard and willing to run some tests?
[...]
> (c) Then use 'input-events ' to get a input event log
> printed to the terminal. Type each missing key once.
>
> (d) Send me the log (with annotation which key is which).
There are two missing keys: / (which is also ?
On Fri, May 22, 2015 at 01:18:22PM -0700, Andrew Morton wrote:
> On Thu, 14 May 2015 19:31:19 +0200 Andrea Arcangeli
> wrote:
>
> > If the rwsem starves writers it wasn't strictly a bug but lockdep
> > doesn't like it and this avoids depending on lowlevel implementation
> > details of the lock.
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> All QMP commands use the "new" handler interface (mhandler.cmd_new).
> Most HMP commands still use the traditional interface (mhandler.cmd),
> but a few use the "new" one. Complicates handle_user_command() for no
> gain, so I'm converting these to
On 05/22/2015 09:42 AM, Ikey Doherty wrote:
meta-comment:
> 1.9.1
>
> -
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> All QMP commands use the "new" handler interface (mhandler.cmd_new).
> Most HMP commands still use the traditional interface (mhandler.cmd),
> but a few use the "new" one. Complicates handle_user_command() for no
> gain, so I'm converting these to
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 22 +-
> 1 file changed, 1 insertion(+), 21 deletions(-)
>
Goodbye! Nice knowing you! (For how many incomplete conversions we
have scattered throughout the tree, it's in
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 65
> ---
> 1 file changed, 33 insertions(+), 32 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 19 ++-
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> @@ -4948,27 +4948,27 @@ static QDict *qmp_check_input_obj(QObject *input_obj)
> }
> } els
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Move mon->error handling to its caller handle_qmp_command().
>
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redha
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index c732203..71ca03f 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -377,11 +377,6 @@ st
On 05/20/2015 05:27 AM, Stefan Hajnoczi wrote:
> On Tue, May 19, 2015 at 06:15:23PM -0400, John Snow wrote:
>> On 05/18/2015 11:45 AM, Stefan Hajnoczi wrote:
>>> On Mon, May 11, 2015 at 07:04:21PM -0400, John Snow wrote:
If we want to get at the job after the life of the job, we'll
need
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> The previous commits narrowed use of QError to handle_qmp_command()
> and its helpers monitor_protocol_emitter(), build_qmp_error_dict().
> Narrow it further to just the command handler call: instead of
> converting Error to QError throughout handl
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvir
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> ... to monitor_qmp_read(), monitor_qmp_event().
>
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 14 --
> 1 file changed, 4 insertions(+), 10 deletions(-)
Not a trivial rename based on diffstat, but...
>
> diff --git a/mon
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 05/22/2015 04:31 PM, Eric Blake wrote:
> On 05/22/2015 02:17 PM, John Snow wrote:
>> If you are running out-of-tree, the -x option to exclude a
>> certain iotest is broken.
>>
>> Replace porcelain usage of ls with a sturdier grep command.
>>
>
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> While there, rename its type as well, from MonitorControl to
> MonitorQMP.
>
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 35 ---
> 1 file changed, 16 insertions(+), 19 deletions(-)
>
> @@ -5255,14 +52
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Superfluous since commit 30f5041 removed it from HMP.
>
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 23 ---
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
Might be worth mentioning in the commit message that...
>
> -static inline int qmp_cmd_mode(const Monitor
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> include/monitor/monitor.h | 2 +-
> monitor.c | 6 --
> stubs/mon-is-qmp.c| 2 +-
> 3 files changed, 6 insertions(+), 4 deletions(-)
>
> +++ b/stubs/mon-is-qmp.c
> @@ -1,7 +1,
On 05/22/2015 05:36 AM, Markus Armbruster wrote:
> ... and change return type to bool.
>
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
See also my review on 16 about a usage in monitor_init().
Reviewed-by: Eric Blak
On 05/22/2015 06:26 PM, Nguyen Anh Quynh wrote:
On Sat, May 23, 2015 at 12:13 AM, Peter Maydell
mailto:peter.mayd...@linaro.org>> wrote:
On 22 May 2015 at 16:36, Jun Koi mailto:junkoi2...@gmail.com>> wrote:
> In general, we would have timer & code execution run in parallel,
No
On Thu, May 21, 2015 at 03:51:43PM +0200, Paolo Bonzini wrote:
> Some of you may have heard about the "Clear Containers" initiative from
> Intel, which couple KVM with various kernel tricks to create extremely
> lightweight virtual machines. The experimental Clear Containers setup
> requires only
On Fri, May 22, 2015 at 02:18:30PM -0700, Andrew Morton wrote:
>
> There's a more serious failure with i386 allmodconfig:
>
> fs/userfaultfd.c:145:2: note: in expansion of macro 'BUILD_BUG_ON'
> BUILD_BUG_ON(sizeof(struct uffd_msg) != 32);
>
> I'm surprised the feature is even reachable on i38
On 05/18/2015 08:53 AM, Catalin Marinas wrote:
> On Thu, May 14, 2015 at 02:46:44PM +0100, Andrew Jones wrote:
>> On Thu, May 14, 2015 at 01:05:09PM +0200, Christoffer Dall wrote:
>>> On Wed, May 13, 2015 at 01:31:52PM +0200, Andrew Jones wrote:
Provide a method to change normal, cacheable mem
On Fri, May 22, 2015 at 07:23:27PM -0400, Kevin O'Connor wrote:
> On Thu, May 21, 2015 at 03:51:43PM +0200, Paolo Bonzini wrote:
> > Some of you may have heard about the "Clear Containers" initiative from
> > Intel, which couple KVM with various kernel tricks to create extremely
> > lightweight vir
Public bug reported:
Dear Qemu,
Spice told me to report this over here.
Scientific Linux 6.6
$ uname -r
2.6.32-504.16.2.el6.x86_64
$ cat /etc/redhat-release
Scientific Linux release 6.6 (Carbon)
$ rpm -qa qemu\*
qemu-img-0.12.1.2-2.448.el6_6.3.x86_64
qemu-kvm-0.12.1.2-2.448.el6_6.3.x86_64
I
201 - 249 of 249 matches
Mail list logo
