Re: [Qemu-devel] [PATCH 1/1] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-05-20 Thread Amit Shah
On (Fri) 15 May 2015 [16:19:38], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > and use it in loadvm_state and ram_load. > > Where ever it's used, check the return and error if it failed. > > Minor: ram_load was using a 257 byte array for its string, the >maxim

Re: [Qemu-devel] [PATCH 0/4] Add section footers to detect corrupted migration streams

2015-05-20 Thread Amit Shah
On (Tue) 19 May 2015 [08:13:52], Eric Blake wrote: > On 05/19/2015 08:06 AM, Dr. David Alan Gilbert wrote: > > >> Does it let us detect a corrupted > >> stream earlier in the process? Or is the main benefit that it gives > >> better error messages at the point corruption is first detected? > > >

Re: [Qemu-devel] [PATCH 0/4] Add section footers to detect corrupted migration streams

2015-05-20 Thread Amit Shah
On (Tue) 19 May 2015 [12:29:49], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Badly formatted migration streams can go undetected or produce > misleading errors due to a lock of checking at the end of sections. s/lock/lack in patch 3 commit msg as well. Otherwise, l

Re: [Qemu-devel] [RFC v7 04/11] vfio: add check host bus reset is support or not

2015-05-20 Thread Chen Fan
On 05/20/2015 03:34 AM, Alex Williamson wrote: On Tue, 2015-05-19 at 12:42 +0800, Chen Fan wrote: when machine is done, we should check the all vfio devices whether support host bus reset, then when need virtual secondary bus reset, we should reset host bus. Signed-off-by: Chen Fan --- hw/v

Re: [Qemu-devel] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2

2015-05-20 Thread Paolo Bonzini
On 20/05/2015 08:38, Fam Zheng wrote: > On Wed, 05/20 08:26, Paolo Bonzini wrote: >> >> >> On 19/05/2015 17:02, Stefan Hajnoczi wrote: >>> 1. Convert everything like you converted qemu-nbd.c. This is a >>> conservative approach and we can be confident that behavior is >>> unchanged. >> >> So,

Re: [Qemu-devel] [PATCH v1 1/1] S390 pci infrastructure modeling

2015-05-20 Thread Paolo Bonzini
On 15/04/2015 10:04, Hong Bo Li wrote: > @@ -513,29 +541,12 @@ static int s390_pcihost_setup_msix(S390PCIBusDevice > *pbdev) > return 0; > } > > +/* this function is useless, just keep it to make the patch more > + readable. Without this function, the diff will mix these hotplug > +

Re: [Qemu-devel] [PATCH v1 1/1] S390 pci infrastructure modeling

2015-05-20 Thread Paolo Bonzini
On 12/05/2015 11:07, Cornelia Huck wrote: >>> This patch contains the actual interesting changes. >>> usage example: >>> -device s390-pcihost >>> -device vfio-pci,host=:00:00.0,id=vpci1 >>> -device zpci,fid=2,uid=5,pci_id=vpci1,id=zpci1 One possible alternative could be making each zpci device

Re: [Qemu-devel] [PATCH 0/4] qga: disk and volume info for Windows guest

2015-05-20 Thread Denis V. Lunev
On 02/05/15 13:13, Denis V. Lunev wrote: Functionality match with Linux. Patches 1 and 2 are very useful for consistent backups of Windows guests. Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Michael Roth ping

Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase

2015-05-20 Thread Kevin Wolf
Am 19.05.2015 um 22:57 hat Peter Maydell geschrieben: > On 19 May 2015 at 21:52, John Snow wrote: > > Hmm, I think this is not purely derived state because the flags are not > > necessarily sufficient for regenerating that state. > > Yeah, if there's genuinely an underlying state machine that's >

[Qemu-devel] [Bug 1456804] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed.

2015-05-20 Thread Jason Wang
>From the trace, looks like the driver is trying to assign config vq (2) an vector(2). This is interesting. I try to reproduce but fail. (The only difference is my guest does not have any vfio and ovmf was not used). Can you reproduce it without ovmf and vfio? Thanks -- You received this bug n

Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase

2015-05-20 Thread Peter Maydell
On 20 May 2015 at 08:54, Kevin Wolf wrote: > Am 19.05.2015 um 22:57 hat Peter Maydell geschrieben: >> Yeah, if there's genuinely an underlying state machine that's >> not completely visible in registers you need to actually model it. >> You should probably then model the register bits by calculati

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-20 Thread Leon Alrae
On 18/05/2015 17:18, Peter Maydell wrote: > On 8 May 2015 at 12:41, Leon Alrae wrote: >> Add new "arg" sub-argument to the --semihosting-config allowing to pass >> multiple input argument separately. It is required for example by UHI >> semihosting to construct argc and argv. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH 7/8] fdc: Fix MSR.RQM flag

2015-05-20 Thread Kevin Wolf
Am 19.05.2015 um 22:40 hat John Snow geschrieben: > > > On 05/19/2015 11:36 AM, Kevin Wolf wrote: > > The RQM bit in MSR should be set whenever the guest is supposed to > > access the FIFO, and it should be cleared in all other cases. This is > > important so the guest can't continue writing/read

Re: [Qemu-devel] [v7][PATCH 03/10] piix: create host bridge to passthrough

2015-05-20 Thread Chen, Tiejun
On 2015/3/26 16:15, Michael S. Tsirkin wrote: On Thu, Mar 26, 2015 at 03:57:18PM +0800, Chen, Tiejun wrote: Michael and Gerd, I don't see any more comments for this revision, so what's next that I should do? Thanks Tiejun On 2015/3/19 9:01, Chen, Tiejun wrote: It's only been a week, and we

Re: [Qemu-devel] [PATCH 5/8] fdc: Code cleanup in fdctrl_write_data()

2015-05-20 Thread Kevin Wolf
Am 19.05.2015 um 22:40 hat John Snow geschrieben: > > > On 05/19/2015 11:35 AM, Kevin Wolf wrote: > > Factor out a few common lines of code, reformat, improve comments. > > > > Signed-off-by: Kevin Wolf > > --- > > hw/block/fdc.c | 62 > > +++---

Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-20 Thread Markus Armbruster
John Snow writes: > On 05/12/2015 04:06 PM, Eric Blake wrote: >> On 05/12/2015 01:53 PM, John Snow wrote: >>> Bitmaps can be in a handful of different states with potentially >>> more to come as we tool around with migration and persistence patches. >>> >>> Instead of having a bunch of boolean fi

Re: [Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data()

2015-05-20 Thread Kevin Wolf
Am 19.05.2015 um 22:40 hat John Snow geschrieben: > > > On 05/19/2015 11:36 AM, Kevin Wolf wrote: > > This commit makes similar improvements as have already been made to the > > write function: Instead of relying on a flag in the MSR to distinguish > > controller phases, use the explicit phase th

Re: [Qemu-devel] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2

2015-05-20 Thread Stefan Hajnoczi
On Wed, May 20, 2015 at 8:39 AM, Paolo Bonzini wrote: > On 20/05/2015 08:38, Fam Zheng wrote: >> On Wed, 05/20 08:26, Paolo Bonzini wrote: >>> >>> >>> On 19/05/2015 17:02, Stefan Hajnoczi wrote: 1. Convert everything like you converted qemu-nbd.c. This is a conservative approach and we

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-20 Thread Liviu Ionescu
> On 20 May 2015, at 11:11, Leon Alrae wrote: > > like "If both are specified, -kernel/-append are ignored (-kernel is > used to load an image, but the path won't be passed to semihosting)" ... > We could initialize semihosting.argv[0] with -kernel here you have a small contradiction, both in

[Qemu-devel] [PULL 2/5] ui: remove check for failure of qemu_acl_init()

2015-05-20 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The qemu_acl_init() function has long since stopped being able to return NULL, since g_malloc will abort on OOM. As such the checks for NULL were unreachable code. Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake Signed-off-by: Gerd Hoffmann --- ui/vnc.c |

[Qemu-devel] [PULL 3/5] vnc: Don't assert if opening unix socket fails

2015-05-20 Thread Gerd Hoffmann
From: Cole Robinson Reproducer: $ qemu-system-x86_64 -display vnc=unix:/root/i-cant-access-you.sock qemu-system-x86_64: iohandler.c:60: qemu_set_fd_handler2: Assertion `fd >= 0' failed. Aborted (core dumped) Signed-off-by: Cole Robinson Reviewed-by: Eric Blake Signed-off-by: Gerd Hoffmann -

[Qemu-devel] [PULL 0/5] vnc patch queue

2015-05-20 Thread Gerd Hoffmann
0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-vnc-20150520-1 for you to fetch changes up to 0ef705a2653f09c15e44a644a98b6febc761431e: qemu-sockets: Report explicit error if unlink fails (2015-05-20 10:23

[Qemu-devel] [PULL 4/5] vnc: Tweak error when init fails

2015-05-20 Thread Gerd Hoffmann
From: Cole Robinson Before: qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC server on `(null)': Failed to bind socket to /root/foo.sock: Permission denied After: qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC server: Failed to bind socket to

[Qemu-devel] [PULL 5/5] qemu-sockets: Report explicit error if unlink fails

2015-05-20 Thread Gerd Hoffmann
From: Cole Robinson Consider this case: $ ls -ld ~/root-owned/ drwx--x--x. 2 root root 4096 Apr 29 12:55 /home/crobinso/root-owned/ $ ls -l ~/root-owned/foo.sock -rwxrwxrwx. 1 crobinso crobinso 0 Apr 29 12:55 /home/crobinso/root-owned/foo.sock $ qemu-system-x86_64 -vnc unix:~/root-owned/foo.so

[Qemu-devel] [PULL 1/5] Strip brackets from vnc host

2015-05-20 Thread Gerd Hoffmann
From: Ján Tomko Commit v2.2.0-1530-ge556032 vnc: switch to inet_listen_opts bypassed the use of inet_parse in inet_listen, making literal IPv6 addresses enclosed in brackets fail: qemu-kvm: -vnc [::1]:0: Failed to start VNC server on `(null)': address resolution failed for [::1]:5900: Name or se

Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase

2015-05-20 Thread Kevin Wolf
Am 20.05.2015 um 10:06 hat Peter Maydell geschrieben: > On 20 May 2015 at 08:54, Kevin Wolf wrote: > > Am 19.05.2015 um 22:57 hat Peter Maydell geschrieben: > >> Yeah, if there's genuinely an underlying state machine that's > >> not completely visible in registers you need to actually model it. >

Re: [Qemu-devel] [PATCH 1/4] Merge section header writing

2015-05-20 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The header writing for device sections is open coded in > a few places, merge it into one. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-20 Thread Leon Alrae
On 20/05/2015 09:30, Liviu Ionescu wrote: > >> On 20 May 2015, at 11:11, Leon Alrae wrote: >> >> like "If both are specified, -kernel/-append are ignored (-kernel is >> used to load an image, but the path won't be passed to semihosting)" > ... >> We could initialize semihosting.argv[0] with -ker

Re: [Qemu-devel] [PATCH 2/4] Disable section footers on older machine types

2015-05-20 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The next patch adds section footers; but we don't want to > break migration compatibility so disable them on older > machine types > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela But Power pe

Re: [Qemu-devel] [PATCH 3/4] Add a protective section footer

2015-05-20 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Badly formatted migration streams can go undetected or produce > misleading errors due to a lock of checking at the end of sections. > In particular a section that adds an extra 0x00 at the end > causes what looks like a n

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-20 Thread Peter Maydell
On 20 May 2015 at 09:11, Leon Alrae wrote: > On 18/05/2015 17:18, Peter Maydell wrote: >> You need to say how this interacts with the -kernel/-append option >> (ie what happens if you specify both). > > I don't see any correlation between semihosting options and "-append" > which is described as "

Re: [Qemu-devel] [PATCH 0/4] Add section footers to detect corrupted migration streams

2015-05-20 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 05/19/2015 08:06 AM, Dr. David Alan Gilbert wrote: >> >> >> Does it let us detect a corrupted >> >> stream earlier in the process? Or is the main benefit that it gives >> >> better error messages at the point corrupt

Re: [Qemu-devel] [RFC] Can we convert UTC time to local time in Qemu

2015-05-20 Thread Daniel P. Berrange
On Wed, May 20, 2015 at 06:29:55AM +, Gonglei (Arei) wrote: > Hi, > > At present, Qemu use g_time_val_to_iso8601() to get the UTC added to > error_report() > (commit 5e2ac5191), TBH this way is very simply, we just need invoke standard > glib functions to > complete the job. > > But in the

[Qemu-devel] [PATCH 2/2] SMBIOS: Allow users to chose base board type

2015-05-20 Thread Michal Privoznik
So far we only mistakenly claimed support for selecting base board type. This patch finally implements it. There's an enum in SMBIOS specification that lays out all the possible values. Therefore, the type is taken as an integer of the corresponding string value. Signed-off-by: Michal Privoznik -

[Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a bool

2015-05-20 Thread Michal Privoznik
When going through code I realized, that the pc_init1() has this two arguments @pci_enabled and @kvmclock_enabled which despite used as booleans are of int type. Signed-off-by: Michal Privoznik --- hw/i386/pc_piix.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 0/2] Couple of SMBIOS fixes

2015-05-20 Thread Michal Privoznik
Well, strictly speaking the first is a code cleanup, the second one implements the feature we claimed to have but it wasn't implemented. Michal Privoznik (2): pc_init1: Don't misuse int for holding up a bool SMBIOS: Allow users to chose base board type hw/i386/pc_piix.c | 10 +- hw/i

Re: [Qemu-devel] migration network requirements

2015-05-20 Thread Dr. David Alan Gilbert
* Alexey Kardashevskiy (a...@ozlabs.ru) wrote: > Hi! > > Recent bugreports from our testers at IBM about failed migration across USA > (for example, from NY to TX) made me wonder - what are the actual basic > requirements/expectations for migration? Oh that's fun. > In what network is it normall

Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase

2015-05-20 Thread Peter Maydell
On 20 May 2015 at 09:43, Kevin Wolf wrote: > Am 20.05.2015 um 10:06 hat Peter Maydell geschrieben: >> That handles migration, which is good. But I still think that >> storing the same information in two places in the device >> state (phase field and the register fields) is error-prone. > > That's

Re: [Qemu-devel] [PATCH 2/2] SMBIOS: Allow users to chose base board type

2015-05-20 Thread Paolo Bonzini
On 20/05/2015 11:15, Michal Privoznik wrote: > So far we only mistakenly claimed support for selecting base > board type. This patch finally implements it. There's an enum in > SMBIOS specification that lays out all the possible values. > Therefore, the type is taken as an integer of the correspo

Re: [Qemu-devel] [RFC] Can we convert UTC time to local time in Qemu

2015-05-20 Thread Gonglei
On 2015/5/20 17:00, Daniel P. Berrange wrote: > On Wed, May 20, 2015 at 06:29:55AM +, Gonglei (Arei) wrote: >> Hi, >> >> At present, Qemu use g_time_val_to_iso8601() to get the UTC added to >> error_report() >> (commit 5e2ac5191), TBH this way is very simply, we just need invoke >> standard g

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-20 Thread Leon Alrae
On 20/05/2015 09:54, Peter Maydell wrote: > Well, with these patches alone we end up with a documented but broken > option. For reasons of consistency (again) I don't want the new > option in the tree without it being supported by ARM, even if the > MIPS code that uses it goes in. Fair enough. I’l

Re: [Qemu-devel] [PATCH v4 06/11] block: add refcount to Job object

2015-05-20 Thread Stefan Hajnoczi
On Tue, May 19, 2015 at 06:15:23PM -0400, John Snow wrote: > On 05/18/2015 11:45 AM, Stefan Hajnoczi wrote: > > On Mon, May 11, 2015 at 07:04:21PM -0400, John Snow wrote: > >> If we want to get at the job after the life of the job, > >> we'll need a refcount for this object. > >> > >> This may occu

[Qemu-devel] [PATCH v2 1/1] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-05-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" and use it in loadvm_state and ram_load. Where ever it's used, check the return and error if it failed. Minor: ram_load was using a 257 byte array for its string, the maximum length is 255 bytes + 0 terminator, so fix to 256 Signed-off-by: Dr. David Alan G

[Qemu-devel] [PATCH v2 0/1] Add qemu_get_counted_string

2015-05-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Move the reading of length first encoded strings into it's own function. v2: Terminate return buffer at read length rather than expected length Dr. David Alan Gilbert (1): Add qemu_get_counted_string to read a string prefixed by a count byte arch_init.c

Re: [Qemu-devel] [PATCH v2 1/1] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-05-20 Thread Amit Shah
On (Wed) 20 May 2015 [10:37:05], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > and use it in loadvm_state and ram_load. > > Where ever it's used, check the return and error if it failed. > > Minor: ram_load was using a 257 byte array for its string, the >maxim

Re: [Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a bool

2015-05-20 Thread Paolo Bonzini
On 20/05/2015 11:15, Michal Privoznik wrote: > When going through code I realized, that the pc_init1() has this two > arguments @pci_enabled and @kvmclock_enabled which despite used as > booleans are of int type. > > Signed-off-by: Michal Privoznik Eduardo, do your patches to the PC machine type

[Qemu-devel] [PATCH v4 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY

2015-05-20 Thread Dimitris Aragiorgis
Get rid of several #ifdef DEBUG_FLOPPY and substitute them with DPRINTF. Signed-off-by: Dimitris Aragiorgis --- block/raw-posix.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 438bf0b..ace228f 100644 ---

[Qemu-devel] [PATCH v4 1/5] block: Use bdrv_is_sg() everywhere

2015-05-20 Thread Dimitris Aragiorgis
Instead of checking bs->sg use bdrv_is_sg() consistently throughout the code. Signed-off-by: Dimitris Aragiorgis Reviewed-by: Paolo Bonzini --- block.c |6 +++--- block/iscsi.c |2 +- block/raw-posix.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --g

[Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic

2015-05-20 Thread Dimitris Aragiorgis
Hi all, These four patches make slight changes to the way QEMU handles SCSI generic devices to fix a number of small problems. I am sending them against the master branch, since I don't know if they can be considered bugfixes. Thanks, dimara v4 (rebased to current master): * Avoid errno clobber

Re: [Qemu-devel] virtio-pci msix error

2015-05-20 Thread Michael S. Tsirkin
On Tue, May 19, 2015 at 09:11:26PM +0100, Peter Maydell wrote: > On 19 May 2015 at 20:16, Michael S. Tsirkin wrote: > > On Tue, May 19, 2015 at 08:54:36AM -0700, Richard Henderson wrote: > >> Re patch c7ff5482. What's the point of this error? > >> It's going to always appear for older targets tha

[Qemu-devel] [PATCH v4 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT

2015-05-20 Thread Dimitris Aragiorgis
Building the QEMU tools fails if we #define DEBUG_BLOCK inside block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with a simple DPRINTF() (that does not cause bit-rot). Signed-off-by: Dimitris Aragiorgis --- block/r

[Qemu-devel] [PATCH v4 2/5] Fix migration in case of scsi-generic

2015-05-20 Thread Dimitris Aragiorgis
During migration, QEMU uses fsync()/fdatasync() on the open file descriptor for read-write block devices to flush data just before stopping the VM. However, fsync() on a scsi-generic device returns -EINVAL which causes the migration to fail. This patch skips flushing data in case of an SG device,

Re: [Qemu-devel] [RFC v7 05/11] vfio: do hot bus reset when do virtual secondary bus reset

2015-05-20 Thread Chen Fan
On 05/20/2015 03:34 AM, Alex Williamson wrote: On Tue, 2015-05-19 at 12:42 +0800, Chen Fan wrote: when do virtual secondary bus reset, the vfio device under this bus need to do host bus reset to reset the device. so add this case. Signed-off-by: Chen Fan --- hw/vfio/pci.c |

[Qemu-devel] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg()

2015-05-20 Thread Dimitris Aragiorgis
Until now, an SG device was identified only by checking if its path started with "/dev/sg". Then, hdev_open() set bs->sg accordingly. This is very fragile, e.g. it fails with symlinks or relative paths. We should rely on the actual properties of the device instead of the specified file path. Test

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-20 Thread Christoffer Dall
On Tue, May 19, 2015 at 12:18:54PM +0100, Catalin Marinas wrote: > On Tue, May 19, 2015 at 11:03:22AM +0100, Andrew Jones wrote: > > On Mon, May 18, 2015 at 04:53:03PM +0100, Catalin Marinas wrote: > > > Another way would be to split the vma containing the non-cacheable > > > memory so that you get

Re: [Qemu-devel] [PATCH] virtio: Notice when the system doesn't support MSIx at all

2015-05-20 Thread Michael S. Tsirkin
On Tue, May 19, 2015 at 01:29:51PM -0700, Richard Henderson wrote: > And do not issue an error_report in that case. > > Signed-off-by: Richard Henderson > --- > hw/virtio/virtio-pci.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > -- > > This seems to be about the on

[Qemu-devel] [PATCH] MAINTAINERS: Add header files to Block Layer Core section

2015-05-20 Thread Kevin Wolf
Suggested-by: Markus Armbruster Signed-off-by: Kevin Wolf --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3552b2..9ff7c36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -785,6 +785,7 @@ S: Supported F: block* F: block/ F: hw/block/ +F: inclu

Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add header files to Block Layer Core section

2015-05-20 Thread Alberto Garcia
On Wed 20 May 2015 12:05:55 PM CEST, Kevin Wolf wrote: > Suggested-by: Markus Armbruster > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] virtio-pci msix error

2015-05-20 Thread Peter Maydell
On 20 May 2015 at 10:58, Michael S. Tsirkin wrote: > On Tue, May 19, 2015 at 09:11:26PM +0100, Peter Maydell wrote: >> On 19 May 2015 at 20:16, Michael S. Tsirkin wrote: >> > On Tue, May 19, 2015 at 08:54:36AM -0700, Richard Henderson wrote: >> >> Re patch c7ff5482. What's the point of this erro

Re: [Qemu-devel] [PATCH 1/4] ui: use libexpoxy

2015-05-20 Thread Max Reitz
On 19.05.2015 16:29, Gerd Hoffmann wrote: libepoxy does the opengl extension handling for us. It also is helpful for trouble-shooting as it prints nice error messages instead of silently failing or segfaulting in case we do something wrong, like using gl commands not supported by the current con

Re: [Qemu-devel] [RESEND PATCH 14/23] hw/acpi/aml-build: Add ToUUID macro

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 12:19:55 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add ToUUID macro, this is useful for generating PCIe ACPI table. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Igor Mammedov Please remove my RB in cases when changes in patch are

Re: [Qemu-devel] [PATCH 2/4] ui: shader.h protect against double inclusion

2015-05-20 Thread Max Reitz
On 19.05.2015 16:29, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- include/ui/shader.h | 5 + 1 file changed, 5 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [RESEND PATCH v7 20/23] hw/acpi/aml-build: Add Unicode macro

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 13:00:58 +0800 Shannon Zhao wrote: when you submit a new version of patch vXX supposed to go up, otherwise how would reader know that it's not the same as before. > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov

Re: [Qemu-devel] [RESEND PATCH 14/23] hw/acpi/aml-build: Add ToUUID macro

2015-05-20 Thread Shannon Zhao
On 2015/5/20 18:57, Igor Mammedov wrote: > On Wed, 20 May 2015 12:19:55 +0800 > Shannon Zhao wrote: > >> From: Shannon Zhao >> >> Add ToUUID macro, this is useful for generating PCIe ACPI table. >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao >> Reviewed-by: Igor Mammedov >

Re: [Qemu-devel] [RESEND PATCH 05/23] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 12:23:02 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add aml_interrupt() for describing device interrupt in resource template. > These can be used to generating DSDT table for ACPI on ARM. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/ac

Re: [Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported 'transaction' operations

2015-05-20 Thread Kashyap Chamarthy
On Tue, May 19, 2015 at 11:37:32AM -0400, John Snow wrote: > > On Mon, May 18, 2015 at 06:22:22PM +0200, Max Reitz wrote: > >> On 12.05.2015 01:04, John Snow wrote: [. . .] > >>> diff --git a/qmp-commands.hx b/qmp-commands.hx > >>> index 7506774..363126a 100644 > >>> --- a/qmp-commands.hx > >>> +

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-20 Thread Liviu Ionescu
> On 20 May 2015, at 11:51, Leon Alrae wrote: > > On 20/05/2015 09:30, Liviu Ionescu wrote: >> >>> On 20 May 2015, at 11:11, Leon Alrae wrote: >>> >>> like "If both are specified, -kernel/-append are ignored (-kernel is >>> used to load an image, but the path won't be passed to semihosting)"

Re: [Qemu-devel] [RESEND PATCH v7 20/23] hw/acpi/aml-build: Add Unicode macro

2015-05-20 Thread Shannon Zhao
On 2015/5/20 19:01, Igor Mammedov wrote: > On Wed, 20 May 2015 13:00:58 +0800 > Shannon Zhao wrote: > > when you submit a new version of patch vXX supposed to go up, > otherwise how would reader know that it's not the same as before. > Hmm, sorry, I thought I added "RESEND" prefix to distingu

[Qemu-devel] [PATCH] MAINTAINERS: Split "Block QAPI, monitor, command line" off core

2015-05-20 Thread Markus Armbruster
Kevin and Stefan asked me to take care of this part. Signed-off-by: Markus Armbruster --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3552b2..8df0c6a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -812,6 +812,14 @@ F: block/stream.h F:

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-20 Thread Catalin Marinas
On Wed, May 20, 2015 at 11:01:27AM +0100, Christoffer Dall wrote: > On Tue, May 19, 2015 at 12:18:54PM +0100, Catalin Marinas wrote: > > On Tue, May 19, 2015 at 11:03:22AM +0100, Andrew Jones wrote: > > > On Mon, May 18, 2015 at 04:53:03PM +0100, Catalin Marinas wrote: > > > > I didn't have time to

Re: [Qemu-devel] [PATCH v4 11/11] qmp-commands.hx: Update the supported 'transaction' operations

2015-05-20 Thread John Snow
On 05/20/2015 07:12 AM, Kashyap Chamarthy wrote: > On Tue, May 19, 2015 at 11:37:32AM -0400, John Snow wrote: >>> On Mon, May 18, 2015 at 06:22:22PM +0200, Max Reitz wrote: On 12.05.2015 01:04, John Snow wrote: > > [. . .] > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index

Re: [Qemu-devel] [RESEND PATCH 05/23] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-20 Thread Shannon Zhao
On 2015/5/20 19:05, Igor Mammedov wrote: > On Wed, 20 May 2015 12:23:02 +0800 > Shannon Zhao wrote: > >> > From: Shannon Zhao >> > >> > Add aml_interrupt() for describing device interrupt in resource template. >> > These can be used to generating DSDT table for ACPI on ARM. >> > >> > Signed-

Re: [Qemu-devel] ABNT2 keys again

2015-05-20 Thread Michael Tokarev
A (friendly) ping? :) 30.04.2015 08:01, Michael Tokarev wrote: > There's a bug open in qemu bugtracker for several years > already, https://bugs.launchpad.net/qemu/+bug/1038136 . > The solution appears to be trivial (see also some background > at http://blog.nielshorn.net/2011/03/qemu-and-brazilia

[Qemu-devel] [PATCH] block: filter filename when testing encrypted images

2015-05-20 Thread Daniel P. Berrange
qemu-io prints a warning message "Disk image '/home/berrange/src/virt/qemu/tests/qemu-iotests/scratch/t.qcow2' is encrypted." when opening an encrypted image, which was mistakenly included in the expected output for test 131. Add a filter which strips this filename from the output data. Signed

Re: [Qemu-devel] [PATCH v6 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 10:40:46 +0800 Zhu Guihua wrote: > From: Chen Fan > > Replace mapping APIC at global system address space with > mapping it at per-CPU address spaces. > > Signed-off-by: Chen Fan > Signed-off-by: Zhu Guihua patch doesn't apply due to a small conflict in hw/i386/pc.c othe

Re: [Qemu-devel] [PATCH v6 2/4] apic: convert ->busdev.qdev casts to C casts

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 10:40:47 +0800 Zhu Guihua wrote: > Use C casts to avoid accessing ICCDevice's qdev field > directly. > > Signed-off-by: Zhu Guihua Reviewed-by: Igor Mammedov > --- > hw/intc/apic.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/hw/intc/

Re: [Qemu-devel] virtio-pci msix error

2015-05-20 Thread Fam Zheng
On Wed, 05/20 11:41, Peter Maydell wrote: > On 20 May 2015 at 10:58, Michael S. Tsirkin wrote: > > On Tue, May 19, 2015 at 09:11:26PM +0100, Peter Maydell wrote: > >> On 19 May 2015 at 20:16, Michael S. Tsirkin wrote: > >> > On Tue, May 19, 2015 at 08:54:36AM -0700, Richard Henderson wrote: > >>

Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase

2015-05-20 Thread John Snow
On 05/20/2015 05:24 AM, Peter Maydell wrote: > On 20 May 2015 at 09:43, Kevin Wolf wrote: >> Am 20.05.2015 um 10:06 hat Peter Maydell geschrieben: >>> That handles migration, which is good. But I still think that >>> storing the same information in two places in the device >>> state (phase field

Re: [Qemu-devel] [PATCH 7/8] fdc: Fix MSR.RQM flag

2015-05-20 Thread John Snow
On 05/20/2015 04:14 AM, Kevin Wolf wrote: > Am 19.05.2015 um 22:40 hat John Snow geschrieben: >> >> >> On 05/19/2015 11:36 AM, Kevin Wolf wrote: >>> The RQM bit in MSR should be set whenever the guest is supposed to >>> access the FIFO, and it should be cleared in all other cases. This is >>> imp

Re: [Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data()

2015-05-20 Thread John Snow
On 05/20/2015 04:25 AM, Kevin Wolf wrote: > Am 19.05.2015 um 22:40 hat John Snow geschrieben: >> >> >> On 05/19/2015 11:36 AM, Kevin Wolf wrote: >>> This commit makes similar improvements as have already been made to the >>> write function: Instead of relying on a flag in the MSR to distinguish >

Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase

2015-05-20 Thread Peter Maydell
On 20 May 2015 at 12:55, John Snow wrote: > So even if /currently/ we can reconstitute it from the register values, > we may eventually be unable to. > > post_load will work for now, but I fear the case (in ten years) when > someone else cleans up FDC code but fails to realize that the phase is >

Re: [Qemu-devel] [PATCH 2/2] SMBIOS: Allow users to chose base board type

2015-05-20 Thread Michal Privoznik
On 20.05.2015 11:24, Paolo Bonzini wrote: > > > On 20/05/2015 11:15, Michal Privoznik wrote: >> So far we only mistakenly claimed support for selecting base >> board type. This patch finally implements it. There's an enum in >> SMBIOS specification that lays out all the possible values. >> Theref

Re: [Qemu-devel] virtio-pci msix error

2015-05-20 Thread Peter Maydell
On 20 May 2015 at 12:55, Fam Zheng wrote: > On Wed, 05/20 11:41, Peter Maydell wrote: >> On 20 May 2015 at 10:58, Michael S. Tsirkin wrote: >> > On Tue, May 19, 2015 at 09:11:26PM +0100, Peter Maydell wrote: >> >> On 19 May 2015 at 20:16, Michael S. Tsirkin wrote: >> >> > On Tue, May 19, 2015 at

Re: [Qemu-devel] [PATCH 3/4] ui: add egl-helpers

2015-05-20 Thread Max Reitz
On 19.05.2015 16:29, Gerd Hoffmann wrote: Add helper functions to initialize OpenGL using egl. Signed-off-by: Gerd Hoffmann --- configure| 2 +- include/ui/egl-helpers.h | 16 ++ ui/Makefile.objs | 3 + ui/egl-helpers.c | 143 +++

Re: [Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a bool

2015-05-20 Thread Eduardo Habkost
On Wed, May 20, 2015 at 11:55:53AM +0200, Paolo Bonzini wrote: > On 20/05/2015 11:15, Michal Privoznik wrote: > > When going through code I realized, that the pc_init1() has this two > > arguments @pci_enabled and @kvmclock_enabled which despite used as > > booleans are of int type. > > > > Signed

Re: [Qemu-devel] [PATCH v6 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-05-20 Thread Eduardo Habkost
On Wed, May 20, 2015 at 01:46:45PM +0200, Igor Mammedov wrote: > On Wed, 20 May 2015 10:40:46 +0800 > Zhu Guihua wrote: > > > From: Chen Fan > > > > Replace mapping APIC at global system address space with > > mapping it at per-CPU address spaces. > > > > Signed-off-by: Chen Fan > > Signed-of

Re: [Qemu-devel] [PATCH v6 2/4] apic: convert ->busdev.qdev casts to C casts

2015-05-20 Thread Andreas Färber
Am 20.05.2015 um 04:40 schrieb Zhu Guihua: > Use C casts to avoid accessing ICCDevice's qdev field > directly. > > Signed-off-by: Zhu Guihua > --- > hw/intc/apic.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Andreas Färber Andreas -- SUSE Linux GmbH, Maxfel

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-20 Thread Leon Alrae
On 20/05/2015 12:12, Liviu Ionescu wrote: > yes, that's correct, my comment was related to the above quotes from your > message, in the first part you mention "the path won't be passed to > semihosting", which is not consistent with the actual behaviour, since the > entire kernel path is passed

Re: [Qemu-devel] [PATCH 00/23] userfaultfd v4

2015-05-20 Thread Andrea Arcangeli
Hi Andrew, On Tue, May 19, 2015 at 02:38:01PM -0700, Andrew Morton wrote: > On Thu, 14 May 2015 19:30:57 +0200 Andrea Arcangeli > wrote: > > > This is the latest userfaultfd patchset against mm-v4.1-rc3 > > 2015-05-14-10:04. > > It would be useful to have some userfaultfd testcases in > tools/

Re: [Qemu-devel] [PATCH 4/4] gtk: add opengl support, using egl

2015-05-20 Thread Max Reitz
On 19.05.2015 16:29, Gerd Hoffmann wrote: This adds opengl rendering support to the gtk ui, using egl. It's off by default for now, use 'qemu -display gtk,gl=on' to play with this. Note that gtk got native opengl support with release 3.16. There most likely will be a separate implementation for

[Qemu-devel] [PATCH] gtk: Replace gdk_cursor_new()

2015-05-20 Thread Max Reitz
gdk_cursor_new() has been deprecated in GTK 3.16, it is recommended to use gdk_cursor_new_for_display() instead, so do that. Signed-off-by: Max Reitz --- ui/gtk.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index c58028f..b9abee1 100644 --- a/ui/gt

Re: [Qemu-devel] [RESEND PATCH 14/23] hw/acpi/aml-build: Add ToUUID macro

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 19:02:12 +0800 Shannon Zhao wrote: > > > On 2015/5/20 18:57, Igor Mammedov wrote: > > On Wed, 20 May 2015 12:19:55 +0800 > > Shannon Zhao wrote: > > > >> From: Shannon Zhao > >> > >> Add ToUUID macro, this is useful for generating PCIe ACPI table. > >> > >> Signed-off-by:

Re: [Qemu-devel] [RESEND PATCH 14/23] hw/acpi/aml-build: Add ToUUID macro

2015-05-20 Thread Shannon Zhao
On 2015/5/20 21:41, Igor Mammedov wrote: On Wed, 20 May 2015 19:02:12 +0800 Shannon Zhao wrote: On 2015/5/20 18:57, Igor Mammedov wrote: On Wed, 20 May 2015 12:19:55 +0800 Shannon Zhao wrote: From: Shannon Zhao Add ToUUID macro, this is useful for generating PCIe ACPI table. Signed-

Re: [Qemu-devel] [RESEND PATCH v7 20/23] hw/acpi/aml-build: Add Unicode macro

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 19:12:40 +0800 Shannon Zhao wrote: > > > On 2015/5/20 19:01, Igor Mammedov wrote: > > On Wed, 20 May 2015 13:00:58 +0800 > > Shannon Zhao wrote: > > > > when you submit a new version of patch vXX supposed to go up, > > otherwise how would reader know that it's not the same

Re: [Qemu-devel] [RESEND PATCH 05/23] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 19:28:26 +0800 Shannon Zhao wrote: > > > On 2015/5/20 19:05, Igor Mammedov wrote: > > On Wed, 20 May 2015 12:23:02 +0800 > > Shannon Zhao wrote: > > > >> > From: Shannon Zhao > >> > > >> > Add aml_interrupt() for describing device interrupt in resource template. > >> > T

Re: [Qemu-devel] [PATCH v3 2/2] semihosting: add --semihosting-config arg sub-argument

2015-05-20 Thread Liviu Ionescu
> On 20 May 2015, at 12:31, Leon Alrae wrote: > > ... I’ll update arm-semi.c as well to concatenate all args. you can use parts of my initial patch for the arm semihosting related changes. --- personally I would add a pointer (cmdline?) in the semihosting structure and a getter (semihosting_

Re: [Qemu-devel] [PATCH v6 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-05-20 Thread Igor Mammedov
On Wed, 20 May 2015 09:38:16 -0300 Eduardo Habkost wrote: > On Wed, May 20, 2015 at 01:46:45PM +0200, Igor Mammedov wrote: > > On Wed, 20 May 2015 10:40:46 +0800 > > Zhu Guihua wrote: > > > > > From: Chen Fan > > > > > > Replace mapping APIC at global system address space with > > > mapping i

Re: [Qemu-devel] migration network requirements

2015-05-20 Thread Alexey Kardashevskiy
On 05/20/2015 07:21 PM, Dr. David Alan Gilbert wrote: * Alexey Kardashevskiy (a...@ozlabs.ru) wrote: Hi! Recent bugreports from our testers at IBM about failed migration across USA (for example, from NY to TX) made me wonder - what are the actual basic requirements/expectations for migration?

Re: [Qemu-devel] [PATCH] block: filter filename when testing encrypted images

2015-05-20 Thread Eric Blake
On 05/20/2015 05:45 AM, Daniel P. Berrange wrote: > qemu-io prints a warning message > > "Disk image > '/home/berrange/src/virt/qemu/tests/qemu-iotests/scratch/t.qcow2' is > encrypted." > > when opening an encrypted image, which was mistakenly included > in the expected output for test 131. Ad

Re: [Qemu-devel] [PATCH] MAINTAINERS: Split "Block QAPI, monitor, command line" off core

2015-05-20 Thread Eric Blake
On 05/20/2015 05:23 AM, Markus Armbruster wrote: > Kevin and Stefan asked me to take care of this part. > > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > Reviewed-by: Eric Blake > diff --git a/MAINTAINERS b/MAINTAINERS > index b3552b2.

  1   2   3   >