Re: [Qemu-devel] [oss-security] QEMU 2.3.0 tmp vulns CVE request

2015-05-16 Thread Michael Tokarev
[Adding Cc qemu-devel@] 13.05.2015 19:23, Kurt Seifried wrote: > So some suspicious looking tmp usage in qemu (I excluded the test > scripts and builds scripts, they were rife with problems so hopefully > people only build in trusted environments). > > Additionally there will no doubt be further

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

2015-05-16 Thread Alexander Graf
On 15.05.15 15:43, Markus Armbruster wrote: > Alexander Graf writes: > >> On 17.03.15 08:46, Markus Armbruster wrote: >>> Alexander Graf writes: >>> On 09.03.15 19:30, Markus Armbruster wrote: > Alexander Graf writes: > >> On 27.02.15 13:43, Markus Armbruster wrote: >>> C

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-16 Thread Andreas Färber
Am 16.05.2015 um 00:24 schrieb Eric Blake: > We require a C99 compiler, so let's use 'bool' instead of 'int' > when dealing with boolean values. There are few enough clients > to fix them all in one pass. > > Signed-off-by: Eric Blake > --- > block/qapi.c| 2 +- > block/quo

Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-05-16 Thread Paolo Bonzini
On 16/05/2015 03:48, Corey Minyard wrote: > On 05/13/2015 09:52 AM, Paolo Bonzini wrote: >> >> On 11/05/2015 21:58, Corey Minyard wrote: >>> I've debated this in my mind since I've been learning more about >>> qemu. Some of the bmc properties are being passed in to the interface >>> and passed on

Re: [Qemu-devel] [oss-security] QEMU 2.3.0 tmp vulns CVE request

2015-05-16 Thread Jakub Wilk
* Michael Tokarev , 2015-05-16, 11:45: ./net/slirp.c: snprintf(s->smb_dir, sizeof(s->smb_dir), "/tmp/qemu-smb.%ld-%d", (long)getpid(), instance++); This one is real, used for -smb argument, to start smbd, making its configuration. Maybe tmpnam() should be used here. "Never us

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-16 Thread Eric Blake
On 05/16/2015 07:30 AM, Andreas Färber wrote: > Am 16.05.2015 um 00:24 schrieb Eric Blake: >> We require a C99 compiler, so let's use 'bool' instead of 'int' >> when dealing with boolean values. There are few enough clients >> to fix them all in one pass. >> >> Signed-off-by: Eric Blake >> --- >

Re: [Qemu-devel] [patch v5] ui/cocoa.m: Adds console items to the View menu

2015-05-16 Thread Peter Maydell
On 11 May 2015 at 16:18, Programmingkid wrote: > Adds any console that is available to the current emulator as a menu item > under the View menu. > > Signed-off-by: John Arbuckle Thanks; I think this version looks pretty good. A minor improvement: > +static void create_view_menu() > +{ > +

Re: [Qemu-devel] [PATCH 1/3] ui/cocoa.m: adds Machine menu with pause and resume menu items

2015-05-16 Thread Peter Maydell
On 11 May 2015 at 23:12, Programmingkid wrote: > Adds a Machine menu to the Macintosh interface that pause and resume menu "with pause and resume menu items" > items. > These items can either pause or resume execution of the guest operating > system. > > Signed-off-by: John Arbuckle This mostl

Re: [Qemu-devel] [PATCH 3/3] ui/cocoa.m: Add Reset and Power Down menu items to Machine menu

2015-05-16 Thread Peter Maydell
On 11 May 2015 at 23:18, Programmingkid wrote: > Adds Reset and Power Down menu items to the Machine menu. > > Signed-off-by: John Arbuckle This patch mostly looks good and pretty straightforward. If you put it as #2 in this series then we can get it into master even if we need to have another r

Re: [Qemu-devel] [PATCH 2/3] ui/cocoa.m: Adds device menu items to Machine menu

2015-05-16 Thread Peter Maydell
On 11 May 2015 at 23:16, Programmingkid wrote: > Adds all removable devices to the Machine menu as a Change and Eject menu > item pair. > ide-cd0 would have a "Change ide-cd0..." and "Eject ide-cd0" menu items. > > Signed-off-by: John Arbuckle Kevin -- is there a block layer API for a UI to be i

[Qemu-devel] [PATCH] target-s390x: fix CC computation for EX instruction

2015-05-16 Thread Aurelien Jarno
Commit 7a6c7067f optimized CC computation by only saving cc_op before calling helpers as they either don't touch the CC or generate a new static value. This however doesn't work for the EX instruction as the helper changes or not the CC value depending on the actual executed instruction (e.g. MVC v

[Qemu-devel] [PATCH] device-tree: Make a common-obj

2015-05-16 Thread Peter Crosthwaite
There is no reason for device tree API to be built per-target. common-obj it. There is an extraneous inclusion of config.h that needs to be removed. Signed-off-by: Peter Crosthwaite --- Makefile.objs | 2 ++ Makefile.target | 1 - device_tree.c | 1 - 3 files changed, 2 insertions(+), 2 dele