[Qemu-devel] [PATCH v1 04/18] target-arm: Route timer access traps to EL1

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index a4bab78..d849b30 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1147,6 +1147,7 @@ static CPAc

[Qemu-devel] [PATCH v1 06/18] target-arm: Add TCR_EL2

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 168549c..025e334 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2524,6 +2524,10 @@ stat

[Qemu-devel] [PATCH v1 07/18] target-arm: Add SCTLR_EL2

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 025e334..c44cbb4 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2528,6 +2528,10 @@ stati

[Qemu-devel] [PATCH v1 05/18] target-arm: Add MAIR_EL2

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index d849b30..168549c 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2520,6 +2520,10 @@ stati

[Qemu-devel] [PATCH v1 08/18] target-arm: Add TTBR0_EL2

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index c44cbb4..ace933c 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2532,6 +2532,10 @@ stati

[Qemu-devel] [PATCH v1 09/18] target-arm: Add TLBI_ALLE1{IS}

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index ace933c..830c9d4 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2366,6 +2366,14 @@ stati

[Qemu-devel] [PATCH v1 10/18] target-arm: Add TLBIALLE2

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 830c9d4..8e96b14 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2636,6 +2636,10 @@ static co

[Qemu-devel] [PATCH v1 12/18] target-arm: Add TLBI_VAE2{IS}

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index d57e0af..7ad9133 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2644,6 +2644,14 @@ stati

[Qemu-devel] [PATCH v1 11/18] target-arm: Add TPIDR_EL2

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 8e96b14..d57e0af 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2544,6 +2544,10 @@ stati

[Qemu-devel] [PATCH v1 13/18] target-arm: Add access to PAR_EL1

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7ad9133..5b7c195 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2436,6 +2436,11 @@ static c

[Qemu-devel] [PATCH v1 14/18] target-arm: Add CNTVOFF_EL2

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 1 + target-arm/helper.c | 41 +++-- 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 6922e54..73a4ce8 100644 --- a/

[Qemu-devel] [PATCH v1 15/18] target-arm: Add CNTHCTL_EL2

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 1 + target-arm/helper.c | 33 +++-- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 73a4ce8..059c200 100644 --- a/target-a

[Qemu-devel] [PATCH v1 18/18] hw/arm/virt: Connect the Hypervisor timer

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/arm/virt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index a7f9a10..76b6b2e 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -384,6 +384,9 @@ static uint32_t create_gic(const VirtBoardI

[Qemu-devel] [PATCH v1 16/18] target-arm: Pass timeridx as argument to various timer functions

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 98 + 1 file changed, 76 insertions(+), 22 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 4c1d6c7..d29b1fc 100644 --- a/target-arm

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-13 Thread Wen Congyang
On 05/13/2015 11:11 AM, Fam Zheng wrote: > Before, we only yield after initializing dirty bitmap, where the QMP > command would return. That may take very long, and guest IO will be > blocked. > > Add sleep points like the later mirror iterations. > > Signed-off-by: Fam Zheng Reviewed-by: Wen C

[Qemu-devel] [PATCH v1 17/18] target-arm: Add HYP timer

2015-05-13 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu-qom.h | 1 + target-arm/cpu.c | 2 ++ target-arm/cpu.h | 3 ++- target-arm/helper.c | 64 4 files changed, 69 insertions(+), 1 deletion(-) diff --git a

Re: [Qemu-devel] [PATCH] monitor: print help for command errors

2015-05-13 Thread Markus Armbruster
Bandan Das writes: > Unlike machines, humans will be (mostly) appreciative on seeing > help output when a command fails due to incorrect syntax or input. > By default, print output of help_cmd() to the monitor in such cases. > The only exceptions are if a command does not exist or parsing > faile

[Qemu-devel] [PATCH v5 2/4] apic: convert ->busdev.qdev casts to C casts

2015-05-13 Thread Zhu Guihua
Use C casts to avoid accessing ICCDevice's qdev field directly. Signed-off-by: Zhu Guihua --- hw/intc/apic.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/intc/apic.c b/hw/intc/apic.c index 0f97b47..e6f14b5 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -376

[Qemu-devel] [PATCH v5 0/4] remove icc bus/bridge

2015-05-13 Thread Zhu Guihua
ICC Bus was used for providing a hotpluggable bus for APIC and CPU, but now we use HotplugHandler to make hotplug. So ICC Bus is unnecessary. This code has passed the new pc-cpu-test. And I have tested with kvm along with kernel_irqchip=on/off, it works fine. This patch series is rebased on Eduar

[Qemu-devel] [PATCH v5 1/4] apic: move apic mmio register to each apic realizefn

2015-05-13 Thread Zhu Guihua
From: Chen Fan Due to local apic address is in view of CPU's address space, so able to move apic mapping to each apic realizefn. Signed-off-by: Chen Fan Signed-off-by: Zhu Guihua --- exec.c| 5 + hw/i386/pc.c | 7 --- hw/intc/apic_common.c | 14 -

[Qemu-devel] [PATCH v5 4/4] icc_bus: drop the unused files

2015-05-13 Thread Zhu Guihua
ICC bus impl has been droped, so all icc related files are not useful any more; delete them. Signed-off-by: Zhu Guihua --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/cpu/Makefile.objs | 1 - hw/cpu/icc_bus.c | 118

[Qemu-devel] [PATCH v5 3/4] cpu/apic: drop icc bus/bridge

2015-05-13 Thread Zhu Guihua
From: Chen Fan ICC bus was invented only to provide hotplug capability to CPU and APIC because at the time being hotplug was available only for BUS attached devices. Now this patch is to drop ICC bus impl, and switch to bus-less CPU+APIC hotplug, handling them in the same manner as pc-dimm. and

Re: [Qemu-devel] [PATCH 0/2] configure: increase glib requirement to 2.22

2015-05-13 Thread Markus Armbruster
John Snow writes: > As discussed during the QEMU 2.3 development freeze. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH V7 15/16] virtio-pci: increase the maximum number of virtqueues to 513

2015-05-13 Thread Jason Wang
On 04/28/2015 03:17 PM, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2015 at 11:12:10AM +0800, Jason Wang wrote: >> > >> > >> > On Mon, Apr 27, 2015 at 7:02 PM, Michael S. Tsirkin >> > wrote: >>> > >On Thu, Apr 23, 2015 at 02:21:48PM +0800, Jason Wang wrote: > >> This patch increases the

Re: [Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific queue limit

2015-05-13 Thread Jason Wang
On 04/28/2015 10:40 PM, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2015 at 03:33:37PM +0200, Cornelia Huck wrote: >> On Tue, 28 Apr 2015 14:47:11 +0200 >> "Michael S. Tsirkin" wrote: >> >>> On Tue, Apr 28, 2015 at 01:39:51PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 12:55:40 +0200 >>

Re: [Qemu-devel] [PATCH v1 05/18] target-arm: Add MAIR_EL2

2015-05-13 Thread Sergey Fedorov
On 13.05.2015 09:52, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/helper.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index d849b30..168549c 100644 > --- a/target-arm

Re: [Qemu-devel] [PATCHv3 1/2] Move parallel_hds_isa_init to hw/isa/isa-bus.c

2015-05-13 Thread Markus Armbruster
mreza...@redhat.com writes: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause removing parallel_hds_isa_init defined in > parallel.c. This function is called during initialization of some boards so > disabling CONFIG_PARALLEL cause build failure. > > This patch moves parallel_hds_isa_

Re: [Qemu-devel] [PATCHv3 2/2] stubs: Provide parallel_mm_init stub version

2015-05-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 12/05/2015 08:22, mreza...@redhat.com wrote: >> From: Miroslav Rezanina >> >> mips build fail with link error in case PARALLEL_CONFIG is disabled as >> hw/mips/mips_jazz.c calls parallel_mm_init. Due to dependecies to content >> of parallel.c we can't simply move it t

Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required

2015-05-13 Thread Daniel P. Berrange
On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote: > On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: > > The qemu-io tool does not check if the image is encrypted so > > historically would silently corrupt the sectors by writing > > plain text data into them instead of cipher text. The e

[Qemu-devel] modules: enabling other kinds of modules, not only block?

2015-05-13 Thread Michael Tokarev
Hello. Is there any interest of enabling other kinds of modules, not only block? Eg, modular display (gtk/sdl/..) would be nice (but not exactly easy with sdl1), smartcard-nss device can be built as module and so on. Also, how about on-demand module loading? I see quite easy way of doing so, fi

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 08:57, Pavel Dovgaluk wrote: >> > It's any instruction that can cause an icount read, typically through >> > QEMU_CLOCK_VIRTUAL or cpu_get_ticks(). > Doesn't this mean that ARM has incorrect implementation of icount? > MMIO is common for this platform, but none of memory accesses ar

Re: [Qemu-devel] [PATCH 13/34] qemu-io: Add command 'reopen'

2015-05-13 Thread Kevin Wolf
Am 12.05.2015 um 17:05 hat Eric Blake geschrieben: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > qemu-io-cmds.c | 71 > > ++ > > 1 file changed, 71 insertions(+) > > > > > + > > +while ((c = get

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-13 Thread Paolo Bonzini
On 12/05/2015 21:41, Peter Maydell wrote: >> > It's any instruction that can cause an icount read, typically through >> > QEMU_CLOCK_VIRTUAL or cpu_get_ticks(). > Also anything that can cause a CPU interrupt, since tcg_handle_interrupt() > will call cpu_abort() if the CPU gets an interrupt while

Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 15:15, Fam Zheng wrote: > raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi > should relax. It's okay to have the same QEMU_BUILD_BUG_ON in different places. However, you're right that this should be a compile-time check rather than run-time check. Paolo >

Re: [Qemu-devel] [PATCH V7 15/16] virtio-pci: increase the maximum number of virtqueues to 513

2015-05-13 Thread Michael S. Tsirkin
On Wed, May 13, 2015 at 03:47:51PM +0800, Jason Wang wrote: > > > On 04/28/2015 03:17 PM, Michael S. Tsirkin wrote: > > On Tue, Apr 28, 2015 at 11:12:10AM +0800, Jason Wang wrote: > >> > > >> > > >> > On Mon, Apr 27, 2015 at 7:02 PM, Michael S. Tsirkin > >> > wrote: > >>> > >On Thu, Apr 23, 2

Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value

2015-05-13 Thread Fam Zheng
On Wed, 05/13 10:43, Paolo Bonzini wrote: > > > On 13/05/2015 15:15, Fam Zheng wrote: > > raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi > > should relax. > > It's okay to have the same QEMU_BUILD_BUG_ON in different places. > However, you're right that this should be a

Re: [Qemu-devel] [PATCHv3 2/2] stubs: Provide parallel_mm_init stub version

2015-05-13 Thread Miroslav Rezanina
On Wed, May 13, 2015 at 10:04:23AM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 12/05/2015 08:22, mreza...@redhat.com wrote: > >> From: Miroslav Rezanina > >> > >> mips build fail with link error in case PARALLEL_CONFIG is disabled as > >> hw/mips/mips_jazz.c calls parallel_

Re: [Qemu-devel] [PATCHv3 1/2] Move parallel_hds_isa_init to hw/isa/isa-bus.c

2015-05-13 Thread Miroslav Rezanina
On Wed, May 13, 2015 at 10:01:12AM +0200, Markus Armbruster wrote: > mreza...@redhat.com writes: > > > From: Miroslav Rezanina > > > > Disabling CONFIG_PARALLEL cause removing parallel_hds_isa_init defined in > > parallel.c. This function is called during initialization of some boards so > > disa

Re: [Qemu-devel] Bug report - Windows XP guest failure

2015-05-13 Thread Paolo Bonzini
On 12/05/2015 09:22, Michael Tokarev wrote: > 12.05.2015 04:05, Peter Crosthwaite wrote: >> On Thu, May 7, 2015 at 2:34 AM, Michael Tokarev wrote: > ... Ok, I can reproduce this, winXP BSODs on boot in tcg mode. Git bisect points to this: commit 23820dbfc79d1c9dce090b4c555994

Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options()

2015-05-13 Thread Kevin Wolf
Am 12.05.2015 um 22:04 hat Eric Blake geschrieben: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: > > Eventually we want to be able to change options at runtime. As a first > > step towards that goal, separate some option handling code from the > > general initialisation code in qcow2_open(). > > > >

Re: [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitable for transactions

2015-05-13 Thread Kevin Wolf
Am 12.05.2015 um 23:40 hat Eric Blake geschrieben: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: > > Before we can allow updating options at runtime with bdrv_reopen(), we > > need to split the function into prepare/commit/abort parts. > > > > Signed-off-by: Kevin Wolf > > --- > > block/qcow2.c |

[Qemu-devel] [RESEND PATCH v4] acpi: add acpi_send_gpe_event() to rise sci for hotplug

2015-05-13 Thread Zhu Guihua
Add a new API named acpi_send_gpe_event() to send hotplug SCI. This API can be used by pci, cpu and memory hotplug. This patch is rebased on master. Signed-off-by: Zhu Guihua --- v4: -rename struct AcpiHotplugStatus to AcpiGPEStatusBits -add comments for struct AcpiGPEStatusBits v3: -rebase

Re: [Qemu-devel] [PATCH 20/34] qcow2: Support updating driver-specific options in reopen

2015-05-13 Thread Kevin Wolf
Am 12.05.2015 um 23:47 hat Eric Blake geschrieben: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: > > For updating the cache sizes or disabling lazy refcounts there is a bit > > more to do than just changing the variables, but otherwise we're all set > > for changing options during bdrv_reopen(). > >

[Qemu-devel] [PATCH v2 00/11] Fix transactional snapshot with virtio-blk dataplane and NBD export

2015-05-13 Thread Fam Zheng
Changes from RFC: - Add op blocker listener in nbd server. - Add other transaction types. - Only notify listeners when changing from/to empty. (Paolo) Reported by Paolo. Unlike the iohandler in main loop, iothreads currently process the event notifier used by virtio-blk ioeventfd in nested

[Qemu-devel] [PATCH v2 01/11] block: Add op blocker type "device IO"

2015-05-13 Thread Fam Zheng
Preventing device from submitting IO is useful around various nested aio_poll. Op blocker is a good place to put this flag. Devices would submit IO requests through blk_* block backend interface, which calls blk_check_request to check the validity. Return -EBUSY if the operation is blocked, which

Re: [Qemu-devel] Supporting multiple CPU AddressSpaces and memory transaction attributes

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 08:41, Edgar E. Iglesias wrote: > I think it would be nice if address_space_translate_for_iotlb > was allowed to modify the attributes so that an IOMMU in front > of a CPU could for example down-grade a secure to a non-secure accesse > (once we add IOMMU support in front of CPUs). I

[Qemu-devel] [PATCH v2 05/11] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-13 Thread Fam Zheng
virtio-blk now listens to op blocker change of the associated block backend. Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO: non-dataplane: 1) Set VirtIOBlock.paused 2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paused dataplane: 1) Clear the host event notifier

[Qemu-devel] [PATCH v2 04/11] virtio-blk: Move complete_request to 'ops' structure

2015-05-13 Thread Fam Zheng
Should more ops be added to differentiate code between dataplane and non-dataplane, the new saved_ops approach will be cleaner than messing with N pointers. Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 13 - hw/block/virtio-blk.c | 8 ++-- include/hw/

[Qemu-devel] [PATCH v2 02/11] block: Add op blocker notifier list

2015-05-13 Thread Fam Zheng
BDS users can register a notifier and get notified about op blocker changes. Signed-off-by: Fam Zheng --- block.c | 28 include/block/block.h | 8 include/block/block_int.h | 3 +++ 3 files changed, 39 insertions(+) diff --git a/bloc

[Qemu-devel] [PATCH v2 06/11] nbd-server: Clear "can_read" when "device io" blocker is set

2015-05-13 Thread Fam Zheng
So that NBD export cannot submit IO during bdrv_drain_all(). Signed-off-by: Fam Zheng --- nbd.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/nbd.c b/nbd.c index 06b501b..7d9d3e4 100644 --- a/nbd.c +++ b/nbd.c @@ -160,6 +160,8 @@ struct NBDExport { uint32_t nbdflag

[Qemu-devel] [PATCH v2 03/11] block-backend: Add blk_op_blocker_add_notifier

2015-05-13 Thread Fam Zheng
Forward the call to bdrv_op_blocker_add_notifier. Signed-off-by: Fam Zheng --- block/block-backend.c | 6 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 71fc695..90d7476 100644 --- a/block/

[Qemu-devel] [PATCH v2 07/11] blockdev: Block device IO during internal snapshot transaction

2015-05-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..7f763d9 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1262,6 +1262,7 @@ typedef struct InternalSnapshotState { BlockDriverState *bs;

[Qemu-devel] [PATCH v2 09/11] blockdev: Block device IO during drive-backup transaction

2015-05-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 923fc90..ae52d27 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1575,6 +1575,7 @@ typedef struct DriveBackupState { BlockDriverState *bs; AioCo

[Qemu-devel] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all

2015-05-13 Thread Fam Zheng
We don't want new requests from guest, so block the operation around the nested poll. Signed-off-by: Fam Zheng --- block/io.c | 12 1 file changed, 12 insertions(+) diff --git a/block/io.c b/block/io.c index 1ce62c4..d369de3 100644 --- a/block/io.c +++ b/block/io.c @@ -289,9 +289,1

[Qemu-devel] [PATCH v2 08/11] blockdev: Block device IO during external snapshot transaction

2015-05-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7f763d9..923fc90 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1404,6 +1404,7 @@ typedef struct ExternalSnapshotState { BlockDriverStat

[Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction

2015-05-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index ae52d27..bd28183 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1649,6 +1649,7 @@ typedef struct BlockdevBackupState { BlockDriverState *bs;

Re: [Qemu-devel] [PATCH] qemu-io: Use getopt() correctly

2015-05-13 Thread Kevin Wolf
Am 12.05.2015 um 17:10 hat Eric Blake geschrieben: > POSIX says getopt() returns -1 on completion. While Linux happens > to define EOF as -1, this definition is not required by POSIX, and > there may be platforms where checking for EOF instead of -1 would > lead to an infinite loop. > > Signed-of

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 05:11, Fam Zheng wrote: > Before, we only yield after initializing dirty bitmap, where the QMP > command would return. That may take very long, and guest IO will be > blocked. > > Add sleep points like the later mirror iterations. You were also planning to let bdrv_co_is_allocated

Re: [Qemu-devel] [PATCH 0/4] semihosting: clean up and add --semihosting-config arg

2015-05-13 Thread Leon Alrae
On 13/05/2015 06:48, Liviu Ionescu wrote: > are these patches finally in? if so, what repo/branch should I use to get > them? Note that v3 was sent quite recently and there should be some time to give everyone a chance to comment. I was planning to send it out later, together with UHI via target-

Re: [Qemu-devel] [PATCH 0/2] configure: increase glib requirement to 2.22

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 00:18, John Snow wrote: > As discussed during the QEMU 2.3 development freeze. > > == > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch glib-version-fix > https://github.com/jnsnow/qemu/tree/glib-version-fix > > This version is tagged glib

Re: [Qemu-devel] Help with deadlock when using sound

2015-05-13 Thread Peter Maydell
On 13 May 2015 at 04:23, Programmingkid wrote: > Found out why QEMU is deadlocking. It is because a mutex that has been > unlocked over 20 times in a row is being locked. OSX supports 'error checking' mutexes which will fail in these undefined-behaviour cases like double-unlock. (The error checki

[Qemu-devel] [PATCHv4] Move parallel_hds_isa_init to hw/isa/isa-bus.c

2015-05-13 Thread mrezanin
From: Miroslav Rezanina Disabling CONFIG_PARALLEL cause removing parallel_hds_isa_init defined in parallel.c. This function is called during initialization of some boards so disabling CONFIG_PARALLEL cause build failure. This patch moves parallel_hds_isa_init to hw/isa/isa-bus.c so it is include

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-13 Thread Peter Maydell
On 13 May 2015 at 09:42, Paolo Bonzini wrote: > > > On 12/05/2015 21:41, Peter Maydell wrote: >>> > It's any instruction that can cause an icount read, typically through >>> > QEMU_CLOCK_VIRTUAL or cpu_get_ticks(). >> Also anything that can cause a CPU interrupt, since tcg_handle_interrupt() >> wi

Re: [Qemu-devel] [PATCH 0/4] semihosting: clean up and add --semihosting-config arg

2015-05-13 Thread Peter Maydell
On 13 May 2015 at 10:29, Leon Alrae wrote: > On 13/05/2015 06:48, Liviu Ionescu wrote: >> are these patches finally in? if so, what repo/branch should I use to get >> them? > > Note that v3 was sent quite recently and there should be some time to > give everyone a chance to comment. It's still o

[Qemu-devel] [PATCH 08/10] target-tricore: add FCALL instructions of the v1.6 ISA

2015-05-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 21 + target-tricore/tricore-opcodes.h | 3 +++ 2 files changed, 24 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 4aea0c6..545cc06 100644 --- a/target-tricore/

[Qemu-devel] [PATCH 04/10] target-tricore: add CMPSWP instructions of the v1.6.1 ISA

2015-05-13 Thread Bastian Koppelmann
Those instruction were introduced in the new Aurix platform. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 35 +++ target-tricore/tricore-opcodes.h | 5 + 2 files changed, 40 insertions(+) diff --git a/target-tricore/translate.c b/

[Qemu-devel] [PATCH 10/10] target-tricore: add RR_DIV and RR_DIV_U instructions of the v1.6 ISA

2015-05-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/helper.h | 2 ++ target-tricore/op_helper.c | 49 target-tricore/translate.c | 21 + target-tricore/tricore-opcodes.h | 2 ++ 4 files changed, 74 insertions(+) dif

[Qemu-devel] [PATCH 00/10] TriCore v1.6.1 ISA and missing v1.6 instructions

2015-05-13 Thread Bastian Koppelmann
Hi, the new Aurix platform introduces a new ISA version, so this patchset adds a new feature bit and changes the generic Aurix cpu to a more specific tc27x cpu model. While at this, it introduces a new cpu model tc1797 which uses the v1.3.1 ISA and fixes the tc1796 to us the v1.3 ISA. It also add

[Qemu-devel] [PATCH 01/10] target-tricore: Add ISA v1.3.1 cpu and fix tc1796 to using v1.3

2015-05-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/target-tricore/cpu.c b/target-tricore/cpu.c index 2ba0cf4..9fe0b97 100644 --- a/target-tricore/cpu.c +++ b/target-tricore/cpu.c @@ -118,6 +118,13 @@ static void tc1796_initfn(Obj

[Qemu-devel] [PATCH 03/10] target-tricore: Add SRC_MOV_E instruction of the v1.6 ISA

2015-05-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 663b2a0..1c37e48 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c

[Qemu-devel] [PATCH 02/10] target-tricore: introduce ISA v1.6.1 feature

2015-05-13 Thread Bastian Koppelmann
The aurix platform contains of several different cpu models and uses the 1.6.1 ISA. This patch changes the generic aurix model to the more specific tc27x cpu model and sets specific features. Signed-off-by: Bastian Koppelmann --- target-tricore/cpu.c | 10 +++--- target-tricore/cpu.h | 1 +

[Qemu-devel] [PATCH 09/10] target-tricore: add FRET instructions of the v1.6 ISA

2015-05-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 14 ++ target-tricore/tricore-opcodes.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 545cc06..4f517b3 100644 --- a/target-tricore/translat

[Qemu-devel] [PATCH 06/10] target-tricore: add RR_CRC32 instruction of the v1.6.1 ISA

2015-05-13 Thread Bastian Koppelmann
This instruction was introduced by the new Aurix platform. Signed-off-by: Bastian Koppelmann --- target-tricore/helper.h | 2 ++ target-tricore/op_helper.c | 11 +++ target-tricore/translate.c | 5 + target-tricore/tricore-opcodes.h | 1 + 4 files changed, 19

[Qemu-devel] [PATCH 07/10] target-tricore: add SYS_RESTORE instruction of the v1.6 ISA

2015-05-13 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 10 ++ target-tricore/tricore-opcodes.h | 1 + 2 files changed, 11 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 52f474b..4aea0c6 100644 --- a/target-tricore/translate.c +

[Qemu-devel] [PATCH 05/10] target-tricore: add SWAPMSK instructions of the v1.6.1 ISA

2015-05-13 Thread Bastian Koppelmann
Those instruction were introduced in the new Aurix platform. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 39 +++ target-tricore/tricore-opcodes.h | 5 + 2 files changed, 44 insertions(+) diff --git a/target-tricore/translate.

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 11:41, Peter Maydell wrote: > > For -icount and SMP, yes. I even posted a patch to that end once. > > I don't see why -icount and SMP need to be mutually exclusive. > If we're round-robining between the SMP CPUs then they should > all stay deterministic, I would have thought? No,

Re: [Qemu-devel] [PATCHv4] Move parallel_hds_isa_init to hw/isa/isa-bus.c

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 11:39, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause removing parallel_hds_isa_init defined in > parallel.c. This function is called during initialization of some boards so > disabling CONFIG_PARALLEL cause build failure. > > This patch

Re: [Qemu-devel] [PATCH v2 05/11] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 19:28, Fam Zheng wrote: > +static void virtio_blk_data_plane_pause(VirtIOBlock *vblk) > +{ > +VirtIOBlockDataPlane *s = vblk->dataplane; > + > +event_notifier_test_and_clear(&s->host_notifier); > +aio_set_event_notifier(s->ctx, &s->host_notifier, NULL); > +} > + > +stati

Re: [Qemu-devel] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 19:28, Fam Zheng wrote: > We don't want new requests from guest, so block the operation around the > nested poll. > > Signed-off-by: Fam Zheng > --- > block/io.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/block/io.c b/block/io.c > index 1ce62c4..d369d

[Qemu-devel] [PATCH] spapr: ensure we have at least one XICS server

2015-05-13 Thread Greg Kurz
XICS needs to know the upper value for cpu_index as it is used to compute the number of servers: smp_cpus * kvmppc_smt_threads() / smp_threads When passing -smp cpus=1,threads=9 on a POWER8 host, we end up with: 1 * 8 / 9 = 0 ... which leads to an assertion in both emulated: Number of

Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500

2015-05-13 Thread Shlomo Pongratz
> -Original Message- > From: Pavel Fedin [mailto:p.fe...@samsung.com] > Sent: Tuesday, 12 May, 2015 3:33 PM > To: Shlomo Pongratz; qemu-devel@nongnu.org > Subject: RE: [PATCH v2] Add virt-v3 machine that uses GIC-500 > > Hello! > > > BTW did you try going beyond 16 cores I had problems w

Re: [Qemu-devel] [PATCH RFC 4/7] vhost: set vring endianness for legacy virtio

2015-05-13 Thread Cornelia Huck
On Tue, 12 May 2015 18:40:35 +0200 "Michael S. Tsirkin" wrote: > On Tue, May 12, 2015 at 06:25:32PM +0200, Cornelia Huck wrote: > > On Tue, 12 May 2015 17:15:53 +0200 > > "Michael S. Tsirkin" wrote: > > > One issue with virtio 1 patches as they are is with how features are > > > handled ATM. T

Re: [Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required

2015-05-13 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, May 12, 2015 at 12:32:53PM -0600, Eric Blake wrote: >> On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: >> > The qemu-io tool does not check if the image is encrypted so >> > historically would silently corrupt the sectors by writing >> > plain text data in

Re: [Qemu-devel] [PATCHv4] Move parallel_hds_isa_init to hw/isa/isa-bus.c

2015-05-13 Thread Markus Armbruster
mreza...@redhat.com writes: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause removing parallel_hds_isa_init defined in > parallel.c. This function is called during initialization of some boards so > disabling CONFIG_PARALLEL cause build failure. > > This patch moves parallel_hds_isa_

Re: [Qemu-devel] [PATCH v1 05/18] target-arm: Add MAIR_EL2

2015-05-13 Thread Edgar E. Iglesias
On Wed, May 13, 2015 at 10:52:55AM +0300, Sergey Fedorov wrote: > On 13.05.2015 09:52, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/helper.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/target-arm

Re: [Qemu-devel] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all

2015-05-13 Thread Fam Zheng
On Wed, 05/13 12:26, Paolo Bonzini wrote: > > > On 13/05/2015 19:28, Fam Zheng wrote: > > We don't want new requests from guest, so block the operation around the > > nested poll. > > > > Signed-off-by: Fam Zheng > > --- > > block/io.c | 12 > > 1 file changed, 12 insertions(+) >

Re: [Qemu-devel] [PATCH v2 05/11] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-13 Thread Fam Zheng
On Wed, 05/13 12:26, Paolo Bonzini wrote: > > > On 13/05/2015 19:28, Fam Zheng wrote: > > +static void virtio_blk_data_plane_pause(VirtIOBlock *vblk) > > +{ > > +VirtIOBlockDataPlane *s = vblk->dataplane; > > + > > +event_notifier_test_and_clear(&s->host_notifier); > > +aio_set_event_

Re: [Qemu-devel] [PATCH v1 05/18] target-arm: Add MAIR_EL2

2015-05-13 Thread Sergey Fedorov
On 13.05.2015 14:05, Edgar E. Iglesias wrote: > On Wed, May 13, 2015 at 10:52:55AM +0300, Sergey Fedorov wrote: >> On 13.05.2015 09:52, Edgar E. Iglesias wrote: >>> From: "Edgar E. Iglesias" >>> >>> Signed-off-by: Edgar E. Iglesias >>> --- >>> target-arm/helper.c | 8 >>> 1 file changed

Re: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction

2015-05-13 Thread Wen Congyang
On 05/14/2015 01:28 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > blockdev.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/blockdev.c b/blockdev.c > index ae52d27..bd28183 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -1649,6 +1649,7 @@ typedef

Re: [Qemu-devel] Supporting multiple CPU AddressSpaces and memory transaction attributes

2015-05-13 Thread Edgar E. Iglesias
On Wed, May 13, 2015 at 11:28:38AM +0200, Paolo Bonzini wrote: > > > On 13/05/2015 08:41, Edgar E. Iglesias wrote: > > I think it would be nice if address_space_translate_for_iotlb > > was allowed to modify the attributes so that an IOMMU in front > > of a CPU could for example down-grade a secur

Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options()

2015-05-13 Thread Max Reitz
On 08.05.2015 19:21, Kevin Wolf wrote: Eventually we want to be able to change options at runtime. As a first step towards that goal, separate some option handling code from the general initialisation code in qcow2_open(). Signed-off-by: Kevin Wolf --- block/qcow2.c | 135

Re: [Qemu-devel] [PATCH RFC 4/7] vhost: set vring endianness for legacy virtio

2015-05-13 Thread Michael S. Tsirkin
On Wed, May 13, 2015 at 12:39:07PM +0200, Cornelia Huck wrote: > On Tue, 12 May 2015 18:40:35 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, May 12, 2015 at 06:25:32PM +0200, Cornelia Huck wrote: > > > On Tue, 12 May 2015 17:15:53 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > One issue w

Re: [Qemu-devel] [PATCH 15/34] qcow2: Move qcow2_update_options() call up

2015-05-13 Thread Max Reitz
On 08.05.2015 19:21, Kevin Wolf wrote: qcow2_update_options() only updates some variables in BDRVQcowState and doesn't really depend on other parts of it being initialised yet, so it can be moved so that it immediately follows the other half of option handling code in qcow2_open(). Signed-off-by

Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options()

2015-05-13 Thread Max Reitz
On 08.05.2015 19:21, Kevin Wolf wrote: Eventually we want to be able to change options at runtime. As a first step towards that goal, separate some option handling code from the general initialisation code in qcow2_open(). Signed-off-by: Kevin Wolf --- block/qcow2.c | 135

Re: [Qemu-devel] [PATCH v2 01/11] block: Add op blocker type "device IO"

2015-05-13 Thread Wen Congyang
On 05/14/2015 01:28 AM, Fam Zheng wrote: > Preventing device from submitting IO is useful around various nested > aio_poll. Op blocker is a good place to put this flag. > > Devices would submit IO requests through blk_* block backend interface, > which calls blk_check_request to check the validity

[Qemu-devel] [RFC/RFT PATCH v2 0/3] KVM: Introduce KVM_MEM_UNCACHED

2015-05-13 Thread Andrew Jones
Introduce a new memory region flag, KVM_MEM_UNCACHED, which is needed by ARM. This flag informs KVM that the given memory region is typically mapped by the guest as non-cacheable. KVM for ARM then ensures that that memory is indeed mapped non-cacheable by the guest, and also remaps that region as n

[Qemu-devel] [RFC/RFT PATCH v2 3/3] arm/arm64: KVM: implement 'uncached' mem coherency

2015-05-13 Thread Andrew Jones
When S1 and S2 memory attributes combine wrt to caching policy, non-cacheable types take precedence. If a guest maps a region as device memory, which KVM userspace is using to emulate the device using normal, cacheable memory, then we lose coherency. With KVM_MEM_UNCACHED, KVM userspace can now hin

[Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-13 Thread Andrew Jones
Provide a method to change normal, cacheable memory to non-cacheable. KVM will make use of this to keep emulated device memory regions coherent with the guest. Signed-off-by: Andrew Jones --- arch/arm/include/asm/cacheflush.h | 1 + arch/arm/mm/pageattr.c | 7 +++ arch/arm64/i

Re: [Qemu-devel] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 13:08, Fam Zheng wrote: > > I think this isn't enough. It's the callers of bdrv_drain and > > bdrv_drain_all that need to block before drain and unblock before > > aio_context_release. > > Which callers do you mean? qmp_transaction is covered in this series. All of them. :( In s

[Qemu-devel] [RFC/RFT PATCH v2 2/3] KVM: promote KVM_MEMSLOT_INCOHERENT to uapi

2015-05-13 Thread Andrew Jones
Commit 1050dcda30529 introduced KVM_MEMSLOT_INCOHERENT to flag memory regions that may have coherency issues due to mapping host system RAM as non-cacheable. This was introduced as a KVM internal flag, but now give KVM userspace access to it so that it may use it for hinting likely problematic regi

  1   2   3   4   >