Re: [Qemu-devel] [PATCH v3 2/6] spapr_pci: encode missing 64-bit memory address space

2015-05-06 Thread Thomas Huth
On Wed, 06 May 2015 11:14:32 +0530 Nikunj A Dadhania wrote: > Thomas Huth writes: [...] > > BTW, does this also require the new version of SLOF already? > > Not yet, only after patch 4/6 newer SLOF would be needed. Ok, ... but it will also still work with old SLOF version? If not, I think you

Re: [Qemu-devel] [PATCH] parallel: Allow to disable CONFIG_PARALLEL

2015-05-06 Thread Miroslav Rezanina
On Tue, May 05, 2015 at 11:59:50AM +0200, Thomas Huth wrote: > On Tue, 5 May 2015 11:30:49 +0200 > mreza...@redhat.com wrote: > > > From: Miroslav Rezanina > > > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > > out initialization to parallel_hds_isa_init that is no

Re: [Qemu-devel] [PATCH] parallel: Allow to disable CONFIG_PARALLEL

2015-05-06 Thread Miroslav Rezanina
On Tue, May 05, 2015 at 12:32:37PM +0200, Thomas Huth wrote: > On Tue, 5 May 2015 12:18:05 +0200 > Miroslav Rezanina wrote: > > > On Tue, May 05, 2015 at 11:59:50AM +0200, Thomas Huth wrote: > > > On Tue, 5 May 2015 11:30:49 +0200 > > > mreza...@redhat.com wrote: > > > > > > > From: Miroslav Re

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Peter Crosthwaite
On Tue, May 5, 2015 at 10:43 AM, Richard Henderson wrote: > On 05/05/2015 10:19 AM, Peter Maydell wrote: >> On 5 May 2015 at 05:45, Peter Crosthwaite wrote: >>> Add the ARM specific disassembly flags setup, so ARM can be correctly >>> disassembled from the monitor. >>> >>> Signed-off-by: Peter Cr

Re: [Qemu-devel] [PATCH v3 0/3] vnc: Fixes for unix socket error handling

2015-05-06 Thread Gerd Hoffmann
On Di, 2015-05-05 at 11:07 -0400, Cole Robinson wrote: > Minor fixes for unix socket error handling, see patches for details added to vnc queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 1/6] mirror: Discard target sectors if not allocated at source side

2015-05-06 Thread wangxiaolong
I just wander if bdrv_is_allocated_above works as it is considered,migrate image in format of qcow2 run into such backtrace:#0  0x7f9e73822c6d in lseek64 () at ../sysdeps/unix/syscall-template.S:82#1  0x7f9e765f08e4 in find_allocation (bs=,    sector_num=, nb_sectors=20480, pnum=0x7f9e7bab0

Re: [Qemu-devel] [RFC PATCH v12 16/21]

2015-05-06 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 05/05/2015 12:22, Pavel Dovgaluk wrote: > > This patch is the reduced version of prior "bottom halves" patch. > > dma-helpers.c is also related to block devices, so it's better not to > change it now. Ok. > Perhaps you can add a replay even

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 10:14:32 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: > > The HMP command info cpus now displays the CPU model name and the > > backing accelerator if part of the CPUState. > > > > (qemu) info cpus > > * CPU #0: (halted) model

Re: [Qemu-devel] Bug report - Windows XP guest failure

2015-05-06 Thread Michael Tokarev
06.05.2015 08:41, Programmingkid wrote > Just wanted to note that for the i386 target, Windows XP as a guest fails to > boot. When it safe mode, loading always stops at > Windows\System32\Drivers\Mup.sys. The guest boots in QEMU 2.2.0, so this > seems to indicate a bug with the May 5th or earli

Re: [Qemu-devel] [PATCH 1/2] virtio-console: notify chardev when writable

2015-05-06 Thread Gerd Hoffmann
On Di, 2015-05-05 at 16:58 +0200, Marc-André Lureau wrote: > When the virtio serial is writable, notify the chardev backend > with qemu_chr_accept_input(). added both patches to spice patch queue. thanks, Gerd

[Qemu-devel] [PATCH 0/4] Introduce eventfd support for virtio-mmio

2015-05-06 Thread Pavel Fedin
Hello! I have updated and successfully tested an old patch set introducing eventfd support for virtio-mmio, enabling to use vhost-net with it: https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg00715.html I would like to upstream it, since virtio-mmio is still there. I know that some of y

[Qemu-devel] [Bug 1452062] Re: qemu-img will fail to convert images in 2.3.0

2015-05-06 Thread Michael Tokarev
I can't reproduce this. qemu-img convert works just fine here. qemu-img convert -f qcow2 -O qcow2 -c -o compat=0.10 x.img y.img (from a random winXP guest image). ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel

[Qemu-devel] [PATCH 1/4] virtio-mmio: introduce set_host_notifier()

2015-05-06 Thread Pavel Fedin
set_host_notifier() is introduced into virtio-mmio now. Most of codes came from virtio-pci. Signed-off-by: Ying-Shiuan Pan Signed-off-by: Pavel Fedin --- hw/virtio/virtio-mmio.c | 70 + 1 file changed, 70 insertions(+) diff --git a/hw/virtio/virt

[Qemu-devel] [PATCH 2/4] virtio-mmio: introduce set_guest_notifiers

2015-05-06 Thread Pavel Fedin
Same as host notifier of virtio-mmio, most of codes came from virtio-pci. The kvm-arm does not yet support irqfd, need to fix the hard-coded part after kvm-arm gets irqfd support. Signed-off-by: Ying-Shiuan Pan Signed-off-by: Pavel Fedin --- hw/virtio/virtio-mmio.c | 60

[Qemu-devel] [PATCH 3/4] virtio-mmio: start ioeventfd when status gets DRIVER_OK

2015-05-06 Thread Pavel Fedin
Signed-off-by: Ying-Shiuan Pan Signed-off-by: Pavel Fedin --- hw/virtio/virtio-mmio.c | 47 ++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index eab74ce..97a1fb0 100644 --- a/hw/virti

[Qemu-devel] [PATCH 4/4] Do not fail if eventfds are not supported

2015-05-06 Thread Pavel Fedin
Signed-off-by: Pavel Fedin --- hw/virtio/virtio-mmio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 97a1fb0..a86c816 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -22,6 +22,7 @@ #include "hw

Re: [Qemu-devel] [RFC PATCH v3 20/24] spapr: CPU hot unplug support

2015-05-06 Thread Bharata B Rao
On Tue, May 05, 2015 at 05:28:38PM +1000, David Gibson wrote: > On Fri, Apr 24, 2015 at 12:17:42PM +0530, Bharata B Rao wrote: > > Support hot removal of CPU for sPAPR guests by sending the hot unplug > > notification to the guest via EPOW interrupt. Release the vCPU object > > after CPU hot unplug

Re: [Qemu-devel] [RFC PATCH v3 21/24] spapr: Initialize hotplug memory address space

2015-05-06 Thread Bharata B Rao
On Tue, May 05, 2015 at 05:33:33PM +1000, David Gibson wrote: > On Fri, Apr 24, 2015 at 12:17:43PM +0530, Bharata B Rao wrote: > > Initialize a hotplug memory region under which all the hotplugged > > memory is accommodated. Also enable memory hotplug by setting > > CONFIG_MEM_HOTPLUG. > > > > Mod

Re: [Qemu-devel] [PATCH v6 12/17] target-s390x: Add S390 CPU class initialization routines

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 11:34:06 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:26PM +0200, Michael Mueller wrote: > > This patch provides routines to dynamically update the previously defined > > S390 CPU classes in the current host context. The main function performing > > this process

Re: [Qemu-devel] [RFC PATCH v3 21/24] spapr: Initialize hotplug memory address space

2015-05-06 Thread Bharata B Rao
On Tue, May 05, 2015 at 10:48:50AM +0200, Igor Mammedov wrote: > On Fri, 24 Apr 2015 12:17:43 +0530 > Bharata B Rao wrote: > > > Initialize a hotplug memory region under which all the hotplugged > > memory is accommodated. Also enable memory hotplug by setting > > CONFIG_MEM_HOTPLUG. > > > > Mod

Re: [Qemu-devel] [PATCH v3 2/6] spapr_pci: encode missing 64-bit memory address space

2015-05-06 Thread Nikunj A Dadhania
Thomas Huth writes: > On Wed, 06 May 2015 11:14:32 +0530 > Nikunj A Dadhania wrote: > >> Thomas Huth writes: > [...] >> > BTW, does this also require the new version of SLOF already? >> >> Not yet, only after patch 4/6 newer SLOF would be needed. > > Ok, ... but it will also still work with ol

Re: [Qemu-devel] [RFC PATCH v3 23/24] spapr: Support ibm, dynamic-reconfiguration-memory

2015-05-06 Thread Bharata B Rao
On Tue, May 05, 2015 at 05:40:32PM +1000, David Gibson wrote: > On Fri, Apr 24, 2015 at 12:17:45PM +0530, Bharata B Rao wrote: > > Parse ibm,architecture.vec table obtained from the guest and enable > > memory node configuration via ibm,dynamic-reconfiguration-memory if guest > > supports it. This

Re: [Qemu-devel] [RFC PATCH v3 24/24] spapr: Memory hotplug support

2015-05-06 Thread Bharata B Rao
On Tue, May 05, 2015 at 05:45:01PM +1000, David Gibson wrote: > On Fri, Apr 24, 2015 at 12:17:46PM +0530, Bharata B Rao wrote: > > Make use of pc-dimm infrastructure to support memory hotplug > > for PowerPC. > > > > Modelled on i386 memory hotplug. > > Can the previous patch actually do anything

Re: [Qemu-devel] [PATCH v1 RFC 34/34] char: introduce support for TLS encrypted TCP chardev backend

2015-05-06 Thread Kashyap Chamarthy
On Tue, May 05, 2015 at 04:54:44PM +0200, Kashyap Chamarthy wrote: [. . .] > While running QEMU as TLS server, the TLS handshake completes > successfully when connected via `gnutls-cli`. > > However, when using QEMU as client to connect to an existing GnuTLS > server, I notice a segmentation fau

Re: [Qemu-devel] [RFC PATCH v3 06/24] spapr: Consolidate cpu init code into a routine

2015-05-06 Thread Bharata B Rao
On Wed, May 06, 2015 at 08:32:03AM +0200, Thomas Huth wrote: > On Wed, 6 May 2015 09:58:09 +0530 > Bharata B Rao wrote: > > > On Mon, May 04, 2015 at 06:10:59PM +0200, Thomas Huth wrote: > > > On Fri, 24 Apr 2015 12:17:28 +0530 > > > Bharata B Rao wrote: > > > > > > > Factor out bits of sPAPR s

[Qemu-devel] [PATCH] ich9: implement SMI_LOCK

2015-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi/ich9.c | 4 +++- hw/isa/lpc_ich9.c | 19 +++ include/hw/acpi/ich9.h | 1 + include/hw/i386/ich9.h | 6 ++ 4 files changed, 29 insertions(+), 1 deletion(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index eefd8b0..86de

Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 03:45, Fam Zheng wrote: >> > This is not enough, you also have to do the discard in block/mirror.c, >> > otherwise the destination image could even become fully provisioned! > I wasn't sure what if src and dest have different can_write_zeroes_with_unmap > value, but your argument is

Re: [Qemu-devel] [PATCH v6 01/17] Introduce stub routine cpu_desc_avail

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 14:41:01 -0300 Eduardo Habkost wrote: > On Tue, May 05, 2015 at 06:12:16PM +0200, Michael Mueller wrote: > > On Tue, 5 May 2015 10:55:47 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 27, 2015 at 04:53:15PM +0200, Michael Mueller wrote: > > > > This patch introduces t

Re: [Qemu-devel] [Qemu-block] [RFC] Differential Backups

2015-05-06 Thread Stefan Hajnoczi
On Tue, May 05, 2015 at 11:55:49AM -0400, John Snow wrote: > On 05/05/2015 06:25 AM, Stefan Hajnoczi wrote: > >On Wed, Apr 29, 2015 at 06:51:08PM -0400, John Snow wrote: > >>This is a feature that should be very easy to add on top of the existing > >>incremental feature, since it's just a differenc

Re: [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h

2015-05-06 Thread Laurent Desnogues
Hello, On Mon, Apr 27, 2015 at 3:27 PM, Michael Tokarev wrote: > From: Paolo Bonzini > > This is a small step towards making libcacard standalone. on my system the removal of qemu-common.h inclusion broke compilation due to assert being used in glib-compat.h. A fix might be to include assert.h

Re: [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 11:46:04 -0300 Eduardo Habkost wrote: > On Tue, May 05, 2015 at 08:36:45AM -0600, Eric Blake wrote: > > On 05/05/2015 07:26 AM, Eduardo Habkost wrote: > > >> +{ 'enum': 'AccelId', > > >> + 'data': ['qtest', 'tcg', 'kvm', 'xen'] } > > >> + > > > > > > Not sure if it is better

Re: [Qemu-devel] [RFC PATCH v3 06/24] spapr: Consolidate cpu init code into a routine

2015-05-06 Thread Thomas Huth
On Wed, 6 May 2015 14:15:37 +0530 Bharata B Rao wrote: > On Wed, May 06, 2015 at 08:32:03AM +0200, Thomas Huth wrote: > > On Wed, 6 May 2015 09:58:09 +0530 > > Bharata B Rao wrote: > > > > > On Mon, May 04, 2015 at 06:10:59PM +0200, Thomas Huth wrote: > > > > On Fri, 24 Apr 2015 12:17:28 +0530

Re: [Qemu-devel] [PATCH v6 03/17] Extend QMP command query-cpus to return accelerator id and model name

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 10:11:15 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:17PM +0200, Michael Mueller wrote: > > The QMP command query-cpus now additionally displays a model name and > > the backing accelerator. Both are omitted if the model name is not > > initialized. > > > >

Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard

2015-05-06 Thread Fam Zheng
On Wed, 05/06 10:59, Paolo Bonzini wrote: > > > On 06/05/2015 03:45, Fam Zheng wrote: > >> > This is not enough, you also have to do the discard in block/mirror.c, > >> > otherwise the destination image could even become fully provisioned! > > I wasn't sure what if src and dest have different >

Re: [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 10:26:02 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote: > > The patch defines ids per accelerator and adds the accel_id and > > the model_name to the CPUState. The accel_id is initialized by > > common code, the model name needs

Re: [Qemu-devel] qemu-img convert (vmdk)

2015-05-06 Thread Kevin Wolf
Am 05.05.2015 um 19:01 hat Antoni Villalonga geschrieben: > Hi, > > Is my first email to that list ;) > > > I can reproduce this bug with v2.2 and v2.3. I'm not sure about the results > after testing with v2.1 (doesn't show errors but seems to be still broken). > > % qemu-img convert -f raw -O

[Qemu-devel] [Bug 1452062] Re: qemu-img will fail to convert images in 2.3.0

2015-05-06 Thread Kevin Wolf
The only possibly relevant change I can see in 2.3 is that the qcow2 driver added an additional error check to a truncate operation. Can you please run qemu-img under strace -f and either provide the output as an attachment or paste the relevant failing call(s) if you can recognise them? -- You r

Re: [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h

2015-05-06 Thread Michael Tokarev
06.05.2015 12:23, Laurent Desnogues wrote: > Hello, > > On Mon, Apr 27, 2015 at 3:27 PM, Michael Tokarev wrote: >> From: Paolo Bonzini >> >> This is a small step towards making libcacard standalone. > > on my system the removal of qemu-common.h inclusion broke compilation > due to assert being

Re: [Qemu-devel] qemu-img convert (vmdk)

2015-05-06 Thread Antoni Villalonga
Hi again, it seems to be related to the subformat option. With the default option seems to work fine. I think StreamOptimized is mantatory for 'ova' files. Thanks On Tue, May 05, 2015 at 05:01:34PM +, Antoni Villalonga wrote: > Hi, > > Is my first email to that list ;) > > > I can reprod

Re: [Qemu-devel] [PULL 00/40] drop qapi nested structs

2015-05-06 Thread Peter Maydell
On 5 May 2015 at 17:46, Markus Armbruster wrote: > We want to eventually allow qapi defaults, by making: > 'data':{'*flag':'bool'} > as shorthand for something like: > 'data':{'flag':{'type':'bool', 'optional':true}} > so that the default can be specified: >'data':{'flag':{'type':'bool',

[Qemu-devel] [vhost] vhost_get_vq_desc, vq->iov mapping

2015-05-06 Thread Vasile Catalin-B50542
From what I know, qemu and vhost backends use some functions in order to access the memory between the guest and the backend. From what I see, vhost does this with vhost_get_vq_desc(). How much do vq->iov mappings remain valid? Does it get unmapped at some time (you could answer me within vhost-

Re: [Qemu-devel] [PATCH v1 RFC 34/34] char: introduce support for TLS encrypted TCP chardev backend

2015-05-06 Thread Daniel P. Berrange
On Wed, May 06, 2015 at 10:34:06AM +0200, Kashyap Chamarthy wrote: > On Tue, May 05, 2015 at 04:54:44PM +0200, Kashyap Chamarthy wrote: > > [. . .] > > > While running QEMU as TLS server, the TLS handshake completes > > successfully when connected via `gnutls-cli`. > > > > However, when using QE

Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 11:50, Fam Zheng wrote: > # src can_write_zeroes_with_unmap target can_write_zeroes_with_unmap > > 1 true true > 2 true

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-06 Thread Eduardo Habkost
On Wed, May 06, 2015 at 09:32:58AM +0200, Michael Mueller wrote: > On Tue, 5 May 2015 10:14:32 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: > > > The HMP command info cpus now displays the CPU model name and the > > > backing accelerator if

Re: [Qemu-devel] qemu-img convert (vmdk)

2015-05-06 Thread Fam Zheng
On Wed, 05/06 12:01, Kevin Wolf wrote: > Am 05.05.2015 um 19:01 hat Antoni Villalonga geschrieben: > > Hi, > > > > Is my first email to that list ;) > > > > > > I can reproduce this bug with v2.2 and v2.3. I'm not sure about the results > > after testing with v2.1 (doesn't show errors but seems

Re: [Qemu-devel] [PATCH v6 01/17] Introduce stub routine cpu_desc_avail

2015-05-06 Thread Eduardo Habkost
On Wed, May 06, 2015 at 11:17:20AM +0200, Michael Mueller wrote: > On Tue, 5 May 2015 14:41:01 -0300 > Eduardo Habkost wrote: > > > On Tue, May 05, 2015 at 06:12:16PM +0200, Michael Mueller wrote: > > > On Tue, 5 May 2015 10:55:47 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Apr 27,

[Qemu-devel] [RFC PATCH 1/7] block: Add op blocker type "device IO"

2015-05-06 Thread Fam Zheng
Preventing device from submitting IO is useful around various nested poll. Op blocker is a good place to put this flag. Devices would submit IO requests through blk_* block backend interface, which calls blk_check_request to check the validity. Return -EBUSY if the operation is blocked, in which c

[Qemu-devel] [RFC PATCH 2/7] block: Block "device IO" during bdrv_drain and bdrv_drain_all

2015-05-06 Thread Fam Zheng
We don't want new requests from guest, so block the operation around the nested poll. Signed-off-by: Fam Zheng --- block/io.c | 12 1 file changed, 12 insertions(+) diff --git a/block/io.c b/block/io.c index 1ce62c4..d369de3 100644 --- a/block/io.c +++ b/block/io.c @@ -289,9 +289,1

[Qemu-devel] [RFC PATCH 0/7] Fix transactional snapshot with virtio-blk dataplane

2015-05-06 Thread Fam Zheng
Reported by Paolo. Unlike the iohandler in main loop, iothreads currently process the event notifier used as virtio-blk ioeventfd in all nested aio_poll. This is dangerous without proper protection, because guest requests could sneak to block layer where they mustn't. For example, a QMP transacti

[Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list

2015-05-06 Thread Fam Zheng
BDS users can register a notifier and get notified about op blocker changes. Signed-off-by: Fam Zheng --- block.c | 20 include/block/block.h | 8 include/block/block_int.h | 3 +++ 3 files changed, 31 insertions(+) diff --git a/block.c b/bl

[Qemu-devel] [RFC PATCH 5/7] virtio-blk: Move complete_request to 'ops' structure

2015-05-06 Thread Fam Zheng
Should more ops be added to differentiate code between dataplane and non-dataplane, the new saved_ops approach will be cleaner than messing with N pointers. Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 13 - hw/block/virtio-blk.c | 8 ++-- include/hw/

[Qemu-devel] [RFC PATCH 4/7] block-backend: Add blk_op_blocker_add_notifier

2015-05-06 Thread Fam Zheng
Forward the call to bdrv_op_blocker_add_notifier. Signed-off-by: Fam Zheng --- block.c| 4 ++-- block/block-backend.c | 6 ++ include/sysemu/block-backend.h | 2 ++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 054ddb

[Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-06 Thread Fam Zheng
virtio-blk now listens to op blocker change of the associated block backend. Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO: non-dataplane: 1) Set VirtIOBlock.paused 2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paused dataplane: 1) Clear the host event notifier

[Qemu-devel] [RFC PATCH 7/7] blockdev: Add "device IO" op blocker during snapshot transaction

2015-05-06 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..859fa2e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1398,6 +1398,7 @@ typedef struct ExternalSnapshotState { BlockDriverState *old_bs; BlockDriverSt

[Qemu-devel] [PATCH] qcow2: Flush pending discards before allocating cluster

2015-05-06 Thread Kevin Wolf
Before a freed cluster can be reused, pending discards for this cluster must be processed. The original assumption was that this was not a problem because discards are only cached during discard/write zeroes operations, which are synchronous so that no concurrent write requests can cause cluster a

[Qemu-devel] [PATCH] serial: fix multi-pci card error cleanup.

2015-05-06 Thread Gerd Hoffmann
Put the number of serial ports into a local variable in multi_serial_pci_realize, then increment the port count (pci->ports) as we initialize the serial port cores. Now pci->ports always holds the number of successfully initialized ports and we can use multi_serial_pci_exit to properly cleanup the

Re: [Qemu-devel] [PATCH v6 03/17] Extend QMP command query-cpus to return accelerator id and model name

2015-05-06 Thread Eduardo Habkost
On Wed, May 06, 2015 at 11:49:50AM +0200, Michael Mueller wrote: > On Tue, 5 May 2015 10:11:15 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 27, 2015 at 04:53:17PM +0200, Michael Mueller wrote: > > > The QMP command query-cpus now additionally displays a model name and > > > the backing accele

Re: [Qemu-devel] [PATCH v1 RFC 34/34] char: introduce support for TLS encrypted TCP chardev backend

2015-05-06 Thread Kashyap Chamarthy
On Wed, May 06, 2015 at 11:18:23AM +0100, Daniel P. Berrange wrote: > On Wed, May 06, 2015 at 10:34:06AM +0200, Kashyap Chamarthy wrote: > > On Tue, May 05, 2015 at 04:54:44PM +0200, Kashyap Chamarthy wrote: > > > > [. . .] > > > > > While running QEMU as TLS server, the TLS handshake completes >

Re: [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState

2015-05-06 Thread Eduardo Habkost
On Wed, May 06, 2015 at 11:59:38AM +0200, Michael Mueller wrote: > On Tue, 5 May 2015 10:26:02 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote: > > > The patch defines ids per accelerator and adds the accel_id and > > > the model_name to the CP

Re: [Qemu-devel] [PULL] Queued tcg patch

2015-05-06 Thread Peter Maydell
On 6 May 2015 at 00:24, Richard Henderson wrote: > Only one tcg related patch since the 2.3 freeze. > > > r~ > > > > The following changes since commit 874e9aeeeb74c5459639a93439a502d262847e68: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-sdl-20150505-1' into > staging (2015-05-05

Re: [Qemu-devel] [PATCH 4/4] qemu-ga: Building Windows MSI installation with configure/Makefile

2015-05-06 Thread Yossi Hindin
I am submitting second version of patches. - Original Message - > From: "Paolo Bonzini" > To: "Yossi Hindin" , qemu-devel@nongnu.org > Cc: yvuge...@redhat.com, dfley...@redhat.com, mdr...@linux.vnet.ibm.com > Sent: Monday, May 4, 2015 12:03:02 PM > Subject: Re: [PATCH 4/4] qemu-ga: Bui

Re: [Qemu-devel] [PATCH 4/4] qemu-ga: Building Windows MSI installation with configure/Makefile

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 13:53, Yossi Hindin wrote: >>> > > +${QEMU_GA_MSI}: config-host.mak >>> > > + >>> > > +${QEMU_GA_MSI}: qga/installer/qemu-ga.wxs >>> > > + $(call quiet-command,QEMU_GA_VERSION="$(QEMU_GA_VERSION)" >>> > > QEMU_GA_MANUFACTURER="$(QEMU_GA_MANUFACTURER)" >>> > > QEMU_GA_DISTRO="

[Qemu-devel] [Patch V2 2/4] qemu-ga: debug printouts to help troubleshoot installation

2015-05-06 Thread Yossi Hindin
Debug printouts extended, helps installation troubleshooting Signed-off-by: Yossi Hindin --- qga/channel-win32.c | 2 +- qga/commands-win32.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 0d5e5f5..04fa5e4 100644 --- a/qga/ch

[Qemu-devel] [Patch V2 0/4] [Patch V2 0/4] Windows MSI installation package

2015-05-06 Thread Yossi Hindin
The second version of commits's set take into account Paolo Bonzini remarks. Typo in WXS file fixed, QEMU GA-related CLI options renamed, '--enable-guest-agent-msi'/ '--disable-guest-agent-msi' processing logic changed so that MSI build is configured by default, unless some prerequisite is missi

[Qemu-devel] [Patch V2 1/4] qemu-ga: adding vss-[un]install options

2015-05-06 Thread Yossi Hindin
Existing command line options include '-s install' and '-s uninstall'. These options install/uninstall both Windows QEMU GA service and optional VSS COM server. The QEMU GA Windows service allows always-on serving guest agent's QMP commands and VSS COM server enables guest agent integration with Vo

[Qemu-devel] [Patch V2 4/4] qemu-ga: Building Windows MSI installation with configure/Makefile

2015-05-06 Thread Yossi Hindin
New options were added to enable Windows MSI installation package creation: Option --enable-guest-agent-msi, like the name suggests, enables building Windows MSI package for QEMU guest agent; option --disable-guest-agent-msi disables MSI package creation; by default, no MSI package is created Sig

[Qemu-devel] [Patch V2 3/4] qemu-ga: Introduce Windows MSI script

2015-05-06 Thread Yossi Hindin
The script enables building Windows MSI installation package on Linux with wixl tool. Signed-off-by: Yossi Hindin --- qga/installer/qemu-ga.wxs | 145 ++ 1 file changed, 145 insertions(+) create mode 100644 qga/installer/qemu-ga.wxs diff --git a/qga

Re: [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h

2015-05-06 Thread Laurent Desnogues
On Wed, May 6, 2015 at 12:05 PM, Michael Tokarev wrote: > 06.05.2015 12:23, Laurent Desnogues wrote: >> Hello, >> >> On Mon, Apr 27, 2015 at 3:27 PM, Michael Tokarev wrote: >>> From: Paolo Bonzini >>> >>> This is a small step towards making libcacard standalone. >> >> on my system the removal of

Re: [Qemu-devel] qemu-img convert (vmdk)

2015-05-06 Thread Fam Zheng
On Wed, 05/06 10:15, Antoni Villalonga wrote: > > Hi again, it seems to be related to the subformat option. With the default > option seems to work fine. > > I think StreamOptimized is mantatory for 'ova' files. I guess I see the problem now - the data is corrupted due to a wrong cluster allocat

[Qemu-devel] [PATCH RFC 0/7] vhost: cross-endian support (vhost-net only)

2015-05-06 Thread Greg Kurz
Hi, This series allows QEMU to use vhost with legacy virtio devices when host and target don't have the same endianness. Only network devices are covered for the moment. I had already posted a series some monthes ago but it never got reviewed. Moreover, the underlying kernel support was entirely

Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 13:23, Fam Zheng wrote: > virtio-blk now listens to op blocker change of the associated block > backend. > > Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO: > > non-dataplane: >1) Set VirtIOBlock.paused >2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paus

[Qemu-devel] [PATCH RFC 2/7] linux-headers: sync vhost.h

2015-05-06 Thread Greg Kurz
This patch brings the cross-endian vhost API to QEMU. Signed-off-by: Greg Kurz --- linux-headers/linux/vhost.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/linux-headers/linux/vhost.h b/linux-headers/linux/vhost.h index c656f61..ead86db 100644 --- a/linux-headers/linux/v

[Qemu-devel] [PATCH RFC 6/7] vhost-net: tell tap backend about the vnet endianness

2015-05-06 Thread Greg Kurz
The default behaviour for TAP/MACVTAP is to consider vnet as native endian. This patch handles the cases when this is not true: - virtio 1.0: always little-endian - legacy cross-endian Signed-off-by: Greg Kurz --- hw/net/vhost_net.c | 33 - 1 file changed, 32 i

[Qemu-devel] [PATCH RFC 1/7] virtio: relax feature check

2015-05-06 Thread Greg Kurz
Unlike with add and clear, there is no valid reason to abort when checking for a feature. It makes more sense to return false (i.e. the feature bit isn't set). This is exactly what __virtio_has_feature() does if fbit >= 32. This allows to introduce code that is aware about new 64-bit features like

[Qemu-devel] [PATCH RFC 5/7] tap: add VNET_LE/VNET_BE operations

2015-05-06 Thread Greg Kurz
The linux tap and macvtap backends can be told to parse vnet headers according to little or big endian. This is done through the TUNSETVNETLE and TUNSETVNETBE ioctls. This patch brings all the plumbing for QEMU to use these APIs. Signed-off-by: Greg Kurz --- include/net/net.h |6 ++ net

[Qemu-devel] [PATCH RFC 3/7] virtio: introduce virtio_legacy_is_cross_endian()

2015-05-06 Thread Greg Kurz
This helper will be used by vhost and tap to detect cross-endianness in the legacy virtio case. Signed-off-by: Greg Kurz --- include/hw/virtio/virtio-access.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access

[Qemu-devel] [PATCH RFC 4/7] vhost: set vring endianness for legacy virtio

2015-05-06 Thread Greg Kurz
Legacy virtio is native endian: if the guest and host endianness differ, we have to tell vhost so it can swap bytes where appropriate. This is done through a vhost ring ioctl. Signed-off-by: Greg Kurz --- hw/virtio/vhost.c | 50 +- 1 file changed

[Qemu-devel] [PATCH RFC 7/7] vhost_net: re-enable when cross endian

2015-05-06 Thread Greg Kurz
From: Cédric Le Goater Cross-endianness is now checked by the core vhost code. revert 371df9f5e0f1 "vhost-net: disable when cross-endian" Signed-off-by: Cédric Le Goater [ added commit message, Greg Kurz ] Signed-off-by: Greg Kurz --- hw/net/vhost_net.c | 19 --- 1 file ch

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Maydell
On 1 May 2015 at 18:25, Peter Crosthwaite wrote: > Ping! > > On Fri, Apr 24, 2015 at 1:28 PM, Peter Crosthwaite > wrote: >> Hi Peter and all, >> >> Xilinx's next gen SoC has been announced. This series adds a SoC and >> board. Neither patchwork nor patches seem to have the complete set of these

Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-06 Thread Fam Zheng
On Wed, 05/06 14:07, Paolo Bonzini wrote: > > > On 06/05/2015 13:23, Fam Zheng wrote: > > virtio-blk now listens to op blocker change of the associated block > > backend. > > > > Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO: > > > > non-dataplane: > >1) Set VirtIOBlock.paused > >

Re: [Qemu-devel] [PATCH v6 12/17] target-s390x: Add S390 CPU class initialization routines

2015-05-06 Thread Eduardo Habkost
On Wed, May 06, 2015 at 10:02:22AM +0200, Michael Mueller wrote: > On Tue, 5 May 2015 11:34:06 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 27, 2015 at 04:53:26PM +0200, Michael Mueller wrote: > > > This patch provides routines to dynamically update the previously defined > > > S390 CPU class

[Qemu-devel] [PATCH] vmdk: Fix next_cluster_sector for compressed write

2015-05-06 Thread Fam Zheng
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster allocation). Sometimes, write_len could be larger than cluster size, because it contains both data and marker. We must advance next_cluster_sector in this case, otherwise the image gets corrupted. Reported-by: Antoni Villalo

Re: [Qemu-devel] [PATCH v6 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-05-06 Thread Eduardo Habkost
On Mon, Apr 27, 2015 at 04:53:29PM +0200, Michael Mueller wrote: [...] > #ifndef CONFIG_USER_ONLY > +static CpuDefinitionInfoList *qmp_query_cpu_definition_host(void) > +{ > +CpuDefinitionInfoList *host = NULL; > +CpuDefinitionInfo *info; > + > +info = g_try_new0(CpuDefinitionInfo, 1);

Re: [Qemu-devel] [PATCH v6 05/17] Add optional parameters to QMP command query-cpu-definitions

2015-05-06 Thread Eduardo Habkost
On Mon, Apr 27, 2015 at 04:53:19PM +0200, Michael Mueller wrote: [...] > diff --git a/qapi-schema.json b/qapi-schema.json > index 215a7bc..285b2d3 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2536,21 +2536,43 @@ > # > # @name: the name of the CPU definition > # > +# @default: #

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Crosthwaite
On Wed, May 6, 2015 at 5:14 AM, Peter Maydell wrote: > On 1 May 2015 at 18:25, Peter Crosthwaite > wrote: >> Ping! >> >> On Fri, Apr 24, 2015 at 1:28 PM, Peter Crosthwaite >> wrote: >>> Hi Peter and all, >>> >>> Xilinx's next gen SoC has been announced. This series adds a SoC and >>> board. > >

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-06 Thread Luiz Capitulino
On Wed, 6 May 2015 07:38:53 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 09:32:58AM +0200, Michael Mueller wrote: > > On Tue, 5 May 2015 10:14:32 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: > > > > The HMP command info cp

[Qemu-devel] [PATCH 01/14] uhci: QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Cc: Gerd Hoffmann Signed-off-by: Gonglei --- hw/usb/hcd-uhci.c | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 327f26d..64a7d87 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/us

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Crosthwaite
On Wed, May 6, 2015 at 5:14 AM, Peter Maydell wrote: > On 1 May 2015 at 18:25, Peter Crosthwaite > wrote: >> Ping! >> >> On Fri, Apr 24, 2015 at 1:28 PM, Peter Crosthwaite >> wrote: >>> Hi Peter and all, >>> >>> Xilinx's next gen SoC has been announced. This series adds a SoC and >>> board. > >

[Qemu-devel] [PATCH 12/14] usb: usb-wacom-tablet QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-wacom.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c index 844eafa..c2450e7 100644 --- a/hw/usb/dev-wacom.c +++ b/hw/usb/dev-wacom.c @@ -56,6 +56,9 @@ typedef struct USBWa

[Qemu-devel] [PATCH 06/14] usb: usb-mtp QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-mtp.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 108ece8..c9c1f32 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -130,6 +130,9 @@ struct MTPState { QT

[Qemu-devel] [PATCH 09/14] usb: usb-ccid QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-smartcard-reader.c | 50 --- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 78ce681..2d29367 100644 --- a/hw/usb/dev-s

[Qemu-devel] [PATCH 03/14] usb: usb-bt QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-bluetooth.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/usb/dev-bluetooth.c b/hw/usb/dev-bluetooth.c index 9bf6730..b19ec76 100644 --- a/hw/usb/dev-bluetooth.c +++ b/hw/usb/dev-bluetooth.c @@ -49,6 +49,

[Qemu-devel] [PATCH 00/14] usb: QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Because DO_UPCAST() is long deprecated, let me do some cleanup work for usb sub-system, which I have said in previous conversation of a bugfix. Patch 7 is a bugfix. Please review, thanks :) Gonglei (14): uhci: QOMify usb: usb-audio QOMify usb: usb-bt QOMify usb: usb-hi

[Qemu-devel] [PATCH 04/14] usb: usb-hid QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-hid.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 507c966..9623e72 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -51,6 +51,9 @@ ty

[Qemu-devel] [PATCH 10/14] usb: usb-storage QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-storage.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index ae8d40d..abe0e1d 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@

[Qemu-devel] [PATCH 11/14] usb: usb-uas QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-uas.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 04fc515..38b26c5 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -127,6 +127,9 @@ struct UASDevice {

[Qemu-devel] [PATCH 13/14] usb: usb-redir QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/redirect.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 2416de8..242a654 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -130,6 +130,9 @@ stru

[Qemu-devel] [PATCH 07/14] usb-mtp: fix segmentation fault

2015-05-06 Thread arei.gonglei
From: Gonglei When x-root property not be configured, will cause segfault because of null pointer accessing. Add a check for s->root property avoid segfault. Signed-off-by: Gonglei --- hw/usb/dev-mtp.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c

[Qemu-devel] [PATCH 05/14] usb: usb-hub QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-hub.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c index 0482f58..c8c6855 100644 --- a/hw/usb/dev-hub.c +++ b/hw/usb/dev-hub.c @@ -41,6 +41,9 @@ typedef struct USBHubState

[Qemu-devel] [PATCH 08/14] usb: usb-net QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-network.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 1866991..5f2ffd0 100644 --- a/hw/usb/dev-network.c +++ b/hw/usb/dev-network.c @@ -648,6 +648,9 @@ typed

  1   2   3   4   >