[Qemu-devel] [PATCH v3 0/3] Support more than 8 MMU modes, speedup PPC by 10%

2015-05-05 Thread Paolo Bonzini
Patches 1 and 2 enable support from more than 8 MMU modes in TCG (patch 1 is in the targets, patch 2 is in cpu-defs.h). The TLB size is reduced proportionally on targets where that is necessary. Patch 3 uses the new support in the PPC target. Paolo v2->v3: - change i386 TCG_TARGET_TLB_DISPLACEM

[Qemu-devel] [PATCH v2 1/3] tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS

2015-05-05 Thread Paolo Bonzini
This will be used to size the TLB when more than 8 MMU modes are used by the target. Limitations come from the limited size of the immediate fields (which sometimes, as in the case of Aarch64, extend to instructions that shift the immediate). Signed-off-by: Paolo Bonzini Message-Id: <1424436345-

[Qemu-devel] [PATCH v2 2/3] softmmu: support up to 12 MMU modes

2015-05-05 Thread Paolo Bonzini
At 8k per TLB (for 64-bit host or target), 8 or more modes make the TLBs bigger than 64k, and some RISC TCG backends do not like that. On the affected hosts, cut the TLB size in half---there is still a measurable speedup on PPC with the next patch. Signed-off-by: Paolo Bonzini Message-Id: <14244

[Qemu-devel] [PATCH v2 3/3] target-ppc: use separate indices for various translation modes

2015-05-05 Thread Paolo Bonzini
PowerPC TCG flushes the TLB on every IR/DR change, which basically means on every user<->kernel context switch. Encode IR/DR in the MMU index. This brings the number of TLB flushes down from ~90 to ~5 for starting up the Debian installer, which is in line with x86 and gives a ~10% perform

Re: [Qemu-devel] [PATCH] sheepdog: fix resource leak with sd_snapshot_create

2015-05-05 Thread Markus Armbruster
zhanghailiang writes: > Signed-off-by: zhanghailiang > --- > block/sheepdog.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index 2d5f06a..bd7cbed 100644 > --- a/block/sheepdog.c > +++ b/block/sheepdog.c > @@ -2341,6 +2341,7 @@ static int sd_snap

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault

2015-05-05 Thread Fam Zheng
On Thu, 04/30 17:50, Paolo Bonzini wrote: > John, Fam, > > I got this report offlist. This happens if a bit in the hbitmap is > cleared and the HBitmap has _not_ yet reached the bit. See this comment > in include/qemu/hbitmap.h: > > * Resetting bits before the current > * position of the iter

Re: [Qemu-devel] [RFC PATCH v3 16/24] qom: Introduce object_has_no_children() API

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:38PM +0530, Bharata B Rao wrote: > This QOM API can be used to check of an object has any child objects > associated with it. > > Needed by PowerPC CPU hotplug code to release parent CPU core and > socket objects only after ascertaining that they don't have any child

Re: [Qemu-devel] [RFC PATCH v3 11/24] ppc: Create sockets and cores for CPUs

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:33PM +0530, Bharata B Rao wrote: > ppc machine init functions create individual CPU threads. Change this > for sPAPR by switching to socket creation. CPUs are created recursively > by socket and core instance init routines. > > TODO: Switching to socket level CPU crea

Re: [Qemu-devel] [RFC PATCH v3 08/24] ppc: Prepare CPU socket/core abstraction

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:30PM +0530, Bharata B Rao wrote: As Thomas says, this really needs a commit message. I also think building this infrastructure is a bit premature when the discussion is ongoing about how to do this geerically. What I'd suggest is just have the minimal set you need,

Re: [Qemu-devel] [RFC PATCH v3 13/24] cpus: Add Error argument to cpu_exec_init()

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:35PM +0530, Bharata B Rao wrote: > Add an Error argument to cpu_exec_init() to let users collect the > error. Change all callers to currently pass NULL error argument. This change > is needed for the following reasons: > > - A subsequent commit changes the CPU enumera

Re: [Qemu-devel] [RFC PATCH v3 15/24] ppc: Move cpu_exec_init() call to realize function

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:37PM +0530, Bharata B Rao wrote: > Move cpu_exec_init() call from instance_init to realize. This allows > any failures from cpu_exec_init() to be handled appropriately. > Correspondingly move cpu_exec_exit() call from instance_finalize > to unrealize. > > Signed-off-b

Re: [Qemu-devel] [RFC PATCH v3 18/24] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:40PM +0530, Bharata B Rao wrote: > When supporting CPU hot removal by parking the vCPU fd and reusing > it during hotplug again, there can be cases where we try to reenable > KVM_CAP_IRQ_XICS CAP for the vCPU for which it was already enabled. > Introduce a boolean memb

Re: [Qemu-devel] [RFC PATCH v3 12/24] spapr: CPU hotplug support

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:34PM +0530, Bharata B Rao wrote: > Support CPU hotplug via device-add command. Set up device tree > entries for the hotplugged CPU core and use the exising EPOW event > infrastructure to send CPU hotplug notification to the guest. > > Also support cold plugged CPUs th

Re: [Qemu-devel] [RFC PATCH v3 24/24] spapr: Memory hotplug support

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:46PM +0530, Bharata B Rao wrote: > Make use of pc-dimm infrastructure to support memory hotplug > for PowerPC. > > Modelled on i386 memory hotplug. Can the previous patch actually do anything without this one? If not, might as well fold them together. > > Signed-of

Re: [Qemu-devel] [RFC PATCH v3 10/24] ppc: Update cpu_model in MachineState

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:32PM +0530, Bharata B Rao wrote: > Keep cpu_model field in MachineState uptodate so that it can be used > from the CPU hotplug path. > > Signed-off-by: Bharata B Rao > Reviewed-by: David Gibson As before, this looks fine to me, but I'm not sure which tree it should

Re: [Qemu-devel] [RFC PATCH v3 21/24] spapr: Initialize hotplug memory address space

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:43PM +0530, Bharata B Rao wrote: > Initialize a hotplug memory region under which all the hotplugged > memory is accommodated. Also enable memory hotplug by setting > CONFIG_MEM_HOTPLUG. > > Modelled on i386 memory hotplug. > > Signed-off-by: Bharata B Rao So, the

Re: [Qemu-devel] [RFC PATCH v3 23/24] spapr: Support ibm, dynamic-reconfiguration-memory

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:45PM +0530, Bharata B Rao wrote: > Parse ibm,architecture.vec table obtained from the guest and enable > memory node configuration via ibm,dynamic-reconfiguration-memory if guest > supports it. This is in preparation to support memory hotplug for > sPAPR guests. > > T

Re: [Qemu-devel] [RFC PATCH v3 22/24] numa: API to lookup NUMA node by address

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:44PM +0530, Bharata B Rao wrote: > Keep track of start and end address of each NUMA node in numa_info > structure so that lookup of node by address becomes easier. Add > an API get_numa_node() to lookup a node by address. > > This is needed by PowerPC memory hotplug i

Re: [Qemu-devel] [RFC PATCH v3 20/24] spapr: CPU hot unplug support

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:42PM +0530, Bharata B Rao wrote: > Support hot removal of CPU for sPAPR guests by sending the hot unplug > notification to the guest via EPOW interrupt. Release the vCPU object > after CPU hot unplug so that vCPU fd can be parked and reused. > > Signed-off-by: Bharata

Re: [Qemu-devel] [RFC PATCH v3 14/24] cpus: Convert cpu_index into a bitmap

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:36PM +0530, Bharata B Rao wrote: > Currently CPUState.cpu_index is monotonically increasing and a newly > created CPU always gets the next higher index. The next available > index is calculated by counting the existing number of CPUs. This is > fine as long as we only

Re: [Qemu-devel] [PATCH] qmp: Add qom-path field to query-cpus command

2015-05-05 Thread David Gibson
On Mon, May 04, 2015 at 04:09:58PM -0300, Eduardo Habkost wrote: > This will allow clients to query additional information directly using > qom-get on the CPU objects. > > Signed-off-by: Eduardo Habkost I'm not sure if it's the only way to accomplish what we need in these new schemes, but it see

Re: [Qemu-devel] [RFC PATCH v3 17/24] cpus: Reclaim vCPU objects

2015-05-05 Thread David Gibson
On Fri, Apr 24, 2015 at 12:17:39PM +0530, Bharata B Rao wrote: > From: Gu Zheng > > In order to deal well with the kvm vcpus (which can not be removed without any > protection), we do not close KVM vcpu fd, just record and mark it as stopped > into a list, so that we can reuse it for the appendin

Re: [Qemu-devel] [PATCH] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

2015-05-05 Thread David Gibson
On Tue, May 05, 2015 at 08:42:36AM +0200, Thomas Huth wrote: > On Tue, 5 May 2015 11:00:01 +1000 > David Gibson wrote: > > > qemu currently implements the hypercalls H_LOGICAL_CI_LOAD and > > H_LOGICAL_CI_STORE as PAPR extensions. These are used by the SLOF firmware > > for IO, because performi

Re: [Qemu-devel] [PATCH v5 15/20] hw/acpi/aml-build: Add aml_not() term

2015-05-05 Thread Igor Mammedov
On Tue, 5 May 2015 10:45:06 +0800 Shannon Zhao wrote: > On 2015/4/15 21:25, Shannon Zhao wrote: > > From: Shannon Zhao > > > > Signed-off-by: Shannon Zhao > > Signed-off-by: Shannon Zhao > > Reviewed-by: Alex Bennée > > --- > > hw/acpi/aml-build.c | 9 + > > include/hw/acpi/

Re: [Qemu-devel] [RFC PATCH v11 00/23] Deterministic replay core

2015-05-05 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 27/04/2015 09:32, Pavel Dovgalyuk wrote: > > This set of patches is related to the reverse execution and deterministic > > replay of qemu execution. This implementation of deterministic replay can > > be used for deterministic debugging of gue

Re: [Qemu-devel] [RFC PATCH v3 21/24] spapr: Initialize hotplug memory address space

2015-05-05 Thread Igor Mammedov
On Fri, 24 Apr 2015 12:17:43 +0530 Bharata B Rao wrote: > Initialize a hotplug memory region under which all the hotplugged > memory is accommodated. Also enable memory hotplug by setting > CONFIG_MEM_HOTPLUG. > > Modelled on i386 memory hotplug. > > Signed-off-by: Bharata B Rao > --- > defau

[Qemu-devel] [PULL 0/1] coverity: fix address_space_rw model

2015-05-05 Thread Markus Armbruster
The following changes since commit 5bccbb04a4abba7af4398de992bf06d585fd1333: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2015-04-30 20:34:54 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-cov-model-2015-05-05 for

Re: [Qemu-devel] [PATCH v3 0/6] spapr_pci: DT field fixes and PCI DT node creation in QEMU

2015-05-05 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > The patch series creates PCI device tree(DT) nodes in QEMU. The new > hotplug code needs the device node creation in QEMU. While during > boot, nodes were created in SLOF. It makes more sense to consolidate > the code to one place for better maintainability. > > Based

[Qemu-devel] [PULL 1/1] coverity: fix address_space_rw model

2015-05-05 Thread Markus Armbruster
From: Paolo Bonzini If the is_write argument is true, address_space_rw writes to memory and thus reads from the buffer. The opposite holds if is_write is false. Fix the model. Cc: Markus Armbruster Signed-off-by: Paolo Bonzini Signed-off-by: Markus Armbruster --- scripts/coverity-model.c |

[Qemu-devel] [PATCH v3 0/6] spapr_pci: DT field fixes and PCI DT node creation in QEMU

2015-05-05 Thread Nikunj A Dadhania
The patch series creates PCI device tree(DT) nodes in QEMU. The new hotplug code needs the device node creation in QEMU. While during boot, nodes were created in SLOF. It makes more sense to consolidate the code to one place for better maintainability. Based on David's spapr-next https://github.c

[Qemu-devel] [PATCH v3 1/6] spapr_pci: remove duplicate macros

2015-05-05 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 2e7590c..4df3a33 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1475,17 +1475,6 @@ PCIHostState *spapr_create_phb(sPA

[Qemu-devel] [PATCH v3 2/6] spapr_pci: encode missing 64-bit memory address space

2015-05-05 Thread Nikunj A Dadhania
The properties reg/assigned-resources need to encode 64-bit memory address space as part of phys.hi dword. 00 if configuration space 01 if IO region, 10 if 32-bit MEM region 11 if 64-bit MEM region Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 10 +- 1 file changed,

[Qemu-devel] [PATCH v3 4/6] spapr_pci: enumerate and add PCI device tree

2015-05-05 Thread Nikunj A Dadhania
All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch adds the pci device node creation in Qemu. For backwa

[Qemu-devel] [PATCH v3 3/6] spapr_pci: encode class code including Prog IF register

2015-05-05 Thread Nikunj A Dadhania
Current code missed the Prog IF register. All Class Code, Subclass, and Prog IF registers are needed to identify the accurate device type. For example: USB controllers use the PROG IF for denoting: USB FullSpeed, HighSpeed or SuperSpeed. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c |

[Qemu-devel] [PATCH v3 3/4] spapr: enumerate and add PCI device tree

2015-05-05 Thread Nikunj A Dadhania
All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch adds the pci device node creation in Qemu. For backwa

[Qemu-devel] [PATCH v3 6/6] spapr_pci: populate ibm,loc-code

2015-05-05 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to identi

[Qemu-devel] [PATCH v3 5/6] spapr_pci: fix boot-time device tree fields for pci hotplug

2015-05-05 Thread Nikunj A Dadhania
From: Michael Roth We need to set the proper drc_index values in ibm,my-drc-index fields in order to allow a PCI device that was present at boot-time to be unplugged. Previously SLOF handles this, but with QEMU handling the DT we need to do it there as well. This patch slightly changes how SLOF

[Qemu-devel] [PATCH v3 3/6] spapr_pci: encode class code including Prog IF register

2015-05-05 Thread Nikunj A Dadhania
Current code missed the Prog IF register. All Class Code, Subclass, and Prog IF registers are needed to identify the accurate device type. For example: USB controllers use the PROG IF for denoting: USB FullSpeed, HighSpeed or SuperSpeed. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c |

[Qemu-devel] [PATCH v3 1/6] spapr_pci: remove duplicate macros

2015-05-05 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 2e7590c..4df3a33 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1475,17 +1475,6 @@ PCIHostState *spapr_create_phb(sPA

[Qemu-devel] [PATCH v3 2/6] spapr_pci: encode missing 64-bit memory address space

2015-05-05 Thread Nikunj A Dadhania
The properties reg/assigned-resources need to encode 64-bit memory address space as part of phys.hi dword. 00 if configuration space 01 if IO region, 10 if 32-bit MEM region 11 if 64-bit MEM region Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 10 +- 1 file changed,

[Qemu-devel] [PATCH v3 0/6] spapr_pci: DT field fixes and PCI DT node creation in QEMU

2015-05-05 Thread Nikunj A Dadhania
The patch series creates PCI device tree(DT) nodes in QEMU. The new hotplug code needs the device node creation in QEMU. While during boot, nodes were created in SLOF. It makes more sense to consolidate the code to one place for better maintainability. Based on David's spapr-next https://github.c

[Qemu-devel] [PATCH v3 6/6] spapr_pci: populate ibm,loc-code

2015-05-05 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to identi

[Qemu-devel] [virtio-vhost] virtqueue, async vq push from vhost

2015-05-05 Thread Catalin Vasile
Can virtqueues be used asynchronous from the vhost end? >From what I've seen there are some primitives with "*add_used_and_signal*" which update some indexes behind the scene. Could marking and signaling used buffers (in another order other than the way they were received) mess up cleaning and/or o

[Qemu-devel] [PATCH v3 1/4] spapr_pci: encode missing 64-bit memory address space

2015-05-05 Thread Nikunj A Dadhania
The properties reg/assigned-resources need to encode 64-bit memory address space as part of phys.hi dword. 00 if configuration space 01 if IO region, 10 if 32-bit MEM region 11 if 64-bit MEM region Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 10 +- 1 file changed,

[Qemu-devel] [PATCH v3 2/4] spapr_pci: encode class code including Prog IF register

2015-05-05 Thread Nikunj A Dadhania
Current code missed the Prog IF register. All Class Code, Subclass, and Prog IF registers are needed to identify the accurate device type. For example: USB controllers use the PROG IF for denoting: USB FullSpeed, HighSpeed or SuperSpeed. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c |

[Qemu-devel] [PATCH v3 4/6] spapr_pci: enumerate and add PCI device tree

2015-05-05 Thread Nikunj A Dadhania
All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch adds the pci device node creation in Qemu. For backwa

[Qemu-devel] [PATCH v3 5/6] spapr_pci: fix boot-time device tree fields for pci hotplug

2015-05-05 Thread Nikunj A Dadhania
From: Michael Roth We need to set the proper drc_index values in ibm,my-drc-index fields in order to allow a PCI device that was present at boot-time to be unplugged. Previously SLOF handles this, but with QEMU handling the DT we need to do it there as well. This patch slightly changes how SLOF

[Qemu-devel] [PATCH v3 4/4] spapr: populate ibm,loc-code

2015-05-05 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to identi

Re: [Qemu-devel] [PATCH v8 20/40] qapi: Better error messages for duplicated expressions

2015-05-05 Thread Markus Armbruster
Eric Blake writes: > The previous commit demonstrated that the generator overlooked > duplicate expressions: > - a complex type or command reusing a built-in type name > - redeclaration of a type name, whether by the same or different > metatype > - redeclaration of a command or event > - collisi

[Qemu-devel] [RFC] ARM/ARM64: KVM: Implement KVM_FLUSH_DCACHE_GPA ioctl

2015-05-05 Thread Jérémy Fanguède
To maintain cache coherency on ARM, we may need a mechanism to flush the data cache. This patch implements KVM_FLUSH_DCACHE_GPA vm ioctl which flushes the data cache at a specified address range. The input argument is a struct kvm_mem_addr containing the guest physical address and the length. Sig

[Qemu-devel] [RFC 1/4] linux-headers update

2015-05-05 Thread Jérémy Fanguède
Add KVM_FLUSH_DCACHE_GPA ioctl. Signed-off-by: Jérémy Fanguède --- linux-headers/linux/kvm.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index b96d978..81d2f64 100644 --- a/linux-headers/linux/kvm.h +++ b/linux-headers/linux/kvm

[Qemu-devel] [RFC 2/4] target-arm/kvm: Flush data cache support

2015-05-05 Thread Jérémy Fanguède
Implement data cache maintenance coherency functions, by using FLUSH_DCACHE_GPA ioctl. Introduce kvm_arm_maintain_cache_coherency() for flushing the data cache if necessary, a very simple logic is implemented to reduce number of flushes due to reads. Two wrapping functions are exposed, for easier u

[Qemu-devel] [RFC 0/4] arm/arm64: KVM: Get around cache incoherency

2015-05-05 Thread Jérémy Fanguède
This RFC series shows how we can solve cache incohenrency issues on ARM/ARM64. This implementation uses an ioctl that flushes the data cache for a given range of the guest physical memory, this possible solution was already broached in the previous discussion [1][2]. Each access (read or write) to

[Qemu-devel] [RFC 3/4] kvm-all: Pre-run cache coherency maintenance

2015-05-05 Thread Jérémy Fanguède
Inform the cache coherency maintenance of an exit from userspace. Signed-off-by: Jérémy Fanguède --- kvm-all.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kvm-all.c b/kvm-all.c index 28f4589..c4b15b0 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1802,6 +1802,7 @@ int kvm_cpu_exec(CPUState *

[Qemu-devel] [RFC 4/4] exec: Flush data cache when needed

2015-05-05 Thread Jérémy Fanguède
Flush the data cache when accesses occur in the guest ram memory. Signed-off-by: Jérémy Fanguède --- exec.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/exec.c b/exec.c index ae37b98..0f859a3 100644 --- a/exec.c +++ b/exec.c @@ -2372,6 +2372,9 @@ MemTxResult address_s

Re: [Qemu-devel] [PATCH v4 00/17] arm_gic: Add security and grouping support

2015-05-05 Thread Peter Maydell
On 5 May 2015 at 03:08, Edgar E. Iglesias wrote: > On Fri, May 01, 2015 at 06:50:26PM +0100, Peter Maydell wrote: >> This patch series adds support for GICv1 and GICv2 security >> extensions, as well as support for GIC interrupt grouping on GICv2. > > A question. Once we enable the the security ex

[Qemu-devel] [PATCH] vmdk: Fix overflow if l1_size is 0x20000000

2015-05-05 Thread Fam Zheng
Richard Jones caught this bug with afl fuzzer. In fact, that's the only possible value to overflow (extent->l1_size = 0x2000) l1_size: l1_size = extent->l1_size * sizeof(long) => 0x8000; g_try_malloc returns NULL because l1_size is interpreted as negative during type casting from 'int' t

Re: [Qemu-devel] [PATCH qemu v7 00/14] spapr: vfio: Enable Dynamic DMA windows (DDW)

2015-05-05 Thread Alexey Kardashevskiy
On 04/25/2015 10:24 PM, Alexey Kardashevskiy wrote: (cut-n-paste from kernel patchset) Anyone, ping? :) Each Partitionable Endpoint (IOMMU group) has an address range on a PCI bus where devices are allowed to do DMA. These ranges are called DMA windows. By default, there is a single DMA win

[Qemu-devel] [PATCH] parallel: Allow to disable CONFIG_PARALLEL

2015-05-05 Thread mrezanin
From: Miroslav Rezanina Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored out initialization to parallel_hds_isa_init that is not build. Make calling parallel_hds_isa_init depending on CONFIG_PARALLEL so it can be correctly disabled. Signed-off-by: Miroslav Rezanina ---

[Qemu-devel] [PULL 1/6] opengl: add shader build infrastructure

2015-05-05 Thread Gerd Hoffmann
perl script to transform shader programs into c include files with static string constands containing the shader programs, so we can easily embed them into qemu. Also some Makefile logic for them. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- Makefile | 14 +++

[Qemu-devel] [PULL 0/6] sdl2: add opengl rendering support.

2015-05-05 Thread Gerd Hoffmann
n/tags/for-upstream' into staging (2015-04-30 20:34:54 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-sdl-20150505-1 for you to fetch changes up to e444ea34f8ec27acfa9ead7eaa9904238c831e69: sdl2: Fix RGB555 (2015-05-05

[Qemu-devel] [PULL 4/6] sdl2: move SDL_* includes to sdl2.h

2015-05-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/sdl2.h | 6 ++ ui/sdl2-2d.c | 6 -- ui/sdl2-input.c | 6 -- ui/sdl2.c | 6 -- 4 files changed, 6 insertions(+), 18 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index 51fff2e..e21

[Qemu-devel] [PULL 2/6] opengl: add shader helper functions.

2015-05-05 Thread Gerd Hoffmann
Helper functions to compile, link and run opengl shader programs. Signed-off-by: Gerd Hoffmann --- include/ui/shader.h | 9 + ui/Makefile.objs| 7 ui/shader.c | 95 + 3 files changed, 111 insertions(+) create mode 100644

[Qemu-devel] [PULL 6/6] sdl2: Fix RGB555

2015-05-05 Thread Gerd Hoffmann
From: Max Reitz Reproducable with: $ x86_64-softmmu/qemu-system-x86_64 \ -kernel $vmlinuz_of_your_choice \ -append vga=0x313 -sdl Signed-off-by: Max Reitz Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 5 + ui/sdl2-2d.c | 15 +-- 2 files changed, 18

[Qemu-devel] [PULL 3/6] console-gl: add opengl rendering helper functions

2015-05-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- Makefile| 3 + configure | 2 +- include/ui/console.h| 31 include/ui/shader.h | 2 + ui/Makefile.objs| 3 + ui/console-gl.c | 168 +

[Qemu-devel] [PULL 5/6] sdl2: add support for display rendering using opengl.

2015-05-05 Thread Gerd Hoffmann
Add new sdl2-gl.c file, with display rendering functions using opengl. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/console.h | 1 + include/ui/sdl2.h| 11 + ui/Makefile.objs | 3 ++ ui/sdl.c | 10 + ui/sdl2-2d.c | 7 ui/sdl

Re: [Qemu-devel] [PATCH] ui: remove check for failure of qemu_acl_init()

2015-05-05 Thread Gerd Hoffmann
On Fr, 2015-05-01 at 11:44 +0100, Daniel P. Berrange wrote: > The qemu_acl_init() function has long since stopped being able > to return NULL, since g_malloc will abort on OOM. As such the > checks for NULL were unreachable code. added to vnc queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2015-05-05 Thread Gerd Hoffmann
Hi, > > Ok then. Added to spice queue. Fails to build, but that looks like > > just being the dependency on amits patch and should go away once that > > one is upstream. > > The dependency patch is now in tree, please pick this series up. Hmm, not in my queue any more, probably dropped at so

Re: [Qemu-devel] PCI on ARM virt machine - status ?

2015-05-05 Thread Pavel Fedin
Hello! > You can help with the merge by indicating you have tested it with a > formal tested-by: tag from yourself to the cover letters of the series. > This helps the maintainers know that someone has tested it. How to do it correctly ? I've never done that before. Do i need to reply to the

Re: [Qemu-devel] [PATCH 1/3] vnc: Don't assert if opening unix socket fails

2015-05-05 Thread Gerd Hoffmann
On Mi, 2015-04-29 at 12:37 -0400, Cole Robinson wrote: > +if (vs->lsock < 0) > +goto fail; fails checkpatch.pl

Re: [Qemu-devel] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols

2015-05-05 Thread Stefan Hajnoczi
On Thu, Mar 19, 2015 at 03:03:18PM -0400, Max Reitz wrote: > Some image formats (e.g. qcow2) require the underlying file to grow on > write accesses, but this is in fact not supported by all protocols (e.g. > nbd does not). If such a format requiring file growth is used > non-read-only over a proto

Re: [Qemu-devel] [PATCH] usb: fix usb-net segfault

2015-05-05 Thread Gerd Hoffmann
On Mi, 2015-04-29 at 11:34 +, Michal Kazior wrote: > The dev->config pointer isn't set until guest > system initializes usb devices (via > usb_desc_set_config). However qemu networking can > go through some motions prior to that, e.g.: > > #0 is_rndis (s=0x57261970) at hw/usb/dev-network

Re: [Qemu-devel] [PATCH] vmdk: Fix overflow if l1_size is 0x20000000

2015-05-05 Thread Richard W.M. Jones
On Tue, May 05, 2015 at 05:28:13PM +0800, Fam Zheng wrote: > Richard Jones caught this bug with afl fuzzer. > > In fact, that's the only possible value to overflow (extent->l1_size = > 0x2000) l1_size: > > l1_size = extent->l1_size * sizeof(long) => 0x8000; > > g_try_malloc returns NULL

[Qemu-devel] [PATCH 1/2] Revert "xhci: generate a Transfer Event for each Transfer TRB with the IOC bit set"

2015-05-05 Thread Gerd Hoffmann
This makes xhci generate multiple short packet events in case of multi-trb transfers. Which is wrong. We need to fix this in a different way. This reverts commit aa6857891df614c620e6e9fc4bc4af6e0e49cafd. --- hw/usb/hcd-xhci.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-

[Qemu-devel] [PATCH 0/2] xhci: fix control transfer event reporting

2015-05-05 Thread Gerd Hoffmann
Hi, Laszlos fix unfortunaly had unwanted side effects, so we have to take a different approach to fix the issue at hand. please review, Gerd Gerd Hoffmann (2): Revert "xhci: generate a Transfer Event for each Transfer TRB with the IOC bit set" xhci: fix events for setup trb. hw/usb

Re: [Qemu-devel] [PATCH] parallel: Allow to disable CONFIG_PARALLEL

2015-05-05 Thread Thomas Huth
On Tue, 5 May 2015 11:30:49 +0200 mreza...@redhat.com wrote: > From: Miroslav Rezanina > > Disabling CONFIG_PARALLEL cause build failure as commit 07dc788 factored > out initialization to parallel_hds_isa_init that is not build. > > Make calling parallel_hds_isa_init depending on CONFIG_PARALL

[Qemu-devel] [PATCH 2/2] xhci: fix events for setup trb.

2015-05-05 Thread Gerd Hoffmann
When we find a IOC bit set on a setup trb and therefore queue an event, that should not stop events being generated for following data trbs. So clear the 'reported' flag. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/usb/hcd-xhc

Re: [Qemu-devel] [PATCH 2/6] input: remove unused mouse_handlers list

2015-05-05 Thread Gerd Hoffmann
On Mo, 2015-04-27 at 12:45 -0400, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 2/3] xhci: remove unused code

2015-05-05 Thread Gerd Hoffmann
Hi, > > So, I think if we were to drop this assignment, we should > > remove the initializer too. But before doing this, I think > > we should try to remember _why_ this assignment is here in > > the first place. The code looks like after the loop, this > > ep variable was supposed to be used

Re: [Qemu-devel] [RFC PATCH 01/15] pci: allow cleanup/unregistration of PCI buses

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:10PM -0500, Michael Roth wrote: > This adds cleanup counterparts to pci_register_bus(), > pci_bus_new(), and pci_bus_irqs(). > > These cleanup routines are needed in the case of hotpluggable > PCIHostBridge implementations. Currently we can rely on the > object_unpare

Re: [Qemu-devel] [RFC PATCH 04/15] spapr_iommu: pass object ownership to parent/owner

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:13PM -0500, Michael Roth wrote: > DRC objects attach themselves to an owner as a child ^^^ Copy and paste error in the commit message. > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth But

Re: [Qemu-devel] [RFC PATCH 03/15] spapr_drc: pass object ownership to parent/owner

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:12PM -0500, Michael Roth wrote: > DRC objects attach themselves to an owner as a child > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth Reviewed-by: David Gibson > --- > hw/ppc/spapr_drc.c

Re: [Qemu-devel] [PATCH v5 0/4] configure: clang 3.5.0 build fixes

2015-05-05 Thread Stefan Hajnoczi
On Wed, Mar 25, 2015 at 06:57:35PM -0400, John Snow wrote: > QEMU does not compile cleanly under clang 3.5.0. These patches eliminate the > avalanche of warnings and make the build usable. > > The result is that you *should* be able to use clang 3.5.0 *with* ccache and > -Werror and produce all t

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault

2015-05-05 Thread Paolo Bonzini
On 05/05/2015 09:36, Fam Zheng wrote: > Since the gdb output is suggesting 1.5.3, it's worth to trying 2.3 which has > this: > > commit c4237dfa635900e4d1cdc6038d5efe3507f45f0c > Author: Vladimir Sementsov-Ogievskiy > Date: Thu Nov 27 12:40:46 2014 +0300 > > block: fix sp

[Qemu-devel] [RFC PATCH v12 00/21] Deterministic replay core

2015-05-05 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. This implementation of deterministic replay can be used for deterministic debugging of guest code through gdb remote interface. Core set of patches does not include support for reverse debugging c

[Qemu-devel] [RFC PATCH v12 05/21] replay: introduce mutex to protect the replay log

2015-05-05 Thread Pavel Dovgalyuk
This mutex will protect read/write operations for replay log. Using mutex is necessary because most of the events consist of several fields stored in the log. The mutex will help to avoid races. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 27 +

[Qemu-devel] [RFC PATCH v12 01/21] i386: partial revert of interrupt poll fix

2015-05-05 Thread Pavel Dovgalyuk
Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c|6 ++ target-i386/cpu.c | 10 ++--

[Qemu-devel] [RFC PATCH v12 06/21] replay: introduce icount event

2015-05-05 Thread Pavel Dovgalyuk
This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 24 re

[Qemu-devel] [RFC PATCH v12 02/21] replay: global variables and function stubs

2015-05-05 Thread Pavel Dovgalyuk
This patch adds global variables, defines, function declarations, and function stubs for deterministic VM replay used by external modules. Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Pavel Dovgalyuk --- Makefile.target |1 docs/replay.txt | 167 ++

[Qemu-devel] [RFC PATCH v12 03/21] sysemu: system functions for replay

2015-05-05 Thread Pavel Dovgalyuk
This patch removes "static" specifier from several qemu function to make them visible to the replay module. It also invents several system functions that will be used by replay. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpus.c |2 +- include/exec/exec-a

[Qemu-devel] [RFC PATCH v12 14/21] replay: checkpoints

2015-05-05 Thread Pavel Dovgalyuk
This patch introduces checkpoints that synchronize cpu thread and iothread. When checkpoint is met in the code all asynchronous events from the queue are executed. Signed-off-by: Pavel Dovgalyuk --- cpus.c |5 + main-loop.c |6 ++ qemu-timer.c

[Qemu-devel] [RFC PATCH v12 09/21] i386: interrupt poll processing

2015-05-05 Thread Pavel Dovgalyuk
This patch updates x86_cpu_exec_interrupt function. It can process two interrupt request at a time (poll and another one). This makes its execution non-deterministic. Determinism is requred for recorded icount execution. Signed-off-by: Pavel Dovgalyuk --- target-i386/seg_helper.c |3 +++ 1 f

[Qemu-devel] [RFC PATCH v12 07/21] cpu-exec: allow temporary disabling icount

2015-05-05 Thread Pavel Dovgalyuk
This patch is required for deterministic replay to generate an exception by trying executing an instruction without changing icount. It adds new flag to TB for disabling icount while translating it. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c |7

[Qemu-devel] [RFC PATCH v12 04/21] replay: internal functions for replay log

2015-05-05 Thread Pavel Dovgalyuk
This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/Makefile.objs |1 replay/replay-internal.c | 149 ++ replay/replay-internal.h | 46 ++

[Qemu-devel] [RFC PATCH v12 15/21] aio: replace stack of bottom halves with queue

2015-05-05 Thread Pavel Dovgalyuk
Bottom halves in AIO context are stored and removes in LIFO order. It makes their execution non-deterministic. This patch replaces the stack with queue to preserve the order of bottom halves processing. Signed-off-by: Pavel Dovgalyuk --- async.c | 26 +++--- in

[Qemu-devel] [RFC PATCH v12 21/21] replay: recording of the user input

2015-05-05 Thread Pavel Dovgalyuk
This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 31 + replay/replay-input.c| 159 +++

Re: [Qemu-devel] [PATCH 2/3] xhci: remove unused code

2015-05-05 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

[Qemu-devel] [RFC PATCH v12 18/21] replay: initialization and deinitialization

2015-05-05 Thread Pavel Dovgalyuk
This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- exec.c |1 replay/replay-internal.h |2 + replay/replay.c | 134 +++

[Qemu-devel] [RFC PATCH v12 08/21] cpu: replay instructions sequence

2015-05-05 Thread Pavel Dovgalyuk
This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. When replayed instructions counter is expired qemu_notify_event() function is ca

Re: [Qemu-devel] [PATCH 2/6] input: remove unused mouse_handlers list

2015-05-05 Thread Michael Tokarev
05.05.2015 13:00, Gerd Hoffmann wrote: > On Mo, 2015-04-27 at 12:45 -0400, Emilio G. Cota wrote: >> Signed-off-by: Emilio G. Cota > > Reviewed-by: Gerd Hoffmann Too late, it has already been applied to master… /mjt

  1   2   3   4   >