Re: [Qemu-devel] [PATCH v14 09/10] sysbus: add irq_routing_notifier

2015-04-30 Thread Peter Crosthwaite
On Wed, Apr 29, 2015 at 7:52 AM, Eric Auger wrote: > Add a new connect_irq_notifier notifier in the SysBusDeviceClass. This > notifier, if populated, is called after sysbus_connect_irq. > > This mechanism is used to setup VFIO signaling once VFIO platform > devices get attached to their platform b

[Qemu-devel] [PULL 37/42] qmp-commands: Fix typo

2015-04-30 Thread Michael Tokarev
From: John Snow Just a trivial patch to correct a QMP example in qmp-commands.hx. Signed-off-by: John Snow Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- qmp-commands.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx inde

[Qemu-devel] [PULL 28/42] microblaze: cpu: Delete EXCP_NMI

2015-04-30 Thread Michael Tokarev
From: Peter Crosthwaite This define is unused. Remove. Signed-off-by: Peter Crosthwaite Reviewed-by: Edgar E. Iglesias Signed-off-by: Michael Tokarev --- target-microblaze/cpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index f21da2f

[Qemu-devel] [PULL 06/42] ui/console : remove 'struct' from 'typedef struct' type

2015-04-30 Thread Michael Tokarev
From: Chih-Min Chao Signed-off-by: Chih-Min Chao Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- ui/console.c | 4 ++-- ui/spice-display.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/console.c b/ui/console.c index 2927513..f5295c4 100644 --- a

[Qemu-devel] [PULL 08/42] misc: Fix new collection of typos

2015-04-30 Thread Michael Tokarev
From: Stefan Weil All of them were reported by codespell. Most typos are in comments, one is in an error message. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- hw/block/virtio-blk.c | 2 +- hw/misc/edu.c

[Qemu-devel] [PULL 23/42] libcacard: do not use full paths for include files in the same dir

2015-04-30 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Paolo Bonzini --- libcacard/vcard_emul_nss.c | 2 +- libcacard/vcardt.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c index 6955f69..d9761ee 100644 --- a/libcaca

[Qemu-devel] [PULL 04/42] ui/vnc : fix coding style

2015-04-30 Thread Michael Tokarev
From: Chih-Min Chao reported by checkpatch.pl Signed-off-by: Chih-Min Chao Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- ui/vnc-auth-vencrypt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ui/vnc-auth-vencrypt.c b/ui/vnc-auth-vencrypt.c index

[Qemu-devel] [PATCH] openrisc: cpu: Remove unused cpu_get_pc

2015-04-30 Thread Peter Crosthwaite
This function is not used by anything. Remove. Signed-off-by: Peter Crosthwaite --- target-openrisc/cpu.h | 5 - 1 file changed, 5 deletions(-) diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h index b25324b..9e23cd0 100644 --- a/target-openrisc/cpu.h +++ b/target-openrisc/cpu.h @@

Re: [Qemu-devel] [PATCH V2] vhost: logs sharing

2015-04-30 Thread Jason Wang
On Tue, Apr 28, 2015 at 6:30 PM, Michael S. Tsirkin wrote: On Tue, Apr 28, 2015 at 05:58:28PM +0800, Jason Wang wrote: On Tue, Apr 28, 2015 at 5:37 PM, Michael S. Tsirkin wrote: >On Fri, Apr 10, 2015 at 05:33:35PM +0800, Jason Wang wrote: >> Currently we allocate one vhost log per v

Re: [Qemu-devel] [PATCH V2] vhost: logs sharing

2015-04-30 Thread Michael S. Tsirkin
On Thu, Apr 30, 2015 at 04:05:09PM +0800, Jason Wang wrote: > > > On Tue, Apr 28, 2015 at 6:30 PM, Michael S. Tsirkin wrote: > >On Tue, Apr 28, 2015 at 05:58:28PM +0800, Jason Wang wrote: > >> On Tue, Apr 28, 2015 at 5:37 PM, Michael S. Tsirkin > >> wrote: > >> >On Fri, Apr 10, 2015 at 05:33

Re: [Qemu-devel] [PATCH] openrisc: cpu: Remove unused cpu_get_pc

2015-04-30 Thread Alex Bennée
Peter Crosthwaite writes: > This function is not used by anything. Remove. > > Signed-off-by: Peter Crosthwaite > --- > target-openrisc/cpu.h | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h > index b25324b..9e23cd0 100644 > --- a/targe

Re: [Qemu-devel] [PATCH microblaze v1 3/6] mb: cpu: Remote unused cpu_get_pc

2015-04-30 Thread Alex Bennée
Peter Crosthwaite writes: > This function is not used by anything. Remove. > > Signed-off-by: Peter Crosthwaite > --- > target-microblaze/cpu.h | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h > index 7d06227..2c18b49 100644 > --- a

[Qemu-devel] [PULL 34/42] coroutine: remove unnecessary parentheses in qemu_co_queue_empty

2015-04-30 Thread Michael Tokarev
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Michael Tokarev --- qemu-coroutine-lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c index e4860ae..6b49033 100644 --- a/qemu-coroutine-lock.c +++ b/qemu-c

[Qemu-devel] [PULL 33/42] qemu-char: remove unused list node from FDCharDriver

2015-04-30 Thread Michael Tokarev
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Michael Tokarev --- qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index a405d76..d0c1564 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -973,7 +973,6 @@ typedef struct FDCharDriver {

[Qemu-devel] [PULL 15/42] pci: Remove unused function ich9_d2pbr_init()

2015-04-30 Thread Michael Tokarev
From: Thomas Huth The function ich9_d2pbr_init() is completely unused and thus can be deleted. Signed-off-by: Thomas Huth Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- hw/pci-bridge/i82801b11.c | 21 - include/hw/i386/ich9.h| 1 - 2 files changed

[Qemu-devel] [PULL 36/42] i440fx-test: remove ARRAY_SIZE redefinition

2015-04-30 Thread Michael Tokarev
From: "Emilio G. Cota" It's defined in osdep.h and shouldn't be redefined here. Signed-off-by: Emilio G. Cota Reviewed-by: Peter Crosthwaite Reviewed-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- tests/i440fx-test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/i440fx-te

[Qemu-devel] [PULL 11/42] tpm: fix coding style

2015-04-30 Thread Michael Tokarev
From: Stefan Berger Fix coding style in one instance. Signed-off-by: Stefan Berger Signed-off-by: Michael Tokarev --- hw/tpm/tpm_tis.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 4b6d601..b8235d5 100644 --- a/hw/tpm/tpm_tis

[Qemu-devel] [PULL 22/42] libcacard: stop including qemu-common.h

2015-04-30 Thread Michael Tokarev
From: Paolo Bonzini This is a small step towards making libcacard standalone. Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- libcacard/cac.c| 5 - libcacard/card_7816.c | 4 +++- libcacard/event.c | 2 +- libcacard/vcard.c | 4 +++- libc

Re: [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send

2015-04-30 Thread Jason Wang
On Wed, Apr 29, 2015 at 6:37 PM, Fam Zheng wrote: This callback is called by main loop before polling s->fd, if it returns false, the fd will not be polled in this iteration. This is redundant with checks inside read callback. After this patch, the data will be sent to peer when it arrives.

Re: [Qemu-devel] [PATCH v4 0/4] scripts: qmp-shell: add transaction support

2015-04-30 Thread Kashyap Chamarthy
On Wed, Apr 29, 2015 at 03:14:00PM -0400, John Snow wrote: > The qmp-shell is a little rudimentary, but it can be hacked > to give us some transactional support without too much difficulty. > > (1) Prep. > (2) Add support for serializing json arrays and > improve the robustness of QMP parsing

[Qemu-devel] Question about block driver

2015-04-30 Thread Wen Congyang
Hi, all Some drivers use bdrv_open, while the other dirvers use bdrv_file_open(). What is the difference between bdrv_open() and bdrv_file_open()? Thanks Wen Congyang

Re: [Qemu-devel] [PULL 0/3] VFIO fixes + AMD GPU reset workaround

2015-04-30 Thread Peter Maydell
On 28 April 2015 at 18:52, Alex Williamson wrote: > The following changes since commit 84cbd63f87c1d246f51ec8eee5367a5588f367fd: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into > staging (2015-04-28 12:22:20 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [REBASE PATCH v5 1/2] machine: add default_ram_size to machine class

2015-04-30 Thread Alexander Graf
On 30.04.15 06:41, Nikunj A Dadhania wrote: > > Hi Paolo, > > Paolo Bonzini writes: >> On 29/04/2015 11:06, Nikunj A Dadhania wrote: so David can push both patches. But isn't 1G a bit too much? At least on x86 you can easily boot with 512M. >>> >>> I understood this numbe

Re: [Qemu-devel] [PATCH V2] vhost: logs sharing

2015-04-30 Thread Jason Wang
On Thu, Apr 30, 2015 at 4:09 PM, Michael S. Tsirkin wrote: On Thu, Apr 30, 2015 at 04:05:09PM +0800, Jason Wang wrote: On Tue, Apr 28, 2015 at 6:30 PM, Michael S. Tsirkin wrote: >On Tue, Apr 28, 2015 at 05:58:28PM +0800, Jason Wang wrote: >> On Tue, Apr 28, 2015 at 5:37 PM, Mich

Re: [Qemu-devel] Question about block driver

2015-04-30 Thread Kevin Wolf
[Cc: qemu-block] Am 30.04.2015 um 11:11 hat Wen Congyang geschrieben: > Some drivers use bdrv_open, while the other dirvers use bdrv_file_open(). > What is the difference between bdrv_open() and bdrv_file_open()? bdrv_file_open() is used by protocol drivers that don't need any other driver to wor

Re: [Qemu-devel] [PATCH V2] vhost: logs sharing

2015-04-30 Thread Michael S. Tsirkin
On Thu, Apr 30, 2015 at 05:22:33PM +0800, Jason Wang wrote: > > > On Thu, Apr 30, 2015 at 4:09 PM, Michael S. Tsirkin wrote: > >On Thu, Apr 30, 2015 at 04:05:09PM +0800, Jason Wang wrote: > >> On Tue, Apr 28, 2015 at 6:30 PM, Michael S. Tsirkin > >> wrote: > >> >On Tue, Apr 28, 2015 at 05:58

Re: [Qemu-devel] Question about block driver

2015-04-30 Thread Wen Congyang
On 04/30/2015 05:33 PM, Kevin Wolf wrote: > [Cc: qemu-block] > > Am 30.04.2015 um 11:11 hat Wen Congyang geschrieben: >> Some drivers use bdrv_open, while the other dirvers use bdrv_file_open(). >> What is the difference between bdrv_open() and bdrv_file_open()? > > bdrv_file_open() is used by pr

Re: [Qemu-devel] [REBASE PATCH v5 1/2] machine: add default_ram_size to machine class

2015-04-30 Thread Thomas Huth
On Thu, 30 Apr 2015 11:18:05 +0200 Alexander Graf wrote: > > > On 30.04.15 06:41, Nikunj A Dadhania wrote: > > > > Hi Paolo, > > > > Paolo Bonzini writes: > >> On 29/04/2015 11:06, Nikunj A Dadhania wrote: > so David can push both patches. > > But isn't 1G a bit too much? At

Re: [Qemu-devel] [REBASE PATCH v5 1/2] machine: add default_ram_size to machine class

2015-04-30 Thread Alexander Graf
> Am 30.04.2015 um 11:40 schrieb Thomas Huth : > > On Thu, 30 Apr 2015 11:18:05 +0200 > Alexander Graf wrote: > >> >> >>> On 30.04.15 06:41, Nikunj A Dadhania wrote: >>> >>> Hi Paolo, >>> >>> Paolo Bonzini writes: On 29/04/2015 11:06, Nikunj A Dadhania wrote: >> so David can push

[Qemu-devel] [PATCH] nvme: support NVME_VOLATILE_WRITE_CACHE feature

2015-04-30 Thread Christoph Hellwig
The SCSI emulation in the Linux NVMe driver really wants to know if a device has a volatile write cache. Given that qemu has moved away from a model where we report the backing store WCE bit to one where the WCE bit is supposed to be part of the migratable guest-visible state we always return 1 he

Re: [Qemu-devel] Question about block driver

2015-04-30 Thread Kevin Wolf
Am 30.04.2015 um 11:43 hat Wen Congyang geschrieben: > On 04/30/2015 05:33 PM, Kevin Wolf wrote: > > [Cc: qemu-block] > > > > Am 30.04.2015 um 11:11 hat Wen Congyang geschrieben: > >> Some drivers use bdrv_open, while the other dirvers use bdrv_file_open(). > >> What is the difference between bdrv

[Qemu-devel] [PULL 21/42] docs/atomics.txt: fix two typos

2015-04-30 Thread Michael Tokarev
From: Laszlo Ersek Cc: Paolo Bonzini Signed-off-by: Laszlo Ersek Signed-off-by: Michael Tokarev --- docs/atomics.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/atomics.txt b/docs/atomics.txt index 6f2997b..ef285e3 100644 --- a/docs/atomics.txt +++ b/docs/atom

Re: [Qemu-devel] [PULL 00/10] Ide patches

2015-04-30 Thread Peter Maydell
On 29 April 2015 at 00:25, John Snow wrote: > The following changes since commit a9392bc93c8615ad1983047e9f91ee3fa8aae75f: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-04-28 16:55:03 +0100) > > are available in the git repository at: > > https://gith

[Qemu-devel] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-04-30 Thread Alberto Garcia
The qcow2 L2/refcount cache contains one separate table for each cache entry. Doing one allocation per table adds unnecessary overhead and it also requires us to store the address of each table separately. Since the size of the cache is constant during its lifetime, it's better to have an array th

[Qemu-devel] [PATCH 6/6] qcow2: style fixes in qcow2-cache.c

2015-04-30 Thread Alberto Garcia
Fix pointer declaration to make it consistent with the rest of the code. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index c0e0278..dd591ef 100644 --- a/block/qcow2-cache

[Qemu-devel] [PATCH 2/6] qcow2: simplify qcow2_cache_put() and qcow2_cache_entry_mark_dirty()

2015-04-30 Thread Alberto Garcia
Since all tables are now stored together, it is possible to obtain the position of a particular table directly from its address, so the operation becomes O(1). Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) dif

[Qemu-devel] [PATCH 5/6] qcow2: use a hash to look for entries in the L2 cache

2015-04-30 Thread Alberto Garcia
The current cache algorithm traverses the array starting always from the beginning, so the average number of comparisons needed to perform a lookup is proportional to the size of the array. By using a hash of the offset as the starting point, lookups are faster and independent from the array size.

[Qemu-devel] [PATCH 3/6] qcow2: use an LRU algorithm to replace entries from the L2 cache

2015-04-30 Thread Alberto Garcia
The current algorithm to evict entries from the cache gives always preference to those in the lowest positions. As the size of the cache increases, the chances of the later elements of being removed decrease exponentially. In a scenario with random I/O and lots of cache misses, entries in position

[Qemu-devel] [PATCH 0/6] qcow2 L2/refcount cache improvements

2015-04-30 Thread Alberto Garcia
Here are some improvements to the qcow2 L2/refcount cache code. The first one is that all cache tables are now allocated using a single memory block, as we discussed last week. Apart from a more efficient use of memory, this allows some additional optimizations so I took the chance to make other

[Qemu-devel] [PATCH 4/6] qcow2: remove qcow2_cache_find_entry_to_replace()

2015-04-30 Thread Alberto Garcia
A cache miss means that the whole array was traversed and the entry we were looking for was not found, so there's no need to traverse it again in order to select an entry to replace. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 45 - 1 file

Re: [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 10:59, Jason Wang wrote: >> >> >> +/* If !can_send, we will want to disable the read poll, but >> we still >> + * need the send completion callback to enable it again, >> which is a >> + * sign of peer becoming ready. So call the send function >> +

[Qemu-devel] [v2 0/2] Generic PCIe host bridge INTx determination for INTx routing

2015-04-30 Thread Pranavkumar Sawargaonkar
This patch adds a routine for GPEX to implement PCI bus specific function pointer "route_intx_to_irq" which is used during INTx routing. ChangeLog: V2: - Drop a patch about adding an API to get irq number from qemu_irq - Store a GPEX INTx information from board specific code (virt.c) V1: - Init

[Qemu-devel] [v2 2/2] arm: hw: virt: Store information about GPEX legacy interrupt numbers

2015-04-30 Thread Pranavkumar Sawargaonkar
This patch stores information about assigned legacy interrupt numbers in GPEX host structure. This is used during GPEX INTx number determination from a pin during INTx routing. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Tushar Jagad --- hw/arm/virt.c | 4 1 file changed, 4 inse

[Qemu-devel] [v2 1/2] pci: GPEX: Add a function to determine interrupt number for INTx routing

2015-04-30 Thread Pranavkumar Sawargaonkar
This patch adds a PCI bus specific function pointer "route_intx_to_irq" for GPEX. This is used in detemining PCI INTx number from pin. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Tushar Jagad --- hw/pci-host/gpex.c | 12 include/hw/pci-host/gpex.h | 1 + 2 files

[Qemu-devel] [PULL 03/10] sclp: sort into categories

2015-04-30 Thread Cornelia Huck
Sort the sclp consoles into the input category, just as virtio-serial. Various other sclp devices don't have an obvious category, sort them into misc. Reviewed-by: David Hildenbrand Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/char/sclpconsole-lm.c | 1 + hw/char/sclpco

[Qemu-devel] [PULL 07/10] s390x/kvm: Put vm name, extended name and UUID into STSI322 SYSIB

2015-04-30 Thread Cornelia Huck
From: Ekaterina Tumanova KVM prefills the SYSIB, returned by STSI 3.2.2. This patch allows userspace to intercept execution, and fill in the values, that are known to qemu: machine name (8 chars), extended machine name (256 chars), extended machine name encoding (equals 2 for UTF-8) and UUID. ST

[Qemu-devel] [PULL 04/10] s390x/ipl: sort into categories

2015-04-30 Thread Cornelia Huck
The s390 ipl device has no real home (it's not really a storage device), so let's sort it into the misc category. Reviewed-by: David Hildenbrand Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/ipl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/s390x/ipl.c b/

[Qemu-devel] [PULL 01/10] virtio-ccw: sort into categories

2015-04-30 Thread Cornelia Huck
Sort the various virtio-ccw devices into the same categories as their virtio-pci counterparts. Reviewed-by: David Hildenbrand Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/s390x/virtio-ccw.

[Qemu-devel] [PULL 02/10] s390-virtio: sort into categories

2015-04-30 Thread Cornelia Huck
Sort the various s390-virtio devices into the same categories as their virtio-pci counterparts. Reviewed-by: David Hildenbrand Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-bus.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/s390x/s390-

[Qemu-devel] [PULL 09/10] s390x/kvm: Support access register mode for KVM_S390_MEM_OP ioctl

2015-04-30 Thread Cornelia Huck
From: Alexander Yarygin Access register mode is one of the modes that control dynamic address translation. In this mode the address space is specified by values of the access registers. The effective address-space-control element is obtained from the result of the access register translation. See

[Qemu-devel] [PULL 05/10] s390x/mmu: Use access type definitions instead of magic values

2015-04-30 Thread Cornelia Huck
From: Thomas Huth Since there are now proper definitions for the MMU access type, let's use them in the s390x MMU code, too, instead of the hard-to-understand magic values. Signed-off-by: Thomas Huth Reviewed-by: Jens Freimann Acked-by: Cornelia Huck Signed-off-by: Cornelia Huck --- target-

[Qemu-devel] [PULL 08/10] s390x/mmu: Use ioctl for reading and writing from/to guest memory

2015-04-30 Thread Cornelia Huck
From: Thomas Huth Add code to make use of the new ioctl for reading from / writing to virtual guest memory. By using the ioctl, the memory accesses are now protected with the so-called ipte-lock in the kernel. [CH: moved error message into kvm_s390_mem_op()] Signed-off-by: Thomas Huth Acked-by:

[Qemu-devel] [PULL 06/10] linux-headers: update

2015-04-30 Thread Cornelia Huck
This updates linux-headers against master 4.1-rc1 (commit b787f68c36d49bb1d9236f403813641efa74a031). Signed-off-by: Cornelia Huck --- include/standard-headers/linux/virtio_balloon.h | 28 +++- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_input.h

[Qemu-devel] [PULL 00/10] first pile of s390x patches for 2.4

2015-04-30 Thread Cornelia Huck
able in the git repository at: git://github.com/cohuck/qemu tags/s390x-20150430 for you to fetch changes up to 2c80e996e427ae31982f3405a762859578a6261d: kvm: better advice for failed s390x startup (2015-04-30 13:21:42 +0200) Firs

[Qemu-devel] [PULL 10/10] kvm: better advice for failed s390x startup

2015-04-30 Thread Cornelia Huck
If KVM_CREATE failed on s390x, we print a hint to enable the switch_amode kernel parameter. This only applies to old kernels, and only if the error was -EINVAL. Moreover, with new kernels, the most likely reason for -EINVAL is that pgstes were not enabled. Let's update the error message to give a

Re: [Qemu-devel] [PATCH v2 2/3] qobject: Add a special null QObject

2015-04-30 Thread Markus Armbruster
Eric Blake writes: > From: Markus Armbruster > > I'm going to fix the JSON parser to recognize null. The obvious > representation of JSON null as (QObject *)NULL doesn't work, because > the parser already uses it as an error value. Perhaps we should > change it to free NULL for null, but that'

Re: [Qemu-devel] [PATCH v2 0/3] parse 'null' literal in QMP

2015-04-30 Thread Markus Armbruster
Eric Blake writes: > Here's my attempt to merge the best points of Markus' approach [1] > (patches 16-18 of that series - benefit of smaller patches and fewer > malloc calls) and my approach [2] (benefit of a testsuite addition > and more detailed commit messages), while fixing the typos that bot

Re: [Qemu-devel] [PATCH v2 0/3] parse 'null' literal in QMP

2015-04-30 Thread Luiz Capitulino
On Thu, 30 Apr 2015 14:21:02 +0200 Markus Armbruster wrote: > Eric Blake writes: > > > Here's my attempt to merge the best points of Markus' approach [1] > > (patches 16-18 of that series - benefit of smaller patches and fewer > > malloc calls) and my approach [2] (benefit of a testsuite additi

Re: [Qemu-devel] [PULL v2 00/22] Memory, TCG, NBD, build system changes for 2015-04-27

2015-04-30 Thread Peter Maydell
On 29 April 2015 at 09:35, Paolo Bonzini wrote: > The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: > > Open 2.4 development tree (2015-04-25 22:05:07 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for y

[Qemu-devel] [PATCH v15 02/10] hw/vfio/platform: vfio-platform skeleton

2015-04-30 Thread Eric Auger
Minimal VFIO platform implementation supporting register space user mapping but not IRQ assignment. Signed-off-by: Kim Phillips Signed-off-by: Eric Auger --- v14 -> v15: - vfio_platform_compute_needs_reset now returns true while vfio_platform_hot_reset_multi returns -1 - adjust g_malloc0_n us

[Qemu-devel] [PATCH v15 00/10] KVM platform device passthrough

2015-04-30 Thread Eric Auger
This series aims at enabling KVM platform device passthrough. On kernel side, the vfio platform driver is needed, available from 4.1-rc1 onwards. This series now only relies on the following QEMU series, for dynamic instantiation of the VFIO platform device from qemu command line: [1] [PATCH v12

[Qemu-devel] [PATCH v15 06/10] kvm: rename kvm_irqchip_[add, remove]_irqfd_notifier with gsi suffix

2015-04-30 Thread Eric Auger
Anticipating for the introduction of new add/remove functions taking a qemu_irq parameter, let's rename existing ones with a gsi suffix. Signed-off-by: Eric Auger --- hw/s390x/virtio-ccw.c | 8 hw/vfio/pci.c | 6 +++--- hw/virtio/virtio-pci.c | 4 ++-- include/sysemu/kvm.h |

[Qemu-devel] [PATCH v15 01/10] linux-headers: update

2015-04-30 Thread Eric Auger
From: Cornelia Huck This updates linux-headers against master 4.1-rc1 (commit b787f68c36d49bb1d9236f403813641efa74a031). Signed-off-by: Cornelia Huck --- include/standard-headers/linux/virtio_balloon.h | 28 +++- include/standard-headers/linux/virtio_blk.h | 8 +- include/standard-heade

[Qemu-devel] [PATCH v15 03/10] hw/vfio/platform: add irq assignment

2015-04-30 Thread Eric Auger
This patch adds the code requested to assign interrupts to a guest. The interrupts are mediated through user handled eventfds only. Signed-off-by: Eric Auger --- v13 -> v14: - remove virtualID field in header v12 -> v13: - start user-side eventfd handling at realize time - remove start_irq_fn

[Qemu-devel] [PATCH v15 10/10] hw/vfio/platform: add irqfd support

2015-04-30 Thread Eric Auger
This patch aims at optimizing IRQ handling using irqfd framework. Instead of handling the eventfds on user-side they are handled on kernel side using - the KVM irqfd framework, - the VFIO driver virqfd framework. the virtual IRQ completion is trapped at interrupt controller This removes the need

[Qemu-devel] [PATCH v15 04/10] hw/vfio/platform: calxeda xgmac device

2015-04-30 Thread Eric Auger
The platform device class has become abstract. This patch introduces a calxeda xgmac device that derives from it. Signed-off-by: Eric Auger Reviewed-by: Alex Bennee --- v10 -> v11: - add Alex Reviewed-by - move virt modifications in a separate patch v8 -> v9: - renamed calxeda_xgmac.c into calx

[Qemu-devel] [PATCH v15 05/10] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-04-30 Thread Eric Auger
This patch allows the instantiation of the vfio-calxeda-xgmac device from the QEMU command line (-device vfio-calxeda-xgmac,host=""). A specialized device tree node is created for the guest, containing compat, dma-coherent, reg and interrupts properties. Signed-off-by: Eric Auger --- v12 -> v13

[Qemu-devel] [PATCH v15 09/10] sysbus: add irq_routing_notifier

2015-04-30 Thread Eric Auger
Add a new connect_irq_notifier notifier in the SysBusDeviceClass. This notifier, if populated, is called after sysbus_connect_irq. This mechanism is used to setup VFIO signaling once VFIO platform devices get attached to their platform bus, on a machine init done notifier. Signed-off-by: Eric Aug

[Qemu-devel] [PATCH v15 08/10] intc: arm_gic_kvm: set the qemu_irq/gsi mapping

2015-04-30 Thread Eric Auger
The arm_gic_kvm now calls kvm_irqchip_set_qemuirq_gsi to build the hash table storing qemu_irq/gsi mappings. From that point on irqfd can be setup directly from the qemu_irq using kvm_irqchip_add_irqfd_notifier. Signed-off-by: Eric Auger --- v2 -> v3: - kvm_irqchip_add_qemuirq_irqfd_notifier re

[Qemu-devel] [PATCH v15 07/10] kvm-all.c: add qemu_irq/gsi hash table and utility routines

2015-04-30 Thread Eric Auger
VFIO platform device needs to setup irqfd but it does not know the gsi corresponding to the device qemu_irq. This series proposes to store a hash table in kvm_state using the qemu_irq as key and the gsi as a value. kvm_irqchip_set_qemuirq_gsi allows to insert such a pair. The interrupt controller

Re: [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30

2015-04-30 Thread Peter Maydell
On 30 April 2015 at 06:08, Michael Tokarev wrote: > Hello. > > This is the first pull request for trivial-patches tree since 2.3 has > been released. During the freeze many patches has been accumulated, > and even more has been received after 2.4 developmnent has been opened. > > So here we have

Re: [Qemu-devel] [REBASE PATCH v5 1/2] machine: add default_ram_size to machine class

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 11:40, Thomas Huth wrote: On 29/04/2015 11:06, Nikunj A Dadhania wrote: >> so David can push both patches. >> >> But isn't 1G a bit too much? At least on x86 you can easily boot with >> 512M. > > I understood this number as not the _minimum memory_ to

Re: [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30

2015-04-30 Thread Michael Tokarev
30.04.2015 15:58, Peter Maydell wrote: [] > Hi. I'm afraid this fails to build the tests on OSX: > CCtests/i440fx-test.o > /Users/pm215/src/qemu/tests/i440fx-test.c:229:21: warning: implicit > declaration > of function 'ARRAY_SIZE' is invalid in C99 So much for trivial ;) Let's remov

[Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30

2015-04-30 Thread Michael Tokarev
Another attempt, now without the problematic ARRAY_SIZE removal, but with additional patch removing the unused cpu_get_pc(), and with additional Reviewed-by. Resending only the newly added patch, not whole series. Thanks, /mjt The following changes since commit 06feaacfb4cfef10cc0c93d97df7bfc8a

[Qemu-devel] [PULL 42/42] openrisc: cpu: Remove unused cpu_get_pc

2015-04-30 Thread Michael Tokarev
From: Peter Crosthwaite This function is not used by anything. Remove. Signed-off-by: Peter Crosthwaite Reviewed-by: Alex Bennée Signed-off-by: Michael Tokarev --- target-openrisc/cpu.h | 5 - 1 file changed, 5 deletions(-) diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h inde

[Qemu-devel] [PATCH] MAINTAINERS: Add qemu-block list where missing

2015-04-30 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 25fd2b5..0b67c48 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -735,12 +735,14 @@ F: backends/rng*.c nvme M: Keith Busch +L: qemu-bl...@nongnu.org S: Supported

Re: [Qemu-devel] [PATCH 0/5] MAINTAINERS: split block layer

2015-04-30 Thread Kevin Wolf
Am 29.04.2015 um 16:13 hat Stefan Hajnoczi geschrieben: > Kevin and I have been maintaining the block layer together. We take weekly > turns reviewing/merging patches. The volume of traffic is so high that we > struggle to give timely code reviews. > > This series adjusts MAINTAINERS to reflect

[Qemu-devel] [PATCH v4 1/7] vmport.c: Fix vmport_cmd_ram_size

2015-04-30 Thread Don Slutz
Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz --- hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 7fcc00d..6b350ce 10064

[Qemu-devel] [PATCH v4 2/7] vmport_rpc: Add the object vmport_rpc

2015-04-30 Thread Don Slutz
This is the 1st part of "Add limited support of VMware's hyper-call rpc". This patch uses existing infrastructure used by vmmouse.c (provided by vmport.c) to handle the VMware backdoor command 30. One of the better on-line references is: https://sites.google.com/site/chitchatvmback/backdoor Mor

[Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Don Slutz
This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz (cherry picked from commit 6d99c91fc9ae27b476e89a8cc880b4a46e2375

[Qemu-devel] [PATCH v4 0/7] Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Don Slutz
Changes v4 to v4: Paolo Bonzini on "vmort_rpc: Add QMP access to vmport_rpc" Does this compile on non-x86 targets? Nope. Fixed. Changes v2 to v3: s/2.3/2.4 Changes v1 to v2: Added live migration code. Adjust data structures for migration. Switch to GHashTable. Eric B

[Qemu-devel] [PATCH v4 5/7] vmport_rpc: Add migration

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 8 +- 2 files changed, 255 insertions(+), 3 deletions(-) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index 0ba3319..a147561 100644 --- a/hw/misc/vmpo

Re: [Qemu-devel] [RFC PATCH 02/15] qdev: store DeviceState's canonical path to use when unparenting

2015-04-30 Thread Paolo Bonzini
On 29/04/2015 21:20, Michael Roth wrote: > If the parent is finalized as a result of object_unparent(), it > will still be attached to the composition tree at the time any > children are unparented as a result of that same call to > object_unparent(). However, in some cases, object_unparent() > w

[Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 269 +++

[Qemu-devel] [PATCH v4 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Don Slutz
The support included is enough to allow VMware tools to install in a guest and provide guestinfo support. guestinfo support is provided by what is known as VMware RPC support. If the guest is running VMware tools, then the "build version" of the tools is also available via the property build-numb

Re: [Qemu-devel] [PATCH] Enable NVMe start controller for Windows guest.

2015-04-30 Thread Kevin Wolf
[Cc: qemu-block] Am 24.04.2015 um 21:19 hat Keith Busch geschrieben: > On Fri, 24 Apr 2015, Daniel Stekloff wrote: > >Windows seems to send two separate calls to NVMe controller configuration. > >The > >first sends configuration info and the second the enable bit. I couldn't > >enable the Windows

Re: [Qemu-devel] [PATCH v4 0/3] block: Fix unaligned bdrv_aio_write_zeroes

2015-04-30 Thread Kevin Wolf
Am 27.04.2015 um 15:18 hat Fam Zheng geschrieben: > An unaligned zero write causes NULL deferencing in bdrv_co_do_pwritev. That > path is reachable from bdrv_co_write_zeroes and bdrv_aio_write_zeroes. > > You can easily trigger through the former with qemu-io, as the test case added > by 61815d6e0

[Qemu-devel] [PATCH v4 7/7] MAINTAINERS: add VMware port

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b5ab755..4bbda42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -755,6 +755,13 @@ S: Maintained F: hw/net/vmxnet* F: hw/scsi/vmw_pvscsi* +VMware port +M: Don Slut

Re: [Qemu-devel] [RESEND PATCH v4 2/4] apic: convert ->busdev.qdev casts to DEVICE() casts

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 07:43, Andreas Färber wrote: > Am 30.04.2015 um 03:33 schrieb Zhu Guihua: >> > Use DEVICE() casts to avoid accessing ICCDevice's qdev field >> > directly. >> > >> > Signed-off-by: Zhu Guihua >> > --- >> > hw/intc/apic.c | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletion

Re: [Qemu-devel] [PATCH 1/7] virtio-net: move qdev properties into virtio-net.c

2015-04-30 Thread Cornelia Huck
On Wed, 29 Apr 2015 23:24:03 +0800 Shannon Zhao wrote: > As only one place in virtio-net.c uses DEFINE_VIRTIO_NET_FEATURES, > there is no need to expose it. Inline it into virtio-net.c to avoid > wrongly use. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/net/virtio-

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

2015-04-30 Thread Cornelia Huck
On Wed, 29 Apr 2015 23:24:02 +0800 Shannon Zhao wrote: > The private qdev properties of virtio devices are only used by > themselves. As Peter suggested and like what virtio-blk has done, we > should move the private qdev properties into devices and don't expose > them to avoid wrongly use. > >

Re: [Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 15:32, Don Slutz wrote: > +#ifdef VMPORT_SHORT > +info->value->key = g_strdup(ckey); > +#else > +info->value->key = g_strdup_printf("guestinfo.%s", ckey); > +#endif What is VMPORT_SHORT for? Paolo

Re: [Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 15:32, Don Slutz wrote: > This is done by adding a new machine property vmware-port-ring3 that > needs to be enabled to have any effect. It only effects accel=tcg > mode. It is needed if you want to use VMware tools in accel=tcg > mode. How does it work on KVM or Xen? > > diff

Re: [Qemu-devel] [PATCH v4 0/7] Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Paolo Bonzini
On 30/04/2015 15:32, Don Slutz wrote: > Changes v4 to v4: > > Paolo Bonzini on "vmort_rpc: Add QMP access to vmport_rpc" > Does this compile on non-x86 targets? > Nope. Fixed. Only have a couple more questions, but apart from this it seems ready to go in. Thanks for your persistence

Re: [Qemu-devel] [RFC PATCH 03/15] spapr_drc: pass object ownership to parent/owner

2015-04-30 Thread Paolo Bonzini
On 29/04/2015 21:20, Michael Roth wrote: > DRC objects attach themselves to an owner as a child > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_drc.c | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [Qemu-devel] [RFC PATCH 04/15] spapr_iommu: pass object ownership to parent/owner

2015-04-30 Thread Paolo Bonzini
On 29/04/2015 21:20, Michael Roth wrote: > DRC objects attach themselves to an owner as a child > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_iommu.c | 1 + > 1 file changed, 1 insertion(+) > > d

Re: [Qemu-devel] [PATCH] nvme: support NVME_VOLATILE_WRITE_CACHE feature

2015-04-30 Thread Keith Busch
On Thu, 30 Apr 2015, Christoph Hellwig wrote: The SCSI emulation in the Linux NVMe driver really wants to know if a device has a volatile write cache. Given that qemu has moved away from a model where we report the backing store WCE bit to one where the WCE bit is supposed to be part of the migr

Re: [Qemu-devel] [RFC PATCH 05/15] spapr_pci: add PHB unrealize

2015-04-30 Thread Paolo Bonzini
On 29/04/2015 21:20, Michael Roth wrote: > To support PHB hotplug we need to clean up lingering references, > memory, child properties, etc. prior to the PHB object being > finalized. Generally this will be called as a result of calling > object_unref() on the PHB object, which in turn would norm

Re: [Qemu-devel] [RFC PATCH 08/15] spapr: create DR connectors for PHBs and register reset hooks

2015-04-30 Thread Paolo Bonzini
On 29/04/2015 21:20, Michael Roth wrote: > +if (spapr->dr_phb_enabled) { > +for (i = 0; i < SPAPR_DRC_MAX_PHB; i++) { > +sPAPRDRConnector *drc = > +spapr_dr_connector_new(OBJECT(machine), > + SPAPR_DR_CONNECTOR_TYPE_PHB

Re: [Qemu-devel] [RFC PATCH 11/15] qdev: add qbus_set_hotplug_handler_generic()

2015-04-30 Thread Paolo Bonzini
On 29/04/2015 21:20, Michael Roth wrote: > void qbus_set_hotplug_handler(BusState *bus, DeviceState *handler, Error > **errp) > { > -qbus_set_hotplug_handler_internal(bus, OBJECT(handler), errp); > +qbus_set_hotplug_handler_generic(bus, OBJECT(handler), errp); > } > I think it's ok

  1   2   3   >