On 04/28/2015 08:57 AM, Peter Crosthwaite wrote:
> On Mon, Apr 27, 2015 at 11:46 PM, Eric Auger wrote:
>> Hi Peter,
>>
>> On 04/27/2015 07:43 PM, Peter Crosthwaite wrote:
>>> On Mon, Apr 27, 2015 at 8:01 AM, Paolo Bonzini wrote:
On 27/04/2015 16:56, Eric Auger wrote:
> Peter, P
On Wed, 15 Apr 2015 21:25:03 +0800
Shannon Zhao wrote:
> From: Shannon Zhao
>
> Add aml_or() term and expose build_append_int_noprefix
> as it wiil be used by creating a buffer.
>
> Signed-off-by: Shannon Zhao
> Signed-off-by: Shannon Zhao
> ---
> hw/acpi/aml-build.c | 12 ++
On Tue, Apr 28, 2015 at 02:30:17PM +0800, Shannon Zhao wrote:
> On 2015/4/28 13:55, Michael S. Tsirkin wrote:
> > Pong.
> > You responded to Cornelia's comments on patch 1/2
> > with "ok will add".
> > I expected v4.
> >
>
> Yeah, but few comments on this patch, so I just want to confirm this
> m
On 2015/4/28 14:56, Igor Mammedov wrote:
> On Wed, 15 Apr 2015 21:25:03 +0800
> Shannon Zhao wrote:
>
>> From: Shannon Zhao
>>
>> Add aml_or() term and expose build_append_int_noprefix
>> as it wiil be used by creating a buffer.
>>
>> Signed-off-by: Shannon Zhao
>> Signed-off-by: Shannon Zhao
On Tue, Apr 28, 2015 at 11:12:10AM +0800, Jason Wang wrote:
>
>
> On Mon, Apr 27, 2015 at 7:02 PM, Michael S. Tsirkin wrote:
> >On Thu, Apr 23, 2015 at 02:21:48PM +0800, Jason Wang wrote:
> >> This patch increases the maximum number of virtqueues for pci from 64
> >> to 513. This will allow boot
On 04/10/2015 12:16 PM, David Gibson wrote:
On Wed, Apr 08, 2015 at 07:33:21PM +1000, Alexey Kardashevskiy wrote:
Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of
client-architecture-support patchset) there is a "compat" option
of "-cpu". However it was not documented at
On Mon, 27 Apr 2015 10:55:41 -0700
Peter Crosthwaite wrote:
> On Mon, Apr 27, 2015 at 10:51 AM, Thomas Huth wrote:
> > The error reporting in pci_nic_init() is quite erratic: Some errors
> > are printed directly with error_report(), and some are passed back
> > to the (only) caller pci_nic_init_
On Tue, Apr 28, 2015 at 02:13:29PM +0800, Shannon Zhao wrote:
> On 2015/4/28 13:20, Michael S. Tsirkin wrote:
> > On Tue, Apr 28, 2015 at 10:49:42AM +0800, Shannon Zhao wrote:
> >> On 2015/4/15 21:24, Shannon Zhao wrote:
> >>> From: Shannon Zhao
> >>>
> >>> This patch series generate seven ACPI ta
On 2015/4/28 15:15, Michael S. Tsirkin wrote:
> On Tue, Apr 28, 2015 at 02:30:17PM +0800, Shannon Zhao wrote:
>> On 2015/4/28 13:55, Michael S. Tsirkin wrote:
>>> Pong.
>>> You responded to Cornelia's comments on patch 1/2
>>> with "ok will add".
>>> I expected v4.
>>>
>>
>> Yeah, but few comments
On Tue, Apr 28, 2015 at 02:13:20PM +0800, Jason Wang wrote:
>
>
> On Tue, Apr 28, 2015 at 1:13 PM, Michael S. Tsirkin wrote:
> >On Tue, Apr 28, 2015 at 11:14:04AM +0800, Jason Wang wrote:
> >> On Mon, Apr 27, 2015 at 7:05 PM, Michael S. Tsirkin
> >> wrote:
> >> >On Thu, Apr 23, 2015 at 02:21
Paolo Bonzini writes:
> On 27/04/2015 13:14, Michael S. Tsirkin wrote:
>>> + *
>>> > + * This work is licensed under the terms of the GNU GPL, version
>>> > 2 or later.
>>> > + * See the COPYING file in the top-level directory.
>> The file you are moving this from is GPL only.
>
> It's BSD.
>
>>
On Mon, Apr 27, 2015 at 11:46 PM, Eric Auger wrote:
> Hi Peter,
>
> On 04/27/2015 07:43 PM, Peter Crosthwaite wrote:
>> On Mon, Apr 27, 2015 at 8:01 AM, Paolo Bonzini wrote:
>>>
>>>
>>> On 27/04/2015 16:56, Eric Auger wrote:
Peter, Paolo,
After your feedbacks, I feel I need to spen
On Wed, Apr 22, 2015 at 01:28:11AM -0500, Michael Roth wrote:
> This interface is used to fetch an OF device-tree nodes that describes a
> newly-attached device to guest. It is called multiple times to walk the
> device-tree node and fetch individual properties into a 'workarea'/buffer
> provided b
On Wed, Apr 22, 2015 at 01:28:16AM -0500, Michael Roth wrote:
> This option enables/disables PCI hotplug for a particular PHB.
>
> Also add machine compatibility code to disable it by default for machine
> types prior to pseries-2.4.
>
> Signed-off-by: Michael Roth
> Reviewed-by: David Gibson
>
On Wed, Apr 22, 2015 at 01:28:15AM -0500, Michael Roth wrote:
> Initially this is identifical to pseries-2.3. Subsequent patches will
> use it to mask new 2.4 features by default.
>
> Signed-off-by: Michael Roth
So, I've seen slightly different patches to add pseries-2.4 machine
type in at least
On Wed, Apr 22, 2015 at 01:28:18AM -0500, Michael Roth wrote:
> We need to work with PCI BARs to generate OF properties
> during PCI hotplug for sPAPR guests.
>
> Signed-off-by: Michael Roth
> Reviewed-by: David Gibson
> Cc: m...@redhat.com
Michael Tsirkin,
Interested to see your comment on th
>From the guest point of view unallocated blocks are zeroed.
Signed-off-by: Denis V. Lunev
CC: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/parallels.c b/block/parallels.c
index 138e618..ae64ce5 100644
--- a/blo
This patchset provides an ability to create of/write to Parallels
images and some testing of the new code. Readings and writings are
optimized out and I expect the same or slightly better performance
as qcow2.
Changes from v4:
- parallels format driver marked as bdrv_has_zero_init_1
- added missed
From: Roman Kagan
Implement VFS method for get_block_status to Parallels format driver.
qemu_co_mutex_lock is not necessary yet (the driver is read-only) but
will be necessary very soon when write will be supported.
Signed-off-by: Roman Kagan
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V
this follows QEMU coding convention
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 4f9cd8d..dca0df6
simple purification..
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index f3ffece..138e618 100644
--- a/
suggested by Jeff Cody
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
tests/qemu-iotests/076 | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/076 b/tests/qemu-iotests/076
index ed2be35..01
This will allow to use this data as buffer to BAT update directly
without any intermediate buffers.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
From: Roman Kagan
Switch the .bdrv_read method implementation from using bdrv_pread() to
bdrv_read() on the underlying file, since the latter is subject to i/o
throttling while the former is not.
Besides, since bdrv_read() operates in sectors rather than bytes, adjust
the helper functions to do
Try to perform IO for the biggest continuous block possible.
The performance for sequential read is increased from 220 Mb/sec to
360 Mb/sec for continous image on my SSD HDD.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 15f6cb3..f615f44 100644
--- a/block/parallels.c
+++ b/bl
Support write on Parallels images. The code is almost the same as one
in the previous patch implemented scatter-gather IO for read.
Signed-off-by: Denis V. Lunev
CC: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 90 +
Main approach is taken from qcow2_co_readv.
The patch drops coroutine lock for the duration of IO operation and
peforms normal scatter-gather IO using standard QEMU backend.
The patch also adds comment about locking considerations in the driver.
Signed-off-by: Denis V. Lunev
CC: Roman Kagan
CC
This is preparational commit for tweaks in Parallels image expansion.
The idea is that enlarge via truncate by one data block is slow. It
would be much better to use fallocate via bdrv_write_zeroes and
expand by some significant amount at once.
Original idea with sequential file writing to the end
From: Roman Kagan
Teach parallels_read() to do reads in coarser granularity than just a
single sector: if requested, read up to the cluster end in one go.
Signed-off-by: Roman Kagan
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
bl
Do not even care to create WithoutFreeSpace image, it is obsolete.
Always create WithouFreSpacExt one.
The code also does not spend a lot of efforts to fill cylinders and
heads fields, they are not used actually in a real life neither in
QEMU nor in Parallels products.
Signed-off-by: Denis V. Lun
BAT means 'block allocation table'. Thus this name is clean and shorter
on writing.
Some obvious formatting fixes in the old code were made to make checkpatch
happy.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels.c | 58
The check is very simple at the moment. It calculates necessary stats
and fix only the following errors:
- space leak at the end of the image. This would happens due to
preallocation
- clusters outside the image are zeroed. Nothing else could be done here
Signed-off-by: Denis V. Lunev
Reviewed-
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
tests/qemu-iotests/131 | 68 ++
tests/qemu-iotests/131.out | 24
tests/qemu-iotests/group | 1 +
3 files changed, 93 insert
Try to perform IO for the biggest continuous block possible.
All blocks abscent in the image are accounted in the same type
and preallocation is made for all of them at once.
The performance for sequential write is increased from 200 Mb/sec to
235 Mb/sec on my SSD HDD.
Signed-off-by: Denis V. Lun
deduplicate copy/paste arithmetcs
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 16fbdf4..1540
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
tests/qemu-iotests/076 | 5 +
tests/qemu-iotests/076.out | 10 ++
2 files changed, 15 insertions(+)
diff --git a/tests/qemu-iotests/076 b/tests/qemu-iotests/076
index 013997
calculate offset of the BAT entry in the image file.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/block/parallels.c b/block/parallels
On 2015/4/28 14:54, Igor Mammedov wrote:
> On Wed, 15 Apr 2015 21:25:02 +0800
> Shannon Zhao wrote:
>
>> From: Shannon Zhao
>>
>> Add ToUUID macro, this is useful for generating PCIe ACPI table.
>>
>> Signed-off-by: Shannon Zhao
>> Signed-off-by: Shannon Zhao
>> ---
>> hw/acpi/aml-build.c
The software driver must set inuse field in Parallels header to
0x746F6E59 when the image is opened in read-write mode. The presence of
this magic in the header on open forces image consistency check.
There is an unfortunate trick here. We can not check for inuse in
parallels_check as this will ha
This metadata cache would allow to properly batch BAT updates to disk
in next patches. These updates will be properly aligned to avoid
read-modify-write transactions on block level.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/pa
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
tests/qemu-iotests/131 | 9 +
tests/qemu-iotests/131.out | 17 +
2 files changed, 26 insertions(+)
diff --git a/tests/qemu-iotests/131 b/tests/qemu-iotests/131
i
This will help to avoid forward declarations for upcoming parallels_check
Some very obvious formatting fixes were made to the moved code to make
checkpatch happy.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
CC: Kevin Wolf
---
block/parallels.c | 191 ++
The idea is that we do not need to immediately sync BAT to the image as
from the guest point of view there is a possibility that IO is lost
even in the physical controller until flush command was finished.
bdrv_co_flush_to_os is exactly the right place for this purpose.
Technically the patch uses
Plain image expansion spends a lot of time to update image file size.
This seriously affects the performance. The following simple test
qemu_img create -f parallels -o cluster_size=64k ./1.hds 64G
qemu_io -n -c "write -P 0x11 0 1024M" ./1.hds
could be improved if the format driver will pre-allo
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index ba15ae0..2af3dd6 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2224,6 +2224,8 @@ static void xhci_kick_ep(XHCIState *xhci, unsigned int
On Tue, 28 Apr 2015 09:14:07 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Apr 28, 2015 at 02:13:20PM +0800, Jason Wang wrote:
> >
> >
> > On Tue, Apr 28, 2015 at 1:13 PM, Michael S. Tsirkin wrote:
> > >On Tue, Apr 28, 2015 at 11:14:04AM +0800, Jason Wang wrote:
> > >> On Mon, Apr 27, 2015 a
On 2015/4/28 14:54, Igor Mammedov wrote:
> btw:
> whole thing might be simpler if an intermediate conversion is avoided,
> just pack buffer as in spec byte by byte:
>
> /* format: aabbccdd-eeff-gghh-iijj-kkllmmnnoopp */
> assert(strlen(uuid) == ...);
> build_append_byte(var->buf, HEX2BYTE(uuid[3])
On 28/04/2015 00:46, Don Slutz wrote:
> This adds one new inject command:
>
> inject-vmport-action
>
> And three guest info commands:
>
> vmport-guestinfo-set
> vmport-guestinfo-get
> query-vmport-guestinfo
>
> More details in qmp-commands.hx
>
> Signed-off-by: Don Slutz
> ---
> hw/misc/vm
On Tue, 28 Apr 2015 15:46:22 +0800
Shannon Zhao wrote:
> On 2015/4/28 14:54, Igor Mammedov wrote:
> > On Wed, 15 Apr 2015 21:25:02 +0800
> > Shannon Zhao wrote:
> >
> >> From: Shannon Zhao
> >>
> >> Add ToUUID macro, this is useful for generating PCIe ACPI table.
> >>
> >> Signed-off-by: Shann
On Tue, Apr 28, 2015 at 10:04:15AM +0200, Cornelia Huck wrote:
> On Tue, 28 Apr 2015 09:14:07 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Tue, Apr 28, 2015 at 02:13:20PM +0800, Jason Wang wrote:
> > >
> > >
> > > On Tue, Apr 28, 2015 at 1:13 PM, Michael S. Tsirkin
> > > wrote:
> > > >On Tue,
Hi Emilio,
On 27/04/2015 19:06, Emilio G. Cota wrote:
Hi Fred,
On Wed, Apr 22, 2015 at 14:26:14 +0200, Frederic Konrad wrote:
git clone g...@git.greensocs.com:fkonrad/mttcg.git -b multi_tcg_v4
I've tried to run buildroot's vexpress-a9 with this, but unfortunately
it gets stuck before showing
On Tue, Apr 28, 2015 at 03:28:51PM +0800, Shannon Zhao wrote:
> On 2015/4/28 15:15, Michael S. Tsirkin wrote:
> > On Tue, Apr 28, 2015 at 02:30:17PM +0800, Shannon Zhao wrote:
> >> On 2015/4/28 13:55, Michael S. Tsirkin wrote:
> >>> Pong.
> >>> You responded to Cornelia's comments on patch 1/2
> >>
Am 28.04.2015 um 04:59 hat tu bo geschrieben:
> Hi Kevin:
>
> On 04/27/2015 07:34 PM, Kevin Wolf wrote:
>
> Am 27.04.2015 um 13:24 hat Max Reitz geschrieben:
>
> On 27.04.2015 09:15, tu bo wrote:
>
> Hi Max:
>
> On 04/24/2015 01:07 AM, Max Reitz wrote:
>
>
Add a new API named acpi_send_gpe_event() to send hotplug SCI.
This API can be used by pci, cpu and memory hotplug.
This patch is rebased on pci branch in mst's tree.
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
Signed-off-by: Zhu Guihua
---
v3:
-rebase on pci branch in mst's tree
-use t
On 04/28/2015 10:31 AM, Markus Armbruster wrote:
Paolo Bonzini writes:
On 27/04/2015 13:14, Michael S. Tsirkin wrote:
+ *
+ * This work is licensed under the terms of the GNU GPL, version
2 or later.
+ * See the COPYING file in the top-level directory.
The file you are moving this from is G
Eric Blake writes:
> The next patch will quit special-casing "'union':'Foo',
> 'discriminator':{}" and instead use "'alternate':'Foo'".
>
> Separating docs from implementation makes it easier to focus
> on wording without holding up code. In particular, making
> alternate a separate type makes f
On 04/28/2015 11:30 AM, Michael S. Tsirkin wrote:
On Mon, Apr 27, 2015 at 03:26:44PM +0300, Marcel Apfelbaum wrote:
On 04/27/2015 02:14 PM, Michael S. Tsirkin wrote:
On Thu, Mar 19, 2015 at 08:52:44PM +0200, Marcel Apfelbaum wrote:
@@ -2414,7 +1945,6 @@ static const TypeInfo pci_device_type_in
On Mon, Apr 27, 2015 at 03:26:44PM +0300, Marcel Apfelbaum wrote:
> On 04/27/2015 02:14 PM, Michael S. Tsirkin wrote:
> >On Thu, Mar 19, 2015 at 08:52:44PM +0200, Marcel Apfelbaum wrote:
> >>@@ -2414,7 +1945,6 @@ static const TypeInfo pci_device_type_info = {
> >>
> >> static void pci_register_typ
On Tue, Apr 28, 2015 at 04:24:02PM +0800, Zhu Guihua wrote:
> Add a new API named acpi_send_gpe_event() to send hotplug SCI.
> This API can be used by pci, cpu and memory hotplug.
>
> This patch is rebased on pci branch in mst's tree.
> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
>
> Signe
On 04/27/2015 11:54 PM, Michael S. Tsirkin wrote:
On Mon, Apr 27, 2015 at 04:04:38PM +0300, Marcel Apfelbaum wrote:
On 04/27/2015 03:48 PM, Michael S. Tsirkin wrote:
On Mon, Apr 27, 2015 at 03:30:01PM +0300, Marcel Apfelbaum wrote:
On 04/27/2015 02:24 PM, Michael S. Tsirkin wrote:
On Thu, Mar
On Tue, Apr 28, 2015 at 05:31:03PM +1000, David Gibson wrote:
> On Wed, Apr 22, 2015 at 01:28:18AM -0500, Michael Roth wrote:
> > We need to work with PCI BARs to generate OF properties
> > during PCI hotplug for sPAPR guests.
> >
> > Signed-off-by: Michael Roth
> > Reviewed-by: David Gibson
> >
On 04/27/2015 05:45 PM, Michael S. Tsirkin wrote:
On Mon, Apr 27, 2015 at 04:01:16PM +0300, Marcel Apfelbaum wrote:
On 04/27/2015 03:14 PM, Michael S. Tsirkin wrote:
On Thu, Mar 19, 2015 at 08:52:48PM +0200, Marcel Apfelbaum wrote:
TYPE_PCI_HOST_BRIDGE_SNOOPED is a special case of host bridge
On Tue, Apr 28, 2015 at 09:26:47AM +0200, Thomas Huth wrote:
> On Mon, 27 Apr 2015 10:55:41 -0700
> Peter Crosthwaite wrote:
>
> > On Mon, Apr 27, 2015 at 10:51 AM, Thomas Huth wrote:
> > > The error reporting in pci_nic_init() is quite erratic: Some errors
> > > are printed directly with error_
On Wed, 15 Apr 2015 21:25:08 +0800
Shannon Zhao wrote:
> From: Shannon Zhao
>
> Add PCIe controller in ACPI DSDT table, so the guest can detect
> the PCIe.
>
> Signed-off-by: Shannon Zhao
> Signed-off-by: Shannon Zhao
> ---
> hw/arm/virt-acpi-build.c | 152
> +++
Eric Blake writes:
> Previous patches have led up to the point where I create the
> new meta-type "'alternate':'Foo'". See the previous patches
> for documentation; I intentionally split as much work into
> earlier patches to minimize the size of this patch, but a lot
> of it is churn due to tes
On Tue, Apr 28, 2015 at 11:39:42AM +0300, Marcel Apfelbaum wrote:
> On 04/27/2015 05:45 PM, Michael S. Tsirkin wrote:
> >On Mon, Apr 27, 2015 at 04:01:16PM +0300, Marcel Apfelbaum wrote:
> >>On 04/27/2015 03:14 PM, Michael S. Tsirkin wrote:
> >>>On Thu, Mar 19, 2015 at 08:52:48PM +0200, Marcel Apfe
On Tue, Apr 28, 2015 at 10:42:25AM +0200, Igor Mammedov wrote:
> On Wed, 15 Apr 2015 21:25:08 +0800
> Shannon Zhao wrote:
>
> > From: Shannon Zhao
> >
> > Add PCIe controller in ACPI DSDT table, so the guest can detect
> > the PCIe.
> >
> > Signed-off-by: Shannon Zhao
> > Signed-off-by: Shann
On 27/04/2015 19:43, Peter Crosthwaite wrote:
> To reduce verbosity, I suggest making object_set_link_property() a
> visible API, then RYO link setters can call it surrounded by custom
> behavior e.g:
>
> foo_object_set_bar_property(...)
> {
> pre_set_link_side_effects();
> object_set_li
On 04/28/2015 04:52 PM, Igor Mammedov wrote:
On Tue, 28 Apr 2015 16:24:02 +0800
Zhu Guihua wrote:
Add a new API named acpi_send_gpe_event() to send hotplug SCI.
This API can be used by pci, cpu and memory hotplug.
This patch is rebased on pci branch in mst's tree.
git://git.kernel.org/pub/sc
On 27/04/2015 19:06, Emilio G. Cota wrote:
> Note that I'm running with -smp 1. My guess is that the iothread
> is starved, since patch 472f4003 "Drop global lock during TCG code execution"
> removes from the iothread the ability to kick CPU threads.
In theory that shouldn't be necessary anymore
From: Gonglei
These trivial patches are collected by me
during qemu 2.3 hard-freeze time, which spoted by coverity.
Please ack or review if possible, thanks.
Gonglei (3):
target-mips: fix memory leak
xhci: remove unused code
vhost-user: remove superfluous '\n' around error_report()
hw/m
From: Gonglei
Signed-off-by: Gonglei
---
hw/virtio/vhost-user.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index aefe0bb..e7ab829 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@
From: Gonglei
Value from xfer->packet.ep is assigned to ep here, but that
stored value is not used before it is overwritten. Remove it.
Cc: Gerd Hoffmann
Signed-off-by: Gonglei
---
hw/usb/hcd-xhci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index
From: Gonglei
Coveristy reports that variable prom_buf/params_buf going
out of scope leaks the storage it points to.
Cc: Aurelien Jarno
Cc: Leon Alrae
Signed-off-by: Gonglei
---
hw/mips/mips_fulong2e.c | 1 +
hw/mips/mips_malta.c| 1 +
hw/mips/mips_r4k.c | 1 +
3 files changed, 3 in
On 2015/4/28 16:47, Michael S. Tsirkin wrote:
> On Tue, Apr 28, 2015 at 10:42:25AM +0200, Igor Mammedov wrote:
>> On Wed, 15 Apr 2015 21:25:08 +0800
>> Shannon Zhao wrote:
>>
>>> From: Shannon Zhao
>>>
>>> Add PCIe controller in ACPI DSDT table, so the guest can detect
>>> the PCIe.
>>>
>>> Signe
On 2015/4/28 16:15, Igor Mammedov wrote:
>>> btw:
>>> > > whole thing might be simpler if an intermediate conversion is avoided,
>>> > > just pack buffer as in spec byte by byte:
>>> > >
>>> > > /* format: aabbccdd-eeff-gghh-iijj-kkllmmnnoopp */
>>> > > assert(strlen(uuid) == ...);
>>> > > build_a
qdev_init_gpio_out_named takes a new argument corresponding to the
check callback passed to object_property_add_link. In qdev_init_gpio_out
this callback is set to the dummy object_property_allow_set_link.
This will allow qdev_init_gpio_out_named callers to specialize this
callback, typically sysb
The VFIO platform device gets connected to the platform bus
on a machine init done notifier. Only at that point irqfd can be
setup. An irq connect notifier would be helpful to do that job.
Instead of adding a new callback at sysbus or qdev level, this
series proposes to use the property check() cal
Add a new callback in the SysBusDeviceClass. This callback now can
be overriden by devices inheriting from sysbus. By default the callback
is set to the dummy object_property_allow_set_link callback.
Signed-off-by: Eric Auger
---
hw/core/sysbus.c| 8 +++-
include/hw/sysbus.h | 1 +
2 fil
Check callback now takes as third argument an Object **. In
object_set_link_property, we pass the property child as argument.
We also assign the *child before the check call so that enhanced
check can be performed in the callback. In case the check fails,
the old value is restored and ref count is
On Tue, 28 Apr 2015 16:24:02 +0800
Zhu Guihua wrote:
> Add a new API named acpi_send_gpe_event() to send hotplug SCI.
> This API can be used by pci, cpu and memory hotplug.
>
> This patch is rebased on pci branch in mst's tree.
> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
>
> Signed-off
On 28 April 2015 at 09:18, Michael S. Tsirkin wrote:
> On Tue, Apr 28, 2015 at 03:28:51PM +0800, Shannon Zhao wrote:
>> On 2015/4/28 15:15, Michael S. Tsirkin wrote:
>> > My question would be, why just net and scsi?
>> > Does not the same apply to all devices?
>> >
>>
>> The virtio-blk has been ch
On 27 April 2015 at 12:07, Gerd Hoffmann wrote:
> Hi,
>
> Here is the spice patch queue, carrying a bunch of minor
> patches piled up during the freeze.
>
> My spice patch queue is empty now, if I happened to have
> missed anything please resend.
>
> please pull,
> Gerd
>
> The following chang
On 2015/3/30 1:09, Michael Tokarev wrote:
> 28.03.2015 10:46, Gonglei wrote:
> []
>>> Can this go through -trivial?
>>>
>> It's ok, but I don't know if -trivial branch maintainer has a plan to send a
>> pull request
>> for rc2.
>
> I do have plan to send a pull request, but this thing is ugly. T
Add a new API named acpi_send_gpe_event() to send hotplug SCI.
This API can be used by pci, cpu and memory hotplug.
This patch is rebased on pci branch in mst's tree.
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
Signed-off-by: Zhu Guihua
---
v4:
-rename struct AcpiHotplugStatus to AcpiGP
On Tue, 28 Apr 2015 16:52:19 +0800
Shannon Zhao wrote:
> On 2015/4/28 16:15, Igor Mammedov wrote:
> >>> btw:
> >>> > > whole thing might be simpler if an intermediate conversion is avoided,
> >>> > > just pack buffer as in spec byte by byte:
> >>> > >
> >>> > > /* format: aabbccdd-eeff-gghh-iijj
On Fri, Apr 10, 2015 at 05:33:35PM +0800, Jason Wang wrote:
> Currently we allocate one vhost log per vhost device. This is sub
> optimal when:
>
> - Guest has several device with vhost as backend
> - Guest has multiqueue devices
>
> In the above cases, we can avoid the memory allocation by shari
On Mo, 2015-04-27 at 17:03 +0200, Ján Tomko wrote:
> Commit v2.2.0-1530-ge556032 vnc: switch to inet_listen_opts
> bypassed the use of inet_parse in inet_listen, making literal
> IPv6 addresses enclosed in brackets fail:
>
> qemu-kvm: -vnc [::1]:0: Failed to start VNC server on `(null)':
> address
On 2015/4/28 17:35, Igor Mammedov wrote:
> On Tue, 28 Apr 2015 16:52:19 +0800
> Shannon Zhao wrote:
>
>> On 2015/4/28 16:15, Igor Mammedov wrote:
> btw:
>>> whole thing might be simpler if an intermediate conversion is avoided,
>>> just pack buffer as in spec byte by byte:
>>>
>>>
On Tue, Apr 28, 2015 at 10:46:39AM +0300, Denis V. Lunev wrote:
> Main approach is taken from qcow2_co_readv.
>
> The patch drops coroutine lock for the duration of IO operation and
> peforms normal scatter-gather IO using standard QEMU backend.
>
> The patch also adds comment about locking consi
On Tue, Apr 28, 2015 at 10:46:41AM +0300, Denis V. Lunev wrote:
> From the guest point of view unallocated blocks are zeroed.
>
> Signed-off-by: Denis V. Lunev
> CC: Roman Kagan
> CC: Kevin Wolf
> CC: Stefan Hajnoczi
> ---
> block/parallels.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-
On Tue, 28 Apr 2015 17:06:00 +0800
Shannon Zhao wrote:
> On 2015/4/28 16:47, Michael S. Tsirkin wrote:
> > On Tue, Apr 28, 2015 at 10:42:25AM +0200, Igor Mammedov wrote:
> >> On Wed, 15 Apr 2015 21:25:08 +0800
> >> Shannon Zhao wrote:
> >>
> >>> From: Shannon Zhao
> >>>
> >>> Add PCIe controlle
On Tue, Apr 28, 2015 at 5:37 PM, Michael S. Tsirkin
wrote:
On Fri, Apr 10, 2015 at 05:33:35PM +0800, Jason Wang wrote:
Currently we allocate one vhost log per vhost device. This is sub
optimal when:
- Guest has several device with vhost as backend
- Guest has multiqueue devices
In
On 07/04/2015 15:53, Denis V. Lunev wrote:
> Replace call of cpu_is_bsp(s->cpu) which really returns
> !!(s->apicbase & MSR_IA32_APICBASE_BSP)
> with directly collected value. Due to this the tracepoint
> trace_cpu_get_apic_base((uint64_t)s->apicbase);
> will not be hit anymore in apic_rese
On Wed, Apr 22, 2015 at 04:05:34PM +0530, Nikunj A Dadhania wrote:
> Each hardware instance has a platform unique location code. The OF
> device tree that describes a part of a hardware entity must include
> the “ibm,loc-code” property with a value that represents the location
> code for that hard
On Wed, Apr 22, 2015 at 04:05:33PM +0530, Nikunj A Dadhania wrote:
> All the PCI enumeration and device node creation was off-loaded to
> SLOF. With PCI hotplug support, code needed to be added to add device
> node. This creates multiple copy of the code one in SLOF and other in
> hotplug code. To
On 04/28/2015 11:43 AM, Michael S. Tsirkin wrote:
On Tue, Apr 28, 2015 at 11:39:42AM +0300, Marcel Apfelbaum wrote:
On 04/27/2015 05:45 PM, Michael S. Tsirkin wrote:
On Mon, Apr 27, 2015 at 04:01:16PM +0300, Marcel Apfelbaum wrote:
On 04/27/2015 03:14 PM, Michael S. Tsirkin wrote:
On Thu, Mar
On Tue, Apr 28, 2015 at 05:58:28PM +0800, Jason Wang wrote:
>
>
> On Tue, Apr 28, 2015 at 5:37 PM, Michael S. Tsirkin wrote:
> >On Fri, Apr 10, 2015 at 05:33:35PM +0800, Jason Wang wrote:
> >> Currently we allocate one vhost log per vhost device. This is sub
> >> optimal when:
> >> - Guest has s
On 27 April 2015 at 16:20, Peter Maydell wrote:
> 2.4 is not officially open yet (I'm waiting for Michael to post
> the actual 2.3 release announcement) but this is lined up
> ready, since I'd like to get the memory attributes patches in
> sooner rather than later to reduce the risk of conflicts.
1 - 100 of 373 matches
Mail list logo
