[Qemu-devel] [PATCH 3/4] qemu-ga: Introduce Windows MSI script

2015-04-26 Thread Yossi Hindin
The script enables building Windows MSI installation package on Linux with wixl tool. Signed-off-by: Yossi Hindin --- qga/installer/qemu-ga.wxs | 145 ++ 1 file changed, 145 insertions(+) create mode 100644 qga/installer/qemu-ga.wxs diff --git a/qga

[Qemu-devel] [PATCH 0/4] MSI installation for Windows Guest Agent

2015-04-26 Thread Yossi Hindin
The patches' set introduce creation of MSI installer for Windows guest agent with wixl tool. Yossi Hindin (4): qemu-ga: adding vss-[un]install options qemu-ga: debug printouts to help troubleshoot installation qemu-ga: Introduce Windows MSI script qemu-ga: Building Windows MSI installation

[Qemu-devel] [PATCH 2/4] qemu-ga: debug printouts to help troubleshoot installation

2015-04-26 Thread Yossi Hindin
Debug printouts extended, helps installation troubleshooting Signed-off-by: Yossi Hindin --- qga/channel-win32.c | 2 +- qga/commands-win32.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 0d5e5f5..04fa5e4 100644 --- a/qga/ch

[Qemu-devel] [PATCH 1/4] qemu-ga: adding vss-[un]install options

2015-04-26 Thread Yossi Hindin
Existing command line options include '-s install' and '-s uninstall'. These options install/uninstall both Windows QEMU GA service and optional VSS COM server. The QEMU GA Windows service allows always-on serving guest agent's QMP commands and VSS COM server enables guest agent integration with Vo

[Qemu-devel] [PATCH 4/4] qemu-ga: Building Windows MSI installation with configure/Makefile

2015-04-26 Thread Yossi Hindin
New options were added to enable Windows MSI installation package creation: Option --enable-guest-msi, like the name suggest, enables building Windows MSI package for QEMU guest agent; option --disable-guest-msi disables MSI package creation; by default, no MSI package is created Signed-off-by: Y

Re: [Qemu-devel] [PATCH 16/17] ipmi: Add ACPI table entries

2015-04-26 Thread Michael S. Tsirkin
On Thu, Apr 23, 2015 at 05:57:57PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > Use the new ACPI table construction tools to create an ACPI > entry for IPMI. > > Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin > --- > hw/ipmi/Makefile.objs | 1 + > hw/ipmi/ipmi_acpi.c

Re: [Qemu-devel] [PATCH 14/17] ipmi: Add SMBIOS table entry

2015-04-26 Thread Michael S. Tsirkin
On Thu, Apr 23, 2015 at 05:57:55PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > Add an IPMI table entry to the SMBIOS. > > Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin > --- > default-configs/i386-softmmu.mak | 1 + > default-configs/x86_64-softmmu.mak | 1 + > h

Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-04-26 Thread Michael S. Tsirkin
On Thu, Apr 23, 2015 at 05:57:43PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > This provides the base infrastructure to tie IPMI low-level > interfaces into a PC ISA bus. > > Signed-off-by: Corey Minyard > --- > default-configs/i386-softmmu.mak | 1 + > default-configs/x86_64-s

Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-04-26 Thread Michael S. Tsirkin
On Thu, Apr 23, 2015 at 05:57:43PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > This provides the base infrastructure to tie IPMI low-level > interfaces into a PC ISA bus. > > Signed-off-by: Corey Minyard > --- > default-configs/i386-softmmu.mak | 1 + > default-configs/x86_64-s

Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-04-26 Thread Michael S. Tsirkin
On Sun, Apr 26, 2015 at 10:58:56AM +0200, Michael S. Tsirkin wrote: > On Thu, Apr 23, 2015 at 05:57:43PM -0500, miny...@acm.org wrote: > > From: Corey Minyard > > > > This provides the base infrastructure to tie IPMI low-level > > interfaces into a PC ISA bus. > > > > Signed-off-by: Corey Minyar

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-26 Thread Andreas Färber
Am 24.04.2015 um 01:11 schrieb Eric Blake: > On 04/23/2015 04:57 PM, miny...@acm.org wrote: >> The major changes from last time are: > > That says this series should probably be named v2 (git > format-patch/send-email -v2) or later, as part of the subject line. If > the previous version is more th

Re: [Qemu-devel] [RFC PATCH v3 05/24] spapr: Reorganize CPU dt generation code

2015-04-26 Thread Bharata B Rao
On Fri, Apr 24, 2015 at 12:17:27PM +0530, Bharata B Rao wrote: > Reorganize CPU device tree generation code so that it be reused from > hotplug path. CPU dt entries are now generated from spapr_finalize_fdt() > instead of spapr_create_fdt_skel(). Creating CPU DT entries from spapr_finalize_fdt() i

Re: [Qemu-devel] Trouble with numlock and SDL

2015-04-26 Thread Erik Rull
Hi Gerd, it seems to be a bug sitting in front of the computer :-) I just recompiled the new SDL and didn't recompile QEMU against the new SDL - I recognized later that there are version dependent pieces of code in QEMU. I will proceed my tests on this topic on other systems, I will send an u

[Qemu-devel] [PATCH] ps2 keyboard:fix can't use ps2 keyboard if typing many times After leaving grub and before finishing linux kernel ps2 driver initialization

2015-04-26 Thread penghao122
Starting a linux guest with ps2 keyboard ,if you type many times during leaving grub and into linux kernel ,then you can't use keyboard after linux initialization finished. during grub,the work method of ps2 keyboard is like this: first ,ps2 keyboard driver send command KBD_CCMD_KBD_ENABLE, seco

Re: [Qemu-devel] [PATCH v2 0/7] Remove more unused functions

2015-04-26 Thread Thomas Huth
Am Wed, 18 Mar 2015 12:22:35 +0100 schrieb Thomas Huth : > > Here are some more patches to remove completely unused functions > from QEMU. Please review carefully, some of the functions might > still get usefull in the future again, so if you discover one, > please let me know, then I'll remove i

[Qemu-devel] [PATCH] vhost-user: Send VHOST_RESET_OWNER on vhost stop

2015-04-26 Thread Luke Gorrie
Hilarity can ensue if vhost is left enabled while a guest reboots. Luke Gorrie (1): vhost-user: Send VHOST_RESET_OWNER on vhost stop hw/net/vhost_net.c | 7 +++ 1 file changed, 7 insertions(+) -- 2.1.4

[Qemu-devel] [PATCH] vhost-user: Send VHOST_RESET_OWNER on vhost stop

2015-04-26 Thread Luke Gorrie
Ensure that the vhost-user slave knows when the vrings are valid and when they are invalid, for example during a guest reboot. The vhost-user protocol says this of VHOST_RESET_OWNER: Issued when a new connection is about to be closed. The Master will no longer own this connection (and

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-26 Thread Paolo Bonzini
On 26/04/2015 13:39, Andreas Färber wrote: >> That says this series should probably be named v2 (git >> format-patch/send-email -v2) or later, as part of the subject >> line. If the previous version is more than a couple weeks ago, >> it's also nice (but not required) to provide a URL to the >>

Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-04-26 Thread Paolo Bonzini
On 26/04/2015 11:05, Michael S. Tsirkin wrote: >> + >> +#define FW_CFG_IPMI_INTERFACE 0x30 >> +#define FW_CFG_IPMI_BASE_ADDR 0x31 >> +#define FW_CFG_IPMI_REG_SPACE 0x32 >> +#define FW_CFG_IPMI_REG_SPACING 0x33 >> +#define FW_CFG_IPMI_SLAVE_ADDR 0x34 >> +#define FW_CFG_IPMI_IRQ 0x35

[Qemu-devel] [PATCH 1/2] gtk: Fix VTE focus grabbing

2015-04-26 Thread Jan Kiszka
From: Jan Kiszka At least on GTK2, the VTE terminal has to be specified as target of gtk_widget_grab_focus. Otherwise, switching from one VTE terminal to another causes the focus to get lost. CC: John Snow Signed-off-by: Jan Kiszka --- ui/gtk.c | 8 +--- 1 file changed, 5 insertions(+), 3

[Qemu-devel] [PATCH 0/2] Usability fixes for GTK2

2015-04-26 Thread Jan Kiszka
Two small patches to fix annoying problems on GTK2. Both weren't tested on GTK3 (no working setup at hand). The first one comes with a tiny risk of behaving differently there. The second one may actually be required on GTK3 as well or is at least a nop there and doesn't need the version check. Jan

[Qemu-devel] [PATCH 2/2] gtk: Avoid accel key leakage into guest on console switch

2015-04-26 Thread Jan Kiszka
From: Jan Kiszka GTK2 sends the accel key to the guest when switching to the graphic console via that shortcut. Resolve this by ignoring any keys until the next key-release event. However, do not ignore keys when switching via the menu or when on GTK3. Signed-off-by: Jan Kiszka --- ui/gtk.c |

[Qemu-devel] [PATCH microblaze v1 2/6] mb: mmu: Delete flip_um fn prototype

2015-04-26 Thread Peter Crosthwaite
This is not implemented or used. Signed-off-by: Peter Crosthwaite --- target-microblaze/mmu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target-microblaze/mmu.h b/target-microblaze/mmu.h index 3f74dda..3b7a998 100644 --- a/target-microblaze/mmu.h +++ b/target-microblaze/mmu.h @@ -82,7 +8

[Qemu-devel] [PATCH microblaze v1 5/6] mb: cpu: Delete EXCP_NMI

2015-04-26 Thread Peter Crosthwaite
This define is unused. Remove. Signed-off-by: Peter Crosthwaite --- target-microblaze/cpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index f21da2f..6522af7 100644 --- a/target-microblaze/cpu.h +++ b/target-microblaze/cpu.h @@ -36,7 +36,

[Qemu-devel] [PATCH microblaze v1 4/6] mb: cpu: Remove unused CC_OP enum

2015-04-26 Thread Peter Crosthwaite
This enum is not used by anything. Remove. Signed-off-by: Peter Crosthwaite --- target-microblaze/cpu.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index 2c18b49..f21da2f 100644 --- a/target-microblaze/cpu.h +++ b/target-microblaze/c

[Qemu-devel] [PATCH microblaze v1 0/6] Microblaze Cleanups

2015-04-26 Thread Peter Crosthwaite
Hi Edgar, This is some code cleanup of Microblaze. Mainly unused code deletion but also code share of the defconfig (P1). Regards, Peter Peter Crosthwaite (6): defconfigs: Piggyback microblazeel on microblaze mb: mmu: Delete flip_um fn prototype mb: cpu: Remote unused cpu_get_pc mb: cpu:

[Qemu-devel] [PATCH microblaze v1 1/6] defconfigs: Piggyback microblazeel on microblaze

2015-04-26 Thread Peter Crosthwaite
Theres no difference in defconfig. Going forward microblazeel should superset microblaze so use an include. Signed-off-by: Peter Crosthwaite --- default-configs/microblazeel-softmmu.mak | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/default-configs/microblazeel-sof

[Qemu-devel] [PATCH microblaze v1 3/6] mb: cpu: Remote unused cpu_get_pc

2015-04-26 Thread Peter Crosthwaite
This function is not used by anything. Remove. Signed-off-by: Peter Crosthwaite --- target-microblaze/cpu.h | 5 - 1 file changed, 5 deletions(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index 7d06227..2c18b49 100644 --- a/target-microblaze/cpu.h +++ b/target-microblaz

[Qemu-devel] [PATCH microblaze v1 6/6] mb: cpu: delete unused cpu_interrupts_enabled

2015-04-26 Thread Peter Crosthwaite
This function is unused. Remove. Signed-off-by: Peter Crosthwaite --- target-microblaze/cpu.h | 5 - 1 file changed, 5 deletions(-) diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h index 6522af7..56d3403 100644 --- a/target-microblaze/cpu.h +++ b/target-microblaze/cpu.h @@ -31

Re: [Qemu-devel] [PATCH v1 5/7] STM32F205: Connect the ADC device

2015-04-26 Thread Peter Crosthwaite
On Sat, Apr 25, 2015 at 7:21 PM, Alistair Francis wrote: > On Sun, Apr 26, 2015 at 4:32 AM, Peter Crosthwaite > wrote: >> "devices" >> >> On Sat, Apr 25, 2015 at 1:18 AM, Alistair Francis >> wrote: >>> Connect the ADC device to the STM32F205 SoC. >>> >> >> "devices" > > Will fix both. > >> >>>

[Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition

2015-04-26 Thread Emilio G. Cota
It's defined in osdep.h and shouldn't be redefined here. Signed-off-by: Emilio G. Cota --- tests/i440fx-test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index d0bc8de..33a7ecb 100644 --- a/tests/i440fx-test.c +++ b/tests/i440fx-test.c @@ -27,8

[Qemu-devel] [PATCH target-arm 0/2] Unused code cleanups

2015-04-26 Thread Peter Crosthwaite
Hi Peter, Two unused code cleanups for target-arm/cpu.h Regards, Peter Peter Crosthwaite (2): arm: cpu.h: Remove unused typdefs arm: cpu.h: Delete unused cpu_pc_from_tb() target-arm/cpu.h | 14 -- 1 file changed, 14 deletions(-) -- 1.9.1

[Qemu-devel] [PATCH target-arm 1/2] arm: cpu.h: Remove unused typdefs

2015-04-26 Thread Peter Crosthwaite
These CP accessor function prototypes are unused. Remove them. Signed-off-by: Peter Crosthwaite --- target-arm/cpu.h | 5 - 1 file changed, 5 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 083211c..7069103 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -93,11 +

[Qemu-devel] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb()

2015-04-26 Thread Peter Crosthwaite
No code uses the cpu_pc_from_tb() function. Delete. Signed-off-by: Peter Crosthwaite --- target-arm/cpu.h | 9 - 1 file changed, 9 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 7069103..c9c5d30 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -1874,15 +1874,

[Qemu-devel] [PATCH] configure: alphabetize tricore in target list

2015-04-26 Thread Peter Crosthwaite
tricore was out of alphabetical order in the target list. Fix. Signed-off-by: Peter Crosthwaite --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 6969f6f..9f0d9bb 100755 --- a/configure +++ b/configure @@ -5169,8 +5169,6 @@ case "$t

Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition

2015-04-26 Thread Peter Crosthwaite
On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota wrote: > It's defined in osdep.h and shouldn't be redefined here. > > Signed-off-by: Emilio G. Cota Reviewed-by: Peter Crosthwaite It looks like there may be another one too: hw/audio/fmopl.c:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))

Re: [Qemu-devel] [PATCH RFC v7 5/7] qemu-iotests: s390x: fix test 049

2015-04-26 Thread tu bo
Hello Max: Xiao Guang Chen left IBM last week, and I took over this job. thanks for your comments :-) On 04/24/2015 12:47 AM, Max Reitz wrote: On 23.04.2015 04:42, Xiao Guang Chen wrote: From: Bo Tu Hm, why is Bo Tu the patch author, but doesn't have an S-o-b in the commit message? I cre

Re: [Qemu-devel] [PATCH RFC v7 6/7] qemu-iotests: s390x: fix test 051

2015-04-26 Thread tu bo
Hi Max: On 04/24/2015 01:00 AM, Max Reitz wrote: On 23.04.2015 04:42, Xiao Guang Chen wrote: The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is de

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-26 Thread Peter Crosthwaite
On Fri, Apr 24, 2015 at 5:39 AM, Eric Auger wrote: > Add a new irq_routing_notifier notifier in the SysBusDeviceClass. This > notifier, if populated, is called after sysbus_connect_irq. > > This mechanism is used to setup VFIO signaling once VFIO platform > devices get attached to their platform b

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/4] qemu-iotests: Test that "stop" doesn't drain block jobs

2015-04-26 Thread Fam Zheng
On Fri, 04/24 17:43, Max Reitz wrote: > On 03.04.2015 16:05, Fam Zheng wrote: > >Signed-off-by: Fam Zheng > >--- > > tests/qemu-iotests/129 | 86 > > ++ > > tests/qemu-iotests/129.out | 5 +++ > > tests/qemu-iotests/group | 1 + > > 3 files cha

Re: [Qemu-devel] [PATCH v2 2/2] block: Fix NULL deference for unaligned write if qiov is NULL

2015-04-26 Thread Fam Zheng
On Fri, 04/24 13:51, Paolo Bonzini wrote: > > > On 24/04/2015 13:00, Paolo Bonzini wrote: > >> -qemu_iovec_add(&local_qiov, head_buf, offset & (align - 1)); > >> -qemu_iovec_concat(&local_qiov, qiov, 0, qiov->size); > >> -use_local_qiov = true; > >> +if (qiov) { >

Re: [Qemu-devel] [RFC PATCH v3 05/24] spapr: Reorganize CPU dt generation code

2015-04-26 Thread Bharata B Rao
On Sun, Apr 26, 2015 at 05:17:48PM +0530, Bharata B Rao wrote: > On Fri, Apr 24, 2015 at 12:17:27PM +0530, Bharata B Rao wrote: > > Reorganize CPU device tree generation code so that it be reused from > > hotplug path. CPU dt entries are now generated from spapr_finalize_fdt() > > instead of spapr_

[Qemu-devel] [PATCH v3 0/3] block: Fix unaligned bdrv_aio_write_zeroes

2015-04-26 Thread Fam Zheng
An unaligned zero write causes NULL deferencing in bdrv_co_do_pwritev. That path is reachable from bdrv_co_write_zeroes and bdrv_aio_write_zeroes. You can easily trigger through the former with qemu-io, as the test case added by 61815d6e0aa. For bdrv_aio_write_zeroes, in common cases there's alway

[Qemu-devel] [PATCH v3 1/3] Revert "block: Fix unaligned zero write"

2015-04-26 Thread Fam Zheng
This reverts commit fc3959e4669a1c2149b91ccb05101cfc7ae1fc05. The core write code already handles the case, so remove this duplication. Signed-off-by: Fam Zheng --- block.c | 45 ++--- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/block.c

[Qemu-devel] [PATCH v3 3/3] qemu-iotests: Test unaligned sub-block zero write

2015-04-26 Thread Fam Zheng
Test zero write in byte range 512~1024 for 4k alignment. Signed-off-by: Fam Zheng --- tests/qemu-iotests/033 | 13 + tests/qemu-iotests/033.out | 30 ++ 2 files changed, 43 insertions(+) diff --git a/tests/qemu-iotests/033 b/tests/qemu-iotests/033 ind

[Qemu-devel] [PATCH v3 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-04-26 Thread Fam Zheng
For zero write, qiov passed by callers (qemu-io "write -z" and scsi-disk "write same") is NULL. Commit fc3959e466 fixed bdrv_co_write_zeroes which is the common case for this bug, but it still exists in bdrv_aio_write_zeroes. A simpler fix would be in bdrv_co_do_pwritev which is the NULL dereferen

[Qemu-devel] libcacard: cac_is_cac_card?

2015-04-26 Thread Michael Tokarev
This function is declared in libcacard/cac.h VCardStatus cac_is_cac_card(VReader *reader); it is referenced in a ifdef-ed out code in libcacard/vcard_emul_type.c: VCardEmulType vcard_emul_type_select(VReader *vreader) { #ifdef notdef /* since there is only one emulator no need to call this