[Qemu-devel] [Bug 1440843] Re: Guest WinXP crashes when trying to use a USB spectrometer

2015-04-21 Thread Erik Rull
Which version is used? Try the latest QEMU or at least QEMU 2.0. The behavior sounds like a pretty old QEMU version. Additionally, enable the EHCI controller (see example in the docs subdirectory). It it working on a native Windows XP? -- You received this bug notification because you are a membe

Re: [Qemu-devel] [PATCH 06/18] virtio: Return error from virtqueue_pop

2015-04-21 Thread Fam Zheng
On Tue, 04/21 08:49, Michael S. Tsirkin wrote: > On Fri, Apr 17, 2015 at 03:59:21PM +0800, Fam Zheng wrote: > > When getting invalid data from vring, virtqueue_pop used to print an > > error and exit. > > > > Add an errp parameter so it can return the error to callers. > > > > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH 04/18] virtio: Return error from virtqueue_next_desc

2015-04-21 Thread Fam Zheng
On Tue, 04/21 08:37, Michael S. Tsirkin wrote: > On Fri, Apr 17, 2015 at 03:59:19PM +0800, Fam Zheng wrote: > > Two callers pass error_abort now, which can be changed to check return value > > and pass the error on. > > > > Signed-off-by: Fam Zheng > > --- > > hw/virtio/virtio.c | 27 +++

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 09:43:36 +0800 Shannon Zhao wrote: > On 2015/4/20 19:32, Cornelia Huck wrote: > > On Mon, 20 Apr 2015 16:20:00 +0800 > > shannon.z...@linaro.org wrote: > > > >> From: Shannon Zhao > >> > >> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > >> The transports just s

Re: [Qemu-devel] [PATCH v2 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Make address_space_rw take transaction attributes, rather > than always using the 'unspecified' attributes. > > Signed-off-by: Peter Maydell > Reviewed-by: Paolo Bonzini > Reviewed-by: Edgar E. Iglesias > --- > dma-helpers.c| 3 ++- > exec.c

[Qemu-devel] [Bug 1440843] Re: Guest WinXP crashes when trying to use a USB spectrometer

2015-04-21 Thread Ruslan
I was using QEMU from git, v2.3.0-rc2, when reporting this bug. And this is the same since much earlier (about a year older) version. And of course I do enable EHCI controller via `-device usb-ehci`. And checked it with native Windows XP, where the device works with no problem. Actually, as I said

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-21 Thread Fam Zheng
On Mon, 04/20 17:13, Cornelia Huck wrote: > On Fri, 17 Apr 2015 15:59:15 +0800 > Fam Zheng wrote: > > > Currently, virtio code chooses to kill QEMU if the guest passes any invalid > > data with vring. That has drawbacks such as losing unsaved data (e.g. when > > guest user is writing a very long

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 08:52:36AM +0200, Paolo Bonzini wrote: > > > On 20/04/2015 22:34, Michael S. Tsirkin wrote: > > On Mon, Apr 20, 2015 at 09:10:02PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 20/04/2015 19:36, Michael S. Tsirkin wrote: > >>> At the implementation level, there's one big i

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 15:44:02 +0800 Fam Zheng wrote: > On Mon, 04/20 17:13, Cornelia Huck wrote: > > On Fri, 17 Apr 2015 15:59:15 +0800 > > Fam Zheng wrote: > > > > > Currently, virtio code chooses to kill QEMU if the guest passes any > > > invalid > > > data with vring. That has drawbacks such

[Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Gal Hammer
A predefined scope in the ACPI specs is precede with a backslash. Signed-off-by: Gal Hammer --- hw/i386/acpi-build.c| 2 +- include/hw/acpi/aml-build.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 8d1a761..05c1d3

Re: [Qemu-devel] about [SeaBIOS PATCH] Try to hard-reboot on rerun of post even on emulators.

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 02:29, Kevin O'Connor wrote: > On a typical x86 machine, the BIOS image is located in read-only > memory at 0x. The chipsets typically also support shadowing > that image to ram (or as a read-only copy) at 0xf. However, > neither qemu nor kvm fully support all the shad

Re: [Qemu-devel] [PATCH v2 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Add new address_space_ld*/st* functions which allow transaction > attributes and error reporting for basic load and stores. These > are named to be in line with the address_space_read/write/rw > buffer operations. > > The existing ld/st*_phys functions are now wrappers ar

Re: [Qemu-devel] about [SeaBIOS PATCH] Try to hard-reboot on rerun of post even on emulators.

2015-04-21 Thread Laszlo Ersek
Hi Amos, On 04/21/15 01:31, Amos Kong wrote: > Hi Kevin, > > When I use old seabios in some stable linux release, some bootable > devices (2 ide disks) would be lost when I try to restart guest by > Ctrl+Alt+Delete during boot stage. > > Releated Red Hat BZ: https://bugzilla.redhat.com/show_bug.

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-21 Thread Fam Zheng
On Tue, 04/21 10:04, Cornelia Huck wrote: > On Tue, 21 Apr 2015 15:44:02 +0800 > Fam Zheng wrote: > > > On Mon, 04/20 17:13, Cornelia Huck wrote: > > > On Fri, 17 Apr 2015 15:59:15 +0800 > > > Fam Zheng wrote: > > > > > > > Currently, virtio code chooses to kill QEMU if the guest passes any >

Re: [Qemu-devel] [PATCH v2 08/14] exec.c: Capture the memory attributes for a watchpoint hit

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Capture the memory attributes for the transaction which triggered > a watchpoint; this allows CPU specific code to implement features > like ARM's "user-mode only WPs also hit for LDRT/STRT accesses > made from privileged code". This change also correctly passes > through

Re: [Qemu-devel] [PATCH v2 09/14] Switch non-CPU callers from ld/st*_phys to address_space_ld/st*

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Switch all the uses of ld/st*_phys to address_space_ld/st*, > except for those cases where the address space is the CPU's > (ie cs->as). This was done with the following script which > generates a Coccinelle patch. > > A few over-80-columns lines in the result were rewrap

[Qemu-devel] [question] Clean way to retrieve the gsi of a sysbus device qemu_irq?

2015-04-21 Thread Eric Auger
Hi, I am trying to figure out a clean solution to retrieve the gsi associated to a sysbus device qemu_irq. Among other things this is needed to start VFIO platform signaling. With PCI, it seems the PCI host stores the mapping (*_route_intx_pin_to_irq). Without PCI, if my understanding is correct

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 16:38:31 +0800 Fam Zheng wrote: > On Tue, 04/21 10:04, Cornelia Huck wrote: > > On Tue, 21 Apr 2015 15:44:02 +0800 > > Fam Zheng wrote: > > > > > On Mon, 04/20 17:13, Cornelia Huck wrote: > > > > On Fri, 17 Apr 2015 15:59:15 +0800 > > > > Fam Zheng wrote: > > > > > > > > >

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-21 Thread Fam Zheng
On Tue, 04/21 11:08, Cornelia Huck wrote: > On Tue, 21 Apr 2015 16:38:31 +0800 > Fam Zheng wrote: > > > On Tue, 04/21 10:04, Cornelia Huck wrote: > > > On Tue, 21 Apr 2015 15:44:02 +0800 > > > Fam Zheng wrote: > > > > > > > On Mon, 04/20 17:13, Cornelia Huck wrote: > > > > > On Fri, 17 Apr 2015

Re: [Qemu-devel] [PATCH v2 10/14] target-arm: Honour NS bits in page tables

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Honour the NS bit in ARM page tables: > * when adding entries to the TLB, include the Secure/NonSecure >transaction attribute > * set the NS bit in the PAR when doing ATS operations > > Note that we don't yet correctly use the NSTable bit to > cause the page table w

Re: [Qemu-devel] [PATCH v2 11/14] target-arm: Use correct memory attributes for page table walks

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Factor out the page table walk memory accesses into their own function, > so that we can specify the correct S/NS memory attributes for them. > This will also provide a place to use the correct endianness and > handle the need for a stage-2 translation when virtualization

Re: [Qemu-devel] [PATCH v2 12/14] target-arm: Add user-mode transaction attribute

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Add a transaction attribute indicating that a memory access is being > done from user-mode (unprivileged). This corresponds to an equivalent > signal in ARM AMBA buses. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > include/exec/memattrs.h | 2 ++ >

Re: [Qemu-devel] [PATCH v2 13/14] target-arm: Use attribute info to handle user-only watchpoints

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Now that we have memory access attribute information in the watchpoint > checking code, we can correctly implement handling of watchpoints > which should match only on userspace accesses, where LDRT/STRT/LDT/STT > from EL1 are treated as userspace accesses. > > Signed-off

Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Check watchpoints against CPU security state

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > Fix a TODO in bp_wp_matches() now that we have a function for > testing whether the CPU is currently in Secure mode or not. > > Signed-off-by: Peter Maydell > Reviewed-by: Edgar E. Iglesias Reviewed-by: Alex Bennée > --- > target-arm/op_helper.c | 6 -- > 1 file

Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Igor Mammedov
On Tue, 21 Apr 2015 11:26:12 +0300 Gal Hammer wrote: > A predefined scope in the ACPI specs is precede with a backslash. > > Signed-off-by: Gal Hammer Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c| 2 +- > include/hw/acpi/aml-build.h | 2 +- > 2 files changed, 2 insertions(

Re: [Qemu-devel] [PATCH 06/18] virtio: Return error from virtqueue_pop

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 03:24:25PM +0800, Fam Zheng wrote: > On Tue, 04/21 08:49, Michael S. Tsirkin wrote: > > On Fri, Apr 17, 2015 at 03:59:21PM +0800, Fam Zheng wrote: > > > When getting invalid data from vring, virtqueue_pop used to print an > > > error and exit. > > > > > > Add an errp parame

Re: [Qemu-devel] virtio-blk and virtio-scsi performance comparison

2015-04-21 Thread Konstantin Krotov
16.04.2015 14:57, Paolo Bonzini пишет: On 16/04/2015 13:17, Konstantin Krotov wrote: In my production system i'm interested to use io=thread, becouse i export MD raid1 devices to guest's and i need to read from the MD device performs balanced between raid1 legs (it's true only if io=thread).

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-21 Thread Cornelia Huck
On Tue, 21 Apr 2015 17:16:53 +0800 Fam Zheng wrote: > On Tue, 04/21 11:08, Cornelia Huck wrote: > > My concern is mainly about legacy setups that aren't used interactively. > > > > How about pausing guest and generating an QMP event? That sounds good as well.

Re: [Qemu-devel] [PATCH 04/18] virtio: Return error from virtqueue_next_desc

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 03:30:23PM +0800, Fam Zheng wrote: > On Tue, 04/21 08:37, Michael S. Tsirkin wrote: > > On Fri, Apr 17, 2015 at 03:59:19PM +0800, Fam Zheng wrote: > > > Two callers pass error_abort now, which can be changed to check return > > > value > > > and pass the error on. > > > >

Re: [Qemu-devel] virtio-blk and virtio-scsi performance comparison

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 11:53, Konstantin Krotov wrote: >> Can you detail the problem more? That could be a kernel bug. > > I connect to the host system, two storage systems as block devices. Both > block devices combine md-raid1. md-device use as disk for virtual > machine. If i use io=native, read perf

Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 05:16:53PM +0800, Fam Zheng wrote: > On Tue, 04/21 11:08, Cornelia Huck wrote: > > On Tue, 21 Apr 2015 16:38:31 +0800 > > Fam Zheng wrote: > > > > > On Tue, 04/21 10:04, Cornelia Huck wrote: > > > > On Tue, 21 Apr 2015 15:44:02 +0800 > > > > Fam Zheng wrote: > > > > > >

Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote: > A predefined scope in the ACPI specs is precede with a backslash. > > Signed-off-by: Gal Hammer s/precede/preceded/ This is correct, but do we need this in 2.3? I'm split on this. Thoughts? If yes, commit log needs better explanation

Re: [Qemu-devel] [PATCH v2 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-21 Thread Shannon Zhao
On 2015/4/21 15:30, Cornelia Huck wrote: > On Tue, 21 Apr 2015 09:43:36 +0800 > Shannon Zhao wrote: > >> On 2015/4/20 19:32, Cornelia Huck wrote: >>> On Mon, 20 Apr 2015 16:20:00 +0800 >>> shannon.z...@linaro.org wrote: >>> From: Shannon Zhao Move DEFINE_VIRTIO_NET_FEATURES to the

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-04-21 Thread Stefano Stabellini
On Mon, 20 Apr 2015, Fabio Fantoni wrote: > I updated xen and qemu from xen 4.5.0 with its upstream qemu included to xen > 4.5.1-pre with qemu upstream from stable-4.5 (changed Config.mk to use > revision "master"). > After few minutes I booted windows 7 64 bit domU qemu crash, tried 2 times > with

[Qemu-devel] [PATCH v3 0/2] virtio: Move host features to backends

2015-04-21 Thread shannon . zhao
From: Shannon Zhao The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the performance is low. The virtio-*-pci, virtio-*-s390, and virtio-*-ccw already have the ability to forward property accesses to the backend child, by calling

[Qemu-devel] [PATCH v3 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi

2015-04-21 Thread shannon . zhao
From: Shannon Zhao Move DEFINE_VIRTIO_SCSI_FEATURES to the backend virtio-scsi. The transports just sync the host features from backend. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/s390x/s390-virtio-bus.c | 1 - hw/s390x/virtio-ccw.c | 1 - hw/scsi/virtio-scs

[Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-21 Thread shannon . zhao
From: Shannon Zhao Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. The transports just sync the host features from backend. Meanwhile move virtio_net_set_config_size to virtio-net. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/net/virtio-net.c| 5 +

[Qemu-devel] [virtio-vhost communication] memory mapping

2015-04-21 Thread Catalin Vasile
If I send a pointer to a vhost server from a virtio driver, do I have to do anything else before I can call copy_from_user() or copy_to_user() on that pointer?

Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 11:09, Michael S. Tsirkin wrote: > On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote: >> A predefined scope in the ACPI specs is precede with a backslash. >> >> Signed-off-by: Gal Hammer > > s/precede/preceded/ > > This is correct, but do we need this in 2.3? > I'm sp

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-04-21 Thread Fabio Fantoni
Il 21/04/2015 12:49, Stefano Stabellini ha scritto: On Mon, 20 Apr 2015, Fabio Fantoni wrote: I updated xen and qemu from xen 4.5.0 with its upstream qemu included to xen 4.5.1-pre with qemu upstream from stable-4.5 (changed Config.mk to use revision "master"). After few minutes I booted windows

Re: [Qemu-devel] [PATCH v12 4/9] hw/vfio/platform: add capability to start IRQ propagation

2015-04-21 Thread Eric Auger
Hi Alex, On 04/17/2015 09:41 PM, Alex Williamson wrote: > On Fri, 2015-04-17 at 17:31 +0200, Eric Auger wrote: >> Hi Alex, >> On 04/17/2015 12:04 AM, Alex Williamson wrote: >>> On Thu, 2015-03-19 at 17:16 +, Eric Auger wrote: Add a reset notify function that enables to start the propagatio

Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 12:33:36PM +0100, Peter Maydell wrote: > On 21 April 2015 at 11:09, Michael S. Tsirkin wrote: > > On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote: > >> A predefined scope in the ACPI specs is precede with a backslash. > >> > >> Signed-off-by: Gal Hammer > > > >

Re: [Qemu-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-04-21 Thread Stefano Stabellini
On Tue, 21 Apr 2015, Fabio Fantoni wrote: > Il 21/04/2015 12:49, Stefano Stabellini ha scritto: > > On Mon, 20 Apr 2015, Fabio Fantoni wrote: > > > I updated xen and qemu from xen 4.5.0 with its upstream qemu included to > > > xen > > > 4.5.1-pre with qemu upstream from stable-4.5 (changed Config.m

Re: [Qemu-devel] [PATCH v2 3/4] target-arm: kvm - support for single step

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > On 31 March 2015 at 16:40, Alex Bennée wrote: >> This adds support for single-step. There isn't much to do on the QEMU >> side as after we set-up the request for single step via the debug ioctl >> it is all handled within the kernel. >> >> Signed-off-by: Alex Bennée >>

Re: [Qemu-devel] [PATCH v2 3/4] target-arm: kvm - support for single step

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 13:56, Alex Bennée wrote: > > Peter Maydell writes: >>> switch (hsr_ec) { >>> +case HSR_EC_SOFT_STEP: >>> +if (cs->singlestep_enabled) { >>> +return true; >>> +} else { >>> +error_report("Came out of SINGLE STEP when not enabled

Re: [Qemu-devel] [RFC/PATCH] Bad volume scaling with Win7 guest, spice audio, and Qemu Intel HDA codec

2015-04-21 Thread Marc-André Lureau
Hi - Original Message - > I see a problem with input volume control on a Windows7 guest > using the qemu Intel HDA codec. In short, moving the volume slider for > the input volume from 0% to 1% under Windows results in > the "gain" values in the emulated HW to jump from 0 to 40 (out of 74)

Re: [Qemu-devel] [PATCH v2 4/4] target-arm: kvm - add support for HW assisted debug

2015-04-21 Thread Alex Bennée
Peter Maydell writes: > On 31 March 2015 at 16:40, Alex Bennée wrote: >> From: Alex Bennée >> >> This adds basic support for HW assisted debug. The ioctl interface to >> KVM allows us to pass an implementation defined number of break and >> watch point registers. When KVM_GUESTDBG_USE_HW_BP is

Re: [Qemu-devel] [PATCH] virtio_blk: comment fix

2015-04-21 Thread Stefan Hajnoczi
On Sun, Apr 12, 2015 at 05:55:17PM +0200, Michael S. Tsirkin wrote: > update virtio blk header from latest linux, include comment fixups. > > Signed-off-by: Michael S. Tsirkin > --- > include/standard-headers/linux/virtio_blk.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Tha

Re: [Qemu-devel] [PATCH] m25p80: add missing blk_attach_dev_nofail

2015-04-21 Thread Stefan Hajnoczi
On Tue, Apr 14, 2015 at 05:29:47PM +0200, Paolo Bonzini wrote: > Of the block devices that poked into -drive options via drive_get_next, > m25p80 was the only one who also did not attach itself to the BlockBackend. > > Since sd does it, and all other devices go through a "drive" property, > with t

Re: [Qemu-devel] [PATCH for-2.4] m25p80: fix s->blk usage before assignment

2015-04-21 Thread Stefan Hajnoczi
On Wed, Apr 15, 2015 at 10:43:44AM +0100, Stefan Hajnoczi wrote: > Delay the call to blk_blockalign() until s->blk has been assigned. > > This never caused a crash because blk_blockalign(NULL, size) defaults to > 4096 alignment but it's technically incorrect. > > Signed-off-by: Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH] block: document block-stream in qmp-commands.hx

2015-04-21 Thread Stefan Hajnoczi
On Wed, Apr 15, 2015 at 11:43:42AM +0100, Stefan Hajnoczi wrote: > The 'block-stream' QMP command is documented in block-core.json but not > qmp-commands.hx. Add a summary of the command to qmp-commands.hx > (similar to the documentation for 'block-commit'). > > Reported-by: Kashyap Chamarthy >

Re: [Qemu-devel] [PATCH v2 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 08:39, Alex Bennée wrote: > > Peter Maydell writes: > >> Make address_space_rw take transaction attributes, rather >> than always using the 'unspecified' attributes. >> >> Signed-off-by: Peter Maydell >> Reviewed-by: Paolo Bonzini >> Reviewed-by: Edgar E. Iglesias >> --- >>

Re: [Qemu-devel] [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-21 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: > The image field in BlockDeviceInfo is supposed to contain an ImageInfo > object. However that is being filled in by bdrv_query_info(), not by > bdrv_block_device_info(), which is where BlockDeviceInfo is actually > created. > > Anyo

Re: [Qemu-devel] [PATCH v2 10/14] target-arm: Honour NS bits in page tables

2015-04-21 Thread Peter Maydell
On 21 April 2015 at 10:24, Alex Bennée wrote: > > Peter Maydell writes: > >> Honour the NS bit in ARM page tables: >> * when adding entries to the TLB, include the Secure/NonSecure >>transaction attribute >> * set the NS bit in the PAR when doing ATS operations >> >> Note that we don't yet

Re: [Qemu-devel] kvm vs host (arm64)

2015-04-21 Thread Christopher Covington
Hi Mohan, On 04/21/2015 02:23 AM, Mohan G wrote: > comments inline > > > - Original Message - > From: Marc Zyngier > To: Mohan G ; "linux-arm-ker...@lists.infradead.org" > > Cc: > Sent: Monday, April 20, 2015 4:32 PM > Subject: Re: kvm vs host (arm64) > > Don't top post. This is ver

Re: [Qemu-devel] vhost/virtio migration planning

2015-04-21 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 02:03:59PM +0300, Catalin Vasile wrote: > I am working on a virtio-crypto with vhost backend. You didn't respond in the "[GSoC] project proposal" thread where I explained why vhost isn't appropriate for this device: My suggestion is to work on the gnutls driver. Then, i

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Leon Alrae
On 16/04/2015 15:22, Peter Maydell wrote: > On 15 April 2015 at 10:09, Liviu Ionescu wrote: >> we currently have two solutions: >> >> - multiple: --semihosting-config arg="..." >> - a single option, placed at the end, and followed by any number >> of arguments: --semihosting-cmdline $@ \n >> >>

Re: [Qemu-devel] [PATCH v2 00/14] Add memory attributes and use them in ARM

2015-04-21 Thread Peter Maydell
On 13 April 2015 at 14:21, Peter Maydell wrote: > I've included both the changes to the core memory system code > and the target-arm changes as a usage example, but the ARM stuff > is all at the end of the series, so if we want to split it and > take it via separate subtrees that's fine. > > There

Re: [Qemu-devel] vhost/virtio migration planning

2015-04-21 Thread Catalin Vasile
Sorry for not respoding there. When I started researching and working on this qemu-devel was the only mailing list where I actually got support (answers) for my questions. On Tue, Apr 21, 2015 at 4:33 PM, Stefan Hajnoczi wrote: > On Fri, Apr 17, 2015 at 02:03:59PM +0300, Catalin Vasile wrote: >

Re: [Qemu-devel] [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-21 Thread Kevin Wolf
Am 21.04.2015 um 15:28 hat Stefan Hajnoczi geschrieben: > On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: > > The image field in BlockDeviceInfo is supposed to contain an ImageInfo > > object. However that is being filled in by bdrv_query_info(), not by > > bdrv_block_device_info(),

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/3] Add bdrv_get_device_or_node_name()

2015-04-21 Thread Stefan Hajnoczi
On Wed, Apr 08, 2015 at 12:29:17PM +0300, Alberto Garcia wrote: > This series contains a couple of minor changes suggested by Markus in > the previous one. I removed the Reviewed-by line by Max in the > modified patch even if the changes are small, hope that's ok. > > v4: > - Fix documentation of

Re: [Qemu-devel] [PATCH] target-arm: rename c1_coproc to cpacr_el1

2015-04-21 Thread Peter Maydell
On 17 March 2015 at 16:23, Peter Maydell wrote: > On 17 March 2015 at 15:33, Sergey Fedorov wrote: >> Rename the field holding CPACR_EL1 system register state in AArch64 >> naming style. >> >> Signed-off-by: Sergey Fedorov > > Reviewed-by: Peter Maydell > > Mostly I've been renaming these only

Re: [Qemu-devel] [PATCH v2.5 00/10] block: incremental backup transactions

2015-04-21 Thread Kashyap Chamarthy
On Fri, Apr 17, 2015 at 09:01:10PM -0400, John Snow wrote: > I am not prepared to send a v3 on this, primarily because I am still > waffling on whether or not to do the code motion patch that is present in > patch #8 of v2 of this series. > > However, for the purposes of testing, reviewers may fin

Re: [Qemu-devel] [PATCH 1/3] target-arm: Add GIC phandle to VirtBoardInfo

2015-04-21 Thread Peter Maydell
On 8 April 2015 at 22:20, Christoffer Dall wrote: > Instead of passing the GIC phandle around between functions, add it to > the VirtBoardInfo just like we do for the clock_phandle. We are about > to add the v2m phandle as well, and it's easier not having to pass > around a bunch of phandles, ret

Re: [Qemu-devel] kvm guest-host separation

2015-04-21 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 08:31:47PM +0200, Andrei Bacs wrote: > I would like to implement some security checks in the qemu user process > that would monitor the disk I/O of a KVM guest. You probably need to avoid QEMU's zero-copy disk I/O, depending on the security checks you are performing. Other

[Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-21 Thread Alexander Graf
The AMD Opteron family has different xlevel levels depending on the generation. I looked up Gen1, Gen2 and Gen3 hardware and adapted the levels according to real silicon. The reason this came up is that there is a sanity check in KVM making sure that SVM is only used when xlevel is high enough. Us

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Luiz Capitulino
On Fri, 27 Mar 2015 17:19:30 +0100 Claudio Fontana wrote: > Just a respectful ping on this one.. > Luiz do you think you can integrate this into the monitor? Would be nice to get a Reviewed-by from someone and, I'm getting a build error: /home/lcapitulino/work/src/upstream/qmp-unstable/monitor.

Re: [Qemu-devel] [PATCH v2] qapi: Drop dead genlist parameter

2015-04-21 Thread Luiz Capitulino
On Fri, 10 Apr 2015 15:07:59 -0600 Eric Blake wrote: > Defaulting a parameter to True, then having all callers omit or > pass an explicit True for that parameter, is pointless. Looks > like it has been dead since introduction in commit 06d64c6, more > than 4 years ago. > > Signed-off-by: Eric Bl

Re: [Qemu-devel] [PATCH] qmp-commands: fix incorrect uses of ":O" specifier

2015-04-21 Thread Luiz Capitulino
On Wed, 15 Apr 2015 13:30:04 +0200 Paolo Bonzini wrote: > As far as the QMP parser is concerned, neither the 'O' nor the 'q' format > specifiers > put any constraint on the command. However, there are two differences: > > 1) from a documentation point of view 'O' says that this command takes >

Re: [Qemu-devel] [PATCH 2/3] arm_gicv2m: Add GICv2m widget to support MSIs

2015-04-21 Thread Peter Maydell
On 10 April 2015 at 10:58, Christoffer Dall wrote: > On Fri, Apr 10, 2015 at 11:16:57AM +0200, Eric Auger wrote: >> Hi Christoffer, >> On 04/08/2015 11:20 PM, Christoffer Dall wrote: >> > The ARM GICv2m widget is a little device that handle MSI interrupt >> > writes to a trigger register and ties

Re: [Qemu-devel] [PATCH] qmp: Give saner messages related to qmp_capabilities misuse

2015-04-21 Thread Luiz Capitulino
On Wed, 15 Apr 2015 09:19:23 -0600 Eric Blake wrote: > Pretending that QMP doesn't understand a command merely because > we are not in the right mode doesn't help first-time users figure > out what to do to correct things. Although the documentation for > QMP calls out capabilities negotiation,

Re: [Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-21 Thread Eduardo Habkost
On Tue, Apr 21, 2015 at 04:04:21PM +0200, Alexander Graf wrote: > The AMD Opteron family has different xlevel levels depending on the > generation. I looked up Gen1, Gen2 and Gen3 hardware and adapted the > levels according to real silicon. > > The reason this came up is that there is a sanity che

Re: [Qemu-devel] [PATCH] x86: Fix Opteron xlevels

2015-04-21 Thread Alexander Graf
On 04/21/2015 04:16 PM, Eduardo Habkost wrote: On Tue, Apr 21, 2015 at 04:04:21PM +0200, Alexander Graf wrote: The AMD Opteron family has different xlevel levels depending on the generation. I looked up Gen1, Gen2 and Gen3 hardware and adapted the levels according to real silicon. The reason th

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-21 Thread Laszlo Ersek
In general, commit messages for the series would be appreciated by the uninitiated :) Then, On 04/20/15 11:19, Gerd Hoffmann wrote: > route access to tseg into nowhere when enabled, > for both cpus and busmaster dma. > > Signed-off-by: Gerd Hoffmann > --- > hw/pci-host/q35.c | 57 > ++

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Claudio Fontana
Hello Luiz, On 21.04.2015 00:01, Luiz Capitulino wrote: > On Fri, 27 Mar 2015 17:19:30 +0100 > Claudio Fontana wrote: > >> Just a respectful ping on this one.. >> Luiz do you think you can integrate this into the monitor? > > Would be nice to get a Reviewed-by from someone and, gladly, I am de

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 16:25, Claudio Fontana wrote: > I seem not to get this warning with the compiler version I am currently using, > and after checking the code I could not find out why with some compilers > would emit such a warning. > > It is difficult for me to debug this issue since I do not get

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Laszlo Ersek
On 04/20/15 11:19, Gerd Hoffmann wrote: > add tseg window to smram region, so cpus can access it in smm mode. > > Signed-off-by: Gerd Hoffmann > --- > hw/pci-host/q35.c | 13 + > include/hw/pci-host/q35.h | 2 +- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff -

[Qemu-devel] [PATCH RFC 1/2] virtio-ccw: change realization sequence

2015-04-21 Thread Cornelia Huck
virtio-ccw has an odd sequence of realizing devices: first the device-specific relization (net, block, ...), then the generic realization. It feels less odd to have the generic realization callback trigger the device-specific realization instead (and this also matches what virtio-pci does). One th

[Qemu-devel] [PATCH RFC 2/2] virtio-ccw: implement ->device_plugged

2015-04-21 Thread Cornelia Huck
Let's move operations that are only valid after the backend has been realized to a ->device_plugged callback, just as virtio-pci does. Also reorder setting up the host feature bits to the sequence used by virtio-pci. While we're at it, also add a ->device_unplugged callback to stop ioeventfd, just

[Qemu-devel] [PATCH RFC 0/2] virtio-ccw realization/plugged handling

2015-04-21 Thread Cornelia Huck
Turns out that reworking the realization/plugging sequence for virtio-ccw to make it more similar to virtio-pci (as discussed in https://marc.info/?l=qemu-devel&m=142954827813046&w=2) was easier than expected. At least I have something that seems to look sane, produces working virtio-ccw devices an

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 16:30, Laszlo Ersek wrote: >> > -MemoryRegion tseg_blackhole; >> > +MemoryRegion tseg_blackhole, tseg_window; >> > PcPciInfo pci_info; >> > ram_addr_t below_4g_mem_size; >> > ram_addr_t above_4g_mem_size; >> > > Why is this necessary? If you disable the black

Re: [Qemu-devel] [PATCH 2/3] arm_gicv2m: Add GICv2m widget to support MSIs

2015-04-21 Thread Peter Maydell
On 8 April 2015 at 22:20, Christoffer Dall wrote: > The ARM GICv2m widget is a little device that handle MSI interrupt > "handles" > writes to a trigger register and ties them to a range of interrupt lines > wires to the GIC. It has a few status/id registers and the interrupt > wires, > and t

Re: [Qemu-devel] [PATCH 3/3] target-arm: Add the GICv2m to the virt board

2015-04-21 Thread Peter Maydell
On 8 April 2015 at 22:21, Christoffer Dall wrote: > Adding the GICv2m to the virt board should allow us to enable MSIs on > the generic PCI host controller, in theory. > So is this commit message just saying "I haven't tested this patchset" :-), or are we still missing some functionality to get

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 16:35, Luiz Capitulino wrote: > > gladly, I am definitely looking for Review, first I wanted to check if the > > idea itself was acceptable. > > I honestly don't have an opinion on this, which means I'm willing > to apply if there are no objections. > > On the other hand, isn't i

Re: [Qemu-devel] [PATCH v2.5 00/10] block: incremental backup transactions

2015-04-21 Thread Kashyap Chamarthy
On Tue, Apr 21, 2015 at 03:53:11PM +0200, Kashyap Chamarthy wrote: [. . .] > And, invoking `drive-backup` *without* pre-creating the target image > (i.e. 'incremental.o.img'): > > { 'execute': 'drive-backup', > 'arguments': { > 'device': 'ide0-0-0', Small typo (in this email,

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Laszlo Ersek
On 04/21/15 16:38, Paolo Bonzini wrote: > > > On 21/04/2015 16:30, Laszlo Ersek wrote: -MemoryRegion tseg_blackhole; +MemoryRegion tseg_blackhole, tseg_window; PcPciInfo pci_info; ram_addr_t below_4g_mem_size; ram_addr_t above_4g_mem_size; >> W

Re: [Qemu-devel] about [SeaBIOS PATCH] Try to hard-reboot on rerun of post even on emulators.

2015-04-21 Thread Kevin O'Connor
On Tue, Apr 21, 2015 at 10:37:49AM +0200, Laszlo Ersek wrote: > As to how you can fix > (which is the > motivation for this entire discussion): > > - You need to identify *what variable exactly* stores the list of > bootable devices. Is that

[Qemu-devel] [PATCH v2 0/2] target-mips: add Config5.FRE support

2015-04-21 Thread Leon Alrae
MIPS architectural feature allowing emulation of Status.FR=0 on a CPU with Status.FR hardwired to 1. v2: * move functions and drop prototypes (James) * fix declaration after code (James) Leon Alrae (2): target-mips: move group of functions above gen_load_fpr32() target-mips: add Config5.FRE s

[Qemu-devel] [PATCH v2 2/2] target-mips: add Config5.FRE support allowing Status.FR=0 emulation

2015-04-21 Thread Leon Alrae
This relatively small architectural feature adds the following: FIR.FREP: Read-only. If FREP=1, then Config5.FRE and Config5.UFE are available. Config5.FRE: When enabled all single-precision FP arithmetic instructions, LWC1/LWXC1/MTC1, SWC1/SWXC1/MFC1 cause a Reserved Instr

[Qemu-devel] [PATCH v2 1/2] target-mips: move group of functions above gen_load_fpr32()

2015-04-21 Thread Leon Alrae
Move the "Tests" group of functions so that gen_load_fpr32() and gen_store_fpr32() can use generate_exception(). Signed-off-by: Leon Alrae --- target-mips/translate.c | 118 1 file changed, 58 insertions(+), 60 deletions(-) diff --git a/target-mi

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 17:04, Gerd Hoffmann wrote: > Hmm. I think if we merge all the smm / smram / tseg patches in one go > this should work. Without patches reading the ESMRAMC register returns > zero. With the patches the three cache-disable bits are hardcoded to > '1'. This should work for detecti

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
> > +static const MemoryRegionOps tseg_blackhole_ops = { > > +.read = tseg_blackhole_read, > > +.write = tseg_blackhole_write, > > +.endianness = DEVICE_NATIVE_ENDIAN, > > +.valid.min_access_size = 1, > > +.valid.max_access_size = 4, > > +.impl.min_access_size = 4, > > +

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-04-21 Thread Claudio Fontana
On 21.04.2015 16:28, Paolo Bonzini wrote: > > > On 21/04/2015 16:25, Claudio Fontana wrote: >> I seem not to get this warning with the compiler version I am currently >> using, >> and after checking the code I could not find out why with some compilers >> would emit such a warning. >> >> It is

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
Hi, > > I'm thinking, the last 1 / 2 / 8 megabytes should behave as RAM in all > > of the following cases: > > - no SMRAM programmed (tseg size = 0) > > - SMRAM programmed (tseg size > 0), and it is open > > - SMRAM programmed (tseg size > 0) and closed, but CPU in SMM > > Correct. Almost. I

[Qemu-devel] [PATCH v2] hw/ppc/spapr_iommu: Fix the check for invalid upper bits in liobn

2015-04-21 Thread Thomas Huth
The check "liobn & 0xULL" in spapr_tce_find_by_liobn() is completely useless since liobn is only declared as an uint32_t parameter. Fix this by using target_ulong instead (this is what most of the callers of this function are using, too). Signed-off-by: Thomas Huth --- v2: - Do no

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
> > tseg_blackhole is added on top of address_space_memory to hide TSEG; > > tseg_window is included in /machine/smram and TCG adds it to the private > > per-CPU address space when it enters system management mode. > > Hm, I must have missed this (or not seen it at all) -- should I have > noticed

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-21 Thread Liviu Ionescu
> On 21 Apr 2015, at 16:34, Leon Alrae wrote: > > (PS: --semihosting-cmdline $@ is probably the most convenient from GUI / > wrapper point of view, but I don't have an opinion whether this is > enough to justify adding a top level QEMU command line option with such > a unique syntax) nope, the

Re: [Qemu-devel] [PATCH 5/6] [wip] tseg, part1, not (yet) tested

2015-04-21 Thread Gerd Hoffmann
On Di, 2015-04-21 at 17:08 +0200, Paolo Bonzini wrote: > > On 21/04/2015 17:04, Gerd Hoffmann wrote: > > Hmm. I think if we merge all the smm / smram / tseg patches in one go > > this should work. Without patches reading the ESMRAMC register returns > > zero. With the patches the three cache-di

Re: [Qemu-devel] [PATCH 6/6] [wip] tseg, part2, not (yet) tested

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 17:05, Laszlo Ersek wrote: > > Yet another question -- as far as I understand, I should have enough > info (with my pending questions of course) for EFI_SMM_ACCESS2_PROTOCOL. > I've now reviewed EFI_SMM_CONTROL2_PROTOCOL too, and AFAICS the only > thing I need to know for it is "ho

[Qemu-devel] [PATCH] qcow2: do lazy allocation of the L2 cache

2015-04-21 Thread Alberto Garcia
Large disk images need large L2 caches in order to maximize their I/O performance. However setting a correct size for the cache is not necessarily easy since apart from the image size, it also depends on other factors like its usage patterns or whether it's part of a backing chain. In order to be

  1   2   >