Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-17 Thread Peter Lieven
Am 16.04.2015 um 15:17 schrieb Paolo Bonzini: > > On 16/04/2015 15:02, Peter Lieven wrote: >>> Also, I think it is iscsi_co_generic_cb that should set >>> force_next_flush, so that it is only set on failure. Not really for the >>> optimization value, but because it's clearer. >> I don't get what y

Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

2015-04-17 Thread Peter Lieven
Am 16.04.2015 um 15:20 schrieb Paolo Bonzini: > > On 16/04/2015 14:58, Peter Lieven wrote: >>> On 16/04/2015 14:18, Peter Lieven wrote: We need this to support SCSI_STATUS_TASK_SET_FULL. >>> Any reason apart from the missing constant? >> No, but I wanted to avoid starting checking for constant

[Qemu-devel] [PATCH] target-ppc: don't invalidate msr MSR_HVB bit in cpu_post_load

2015-04-17 Thread Mark Cave-Ayland
The invalidation code introduced in commit 2360b works by inverting most bits of env->msr to ensure that hreg_store_msr() will forcibly update the CPU env state to reflect the new msr value post-migration. Unfortunately hreg_store_msr() is called with alter_hv set to 0 which preserves the MSR_HVB s

[Qemu-devel] [PATCH 4/6] watchdog: Add migration support to diag288 watchdog device

2015-04-17 Thread Cornelia Huck
From: Xu Wang Add vmstate structure to keep state and data during migration. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/watchdog/wdt_diag288.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/watchdog/wdt_diag288.c b/hw/watch

[Qemu-devel] [PATCH 3/6] s390/kvm: diag288 instruction interception and handling

2015-04-17 Thread Cornelia Huck
From: Xu Wang Intercept the diag288 requests from kvm guests, and hand the requested command to the diag288 watchdog device for further handling. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- target-s390x/cpu.h | 1 + target-s390x/kvm.c

[Qemu-devel] [PATCH 5/6] nmi: Implement inject_nmi() for non-monitor context use

2015-04-17 Thread Cornelia Huck
From: Xu Wang Let's introduce a general "inject_nmi()" function that doesn't rely on the cpu index of the monitor, but uses cpu index 0 as default (except for x86). This function can then later be used from a non-monitor context. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off

[Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable has_dynamic_sysbus

2015-04-17 Thread Cornelia Huck
From: Xu Wang We have to enable this flag to support dynamically adding devices to the sysbus. This change is needed for the the upcoming diag288 watchdog. Signed-off-by: Xu Wang Acked-by: Cornelia Huck Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw

[Qemu-devel] [PATCH 0/6] s390x: support diag288 watchdog

2015-04-17 Thread Cornelia Huck
The following series of patches enables a watchdog for s390x that is based upon a hypercall (diagnose 0x288). The same interface is already used for s390 LPAR, so it makes sense to provide it under qemu as well. Patches to enable Linux guests to utilize the watchdog have made their way upstream du

[Qemu-devel] [PATCH 6/6] watchdog: Add new Virtual Watchdog action INJECT-NMI

2015-04-17 Thread Cornelia Huck
From: Mao Chuan Li This patch allows QEMU to inject a NMI into a guest when the watchdog expires. Signed-off-by: Mao Chuan Li Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/watchdog/watchdog.c | 10 ++ qapi-schema.json | 6 +- 2 files changed, 15 insert

[Qemu-devel] [PATCH 2/6] watchdog: Add watchdog device diag288 to the sysbus

2015-04-17 Thread Cornelia Huck
From: Xu Wang A new sysbus device for diag288 watchdog, it monitors the kvm guest status, and take corresponding actions when it detects that the guest is not responding. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- default-configs/s390x-softmmu.mak

Re: [Qemu-devel] qcow2 problem: while a qcow2 image run out of disk space the guest paused.

2015-04-17 Thread Kevin Wolf
Am 17.04.2015 um 06:30 hat Alexandre DERUMIER geschrieben: > Hi, > > Isn't it related to drive options ? > > > " > werror=action,rerror=action > > Specify which action to take on write and read errors. Valid actions are: > “ignore” (ignore the error and try to continue), “stop” (pause QEMU),

[Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET"

2015-04-17 Thread Fam Zheng
Currently, virtio code chooses to kill QEMU if the guest passes any invalid data with vring. That has drawbacks such as losing unsaved data (e.g. when guest user is writing a very long email), or possible denial of service in a nested vm use case where virtio device is passed through. virtio-1 has

[Qemu-devel] [PATCH 01/18] virtio: Return error from virtqueue_map_sg

2015-04-17 Thread Fam Zheng
virtqueue_map_sg calls error_report() and exit() when parameter is invalid, or when mapping failed. Lift the error check to caller, by adding errp. Also, when one of the mapping failed, previous maps are reverted for cleanness. All existing callers pass in error_abort for now. Signed-off-by: Fam

[Qemu-devel] [PATCH 02/18] virtio: Return error from virtqueue_num_heads

2015-04-17 Thread Fam Zheng
If vring has invalid data, virtqueue_num_heads used to print an error and abort(). Change to returning -EINVAL with error info. For now, pass in error_abort from two existing callers. Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

[Qemu-devel] [PATCH 11/18] virtio: Add "needs_reset" flag to virtio device

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 18 ++ include/hw/virtio/virtio.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 6dfa181..7ff0dc4 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -623,6 +6

[Qemu-devel] [PATCH 06/18] virtio: Return error from virtqueue_pop

2015-04-17 Thread Fam Zheng
When getting invalid data from vring, virtqueue_pop used to print an error and exit. Add an errp parameter so it can return the error to callers. Signed-off-by: Fam Zheng --- hw/9pfs/virtio-9p.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 10 +++ hw/n

[Qemu-devel] [PATCH 03/18] virtio: Return error from virtqueue_get_head

2015-04-17 Thread Fam Zheng
Return type is changed to int. When data is invalid, return -EINVAL with an error. Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index b02c7a1..a525f8e 100644 --- a/hw/vir

[Qemu-devel] [PATCH 12/18] virtio: Return -EINVAL if the vdev needs reset in virtqueue_pop

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 7ff0dc4..87f8c36 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -505,6 +505,9 @@ int virtqueue_pop(VirtQueue *vq, VirtQueueElement *ele

[Qemu-devel] [PATCH 10/18] virtio: Add macro for VIRTIO_CONFIG_S_NEEDS_RESET

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/standard-headers/linux/virtio_config.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/standard-headers/linux/virtio_config.h b/include/standard-headers/linux/virtio_config.h index bcc445b..34b8155 100644 --- a/include/standard-headers/linux/vir

[Qemu-devel] [PATCH 05/18] virtio: Return error from virtqueue_get_avail_bytes

2015-04-17 Thread Fam Zheng
Add errp and pass in error_abort for now. Later, we can add error handling code in callers. Signed-off-by: Fam Zheng --- hw/char/virtio-serial-bus.c | 2 +- hw/virtio/virtio-rng.c | 2 +- hw/virtio/virtio.c | 39 +++ include/hw/virtio/virtio.h

[Qemu-devel] [PATCH 14/18] qtest: Add "QTEST_FILTER" to filter test cases

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index 55aa745..1c1294f 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -411,12 +411,16 @@ GCOV_OPTIONS = -n $(if $(V),-f,) # gtester tests, p

[Qemu-devel] [PATCH 13/18] virtio-blk: Graceful error handling of virtqueue_pop

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 9 ++- hw/block/virtio-blk.c | 56 - include/hw/virtio/virtio-blk.h | 3 ++- 3 files changed, 54 insertions(+), 14 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/h

[Qemu-devel] [PATCH 07/18] virtio: Return error from virtqueue_avail_bytes

2015-04-17 Thread Fam Zheng
The only caller is virtio-net, which now passes in error_abort. Signed-off-by: Fam Zheng --- hw/net/virtio-net.c| 4 ++-- hw/virtio/virtio.c | 9 +++-- include/hw/virtio/virtio.h | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/

[Qemu-devel] [PATCH 16/18] libqos: Add qvirtio_needs_reset

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/libqos/virtio.c | 5 + tests/libqos/virtio.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c index 3205b88..cd45b5c 100644 --- a/tests/libqos/virtio.c +++ b/tests/libqos/virtio.c @@ -46,6 +46,11 @@ void qv

[Qemu-devel] [PATCH 09/18] virtio: Return error from virtio_del_queue

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/net/virtio-net.c| 2 +- hw/virtio/virtio.c | 5 +++-- include/hw/virtio/virtio.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 74205b4..c727277 100644 --- a/hw/net/virtio-net.c

[Qemu-devel] [PATCH 15/18] qtest: virtio-blk: Extract "setup" for future reuse

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/virtio-blk-test.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 4078321..866415a 100644 --- a/tests/virtio-blk-test.c +++ b/tests/virtio-blk-test.c @@ -168,

[Qemu-devel] [PATCH 17/18] qtest: Add test case for "needs reset" of virtio-blk

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/virtio-blk-test.c | 154 1 file changed, 154 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 866415a..c5a599d 100644 --- a/tests/virtio-blk-test.c +++ b/tests/virtio-blk-test.c

[Qemu-devel] [PATCH 18/18] qtest: virtio-blk: Suppress virtio error messages in "make check"

2015-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/virtio-blk-test.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index c5a599d..17eb33d 100644 --- a/tests/virtio-blk-test.c +++ b/tests/virtio-blk-test.c @@ -76,7 +76,7 @

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-17 Thread Kevin Wolf
Am 16.04.2015 um 14:34 hat Alberto Garcia geschrieben: > On Thu 16 Apr 2015 02:27:39 PM CEST, Eric Blake wrote: > > +orig_bs_flags = bdrv_get_flags(bs); > +if (!(orig_bs_flags & BDRV_O_RDWR)) { > >>> > >>> I feel like we don't want to do this if we're not streaming to an > >>> in

[Qemu-devel] [PATCH 08/18] virtio: Return error from virtio_add_queue

2015-04-17 Thread Fam Zheng
All callers pass in error_abort for now. Error handling will be added in separate patches later. Signed-off-by: Fam Zheng --- hw/9pfs/virtio-9p-device.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/char/virtio-serial-bus.c | 14 -- hw/net/virtio-net.c | 24 ++

[Qemu-devel] [PATCH 04/18] virtio: Return error from virtqueue_next_desc

2015-04-17 Thread Fam Zheng
Two callers pass error_abort now, which can be changed to check return value and pass the error on. Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index a525f

[Qemu-devel] [RFC 2/7] qemu: add guest init event callback to do the initialize work for guest

2015-04-17 Thread Chen Fan
Signed-off-by: Chen Fan --- src/qemu/qemu_domain.h | 7 +++ src/qemu/qemu_driver.c | 32 src/qemu/qemu_process.c | 22 ++ 3 files changed, 61 insertions(+) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 3225abb..19f4

[Qemu-devel] [RFC 1/7] qemu-agent: add agent init callback when detecting guest setup

2015-04-17 Thread Chen Fan
sometimes, we want to do some initialize work in guest when guest startup, but currently, qemu-agent doesn't support that. so here we add an init callback, when guest startup, notify libvirt it has been up, then libvirt can do some work for guest. Signed-off-by: Chen Fan --- src/qemu/qemu_agent.

[Qemu-devel] [RFC 0/7] Live Migration with Pass-through Devices proposal

2015-04-17 Thread Chen Fan
backgrond: Live migration is one of the most important features of virtualization technology. With regard to recent virtualization techniques, performance of network I/O is critical. Current network I/O virtualization (e.g. Para-virtualized I/O, VMDq) has a significant performance gap with nativ

[Qemu-devel] [RFC 5/7] hostdev: add parse ip and route for bond configure

2015-04-17 Thread Chen Fan
bond device always need to configure the ip address and route way address. so here we add the interface. xml like: Signed-off-by: Chen Fan --- docs/schemas/domaincommon.rng | 21 +++ src/conf/domain_conf.c| 87 -

[Qemu-devel] [RFC 0/3] add support migration with passthrough device

2015-04-17 Thread Chen Fan
the patches is for libvirt to support migration with passthrough device using existing feacture. Chen Fan (3): qemu-agent: add guest-network-set-interface command qemu-agent: add guest-network-delete-interface command qemu-agent: add notify for qemu-ga boot configure| 16 +++

[Qemu-devel] [RFC 4/7] qemu-agent: add qemuAgentCreateBond interface

2015-04-17 Thread Chen Fan
via initialize callback to create bond device. Signed-off-by: Chen Fan --- src/qemu/qemu_agent.c | 118 src/qemu/qemu_agent.h | 10 src/qemu/qemu_domain.c | 70 src/qemu/qemu_domain.h | 7 +++ src/qemu/q

[Qemu-devel] [RFC 3/7] hostdev: add a 'bond' type element in element

2015-04-17 Thread Chen Fan
this 'bond' element is to create bond device when guest startup, the xml like: Signed-off-by: Chen Fan --- docs/schemas/basictypes.rng | 6 ++ docs/schemas/domaincommon.rng | 16 ++ src/conf/domain_conf.c| 131 ++

[Qemu-devel] [RFC 3/3] qemu-agent: add notify for qemu-ga boot

2015-04-17 Thread Chen Fan
Signed-off-by: Chen Fan --- qga/main.c | 13 + 1 file changed, 13 insertions(+) diff --git a/qga/main.c b/qga/main.c index 9939a2b..f011ce0 100644 --- a/qga/main.c +++ b/qga/main.c @@ -1170,6 +1170,19 @@ int main(int argc, char **argv) g_critical("failed to initialize guest

[Qemu-devel] [RFC 6/7] migrate: hot remove hostdev at perform phase for bond device

2015-04-17 Thread Chen Fan
For bond device, we can support the migrate, we can simple to hot remove the device from source side, and after migration end, we hot add the new device at destination side. Signed-off-by: Chen Fan --- src/qemu/qemu_driver.c| 57 +++ src/qemu/qemu_

[Qemu-devel] [RFC 7/7] migrate: add hostdev migrate status to support hostdev migration

2015-04-17 Thread Chen Fan
we add a migrate status for hostdev to specify the device don't need to initialze when VM startup, after migration end, we add the migrate status hostdev, so can support hostdev migration. Signed-off-by: Chen Fan --- src/conf/domain_conf.c| 3 ++ src/conf/domain_conf.h| 7 src/qem

[Qemu-devel] [PATCH 0/2] Generic PCIe host bridge legacy interrupts routing support

2015-04-17 Thread Pranavkumar Sawargaonkar
This patch adds: - Function to determine an irq number from qemu_irq. - Function to determine and route legacy interrupts to a VM. Pranavkumar Sawargaonkar (2): hw: irq: Add API to get irq number from qemu_irq pci: GPEX: Add support to route legacy interrupts hw/core/irq.c | 9 +++

[Qemu-devel] [RFC 1/3] qemu-agent: add guest-network-set-interface command

2015-04-17 Thread Chen Fan
Nowadays, qemu has supported physical NIC hotplug for high network throughput. but it's in conflict with live migration feature, to keep network connectivity, we could to create bond device interface which provides a mechanism for enslaving multiple network interfaces into a single "bond" interface

[Qemu-devel] [PATCH 1/2] hw: irq: Add API to get irq number from qemu_irq

2015-04-17 Thread Pranavkumar Sawargaonkar
This patch adds a new function to get irq number from qemu irq. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Tushar Jagad --- hw/core/irq.c| 9 + include/hw/irq.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/core/irq.c b/hw/core/irq.c index 8a62a36..0eeffdf 10

[Qemu-devel] [RFC 2/3] qemu-agent: add guest-network-delete-interface command

2015-04-17 Thread Chen Fan
Add a corresponding command to guest-network-set-interface. Signed-off-by: Chen Fan --- qga/commands-posix.c | 51 +++ qga/commands-win32.c | 6 ++ qga/qapi-schema.json | 11 +++ 3 files changed, 68 insertions(+) diff --git a/qga/comm

[Qemu-devel] [PATCH 2/2] pci: GPEX: Add support to route legacy interrupts

2015-04-17 Thread Pranavkumar Sawargaonkar
This patch adds routine to route legacy interrupts to VM. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Tushar Jagad --- hw/pci-host/gpex.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/pci-host/gpex.c b/hw/pci-host/gpex.c index 9d8fb5a..35842e4 100644 --- a/hw/p

Re: [Qemu-devel] ARM: PCI devices emulation broken with KVM due to cache issue

2015-04-17 Thread Christoffer Dall
On Thu, Apr 16, 2015 at 06:02:27PM +0200, Paolo Bonzini wrote: > > > On 16/04/2015 17:54, Jérémy Fanguède wrote: > > The guest kernel driver of the lsi device fails to enable it correctly > > with a cache error: > > [...] > > sym53c8xx :00:01.0: enabling device (0100 -> 0103) > > sym0: <895a>

Re: [Qemu-devel] [PATCH] target-ppc: don't invalidate msr MSR_HVB bit in cpu_post_load

2015-04-17 Thread Alexander Graf
> Am 17.04.2015 um 09:16 schrieb Mark Cave-Ayland > : > > The invalidation code introduced in commit 2360b works by inverting most bits > of env->msr to ensure that hreg_store_msr() will forcibly update the CPU env > state to reflect the new msr value post-migration. Unfortunately > hreg_store_

[Qemu-devel] [PULL 0/1 for-2.3] fulong2e bugfix

2015-04-17 Thread Leon Alrae
available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20150417 for you to fetch changes up to 04327c41952c75fb4485933b9f51d9f2edea23a9: mips: fix broken fulong2e machine (2015-04-17 09:40:00 +0100) MIPS

[Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine

2015-04-17 Thread Leon Alrae
After commit 5312bd8 the bonito_readl() and bonito_writel() have been accessing incorrect addresses. Consequently QEMU is crashing when trying to boot Linux kernel on fulong2e machine. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Signed-off-by: Leon Alrae --- hw/pci-host/bonito.c | 4

Re: [Qemu-devel] [PATCH 0/2] Generic PCIe host bridge legacy interrupts routing support

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 09:55, Pranavkumar Sawargaonkar wrote: > This patch adds: > - Function to determine an irq number from qemu_irq. > - Function to determine and route legacy interrupts to a VM. Can you describe in more detail what this patch series is supposed to do, please? Interrupt routing a

Re: [Qemu-devel] [PATCH 0/2] Generic PCIe host bridge legacy interrupts routing support

2015-04-17 Thread Pranavkumar Sawargaonkar
Hi PMM, On 17 April 2015 at 15:23, Peter Maydell wrote: > On 17 April 2015 at 09:55, Pranavkumar Sawargaonkar > wrote: >> This patch adds: >> - Function to determine an irq number from qemu_irq. >> - Function to determine and route legacy interrupts to a VM. > > Can you describe in more detail w

Re: [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 10:46, Leon Alrae wrote: > After commit 5312bd8 the bonito_readl() and bonito_writel() have been > accessing incorrect addresses. Consequently QEMU is crashing when trying > to boot Linux kernel on fulong2e machine. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine

2015-04-17 Thread Leon Alrae
On 17/04/2015 11:42, Peter Maydell wrote: > On 17 April 2015 at 10:46, Leon Alrae wrote: >> After commit 5312bd8 the bonito_readl() and bonito_writel() have been >> accessing incorrect addresses. Consequently QEMU is crashing when trying >> to boot Linux kernel on fulong2e machine. >> >> Cc: qemu-

Re: [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 11:49, Leon Alrae wrote: > On 17/04/2015 11:42, Peter Maydell wrote: >> On 17 April 2015 at 10:46, Leon Alrae wrote: >>> After commit 5312bd8 the bonito_readl() and bonito_writel() have been >>> accessing incorrect addresses. Consequently QEMU is crashing when trying >>> to bo

[Qemu-devel] vhost/virtio migration planning

2015-04-17 Thread Catalin Vasile
I am working on a virtio-crypto with vhost backend. This functionality should expose a virtual cryptographic device to the guest which would send crypto jobs to the host. One problem I am facing is where to store session data (such as keys, IVs, etc.). For performance improvements, I would be ideal

Re: [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine

2015-04-17 Thread Leon Alrae
On 17/04/2015 11:58, Peter Maydell wrote: > On 17 April 2015 at 11:49, Leon Alrae wrote: >> On 17/04/2015 11:42, Peter Maydell wrote: >>> On 17 April 2015 at 10:46, Leon Alrae wrote: After commit 5312bd8 the bonito_readl() and bonito_writel() have been accessing incorrect addresses. Con

Re: [Qemu-devel] [PATCH v6 07/16] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue

2015-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2015 12:48:31 +0800 Jason Wang wrote: > There's no need to use vector 0 for invalid virtqueue. So this patch s/There's no need/It's a bad idea/ > changes to use VIRTIO_NO_VECTOR instead. s/use/using/ > > Cc: Michael S. Tsirkin > Cc: Cornelia Huck > CC: Christian Borntraeger

[Qemu-devel] [PULL v2 0/1 for-2.3] fulong2e bugfix

2015-04-17 Thread Leon Alrae
Update version for v2.3.0-rc3 release (2015-04-13 17:35:44 +0100) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20150417-2 for you to fetch changes up to 0ca4f94195cce77b624edc6d9abcf14a3bf01f06: mips: fix broken fulong2e machine (2015-04-17 12:1

[Qemu-devel] [PULL v2 1/1] mips: fix broken fulong2e machine

2015-04-17 Thread Leon Alrae
From: Paolo Bonzini After commit 5312bd8 the bonito_readl() and bonito_writel() have been accessing incorrect addresses. Consequently QEMU is crashing when trying to boot Linux kernel on fulong2e machine. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Signed-off-by: Leon Alrae --- hw

Re: [Qemu-devel] [PATCH] target-ppc: don't invalidate msr MSR_HVB bit in cpu_post_load

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 10:44, Alexander Graf wrote: > > >> Am 17.04.2015 um 09:16 schrieb Mark Cave-Ayland >> : >> >> The invalidation code introduced in commit 2360b works by inverting most bits >> of env->msr to ensure that hreg_store_msr() will forcibly update the CPU env >> state to reflect the

Re: [Qemu-devel] [PATCH v6 08/16] virtio: introduce bus specific queue limit

2015-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2015 12:48:32 +0800 Jason Wang wrote: > This patch introduces a bus specific queue limitation. It will be > useful for increasing the limit for one of the bus without disturbing > other buses. > > Cc: Michael S. Tsirkin > Cc: Alexander Graf > Cc: Richard Henderson > Cc: Corneli

Re: [Qemu-devel] [PATCH v6 09/16] virtio-ccw: introduce ccw specific queue limit

2015-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2015 12:48:33 +0800 Jason Wang wrote: > Instead of depending on marco, using a bus specific limit. Also make > it clear that the number of gsis per I/O adapter is not directly > depending on the number of virtio queues, but rather the other way > around. > > Cc: Alexander Graf >

Re: [Qemu-devel] [PATCH v6 10/16] virtio-s390: switch to bus specific queue limit

2015-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2015 12:48:34 +0800 Jason Wang wrote: > Instead of depending on marco, switch to use a bus specific queue s/marco/macro/ > limit. > > Cc: Alexander Graf > Cc: Richard Henderson > Cc: Christian Borntraeger > Cc: Cornelia Huck > Signed-off-by: Jason Wang > --- > hw/s390x/s39

[Qemu-devel] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-17 Thread Alberto Garcia
The image field in BlockDeviceInfo is supposed to contain an ImageInfo object. However that is being filled in by bdrv_query_info(), not by bdrv_block_device_info(), which is where BlockDeviceInfo is actually created. Anyone calling bdrv_block_device_info() directly will get a null image field. As

Re: [Qemu-devel] [PULL for-2.3 0/1] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-04-17 Thread Peter Maydell
On 14 April 2015 at 12:34, Peter Maydell wrote: > On 14 April 2015 at 12:27, Gerd Hoffmann wrote: >> Hi, >> >> Damn, wanted to sent this out last week, then forgot, so it missed -rc3. >> But it is a documentation-only change, so it should still be fine for >> 2.3, right? > > My inclination is t

Re: [Qemu-devel] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-17 Thread Alberto Garcia
On Fri 17 Apr 2015 01:52:43 PM CEST, Alberto Garcia wrote: > Anyone calling bdrv_block_device_info() directly will get a null image > field. As a consequence of this, the HMP command 'info block -n -v' > crashes QEMU. > > This patch moves the code that fills in that field from > bdrv_query_info()

Re: [Qemu-devel] [PATCH 6/6] watchdog: Add new Virtual Watchdog action INJECT-NMI

2015-04-17 Thread Eric Blake
On 04/17/2015 01:52 AM, Cornelia Huck wrote: > From: Mao Chuan Li > > This patch allows QEMU to inject a NMI into a guest when the > watchdog expires. > > Signed-off-by: Mao Chuan Li > Reviewed-by: David Hildenbrand > Signed-off-by: Cornelia Huck > --- > hw/watchdog/watchdog.c | 10 +

[Qemu-devel] [PATCH for-2.3] hmp: fix crash in 'info block -n -v'

2015-04-17 Thread Alberto Garcia
The image field in BlockDeviceInfo should never be null, however bdrv_block_device_info() is not filling it in. This makes the 'info block -n -v' command crash QEMU. The proper solution is probably to move the relevant code from bdrv_query_info() to bdrv_block_device_info(), but since we're too c

Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-17 Thread Max Reitz
On 16.04.2015 16:30, Alberto Garcia wrote: On Wed 15 Apr 2015 06:09:18 PM CEST, Max Reitz wrote: +orig_bs_flags = bdrv_get_flags(bs); +if (!(orig_bs_flags & BDRV_O_RDWR)) { I feel like we don't want to do this if we're not streaming to an intermediate layer but to the top layer (becau

[Qemu-devel] register_savevm()

2015-04-17 Thread Catalin Vasile
When are save() and load() handlers actually used? When are they trying to save and restore state?

[Qemu-devel] [PATCH 1/4] hw/s390x/virtio-ccw: Add virtio_ccw_device_plugged for virtio-ccw

2015-04-17 Thread Shannon Zhao
Add virtio_ccw_device_plugged, it can be used to get backend's features. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/s390x/virtio-ccw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 130535c..30ca377 100644

[Qemu-devel] [PATCH RFC 0/3] Checkpoint-assisted migration proposal

2015-04-17 Thread Bohdan Trach
From: Bohdan Trach This patchset contains a checkpoint-assisted migration feature as proposed earlier on this list [1]. It allows reusing existing memory snapshots of guests to speed up migration of VMs between physical hosts. [1] https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg01555.ht

[Qemu-devel] [PATCH RFC 2/3] memory: implement checkpoint handling

2015-04-17 Thread Bohdan Trach
From: Bohdan Trach This commit adds functions, which are used to work with checkpoint files. A new command-line option `-checkpoint` is added, which is used to specify the checkpoint file. Currently, MD5 function from OpenSSL is used to checkpoint memory. Signed-off-by: Bohdan Trach --- arch_i

[Qemu-devel] [PATCH 2/4] hw/s390x/s390-virtio-bus: Add virtio_s390_device_plugged for s390-virtio

2015-04-17 Thread Shannon Zhao
Add virtio_s390_device_plugged, it can be used to get backend's features. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/s390x/s390-virtio-bus.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c index 047c963.

[Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing

2015-04-17 Thread Bohdan Trach
From: Bohdan Trach dump-pc-mem command is added for checkpointing guest memory to file. Only system RAM region is saved. This checkpoint is later used to recover unchanged pages. Signed-off-by: Bohdan Trach --- arch_init.c | 19 +++ hmp-commands.hx | 16

[Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-17 Thread Shannon Zhao
The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the performance is low. The virtio-*-pci, virtio-*-s390, and virtio-*-ccw already have the ability to forward property accesses to the backend child, by calling *_virtio_*_instance_

[Qemu-devel] [PATCH 3/4] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-17 Thread Shannon Zhao
Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. The transports just sync the host features from backend. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/net/virtio-net.c| 4 hw/s390x/s390-virtio-bus.c | 1 - hw/s390x/virtio-ccw.c | 1 - hw

[Qemu-devel] [PATCH RFC 3/3] migration: use checkpoint during migration

2015-04-17 Thread Bohdan Trach
From: Bohdan Trach Extend memory page saving and loading functions to utilize information available in checkpoints to avoid sending full pages over the network. Signed-off-by: Bohdan Trach --- arch_init.c | 167 1 file changed, 158 i

[Qemu-devel] [PATCH 4/4] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi

2015-04-17 Thread Shannon Zhao
Move DEFINE_VIRTIO_SCSI_FEATURES to the backend virtio-scsi. The transports just sync the host features from backend. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/s390x/s390-virtio-bus.c | 1 - hw/s390x/virtio-ccw.c | 1 - hw/scsi/virtio-scsi.c | 5 +++

Re: [Qemu-devel] [PATCH v5 10/21] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2015-04-17 Thread Max Reitz
On 09.04.2015 00:19, John Snow wrote: For "dirty-bitmap" sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of "top" sync mode. Signed-off-by: Fam Zheng Signed

Re: [Qemu-devel] [PATCH v5 15/21] block: Resize bitmaps on bdrv_truncate

2015-04-17 Thread Max Reitz
On 09.04.2015 00:19, John Snow wrote: Signed-off-by: John Snow --- block.c| 18 ++ include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 48 3 files changed, 76 insertions(+) diff --git a/block.c b/

Re: [Qemu-devel] [PULL v2 0/1 for-2.3] fulong2e bugfix

2015-04-17 Thread Peter Maydell
; > Cc: Peter Maydell > > The following changes since commit b8df9208f357d2b36e1b19634aea973618dc7ba8: > > Update version for v2.3.0-rc3 release (2015-04-13 17:35:44 +0100) > > are available in the git repository at: > > git://github.com/lalr

Re: [Qemu-devel] [PATCH v5 18/21] iotests: add QMP event waiting queue

2015-04-17 Thread Max Reitz
On 09.04.2015 00:20, John Snow wrote: A filter is added to allow callers to request very specific events to be pulled from the event queue, while leaving undesired events still in the stream. This allows to poll for completion data for multiple asynchronous events in any arbitrary order. A new

Re: [Qemu-devel] register_savevm()

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 14:03, Catalin Vasile wrote: > When are save() and load() handlers actually used? > When are they trying to save and restore state? These are used for: * live migration * VM state save/load (eg via monitor 'savevm' and 'loadvm' commands or command line -loadvm option). Note

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2015 20:13:42 +0800 Shannon Zhao wrote: [Some questions may be silly, but I'm not familiar with the virtio-mmio code] > The reason to do this is that the virtio-net-device can't expose host > features to guest while using virtio-mmio. So the performance is low. So how does virtio

Re: [Qemu-devel] [PATCH 1/4] hw/s390x/virtio-ccw: Add virtio_ccw_device_plugged for virtio-ccw

2015-04-17 Thread Cornelia Huck
On Fri, 17 Apr 2015 20:13:43 +0800 Shannon Zhao wrote: > Add virtio_ccw_device_plugged, it can be used to get backend's features. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/s390x/virtio-ccw.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/

Re: [Qemu-devel] ARM: PCI devices emulation broken with KVM due to cache issue

2015-04-17 Thread Jérémy Fanguède
On Fri, Apr 17, 2015 at 11:29 AM, Christoffer Dall wrote: > On Thu, Apr 16, 2015 at 06:02:27PM +0200, Paolo Bonzini wrote: >> >> >> On 16/04/2015 17:54, Jérémy Fangučde wrote: >> > The guest kernel driver of the lsi device fails to enable it correctly >> > with a cache error: >> > [...] >> > sym53

Re: [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing

2015-04-17 Thread Eric Blake
On 04/17/2015 06:13 AM, Bohdan Trach wrote: > From: Bohdan Trach > > dump-pc-mem command is added for checkpointing guest memory to > file. Only system RAM region is saved. This checkpoint is later used to > recover unchanged pages. > > Signed-off-by: Bohdan Trach > --- > > +void qmp_dump_pc_

Re: [Qemu-devel] register_savevm()

2015-04-17 Thread Catalin Vasile
Does loadvm create new virtual devices (dev.init(), dev.realize(), etc.) for the vm to run onto and then load VMStateDescription? On Fri, Apr 17, 2015 at 4:40 PM, Peter Maydell wrote: > On 17 April 2015 at 14:03, Catalin Vasile > wrote: > > When are save() and load() handlers actually used? > >

Re: [Qemu-devel] [PATCH 0/4] virtio: Move host features to backends

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 14:43, Cornelia Huck wrote: > On Fri, 17 Apr 2015 20:13:42 +0800 > Shannon Zhao wrote: > > [Some questions may be silly, but I'm not familiar with the virtio-mmio > code] > >> The reason to do this is that the virtio-net-device can't expose host >> features to guest while usin

Re: [Qemu-devel] register_savevm()

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 14:54, Catalin Vasile wrote: > Does loadvm create new virtual devices (dev.init(), dev.realize(), etc.) for > the vm to run onto and then load VMStateDescription? loadvm itself does not, no. You have to start QEMU with the exact same configuration and command line options, whi

Re: [Qemu-devel] [PATCH 3/4] hw/net/virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-17 Thread Peter Maydell
On 17 April 2015 at 13:13, Shannon Zhao wrote: > Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net. > The transports just sync the host features from backend. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/net/virtio-net.c| 4 > hw/s390x/s390-v

Re: [Qemu-devel] ARM: PCI devices emulation broken with KVM due to cache issue

2015-04-17 Thread Christoffer Dall
On Fri, Apr 17, 2015 at 03:48:35PM +0200, Jérémy Fanguède wrote: > On Fri, Apr 17, 2015 at 11:29 AM, Christoffer Dall > wrote: > > On Thu, Apr 16, 2015 at 06:02:27PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 16/04/2015 17:54, Jérémy Fangučde wrote: > >> > The guest kernel driver of the lsi dev

[Qemu-devel] [PATCH v1 RFC 04/34] qom: add object_new_propv / object_new_proplist constructors

2015-04-17 Thread Daniel P. Berrange
It is reasonably common to want to create an object, set a number of properties, register it in the hierarchy and then mark it as complete (if a user creatable type). This requires quite alot of error prone, verbose, boilerplate code to achieve. The object_new_propv / object_new_proplist construct

[Qemu-devel] [PATCH v1 RFC 01/34] ui: remove check for failure of qemu_acl_init()

2015-04-17 Thread Daniel P. Berrange
The qemu_acl_init() function has long since stopped being able to return NULL, since g_malloc will abort on OOM. As such the checks for NULL were unreachable code. Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 8 1 file changed, 8 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index

[Qemu-devel] [PATCH v1 RFC 00/34] Generic support for TLS protocol & I/O channels

2015-04-17 Thread Daniel P. Berrange
The following series is a work-in-progress of my effort to bring TLS encryption support to all the QEMU socket based backends. The current patches just illustrate changes to the chardev backends, but future patches will cover NBD client/server and the migration client/server code. The original disc

[Qemu-devel] [PATCH v1 RFC 09/34] crypto: move built-in AES implementation into crypto/

2015-04-17 Thread Daniel P. Berrange
To prepare for a generic internal cipher API, move the built-in AES implementation into the crypto/ directory Signed-off-by: Daniel P. Berrange --- block/qcow.c | 2 +- block/qcow2.c | 1 - block/qcow2.h | 2 +- crypto/Makefile.objs |

[Qemu-devel] [PATCH v1 RFC 08/34] crypto: introduce new module for computing hash digests

2015-04-17 Thread Daniel P. Berrange
Introduce a new crypto/ directory that will (eventually) contain all the cryptographic related code. This initially defines a wrapper for initializing gnutls and for computing hashes with gnutls. The former ensures that gnutls is guaranteed to be initialized exactly once in QEMU regardless of CLI a

[Qemu-devel] [PATCH v1 RFC 02/34] qom: document user creatable object types in help text

2015-04-17 Thread Daniel P. Berrange
The QEMU help for -object is essentially useless, just giving users the generic syntax. Move it down into its own section and introduce a nested table where each user creatable object can be documented. The existing memory-backend-file, rng-random and rng-egd object types are documented. Signed-of

  1   2   3   >