Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-09 Thread Liviu Ionescu
> On 09 Apr 2015, at 20:58, Peter Maydell wrote: > > On 9 April 2015 at 18:41, Stefan Weil wrote: >> I think -mthreads is essential (needed for thread local storage), >> and -D_POSIX=1 is also needed for 64 bit builds. > > My 64-bit builds worked without either of these things... I tried with

Re: [Qemu-devel] [PATCH 00/14] Add memory attributes and use them in ARM

2015-04-09 Thread Edgar E. Iglesias
On Tue, Apr 07, 2015 at 09:09:46PM +0100, Peter Maydell wrote: > Following from my previous RFC about transaction memory attributes, > here's some code I think is good enough to drop the 'RFC' tag :-) > (read: I would like to land this when master reopens for 2.4.) > > I've included both the chang

Re: [Qemu-devel] [PATCH 10/14] target-arm: Honour NS bits in page tables

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 12:23, Edgar E. Iglesias wrote: > On Tue, Apr 07, 2015 at 09:09:56PM +0100, Peter Maydell wrote: >> >> +if (regime_is_secure(env, mmu_idx)) { >> +/* The page table entries may downgrade this to non-secure, but >> + * cannot upgrade an non-secure translation r

[Qemu-devel] [PATCH 2/2] qdev: Free property names after registering gpio aliases

2015-04-09 Thread Eduardo Habkost
Now that object_property_add_alias() strdup()s target_name, we can free the property names in qdev_pass_gpios(). Signed-off-by: Eduardo Habkost --- hw/core/qdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 6e6a65d..6dca6cb 100644 --- a/hw/core/qde

Re: [Qemu-devel] [Qemu-block] [RFC] Intermediate block mirroring

2015-04-09 Thread Alberto Garcia
On Thu, Apr 09, 2015 at 11:39:28AM +0100, Stefan Hajnoczi wrote: > > The goal would be to convert this: > > > >[A] -> [B] -> [C] -> [D] > > > > into this: > > > >[A] -> [B] -> [X] -> [D] > > > > where [D] is the active image and [X] would be a copy of [C]. The > > latter would be unlin

Re: [Qemu-devel] Getting VM state from outside QEMU?

2015-04-09 Thread Paulo Ricardo Paz Vital
Sorry guys only checked the emails this morning :-D On Wed, 2015-04-08 at 10:16 -0600, Eric Blake wrote: > On 04/08/2015 10:10 AM, Erik Rull wrote: > >> > >> My suggestion is to create a script that sends the QMP command > >> "query-status" an then parse the result. The syntax and output is: > >>

[Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-09 Thread Thomas Huth
Current QEMU crashes when specifying an illegal model with the "-net nic,model=xxx" option, e.g.: $ qemu-system-x86_64 -net nic,model=n/a qemu-system-x86_64: Unsupported NIC model: n/a Program received signal SIGSEGV, Segmentation fault. The gdb backtrace looks like this: 0x55965fe0

[Qemu-devel] Qemu binary and list of supported arches

2015-04-09 Thread Michal Privoznik
Dear list, when trying to solve this bug [1] I've realized qemu is not reporting a list of supported architectures for given binary. I mean, we do have 'query-target' but as I understand it it merely reports only the default architecture. For instance for qemu-system-i386 I get 'i386', for -x86_64

Re: [Qemu-devel] [PATCH v2 1/4] target-i386: Make "level" and "xlevel" properties static

2015-04-09 Thread Igor Mammedov
On Wed, 8 Apr 2015 16:02:40 -0300 Eduardo Habkost wrote: > Static properties require only 1 line of code, much simpler than the > existing code that requires writing new getters/setters. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > target-i386/cpu.c | 40 ++-

Re: [Qemu-devel] [PATCH v5 15/21] block: Resize bitmaps on bdrv_truncate

2015-04-09 Thread Stefan Hajnoczi
On Wed, Apr 08, 2015 at 06:19:58PM -0400, John Snow wrote: > Signed-off-by: John Snow > --- > block.c| 18 ++ > include/qemu/hbitmap.h | 10 ++ > util/hbitmap.c | 48 > 3 files changed, 76 insertions(

Re: [Qemu-devel] [RFC PATCH 0/3] pflash_cfi01: allow reading/writing it only in secure mode

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 14:47, Peter Maydell wrote: > On 9 April 2015 at 13:20, Paolo Bonzini wrote: >> This is an example of usage of attributes in a device model. It lets >> you block flash writes unless the CPU is in secure mode. Enabling it >> currently requires a -readconfig file: >> >> [gl

Re: [Qemu-devel] [PATCH 01/14] memory: Define API for MemoryRegionOps to take attrs and return status

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 09:55, Edgar E. Iglesias wrote: > Did you consider using a struct here? > e.g: > > typedef struct MemTxAttrs { > unsigned int secure : 1; > unsigned int master_id : 10; > unsigned int etc : 1; > } MemTxAttrs; > > I think you could still pass it by value and my unders

Re: [Qemu-devel] [PATCH v4 10/20] hw/arm/virt-acpi-build: Generate RSDT table

2015-04-09 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > RSDT points to other tables FADT, MADT, GTDT. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/hw/arm/virt-acpi-bu

Re: [Qemu-devel] [PATCH v4 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-09 Thread Igor Mammedov
On Fri, 3 Apr 2015 18:03:45 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add ToUUID macro, this is useful for generating PCIe ACPI table. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/acpi/aml-build.c | 23 +++ > include/hw/acpi/a

[Qemu-devel] [PATCH 10/10] s390x/kvm: Support access register mode for KVM_S390_MEM_OP ioctl

2015-04-09 Thread Cornelia Huck
From: Alexander Yarygin Access register mode is one of the modes that control dynamic address translation. In this mode the address space is specified by values of the access registers. The effective address-space-control element is obtained from the result of the access register translation. See

Re: [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support

2015-04-09 Thread Stefan Hajnoczi
On Mon, Mar 30, 2015 at 07:19:42PM +0300, Alberto Garcia wrote: > @@ -1941,9 +1951,11 @@ void qmp_block_set_io_throttle(const char *device, > int64_t bps, int64_t bps_rd, > aio_context_acquire(aio_context); > > if (!bs->io_limits_enabled && throttle_enabled(&cfg)) { > -bdrv_io_

Re: [Qemu-devel] [PATCH 3/3] arm: semihosting: Wire up A64 HLT 0xf000

2015-04-09 Thread Christopher Covington
Hi Peter, On Fri, Mar 27, 2015 at 12:40 PM, Peter Maydell wrote: >> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c >> index 0b192a1..3b5b875 100644 >> --- a/target-arm/translate-a64.c >> +++ b/target-arm/translate-a64.c >> @@ -1544,7 +1544,11 @@ static void disas_exc(DisasC

Re: [Qemu-devel] [PATCH for-2.3] configure: disable by default and warn about libxseg GPLv3 license

2015-04-09 Thread Andreas Färber
Am 09.04.2015 um 18:57 schrieb Andreas Färber: > Am 09.04.2015 um 15:52 schrieb Stefan Hajnoczi: >> libxseg has changed license to GPLv3. QEMU includes GPL "v2 only" code >> which is not compatible with GPLv3. This means the resulting binaries >> may not be redistributable! >> >> Disable Archipel

Re: [Qemu-devel] [PATCH 10/14] target-arm: Honour NS bits in page tables

2015-04-09 Thread Edgar E. Iglesias
On Thu, Apr 09, 2015 at 03:14:58PM +0100, Peter Maydell wrote: > On 9 April 2015 at 12:23, Edgar E. Iglesias wrote: > > On Tue, Apr 07, 2015 at 09:09:56PM +0100, Peter Maydell wrote: > >> > >> +if (regime_is_secure(env, mmu_idx)) { > >> +/* The page table entries may downgrade this to

[Qemu-devel] [PATCH 06/10] s390x/mmu: Use access type definitions instead of magic values

2015-04-09 Thread Cornelia Huck
From: Thomas Huth Since there are now proper definitions for the MMU access type, let's use them in the s390x MMU code, too, instead of the hard-to-understand magic values. Signed-off-by: Thomas Huth Reviewed-by: Jens Freimann Acked-by: Cornelia Huck Signed-off-by: Cornelia Huck --- target-

Re: [Qemu-devel] [PATCH 0/5] fix coding style and use of typedef type

2015-04-09 Thread Gerd Hoffmann
On Do, 2015-04-09 at 02:04 +0800, Chih-Min Chao wrote: > bitops : fix coding style > ui/vnc : fix coding style > ui/vnc : remove 'struct' of 'typedef struct' > ui/console : remove 'struct' from 'typedef struct' type > hw/display : remove 'struct' from 'typedef QXL struct' Reviewed-by: Ge

Re: [Qemu-devel] [PATCH v4 09/20] hw/arm/virt-acpi-build: Generate GTDT table

2015-04-09 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > ACPI v5.1 defines GTDT for ARM devices as a place to describe timer > related information in the system. The Arch Timer interrupts must > be provided for GTDT. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi

Re: [Qemu-devel] [PATCH v4 06/20] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices

2015-04-09 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > DSDT consists of the usual common table header plus a definition > block in AML encoding which describes all devices in the platform. > > After initializing DSDT with header information the namespace is > created which is followed by the device enco

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-09 Thread Liviu Ionescu
> On 09 Apr 2015, at 10:40, Liviu Ionescu wrote: > I guess you either tweaked the pkg-config to find them, or you set some > environment variables before configure. > ... > can you share these details too? I want to reproduce "exactly" your > environment. the reason I ask for these details is

[Qemu-devel] [PATCH v2] translate-all: use glib for all page descriptor allocations

2015-04-09 Thread Emilio G. Cota
Since commit b7b5233a "bsd-user/mmap.c: Don't try to override g_malloc/g_free" the exception we make here for usermode has been unnecessary. Get rid of it. Signed-off-by: Emilio G. Cota --- translate-all.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/2] CVE-2015-1779: incrementally decode websocket frames

2015-04-09 Thread Daniel P. Berrange
On Wed, Apr 01, 2015 at 02:41:57PM +0100, Peter Maydell wrote: > On 1 April 2015 at 14:36, Gerd Hoffmann wrote: > > Confirmed. Fixes the issues I've seen in testing and looks sensible to > > me. Comment from Daniel would be nice, especially as I know next to > > nothing about websockets, but he

Re: [Qemu-devel] [PATCH v4 12/20] hw/arm/virt-acpi-build: Add PCIe info and generate MCFG table

2015-04-09 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > Add PCIe info struct, prepare for building PCIe table. > And generate MCFG table. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 21 + > include/hw/arm/virt-acpi-build.

Re: [Qemu-devel] [PULL 22/62] block: Support Archipelago as a QEMU block backend

2015-04-09 Thread Chrysostomos Nanakos
On 2015-04-09 06:48, Andreas Färber wrote: Am 08.08.2014 um 19:39 schrieb Kevin Wolf: From: Chrysostomos Nanakos VM Image on Archipelago volume is specified like this: file.driver=archipelago,file.volume=[,file.mport=[, file.vport=][,file.segment=]] 'archipelago' is the protocol. 'mport' i

[Qemu-devel] [PATCH] misc: Fix new collection of typos

2015-04-09 Thread Stefan Weil
All of them were reported by codespell. Most typos are in comments, one is in an error message. Signed-off-by: Stefan Weil --- hw/block/virtio-blk.c |2 +- hw/misc/edu.c |2 +- hw/net/virtio-net.c |2 +- hw/ppc/spapr.c|2 +- qga/qapi-schema.json

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 16:54, Peter Lieven wrote: > > #define BM_MIGRATION_COMPAT_STATUS_BITS \ > (IDE_RETRY_DMA | IDE_RETRY_PIO | \ > IDE_RETRY_READ | IDE_RETRY_FLUSH) > > Why is there no IDE_RETRY_WRITE ? Because that's represented by none of read and flush being set. :) > Honestly,

Re: [Qemu-devel] seccomp breakage on arm

2015-04-09 Thread Paul Moore
On Thursday, April 09, 2015 10:21:52 AM Eduardo Otubo wrote: > On Thu, Apr 09, 2015 at 05=01=31AM +0200, Andreas Färber wrote: > > Hello, > > > > I am seeing the following build failure on openSUSE Tumbleweed armv7l > > with --enable-seccomp in v2.3.0-rc2: > > > > [ 551s] In file included from q

Re: [Qemu-devel] [PATCH 01/14] memory: Define API for MemoryRegionOps to take attrs and return status

2015-04-09 Thread Edgar E. Iglesias
On Tue, Apr 07, 2015 at 09:09:47PM +0100, Peter Maydell wrote: > Define an API so that devices can register MemoryRegionOps whose read > and write callback functions are passed an arbitrary pointer to some > transaction attributes and can return a success-or-failure status code. > This will allow u

Re: [Qemu-devel] [PATCH] qemu-config: Accept empty option values

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 20:50, Eduardo Habkost wrote: > On Thu, Apr 09, 2015 at 02:11:11PM +0200, Paolo Bonzini wrote: >> On 08/04/2015 20:16, Eduardo Habkost wrote: >>> Currently it is impossible to set an option in a config file to an empty >>> string, because the parser matches only lines containing non

Re: [Qemu-devel] seccomp breakage on arm

2015-04-09 Thread Andreas Färber
Am 09.04.2015 um 11:10 schrieb Paul Moore: > On Thursday, April 09, 2015 10:21:52 AM Eduardo Otubo wrote: >> On Thu, Apr 09, 2015 at 05=01=31AM +0200, Andreas Färber wrote: >>> Hello, >>> >>> I am seeing the following build failure on openSUSE Tumbleweed armv7l >>> with --enable-seccomp in v2.3.0-r

Re: [Qemu-devel] [PATCH 2/7] throttle: Add throttle group infrastructure

2015-04-09 Thread Stefan Hajnoczi
On Mon, Mar 30, 2015 at 07:19:40PM +0300, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > block/Makefile.objs | 1 + > block/throttle-groups.c | 261 > > include/block/block_int.h | 1 + > include/block/throttle

[Qemu-devel] [PULL 0/4] Block patches

2015-04-09 Thread Stefan Hajnoczi
The following changes since commit 5a24f20a7208a58fb80d78ca0521bba6f4d7b145: Merge remote-tracking branch 'remotes/mjt/tags/pull-trivial-patches-2015-04-04' into staging (2015-04-07 14:33:46 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-r

Re: [Qemu-devel] [Qemu-block] [RFC] Intermediate block mirroring

2015-04-09 Thread Stefan Hajnoczi
On Thu, Apr 02, 2015 at 03:28:57PM +0200, Alberto Garcia wrote: > Hi, > > I'm interested in adding the possibility to mirror an intermediate > node in a disk image chain, but I would like to have some feedback > before sending any patches. > > The goal would be to convert this: > >[A] -> [B]

Re: [Qemu-devel] [PATCH 1/2] kvm: introduce kvm_arch_msi_data_to_gsi

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 17:20, Eric Auger wrote: > On ARM the MSI data corresponds to the shared peripheral interrupt (SPI) > ID. This latter equals to the SPI index + 32. to retrieve the SPI index, > matching the gsi, an architecture specific function is introduced. > > Signed-off-by: Eric Auger > --- >

Re: [Qemu-devel] [PATCH v4 06/20] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices

2015-04-09 Thread Igor Mammedov
On Thu, 09 Apr 2015 10:51:33 +0100 Alex Bennée wrote: > > Shannon Zhao writes: > > > From: Shannon Zhao > > > > DSDT consists of the usual common table header plus a definition > > block in AML encoding which describes all devices in the platform. > > > > After initializing DSDT with header i

[Qemu-devel] [PULL 1/4] qcow2: Fix header update with overridden backing file

2015-04-09 Thread Stefan Hajnoczi
From: Kevin Wolf In recent qemu versions, it is possible to override the backing file name and format that is stored in the image file with values given at runtime. In such cases, the temporary override could end up in the image header if the qcow2 header was updated, while obviously correct beha

Re: [Qemu-devel] [PULL 22/62] block: Support Archipelago as a QEMU block backend

2015-04-09 Thread Chrysostomos Nanakos
On 2015-04-09 17:05, Stefan Hajnoczi wrote: On Thu, Apr 9, 2015 at 1:48 PM, Chrysostomos Nanakos wrote: On 2015-04-09 06:48, Andreas Färber wrote: Am 08.08.2014 um 19:39 schrieb Kevin Wolf: From: Chrysostomos Nanakos VM Image on Archipelago volume is specified like this: file.driver=a

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-09 Thread Stefan Weil
Am 09.04.2015 um 16:07 schrieb Liviu Ionescu On 09 Apr 2015, at 10:40, Liviu Ionescu wrote: I guess you either tweaked the pkg-config to find them, or you set some environment variables before configure. ... can you share these details too? I want to reproduce "exactly" your environment. Her

[Qemu-devel] [PATCH] translate-all: use g_malloc0 for all page descriptor allocations

2015-04-09 Thread Emilio G. Cota
Since commit b7b5233a "bsd-user/mmap.c: Don't try to override g_malloc/g_free" the exception we make here for usermode has been unnecessary. Get rid of it. Signed-off-by: Emilio G. Cota --- translate-all.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Edgar E. Iglesias
On Tue, Apr 07, 2015 at 09:09:52PM +0100, Peter Maydell wrote: > Make address_space_rw take transaction attributes, rather > than always using the 'unspecified' attributes. Reviewed-by: Edgar E. Iglesias I guess that we eventually will need to convert the dma_ functions? > > Signed-off-by: P

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add myself as NUMA code maintainer

2015-04-09 Thread Paolo Bonzini
On 08/04/2015 18:53, Eduardo Habkost wrote: > The "srat" and "numa" keywords will help get_maintainer.pl catch > NUMA-related code in other files too. > > Signed-off-by: Eduardo Habkost > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAI

Re: [Qemu-devel] SIGTERM signal to qemu-kvm process

2015-04-09 Thread Jatin Davey
On 4/8/2015 9:06 PM, Kevin Wolf wrote: Am 08.04.2015 um 07:07 hat Jatin Davey geschrieben: I am using QEMU 0.12.1 as the hypervisor in my RHEL installation of 6.5. I wanted to know if there are any side-effects with respect to VM image corruption when i use SIGTERM signal to kill a qemu-kvm pro

Re: [Qemu-devel] [Qemu-block] Migration sometimes fails with IDE and Qemu 2.2.1

2015-04-09 Thread Peter Lieven
Am 07.04.2015 um 21:13 schrieb John Snow: On 04/07/2015 03:02 PM, Peter Lieven wrote: Am 07.04.2015 um 20:56 schrieb John Snow: On 04/07/2015 02:44 PM, Peter Lieven wrote: Am 07.04.2015 um 17:29 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi David, Am 07.04.2015

Re: [Qemu-devel] [PATCH qemu v5 04/12] spapr_pci_vfio: Enable multiple groups per container

2015-04-09 Thread Alexey Kardashevskiy
On 04/09/2015 04:43 PM, David Gibson wrote: On Wed, Apr 08, 2015 at 01:45:19PM +1000, Alexey Kardashevskiy wrote: On 04/08/2015 12:01 PM, David Gibson wrote: On Tue, Mar 31, 2015 at 04:28:39PM +1100, Alexey Kardashevskiy wrote: This enables multiple IOMMU groups in one VFIO container which mea

[Qemu-devel] [PULL 2/4] virtio-blk: correctly dirty guest memory

2015-04-09 Thread Stefan Hajnoczi
From: Paolo Bonzini After qemu_iovec_destroy, the QEMUIOVector's size is zeroed and the zero size ultimately is used to compute virtqueue_push's len argument. Therefore, reads from virtio-blk devices did not migrate their results correctly. (Writes were okay). Save the size in virtio_blk_handl

[Qemu-devel] [PATCH v3] translate-all: use glib for all page descriptor allocations

2015-04-09 Thread Emilio G. Cota
Since commit b7b5233a "bsd-user/mmap.c: Don't try to override g_malloc/g_free" the exception we make here for usermode has been unnecessary. Get rid of it. Signed-off-by: Emilio G. Cota --- translate-all.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 12:43, Peter Maydell wrote: > > At this point, some memory barriers, basically. > > So what distinguishes a device that needs the memory barriers > and does its accesses via dma_* from a device that doesn't and > uses address_space_* or ld/st*_phys ? (Or for that matter a > non-devi

Re: [Qemu-devel] [RFC PATCH 0/3] pflash_cfi01: allow reading/writing it only in secure mode

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 18:10, Laszlo Ersek wrote: > In OVMF, the reset vector and the SEC phase code run from (read-only) > flash. SEC decompresses everything else to RAM. Also, SEC does not > access read-write flash (the varstore) at all. > > The above is a specialty of OVMF. In ArmVirtualizationQemu (a

Re: [Qemu-devel] [PATCH v4 10/20] hw/arm/virt-acpi-build: Generate RSDT table

2015-04-09 Thread Igor Mammedov
On Thu, 09 Apr 2015 13:50:52 +0100 Alex Bennée wrote: > > Shannon Zhao writes: > > > From: Shannon Zhao > > > > RSDT points to other tables FADT, MADT, GTDT. > > > > Signed-off-by: Shannon Zhao > > Signed-off-by: Shannon Zhao > > --- > > hw/arm/virt-acpi-build.c | 27 ++

[Qemu-devel] [PATCH 2/3] pflash_cfi01: change to new-style MMIO accessors

2015-04-09 Thread Paolo Bonzini
This is a required step to implement read_with_attrs and write_with_attrs. Signed-off-by: Paolo Bonzini --- hw/block/pflash_cfi01.c | 96 ++--- 1 file changed, 10 insertions(+), 86 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cf

Re: [Qemu-devel] [PATCH v4 04/20] hw/acpi/aml-build: Add aml_memory32_fixed() term

2015-04-09 Thread Alex Bennée
Michael S. Tsirkin writes: > On Wed, Apr 08, 2015 at 03:54:45PM +0100, Alex Bennée wrote: >> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> > index 8d01959..fefe7c7 100644 >> > --- a/hw/acpi/aml-build.c >> > +++ b/hw/acpi/aml-build.c >> > @@ -505,6 +505,28 @@ Aml *aml_call4(const ch

Re: [Qemu-devel] [PATCH 05/14] exec.c: Convert subpage memory ops to _with_attrs

2015-04-09 Thread Edgar E. Iglesias
On Tue, Apr 07, 2015 at 09:09:51PM +0100, Peter Maydell wrote: > Convert the subpage memory ops to _with_attrs; this will allow > us to pass the attributes through to the underlying access > functions. > > Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias > --- > exec.c | 33 ++

Re: [Qemu-devel] [PATCH v4 10/20] hw/arm/virt-acpi-build: Generate RSDT table

2015-04-09 Thread Laszlo Ersek
On 04/09/15 18:03, Peter Maydell wrote: > On 9 April 2015 at 17:00, Laszlo Ersek wrote: >> On 04/09/15 15:59, Peter Maydell wrote: >>> On 9 April 2015 at 14:51, Igor Mammedov wrote: On Thu, 9 Apr 2015 14:27:58 +0100 Peter Maydell wrote: > On 9 April 2015 at 14:17, Igor Mammedo

Re: [Qemu-devel] [PATCH v4 14/20] hw/acpi/aml-build: Add aml_or() term

2015-04-09 Thread Igor Mammedov
On Fri, 3 Apr 2015 18:03:46 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add aml_or() term and make aml_and can take three args. > Expose build_append_int_noprefix as it wiil be used by > creating a buffer. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/acpi/

[Qemu-devel] [PATCH 0/2] qom: strdup() target_name on object_property_add_alias()

2015-04-09 Thread Eduardo Habkost
This helps us avoid memory leaks when using object_property_add_alias(), as it is not practical for callers to save target_name to free it later. Eduardo Habkost (2): qom: strdup() target property name on object_property_add_alias() qdev: Free property names after registering gpio aliases hw

Re: [Qemu-devel] [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

2015-04-09 Thread Stefan Hajnoczi
On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven wrote: CCing the entirety of this patch to qemu-devel@nongnu.org. It is also available in the qemu-bl...@nongnu.org mailing list archives: http://permalink.gmane.org/gmane.comp.emulators.qemu.block/460 > newer libiscsi versions may return zero events

Re: [Qemu-devel] [PATCH] translate-all: use g_malloc0 for all page descriptor allocations

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 19:24, Emilio G. Cota wrote: > Since commit > > b7b5233a "bsd-user/mmap.c: Don't try to override g_malloc/g_free" > > the exception we make here for usermode has been unnecessary. > Get rid of it. > > Signed-off-by: Emilio G. Cota > --- > translate-all.c | 18 ++--

Re: [Qemu-devel] [PATCH 14/14] target-arm: Check watchpoints against CPU security state

2015-04-09 Thread Edgar E. Iglesias
On Tue, Apr 07, 2015 at 09:10:00PM +0100, Peter Maydell wrote: > Fix a TODO in bp_wp_matches() now that we have a function for > testing whether the CPU is currently in Secure mode or not. > > Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias > --- > target-arm/op_helper.c | 6

Re: [Qemu-devel] [PATCH] qemu-config: Accept empty option values

2015-04-09 Thread Eduardo Habkost
On Thu, Apr 09, 2015 at 02:11:11PM +0200, Paolo Bonzini wrote: > On 08/04/2015 20:16, Eduardo Habkost wrote: > > Currently it is impossible to set an option in a config file to an empty > > string, because the parser matches only lines containing non-empty > > strings between double-quotes. > > >

Re: [Qemu-devel] [PATCH v4 04/20] hw/acpi/aml-build: Add aml_memory32_fixed() term

2015-04-09 Thread Igor Mammedov
On Fri, 3 Apr 2015 18:03:36 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add aml_memory32_fixed() for describing device mmio region in resource > template. > These can be used to generating DSDT table for ACPI on ARM. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > ---

Re: [Qemu-devel] [PATCH v4 05/20] hw/acpi/aml-build: Add aml_interrupt() term

2015-04-09 Thread Igor Mammedov
On Thu, 9 Apr 2015 14:09:23 +0800 Shannon Zhao wrote: > On 2015/4/8 22:57, Alex Bennée wrote: > > > > Shannon Zhao writes: > > > >> From: Shannon Zhao > >> > >> Add aml_interrupt() for describing device interrupt in resource template. > >> These can be used to generating DSDT table for ACPI o

Re: [Qemu-devel] [PATCH for-2.3] configure: disable by default and warn about libxseg GPLv3 license

2015-04-09 Thread Andreas Färber
Am 09.04.2015 um 15:52 schrieb Stefan Hajnoczi: > libxseg has changed license to GPLv3. QEMU includes GPL "v2 only" code > which is not compatible with GPLv3. This means the resulting binaries > may not be redistributable! > > Disable Archipelago (libxseg) by default to prevent accidental licens

Re: [Qemu-devel] [RFC PATCH 0/3] pflash_cfi01: allow reading/writing it only in secure mode

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 14:06, Paolo Bonzini wrote: > On 09/04/2015 14:47, Peter Maydell wrote: >> Are real flash devices ever wired up like this? > > On x86 machines it is almost exactly like this. I'm implementing x86 > system management mode, and I'm reusing MEMTXATTRS_SECURE for it. Cool -- usefu

Re: [Qemu-devel] [PATCH 01/12 v9] linux-user: tilegx: Firstly add architecture related features

2015-04-09 Thread Peter Maydell
On 27 March 2015 at 10:48, Chen Gang wrote: > They are based on Linux kernel tilegx architecture for 64 bit binary, > also based on tilegx ABI reference document. > > Signed-off-by: Chen Gang > --- > linux-user/tilegx/syscall.h| 80 > linux-user/tilegx/syscall_nr.h | 278 ++

Re: [Qemu-devel] [PULL 22/62] block: Support Archipelago as a QEMU block backend

2015-04-09 Thread Stefan Hajnoczi
On Thu, Apr 9, 2015 at 1:48 PM, Chrysostomos Nanakos wrote: > On 2015-04-09 06:48, Andreas Färber wrote: >> >> Am 08.08.2014 um 19:39 schrieb Kevin Wolf: >>> >>> From: Chrysostomos Nanakos >>> >>> VM Image on Archipelago volume is specified like this: >>> >>> >>> >>> file.driver=archipelago,file.

Re: [Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-04-09 Thread Alberto Garcia
On Wed, Apr 08, 2015 at 10:27:34AM -0600, Eric Blake wrote: > > +++ b/block/snapshot.c > > @@ -246,9 +246,9 @@ int bdrv_snapshot_delete(BlockDriverState *bs, > > if (bs->file) { > > return bdrv_snapshot_delete(bs->file, snapshot_id, name, errp); > > } > > -error_set(errp, QE

Re: [Qemu-devel] [PATCH 0/3] Add support for for GICv2m and MSIs to arm-virt

2015-04-09 Thread Christoffer Dall
On Thu, Apr 9, 2015 at 12:01 AM, Nikolay Nikolaev wrote: > On Thu, Apr 9, 2015 at 12:20 AM, Christoffer Dall > wrote: >> Now when we have a host generic PCIe controller in the virt board, it >> would be nice to be able to use MSIs so that we can eventually enable >> VHOST with KVM. >> >> With the

[Qemu-devel] [PULL 4/4] block/iscsi: handle zero events from iscsi_which_events

2015-04-09 Thread Stefan Hajnoczi
From: Peter Lieven newer libiscsi versions may return zero events from iscsi_which_events. In this case iscsi_service will return immediately without any progress. To avoid busy waiting for iscsi_which_events to change we deregister all read and write handlers in this case and schedule a timer t

[Qemu-devel] [PATCH] aio: strengthen memory barriers for bottom half scheduling

2015-04-09 Thread Paolo Bonzini
There are two problems with memory barriers in async.c. The fix is to use atomic_xchg in order to achieve sequential consistency between the scheduling of a bottom half and the corresponding execution. First, if bh->scheduled is already 1 in qemu_bh_schedule, QEMU does not execute a memory barrie

Re: [Qemu-devel] [PATCH v3 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-04-09 Thread Gerd Hoffmann
Hi, > Would it make sense for me to re-send just 1/5 > ("fw_cfg: add documentation file") to actually provide the > above-mentioned documentation file with 2.3, leaving only > patches 2..5 (the actual code changes, subject to the freeze) > for 2.4 resubmission ? Yes, doc updates are fine even i

Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 13:49, Peter Maydell wrote: >> > I think we do not want to expose these at all (or at least, all users >> > should really be CPUs and hence use *_phys functions). >> > >> > S390 is always big-endian, and watch_mem_read/write can use the same >> > buffer trick as subpages (and in fac

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-09 Thread Liviu Ionescu
> On 09 Apr 2015, at 08:12, Stefan Weil wrote: > > The first four are custom packages, and you can get them from > http://qemu.weilnetz.de/debian/. > The last one is Wheezy specific and not needed. ok, got them, installed them and got no errors, they are now listed by dpkg -l > The gtk custom

[Qemu-devel] glusterfs-api.pc versioning breaks QEMU

2015-04-09 Thread Andreas Färber
Hello, Testing QEMU v2.3.0-rc2, I have run into QEMU's glusterfs support being broken on openSUSE Tumbleweed, resulting in its configure complaining: [ 76s] ERROR: User requested feature GlusterFS backend support [ 76s]configure was not able to find it. [ 76s]Install gluster

[Qemu-devel] [PATCH] configure: improve multiarch support for pkgconfig

2015-04-09 Thread John Snow
This will improve the multi-arch compilation for hosts using gcc. configurations using clang won't see an improvement, but also won't see a regression. Signed-off-by: John Snow --- configure | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configure b/configure index 826d6fd..

[Qemu-devel] [PATCH v3] target-i386: Register QOM properties for feature flags

2015-04-09 Thread Eduardo Habkost
This uses the feature name arrays to register "feat-*" QOM properties for feature flags. This simply adds the properties so they can be configured using -global, but doesn't change x86_cpu_parse_featurestr() to use them yet. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use "cpuid-" pref

Re: [Qemu-devel] 64-bit build of qemu-system-arm with mingw-w64 not functional

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 21:43, Stefan Weil wrote: > My fork also contains additional code which would need much work > to integrate it in the official QEMU (MIPS AR7 with WLAN router emulation, > Raspberry Pi emulation and other parts which are not always working). As an aside, if you're interested in

Re: [Qemu-devel] [PATCH v4 08/20] hw/arm/virt-acpi-build: Generate MADT table

2015-04-09 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > MADT describes GIC enabled ARM platforms. The GICC and GICD > subtables are used to define the GIC regions. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée > --- > hw/arm/virt-acpi-build.c | 61 >

Re: [Qemu-devel] [RFC PATCH 0/3] pflash_cfi01: allow reading/writing it only in secure mode

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 15:58, Edgar E. Iglesias wrote: > Hi Paulo, > > How would this work with XIP off the romd region? > Without s/ns address spaces, CPUs in NS state will be able to execute > and access data while in ROMD state won't they? Good point! In fact, even with S/NS address spaces, the ROM

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 11:21, Paolo Bonzini wrote: > > > On 09/04/2015 12:14, Peter Maydell wrote: >> On 9 April 2015 at 10:59, Edgar E. Iglesias wrote: >>> > On Tue, Apr 07, 2015 at 09:09:52PM +0100, Peter Maydell wrote: >> Make address_space_rw take transaction attributes, rather >> than

Re: [Qemu-devel] [PATCH 0/2] qom: strdup() target_name on object_property_add_alias()

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 21:57, Eduardo Habkost wrote: > This helps us avoid memory leaks when using object_property_add_alias(), as it > is not practical for callers to save target_name to free it later. > > Eduardo Habkost (2): > qom: strdup() target property name on object_property_add_alias() > qde

Re: [Qemu-devel] [PULL 0/4] Block patches

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 10:55, Stefan Hajnoczi wrote: > The following changes since commit 5a24f20a7208a58fb80d78ca0521bba6f4d7b145: > > Merge remote-tracking branch > 'remotes/mjt/tags/pull-trivial-patches-2015-04-04' into staging (2015-04-07 > 14:33:46 +0100) > > are available in the git reposito

[Qemu-devel] [PATCH 2/2] arm_gicv2m: set kvm_gsi_direct_mapping and kvm_msi_via_irqfd_allowed

2015-04-09 Thread Eric Auger
After introduction of kvm_arch_msi_data_to_gsi, kvm_gsi_direct_mapping now can be set on ARM. Also kvm_msi_via_irqfd_allowed can be set, depending on kernel irqfd support, hence enabling VIRTIO-PCI with vhost back-end. Signed-off-by: Eric Auger --- hw/intc/arm_gicv2m.c | 2 ++ 1 file changed, 2

[Qemu-devel] [PATCH 1/2] kvm: introduce kvm_arch_msi_data_to_gsi

2015-04-09 Thread Eric Auger
On ARM the MSI data corresponds to the shared peripheral interrupt (SPI) ID. This latter equals to the SPI index + 32. to retrieve the SPI index, matching the gsi, an architecture specific function is introduced. Signed-off-by: Eric Auger --- include/sysemu/kvm.h | 2 ++ kvm-all.c| 2

Re: [Qemu-devel] [PATCH v3] translate-all: use glib for all page descriptor allocations

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 22:07, Emilio G. Cota wrote: > Since commit > > b7b5233a "bsd-user/mmap.c: Don't try to override g_malloc/g_free" > > the exception we make here for usermode has been unnecessary. > Get rid of it. > > Signed-off-by: Emilio G. Cota > --- > translate-all.c | 18 ++--

Re: [Qemu-devel] [PATCH v4 12/20] hw/arm/virt-acpi-build: Add PCIe info and generate MCFG table

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 16:54, Alex Bennée wrote: > > Shannon Zhao writes: > >> From: Shannon Zhao >> +build_mcfg(GArray *table_data, GArray *linker, VirtGuestInfo *guest_info) >> +{ >> +AcpiTableMcfg *mcfg; >> +acpi_pcie_info *info = guest_info->pcie_info; >> +int len = sizeof(*mcfg) + 1

Re: [Qemu-devel] [PATCH v4 10/20] hw/arm/virt-acpi-build: Generate RSDT table

2015-04-09 Thread Laszlo Ersek
On 04/09/15 15:59, Peter Maydell wrote: > On 9 April 2015 at 14:51, Igor Mammedov wrote: >> On Thu, 9 Apr 2015 14:27:58 +0100 >> Peter Maydell wrote: >> >>> On 9 April 2015 at 14:17, Igor Mammedov wrote: On Thu, 09 Apr 2015 13:50:52 +0100 Alex Bennée wrote: > > Shannon Zh

Re: [Qemu-devel] seccomp breakage on arm

2015-04-09 Thread Paul Moore
On Thursday, April 09, 2015 02:28:24 PM Andreas Färber wrote: > Am 09.04.2015 um 11:10 schrieb Paul Moore: > > On Thursday, April 09, 2015 10:21:52 AM Eduardo Otubo wrote: > >> On Thu, Apr 09, 2015 at 05=01=31AM +0200, Andreas Färber wrote: > >>> Hello, > >>> > >>> I am seeing the following build

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-09 Thread Michael S. Tsirkin
On Thu, Apr 09, 2015 at 03:32:45PM +0200, Thomas Huth wrote: > Current QEMU crashes when specifying an illegal model with the > "-net nic,model=xxx" option, e.g.: > > $ qemu-system-x86_64 -net nic,model=n/a > qemu-system-x86_64: Unsupported NIC model: n/a > > Program received signal SIGSEGV, S

[Qemu-devel] [PATCH 08/10] s390x/kvm: Put vm name, extended name and UUID into STSI322 SYSIB

2015-04-09 Thread Cornelia Huck
From: Ekaterina Tumanova KVM prefills the SYSIB, returned by STSI 3.2.2. This patch allows userspace to intercept execution, and fill in the values, that are known to qemu: machine name (8 chars), extended machine name (256 chars), extended machine name encoding (equals 2 for UTF-8) and UUID. ST

[Qemu-devel] [PATCH 03/10] s390-virtio: sort into categories

2015-04-09 Thread Cornelia Huck
Sort the various s390-virtio devices into the same categories as their virtio-pci counterparts. Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-bus.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virt

Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Register QOM properties for feature flags

2015-04-09 Thread Eduardo Habkost
On Wed, Apr 08, 2015 at 04:02:42PM -0300, Eduardo Habkost wrote: [...] > +names = g_strsplit(fi->feat_names[bit], "|", 0); I forgot to implement the property aliases Igor asked for. I will submit v3 of this patch later. > +for (i = 0; names[i]; i++) { > +char *feat_name = names[i]

Re: [Qemu-devel] [PATCH 0/2] MAINTAINERS: X86 update

2015-04-09 Thread Paolo Bonzini
On 08/04/2015 18:57, Eduardo Habkost wrote: > Add myself as X86 maintainer, and change its status to "Maintained". > > Eduardo Habkost (2): > MAINTAINERS: Add myself to X86 > MAINTAINERS: Change status of X86 to Maintained > > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 delet

Re: [Qemu-devel] [RFC PATCH 0/3] pflash_cfi01: allow reading/writing it only in secure mode

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 13:20, Paolo Bonzini wrote: > This is an example of usage of attributes in a device model. It lets > you block flash writes unless the CPU is in secure mode. Enabling it > currently requires a -readconfig file: > > [global] > driver = "cfi.pflash01" > p

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 12:14, Peter Maydell wrote: > On 9 April 2015 at 10:59, Edgar E. Iglesias wrote: >> > On Tue, Apr 07, 2015 at 09:09:52PM +0100, Peter Maydell wrote: >>> >> Make address_space_rw take transaction attributes, rather >>> >> than always using the 'unspecified' attributes. >> > >> > Rev

Re: [Qemu-devel] [PATCH v4 10/20] hw/arm/virt-acpi-build: Generate RSDT table

2015-04-09 Thread Igor Mammedov
On Thu, 9 Apr 2015 14:59:09 +0100 Peter Maydell wrote: > On 9 April 2015 at 14:51, Igor Mammedov wrote: > > On Thu, 9 Apr 2015 14:27:58 +0100 > > Peter Maydell wrote: > > > >> On 9 April 2015 at 14:17, Igor Mammedov wrote: > >> > On Thu, 09 Apr 2015 13:50:52 +0100 > >> > Alex Bennée wrote: >

Re: [Qemu-devel] [PATCH v4 11/20] hw/arm/virt-acpi-build: Generate RSDP table

2015-04-09 Thread Alex Bennée
Shannon Zhao writes: > From: Shannon Zhao > > RSDP points to RSDT which in turn points to other tables. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée > --- > hw/arm/virt-acpi-build.c | 35 ++- > 1 file changed, 34 in

  1   2   >