Re: [Qemu-devel] [PATCH] qom: Change prototype of user_creatable_complete.

On Wed, 1 Apr 2015 10:57:04 +0800 Lin Ma wrote: > From void user_creatable_complete(Object *obj, Error **errp) > to void user_creatable_complete(UserCreatable *uc, Error **errp) > > Signed-off-by: Lin Ma > --- > hw/block/dataplane/virtio-blk.c | 4 +++- > hw/virtio/virtio-rng.c |

Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim

On 31/03/2015 19:03, Eric Blake wrote: >>> >>> Apart from this, looks good. > Changing a "return":{} to "return":0 is not backwards-compatible. Why not? Paolo >> I'm CCing the qemu-ga maintainer. > I failed to do that in my beefier reply, so I'm responding here > just to say that this needs a

Re: [Qemu-devel] ppc vga output breakage since commit c3c1bb99

On 01/04/2015 00:34, Mark Cave-Ayland wrote: > On 30/03/15 12:47, Paolo Bonzini wrote: > >> On 30/03/2015 13:45, Peter Crosthwaite wrote: >>> Can the address_space_translate_address() length clamp be made >>> conditional on non-MMIO access as the RC fix? I submitted >>> c3c1bb99d1c11978d9ce94d1b

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

On 01/04/2015 08:54, Marcel Apfelbaum wrote: > This is the first object for which QemuOps are defined per > sub-type and are not global (if you don't take "object" under > consideration). We can return the same QemuOpts that were included before. Per-machine-type options are new and need not be

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

On 04/01/2015 11:01 AM, Paolo Bonzini wrote: On 01/04/2015 08:54, Marcel Apfelbaum wrote: This is the first object for which QemuOps are defined per sub-type and are not global (if you don't take "object" under consideration). We can return the same QemuOpts that were included before. Per-ma

[Qemu-devel] [PATCH V5 02/18] pc: add 2.4 machine types

The following patches will limit the following things to legacy machine type: - maximum number of virtqueues for virtio-pci were limited to 64 - auto msix bar size for virtio-net-pci were disabled by default Cc: Paolo Bonzini Cc: Richard Henderson Cc: Michael S. Tsirkin Signed-off-by: Jason Wa

[Qemu-devel] [PATCH V5 00/18] Support more virtio queues

We current limit the max virtio queues to 64. This is not sufficient to support multiqueue devices (e.g recent Linux support up to 256 tap queues). So this series tries to let virtio to support more queues. No much works need to be done except: - Introducing transport specific queue limitation. T

[Qemu-devel] [PATCH V5 01/18] virtio-net: fix the upper bound when trying to delete queues

Virtqueue were indexed from zero, so don't delete virtqueue whose index is n->max_queues * 2 + 1. Cc: Michael S. Tsirkin Cc: qemu-stable Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net

[Qemu-devel] [PATCH V5 08/18] virtio: introduce bus specific queue limit

This patch introduces a bus specific queue limitation. It will be useful for increasing the limit for one of the bus without disturbing other buses. Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: Richard Henderson Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Paolo Bonzini Signed-off-by: Ja

[Qemu-devel] [PATCH V5 03/18] spapr: add machine type specific instance init function

This patches adds machine type specific instance initialization functions. Those functions will be used by following patches to compat class properties for legacy machine types. Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Jason Wang --- hw/ppc/spapr.c | 23 +++

[Qemu-devel] [PATCH V5 04/18] ppc: spapr: add 2.4 machine type

The following patches will limit the following things to legacy machine type: - maximum number of virtqueues for virtio-pci were limited to 64 - auto msix bar size for virtio-net-pci were disabled by default Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Jason Wang --- hw/ppc/spapr

[Qemu-devel] [PATCH V5 06/18] monitor: check return value of qemu_find_net_clients_except()

qemu_find_net_clients_except() may return a value which is greater than the size of array we provided. So we should check this value before using it, otherwise this may cause unexpected memory access. This patch fixes the net related command completion when we have a virtio-net nic with more than

[Qemu-devel] [PATCH V5 11/18] virtio-mmio: switch to bus specific queue limit

Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-mmio.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 2ae6942..dbd44b6 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@

[Qemu-devel] [PATCH V5 05/18] monitor: replace the magic number 255 with MAX_QUEUE_NUM

This patch replace the magic number 255, and increase it to MAX_QUEUE_NUM which is maximum number of queues supported by a nic. Cc: Luiz Capitulino Signed-off-by: Jason Wang --- monitor.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/monitor.c b/monitor.

[Qemu-devel] [PATCH V5 09/18] virtio-ccw: introduce ccw specific queue limit

Instead of depending on marco, using a bus specific limit. Also make it clear that the number of gsis per I/O adapter is not directly depending on the number of virtio queues, but rather the other way around. Cc: Alexander Graf Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson

[Qemu-devel] [PATCH V5 13/18] virtio: introduce vector to virtqueues mapping

Currently we will try to traverse all virtqueues to find a subset that using a specific vector. This is sub optimal when we will support hundreds or even thousands of virtqueues. So this patch introduces a method which could be used by transport to get all virtqueues that using a same vector. This

[Qemu-devel] [PATCH V5 10/18] virtio-s390: switch to bus specific queue limit

Instead of depending on marco, switch to use a bus specific queue limit. Cc: Alexander Graf Cc: Richard Henderson Cc: Christian Borntraeger Cc: Cornelia Huck Signed-off-by: Jason Wang --- hw/s390x/s390-virtio-bus.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/h

[Qemu-devel] [PATCH V5 07/18] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue

There's no need to use vector 0 for invalid virtqueue. So this patch changes to use VIRTIO_NO_VECTOR instead. Cc: Michael S. Tsirkin Cc: Cornelia Huck CC: Christian Borntraeger Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Jason Wang --- hw/s390x/virtio-ccw.c | 2 +- 1 file change

[Qemu-devel] [PATCH V5 14/18] virtio: introduce virtio_queue_get_index()

This patch introduces a helper that can get the queue index of a VirtQueue. This is useful when traversing the list of VirtQueues. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio.c | 5 + include/hw/virtio/virtio.h | 1 + 2 files changed, 6 insertions(+) diff

[Qemu-devel] [PATCH V5 15/18] virtio-pci: speedup MSI-X masking and unmasking

This patch tries to speed up the MSI-X masking and unmasking through the mapping between vector and queues. With this patch it will there's no need to go through all possible virtqueues, which may help to reduce the time spent when doing MSI-X masking/unmasking a single vector when more than hundre

[Qemu-devel] [PATCH V5 12/18] virtio-pci: switch to use bus specific queue limit

Instead of depending on a macro, switch to use a bus specific queue limit. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 12 +++- include/hw/virtio/virtio.h | 2 -- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH V5 17/18] pci: remove hard-coded bar size in msix_init_exclusive_bar()

This patch lets msix_init_exclusive_bar() can calculate the bar and pba size according to the number of MSI-X vectors other than using a hard-coded limit 4096. This is needed to allow device to have more than 128 MSI_X vectors. An extra legacy_layout parameter was introduced to use legacy static 40

[Qemu-devel] [PATCH V5 18/18] virtio-pci: introduce auto_msix_bar_size property

Currently we don't support more than 128 MSI-X vectors for a pci devices, trying to use vector=129 for a virtio-net-pci device may get: qemu-system-x86_64: -device virtio-net-pci,netdev=hn0,vectors=129: unable to init msix vectors to 129 This this because the MSI-X bar size were hard-coded as 409

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

Am 31.03.2015 um 22:46 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 26.03.2015 um 16:04 hat Eric Blake geschrieben: > >> On 03/26/2015 07:18 AM, Markus Armbruster wrote: > >> > Eric Blake writes: > >> >> Meanwhile, it would be nice to allow > >> >> 'discri

[Qemu-devel] [PATCH V5 16/18] virtio-pci: increase the maximum number of virtqueues to 513

This patch increases the maximum number of virtqueues for pci from 64 to 513. This will allow booting a virtio-net-pci device with 256 queue pairs. To keep migration compatibility, 64 was kept for legacy machine types. This is because qemu in fact allows guest to probe the limit of virtqueues thro

Re: [Qemu-devel] [PATCH v5 3/7] acpi, mem-hotplug: add unplug request cb for memory device

On Fri, 27 Mar 2015 17:20:36 +0800 Zhu Guihua wrote: > From: Tang Chen > > This patch adds unplug request cb for memory device, and adds the > is_removing boolean field to MemStatus. This field is used to indicate > whether the memory slot is being removed. This field is set to true in > acpi_m

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

On 01/04/2015 10:06, Marcel Apfelbaum wrote: >> >> We can return the same QemuOpts that were included before. >> Per-machine-type options are new and need not be covered by >> query-command-line-options. > > OK, we have them under hw/core/machine.c as "base" machine properties. > We still need a

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

Marcel Apfelbaum writes: > On 03/31/2015 05:21 PM, Tony Krowiak wrote: >> Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc >> elements from the >> *desc* field of the *qemu_machine_opts *array defined in vl.c. Since >> applying that patch to qemu >> on my system, I can n

Re: [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

On Wed, 04/01 12:42, Bin Wu wrote: > From: Bin Wu What's the issue are you fixing? I think the coroutine already is running in the AioContext of bs. Fam > > Signed-off-by: Bin Wu > --- > block/mirror.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

Am 31.03.2015 um 22:09 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: > >> From: Fam Zheng > >> > >> In the near term, we will use it for a sensible-looking > >> 'gen':false inside command declarations, instead of the > >> curren

Re: [Qemu-devel] [PATCH v5 5/7] acpi: extend aml_field() to support UpdateRule

On Fri, 27 Mar 2015 17:20:38 +0800 Zhu Guihua wrote: > The flags field is declared with default update rule 'Preserve', > this patch is to extend aml_field() to support UpdateRule so that s/is to extend/extends/ > we can specify different value to UpdateRule for different field. s/value to Update

Re: [Qemu-devel] [PATCH v5 0/7] QEMU memory hot unplug support

On Fri, 27 Mar 2015 17:20:33 +0800 Zhu Guihua wrote: > Memory hot unplug are both asynchronous procedures. > When the unplug operation happens, unplug request cb is called first. > And when guest OS finished handling unplug, unplug cb will be called > to do the real removal of device. I think ser

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

Paolo Bonzini writes: > On 01/04/2015 08:54, Marcel Apfelbaum wrote: >> This is the first object for which QemuOps are defined per >> sub-type and are not global (if you don't take "object" under >> consideration). > > We can return the same QemuOpts that were included before. > Per-machine-type

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

On Wed, 2015-04-01 at 09:05 +0800, Chen, Tiejun wrote: > @@ -699,9 +699,35 @@ working graphics passthrough. See the > XenVGAPassthroughTestedAdapters > L wiki page > for currently supported graphics cards for gfx_passthru. > > -gfx_pas

Re: [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

On 2015/4/1 16:19, Fam Zheng wrote: > On Wed, 04/01 12:42, Bin Wu wrote: >> From: Bin Wu > > What's the issue are you fixing? I think the coroutine already is running in > the AioContext of bs. > > Fam > In the current implementation of bdrv_drain, it should be placed in a critical section as

[Qemu-devel] [PATCH v2] qom: Change prototype of user_creatable_complete.

>From void user_creatable_complete(Object *obj, Error **errp) to void user_creatable_complete(UserCreatable *uc, Error **errp) Signed-off-by: Lin Ma --- hw/block/dataplane/virtio-blk.c | 3 ++- hw/virtio/virtio-rng.c | 2 +- include/qom/object_interfaces.h | 7 +++ qmp.c

Re: [Qemu-devel] [PATCH] qom: Change prototype of user_creatable_complete.

On 01/04/2015 04:57, Lin Ma wrote: > From void user_creatable_complete(Object *obj, Error **errp) > to void user_creatable_complete(UserCreatable *uc, Error **errp) > > Signed-off-by: Lin Ma > --- > hw/block/dataplane/virtio-blk.c | 4 +++- > hw/virtio/virtio-rng.c | 3 ++- > incl

Re: [Qemu-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

On Tue, Mar 31, 2015 at 03:18:03PM +0100, Stefano Stabellini wrote: > From: Jan Beulich > > Otherwise the guest can abuse that control to cause e.g. PCIe > Unsupported Request responses (by disabling memory and/or I/O decoding > and subsequently causing [CPU side] accesses to the respective addre

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

On 01/04/2015 10:42, Markus Armbruster wrote: > The obvious way to return them is to put them right back in > qemu_machine_opts.desc[]. But then -machine rejects machine-specific > parameters. > > Hack: monkey-patch them in after we're done parsing. > > Cleaner: "empty desc[] means accept anyt

Re: [Qemu-devel] [PATCH v2] qom: Change prototype of user_creatable_complete.

On 01/04/2015 10:52, Lin Ma wrote: > From void user_creatable_complete(Object *obj, Error **errp) > to void user_creatable_complete(UserCreatable *uc, Error **errp) > > Signed-off-by: Lin Ma > --- > hw/block/dataplane/virtio-blk.c | 3 ++- > hw/virtio/virtio-rng.c | 2 +- > includ

Re: [Qemu-devel] Are "info pic" and "info irq" still of any use?

Am 31.03.2015 um 11:56 hat Markus Armbruster geschrieben: > These commands look like bit-rotted development aids to me. > > They're limited to just a few interrupt controllers. For the most > common machine types and accelerators, they do nothing. > > They complicate David Gibson's work on disen

Re: [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes

On 30 March 2015 at 12:45, Paolo Bonzini wrote: > These fix the problem with OpenBIOS's accesses to the VBE DISPI ports. > The problem stems from weird memory regions created by ioport.c. > > Patches 1-3 simplify some of the MemoryRegionPortio arrays. This makes it > easier to ascertain the effec

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

Kevin Wolf writes: > Am 31.03.2015 um 22:46 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 26.03.2015 um 16:04 hat Eric Blake geschrieben: >> >> On 03/26/2015 07:18 AM, Markus Armbruster wrote: >> >> > Eric Blake writes: >> >> >> Meanwhile, it would be

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

On 04/01/2015 12:07 PM, Paolo Bonzini wrote: On 01/04/2015 10:42, Markus Armbruster wrote: The obvious way to return them is to put them right back in qemu_machine_opts.desc[]. But then -machine rejects machine-specific parameters. Hack: monkey-patch them in after we're done parsing. Cleane

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

Perhaps add "With qemu-xen-traditional IGD is always assumed and other options than autodetect or explicit IGD will result in an error"? Will do. diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index a8b08f2..4fd6310 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm

Re: [Qemu-devel] [PATCH V5 17/18] pci: remove hard-coded bar size in msix_init_exclusive_bar()

On Wed, Apr 01, 2015 at 04:15:11PM +0800, Jason Wang wrote: > This patch lets msix_init_exclusive_bar() can calculate the bar and > pba size according to the number of MSI-X vectors other than using a > hard-coded limit 4096. This is needed to allow device to have more > than 128 MSI_X vectors. An

Re: [Qemu-devel] [PATCH V5 18/18] virtio-pci: introduce auto_msix_bar_size property

On Wed, Apr 01, 2015 at 04:15:12PM +0800, Jason Wang wrote: > Currently we don't support more than 128 MSI-X vectors for a pci > devices, trying to use vector=129 for a virtio-net-pci device may get: > > qemu-system-x86_64: -device virtio-net-pci,netdev=hn0,vectors=129: > unable to init msix vecto

Re: [Qemu-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

CC'ing the author of the patch and xen-devel. FYI I think that Jan is going to be on vacation for a couple of weeks. On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: > On Tue, Mar 31, 2015 at 03:18:03PM +0100, Stefano Stabellini wrote: > > From: Jan Beulich > > > > Otherwise the guest can abuse tha

Re: [Qemu-devel] [PATCH for-2.3 0/3] ioport fixes

On 01/04/2015 11:10, Peter Maydell wrote: >> > Peter, if you prefer you can just revert c3c1bb99. > Given the SPARC reset breakage also, I agree with you > (in the other thread) that we should revert c3c1bb99 > for 2.3, and fix this all properly in 2.4. Yup, pull request coming. Paolo

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

On 01/04/2015 11:14, Marcel Apfelbaum wrote: > This + 'monkey-patch' may be a feasible solution for 2.4 Why monkey-patch and not just revert? Paolo

Re: [Qemu-devel] block-commit & dropping privs

30.03.2015 18:36, Kevin Wolf wrote: > Am 27.03.2015 um 18:12 hat Eric Blake geschrieben: >> On 03/27/2015 09:36 AM, Michael Tokarev wrote: >>> Wonder how to specify cache mode, or should I open these with proper >>> O_DIRECT/O_SYNC/whatever? It looks like it's possible to change O_DIRECT >>> at ru

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

On 04/01/2015 12:23 PM, Paolo Bonzini wrote: On 01/04/2015 11:14, Marcel Apfelbaum wrote: This + 'monkey-patch' may be a feasible solution for 2.4 Why monkey-patch and not just revert? There are already several machine sub-types that have their own options, some of the code I think it was a

Re: [Qemu-devel] [PATCH v2] qom: Change prototype of user_creatable_complete.

On Wed, 1 Apr 2015 16:52:22 +0800 Lin Ma wrote: > From void user_creatable_complete(Object *obj, Error **errp) > to void user_creatable_complete(UserCreatable *uc, Error **errp) > > Signed-off-by: Lin Ma Reviewed-by: Igor Mammedov > --- > hw/block/dataplane/virtio-blk.c | 3 ++- > hw/vir

Re: [Qemu-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

On Wed, Apr 01, 2015 at 10:20:06AM +0100, Stefano Stabellini wrote: > CC'ing the author of the patch and xen-devel. > FYI I think that Jan is going to be on vacation for a couple of weeks. > > On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: > > On Tue, Mar 31, 2015 at 03:18:03PM +0100, Stefano Stabe

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

Kevin Wolf writes: > Am 31.03.2015 um 22:09 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: >> >> From: Fam Zheng >> >> >> >> In the near term, we will use it for a sensible-looking >> >> 'gen':false inside command declaratio

Re: [Qemu-devel] [PATCH v5 0/7] QEMU memory hot unplug support

On 04/01/2015 04:42 PM, Igor Mammedov wrote: On Fri, 27 Mar 2015 17:20:33 +0800 Zhu Guihua wrote: Memory hot unplug are both asynchronous procedures. When the unplug operation happens, unplug request cb is called first. And when guest OS finished handling unplug, unplug cb will be called to d

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

On 01/04/15 10:20, Stefano Stabellini wrote: > CC'ing the author of the patch and xen-devel. > FYI I think that Jan is going to be on vacation for a couple of weeks. > > On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2015 at 03:18:03PM +0100, Stefano Stabellini wrote: >>> From: Ja

Re: [Qemu-devel] [PATCH 2/2] balloon: add a feature bit to let Guest OS deflate balloon on oom

On Wed, Apr 01, 2015 at 12:44:28PM +0300, James Bottomley wrote: > On Fri, 2015-02-27 at 09:57 +0300, Denis V. Lunev wrote: > > Excessive virtio_balloon inflation can cause invocation of OOM-killer, > > when Linux is under severe memory pressure. Various mechanisms are > > responsible for correct v

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

On Wed, 2015-04-01 at 10:20 +0100, Stefano Stabellini wrote: > CC'ing the author of the patch and xen-devel. Adding Andy C who I think knows about this stuff. > FYI I think that Jan is going to be on vacation for a couple of weeks. > > On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: > > On Tue, Ma

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

On Wed, 2015-04-01 at 17:18 +0800, Chen, Tiejun wrote: > Currently Qemu maintainers are busy finalizing qemu 2.3, they don't > complete to review all associated qemu patch set. Although that don't > bring any change to our two patches on Xen side, I think we'd better > merge these patches until

Re: [Qemu-devel] block-commit & dropping privs

01.04.2015 12:26, Michael Tokarev пишет: > 30.03.2015 18:36, Kevin Wolf wrote: >> Am 27.03.2015 um 18:12 hat Eric Blake geschrieben: >>> On 03/27/2015 09:36 AM, Michael Tokarev wrote: Wonder how to specify cache mode, or should I open these with proper O_DIRECT/O_SYNC/whatever? It looks

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

Am 01.04.2015 um 11:33 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 31.03.2015 um 22:09 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: > >> >> From: Fam Zheng > >> >> > >> >> In the near term, we wi

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

On Wed, Apr 01, 2015 at 10:41:12AM +0100, Andrew Cooper wrote: > On 01/04/15 10:20, Stefano Stabellini wrote: > > CC'ing the author of the patch and xen-devel. > > FYI I think that Jan is going to be on vacation for a couple of weeks. > > > > On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: > >> On Tu

Re: [Qemu-devel] [PATCH 3/7] throttle: Add throttle group infrastructure tests

On Mon, 03/30 19:19, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/test-throttle.c | 79 > --- > 1 file changed, 69 insertions(+), 10 deletions(-) > > diff --git a/tests/test-throttle.c b/tests/test-throttle.c > index 458f577

Re: [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

On Mon, 03/30 19:19, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > block/qapi.c | 3 +++ > hmp.c| 6 -- > qapi/block-core.json | 4 +++- > 3 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/block/qapi.c b/block/qapi.c > index 65af057..e

Re: [Qemu-devel] [PATCH 6/7] throttle: add the name of the ThrottleGroup to BlockDeviceInfo

On Wed, Apr 01, 2015 at 05:59:40PM +0800, Fam Zheng wrote: > > info->has_iops_size = cfg.op_size; > > info->iops_size = cfg.op_size; > > + > > +info->has_group = true; > > +info->group = g_strdup(throttle_group_get_name(bs)); > > True even if it's unset? Note th

Re: [Qemu-devel] remaining patches for rc2?

On 27 March 2015 at 16:42, Peter Maydell wrote: > This is the set of things I have on the list for "should ideally > get into rc2": > * AArch64 migration fixes > * VNC patches to fix CVEs > * recent exec.c changes broke ppc OSX/OpenBIOS boot We seem to be still a little way off on a couple of

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

On Wed, Apr 01, 2015 at 10:50:45AM +0100, Ian Campbell wrote: > On Wed, 2015-04-01 at 10:20 +0100, Stefano Stabellini wrote: > > CC'ing the author of the patch and xen-devel. > > Adding Andy C who I think knows about this stuff. > > > FYI I think that Jan is going to be on vacation for a couple o

Re: [Qemu-devel] [PATCH V5 17/18] pci: remove hard-coded bar size in msix_init_exclusive_bar()

On Wed, Apr 1, 2015 at 5:18 PM, Michael S. Tsirkin wrote: On Wed, Apr 01, 2015 at 04:15:11PM +0800, Jason Wang wrote: This patch lets msix_init_exclusive_bar() can calculate the bar and pba size according to the number of MSI-X vectors other than using a hard-coded limit 4096. This is nee

Re: [Qemu-devel] [PATCH V5 18/18] virtio-pci: introduce auto_msix_bar_size property

On Wed, Apr 1, 2015 at 5:20 PM, Michael S. Tsirkin wrote: On Wed, Apr 01, 2015 at 04:15:12PM +0800, Jason Wang wrote: Currently we don't support more than 128 MSI-X vectors for a pci devices, trying to use vector=129 for a virtio-net-pci device may get: qemu-system-x86_64: -device virt

Re: [Qemu-devel] [PATCH 2/2] balloon: add a feature bit to let Guest OS deflate balloon on oom

On Wed, Apr 01, 2015 at 12:51:42PM +0300, James Bottomley wrote: > On Wed, 2015-04-01 at 11:50 +0200, Michael S. Tsirkin wrote: > > On Wed, Apr 01, 2015 at 12:44:28PM +0300, James Bottomley wrote: > > > On Fri, 2015-02-27 at 09:57 +0300, Denis V. Lunev wrote: > > > > Excessive virtio_balloon inflat

Re: [Qemu-devel] [PATCH V5 17/18] pci: remove hard-coded bar size in msix_init_exclusive_bar()

On Wed, Apr 01, 2015 at 06:12:18PM +0800, Jason Wang wrote: > >> diff --git a/hw/pci/msix.c b/hw/pci/msix.c > >> index 24de260..8c6d8f3 100644 > >> --- a/hw/pci/msix.c > >> +++ b/hw/pci/msix.c > >> @@ -291,33 +291,44 @@ int msix_init(struct PCIDevice *dev, unsigned > >>short nentries, > >> } > >>

Re: [Qemu-devel] virtio-scsi + iothread : segfault on drive_del

On 01/04/2015 05:34, Alexandre DERUMIER wrote: > > I'm currently testing virtio-scsi and iothread, > > and I'm seeing qemu segfault when I try to remove an scsi drive > on top of an virtio-scsi controller with iothread enabled. > > > virtio-blk + iothread drive_del is supported since this p

[Qemu-devel] [PULL 0/5] Bugfixes for 2.3.0-rc2

The following changes since commit 033a20359aaf93f4d8aa2be12558901e8e028baa: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' into staging (2015-03-31 12:12:23 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for y

[Qemu-devel] [PULL 3/5] pc: acpi: fix pvpanic regression

From: Igor Mammedov Commit cd61cb2 pc: acpi-build: generate pvpanic device description dynamically introduced regression changing pvpanic device HID from QEMU0001 to QEMU0002. Fix AML generated code so that pvpanic device would keep its original HID. i.e. QEMU0001 Signed-off-by: Igor Mammedov

[Qemu-devel] [PULL 5/5] Revert "exec: Respect as_tranlsate_internal length clamp"

This reverts commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459. It causes problems with boards that declare memory regions shorter than the registers they contain. Reported-by: Zoltan Balaton Signed-off-by: Paolo Bonzini --- exec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] remaining patches for rc2?

On 01/04/2015 12:08, Peter Maydell wrote: >> This is the set of things I have on the list for "should ideally >> get into rc2": >> * AArch64 migration fixes >> * VNC patches to fix CVEs >> * recent exec.c changes broke ppc OSX/OpenBIOS boot > We seem to be still a little way off on a couple of

[Qemu-devel] [PULL 1/5] qom: Add can_be_deleted callback to UserCreatableClass

From: Lin Ma If backends implement the can_be_deleted and it returns false, Then the qmp_object_del won't delete the given backends. Signed-off-by: Lin Ma Message-Id: <1427704589-7688-2-git-send-email-...@suse.com> Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- include/qom/objec

[Qemu-devel] [PULL 4/5] rcu: do not create thread in pthread_atfork callback

If QEMU forks after the CPU threads have been created, qemu_mutex_lock_iothread will not be able to do qemu_cpu_kick_thread. There is no solution other than assuming that forks after the CPU threads have been created will end up in an exec. Forks before the CPU threads have been created (such as

[Qemu-devel] [PULL 2/5] hostmem: Prevent removing an in-use memory backend

From: Lin Ma showing a memory device whose memdev is removed leads an assert: (qemu) object_add memory-backend-ram,id=ram0,size=128M (qemu) device_add pc-dimm,id=d0,memdev=ram0 (qemu) object_del ram0 (qemu) info memory-devices ** ERROR:qom/object.c:1274:object_get_canonical_path_component:\

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

I stumble upon the same problem. Made the same mistake taking a snapshot using qemu-img on a running virtual machine. It was easily fixed using qemu-img v1.7.2 binaries as mentioned earlier: ./qemu-img convert bad.qcow2 fixed.qcow2 -- You received this bug notification because you are a membe

Re: [Qemu-devel] remaining patches for rc2?

On 27 March 2015 at 21:07, Stefan Weil wrote: > Here are some open patches from my queue: > > http://patchwork.ozlabs.org/patch/450182/ > http://patchwork.ozlabs.org/patch/452748/ > http://patchwork.ozlabs.org/patch/452749/ > > All three are ARM related, so maybe you are interested to use them for

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

Kevin Wolf writes: > Am 01.04.2015 um 11:33 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 31.03.2015 um 22:09 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > Am 24.03.2015 um 21:03 hat Eric Blake geschrieben: >> >> >> From: Fam Zheng >> >> >>

Re: [Qemu-devel] remaining patches for rc2?

On 01/04/2015 13:08, Markus Armbruster wrote: > > Andreas, Markus, what's the status of the device-add changes? Are we > > going to fix PReP or is that delayed to 2.4? > > I like Andreas's patches to fix PReP's pc87312 well enough, but I can't > justify taking them this close to the release. S

Re: [Qemu-devel] remaining patches for rc2?

Paolo Bonzini writes: > On 01/04/2015 12:08, Peter Maydell wrote: >>> This is the set of things I have on the list for "should ideally >>> get into rc2": >>> * AArch64 migration fixes >>> * VNC patches to fix CVEs >>> * recent exec.c changes broke ppc OSX/OpenBIOS boot >> We seem to be still a

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

Am 01.04.2015 um 13:03 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 01.04.2015 um 11:33 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 31.03.2015 um 22:09 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > >> >> > Am 24.03.20

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-31 21:23+0300, Andrey Korolyov: > On Tue, Mar 31, 2015 at 9:04 PM, Bandan Das wrote: > > Bandan Das writes: > >> Andrey Korolyov writes: > >> ... > >>> http://xdel.ru/downloads/kvm-e5v2-issue/another-tracepoint-fail-with-apicv.dat.gz > >>> > >>> Something a bit more interesting, but the

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] null driver patches

On Wed, Apr 01, 2015 at 09:45:37AM +0800, Fam Zheng wrote: > v2: Change patch 01 to use realtime clock, that way we don't need to check the > VCPU state. [Stefan] > Added Eric's rev-by in 2&3. > Change title to "Null block driver" in 3. [Eric] > > The second patch allows testing commit

Re: [Qemu-devel] [Qemu-block] [PATCH] mirror: hold aio_context before bdrv_drain

On Wed, Apr 01, 2015 at 04:49:39PM +0800, Bin Wu wrote: > > On 2015/4/1 16:19, Fam Zheng wrote: > > On Wed, 04/01 12:42, Bin Wu wrote: > >> From: Bin Wu > > > > What's the issue are you fixing? I think the coroutine already is running in > > the AioContext of bs. > > > > Fam > > > In the curre

Re: [Qemu-devel] E5-2620v2 - emulation stop error

On 01/04/2015 13:49, Radim Krčmář wrote: > 2015-03-31 21:23+0300, Andrey Korolyov: >> On Tue, Mar 31, 2015 at 9:04 PM, Bandan Das wrote: >>> Bandan Das writes: Andrey Korolyov writes: ... > http://xdel.ru/downloads/kvm-e5v2-issue/another-tracepoint-fail-with-apicv.dat.gz > >>

[Qemu-devel] [PATCH for-2.4 1/5] chardev: Add IRC char driver

In order for qemu to become more human-friendly, we require an interface which is actually used by humans in their normal day-to-day communication. Many people in the qemu community will agree that IRC is indeed such a communication platform. By adding that support to qemu, users no longer have to

[Qemu-devel] [PATCH for-2.4 0/5] chardev: Add IRC char driver

This series adds a long-missing IRC character device driver to qemu. See patch 1 for an explanation why you should have been missing it. To make it short: IRC is a very well tested and more reliable, social, human-friendly, and ubiquitous[1] communication interface than any of the other character

[Qemu-devel] [PATCH for-2.4 2/5] chardev/irc: Add sockfd option

IRC being well on the way to deprecate other character devices, it must be exposed to management tools as well. These often prefer to pass a socket FD instead of a host and port to connect to, so this patch adds an appropriate option. Signed-off-by: Max Reitz --- qemu-char.c | 29 +++

[Qemu-devel] [PATCH for-2.4 3/5] chardev/irc: Add SSL support

qemu already makes use of gnutls, so it is only natural to extend its use to the IRC char driver. Furthermore, though IRC is ubiquitous, there may be servers which allow only SSL connections for some sense of additional security, be it real or not. Adding that support to qemu therefore means greate

[Qemu-devel] [PATCH for-2.4 4/5] chardev/irc: Add end-to-end encryption

IRC being usable for remote configuration, offering a secure channel is indispensable. As can be seen from its alias "Caesar's cipher", ROT13 has been in use since ancient times and has been employed for state and military secrets, so it is definitely well-tested, stable and secure enough to manage

[Qemu-devel] [PATCH for-2.4 5/5] Documentation: Document IRC char driver

With the IRC char driver being fully functional, it now needs to be exposed to the broad audience. Adding documentation has been proven a valuable step in this process. Regarding the next steps, mouth-to-mouth propaganda will probably suffice, considering that IRC is objectively the single best ch

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

On 04/01/2015 03:33 AM, Markus Armbruster wrote: >>> Longhand: >>> >>> # mandatory >>> 'name': { 'type': 'str' } >>> # optional, with a default >>> 'flag': { 'type': 'bool', 'default': true } >>> # optional, no default >>> 'string': { 'type': 'str', 'default': null } >>> >>

Re: [Qemu-devel] [PULL 0/5] Bugfixes for 2.3.0-rc2

On 1 April 2015 at 11:29, Paolo Bonzini wrote: > The following changes since commit 033a20359aaf93f4d8aa2be12558901e8e028baa: > > Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' > into staging (2015-03-31 12:12:23 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] E5-2620v2 - emulation stop error

On Wed, Apr 1, 2015 at 2:49 PM, Radim Krčmář wrote: > 2015-03-31 21:23+0300, Andrey Korolyov: >> On Tue, Mar 31, 2015 at 9:04 PM, Bandan Das wrote: >> > Bandan Das writes: >> >> Andrey Korolyov writes: >> >> ... >> >>> http://xdel.ru/downloads/kvm-e5v2-issue/another-tracepoint-fail-with-apicv.d

Re: [Qemu-devel] [PULL 5/5] Revert "exec: Respect as_tranlsate_internal length clamp"

On 04/01/2015 04:29 AM, Paolo Bonzini wrote: > This reverts commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459. Which means the typo in that commit message (tranlsate) is perpetuated here too. Cute. Thankfully doesn't hurt anything other than bothering OCD editors (does that mean I'm becoming one?

  1   2   3   >