Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support

2015-03-27 Thread Alberto Garcia
On Fri, Mar 27, 2015 at 09:11:19AM +0800, Fam Zheng wrote: > > Hmm... this actually breaks the new test because now BDS are > > required to have an AioContext attached when they're added to a > > group, which doesn't happen in qtest: > > > > bdrv = bdrv_new(); > > throttle_group_register_

[Qemu-devel] Use of QERR_ macros and error classes (was: [RFC PATCH COLO v2 06/13] NBD client: implement block driver interfaces for block replication)

2015-03-27 Thread Markus Armbruster
Fam Zheng writes: > On Thu, 03/26 15:32, Wen Congyang wrote: >> On 03/26/2015 03:21 PM, Fam Zheng wrote: >> > On Wed, 03/25 17:36, Wen Congyang wrote: >> >> Signed-off-by: Wen Congyang >> >> Signed-off-by: zhanghailiang >> >> Signed-off-by: Gonglei >> >> --- >> >> block/nbd.c | 49 +++

Re: [Qemu-devel] [PATCH v5 16/28] qapi: Better error messages for duplicated expressions

2015-03-27 Thread Markus Armbruster
One more... Eric Blake writes: [...] > diff --git a/scripts/qapi.py b/scripts/qapi.py > index 90eb3bc..5d0dc91 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.py [...] > @@ -560,12 +585,22 @@ def type_name(name): > return c_list_type(name[0]) > return name > > -enum_types = []

[Qemu-devel] Need some helps

2015-03-27 Thread Qiang Guan
Hi, I am working on the old version QEMU which is still using dyngen with my own constraints. I want to know how I can get the guest instruction to intermediate code mapping. Are there any docs? For example: For this guest instruction add [ebp + 0x08], edx It will be split into multiple micro-o

Re: [Qemu-devel] [PATCH v5 20/28] qapi: More rigourous checking of types

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > Now that we know every expression is valid with regards to > its keys, we can add further tests that those keys refer to > valid types. With this patch, all uses of a type (the 'data': > of command, type, union, alternate, and event; the 'returns': > of command; the 'base':

Re: [Qemu-devel] [PATCH v4 0/7] Block Throttle Group Support

2015-03-27 Thread Fam Zheng
On Fri, 03/27 08:23, Alberto Garcia wrote: > On Fri, Mar 27, 2015 at 09:11:19AM +0800, Fam Zheng wrote: > > > > Hmm... this actually breaks the new test because now BDS are > > > required to have an AioContext attached when they're added to a > > > group, which doesn't happen in qtest: > > > > >

Re: [Qemu-devel] [PATCH v5 21/28] qapi: Require valid names

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > Previous commits demonstrated that the generator overlooked various > bad naming situations: > - types, commands, and events need a valid name > - union and alternate branches cannot be marked optional > > The set of valid names includes [a-zA-Z0-9._-] (where '.' is > useful

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Stefan Hajnoczi
On Thu, Mar 26, 2015 at 11:29:43AM +0100, Juan Quintela wrote: > Wen Congyang wrote: > > On 03/25/2015 05:50 PM, Juan Quintela wrote: > >> zhanghailiang wrote: > >>> Hi all, > >>> > >>> We found that, sometimes, the content of VM's memory is > >>> inconsistent between Source side and Destination

Re: [Qemu-devel] [PATCH for-2.3 1/4] virtio-ccw: fix range check for SET_VQ

2015-03-27 Thread Christian Borntraeger
Am 26.03.2015 um 16:35 schrieb Cornelia Huck: > VIRTIO_PCI_QUEUE_MAX is already too big; a malicious guest would be > able to trigger a write beyond the VirtQueue structure. > > Cc: qemu-sta...@nongnu.org > Reviewed-by: David Hildenbrand > Signed-off-by: Cornelia Huck Acked-by: Christian Borntra

Re: [Qemu-devel] [PATCH for-2.3 2/4] virtio-ccw: range check in READ_VQ_CONF

2015-03-27 Thread Christian Borntraeger
Am 26.03.2015 um 16:36 schrieb Cornelia Huck: > Processing for READ_VQ_CONF needs to check whether the requested queue > value is actually in the supported range and post a channel program > check if not. > > Cc: qemu-sta...@nongnu.org > Reviewed-by: David Hildenbrand > Signed-off-by: Cornelia Hu

[Qemu-devel] block-commit & dropping privs

2015-03-27 Thread Michael Tokarev
Hello. I tried to experiment with block-commit command, which propagates changes accumulated in an overlay (qcow2) block image file back to the base image file. And immediately faced a problem. All my VMs are run chrooted into an empty dir and with low-priv user (using -runsa and -chroot options

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Wen Congyang
On 03/27/2015 04:56 PM, Stefan Hajnoczi wrote: > On Thu, Mar 26, 2015 at 11:29:43AM +0100, Juan Quintela wrote: >> Wen Congyang wrote: >>> On 03/25/2015 05:50 PM, Juan Quintela wrote: zhanghailiang wrote: > Hi all, > > We found that, sometimes, the content of VM's memory is >

Re: [Qemu-devel] [PATCH v5 22/28] qapi: Whitelist commands that don't return dictionary

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > ...or an array of dictionaries. Although we have to cater to > existing commands, returning a non-dictionary means the command > is not extensible (no new name/value pairs can be added if more > information must be returned in parallel). By making the > whitelist explicit,

Re: [Qemu-devel] [PATCH 14/22] exec: only check relevant bitmaps for cleanliness

2015-03-27 Thread Paolo Bonzini
On 27/03/2015 07:10, Fam Zheng wrote: >> static inline bool cpu_physical_memory_range_includes_clean(ram_addr_t >> start, >> -ram_addr_t >> length) >> +ram_addr_t >> length,

Re: [Qemu-devel] [PATCH 17/22] bitmap: add atomic test and clear

2015-03-27 Thread Paolo Bonzini
On 27/03/2015 07:37, Fam Zheng wrote: > On Thu, 03/26 18:38, Paolo Bonzini wrote: >> From: Stefan Hajnoczi >> >> The new bitmap_test_and_clear_atomic() function clears a range and >> returns whether or not the bits were set. >> >> Signed-off-by: Stefan Hajnoczi >> Message-Id: <1417519399-3166-3

[Qemu-devel] [PATCH v5 1/7] docs: update documentation for memory hot unplug

2015-03-27 Thread Zhu Guihua
Add specification about how to use memory hot unplug, and add a flow diagram to explain memory hot unplug process. Signed-off-by: Zhu Guihua --- docs/memory-hotplug.txt | 24 docs/specs/acpi_mem_hotplug.txt | 16 +++- 2 files changed, 35 insertions(+)

[Qemu-devel] [PATCH v5 0/7] QEMU memory hot unplug support

2015-03-27 Thread Zhu Guihua
Memory hot unplug are both asynchronous procedures. When the unplug operation happens, unplug request cb is called first. And when guest OS finished handling unplug, unplug cb will be called to do the real removal of device. v5: -reorganize the patchset -add documentation to understand patch eas

[Qemu-devel] [PATCH v5 7/7] qmp-event: add event notification for memory hot unplug error

2015-03-27 Thread Zhu Guihua
When memory hot unplug fails, this patch adds support to send QMP event to notify mgmt about this failure. Signed-off-by: Zhu Guihua --- docs/qmp/qmp-events.txt | 17 + hw/acpi/memory_hotplug.c | 8 +++- monitor.c| 1 + qapi/event.json | 14 +++

[Qemu-devel] [PATCH v5 2/7] acpi, mem-hotplug: add acpi_memory_slot_status() to get MemStatus

2015-03-27 Thread Zhu Guihua
From: Tang Chen Add a new API named acpi_memory_slot_status() to obtain a single memory slot status. Doing this is because this procedure will be used by other functions in the next coming patches. Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua --- hw/acpi/memory_hotplug.c | 34 ++

[Qemu-devel] [PATCH v5 4/7] acpi, mem-hotplug: add unplug cb for memory device

2015-03-27 Thread Zhu Guihua
From: Tang Chen This patch adds unplug cb for memory device. It resets memory status "is_enabled" in acpi_memory_unplug_cb(), removes the corresponding memory region, unregisters vmstate, and unparents the object. Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua --- hw/acpi/ich9.c

[Qemu-devel] [PATCH v5 3/7] acpi, mem-hotplug: add unplug request cb for memory device

2015-03-27 Thread Zhu Guihua
From: Tang Chen This patch adds unplug request cb for memory device, and adds the is_removing boolean field to MemStatus. This field is used to indicate whether the memory slot is being removed. This field is set to true in acpi_memory_unplug_request_cb(). Signed-off-by: Tang Chen Signed-off-by

[Qemu-devel] [PATCH v5 6/7] acpi: add hardware implementation for memory hot unplug

2015-03-27 Thread Zhu Guihua
- implements QEMU hardware part of memory hot unplug protocol described at "docs/spec/acpi_mem_hotplug.txt" - handles memory remove notification event - handles device eject notification Signed-off-by: Zhu Guihua --- docs/specs/acpi_mem_hotplug.txt | 16 +--- hw/acpi/memory_hotpl

[Qemu-devel] [PATCH v5 5/7] acpi: extend aml_field() to support UpdateRule

2015-03-27 Thread Zhu Guihua
The flags field is declared with default update rule 'Preserve', this patch is to extend aml_field() to support UpdateRule so that we can specify different value to UpdateRule for different field. Signed-off-by: Zhu Guihua --- hw/acpi/aml-build.c | 4 +++- hw/i386/acpi-build.c|

Re: [Qemu-devel] [PATCH v5 23/28] qapi: More rigorous checking for type safety bypass

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > Now that we have a way to validate every type, we can also be > stricter about enforcing that callers that want to bypass > type safety in generated code. Prior to this patch, it didn't > matter what value was associated with the key 'gen', but it > looked odd that 'gen':'ye

[Qemu-devel] [PATCH v2] spapr: populate ibm,loc-code

2015-03-27 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Introduce an hcall to populate ibm,loc-code. 1) PCI passthru

Re: [Qemu-devel] [PATCH v5 24/28] qapi: Merge UserDefTwo and UserDefNested in tests

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > In the testsuite, UserDefTwo and UserDefNested were identical > types other than the member names. Reduce code duplication by > having just one type, and choose names that also favor reuse. > This will also make it easier for a later patch to get rid of > inline nested types

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-27 Thread Ian Campbell
On Fri, 2015-03-27 at 09:29 +0800, Chen, Tiejun wrote: > On 2015/3/26 18:06, Ian Campbell wrote: > > On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: > >>> Hrm, OK. I suppose we can live with autodetect and igd both meaning igd > >>> and whoever adds a new type will have to remember to add a

Re: [Qemu-devel] [PATCH] tcg: optimise memory layout of TCGTemp

2015-03-27 Thread Alex Bennée
Emilio G. Cota writes: > This brings down the size of the struct from 56 to 32 bytes on 64-bit, > and to 16 bytes on 32-bit. Have you been able to measure any performance improvement with these new structures? In theory, if aligned with cache lines, performance should improve but real numbers w

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Stefan Hajnoczi
On Fri, Mar 27, 2015 at 9:14 AM, Wen Congyang wrote: > On 03/27/2015 04:56 PM, Stefan Hajnoczi wrote: >> On Thu, Mar 26, 2015 at 11:29:43AM +0100, Juan Quintela wrote: >>> Wen Congyang wrote: On 03/25/2015 05:50 PM, Juan Quintela wrote: > zhanghailiang wrote: >> Hi all, >> >

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Wen Congyang
On 03/27/2015 05:57 PM, Stefan Hajnoczi wrote: > On Fri, Mar 27, 2015 at 9:14 AM, Wen Congyang wrote: >> On 03/27/2015 04:56 PM, Stefan Hajnoczi wrote: >>> On Thu, Mar 26, 2015 at 11:29:43AM +0100, Juan Quintela wrote: Wen Congyang wrote: > On 03/25/2015 05:50 PM, Juan Quintela wrote: >>

Re: [Qemu-devel] [RFC 00/10] MultiThread TCG.

2015-03-27 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > Hi everybody, > > This is the start of our work on TCG multithread. It's been a while since the first RFC are we likely to see a v2 of the patch series any time soon? > > We send it for comment to be sure we are taking the right dir

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Stefan Hajnoczi
On Fri, Mar 27, 2015 at 10:05 AM, Wen Congyang wrote: > On 03/27/2015 05:57 PM, Stefan Hajnoczi wrote: >> On Fri, Mar 27, 2015 at 9:14 AM, Wen Congyang wrote: >>> On 03/27/2015 04:56 PM, Stefan Hajnoczi wrote: On Thu, Mar 26, 2015 at 11:29:43AM +0100, Juan Quintela wrote: > Wen Congyang

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread zhanghailiang
On 2015/3/26 11:52, Li Zhijian wrote: On 03/26/2015 11:12 AM, Wen Congyang wrote: On 03/25/2015 05:50 PM, Juan Quintela wrote: zhanghailiang wrote: Hi all, We found that, sometimes, the content of VM's memory is inconsistent between Source side and Destination side when we check it just aft

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-27 Thread Andrey Korolyov
On Fri, Mar 27, 2015 at 12:03 AM, Bandan Das wrote: > Radim Krčmář writes: > >> 2015-03-26 21:24+0300, Andrey Korolyov: >>> On Thu, Mar 26, 2015 at 8:40 PM, Radim Krčmář wrote: >>> > 2015-03-26 20:08+0300, Andrey Korolyov: >>> >> KVM internal error. Suberror: 2 >>> >> extra data[0]: 80ef >>>

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/3/26 11:52, Li Zhijian wrote: > >On 03/26/2015 11:12 AM, Wen Congyang wrote: > >>On 03/25/2015 05:50 PM, Juan Quintela wrote: > >>>zhanghailiang wrote: > Hi all, > > We found that, sometimes, the content of VM's memory

[Qemu-devel] [PULL for-2.3 0/4] Block patches

2015-03-27 Thread Stefan Hajnoczi
The following changes since commit 4ad9e2b36e1e00fe5b96c3448ecd673e11c4d6d8: Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20150326-1' into staging (2015-03-26 18:35:09 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request fo

[Qemu-devel] [PULL for-2.3 2/4] block: Fix unaligned zero write

2015-03-27 Thread Stefan Hajnoczi
From: Fam Zheng If the zero write is not aligned, bdrv_co_do_pwritev will segfault because of accessing to the NULL qiov passed in by bdrv_co_write_zeroes. Fix this by allocating a local qiov in bdrv_co_do_pwritev if the request is not aligned. (In this case the padding iovs are necessary anyway,

[Qemu-devel] [PULL for-2.3 1/4] nvme: Fix unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)

2015-03-27 Thread Stefan Hajnoczi
From: Stefan Weil The shift operation on nlb gives a 32 bit result if no type cast is applied. This bug was reported by Coverity. Signed-off-by: Stefan Weil Message-id: 1426348844-8793-1-git-send-email...@weilnetz.de Signed-off-by: Stefan Hajnoczi --- hw/block/nvme.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL for-2.3 4/4] block: Document blockdev-add's immaturity

2015-03-27 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-id: 1426858337-21423-1-git-send-email-arm...@redhat.com Signed-off-by: Stefan Hajnoczi --- qapi/block-core.json | 4 qmp-commands.hx | 4 2 files changed, 8 insertions(+) diff --git a/qapi

[Qemu-devel] [PULL for-2.3 3/4] qemu-iotests: Test unaligned 4k zero write

2015-03-27 Thread Stefan Hajnoczi
From: Fam Zheng Signed-off-by: Fam Zheng Message-id: 1427160230-4489-3-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/033 | 47 +- tests/qemu-iotests/033.out | 26 + 2 files changed, 5

Re: [Qemu-devel] [PATCH v5 25/28] qapi: Drop tests for inline nested structs

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > A future patch will be using a 'name':{dictionary} entry in the > QAPI schema to specify a default value for an optional argument; > but existing use of inline nested structs conflicts with that goal. I'm okay with this rationale as is, just want to mention the more general

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Juan Quintela
Wen Congyang wrote: > On 03/27/2015 04:56 PM, Stefan Hajnoczi wrote: >> On Thu, Mar 26, 2015 at 11:29:43AM +0100, Juan Quintela wrote: >>> Wen Congyang wrote: On 03/25/2015 05:50 PM, Juan Quintela wrote: > zhanghailiang wrote: >> Hi all, >> >> We found that, sometimes, the c

Re: [Qemu-devel] [PATCH v5 26/28] qapi: Drop inline nested type in query-version

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > A future patch will be using a 'name':{dictionary} entry in the > QAPI schema to specify a default value for an optional argument; > but existing use of inline nested structs conflicts with that goal. > This patch fixes one of only two commands relying on nested > types, by b

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Juan Quintela
Wen Congyang wrote: > On 03/27/2015 05:57 PM, Stefan Hajnoczi wrote: You must use -drive cache=none if you want to use live migration. It should not directly affect memory during migration though. >>> >>> Otherwise, what will happen? If the user doesn't use cache=none, and >>> tries to

Re: [Qemu-devel] [RFC 00/10] MultiThread TCG.

2015-03-27 Thread Frederic Konrad
Hi, Yes a v2 will come soon. Actually I'm trying to unbreak GDB stub and a strange segfault with smp > 2. Fred On 27/03/2015 11:08, Alex Bennée wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic Hi everybody, This is the start of our work on TCG multithread. It's been a while

Re: [Qemu-devel] [PATCH v5 27/28] qapi: Drop inline nested types in query-pci

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > A future patch will be using a 'name':{dictionary} entry in the > QAPI schema to specify a default value for an optional argument; > but existing use of inline nested structs conflicts with that goal. > This patch fixes one of only two commands relying on nested > types, by b

Re: [Qemu-devel] [PATCH v5 28/28] qapi: Drop support for inline nested types

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > A future patch will be using a 'name':{dictionary} entry in the > QAPI schema to specify a default value for an optional argument; > but existing use of inline nested structs conflicts with that goal. > Now that all commands have been changed to avoid inline nested > structs,

Re: [Qemu-devel] [v6 08/14] migration: Add the core code of multi-thread compression

2015-03-27 Thread Juan Quintela
Liang Li wrote: > Implement the core logic of the multiple thread compression. At this > point, multiple thread compression can't co-work with xbzrle yet. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Coming back to here, as we have the full code. > --- > arch_init.c | 184 > +

[Qemu-devel] [PATCH 00/12 v9] tilegx: Firstly add tilegx feature for linux-user

2015-03-27 Thread Chen Gang
After load elf64 binary, qemu tilegx can finish executing the first system call (uname) successfully in _dl_discover_osversion(), and return to __libc_start_main(). Chen Gang (12): linux-user: tilegx: Firstly add architecture related features linux-user: tilegx: Add target features support wi

Re: [Qemu-devel] [PATCH v5 17/45] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

2015-03-27 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Thu, Mar 26, 2015 at 04:33:28PM +, Dr. David Alan Gilbert wrote: > > (Only replying to some of the items in this mail - the others I'll get > > to another time). > > > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Wed, F

[Qemu-devel] [PATCH 01/12 v9] linux-user: tilegx: Firstly add architecture related features

2015-03-27 Thread Chen Gang
They are based on Linux kernel tilegx architecture for 64 bit binary, also based on tilegx ABI reference document. Signed-off-by: Chen Gang --- linux-user/tilegx/syscall.h| 80 linux-user/tilegx/syscall_nr.h | 278 linux-user/tilegx/term

[Qemu-devel] [PATCH 03/12 v9] linux-user: Support tilegx architecture in syscall

2015-03-27 Thread Chen Gang
Add tilegx architecture in "syscall_defs.h", all related features (ioctrl, and stat) are based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- linux-user/syscall_defs.h | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 02/12 v9] linux-user: tilegx: Add target features support within qemu

2015-03-27 Thread Chen Gang
They are for target features within qemu which independent from outside. Signed-off-by: Chen Gang --- linux-user/tilegx/target_cpu.h | 35 +++ linux-user/tilegx/target_signal.h | 28 ++ linux-user/tilegx/target_structs.h | 48 +

Re: [Qemu-devel] [Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

2015-03-27 Thread Juan Quintela
zhanghailiang wrote: > On 2015/3/26 11:52, Li Zhijian wrote: >> On 03/26/2015 11:12 AM, Wen Congyang wrote: >>> On 03/25/2015 05:50 PM, Juan Quintela wrote: zhanghailiang wrote: > Hi all, > > We found that, sometimes, the content of VM's memory is > inconsistent between Sourc

[Qemu-devel] [PATCH 05/12 v9] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx

2015-03-27 Thread Chen Gang
For tilegx, several syscall macros are not supported, so switch them to avoid building break. Signed-off-by: Chen Gang --- linux-user/syscall.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user

[Qemu-devel] [PATCH 07/12 v9] target-tilegx: Add helper features for linux-user

2015-03-27 Thread Chen Gang
For supporting linux-user system call, tilegx need support exception helper features for it. Signed-off-by: Chen Gang --- target-tilegx/helper.c | 31 +++ target-tilegx/helper.h | 1 + 2 files changed, 32 insertions(+) create mode 100644 target-tilegx/helper.c crea

[Qemu-devel] [PATCH 08/12 v9] target-tilegx: Add opcode basic implementation for tilegx

2015-03-27 Thread Chen Gang
It is from Tilera Corporation, and copied from Linux kernel "arch/tile/ include/uapi/arch/opcode_tilegx.h". Signed-off-by: Chen Gang --- target-tilegx/opcode_tilegx.h | 1406 + 1 file changed, 1406 insertions(+) create mode 100644 target-tilegx/opcode_til

[Qemu-devel] [PATCH 09/12 v9] target-tilegx: Finish processing bundle and preparing decoding pipes

2015-03-27 Thread Chen Gang
Finish processing tilegx bundle, and reach to related pipes. Signed-off-by: Chen Gang --- target-tilegx/translate.c | 515 ++ 1 file changed, 515 insertions(+) create mode 100644 target-tilegx/translate.c diff --git a/target-tilegx/translate.c b/targ

Re: [Qemu-devel] [RFC 1/5] memory: Define API for MemoryRegionOps to take attrs and return status

2015-03-27 Thread Peter Maydell
On 16 March 2015 at 17:20, Peter Maydell wrote: > Define an API so that devices can register MemoryRegionOps whose read > and write callback functions are passed an arbitrary pointer to some > transaction attributes and can return a success-or-failure status code. > This will allow us to model dev

[Qemu-devel] [PATCH 10/12 v9] target-tilegx: Add TILE-Gx building files

2015-03-27 Thread Chen Gang
Add related configuration, make files for tilegx. Now, qemu tilegx can pass building. Signed-off-by: Chen Gang --- configure | 3 +++ default-configs/tilegx-linux-user.mak | 1 + target-tilegx/Makefile.objs | 1 + 3 files changed, 5 insertions(+) create mod

Re: [Qemu-devel] [PATCH 2/5] qapi: Clean up documentation of alternate mappings

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > QObject is an internal coding concept and requires the reader to > reverse engineer the mapping; it is nicer to be explicit and call > out specific JSON types. > > Signed-off-by: Eric Blake > --- > docs/qapi-code-gen.txt | 24 ++-- > 1 file changed, 14 i

[Qemu-devel] [PATCH 11/12 v9] target-tilegx: Decoding pipes to support finish running 1st system call

2015-03-27 Thread Chen Gang
For the instructions which need tcg generation, the decoding functions return directly, or they will direct to the exception. Signed-off-by: Chen Gang --- target-tilegx/translate.c | 704 ++ 1 file changed, 704 insertions(+) diff --git a/target-tilegx

Re: [Qemu-devel] [PATCH 0/5] qapi doc cleanups

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > Markus had some nice review comments on my earlier patch: > https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05310.html > > Depends on the full series "[PATCH v5 00/28] drop qapi nested structs", > although if I have to respin that, I'll probably just squash the > app

[Qemu-devel] [PATCH 12/12 v9] target-tilegx: Generate tcg instructions to execute to 1st system call

2015-03-27 Thread Chen Gang
Generate related tcg instructions, and qemu tilegx can run to 1st system call (uname) successfully in _dl_discover_osversion(), and return to __libc_start_main(). Signed-off-by: Chen Gang --- target-tilegx/translate.c | 543 ++ 1 file changed, 543 ins

[Qemu-devel] [PATCH 06/12 v9] target-tilegx: Add cpu basic features for linux-user

2015-03-27 Thread Chen Gang
It implements minimized cpu features for linux-user. Signed-off-by: Chen Gang --- target-tilegx/cpu-qom.h | 73 target-tilegx/cpu.c | 149 target-tilegx/cpu.h | 94 ++ 3 files changed,

[Qemu-devel] [PATCH 04/12 v9] linux-user: Support tilegx architecture in linux-user

2015-03-27 Thread Chen Gang
Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- include/elf.h| 2 ++ linux-user/elfload.c | 23 ++ linux-user/main.c| 86 +

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-27 Thread Andrey Korolyov
On Thu, Mar 26, 2015 at 11:40 PM, Radim Krčmář wrote: > 2015-03-26 21:24+0300, Andrey Korolyov: >> On Thu, Mar 26, 2015 at 8:40 PM, Radim Krčmář wrote: >> > 2015-03-26 20:08+0300, Andrey Korolyov: >> >> KVM internal error. Suberror: 2 >> >> extra data[0]: 80ef >> >> extra data[1]: 8b0d >>

[Qemu-devel] [PULL for-2.3 0/1] Net patches

2015-03-27 Thread Stefan Hajnoczi
The following changes since commit 4ad9e2b36e1e00fe5b96c3448ecd673e11c4d6d8: Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20150326-1' into staging (2015-03-26 18:35:09 +) are available in the git repository at: git://github.com/stefanha/qemu.git net-pull-request for you t

[Qemu-devel] [PULL for-2.3 1/1] hw/net/e1000: fix integer endianness

2015-03-27 Thread Stefan Hajnoczi
From: Shannon Zhao It's detected by coverity.In is_vlan_packet s->mac_reg[VET] is unsigned int but is dereferenced as a narrower unsigned short. This may lead to unexpected results depending on machine endianness. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Message-id: 1426224119-8

[Qemu-devel] [RESEND PULL for-2.3 1/1] hw/net/e1000: fix integer endianness

2015-03-27 Thread Stefan Hajnoczi
From: Shannon Zhao It's detected by coverity.In is_vlan_packet s->mac_reg[VET] is unsigned int but is dereferenced as a narrower unsigned short. This may lead to unexpected results depending on machine endianness. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Message-id: 1426224119-8

[Qemu-devel] [RESEND PULL for-2.3 0/1] Net patches

2015-03-27 Thread Stefan Hajnoczi
The following changes since commit 4ad9e2b36e1e00fe5b96c3448ecd673e11c4d6d8: Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20150326-1' into staging (2015-03-26 18:35:09 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for

Re: [Qemu-devel] [RFC 1/5] memory: Define API for MemoryRegionOps to take attrs and return status

2015-03-27 Thread Edgar E. Iglesias
On Fri, Mar 27, 2015 at 10:58:01AM +, Peter Maydell wrote: > On 16 March 2015 at 17:20, Peter Maydell wrote: > > Define an API so that devices can register MemoryRegionOps whose read > > and write callback functions are passed an arbitrary pointer to some > > transaction attributes and can ret

Re: [Qemu-devel] [RFC 1/5] memory: Define API for MemoryRegionOps to take attrs and return status

2015-03-27 Thread Paolo Bonzini
On 27/03/2015 13:02, Edgar E. Iglesias wrote: > On Fri, Mar 27, 2015 at 10:58:01AM +, Peter Maydell wrote: >> On 16 March 2015 at 17:20, Peter Maydell wrote: >>> Define an API so that devices can register MemoryRegionOps whose read >>> and write callback functions are passed an arbitrary poi

Re: [Qemu-devel] [RFC 1/5] memory: Define API for MemoryRegionOps to take attrs and return status

2015-03-27 Thread Peter Maydell
On 27 March 2015 at 12:02, Edgar E. Iglesias wrote: > On Fri, Mar 27, 2015 at 10:58:01AM +, Peter Maydell wrote: >> So I was looking at how this would actually get plumbed through >> the memory subsystem code, and there are some awkwardnesses >> with this simple enum approach. In particular, f

Re: [Qemu-devel] [PULL for-2.3 0/4] Block patches

2015-03-27 Thread Peter Maydell
On 27 March 2015 at 10:20, Stefan Hajnoczi wrote: > The following changes since commit 4ad9e2b36e1e00fe5b96c3448ecd673e11c4d6d8: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20150326-1' into > staging (2015-03-26 18:35:09 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v5 06/28] qapi: Add some union tests

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > On 03/26/2015 07:18 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Demonstrate that the qapi generator doesn't deal well with unions >>> that aren't up to par. Later patches will update the expected >>> reseults as the generator is made stricter. >>> >>> Of parti

Re: [Qemu-devel] [RFC 1/5] memory: Define API for MemoryRegionOps to take attrs and return status

2015-03-27 Thread Edgar E. Iglesias
On Fri, Mar 27, 2015 at 01:10:07PM +0100, Paolo Bonzini wrote: > > > On 27/03/2015 13:02, Edgar E. Iglesias wrote: > > On Fri, Mar 27, 2015 at 10:58:01AM +, Peter Maydell wrote: > >> On 16 March 2015 at 17:20, Peter Maydell wrote: > >>> Define an API so that devices can register MemoryRegion

Re: [Qemu-devel] [PATCH v5 10/28] qapi: Segregate anonymous unions into alternates in generator

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > On 03/26/2015 08:47 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Special-casing 'discriminator == {}' for handling anonymous unions >>> is getting awkward; since this particular type is not always a >>> dictionary on the wire, it is easier to treat it as a comp

Re: [Qemu-devel] [PATCH v5 13/28] qapi: Add some expr tests

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > On 03/26/2015 09:55 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Demonstrate that the qapi generator doesn't deal well with >>> expressions that aren't up to par. Later patches will improve >>> the expected results as the generator is made stricter. Only >>> o

Re: [Qemu-devel] [PATCH v5 18/28] qapi: Unify type bypass and add tests

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > On 03/26/2015 11:38 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> For a few QMP commands, we are forced to pass an arbitrary type >>> without tracking it properly in QAPI. Among the existing clients, >>> this unnamed type was spelled 'dict', 'visitor', and '**'

Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > After several months of sitting on this, I finally made progress > on it. Let's get it in 2.4, and I promise to kick out a v6 > (if needed) with much less delay. > > We want to eventually allow qapi defaults, by making: > 'data':{'*flag':'bool'} > shorthand for: > 'data':{

Re: [Qemu-devel] [RFC 1/5] memory: Define API for MemoryRegionOps to take attrs and return status

2015-03-27 Thread Paolo Bonzini
On 27/03/2015 13:32, Edgar E. Iglesias wrote: >>> Is this related to masters relying on the memory frameworks magic >>> handling of unaliged accesses? >> >> Not necessarily, you can get the same just by doing a large write that >> spans multiple MemoryRegions. See the loop in address_space_rw. >

Re: [Qemu-devel] [RESEND PULL for-2.3 0/1] Net patches

2015-03-27 Thread Peter Maydell
On 27 March 2015 at 11:59, Stefan Hajnoczi wrote: > The following changes since commit 4ad9e2b36e1e00fe5b96c3448ecd673e11c4d6d8: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20150326-1' into > staging (2015-03-26 18:35:09 +) > > are available in the git repository at: > >

[Qemu-devel] [Bug 1392504] Re: libvirt not relabeling devices on USB Passthrough

2015-03-27 Thread Kelvin Middleton
...actually are you talking kernel or the full 15.04 pre-release? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1392504 Title: libvirt not relabeling devices on USB Passthrough Status in QEMU: N

[Qemu-devel] [Bug 1392504] Re: libvirt not relabeling devices on USB Passthrough

2015-03-27 Thread Kelvin Middleton
I'm running an ACS patched linux mainline 3.18 as well as Ubuntu 14.10 stock. Haven't tested the Ubuntu 15.04 stock but will grab the debs and confirm. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

Re: [Qemu-devel] [RFC 1/5] memory: Define API for MemoryRegionOps to take attrs and return status

2015-03-27 Thread Edgar E. Iglesias
On Fri, Mar 27, 2015 at 02:16:53PM +0100, Paolo Bonzini wrote: > > > On 27/03/2015 13:32, Edgar E. Iglesias wrote: > >>> Is this related to masters relying on the memory frameworks magic > >>> handling of unaliged accesses? > >> > >> Not necessarily, you can get the same just by doing a large wri

Re: [Qemu-devel] [PATCH for-2.3 3/4] s390x: do not include ram_addr.h

2015-03-27 Thread Thomas Huth
Am Thu, 26 Mar 2015 16:36:01 +0100 schrieb Cornelia Huck : > From: Paolo Bonzini > > ram_addr.h is an internal interface and it is not needed anyway by > hw/s390x/ipl.c. > > Cc: Christian Borntraeger > Signed-off-by: Paolo Bonzini > Message-Id: <1427295389-5054-1-git-send-email-pbonz...@redha

[Qemu-devel] unhandled signal 11

2015-03-27 Thread Catalin Vasile
How can I debug errors like this: qemu-system-ppc[2273]: unhandled signal 11 at 0008 nip 1007ed08 lr 103404e0 code 30001 ? I know it is a ppc binary, but I am asking a general question. >From a first impression it looks a little like Linux Kernel Oops messages. How can I actually find out the l

Re: [Qemu-devel] [PATCH] fix assertion in "info memory-devices" if memdev isn't accessible

2015-03-27 Thread Igor Mammedov
On Thu, 26 Mar 2015 21:33:19 +0100 Paolo Bonzini wrote: > > > On 26/03/2015 17:42, Igor Mammedov wrote: > > +mdevid = object_property_get_str(OBJECT(dimm->hostmem), "id", > > + &error_abort); > > +mdevpath = g_strdup_printf("/o

Re: [Qemu-devel] [PATCH] fix assertion in "info memory-devices" if memdev isn't accessible

2015-03-27 Thread Igor Mammedov
On Thu, 26 Mar 2015 16:26:17 -0400 Luiz Capitulino wrote: > On Thu, 26 Mar 2015 15:59:25 -0400 > Luiz Capitulino wrote: > > > On Thu, 26 Mar 2015 16:42:54 + > > Igor Mammedov wrote: > > > > > showing a memory device whose memdev is removed leads to an assert: > > > > > > (qemu) object_ad

Re: [Qemu-devel] unhandled signal 11

2015-03-27 Thread Peter Maydell
On 27 March 2015 at 14:09, Catalin Vasile wrote: > How can I debug errors like this: > qemu-system-ppc[2273]: unhandled signal 11 at 0008 nip 1007ed08 lr > 103404e0 code 30001 > ? > I know it is a ppc binary, but I am asking a general question. > From a first impression it looks a little like

Re: [Qemu-devel] [PATCH] fix assertion in "info memory-devices" if memdev isn't accessible

2015-03-27 Thread Igor Mammedov
On Thu, 26 Mar 2015 21:33:19 +0100 Paolo Bonzini wrote: > > > On 26/03/2015 17:42, Igor Mammedov wrote: > > +mdevid = object_property_get_str(OBJECT(dimm->hostmem), "id", > > + &error_abort); > > +mdevpath = g_strdup_printf("/o

Re: [Qemu-devel] [PATCH v4 1/2] qom: Add can_be_deleted callback to UserCreatableClass

2015-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2015 13:36:11 +0800 Lin Ma wrote: > If backends implement the can_be_deleted and it returns false, > Then the qmp_object_del won't delete the given backends. > > Signed-off-by: Lin Ma > --- > include/qom/object_interfaces.h | 14 ++ > qmp.c

Re: [Qemu-devel] [PATCH v4 2/2] hostmem: Prevent removing an in-use memory backend object

2015-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2015 13:36:12 +0800 Lin Ma wrote: > showing a memory device whose memdev is removed leads an assert: > > (qemu) object_add memory-backend-ram,id=ram0,size=128M > (qemu) device_add pc-dimm,id=d0,memdev=ram0 > (qemu) object_del ram0 > (qemu) info memory-devices > ** > ERROR:qom/obje

Re: [Qemu-devel] [PATCH v4 0/2] Add generic can_be_deleted to UserCreatableClass.

2015-03-27 Thread Igor Mammedov
On Fri, 27 Mar 2015 13:36:10 +0800 Lin Ma wrote: > The patchset adds a generic can_be_deleted callback to UserCreatableClass. > It prevents removing a usercreatable object if the callback returns false. > > Backends could implement the callback if it shoudn't be removed while it's > in use. > >

Re: [Qemu-devel] block-commit & dropping privs

2015-03-27 Thread Eric Blake
On 03/27/2015 03:07 AM, Michael Tokarev wrote: > Hello. > > I tried to experiment with block-commit command, which propagates > changes accumulated in an overlay (qcow2) block image file back to > the base image file. > > And immediately faced a problem. All my VMs are run chrooted into > an emp

Re: [Qemu-devel] [PATCH v5 7/7] qmp-event: add event notification for memory hot unplug error

2015-03-27 Thread Eric Blake
On 03/27/2015 03:20 AM, Zhu Guihua wrote: > When memory hot unplug fails, this patch adds support to send > QMP event to notify mgmt about this failure. > > Signed-off-by: Zhu Guihua > --- > docs/qmp/qmp-events.txt | 17 + > hw/acpi/memory_hotplug.c | 8 +++- > monitor.c

[Qemu-devel] [Bug 1437367] [NEW] Qemu guest fails to write files with raw disk (like \\.\PhysicalDrive1) on Windows host.

2015-03-27 Thread hiroaki
Public bug reported: Qemu guest fails to write files with specifing raw disk like \\.\PhysicalDrive1 full command line is below. qemu-sysytem-i386.exe -kernel bzImage -drive file=rootfs.ext2,index=0,if=scsi -append root=/dev/sda -drive file=\\.\PhysicalDrive1,index=1,if=scsi I found the reason i

Re: [Qemu-devel] [PATCH] tcg: optimise memory layout of TCGTemp

2015-03-27 Thread Richard Henderson
On 03/25/2015 12:50 PM, Emilio G. Cota wrote: > This brings down the size of the struct from 56 to 32 bytes on 64-bit, > and to 16 bytes on 32-bit. > > The appended adds macros to prevent us from mistakenly overflowing > the bitfields when more elements are added to the corresponding > enums/macro

[Qemu-devel] [PATCH] target-tricore: fix CACHEA/I_POSTINC/PREINC using data register..

2015-03-27 Thread Bastian Koppelmann
..for address calculation instead address registers. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index bbcfee9..54a48cd 100644 --- a/target-tri

  1   2   >