Re: [Qemu-devel] [RFC PATCH v2 09/23] spapr: Add CPU hotplug handler

2015-03-24 Thread David Gibson
On Mon, Mar 23, 2015 at 07:05:50PM +0530, Bharata B Rao wrote: > Add CPU hotplug handler to spapr machine class and let the plug handler > initialize spapr CPU specific initialization bits for a realized CPU. > This lets CPU boot path and hotplug path to share as much code as possible. > > Signed-

Re: [Qemu-devel] [RFC PATCH v2 10/23] ppc: Update cpu_model in MachineState

2015-03-24 Thread David Gibson
On Mon, Mar 23, 2015 at 07:05:51PM +0530, Bharata B Rao wrote: > Keep cpu_model field in MachineState uptodate so that it can be used > from the CPU hotplug path. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson -- David Gibson| I'll have my music baroque, and my

Re: [Qemu-devel] [RFC PATCH v2 08/23] ppc: Prepare CPU socket/core abstraction

2015-03-24 Thread David Gibson
On Mon, Mar 23, 2015 at 07:05:49PM +0530, Bharata B Rao wrote: Again, this needs a commit message explaining why the new abstraction is valuable. > Signed-off-by: Bharata B Rao > Signed-off-by: Andreas Färber > --- > hw/ppc/Makefile.objs| 1 + > hw/ppc/cpu-core.c | 46 ++

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-03-24 Thread Alex Williamson
On Wed, 2015-03-25 at 09:53 +0800, Chen Fan wrote: > On 03/16/2015 10:09 PM, Alex Williamson wrote: > > On Mon, 2015-03-16 at 15:35 +0800, Chen Fan wrote: > >> On 03/16/2015 11:52 AM, Alex Williamson wrote: > >>> On Mon, 2015-03-16 at 11:05 +0800, Chen Fan wrote: > On 03/14/2015 06:34 AM, Alex

[Qemu-devel] [PATCH v3] block: Switch to host monotonic clock for IO throttling

2015-03-24 Thread Fam Zheng
Currently, throttle timers won't make any progress when VCPU is not running, which would stall the request queue in utils, qtest, vm suspending, and live migration without special handling. Block jobs are confusingly inconsistent between with and without throttling: if user sets a bps limit, start

Re: [Qemu-devel] [RFC PATCH v2 12/23] spapr: CPU hotplug support

2015-03-24 Thread David Gibson
On Mon, Mar 23, 2015 at 07:05:53PM +0530, Bharata B Rao wrote: > Support CPU hotplug via device-add command. Set up device tree > entries for the hotplugged CPU core and use the exising EPOW event > infrastructure to send CPU hotplug notification to the guest. > > Signed-off-by: Bharata B Rao > -

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-03-24 Thread Chen Fan
On 03/25/2015 10:41 AM, Alex Williamson wrote: On Wed, 2015-03-25 at 09:53 +0800, Chen Fan wrote: On 03/16/2015 10:09 PM, Alex Williamson wrote: On Mon, 2015-03-16 at 15:35 +0800, Chen Fan wrote: On 03/16/2015 11:52 AM, Alex Williamson wrote: On Mon, 2015-03-16 at 11:05 +0800, Chen Fan wrote

Re: [Qemu-devel] [RFC PATCH v2 14/23] cpus: Convert cpu_index into a bitmap

2015-03-24 Thread David Gibson
On Mon, Mar 23, 2015 at 07:05:55PM +0530, Bharata B Rao wrote: > Currently CPUState.cpu_index is monotonically increasing and a newly > created CPU always gets the next higher index. The next available > index is calculated by counting the existing number of CPUs. This is > fine as long as we only

Re: [Qemu-devel] [RFC PATCH v2 13/23] cpus: Add Error argument to cpu_exec_init()

2015-03-24 Thread David Gibson
On Mon, Mar 23, 2015 at 07:05:54PM +0530, Bharata B Rao wrote: > Add an Error argument to cpu_exec_init() to let users collect the > error. Change all callers to currently pass NULL error argument. This change > is needed for the following reasons: > > - A subsequent commit changes the CPU enumera

Re: [Qemu-devel] [RFC PATCH v2 15/23] ppc: Move cpu_exec_init() call to realize function

2015-03-24 Thread David Gibson
On Mon, Mar 23, 2015 at 07:05:56PM +0530, Bharata B Rao wrote: > Move cpu_exec_init() call from instance_init to realize. This allows > any failures from cpu_exec_init() to be handled appropriately. > > Also add cpu_exec_exit() call from unrealize. This still leaves all non-ppc archs not ever cal

Re: [Qemu-devel] [RFC PATCH v2 02/23] spapr: Add DRC dt entries for CPUs

2015-03-24 Thread Bharata B Rao
On Wed, Mar 25, 2015 at 11:07:10AM +1100, David Gibson wrote: > On Mon, Mar 23, 2015 at 07:05:43PM +0530, Bharata B Rao wrote: > > Advertise CPU DR-capability to the guest via device tree. > > > > Signed-off-by: Bharata B Rao > > Signed-off-by: Michael Roth > >[spapr_drc_reset im

Re: [Qemu-devel] virtconsole migration regression from 2.2.0

2015-03-24 Thread Michael S. Tsirkin
On Tue, Mar 24, 2015 at 06:14:44PM -0400, Cole Robinson wrote: > I'm hitting an error migrating from stock v2.2.0 to git master: > > 2015-03-24T21:42:07.731317Z qemu-system-x86_64: error while loading state for > instance 0x0 of device ':00:05.0/virtio-console' > 2015-03-24T21:42:07.731392Z qe

Re: [Qemu-devel] [PATCH v2 0/2] e1000: fixes for Phar Lap ETS

2015-03-24 Thread Richard Tollerton
Stefan Hajnoczi writes: > On Wed, Dec 10, 2014 at 11:23:45PM -0600, Richard Tollerton wrote: >> The 8254x driver in certain versions of Phar Lap ETS hasn't been >> initializing the e1000 device properly in qemu. It looks like the driver >> is relying on two specific pieces of behavior which (anec

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-24 Thread Zhu Guihua
On 03/24/2015 06:26 PM, Igor Mammedov wrote: On Tue, 24 Mar 2015 17:34:29 +0800 Zhu Guihua wrote: On 03/23/2015 08:47 PM, Igor Mammedov wrote: On Mon, 23 Mar 2015 18:59:28 +0800 Zhu Guihua wrote: On 03/16/2015 10:59 PM, Igor Mammedov wrote: [...] diff --git a/hw/i386/acpi-dsdt-mem-ho

<    1   2   3