Re: [Qemu-devel] [PATCH for-2.3] powerpc: fix -machine usb=no for newworld and pseries machines

2015-03-24 Thread Paolo Bonzini
On 23/03/2015 23:00, Marcel Apfelbaum wrote: I know it comes to solve a bug, but we talked about it in another mail thread and this change in semantics was approved. I forgot to reply to this---my understanding is that it was okay for the sake of your patch series, but it would be fixe

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/2] i6300esb: Fix signed integer overflow

2015-03-24 Thread Paolo Bonzini
On 24/03/2015 01:22, David Gibson wrote: > On Mon, Mar 23, 2015 at 10:54:39AM +0100, BALATON Zoltan wrote: >> On Mon, 23 Mar 2015, David Gibson wrote: >>> If the guest programs a sufficiently large timeout value an >>> integer overflow can occur in i6300esb_restart_timer(). e.g. >>> if the maxim

Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-24 Thread Paolo Bonzini
On 23/03/2015 21:19, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 23/03/2015 18:48, Eric Blake wrote: Why can't libvirt just add ,format=raw instead of leaving out the format key altogether? >>> >>> Libvirt DOES add format=raw. This patch is an extra insurance >>> policy

[Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Chen, Tiejun
All guys, Sorry to bother you. I have a question to two files, tools/python/xen/lowlevel/xc/xc.c and tools/python/xen/lowlevel/xl/xl.c. Who is a caller to those methods like pyxc_methods[] and pyxl_methods[]? And how should we call these approaches? In my specific case, I'm trying to introdu

[Qemu-devel] [PULL 1/4] target-tricore: Fix two helper functions (clang warnings)

2015-03-24 Thread Bastian Koppelmann
From: Stefan Weil clang report: target-tricore/op_helper.c:1247:24: warning: taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int') has no effect [-Wabsolute-value] target-tricore/op_helper.c:1248:25: warning: taking the absolute value of unsigned type 'uint32_t' (aka '

[Qemu-devel] [PULL 4/4] target-tricore: properly fix dvinit_b/h_13

2015-03-24 Thread Bastian Koppelmann
The TriCore documentation was wrong on how to calculate ovf bits for those two instructions, which I confirmed with real hardware (TC1796 chip). An ovf actually happens, if the result (without remainder) does not fit into 8/16 bits. Signed-off-by: Bastian Koppelmann --- target-tricore/op_helper.

[Qemu-devel] [PULL 2/4] target-tricore: fix DVINIT_HU/BU calculating overflow before result

2015-03-24 Thread Bastian Koppelmann
dvinit_hu/bu for ISA v1.3 calculate the higher part of the result, that is needed for the overflow bits, after calculating the overflow bits. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-)

[Qemu-devel] [PULL 0/4] tricore-patches for 2.3-rc1

2015-03-24 Thread Bastian Koppelmann
.git tags/pull-tricore-20150324 for you to fetch changes up to f69c24e4584f2161f90ee7caba38728aa77f937f: target-tricore: properly fix dvinit_b/h_13 (2015-03-24 09:45:28 +0100) TriCore bugfixes f

[Qemu-devel] [PULL 3/4] target-tricore: fix RRPW_DEXTR using wrong reg

2015-03-24 Thread Bastian Koppelmann
RRPW_DEXTR used r1 for the low part and r2 for the high part. It should be the other way round. This also fixes that the result of the first shift was not saved in a temp and could overwrite registers that were needed for the second shift. Signed-off-by: Bastian Koppelmann --- target-tricore/tra

[Qemu-devel] [PATCH] target-ppc: gdbstub: Add VSX support

2015-03-24 Thread Anton Blanchard
Add the XML and functions to get and set VSX registers. Signed-off-by: Anton Blanchard --- configure | 6 +++--- gdb-xml/power-vsx.xml | 44 target-ppc/translate_init.c | 22 ++ 3 files changed, 69 insertio

Re: [Qemu-devel] [libvirt] [RFC PATCH v2 00/12] qemu: add support to hot-plug/unplug cpu device

2015-03-24 Thread Zhu Guihua
On 03/24/2015 04:30 PM, Zhi Yong Wu wrote: HI, Do you have plan to update this patchset based on the comments recently or have the latest one to post? The develop plan for cpu hotplug in qemu has been changed, it is to add socket-based device_add. So I think we could not continue this cpu

Re: [Qemu-devel] [PATCH v5 38/45] Don't sync dirty bitmaps in postcopy

2015-03-24 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:52:01PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Once we're in postcopy the source processors are stopped and memory > > shouldn't change any more, so there's no need to l

Re: [Qemu-devel] [PATCH] target-ppc: gdbstub: Add VSX support

2015-03-24 Thread Alexander Graf
On 24.03.15 09:59, Anton Blanchard wrote: > Add the XML and functions to get and set VSX registers. Awesome, thanks. Have you verified that this works for LE as well as BE guests? Alex

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-24 Thread Zhu Guihua
On 03/23/2015 08:47 PM, Igor Mammedov wrote: On Mon, 23 Mar 2015 18:59:28 +0800 Zhu Guihua wrote: On 03/16/2015 10:59 PM, Igor Mammedov wrote: [...] diff --git a/hw/i386/acpi-dsdt-mem-hotplug.dsl b/hw/i386/acpi-dsdt-mem-hotplug.dsl index 1e9ec39..ef847e2 100644 --- a/hw/i386/acpi-dsdt-me

Re: [Qemu-devel] [PATCH v2 0/2] e1000: fixes for Phar Lap ETS

2015-03-24 Thread Stefan Hajnoczi
On Wed, Dec 10, 2014 at 11:23:45PM -0600, Richard Tollerton wrote: > The 8254x driver in certain versions of Phar Lap ETS hasn't been > initializing the e1000 device properly in qemu. It looks like the driver > is relying on two specific pieces of behavior which (anecdotally) exist > in hardware, a

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-24 Thread Zhu Guihua
On 03/16/2015 10:59 PM, Igor Mammedov wrote: On Mon, 16 Mar 2015 16:58:18 +0800 Zhu Guihua wrote: This patch adds a new bit to memory hotplug IO port indicating that actually bit was added in 2/6 where is_removing had been added. EJ0 has been evaluated by guest OS. And call pc-dimm unplug

Re: [Qemu-devel] [PATCH] target-ppc: gdbstub: Add VSX support

2015-03-24 Thread Anton Blanchard
Hi Alex, > On 24.03.15 09:59, Anton Blanchard wrote: > > Add the XML and functions to get and set VSX registers. > > Awesome, thanks. Have you verified that this works for LE as well as > BE guests? Unfortunately all our XML gdbstub routines have endian issues (FPU, Altivec and now VMX). I only

Re: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 16:47 +0800, Chen, Tiejun wrote: > All guys, > > Sorry to bother you. > > I have a question to two files, tools/python/xen/lowlevel/xc/xc.c and > tools/python/xen/lowlevel/xl/xl.c. Who is a caller to those methods like > pyxc_methods[] and pyxl_methods[]? They are registe

Re: [Qemu-devel] [PATCH] qmp: implement a qmp command get_link_status

2015-03-24 Thread Stefan Hajnoczi
On Thu, Dec 11, 2014 at 02:36:14PM +0100, Wolfgang Link wrote: > this qmp command returns the current link state from the given nic > this is impotent if the set_link failed or get an timeout. s/impotent/important/ I don't understand the rationale for this patch: set_link does not fail or time o

Re: [Qemu-devel] [PATCH] target-ppc: gdbstub: Add VSX support

2015-03-24 Thread Alexander Graf
On 24.03.15 10:50, Anton Blanchard wrote: > Hi Alex, > >> On 24.03.15 09:59, Anton Blanchard wrote: >>> Add the XML and functions to get and set VSX registers. >> >> Awesome, thanks. Have you verified that this works for LE as well as >> BE guests? > > Unfortunately all our XML gdbstub routines

Re: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Chen, Tiejun
On 2015/3/24 17:51, Ian Campbell wrote: On Tue, 2015-03-24 at 16:47 +0800, Chen, Tiejun wrote: All guys, Thanks for your reply. Sorry to bother you. I have a question to two files, tools/python/xen/lowlevel/xc/xc.c and tools/python/xen/lowlevel/xl/xl.c. Who is a caller to those methods lik

Re: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 18:15 +0800, Chen, Tiejun wrote: > On 2015/3/24 17:51, Ian Campbell wrote: > > On Tue, 2015-03-24 at 16:47 +0800, Chen, Tiejun wrote: > >> All guys, > >> > > Thanks for your reply. > > >> Sorry to bother you. > >> > >> I have a question to two files, tools/python/xen/lowleve

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Paolo Bonzini
On 23/03/2015 20:09, Markus Armbruster wrote: > Drives defined with if!=none are for board initialization to wire up. > Board code calls drive_get() or similar to find them, and creates > devices with their qdev drive properties set accordingly. > > Except a few devices go on a fishing expeditio

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-24 Thread Igor Mammedov
On Tue, 24 Mar 2015 17:34:29 +0800 Zhu Guihua wrote: > > On 03/23/2015 08:47 PM, Igor Mammedov wrote: > > On Mon, 23 Mar 2015 18:59:28 +0800 > > Zhu Guihua wrote: > > > >> On 03/16/2015 10:59 PM, Igor Mammedov wrote: > >> [...] > >>> > >>> diff --git a/hw/i386/acpi-dsdt-mem-hotplug.dsl > >

Re: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Chen, Tiejun
On 2015/3/24 18:20, Ian Campbell wrote: On Tue, 2015-03-24 at 18:15 +0800, Chen, Tiejun wrote: On 2015/3/24 17:51, Ian Campbell wrote: On Tue, 2015-03-24 at 16:47 +0800, Chen, Tiejun wrote: All guys, Thanks for your reply. Sorry to bother you. I have a question to two files, tools/python

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-24 Thread Igor Mammedov
On Tue, 24 Mar 2015 17:38:53 +0800 Zhu Guihua wrote: > > On 03/16/2015 10:59 PM, Igor Mammedov wrote: > > On Mon, 16 Mar 2015 16:58:18 +0800 > > Zhu Guihua wrote: > > > >> This patch adds a new bit to memory hotplug IO port indicating that > > actually bit was added in 2/6 where is_removing had

[Qemu-devel] [PATCH 1/3] apic: Added helper function apic_match_dest, apic_match_[physical, logical]_dest

2015-03-24 Thread James Sullivan
Added three helper functions apic_match_dest(), apic_match_physical_dest(), and apic_match_logical_dest() which can be used to determine if a logical or physical APIC ID match a given LAPIC under a given dest_mode. This does not account for shorthand. Signed-off-by: James Sullivan --- hw/intc/ap

[Qemu-devel] [PATCH] apic: Implement low-priority arbitration for IRQ delivery

2015-03-24 Thread James Sullivan
Currently, there is no arbitration among processors for low priority IRQ delivery. Implemented apic_get_arb_pri(), and added two new functions apic_compare_prio() and apic_lowest_prio() to support arbitration in apic_bus_deliver(). Signed-off-by: James Sullivan --- hw/intc/apic.c | 67 ++

[Qemu-devel] [PATCH 2/3] apic: Set and pass in RH bit for MSI interrupts

2015-03-24 Thread James Sullivan
In apic_send_msi(), set msi_redir_hint to 0x1 when RH=1 in the MSI Address Register. Added an argument for msi_redir_hint to apic_deliver_irq(), and changed calls to the function accordingly (using 0 as a default value for non-MSI interrupts). Signed-off-by: James Sullivan --- hw/intc/apic.c

[Qemu-devel] [PATCH 3/3] apic: Implement handling of RH=1 for MSI interrupt delivery

2015-03-24 Thread James Sullivan
Added argument to apic_get_delivery_bitmask() for msi_redir_hint, and changed calls to the function accordingly (using 0 as a default value for non-MSI interrupts). Modified the implementation of apic_get_delivery_bitmask() to account for the RH bit of an MSI IRQ. The RH bit indicates that the mes

Re: [Qemu-devel] [Xen-devel] Question about scsi emulation

2015-03-24 Thread Juergen Gross
On 03/24/2015 01:20 AM, Yaoli Zheng wrote: Thank you for the advice! It will be grateful if someone can provide any guide how to config MegaSAS HBA or how to use xen pvscsi in XEN. There seems no option in XEN for these two driver emulation and no document found online. The pvscsi driver is

[Qemu-devel] [PATCH] Haiku: Platform build fixes

2015-03-24 Thread Alexander von Gluck IV
* skip syscall.h on Haiku * skip signal.h on Haiku * no daemon function * only attach SIGIO when it exists * use termios.h on Haiku --- main-loop.c |2 + os-posix.c |4 ++ target-xtensa/xtensa-semi.c | 84 --- tests

[Qemu-devel] [PATCH 0/3] apic: Implement handling for MSI redirection hint in IRQ delivery

2015-03-24 Thread James Sullivan
This set of patches implements handling for the MSI redirection hint bit. The RH bit is used in logical destination mode to indicate that the delivery of the interrupt shall only be to the lowest priority candidate LAPIC. Currently, there is no handling of the MSI RH bit. This patch implements th

[Qemu-devel] Qemu 2.2.1 black screen of death in windows 2012 R2

2015-03-24 Thread Stefan Priebe - Profihost AG
Hi, after upgrading Qemu from 2.2.0 to 2.2.1 Windows 2012 R2 works after installing. But after applying 72 updates it breaks with a black screen of death. Linking to this KB: https://support.microsoft.com/en-us/kb/2939259 It works fine with Qemu 2.2.0 Greets, Stefan

Re: [Qemu-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 18:31 +0800, Chen, Tiejun wrote: > > NB, the libxl ones are broken and not even compiled right now, you can > > ignore them. > > Looks this is still compiled now. xc is, xl is not, I am sure of that. > > I don't know what the semantics of flag is, if it is per SBDF then I >

Re: [Qemu-devel] Qemu 2.2.1 black screen of death in windows 2012 R2

2015-03-24 Thread Paolo Bonzini
On 24/03/2015 11:39, Stefan Priebe - Profihost AG wrote: > after upgrading Qemu from 2.2.0 to 2.2.1 > > Windows 2012 R2 works after installing. But after applying 72 updates it > breaks with a black screen of death. Can you bisect it? > Linking to this KB: > https://support.microsoft.com/en-us

Re: [Qemu-devel] [RESEND PATCH v4 6/6] acpi: Add hardware implementation for memory hot unplug

2015-03-24 Thread Zhu Guihua
On 03/24/2015 06:31 PM, Igor Mammedov wrote: On Tue, 24 Mar 2015 17:38:53 +0800 Zhu Guihua wrote: On 03/16/2015 10:59 PM, Igor Mammedov wrote: On Mon, 16 Mar 2015 16:58:18 +0800 Zhu Guihua wrote: This patch adds a new bit to memory hotplug IO port indicating that actually bit was added i

Re: [Qemu-devel] [Bug 1405385] Re: QEMU crashes when virtio network cards are used together with e1000 network cards

2015-03-24 Thread Stefan Hajnoczi
On Fri, Jan 09, 2015 at 07:30:05AM -, Bram Klein Gunnewiek wrote: > I'm not sure if there is more information required from my side? I can > still reproduce this and have no clue where to look for more > information. I cannot reproduce a crash from your command-line with qemu.git/master (3e5f6

Re: [Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-03-24 Thread Stefan Hajnoczi
On Wed, Jan 07, 2015 at 04:09:55PM -, timsoft wrote: > I have tried what you suggested (breaking the bridge on the host, and giving > the host tap 192.168.5.1 and the guest eth0 192.168.5.2 > and tried pinging one from the other. I get 100% packet loss. > This points to QEMU's tap networking a

Re: [Qemu-devel] [PULL 0/4] tricore-patches for 2.3-rc1

2015-03-24 Thread Peter Maydell
ble in the git repository at: > > https://github.com/bkoppelmann/qemu-tricore-upstream.git > tags/pull-tricore-20150324 > > for you to fetch changes up to f69c24e4584f2161f90ee7caba38728aa77f937f: > > target-tricore: prop

Re: [Qemu-devel] Qemu 2.2.1 black screen of death in windows 2012 R2

2015-03-24 Thread Stefan Priebe - Profihost AG
Am 24.03.2015 um 11:45 schrieb Paolo Bonzini: > > > On 24/03/2015 11:39, Stefan Priebe - Profihost AG wrote: >> after upgrading Qemu from 2.2.0 to 2.2.1 >> >> Windows 2012 R2 works after installing. But after applying 72 updates it >> breaks with a black screen of death. > > Can you bisect it?

Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-03-24 Thread Stefan Hajnoczi
On Thu, Mar 12, 2015 at 11:29:38PM +0800, Yi Wang wrote: > How about this? > > From 913cf2cd04167b7f6b892ac1ab405a617d886b97 Mon Sep 17 00:00:00 2001 > From: Yi Wang > Date: Thu, 12 Mar 2015 22:54:42 +0800 > Subject: [PATCH] savevm: create snapshot failed when id_str already exists > > The comma

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Markus Armbruster
Adding Andreas because he's the odd fixer for pc87312. Paolo Bonzini writes: > On 23/03/2015 20:09, Markus Armbruster wrote: >> Drives defined with if!=none are for board initialization to wire up. >> Board code calls drive_get() or similar to find them, and creates >> devices with their qdev dr

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/3] VFIO: Clear stale MSIx table during EEH reset

2015-03-24 Thread Alex Williamson
On Tue, 2015-03-24 at 17:54 +1100, David Gibson wrote: > On Tue, Mar 24, 2015 at 05:24:55PM +1100, Gavin Shan wrote: > > On Tue, Mar 24, 2015 at 04:41:21PM +1100, David Gibson wrote: > > >On Mon, Mar 23, 2015 at 04:25:10PM +1100, Gavin Shan wrote: > > >> On Mon, Mar 23, 2015 at 04:06:56PM +1100, Da

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add myself as the maintainer of the Quorum driver

2015-03-24 Thread Stefan Hajnoczi
On Mon, Mar 16, 2015 at 06:22:05PM +0200, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan pgpzd3tmoRxE7.pgp Description: PGP

Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock for IO throttling

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 24, 2015 at 09:17:38AM +0800, Fam Zheng wrote: > Alberto saw that this patch also fixes the odd behavior: block jobs, which > need > to R/W a throttled BDS, will not make progress if VCPU is not running. If we > don't consider this as a bug, we should document the inconsistency > (con

Re: [Qemu-devel] Output of fprintf messages in qemu source

2015-03-24 Thread Toms Varghese
In my Fedora, I couldn't find the file in the mentioned path. I got it finally from /var/log/libvirt/qemu/.log Thanks a lot for the help. Regards Toms Varghese On Mon, Mar 23, 2015 at 6:17 PM, Stefan Hajnoczi wrote: > On Thu, Mar 19, 2015 at 12:17:29AM +0530, Toms Varghese wrote: > > Hi all, >

Re: [Qemu-devel] [PATCH v3 7/9] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update()

2015-03-24 Thread Stefan Hajnoczi
On Mon, Mar 23, 2015 at 04:40:26PM +0100, Paolo Bonzini wrote: > > > On 23/03/2015 16:29, Stefan Hajnoczi wrote: > > From: Paolo Bonzini > > > > The loop previously terminated on ffs(0) == 0, now it terminates on > > ctz32(0) + 1 == 33. > > ... now it terminates on level == 0. Old commit desc

Re: [Qemu-devel] [PATCH v2 0/2] block: Fix unaligned zero write

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 24, 2015 at 09:23:48AM +0800, Fam Zheng wrote: > This fixes a segfault when doing unaligned zero write to an image that is 4k > aligned. > > v2: Don't drop the unset of UNMAP flag. [Stefan, Peter] > > Reproducer: > > $ (echo "open -o file.align=4k blkdebug::img"; echo "write -z 5

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Peter Maydell
On 23 March 2015 at 12:24, Peter Maydell wrote: > (This is part of the work I'm doing for transaction attributes.) OK, here's try 2, based on feedback on the first proposal: * address_space_rw &c remain with their current names, but take an extra MemTxAttrs argument and return MemTxResult

Re: [Qemu-devel] GSoC Proposal: ARM Virtualization Extensions

2015-03-24 Thread Sergey Fedorov
On 23.03.2015 04:29, Merten Sach wrote: > On 21/03/15 04:16, Sergey Fedorov wrote: >> Hi! >> >> I am currently working on AArch64 EL2 support. There is a plan to submit >> the changes to the community. Merten, IIUYC, you are going to support >> only AArch32 EL2? >> >> Best regards, >> Sergey > Hi >

Re: [Qemu-devel] Qemu 2.2.1 black screen of death in windows 2012 R2

2015-03-24 Thread Stefan Priebe
Hi, it started to work again with virtio 100 instead of 94. No idea why it works with qemu 2.2.0. Stefan Am 24.03.2015 um 12:15 schrieb Stefan Priebe - Profihost AG: Am 24.03.2015 um 11:45 schrieb Paolo Bonzini: On 24/03/2015 11:39, Stefan Priebe - Profihost AG wrote: after upgrading Qe

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-24 Thread jacob jacob
After update to latest firmware and using version 1.2.37 of i40e driver, things are looking better with PCI passthrough. ]# ethtool -i eth3 driver: i40e version: 1.2.37 firmware-version: f4.33.31377 a1.2 n4.42 e1930 bus-info: :00:07.0 supports-statistics: yes supports-test: yes supports-eeprom

Re: [Qemu-devel] [PATCH for-2.3 1/1] block: New command line option --misc format-probing=off

2015-03-24 Thread Eric Blake
On 03/23/2015 02:42 PM, Markus Armbruster wrote: >> >> I don't think it's the right solution. Libvirt knows where to add a >> format=raw option, and it can do it without waiting for QEMU to >> implement this. Direct command-line users are not going to use the >> option anyway. > > Two separate

Re: [Qemu-devel] [Qemu-block] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-24 Thread Eric Blake
On 03/24/2015 02:37 AM, Paolo Bonzini wrote: >> The option sets bdrv_image_probing_disabled in a straightforward manner, >> and bdrv_image_probing_disabled guards the probing code in an equally >> straightforward manner. > > But what about migration from newer to older QEMU? Libvirt even > suppo

Re: [Qemu-devel] [PATCH v5 1/6] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-24 Thread Greg Bellows
On Mon, Mar 23, 2015 at 12:05 PM, Alex Bennée wrote: > From: Peter Maydell > > The AArch64 SPSR_EL1 register is architecturally mandated to > be mapped to the AArch32 SPSR_svc register. This means its > state should live in QEMU's env->banked_spsr[1] field. > Correct the various places in the cod

Re: [Qemu-devel] [PATCH RFC 0/4] target-i386: PC socket/core/thread modeling, part 1

2015-03-24 Thread Christian Borntraeger
Am 23.03.2015 um 18:31 schrieb Andreas Färber: > Hello, > > This long-postponed series proposes a hierarchical QOM model of socket > and core objects for the x86 PC machines. Just some comments from the s390 side as we probably want more than status quo in the future as well. Traditionally all

Re: [Qemu-devel] [PATCH v5 1/6] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-24 Thread Peter Maydell
On 24 March 2015 at 14:32, Greg Bellows wrote: > On Mon, Mar 23, 2015 at 12:05 PM, Alex Bennée wrote: >> From: Peter Maydell >> @@ -523,7 +523,7 @@ void aarch64_cpu_do_interrupt(CPUState *cs) >> aarch64_save_sp(env, arm_current_el(env)); >> env->elr_el[new_el] = env->pc; >>

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Paolo Bonzini
On 24/03/2015 14:47, Peter Maydell wrote: > On 23 March 2015 at 12:24, Peter Maydell wrote: >> (This is part of the work I'm doing for transaction attributes.) > > OK, here's try 2, based on feedback on the first proposal: > > * address_space_rw &c remain with their current names, but >ta

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Paolo Bonzini
On 24/03/2015 13:48, Markus Armbruster wrote: > Use of -drive if=floppy with onboard pc87312 (machine "prep") shouldn't > be affected. Likewise for connecting onboard m25p80-generic derivatives > with if=mtd drives, or onboard ssi-sd with if=sd. Exactly. > Weird usage similar to the one you ca

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-24 Thread Ian Campbell
On Mon, 2015-03-23 at 09:17 +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn' suffice ^t > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-24 Thread Shannon Nelson
On Tue, Mar 24, 2015 at 7:13 AM, jacob jacob wrote: > After update to latest firmware and using version 1.2.37 of i40e > driver, things are looking better with PCI passthrough. > > ]# ethtool -i eth3 > driver: i40e > version: 1.2.37 > firmware-version: f4.33.31377 a1.2 n4.42 e1930 > bus-info:

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Peter Maydell
On 24 March 2015 at 14:45, Paolo Bonzini wrote: > On 24/03/2015 14:47, Peter Maydell wrote: >> On 23 March 2015 at 12:24, Peter Maydell wrote: >> * no default-to-no-attrs/etc versions of ld/st*_ phys >>(if in specific devices/buses it's the best thing we should >>have bus-specific dma ac

Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property

2015-03-24 Thread Markus Armbruster
Peter Crosthwaite writes: > On Mon, Mar 23, 2015 at 7:05 PM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 23/03/2015 10:10, Markus Armbruster wrote: [...] I believe the proper solution for your problem is qdevifying the SD card. >>> >>> The question is whether there is

Re: [Qemu-devel] [PATCH 2/6] throttle: Add throttle group infrastructure

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 05:30:46PM +0200, Alberto Garcia wrote: > +typedef struct ThrottleGroup { > +char *name; /* This is constant during the lifetime of the group */ Is this also protected by throttle_groups_lock? I guess throttle_groups_lock must be held in order to read this field - othe

Re: [Qemu-devel] [PATCH 1/6] throttle: Extract timers from ThrottleState into a separate structure

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 05:30:45PM +0200, Alberto Garcia wrote: > From: Benoît Canet > > Group throttling will share ThrottleState between multiple bs. > As a consequence the ThrottleState will be accessed by multiple aio > context. > > Timers are tied to their aio context so they must go out of

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-24 Thread jacob jacob
On Tue, Mar 24, 2015 at 10:53 AM, Shannon Nelson wrote: > On Tue, Mar 24, 2015 at 7:13 AM, jacob jacob wrote: >> After update to latest firmware and using version 1.2.37 of i40e >> driver, things are looking better with PCI passthrough. >> >> ]# ethtool -i eth3 >> driver: i40e >> version: 1.2.37

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Paolo Bonzini
On 24/03/2015 15:53, Peter Maydell wrote: >> > In any case, the removal or segregation of ld/st*_phys should be a >> > separate series for ease of review. > Who wants to remove ld/st*_phys? Not me... Well, you want to rename them _and_ add new arguments. Basically at the end they don't exist an

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Peter Maydell
On 24 March 2015 at 15:08, Paolo Bonzini wrote: > On 24/03/2015 15:53, Peter Maydell wrote: >>> > In any case, the removal or segregation of ld/st*_phys should be a >>> > separate series for ease of review. >> Who wants to remove ld/st*_phys? Not me... > > Well, you want to rename them _and_ add n

Re: [Qemu-devel] [PATCH 3/6] throttle: Add throttle group infrastructure tests

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 05:30:47PM +0200, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/test-throttle.c | 37 +++-- > 1 file changed, 35 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi pgpP_PgdRsuJB.pgp Description: PGP signatur

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 24/03/2015 13:48, Markus Armbruster wrote: >> Use of -drive if=floppy with onboard pc87312 (machine "prep") shouldn't >> be affected. Likewise for connecting onboard m25p80-generic derivatives >> with if=mtd drives, or onboard ssi-sd with if=sd. > > Exactly. > >> Weird

Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-24 Thread Stefan Berger
On 03/23/2015 10:20 PM, Xu, Quan wrote: -Original Message- From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] Sent: Tuesday, March 24, 2015 4:01 AM To: Xu, Quan; Ian Campbell Cc: ke...@koconnor.net; qemu-devel@nongnu.org; stefano.stabell...@eu.citrix.com; xen-de...@lists.xen.org Su

Re: [Qemu-devel] [PATCH 2/6] throttle: Add throttle group infrastructure

2015-03-24 Thread Alberto Garcia
On Tue, Mar 24, 2015 at 03:03:07PM +, Stefan Hajnoczi wrote: > > +typedef struct ThrottleGroup { > > +char *name; /* This is constant during the lifetime of the group */ > > Is this also protected by throttle_groups_lock? > > I guess throttle_groups_lock must be held in order to read thi

Re: [Qemu-devel] [PATCH 0/2] CVE-2015-1779: fix denial of service in VNC websockets

2015-03-24 Thread Gerd Hoffmann
On Mo, 2015-03-23 at 22:58 +, Daniel P. Berrange wrote: > The VNC websockets protocol decoder has two places where it did > not correctly limit its resource usage when processing data from > the client. This can be abused by a malicious client to cause QEMU > to consume all system memory, unles

Re: [Qemu-devel] [PATCH 4/6] throttle: Add throttle group support

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 05:30:48PM +0200, Alberto Garcia wrote: > @@ -179,10 +179,11 @@ static void bdrv_throttle_write_timer_cb(void *opaque) > } > > /* should be called before bdrv_set_io_limits if a limit is set */ > -void bdrv_io_limits_enable(BlockDriverState *bs) > +void bdrv_io_limits_en

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Paolo Bonzini
> I really can't see why we should tie ourselves into knots to avoid an > incompatible change here. I seriously doubt anyone will notice if drop > the mistaken automatic backend pickup so that "-drive if=floppy -device > i82378 -device pc87312" no longer picks up the floppy. Ok, it wasn't too har

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Paolo Bonzini
> On 24 March 2015 at 15:08, Paolo Bonzini wrote: > > On 24/03/2015 15:53, Peter Maydell wrote: > >>> > In any case, the removal or segregation of ld/st*_phys should be a > >>> > separate series for ease of review. > >> Who wants to remove ld/st*_phys? Not me... > > > > Well, you want to rename th

Re: [Qemu-devel] [PATCH 4/6] throttle: Add throttle group support

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 05:30:48PM +0200, Alberto Garcia wrote: > +/* Return the next BlockDriverState in the round-robin sequence with > + * pending I/O requests. > + * > + * @bs:the current BlockDriverState > + * @is_write: the type of operation (read/write) > + * @ret: the next Bl

Re: [Qemu-devel] [PATCH v3 0/6] Block Throttle Group Support

2015-03-24 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 05:30:44PM +0200, Alberto Garcia wrote: > Here's what's new: Thanks for the cleanup! The locking isn't safe yet but the series is in pretty good shape overall. Please see comments on individual patches for details. Stefan pgpBl24v56at7.pgp Description: PGP signature

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Peter Maydell
On 24 March 2015 at 16:23, Paolo Bonzini wrote: >> On 24 March 2015 at 15:08, Paolo Bonzini wrote: >> > On 24/03/2015 15:53, Peter Maydell wrote: >> >>> > In any case, the removal or segregation of ld/st*_phys should be a >> >>> > separate series for ease of review. >> >> Who wants to remove ld/s

Re: [Qemu-devel] [RFC 0/6] memory: make dirty_memory[] accesses atomic

2015-03-24 Thread Stefan Hajnoczi
On Mon, Mar 23, 2015 at 12:09:55PM +0100, Paolo Bonzini wrote: > > > On 28/11/2014 13:44, Stefan Hajnoczi wrote: > > This is an example of what I mean. > > > > I'm not going to work on making TCG thread-safe in this series, and > > there is no dangerous race condition in this code if we leave it

Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing

2015-03-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/03/2015 21:19, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 23/03/2015 18:48, Eric Blake wrote: > Why can't libvirt just add ,format=raw instead of leaving out the > format key altogether? Libvirt DOES add format=raw. This patch is

[Qemu-devel] [PATCH 3/3] spice: learn to hide cursor

2015-03-24 Thread Marc-André Lureau
--- ui/spice-display.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index a85d6aa..7d025be 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -269,7 +269,8 @@ static void qemu_spice_create_update(SimpleSpiceDisplay *

[Qemu-devel] [PATCH 1/3] spice: fix mouse cursor position

2015-03-24 Thread Marc-André Lureau
--- ui/spice-display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index c888650..fb22b65 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -717,7 +717,7 @@ static void display_mouse_set(DisplayChangeListener *dcl, qe

[Qemu-devel] [PATCH 0/3] A few Spice cursor fixes for non-QXL

2015-03-24 Thread Marc-André Lureau
Hi Since 5643fc0, qemu learned to set Spice cursor when using non-QXL card, this is a few improvements: Marc-André Lureau (3): spice: fix mouse cursor position spice: set pointer position on hotspot spice: learn to hide cursor include/ui/spice-display.h | 3 ++- ui/spice-display.c

[Qemu-devel] [PATCH 2/3] spice: set pointer position on hotspot

2015-03-24 Thread Marc-André Lureau
The Spice protocol uses cursor position on hotspot: the client is applying hotspot offset when drawing the cursor. --- include/ui/spice-display.h | 3 ++- ui/spice-display.c | 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/include/ui/spice-display.h b/includ

Re: [Qemu-devel] [PATCH v2 0/2] ahci: test varying sector offsets

2015-03-24 Thread John Snow
Ping: I'll pull both this series and the 'ahci: rerror/werror=stop resume tests' series into my ide-next branch if just these two patches get a re-review. They were excised from a pullreq due to glib compatibility issues, so the following series has no changes. --js On 03/13/2015 03:22 PM,

Re: [Qemu-devel] [Xen-devel] Question about scsi emulation

2015-03-24 Thread Stefano Stabellini
On Tue, 24 Mar 2015, Juergen Gross wrote: > On 03/24/2015 01:20 AM, Yaoli Zheng wrote: > > Thank you for the advice! > > It will be grateful if someone can provide any guide how to config MegaSAS > > HBA or how to use xen pvscsi in XEN. > > There seems no option in XEN for these two driver emulati

Re: [Qemu-devel] [PATCH 4/6] throttle: Add throttle group support

2015-03-24 Thread Alberto Garcia
On Tue, Mar 24, 2015 at 04:31:45PM +, Stefan Hajnoczi wrote: > > +/* get next bs round in round robin style */ > > +token = throttle_group_next_bs(token); > > +while (token != start && > > + qemu_co_queue_empty(&token->throttled_reqs[is_write])) { > > It's not safe to a

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Paolo Bonzini
On 24/03/2015 17:35, Peter Maydell wrote: > On 24 March 2015 at 16:23, Paolo Bonzini wrote: >>> On 24 March 2015 at 15:08, Paolo Bonzini wrote: On 24/03/2015 15:53, Peter Maydell wrote: >>> In any case, the removal or segregation of ld/st*_phys should be a >>> separate series for e

Re: [Qemu-devel] RFC: memory API changes

2015-03-24 Thread Peter Maydell
On 24 March 2015 at 17:51, Paolo Bonzini wrote: > On 24/03/2015 17:35, Peter Maydell wrote: >> On 24 March 2015 at 16:23, Paolo Bonzini wrote: On 24 March 2015 at 15:08, Paolo Bonzini wrote: >>> , for those callers >>> of ld/st*_phys that use cs->as as the first argument. >> >> ...but I don

[Qemu-devel] [PATCH v4 3/4] configure: silence glib unknown attribute __alloc_size__

2015-03-24 Thread John Snow
The glib headers use GCC attributes. Unfortunately the __GNUC__ and __GNUC_MINOR__ version macros are also defined by clang, but clang doesn't support the same attributes as GCC. clang 3.5.0 does not support the __alloc_size__ attribute: https://github.com/llvm-mirror/clang/commit/c047507a9a7

[Qemu-devel] [PATCH v4 4/4] configure: Add workaround for ccache and clang

2015-03-24 Thread John Snow
Test if ccache is interfering with semantic analysis of macros, disable its habit of trying to compile already pre-processed versions of code if so. ccache attempts to save time by compiling pre-processed versions of code, but this disturbs clang's static analysis enough to produce false positives.

[Qemu-devel] [PATCH v4 2/4] configure: factor out supported flag check

2015-03-24 Thread John Snow
Factor out the function that checks if a compiler flag is supported or not. Signed-off-by: John Snow --- configure | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/configure b/configure index 7a8637e..6f4bf4f 100755 --- a/configure +++ b/con

[Qemu-devel] [PATCH v4 0/4] configure: clang 3.5.0 build fixes

2015-03-24 Thread John Snow
QEMU does not compile cleanly under clang 3.5.0. These patches eliminate the avalanche of warnings and make the build usable. v4: - Enable ccache workaround for configurations without -Werror, to suppress warnings as well. - Removed optimization from cc_has_warning_flag() - Renamed ccache varia

[Qemu-devel] [PATCH v4 1/4] configure: handle clang -nopie argument warning

2015-03-24 Thread John Snow
From: Stefan Hajnoczi gcc 4.9.2 treats -nopie as an error: cc: error: unrecognized command line option ‘-nopie’ clang 3.5.0 treats -nopie as a warning: clang: warning: argument unused during compilation: '-nopie' The causes ./configure to fail with clang: ERROR: configure test passed w

[Qemu-devel] [PATCH for-2.3 0/1] gtk: fix NULL dereferences

2015-03-24 Thread Hervé Poussineau
Hi, Attached patch fixes some problems I encountered while testing MIPS Magnum emulation. (qemu-system-mips64el:1399): Gdk-CRITICAL **: IA__gdk_drawable_get_size: assertion `GDK_IS_DRAWABLE (drawable)' failed (qemu-system-mips64el:1714): Gdk-CRITICAL **: IA__gdk_window_set_cursor: assertion `GD

[Qemu-devel] [PATCH for-2.3 1/1] gtk: do not call gtk_widget_get_window if drawing area is not initialized

2015-03-24 Thread Hervé Poussineau
This prevents gtk_widget_get_window to return a NULL pointer. Signed-off-by: Hervé Poussineau --- ui/gtk.c | 12 1 file changed, 12 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 29bdc19..d6e01c2 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -294,6 +294,10 @@ static void gd_updat

[Qemu-devel] [PATCH v2 0/5] Implement RH bit handling and lowpri arbitration

2015-03-24 Thread James Sullivan
(Combination of <1427149572-11378-1-git-send-email-sullivan.jame...@gmail.com> and <1427152883-7049-1-git-send-email-sullivan.jame...@gmail.com>) Changes in v2: * Merged in low priority IRQ delivery implementation to RH bit handling implementation, since both rely on the same helper fu

[Qemu-devel] [PATCH v2 2/5] apic: Implement low priority arbitration for IRQ delivery

2015-03-24 Thread James Sullivan
Currently, there is no arbitration among processors for low priority IRQ delivery. Added support for low priority arbitration to apic_bus_deliver(), using the functions introduced in [74c1222c5b579970fafdd6a8e919fbb2c88219c3] ("apic: Implement LAPIC low priority arbitration functions"). Signed-off

  1   2   3   >