Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine

2015-03-19 Thread Ian Campbell
On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: > @@ -151,6 +152,8 @@ device_hardware_setup(void) > esp_scsi_setup(); > megasas_setup(); > pvscsi_setup(); > +if (runningOnXen()) > +vtpm4hvm_setup(); Is there anything which is actually Xen specific about the driver in t

Re: [Qemu-devel] [PULL for-2.3 0/9] vnc patch queue.

2015-03-19 Thread Peter Maydell
On 18 March 2015 at 13:17, Gerd Hoffmann wrote: > Hi, > > One QMP fix from Markus, needs to go into 2.3 because it is a API fix. > A bunch of websocket fixes from Daniel, with some cleanup work. The > problems fixed are serious enouth that I don't want delay this to 2.4 > even though there are

Re: [Qemu-devel] [PATCH 2/8] exec: move rcu_read_lock/unlock to address_space_translate callers

2015-03-19 Thread Jan Kiszka
On 2015-03-18 14:21, Paolo Bonzini wrote: > @@ -2591,9 +2596,12 @@ void *address_space_map(AddressSpace *as, > } > > l = len; > +rcu_read_lock(); > mr = address_space_translate(as, addr, &xlat, &l, is_write); > + > if (!memory_access_is_direct(mr, is_write)) { > i

Re: [Qemu-devel] [PATCH v2 1/3] block-backend: Expose bdrv_write_zeroes()

2015-03-19 Thread Max Reitz
On 2015-03-19 at 08:33, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- block/block-backend.c | 11 +++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 13 insertions(+) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 0/1] Add virtio-input driver.

2015-03-19 Thread Michael S. Tsirkin
On Thu, Mar 19, 2015 at 10:13:10AM +0100, Gerd Hoffmann wrote: > Hi, > > This patch adds a virtio driver for input devices. > > Specification: > https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input > > https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007

Re: [Qemu-devel] [PATCH v2 2/3] qemu-img convert: Rewrite copying logic

2015-03-19 Thread Max Reitz
On 2015-03-19 at 08:33, Kevin Wolf wrote: The implementation of qemu-img convert is (a) messy, (b) buggy, and (c) less efficient than possible. The changes required to beat some sense into it are massive enough that incremental changes would only make my and the reviewers' life harder. So throw i

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-19 Thread Eduardo Habkost
On Wed, Mar 18, 2015 at 11:50:04AM +0530, Bharata B Rao wrote: > On Tue, Mar 17, 2015 at 11:56:04AM +0100, Andreas Färber wrote: > > Am 17.03.2015 um 09:39 schrieb Bharata B Rao: > > > On Tue, Mar 17, 2015 at 07:56:41AM +0100, Alexander Graf wrote: > > >> > > >> > > >> On 13.03.15 12:56, Bharata B

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-19 Thread jacob jacob
I was going to try this on fedora 21...now not very sure if that makes much sense.. On Thu, Mar 19, 2015 at 4:15 AM, Stefan Assmann wrote: > On 18.03.2015 23:06, Shannon Nelson wrote: >> On Wed, Mar 18, 2015 at 3:01 PM, Shannon Nelson >> wrote: >>> >>> >>> On Wed, Mar 18, 2015 at 8:40 AM, jacob

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-19 Thread jacob jacob
Hi Stefan, have you been able to get PCI passthrough working without any issues after the upgrade? Thanks Jacob On Thu, Mar 19, 2015 at 4:15 AM, Stefan Assmann wrote: > On 18.03.2015 23:06, Shannon Nelson wrote: >> On Wed, Mar 18, 2015 at 3:01 PM, Shannon Nelson >> wrote: >>> >>> >>> On Wed, Mar

Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-19 Thread Li, Liang Z
> * Li, Liang Z (liang.z...@intel.com) wrote: > > > > > First explanation, why I think this don't fix the full problem. > > > > > Whith this patch, we fix the problem where we have a dirty block > > > > > layer but basically nothing dirtying the memory on the guest (we > > > > > are moving the 20 s

Re: [Qemu-devel] [PULL 0/3] target-mips queue

2015-03-19 Thread Peter Maydell
On 18 March 2015 at 14:37, Leon Alrae wrote: > Hi, > > This pull request contains MIPS bug fixes for 2.3. > > Thanks, > Leon > > Cc: Peter Maydell > Cc: Aurelien Jarno > > The following changes since commit 5a4992834daec85c3913654903fb9f4f954e585a: > > Merge remote-tracking branch > 'remotes/

Re: [Qemu-devel] [PATCH] fdc: remove sparc sun4m mutations

2015-03-19 Thread Mark Cave-Ayland
On 14/03/15 16:50, Hervé Poussineau wrote: > They were introduced in 6f7e9aec5eb5bdfa57a9e458e391b785c283a007 and > 82407d1a4035e5bfefb53ffdcb270872f813b34c and lots of bug fixes were done > after that. > > This fixes (at least) the detection of the floppy controller on Debian > 4.0r9/SPARC, >

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-19 Thread Stefan Assmann
On 19.03.2015 15:04, jacob jacob wrote: > Hi Stefan, > have you been able to get PCI passthrough working without any issues > after the upgrade? My XL710 fails to transfer regular TCP traffic (netperf). If that works for you then you're already one step ahead of me. Afraid I can't help you there.

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-19 Thread Li, Liang Z
> >> The command takes a list of key-value pairs. Looks like this > >> (example stolen from your patch to qmp-commands.hx): > >> > >> { "execute": "migrate-set-parameters", > >> "arguments": { "parameters": > >> [ { "parameter": "compress-level", "value": 1 } > >> ]

Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-19 Thread Eric Blake
On 03/19/2015 05:29 AM, Kevin Wolf wrote: > Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben: >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit >> b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUN

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-19 Thread Eric Blake
On 03/18/2015 08:30 PM, Li, Liang Z wrote: >>> +'migrate-set-parameters', >>> + 'data': { 'parameters': ['MigrationParameterStatus'] } } >> >> The command takes a list of key-value pairs. Looks like this (example stolen >> from your patch to qmp-commands.hx): >> >> { "execute": "migrate-set-

Re: [Qemu-devel] [PATCH 2/8] exec: move rcu_read_lock/unlock to address_space_translate callers

2015-03-19 Thread Jan Kiszka
On 2015-03-19 14:27, Jan Kiszka wrote: > On 2015-03-18 14:21, Paolo Bonzini wrote: >> @@ -2591,9 +2596,12 @@ void *address_space_map(AddressSpace *as, >> } >> >> l = len; >> +rcu_read_lock(); >> mr = address_space_translate(as, addr, &xlat, &l, is_write); >> + >> if (!memo

Re: [Qemu-devel] [PATCH 1/1] hw/arm/virt: Make host as default CPU type on AArch64

2015-03-19 Thread Peter Maydell
On 19 March 2015 at 14:53, Wei Huang wrote: > Currently mach-virt machine model uses cortex-a15 as default CPU when > -cpu option is missing. This caused confusion to certain virt tools > (e.g. libvirt, virt-install) which don't suppply -cpu option while > invoking qemu-kvm. To solve this problem

Re: [Qemu-devel] [PULL for-2.3 00/13] usb patch queue.

2015-03-19 Thread Gerd Hoffmann
On Do, 2015-03-19 at 12:11 +, Peter Maydell wrote: > On 18 March 2015 at 13:07, Gerd Hoffmann wrote: > > Hi, > > > > Here is the usb patch queue for 2.3-rc1. Grow a bit larger than I'd > > like it to be. But I've somehow missed I had patches lingering in the > > usb queue while preparing t

Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-19 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > * Li, Liang Z (liang.z...@intel.com) wrote: > > > > > > First explanation, why I think this don't fix the full problem. > > > > > > Whith this patch, we fix the problem where we have a dirty block > > > > > > layer but basically nothing dirtying the m

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some qemu-img convert tests

2015-03-19 Thread Max Reitz
On 2015-03-19 at 10:44, Max Reitz wrote: On 2015-03-19 at 08:33, Kevin Wolf wrote: This adds a regression test for some problems that the qemu-img convert rewrite just fixed. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/122 | 223 + tests

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Some qemu-img convert tests

2015-03-19 Thread Max Reitz
On 2015-02-18 at 10:19, Kevin Wolf wrote: This adds a regression test for some problems that the qemu-img convert rewrite just fixed. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/122 | 83 ++ tests/qemu-iotests/122.out | 30

Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

2015-03-19 Thread Gerd Hoffmann
On Do, 2015-03-19 at 12:37 +0100, Michael S. Tsirkin wrote: > On Thu, Mar 19, 2015 at 12:33:01PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > Adding not-yet upstream files to the list of headers to sync over from > > > > linux isn't sane IMHO. > > > > > > > > cheers, > > > > Gerd > > > >

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Some qemu-img convert tests

2015-03-19 Thread Max Reitz
On 2015-03-19 at 10:41, Max Reitz wrote: On 2015-02-18 at 10:19, Kevin Wolf wrote: This adds a regression test for some problems that the qemu-img convert rewrite just fixed. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/122 | 83 ++ test

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some qemu-img convert tests

2015-03-19 Thread Max Reitz
On 2015-03-19 at 08:33, Kevin Wolf wrote: This adds a regression test for some problems that the qemu-img convert rewrite just fixed. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/122 | 223 + tests/qemu-iotests/122.out | 209 +++

[Qemu-devel] [PATCH 1/1] hw/arm/virt: Make host as default CPU type on AArch64

2015-03-19 Thread Wei Huang
Currently mach-virt machine model uses cortex-a15 as default CPU when -cpu option is missing. This caused confusion to certain virt tools (e.g. libvirt, virt-install) which don't suppply -cpu option while invoking qemu-kvm. To solve this problem this patch changes the default CPU type to "host" whe

Re: [Qemu-devel] [PATCH 0/1] Add virtio-input driver.

2015-03-19 Thread Gerd Hoffmann
On Do, 2015-03-19 at 14:35 +0100, Michael S. Tsirkin wrote: > On Thu, Mar 19, 2015 at 10:13:10AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > This patch adds a virtio driver for input devices. > > > > Specification: > > https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input > > > > htt

Re: [Qemu-devel] [PATCH] fdc: remove sparc sun4m mutations

2015-03-19 Thread Mark Cave-Ayland
On 17/03/15 06:43, Hervé Poussineau wrote: > Hi, > > Le 16/03/2015 22:48, John Snow a écrit : >> On 03/14/2015 12:50 PM, Hervé Poussineau wrote: >>> They were introduced in 6f7e9aec5eb5bdfa57a9e458e391b785c283a007 and >>> 82407d1a4035e5bfefb53ffdcb270872f813b34c and lots of bug fixes were >>> don

[Qemu-devel] [RFC PATCH] libcacard: Fix bug detected with 'smatch'

2015-03-19 Thread Thomas Huth
'smatch' complains about two bugs and one style issue in card_7816.c: libcacard/card_7816.c:273 vcard_apdu_set_length() warn: should this be a bitwise op? libcacard/card_7816.c:295 vcard_apdu_set_length() warn: should this be a bitwise op? libcacard/card_7816.c:661 vcard7816_vm_process_apdu() wa

[Qemu-devel] [PULL 2/3] raw-posix: Deprecate aio=threads fallback without O_DIRECT

2015-03-19 Thread Kevin Wolf
Currently, if the user requests aio=native, but forgets to choose a cache mode that sets O_DIRECT, that request is silently ignored and raw falls back to aio=threads. Deprecate that behaviour so we can make it an error in future qemu versions. Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbru

[Qemu-devel] [PULL 0/3] Block patches for 2.3.0-rc1

2015-03-19 Thread Kevin Wolf
The following changes since commit cd232acfa0d70002fed89e9293f04afda577a513: Update version for v2.3.0-rc0 release (2015-03-17 18:58:33 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to 5b347c541017b9ced10e8e9bce0

[Qemu-devel] [PULL 3/3] block: Fix blockdev-backup not to use funky error class

2015-03-19 Thread Kevin Wolf
From: Markus Armbruster Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace them. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-

[Qemu-devel] [PULL 1/3] raw-posix: Deprecate host floppy passthrough

2015-03-19 Thread Kevin Wolf
From: Markus Armbruster Raise your hand if you have a physical floppy drive in a computer you've powered on in 2015. Okay, I see we got a few weirdos in the audience. That's okay, weirdos are welcome here. Kidding aside, media change detection doesn't fully work, isn't going to be fixed, and f

[Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-19 Thread Alberto Garcia
This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 5 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 7 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 0/3] Add bdrv_get_device_or_node_name()

2015-03-19 Thread Alberto Garcia
We have several cases of error messages related to BlockDriverState that expect it to have a device name. However many of those can happen in nodes that don't have a device name associated so the generated error messages are not very meaningful. This series adds a new function bdrv_get_device_o

[Qemu-devel] [PATCH 3/3] block: allow BLOCK_IMAGE_CORRUPTED to have a node name

2015-03-19 Thread Alberto Garcia
Since this event can occur in nodes that don't have a device name associated, use the node name as fallback in those cases. Signed-off-by: Alberto Garcia --- block/qcow2.c | 5 +++-- docs/qmp/qmp-events.txt | 2 +- qapi/block-core.json| 2 +- 3 files changed, 5 insertions(+), 4 del

[Qemu-devel] [PATCH 2/3] block: use bdrv_get_device_or_node_name() in error messages

2015-03-19 Thread Alberto Garcia
There are several error messages that identify a BlockDriverState by its device name. However those errors can be produced in nodes that don't have a device name associated. In those cases we should use bdrv_get_device_or_node_name() to fall back to the node name and produce a more meaningful mess

Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

2015-03-19 Thread Michael S. Tsirkin
On Thu, Mar 19, 2015 at 03:38:59PM +0100, Gerd Hoffmann wrote: > On Do, 2015-03-19 at 12:37 +0100, Michael S. Tsirkin wrote: > > On Thu, Mar 19, 2015 at 12:33:01PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > Adding not-yet upstream files to the list of headers to sync over from > > > >

Re: [Qemu-devel] [PATCH v2 for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-19 Thread Andreas Färber
Am 18.03.2015 um 17:38 schrieb Igor Mammedov: > since commit >dd0247e0 pc: acpi: mark all possible CPUs as enabled in SRAT > Linux kernel actually tries to use CPU to Node mapping from > QEMU provided SRAT table instead of discarding it, and that > in some cases breaks build_sched_domains() whi

Re: [Qemu-devel] [PATCH v2 for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-19 Thread Igor Mammedov
On Thu, 19 Mar 2015 17:05:13 +0100 Andreas Färber wrote: > Am 18.03.2015 um 17:38 schrieb Igor Mammedov: > > since commit > >dd0247e0 pc: acpi: mark all possible CPUs as enabled in SRAT > > Linux kernel actually tries to use CPU to Node mapping from > > QEMU provided SRAT table instead of dis

Re: [Qemu-devel] [PATCH v2 1/5] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-03-19 Thread Laszlo Ersek
On 03/19/15 01:18, Gabriel L. Somlo wrote: > +=== Revision (Key 0x0001, FW_CFG_ID) === > + > +A 32-bit little-endian unsigned int, this item is used as an interface > +revision number, and is currently set to 1 by all QEMU architectures > +which expose a fw_cfg device. arm/virt doesn't :) It cou

Re: [Qemu-devel] [PATCH v2 2/5] fw_cfg: remove support for guest-side data writes

2015-03-19 Thread Laszlo Ersek
On 03/19/15 01:18, Gabriel L. Somlo wrote: > From this point forward, any guest-side writes to the fw_cfg > data register will be treated as no-ops. This patch also removes > the unused host-side API function fw_cfg_add_callback(), which > allowed the registration of a callback to be executed each

Re: [Qemu-devel] [PATCH v2 3/5] fw_cfg: prevent selector key conflict

2015-03-19 Thread Laszlo Ersek
On 03/19/15 01:18, Gabriel L. Somlo wrote: > Enforce a single assignment of data for each distinct selector key. > > Signed-off-by: Gabriel Somlo > --- > hw/nvram/fw_cfg.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index 2f609b4..659de4c 100

Re: [Qemu-devel] [PATCH v2 for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-19 Thread Andreas Färber
Igor, Some minor nits I overlooked: Am 18.03.2015 um 17:38 schrieb Igor Mammedov: > since commit "Since" :) >dd0247e0 pc: acpi: mark all possible CPUs as enabled in SRAT > Linux kernel actually tries to use CPU to Node mapping from > QEMU provided SRAT table instead of discarding it, and th

[Qemu-devel] [PATCH] checkrom: Fix typo in error message

2015-03-19 Thread Andreas Färber
increate -> increase Signed-off-by: Andreas Färber --- scripts/checkrom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkrom.py b/scripts/checkrom.py index 377277d..aced5e2 100755 --- a/scripts/checkrom.py +++ b/scripts/checkrom.py @@ -39,7 +39,7 @@ def main():

Re: [Qemu-devel] [PATCH 2/8] exec: move rcu_read_lock/unlock to address_space_translate callers

2015-03-19 Thread Paolo Bonzini
On 19/03/2015 15:55, Jan Kiszka wrote: >> > >> > What is this patch based on? Do you have a public branch where I can >> > find the series and its dependencies? > Think I found the series: > http://thread.gmane.org/gmane.comp.emulators.qemu/326076. At least it > builds and runs. Yes, it's the c

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-19 Thread Shannon Nelson
On Thu, Mar 19, 2015 at 1:15 AM, Stefan Assmann wrote: > Interesting, the following might explain why my XL710 feels a bit > sketchy then. ;-) > # ethtool -i p4p1 > driver: i40e > version: 1.2.37-k > firmware-version: f4.22.26225 a1.1 n4.24 e12ef > Looks like the firmware on this NIC is even older

Re: [Qemu-devel] [PATCH v2 for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-19 Thread Igor Mammedov
On Thu, 19 Mar 2015 17:21:39 +0100 Andreas Färber wrote: I'll fix the rest of comments. > > Isn't the 5 wrong here? I would expect sockets, cores and threads > overriding that value to 8. 5 is correct here it's number of present at boot VCPUs while "sockets=2,cores=4,threads=1" defines system

Re: [Qemu-devel] [PATCH 0/1] Add virtio-input driver.

2015-03-19 Thread Michael S. Tsirkin
On Thu, Mar 19, 2015 at 03:46:44PM +0100, Gerd Hoffmann wrote: > On Do, 2015-03-19 at 14:35 +0100, Michael S. Tsirkin wrote: > > On Thu, Mar 19, 2015 at 10:13:10AM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > This patch adds a virtio driver for input devices. > > > > > > Specification: > >

Re: [Qemu-devel] [PATCH v2 4/5] fw_cfg: prohibit insertion of duplicate fw_cfg file names

2015-03-19 Thread Laszlo Ersek
On 03/19/15 01:18, Gabriel L. Somlo wrote: > Exit with an error (instead of simply logging a trace event) > whenever the same fw_cfg file name is added multiple times via > one of the fw_cfg_add_file[_callback]() host-side API calls. > > Signed-off-by: Gabriel Somlo > --- > hw/nvram/fw_cfg.c | 1

Re: [Qemu-devel] [PATCH 0/1] Add virtio-input driver.

2015-03-19 Thread Michael S. Tsirkin
On Thu, Mar 19, 2015 at 03:46:44PM +0100, Gerd Hoffmann wrote: > On Do, 2015-03-19 at 14:35 +0100, Michael S. Tsirkin wrote: > > On Thu, Mar 19, 2015 at 10:13:10AM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > This patch adds a virtio driver for input devices. > > > > > > Specification: > >

Re: [Qemu-devel] [PULL 00/24] Trivial patches for 2015-03-19

2015-03-19 Thread Peter Maydell
On 19 March 2015 at 09:05, Michael Tokarev wrote: > Here's another trivial-patches pull request, it comes very close to > the release because I was too busy last 2 weeks to do anything useful > with the trivial-patches queue, and because it accumulated quite a few > patches since that. > > Here, t

Re: [Qemu-devel] [RFC PATCH 0/3] KVM: Introduce KVM_MEM_UNCACHED

2015-03-19 Thread Paolo Bonzini
On 18/03/2015 20:10, Andrew Jones wrote: > Introduce a new memory region flag, KVM_MEM_UNCACHED, which > is needed by ARM. This flag informs KVM that the given memory > region is typically mapped by the guest as uncached. KVM for > ARM then maps that region as uncached for userspace as well, > in

Re: [Qemu-devel] [PATCH 0/1] Add virtio-input driver.

2015-03-19 Thread Paolo Bonzini
On 19/03/2015 17:33, Michael S. Tsirkin wrote: > On Thu, Mar 19, 2015 at 03:46:44PM +0100, Gerd Hoffmann wrote: >> Latest. As far I know there never ever have been incompatible changes >> to the interface, and given this is userspace/kernel abi I don't expect >> that to happen in the future. >

[Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default VCPUs to node mapping

2015-03-19 Thread Igor Mammedov
Changes since v2: - fix spelling errors - split out PC hunks itno a separate patch Igor Mammedov (2): numa: introduce machine callback for VCPU to node mapping pc: fix default VCPU to NUMA node mapping hw/i386/pc.c | 9 + include/hw/boards.h | 5 + include/sysemu/n

[Qemu-devel] [PATCH v3 for-2.3 1/2] numa: introduce machine callback for VCPU to node mapping

2015-03-19 Thread Igor Mammedov
Current default round-robin way of distributing VCPUs among NUMA nodes might be wrong in case on multi-core/threads CPUs. Making guests confused wrt topology where cores from the same socket are on different nodes. Allow a machine to override default mapping by providing MachineClass->cpu_index_t

[Qemu-devel] [PATCH v3 for-2.3 2/2] pc: fix default VCPU to NUMA node mapping

2015-03-19 Thread Igor Mammedov
Since commit dd0247e0 pc: acpi: mark all possible CPUs as enabled in SRAT Linux kernel actually tries to use CPU to Node mapping from QEMU provided SRAT table instead of discarding it, and that in some cases breaks build_sched_domains() which expects sane mapping where cores/threads belonging to

Re: [Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default VCPUs to node mapping

2015-03-19 Thread Andreas Färber
Am 19.03.2015 um 18:09 schrieb Igor Mammedov: > Changes since v2: > - fix spelling errors > - split out PC hunks itno a separate patch > > Igor Mammedov (2): > numa: introduce machine callback for VCPU to node mapping > pc: fix default VCPU to NUMA node mapping Reviewed-by: Andreas Färber

Re: [Qemu-devel] [PATCH v3 for-2.3 1/2] numa: introduce machine callback for VCPU to node mapping

2015-03-19 Thread Andreas Färber
Am 19.03.2015 um 18:09 schrieb Igor Mammedov: > Current default round-robin way of distributing VCPUs among > NUMA nodes might be wrong in case on multi-core/threads > CPUs. Making guests confused wrt topology where cores from > the same socket are on different nodes. > > Allow a machine to overri

[Qemu-devel] Setting FW_CFG_ID (was: [PATCH] fw_cfg: add documentation file)

2015-03-19 Thread Gabriel L. Somlo
On Thu, Mar 19, 2015 at 05:14:04PM +0100, Laszlo Ersek wrote: > On 03/19/15 01:18, Gabriel L. Somlo wrote: > > > +=== Revision (Key 0x0001, FW_CFG_ID) === > > + > > +A 32-bit little-endian unsigned int, this item is used as an interface > > +revision number, and is currently set to 1 by all QEMU a

[Qemu-devel] [PATCH v12 1/9] linux-headers: update VFIO header for VFIO platform/amba drivers

2015-03-19 Thread Eric Auger
Update according to the vfio.h header found in ssh://g...@git.linaro.org/people/eric.auger/linux.git branch 4.0-rc3-v14 --- v10 -> v11: - only includes header modifications related to vfio platform driver v14 and not those related to "vfio: type1: support for ARM SMMUS with VFIO_IOMMU_TYPE1"

[Qemu-devel] [PATCH v12 5/9] hw/arm/virt: start VFIO IRQ propagation

2015-03-19 Thread Eric Auger
Although the dynamic instantiation of VFIO QEMU devices already is possible, VFIO IRQ signaling is not yet started. This patch enables IRQ forwarding by registering a reset notifier that kick off VFIO signaling for all VFIO devices. Such mechanism is requested because the VFIO IRQ binding is handl

[Qemu-devel] [PATCH v12 4/9] hw/vfio/platform: add capability to start IRQ propagation

2015-03-19 Thread Eric Auger
Add a reset notify function that enables to start the propagation of interrupts to the guest. Signed-off-by: Eric Auger --- v10 -> v11: - comment reword v8 -> v9: - handle failure in vfio_irq_starter --- hw/vfio/platform.c | 64 + include/hw

[Qemu-devel] [PATCH v12 3/9] hw/vfio/platform: add irq assignment

2015-03-19 Thread Eric Auger
This patch adds the code requested to assign interrupts to a guest. The interrupts are mediated through user handled eventfds only. The mechanics to start the IRQ handling is not yet there through. Signed-off-by: Eric Auger --- v10 -> v11: - use block declaration when possible - change order of

[Qemu-devel] [PATCH v12 9/9] hw/vfio/platform: add irqfd support

2015-03-19 Thread Eric Auger
This patch aims at optimizing IRQ handling using irqfd framework. Instead of handling the eventfds on user-side they are handled on kernel side using - the KVM irqfd framework, - the VFIO driver virqfd framework. the virtual IRQ completion is trapped at interrupt controller This removes the need

[Qemu-devel] [PATCH v12 2/9] hw/vfio/platform: vfio-platform skeleton

2015-03-19 Thread Eric Auger
Minimal VFIO platform implementation supporting register space user mapping but not IRQ assignment. Signed-off-by: Kim Phillips Signed-off-by: Eric Auger --- v11 -> v12: - add x-mmap property definition, without which the default value of vbasedev.allow_mmap is false, hence preventing the reg

[Qemu-devel] [PATCH v12 0/9] KVM platform device passthrough

2015-03-19 Thread Eric Auger
This series aims at enabling KVM platform device passthrough. Kernel dependencies were pulled for 4.1-rc0 (vfio platform driver and irqfd for ARM) This series now only relies on the following QEMU series that allows to instantiate the VFIO platform device from QEMU command line: [1] [PATCH v11 0

[Qemu-devel] [PATCH v12 6/9] hw/vfio/platform: calxeda xgmac device

2015-03-19 Thread Eric Auger
The platform device class has become abstract. This patch introduces a calxeda xgmac device that derives from it. Signed-off-by: Eric Auger Reviewed-by: Alex Bennée --- v10 -> v11: - add Alex Reviewed-by - move virt modifications in a separate patch v8 -> v9: - renamed calxeda_xgmac.c into cal

[Qemu-devel] [PATCH v12 8/9] linux-headers: update arm/arm64 KVM headers for irqfd

2015-03-19 Thread Eric Auger
Update according to arm/arm64 kvm.h headers found in ssh://git.linaro.org/people/eric.auger/linux.git branch irqfd_v9_stdalone_official_release Signed-off-by: Eric Auger --- linux-headers/asm-arm/kvm.h | 3 +++ linux-headers/asm-arm64/kvm.h | 3 +++ 2 files changed, 6 insertions(+) diff --git

[Qemu-devel] [PATCH v12 7/9] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-03-19 Thread Eric Auger
This patch allows the instantiation of the vfio-calxeda-xgmac device from the QEMU command line (-device vfio-calxeda-xgmac,host=""). A specialized device tree node is created for the guest, containing compat, dma-coherent, reg and interrupts properties. Signed-off-by: Eric Auger --- v10 -> v11

Re: [Qemu-devel] [RFC PATCH 0/3] KVM: Introduce KVM_MEM_UNCACHED

2015-03-19 Thread Andrew Jones
On Thu, Mar 19, 2015 at 05:56:20PM +0100, Paolo Bonzini wrote: > > > On 18/03/2015 20:10, Andrew Jones wrote: > > Introduce a new memory region flag, KVM_MEM_UNCACHED, which > > is needed by ARM. This flag informs KVM that the given memory > > region is typically mapped by the guest as uncached.

Re: [Qemu-devel] Setting FW_CFG_ID (was: [PATCH] fw_cfg: add documentation file)

2015-03-19 Thread Paolo Bonzini
On 19/03/2015 18:14, Gabriel L. Somlo wrote: > I'd be happy to add a patch factoring out the call to > > fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); > > into fw_cfg_init1(), which would then make it consistent across all > architectures, including arm/virt. Yes, please---this should be a 2.3 bl

Re: [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-19 Thread Laszlo Ersek
On 03/19/15 01:18, Gabriel L. Somlo wrote: > Allow user supplied files to be inserted into the fw_cfg > device before starting the guest. Since fw_cfg_add_file() > already disallows duplicate fw_cfg file names, qemu will > exit with an error message if the user supplies multiple > blobs with the sa

Re: [Qemu-devel] [PATCH v3 for-2.3 0/2] numa: Fix default VCPUs to node mapping

2015-03-19 Thread Eduardo Habkost
On Thu, Mar 19, 2015 at 06:13:42PM +0100, Andreas Färber wrote: > Am 19.03.2015 um 18:09 schrieb Igor Mammedov: > > Changes since v2: > > - fix spelling errors > > - split out PC hunks itno a separate patch > > > > Igor Mammedov (2): > > numa: introduce machine callback for VCPU to node mappin

Re: [Qemu-devel] [PULL v2 for-2.3] virtio-serial: guest_writable callback

2015-03-19 Thread Peter Maydell
On 19 March 2015 at 12:09, Amit Shah wrote: > The following changes since commit 17b11a1406fdc43b5022f32a6fbfcb005a353b38: > > Merge remote-tracking branch > 'remotes/bkoppelmann/tags/pull-tricore-20150316' into staging (2015-03-16 > 18:27:13 +) > > are available in the git repository at:

[Qemu-devel] [PATCH for-2.3] fw_cfg-test: Fix test path to include architecture

2015-03-19 Thread Andreas Färber
Use qtest_add_func() instead of g_test_add_func() to reflect the architecture tested, changing GTester paths as follows: /fw_cfg/foo -> /x86_64/fw_cfg/foo etc. Signed-off-by: Andreas Färber --- tests/fw_cfg-test.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions

Re: [Qemu-devel] [PATCH for-2.3] fw_cfg-test: Fix test path to include architecture

2015-03-19 Thread Andreas Färber
Am 19.03.2015 um 18:47 schrieb Andreas Färber: > Use qtest_add_func() instead of g_test_add_func() to reflect > the architecture tested, changing GTester paths as follows: > > /fw_cfg/foo -> /x86_64/fw_cfg/foo etc. > Actually this should even be Cc: qemu-sta...@nongnu.org It's been wrong sin

Re: [Qemu-devel] [PATCH] fdc: remove sparc sun4m mutations

2015-03-19 Thread John Snow
On 03/19/2015 10:25 AM, Mark Cave-Ayland wrote: On 17/03/15 06:43, Hervé Poussineau wrote: Hi, Le 16/03/2015 22:48, John Snow a écrit : On 03/14/2015 12:50 PM, Hervé Poussineau wrote: They were introduced in 6f7e9aec5eb5bdfa57a9e458e391b785c283a007 and 82407d1a4035e5bfefb53ffdcb270872f813b

Re: [Qemu-devel] [PATCH 2/2] target-i386: Haswell-noTSX and Broadwell-noTSX

2015-03-19 Thread Eduardo Habkost
On Mon, Mar 16, 2015 at 10:24:51AM +, Daniel P. Berrange wrote: > On Fri, Mar 13, 2015 at 04:09:57PM -0300, Eduardo Habkost wrote: > > With the Intel microcode update that removed HLE and RTM, there will be > > different kinds of Haswell and Broadwell CPUs out there: some that still > > have th

[Qemu-devel] [PATCH] fw_cfg: factor out initialization of FW_CFG_ID (rev. number)

2015-03-19 Thread Gabriel L. Somlo
Signed-off-by: Gabriel Somlo --- On Thu, Mar 19, 2015 at 06:25:15PM +0100, Paolo Bonzini wrote: > On 19/03/2015 18:14, Gabriel L. Somlo wrote: > > I'd be happy to add a patch factoring out the call to > > > > fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); > > > > into fw_cfg_init1(), which would th

Re: [Qemu-devel] [PATCH 2/2] target-i386: Haswell-noTSX and Broadwell-noTSX

2015-03-19 Thread Daniel P. Berrange
On Thu, Mar 19, 2015 at 03:02:27PM -0300, Eduardo Habkost wrote: > On Mon, Mar 16, 2015 at 10:24:51AM +, Daniel P. Berrange wrote: > > On Fri, Mar 13, 2015 at 04:09:57PM -0300, Eduardo Habkost wrote: > > > With the Intel microcode update that removed HLE and RTM, there will be > > > different k

Re: [Qemu-devel] [PATCH v5 05/13] block: Move BDS close notifiers into BB

2015-03-19 Thread Eric Blake
On 03/03/2015 01:13 PM, Max Reitz wrote: > The only remaining user of the BDS close notifiers is NBD which uses > them to determine when a BDS tree is being ejected. This patch removes > the BDS-level close notifiers and adds a notifier list to the > BlockBackend structure that is invoked whenever

[Qemu-devel] [PATCH v2] fw_cfg: factor out initialization of FW_CFG_ID (rev. number)

2015-03-19 Thread Gabriel L. Somlo
Signed-off-by: Gabriel Somlo --- And, once again, this time after testing and making sure semicolons were't inadvertently left out :) Sorry for all the noise, Gabriel >On Thu, Mar 19, 2015 at 06:25:15PM +0100, Paolo Bonzini wrote: >>On 19/03/2015 18:14, Gabriel L. Somlo wrote: >>> I'd be happ

Re: [Qemu-devel] [PATCH 6/6] qga: RFC: guest-side retrieval of fw_cfg file

2015-03-19 Thread Kevin O'Connor
On Tue, Mar 17, 2015 at 01:38:06PM +0100, Laszlo Ersek wrote: > On 03/16/15 15:15, Gabriel L. Somlo wrote: > > 1. I can't for the life of me figure out how to stop gcc -O2 > > from assuming the if() test below is ALWAYS FALSE, and thus > > optimizing it out completely. For now I've forc

Re: [Qemu-devel] Emulation failure on booting/rebooting VMs

2015-03-19 Thread Mohammed Gamal
On Wed, Mar 18, 2015 at 7:09 PM, Kevin O'Connor wrote: > On Wed, Mar 18, 2015 at 06:36:48PM +0100, Mohammed Gamal wrote: > > Hi, > > I've been sporadically getting my KVM virtual machines crashing with this > > message while they're booting > > > > KVM internal error. Suberror: 1 > > emulation fa

Re: [Qemu-devel] [PATCH 6/6] qga: RFC: guest-side retrieval of fw_cfg file

2015-03-19 Thread Laszlo Ersek
On 03/19/15 19:27, Kevin O'Connor wrote: > On Tue, Mar 17, 2015 at 01:38:06PM +0100, Laszlo Ersek wrote: >> On 03/16/15 15:15, Gabriel L. Somlo wrote: >>> 1. I can't for the life of me figure out how to stop gcc -O2 >>> from assuming the if() test below is ALWAYS FALSE, and thus >>> opt

Re: [Qemu-devel] [PULL 0/3] Block patches for 2.3.0-rc1

2015-03-19 Thread Peter Maydell
On 19 March 2015 at 15:16, Kevin Wolf wrote: > The following changes since commit cd232acfa0d70002fed89e9293f04afda577a513: > > Update version for v2.3.0-rc0 release (2015-03-17 18:58:33 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream >

Re: [Qemu-devel] [PATCH v2] fw_cfg: factor out initialization of FW_CFG_ID (rev. number)

2015-03-19 Thread Laszlo Ersek
On 03/19/15 19:20, Gabriel L. Somlo wrote: > Signed-off-by: Gabriel Somlo > --- > > And, once again, this time after testing and making sure semicolons > were't inadvertently left out :) > > Sorry for all the noise, > Gabriel > >> On Thu, Mar 19, 2015 at 06:25:15PM +0100, Paolo Bonzini wrote:

[Qemu-devel] [PATCH V6 for-2.3 00/26] hw/pc: implement multiple primary busses for pc machines

2015-03-19 Thread Marcel Apfelbaum
Notes: - I realize that this qualifies as a late submission, but the code was arround a lot of time and got lots of reviews and it also tested (by Gerd), so should be mature enough. - This series is not that big, patches 1-8 are really small and can be submitted separately, however I pref

[Qemu-devel] [PATCH v2 0/2] block: driver should override flags in bdrv_open()

2015-03-19 Thread Max Reitz
BDRV_O_PROTOCOL is an internal qemu flag which a user should be able to override by explicitly specifying a block driver. This series implements this and adds two iotests (one for NBD, one for file) to test it. v2 (rebase on current master): - Patch 1: Conflict in iotest 051's reference output (i

[Qemu-devel] [PATCH V6 for-2.3 02/26] acpi: add aml_add() term

2015-03-19 Thread Marcel Apfelbaum
Add encoding for ACPI DefAdd Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index daba474..b01fb99 1

[Qemu-devel] [PATCH V6 for-2.3 07/26] acpi: add aml_increment() term

2015-03-19 Thread Marcel Apfelbaum
Add encoding for ACPI DefIncrement Opcode. Reviewed-by: Shannon Zhao Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-buil

[Qemu-devel] [PATCH v2 2/2] iotests: Add tests for overriding BDRV_O_PROTOCOL

2015-03-19 Thread Max Reitz
This adds tests for overriding the qemu-internal BDRV_O_PROTOCOL flag by explicitly specifying a block driver. As one test must be run over the NBD protocol while the other must not, this patch adds two separate iotests. Signed-off-by: Max Reitz --- tests/qemu-iotests/119 | 60 ++

[Qemu-devel] [PATCH V6 for-2.3 04/26] acpi: add aml_index() term

2015-03-19 Thread Marcel Apfelbaum
Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index e44a221..ad8c04d 100644 --- a/hw/acpi/aml-bu

[Qemu-devel] [PATCH V6 for-2.3 01/26] acpi: add aml_or() term

2015-03-19 Thread Marcel Apfelbaum
Add encoding for ACPI DefOr Opcode. Reviewed-by: Shannon Zhao Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.

[Qemu-devel] [PATCH V6 for-2.3 10/26] hw/pci: made pci_bus_is_root a PCIBusClass method

2015-03-19 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Refactoring it as a method of PCIBusClass will allow different implementations for subclasses. Removed the assumption that the root bus does not have a parent device because is specific only to the default class implementation. Signed-off-by: Marcel Apfelbaum --- hw/pci

[Qemu-devel] [PATCH v2 1/2] block: driver should override flags in bdrv_open()

2015-03-19 Thread Max Reitz
The BDRV_O_PROTOCOL flag should have an impact only if no driver is specified explicitly. Therefore, if bdrv_open() is called with an explicit block driver argument (either through the options QDict or through the drv parameter) and that block driver is a protocol block driver, BDRV_O_PROTOCOL shou

[Qemu-devel] [PATCH V6 for-2.3 08/26] acpi: add aml_while() term

2015-03-19 Thread Marcel Apfelbaum
Add encoding for ACPI DefWhile Opcode. Reviewed-by: Shannon Zhao Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c

[Qemu-devel] [PATCH V6 for-2.3 06/26] acpi: add aml_shiftright() term

2015-03-19 Thread Marcel Apfelbaum
Add encoding for ACPI DefShiftRight Opcode. Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 428ea47..64

[Qemu-devel] [PATCH V6 for-2.3 15/26] hw/acpi: add support for i440fx 'snooping' root busses

2015-03-19 Thread Marcel Apfelbaum
If the machine has extra root busses that are snooping to the i440fx host bridge, we need to add them to acpi in order to be properly detected by guests. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 30 -- hw/pci-host/piix.c | 4 ++-- include/hw/i386/

<    1   2   3   >