[Qemu-devel] [PATCH] PPC: pseries: Implement boot once=foo

2015-03-18 Thread Alexander Graf
On sPAPR we haven't supported boot once ever since it emerged, but recently grew need for it. This patch implements boot once logic to it. While at it, we also move to the new bootdevice handling that got introduced to the tree recently. Reported-by: Dinar Valeev Signed-off-by: Alexander Graf -

Re: [Qemu-devel] [PATCH V4 18/19] pci: remove hard-coded bar size in msix_init_exclusive_bar()

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 05:35:08PM +0800, Jason Wang wrote: > This patch let msix_init_exclusive_bar() can accept bar_size parameter > other than a hard-coded limit 4096. Then caller can specify a bar_size > depends on msix entries and can use up to 2048 msix entries as PCI > spec allows. To keep m

Re: [Qemu-devel] [PATCH V4 19/19] virtio-pci: introduce auto_msix_bar_size property

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 05:35:09PM +0800, Jason Wang wrote: > Currently we don't support more than 128 MSI-X vectors for a pci > devices, trying to use vector=129 for a virtio-net-pci device may get: > > qemu-system-x86_64: -device virtio-net-pci,netdev=hn0,vectors=129: > unable to init msix vecto

Re: [Qemu-devel] [RFC PATCH 03/14] quorum: ignore 0-length child

2015-03-18 Thread Max Reitz
On 2015-03-18 at 01:29, Wen Congyang wrote: On 02/24/2015 04:43 AM, Max Reitz wrote: On 2015-02-11 at 22:07, Wen Congyang wrote: We connect to NBD server when starting block replication, so the length is 0 before starting block replication. Signed-off-by: Wen Congyang Signed-off-by: zhanghail

Re: [Qemu-devel] [PATCH V4 00/19] Support more virtio queues

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 05:34:50PM +0800, Jason Wang wrote: > We current limit the max virtio queues to 64. This is not sufficient > to support multiqueue devices (e.g recent Linux support up to 256 > tap queues). So this series tries to let virtio to support more queues. > > No much works need to

Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-18 Thread Paolo Bonzini
On 18/03/2015 13:36, Juan Quintela wrote: > I know that the code has changed a lot on that area, the select() don't > exist anymore. It is still there in aio_poll(): ret = qemu_poll_ns((GPollFD *)ctx->pollfds->data, ctx->pollfds->len, blocki

[Qemu-devel] [RFC PATCH] cpus: Don't kick un-inited cpus.

2015-03-18 Thread Peter Crosthwaite
following a464982499b2f637f6699e3d03e0a9d2e0b5288b, it's now possible for there to be attempts to take the BQL before CPUs have been realized in cases where a machine model inits peripherals before the first CPU. BQL lock aquisition kicks the first_cpu, leading to a segfault if this happens pre-re

Re: [Qemu-devel] [PATCH 05/11] block: add delayed bitmap successor cleanup

2015-03-18 Thread Max Reitz
On 2015-03-17 at 18:46, John Snow wrote: On 03/17/2015 02:44 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: [snip] +} +} + +BdrvDirtyBitmap *bdrv_dirty_bitmap_decref(BlockDriverState *bs, I don't know whether I'm that content with the name chosen, because you're actual

Re: [Qemu-devel] [PATCH V4 07/19] virtio-net: validate backend queue numbers against bus limitation

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 05:34:57PM +0800, Jason Wang wrote: > We don't validate the backend queue numbers against bus limitation, > this will easily crash qemu if it exceeds the limitation. Fixing this > by doing the validation and fail early. > > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wan

Re: [Qemu-devel] [PATCH V4 08/19] virtio-net: fix the upper bound when trying to delete queues

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 05:34:58PM +0800, Jason Wang wrote: > Virtqueue were indexed from zero, so don't delete virtqueue whose > index is n->max_queues * 2 + 1. > > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang Bugfix? needed on master? stable? > --- > hw/net/virtio-net.c | 2 +- > 1 fi

[Qemu-devel] [PULL 11/13] uhci: fix segfault when hot-unplugging uhci controller

2015-03-18 Thread Gerd Hoffmann
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

[Qemu-devel] [PULL for-2.3 00/13] usb patch queue.

2015-03-18 Thread Gerd Hoffmann
ng changes since commit 5a4992834daec85c3913654903fb9f4f954e585a: Merge remote-tracking branch 'remotes/armbru/tags/pull-cov-model-2015-03-17' into staging (2015-03-17 11:43:00 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20150318-1 for you

[Qemu-devel] [PULL 12/13] ohci: fix resource cleanup leak

2015-03-18 Thread Gerd Hoffmann
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

[Qemu-devel] [PULL 02/13] usb: Improve companion configuration error messages

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster The previous commit broke the additional messages explaining the error messages. Improve the error messages, so they don't need explaining so much. Helps QMP users as well, unlike additional explanations. Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann -

[Qemu-devel] [PULL 05/13] monitor: Drop dead QMP check from monitor_read_password()

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster Function is only called in HMP context since commit 333a96e "qapi: Convert change". Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Gerd Hoffmann --- monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/monitor.c b/

[Qemu-devel] [PULL 06/13] monitor: Plug memory leak in monitor_read_bdrv_key_start()

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Gerd Hoffmann --- monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/monitor.c b/monitor.c index 1b46d07..bc77415 100644 --- a/monitor.c +++ b/monitor.c @@ -5391,9 +5391,11 @@ int moni

[Qemu-devel] [PULL 13/13] ehci: fix segfault when hot-unplugging ehci controller

2015-03-18 Thread Gerd Hoffmann
From: Gonglei When hot-unplugging the usb controllers (ehci/uhci), we have to clean all resouce of these devices, involved registered reset handler. Otherwise, it may cause NULL pointer access and/or segmentation fault if we reboot the guest os after hot-unplugging. Let's hook up reset via Devic

[Qemu-devel] [PULL 04/13] uhci: Convert to realize

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 2ca8de3..e791377 100644 --- a/hw/usb/hcd-uhci.c +++ b/

[Qemu-devel] [PULL 09/13] usb/dev-storage: Avoid qerror_report_err() outside QMP handlers

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. usb_msd_password_cb() is only called from within an HMP command handler. Replace by error_report_err(). Signed-off-by: Markus Armb

[Qemu-devel] [PULL 10/13] hw/usb: Include USB files only if necessary

2015-03-18 Thread Gerd Hoffmann
From: Thomas Huth Boards that do not include an USB controller should not provide USB devices. However, when running "qemu-system-s390x -device help" for example, there's still a usb-hub, usb-kbd, usb-mouse and usb-tablet in the list of "supported" devices. Let's fix that by compiling and linking

[Qemu-devel] [PULL 07/13] monitor usb: Inline monitor_read_bdrv_key_start()'s first part

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster monitor_read_bdrv_key_start() does several things: 1. If no key is needed, call completion_cb() and succeed 2. If we're in QMP context, call qerror_report_err() and fail 3. Start reading the key in the monitor. This is two things too many. Inline 1. and 2. into its ca

[Qemu-devel] [PULL 03/13] ohci: Complete conversion to realize

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster Commit 457215ec "ohci: Use QOM realize for OHCI" converted only "sysbus-ohci". Finish the job: convert "pci-ohci". Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ohci.c | 34 +- 1 file changed, 17 insertion

Re: [Qemu-devel] [PATCH V4 06/19] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 05:34:56PM +0800, Jason Wang wrote: > There's no need to use vector 0 for invalid virtqueue. So this patch > changes to use VIRTIO_NO_VECTOR instead. > > Cc: Michael S. Tsirkin > Cc: Cornelia Huck > CC: Christian Borntraeger > Cc: Richard Henderson > Cc: Alexander Graf

[Qemu-devel] [PULL 01/13] usb: Propagate errors through usb_register_companion()

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster This loses the messages explaining the error printed with error_printf_unless_qmp(). The next commit will make up for the loss. Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- hw/usb/bus.c | 17 ++--- hw/usb/hcd-ehci.c | 23 +

[Qemu-devel] [PULL 08/13] usb/dev-storage: Fix QMP device_add missing encryption key failure

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster When the image is encrypted, QMP device_add creates the device, defers actually attaching it to when the key becomes available, then returns an error. This is wrong. device_add must either create the device and succeed, or do nothing and fail. The bug is in usb_msd_real

Re: [Qemu-devel] [RFC PATCH] cpus: Don't kick un-inited cpus.

2015-03-18 Thread Paolo Bonzini
On 18/03/2015 13:53, Peter Crosthwaite wrote: > following a464982499b2f637f6699e3d03e0a9d2e0b5288b, it's now possible for > there to be attempts to take the BQL before CPUs have been realized in > cases where a machine model inits peripherals before the first CPU. > > BQL lock aquisition kicks t

[Qemu-devel] [PULL 1/9] vnc: Fix QMP change not to use funky error class

2015-03-18 Thread Gerd Hoffmann
From: Markus Armbruster Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 +- 1 file changed, 1 insert

[Qemu-devel] [PULL 6/9] ui: fix setup of VNC websockets auth scheme with TLS

2015-03-18 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The way the websockets TLS code was integrated into the VNC server made it essentially useless. The only time that the websockets TLS support could be used is if the primary VNC server had its existing TLS support disabled. ie QEMU had to be launched with: # qemu -vn

[Qemu-devel] [PULL 8/9] ui: remove separate gnutls_session for websockets server

2015-03-18 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The previous change to the auth scheme handling guarantees we can never have nested TLS sessions in the VNC websockets server. Thus we can remove the separate gnutls_session instance. Signed-off-by: Daniel P. Berrange Signed-off-by: Gerd Hoffmann --- ui/vnc-tls.c |

Re: [Qemu-devel] [PATCH target-arm v3 04/15] arm: xlnx-zynqmp: Add GIC

2015-03-18 Thread Peter Crosthwaite
On Wed, Mar 18, 2015 at 10:26 AM, Alistair Francis wrote: > On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite > wrote: >> And connect IRQ outputs to the CPUs. >> >> Reviewed-by: Alistair Francis >> Signed-off-by: Peter Crosthwaite >> --- >> hw/arm/xlnx-zynqmp.c | 19 +

[Qemu-devel] [PULL 2/9] ui: remove unused 'wiremode' variable in VncState struct

2015-03-18 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Signed-off-by: Daniel P. Berrange Signed-off-by: Gerd Hoffmann --- ui/vnc-auth-vencrypt.c | 1 - ui/vnc-tls.c | 2 -- ui/vnc-tls.h | 7 --- ui/vnc-ws.c| 1 - 4 files changed, 11 deletions(-) diff --git a/ui/vnc-auth-vencrypt.c b/u

[Qemu-devel] [PULL for-2.3 0/9] vnc patch queue.

2015-03-18 Thread Gerd Hoffmann
u tags/pull-vnc-20150318-1 for you to fetch changes up to 4a48aaa9f52dbac148be24f591de2f28c58ccb5d: ui: ensure VNC websockets server checks the ACL if requested (2015-03-18 09:25:14 +0100) vnc: fix w

Re: [Qemu-devel] [PATCH 3/8] pci: Remove unused functions

2015-03-18 Thread Michael S. Tsirkin
On Mon, Mar 09, 2015 at 06:30:10PM +0100, Thomas Huth wrote: > The functions pcie_ari_init(), pcie_cap_is_arifwd_enabled() > and ich9_d2pbr_init() are completely unused and thus can > be deleted. > > Signed-off-by: Thomas Huth > Cc: Michael S. Tsirkin > Cc: Anthony Liguori Pls split this out t

[Qemu-devel] [PULL 3/9] ui: replace printf() calls with VNC_DEBUG

2015-03-18 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Handling of VNC audio messages results in printfs to the console. This is of no use to anyone in production, so should be using the normal VNC_DEBUG macro instead. Signed-off-by: Daniel P. Berrange Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 12 ++-- 1 file

[Qemu-devel] [PULL 5/9] ui: split setup of VNC auth scheme into separate method

2015-03-18 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The vnc_display_open method is quite long and complex, so move the VNC auth scheme decision logic into a separate method for clarity. Also update the comment to better describe what we are trying to achieve. Signed-off-by: Daniel P. Berrange Signed-off-by: Gerd Hoffm

[Qemu-devel] [PATCH 1/8] memory: Add global-locking property to memory regions

2015-03-18 Thread Paolo Bonzini
From: Jan Kiszka This introduces the memory region property "global_locking". It is true by default. By setting it to false, a device model can request BQL-free dispatching of region accesses to its r/w handlers. The actual BQL break-up will be provided in a separate patch. Signed-off-by: Jan Ki

[Qemu-devel] [PATCH for-2.4 0/8] memory: enable unlocked PIO/MMIO in KVM

2015-03-18 Thread Paolo Bonzini
And here we are... These are the changes required to make the BQL optional for memory access, and use that support in KVM. For now, only one device model is changed to do unlocked accesses. Please review! Jan Kiszka (4): memory: Add global-locking property to memory regions memory: Provide

[Qemu-devel] [PULL 7/9] ui: enforce TLS when using websockets server

2015-03-18 Thread Gerd Hoffmann
From: "Daniel P. Berrange" When TLS is required, the primary VNC server considers it to be mandatory. ie the server admin decides whether or not TLS is used, and the client has to comply with this decision. The websockets server, however, treated it as optional, allowing non-TLS clients to connec

[Qemu-devel] [PATCH 3/8] memory: Provide address_space_rw_unlocked

2015-03-18 Thread Paolo Bonzini
From: Jan Kiszka Break up address_space_rw into two version: The standard one continues to require the caller to hold BQL on invocation, the unlocked one takes or avoids BQL depending on the locking strategy of the target memory region and its coalesced MMIO handling. As memory_region_read/write

[Qemu-devel] [PULL 9/9] ui: ensure VNC websockets server checks the ACL if requested

2015-03-18 Thread Gerd Hoffmann
From: "Daniel P. Berrange" If the x509verify option is requested, the VNC websockets server was failing to validate that the websockets client provided an x509 certificate matching the ACL rules. Signed-off-by: Daniel P. Berrange Signed-off-by: Gerd Hoffmann --- ui/vnc-ws.c | 10 ++ 1

[Qemu-devel] [PATCH 4/8] kvm: First step to push iothread lock out of inner run loop

2015-03-18 Thread Paolo Bonzini
From: Jan Kiszka This opens the path to get rid of the iothread lock on vmexits in KVM mode. On x86, the in-kernel irqchips has to be used because we otherwise need to synchronize APIC and other per-cpu state accesses that could be changed concurrently. s390x and ARM should be fine without speci

[Qemu-devel] [PATCH 6/8] exec: mark unassigned_io_ops as unlocked

2015-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- exec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/exec.c b/exec.c index d60abfc..c1a2e9e 100644 --- a/exec.c +++ b/exec.c @@ -2197,6 +2197,7 @@ static void memory_map_init(void) system_io = g_malloc(sizeof(*system_io)); memory_region_init_io(sys

[Qemu-devel] [PULL 4/9] ui: report error if user requests VNC option that is unsupported

2015-03-18 Thread Gerd Hoffmann
From: "Daniel P. Berrange" If the VNC server is built without tls, sasl or websocket support and the user requests one of these features, they are just silently ignored. This is bad because it means the VNC server ends up running in a configuration that is less secure than the user asked for. It

[Qemu-devel] [PATCH 5/8] kvm: Switch to unlocked PIO

2015-03-18 Thread Paolo Bonzini
From: Jan Kiszka Do not take the BQL before dispatching PIO requests of KVM VCPUs. Instead, call the unlocked version of address_space_rw. This enables completely BQL-free PIO handling in KVM mode for upcoming devices with fine-grained locking. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bon

[Qemu-devel] [PATCH 8/8] kvm: Switch to unlocked MMIO

2015-03-18 Thread Paolo Bonzini
Do not take the BQL before dispatching MMIO requests of KVM VCPUs. Instead, call the unlocked version of address_space_rw. This enables completely BQL-free MMIO handling in KVM mode for upcoming devices with fine-grained locking. Signed-off-by: Paolo Bonzini --- kvm-all.c | 11 +-- 1 fil

Re: [Qemu-devel] [PATCH v2 3/7] pci: Remove unused function ich9_d2pbr_init()

2015-03-18 Thread Michael S. Tsirkin
On Sat, Mar 14, 2015 at 07:19:30AM +0100, Thomas Huth wrote: > The function ich9_d2pbr_init() is completely unused and > thus can be deleted. > > Signed-off-by: Thomas Huth > Cc: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin I assume all this will go in for 2.4 through the trivial tree?

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
typo in subject: vfio, not vifo. On Thu, Mar 12, 2015 at 06:23:59PM +0800, Chen Fan wrote: > for piix4 chipset, we don't need to expose aer, so introduce > PC_I440FX_COMPAT for all piix4 machines to disable aercap, > and add HW_COMPAT_2_2 to disable aercap for all lower > than 2.3. > > Signed-off

[Qemu-devel] [PATCH 2/8] exec: move rcu_read_lock/unlock to address_space_translate callers

2015-03-18 Thread Paolo Bonzini
Once address_space_translate will be called outside the BQL, the returned MemoryRegion might disappear as soon as the RCU read-side critical section ends. Avoid this by moving the critical section to the callers. Signed-off-by: Paolo Bonzini --- exec.c| 33 ++

[Qemu-devel] [PATCH 7/8] acpi: mark PMTIMER as unlocked

2015-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/acpi/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index 51913d6..954a96b 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -527,6 +527,7 @@ void acpi_pm_tmr_init(ACPIREGS *ar, acpi_update_sci_fn update_sci,

Re: [Qemu-devel] [PATCH v5 4/7] pcie_aer: expose pcie_aer_msg() interface

2015-03-18 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 06:23:56PM +0800, Chen Fan wrote: > For vfio device, we need to propagate the aer error to > Guest OS. we use the pcie_aer_msg() to send aer error > to guest. > > Signed-off-by: Chen Fan Interesting. pcie_aer_inject_error was intended as an interface to send errors to gue

Re: [Qemu-devel] [PATCH v5 6/7] vfio: add 'x-aer' property to expose aercap

2015-03-18 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 06:23:58PM +0800, Chen Fan wrote: > add 'x-aer' property to let user able to decide whether expose > the aer capability. > > Signed-off-by: Chen Fan If it's exposed to users, it should not have the x- prefix. That prefix means "internal only". > --- > hw/vfio/pci.c | 8

Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp

2015-03-18 Thread Claudio Fontana
Tested with kvm on aarch64 LE host with aarch64 LE guest, tested with tcg on aarch64 LE host with aarch64 LE/sparc BE/x86 LE guests. Would be interesting to test this also on a big endian host with different guest combinations.. Claudio On 16.03.2015 11:31, hw.clau...@gmail.com wrote: > From: Cl

Re: [Qemu-devel] [PATCH target-arm v3 04/15] arm: xlnx-zynqmp: Add GIC

2015-03-18 Thread Paolo Bonzini
On 18/03/2015 14:11, Peter Crosthwaite wrote: > So I actually bisected this as a recent regression on: > > commit a464982499b2f637f6699e3d03e0a9d2e0b5288b (refs/bisect/bad) > Author: Paolo Bonzini > Date: Wed Feb 11 17:15:18 2015 +0100 > rcu: run RCU callbacks under the BQL > This nee

Re: [Qemu-devel] [PATCH qemu] target-ppc: Remove never existed POWER5+ v0.0

2015-03-18 Thread Andreas Färber
s/existed/existing/ or "that never existed" Am 18.03.2015 um 04:11 schrieb Alexey Kardashevskiy: > IBM uses low 16bits to specify a chip version of a POWER CPU. "specify the chip version of a" > So there has never been an actual silicon with PVR = 0x003B. > The first silicon would have PVR 0

Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-18 Thread Li, Liang Z
> > > First explanation, why I think this don't fix the full problem. > > > Whith this patch, we fix the problem where we have a dirty block > > > layer but basically nothing dirtying the memory on the guest (we are > > > moving the 20 seconds from max_downtime for the blocklayer flush), > > > to 2

Re: [Qemu-devel] [PATCH 07/11] block: drive_backup transaction callback support

2015-03-18 Thread Max Reitz
On 2015-03-17 at 19:27, John Snow wrote: On 03/17/2015 03:49 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: This patch actually implements the transactional callback system for the drive_backup transaction. (1) We manually pick up a reference to the bitmap if present to allow

Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-18 Thread Kevin Wolf
Am 18.03.2015 um 13:36 hat Juan Quintela geschrieben: > Kevin Wolf wrote: > > The problem is that the block layer really doesn't have an option to > > control what is getting synced once the data is cached outside of qemu. > > Essentially we can do an fdatasync() or we can leave it, that's the onl

Re: [Qemu-devel] [PATCH 09/11] iotests: test 124 - drive object refactoring

2015-03-18 Thread Max Reitz
On 2015-03-17 at 19:40, John Snow wrote: On 03/17/2015 04:44 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: The original test was not particularly good about keeping the relationships between bitmaps, drives, and images very explicit, so this patch adds an explicit 'drive' dict

[Qemu-devel] [Bug 1433510] [NEW] VM Konfig mismatches when -readconfig option is used

2015-03-18 Thread Bjoern Bornemann
Public bug reported: Since qemu is able to write / read config files, i thought it might be cool to use this. BUT: qemu allways adds an default network interface, when i use the -readconfig option. Till now, i start my VM like this (all variables are defined and working well in this script)

Re: [Qemu-devel] [PATCH v2] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-03-18 Thread Alex Bennée
Christoffer Dall writes: > On Tue, Mar 17, 2015 at 07:32:15PM +, Peter Maydell wrote: >> The AArch64 SPSR_EL1 register is architecturally mandated to >> be mapped to the AArch32 SPSR_svc register. This means its >> state should live in QEMU's env->banked_spsr[1] field. >> Correct the various

[Qemu-devel] [PATCH 0/4] virtio: add input device

2015-03-18 Thread Gerd Hoffmann
Hi, This patch series adds virtio input devices. It's basically sending linux evdev events over virtio. There is support for emulated hid devices (i.e. send usual input to virtio device instead of usb or ps2 device) and for evdev device pass-through. This depends on mst's virtio-1.0 patches.

[Qemu-devel] [PATCH 1/4] pci: add PCI_CLASS_INPUT_*

2015-03-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/pci/pci_ids.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h index d7be386..dfccefc 100644 --- a/include/hw/pci/pci_ids.h +++ b/include/hw/pci/pci_ids.h @@ -46,6 +46,13 @@ #define PCI_CLAS

[Qemu-devel] [PATCH 4/4] virtio-input: evdev passthrough

2015-03-18 Thread Gerd Hoffmann
This allows to assign host input devices to the guest: qemu -device virto-input-host-pci,evdev=/dev/input/event The guest gets exclusive access to the input device, so be careful with assigning the keyboard if you have only one connected to your machine. Signed-off-by: Gerd Hoffmann --- hw/inp

[Qemu-devel] [PATCH 3/4] virtio-input: emulated devices

2015-03-18 Thread Gerd Hoffmann
This patch adds the virtio-input-hid base class and virtio-{keyboard,mouse,tablet} subclasses building on the base class. They are hooked up to the qemu input core and deliver input events to the guest like all other hid devices (ps/2 kbd, usb tablet, ...). Using them is as simple as adding "-devi

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 14:23 +0100, Michael S. Tsirkin wrote: > typo in subject: vfio, not vifo. > > On Thu, Mar 12, 2015 at 06:23:59PM +0800, Chen Fan wrote: > > for piix4 chipset, we don't need to expose aer, so introduce > > PC_I440FX_COMPAT for all piix4 machines to disable aercap, > > and add

[Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

2015-03-18 Thread Gerd Hoffmann
This patch adds virtio-input support to qemu. It brings a abstract base class providing core support, other classes can build on it to actually implement input devices. virtio-input basically sends linux input layer events (evdev) over virtio. Signed-off-by: Gerd Hoffmann --- hw/input/Makefile

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 08:02:26AM -0600, Alex Williamson wrote: > On Wed, 2015-03-18 at 14:23 +0100, Michael S. Tsirkin wrote: > > typo in subject: vfio, not vifo. > > > > On Thu, Mar 12, 2015 at 06:23:59PM +0800, Chen Fan wrote: > > > for piix4 chipset, we don't need to expose aer, so introduce

Re: [Qemu-devel] [PATCH v5 6/7] vfio: add 'x-aer' property to expose aercap

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 14:23 +0100, Michael S. Tsirkin wrote: > On Thu, Mar 12, 2015 at 06:23:58PM +0800, Chen Fan wrote: > > add 'x-aer' property to let user able to decide whether expose > > the aer capability. > > > > Signed-off-by: Chen Fan > > If it's exposed to users, it should not have the

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 15:05 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 08:02:26AM -0600, Alex Williamson wrote: > > On Wed, 2015-03-18 at 14:23 +0100, Michael S. Tsirkin wrote: > > > typo in subject: vfio, not vifo. > > > > > > On Thu, Mar 12, 2015 at 06:23:59PM +0800, Chen Fan wro

Re: [Qemu-devel] [PATCH qemu] target-ppc: Remove never existed POWER5+ v0.0

2015-03-18 Thread Alexander Graf
On 03/18/2015 02:36 PM, Andreas Färber wrote: s/existed/existing/ or "that never existed" Am 18.03.2015 um 04:11 schrieb Alexey Kardashevskiy: IBM uses low 16bits to specify a chip version of a POWER CPU. "specify the chip version of a" So there has never been an actual silicon with PVR = 0x

Re: [Qemu-devel] GSOC 2015 Project Proposal

2015-03-18 Thread Alexander Graf
On 03/18/2015 12:46 PM, Stefan Hajnoczi wrote: On Mon, Feb 9, 2015 at 12:44 AM, Xin Tong wrote: I would like to do GSOC this summer. The project i have in mind is to implement a set of facilities to make implementing Hardware transactional memory (HTM) easier in QEMU. HTM has become available

Re: [Qemu-devel] [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0 error

2015-03-18 Thread John Snow
On 03/18/2015 03:11 AM, Markus Armbruster wrote: John Snow writes: A thinko that clang 3.5.0 caught. Thankfully does not introduce any new failures. Signed-off-by: John Snow How you caught the bug is interesting enough to be mentioned in the commit message, but the nature of the bug sure

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 08:15:01AM -0600, Alex Williamson wrote: > On Wed, 2015-03-18 at 15:05 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2015 at 08:02:26AM -0600, Alex Williamson wrote: > > > On Wed, 2015-03-18 at 14:23 +0100, Michael S. Tsirkin wrote: > > > > typo in subject: vfio, not

[Qemu-devel] [PULL 3/3] target-mips: save cpu state before calling MSA load and store helpers

2015-03-18 Thread Leon Alrae
PC needs to be saved if an exception can be generated by an helper. This fixes a problem related to resuming the execution at unexpected address after an exception (caused by MSA load/store instruction) has been serviced. Signed-off-by: Leon Alrae --- target-mips/translate.c | 2 ++ 1 file chang

[Qemu-devel] [PULL 1/3] target-mips: fix CP0.BadVAddr by stopping translation on Address Error

2015-03-18 Thread Leon Alrae
CP0.BadVAddr is supposed to capture the most recent virtual address that caused the exception. Currently this does not work correctly for unaligned instruction fetch as translation is not stopped and CP0.BadVAddr is updated with subsequent addresses. Signed-off-by: Leon Alrae --- target-mips/tra

[Qemu-devel] [PULL 2/3] target-mips: fix hflags modified in delay / forbidden slot

2015-03-18 Thread Leon Alrae
All instructions which may change hflags terminate tb. However, this doesn't work if such an instruction is placed in delay or forbidden slot. gen_branch() clears MIPS_HFLAG_BMASK in ctx->hflags and then generates code to overwrite hflags with ctx->hflags, consequently we loose any execution-time h

[Qemu-devel] [PULL 0/3] target-mips queue

2015-03-18 Thread Leon Alrae
5-03-17 11:43:00 +) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20150318 for you to fetch changes up to 0af7a37054310384e00209e0a43efe95b7c19ef0: target-mips: save cpu state before calling MSA load and store helpers (2015-03-18 09:5

Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 03:00:12PM +0100, Gerd Hoffmann wrote: > This patch adds virtio-input support to qemu. It brings a abstract > base class providing core support, other classes can build on it to > actually implement input devices. > > virtio-input basically sends linux input layer events (

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 15:36 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 08:15:01AM -0600, Alex Williamson wrote: > > On Wed, 2015-03-18 at 15:05 +0100, Michael S. Tsirkin wrote: > > > On Wed, Mar 18, 2015 at 08:02:26AM -0600, Alex Williamson wrote: > > > > On Wed, 2015-03-18 at 14:23

Re: [Qemu-devel] [PATCH 6/8] exec: mark unassigned_io_ops as unlocked

2015-03-18 Thread Jan Kiszka
On 2015-03-18 14:21, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini A commit log should briefly state why we can do this safely (no state dependency, no need for locking). Yes, it's trivial in this case but already a little bit less trivial in case of the PM timer. > --- > exec.c | 1 + >

Re: [Qemu-devel] [PATCH for-2.4 0/8] memory: enable unlocked PIO/MMIO in KVM

2015-03-18 Thread Paolo Bonzini
On 18/03/2015 15:33, Jan Kiszka wrote: > Just in time: I'm planning to rebase our queue soon, specifically to > benefit from RCU support. Will let you know if it works on top of this > series. Great. FWIW, this is the most similar version to the one we played with in 2013. I have an alternativ

Re: [Qemu-devel] [PATCH 6/8] exec: mark unassigned_io_ops as unlocked

2015-03-18 Thread Paolo Bonzini
On 18/03/2015 15:33, Jan Kiszka wrote: > On 2015-03-18 14:21, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini > > A commit log should briefly state why we can do this safely (no state > dependency, no need for locking). Yes, it's trivial in this case but > already a little bit less trivial

[Qemu-devel] [GSoC] project proposal

2015-03-18 Thread Catalin Vasile
Hi, My name is Catalin Vasile and I want to participate with a project for qemu at GSoC. >From what I understand from the rules, I can participate with things I could also use for my college projects. This is my last bachelor year and I'm doing my diploma project, which is related to virtualizatio

Re: [Qemu-devel] [PATCH for-2.4 0/8] memory: enable unlocked PIO/MMIO in KVM

2015-03-18 Thread Jan Kiszka
On 2015-03-18 14:21, Paolo Bonzini wrote: > And here we are... These are the changes required to make the BQL > optional for memory access, and use that support in KVM. For now, > only one device model is changed to do unlocked accesses. > > Please review! > > Jan Kiszka (4): > memory: Add gl

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 08:50:54AM -0600, Alex Williamson wrote: > On Wed, 2015-03-18 at 15:36 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2015 at 08:15:01AM -0600, Alex Williamson wrote: > > > On Wed, 2015-03-18 at 15:05 +0100, Michael S. Tsirkin wrote: > > > > On Wed, Mar 18, 2015 at 08:

Re: [Qemu-devel] [PATCH for-2.4 0/8] memory: enable unlocked PIO/MMIO in KVM

2015-03-18 Thread Jan Kiszka
On 2015-03-18 15:52, Paolo Bonzini wrote: > > > On 18/03/2015 15:33, Jan Kiszka wrote: >> Just in time: I'm planning to rebase our queue soon, specifically to >> benefit from RCU support. Will let you know if it works on top of this >> series. > > Great. FWIW, this is the most similar version t

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-18 Thread Bandan Das
[Ccing netdev and Stefan] Bandan Das writes: > jacob jacob writes: > >> On Mon, Mar 16, 2015 at 2:12 PM, Bandan Das wrote: >>> jacob jacob writes: >>> I also see the following in dmesg in the VM. [0.095758] ACPI: PCI Root Bridge [PCI0] (domain [bus 00-ff]) [0.0

Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

2015-03-18 Thread Gerd Hoffmann
On Mi, 2015-03-18 at 15:31 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 03:00:12PM +0100, Gerd Hoffmann wrote: > > This patch adds virtio-input support to qemu. It brings a abstract > > base class providing core support, other classes can build on it to > > actually implement input d

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-18 Thread jacob jacob
On Wed, Mar 18, 2015 at 11:24 AM, Bandan Das wrote: > [Ccing netdev and Stefan] > Bandan Das writes: > >> jacob jacob writes: >> >>> On Mon, Mar 16, 2015 at 2:12 PM, Bandan Das wrote: jacob jacob writes: > I also see the following in dmesg in the VM. > > [0.095758] AC

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 16:02 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 08:50:54AM -0600, Alex Williamson wrote: > > On Wed, 2015-03-18 at 15:36 +0100, Michael S. Tsirkin wrote: > > > On Wed, Mar 18, 2015 at 08:15:01AM -0600, Alex Williamson wrote: > > > > On Wed, 2015-03-18 at 15:05

[Qemu-devel] [PATCH 0/6 v6] tilegx: Firstly add tilegx feature for linux-user

2015-03-18 Thread Chen Gang
After load elf64 binary, qemu tilegx can finish executing the first system call (uname) successfully in _dl_discover_osversion(), and return to __libc_start_main(). Chen Gang (6): target-tilegx: Firstly add TILE-Gx with minimized features linux-user: tilegx: Firstly add architecture related fe

[Qemu-devel] [PATCH 1/6 v6] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-18 Thread Chen Gang
It is the configure and build system support for TILE-Gx (tilegx will be used in configure and real sub-directory name). At present, it is linux-user only, and can finish the first system call (uname) execution in __libc_start_main(). Signed-off-by: Chen Gang --- configure

[Qemu-devel] [PATCH 2/6 v6] linux-user: tilegx: Firstly add architecture related features

2015-03-18 Thread Chen Gang
They are based on Linux kernel tilegx architecture for 64 bit binary, also based on tilegx ABI reference document. Signed-off-by: Chen Gang --- linux-user/tilegx/syscall.h| 80 linux-user/tilegx/syscall_nr.h | 278 linux-user/tilegx/term

[Qemu-devel] [PATCH 3/6 v6] linux-user: tilegx: Add target features support within qemu

2015-03-18 Thread Chen Gang
They are for target features within qemu which independent from outside. Signed-off-by: Chen Gang --- linux-user/tilegx/target_cpu.h | 35 +++ linux-user/tilegx/target_signal.h | 28 ++ linux-user/tilegx/target_structs.h | 48 +

[Qemu-devel] [PATCH v2 for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-18 Thread Igor Mammedov
since commit dd0247e0 pc: acpi: mark all possible CPUs as enabled in SRAT Linux kernel actually tries to use CPU to Node mapping from QEMU provided SRAT table instead of discarding it, and that in some cases breaks build_sched_domains() which expects sane mapping where cores/threads belonging to

[Qemu-devel] [PATCH 4/6 v6] linux-user: Support tilegx architecture in syscall

2015-03-18 Thread Chen Gang
Add tilegx architecture in "syscall_defs.h", all related features (ioctrl, and stat) are based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- linux-user/syscall_defs.h | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 5/6 v6] linux-user: Support tilegx architecture in linux-user

2015-03-18 Thread Chen Gang
Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- include/elf.h| 2 ++ linux-user/elfload.c | 23 ++ linux-user/main.c| 86 +

[Qemu-devel] [PATCH 6/6 v6] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx

2015-03-18 Thread Chen Gang
For tilegx, several syscall macros are not supported, so switch them to avoid building break. Signed-off-by: Chen Gang --- linux-user/syscall.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 09:45:29AM -0600, Alex Williamson wrote: > On Wed, 2015-03-18 at 16:02 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2015 at 08:50:54AM -0600, Alex Williamson wrote: > > > On Wed, 2015-03-18 at 15:36 +0100, Michael S. Tsirkin wrote: > > > > On Wed, Mar 18, 2015 at 08:

Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-18 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > > > First explanation, why I think this don't fix the full problem. > > > > Whith this patch, we fix the problem where we have a dirty block > > > > layer but basically nothing dirtying the memory on the guest (we are > > > > moving the 20 seconds fro

<    1   2   3   >