Re: [Qemu-devel] wrong size for virtio-scsi headers

2015-03-12 Thread Gonglei
On 2015/3/12 14:37, Michael S. Tsirkin wrote: > On Thu, Mar 12, 2015 at 03:24:40AM +, Gonglei (Arei) wrote: >> Hi, >> >> Today I start a vm failed, and get the following log: >> >> qemu-system-x86_64: wrong size for virtio-scsi headers >> >> 1) The Qemu command line: >> >> ./qemu-system-x86_64

[Qemu-devel] [PATCH] hmp: add info iothreads command

2015-03-12 Thread Ting Wang
Make "info iothreads" available on the HMP monitor. The results are as follows: id1: thread_id1 id2: thread_id2 Signed-off-by: Ting Wang --- hmp-commands.hx | 2 ++ hmp.c | 21 + hmp.h | 1 + monitor.c | 7 +++ 4 files changed, 31 insertions(

Re: [Qemu-devel] [PATCH] vnc: fix segmentation fault when invalid vnc parameters are specified

2015-03-12 Thread Michael Tokarev
12.03.2015 06:59, arei.gong...@huawei.com wrote: > +++ b/ui/vnc.c > @@ -3698,8 +3698,13 @@ QemuOpts *vnc_parse_func(const char *str) > { > QemuOptsList *olist = qemu_find_opts("vnc"); > QemuOpts *opts = qemu_opts_parse(olist, str, 1); > -const char *id = qemu_opts_id(opts); > +co

Re: [Qemu-devel] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-12 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 11:03:14PM +0100, Greg Kurz wrote: > On Wed, 11 Mar 2015 21:06:05 +0100 > "Michael S. Tsirkin" wrote: > > > On Wed, Mar 11, 2015 at 07:04:38PM +0100, Greg Kurz wrote: > > > vhost is seriously broken with ppc64le guests, even in the supposedly > > > supported case where the

Re: [Qemu-devel] [Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures

2015-03-12 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 11:52:13PM +0100, Greg Kurz wrote: > On Thu, 12 Mar 2015 09:18:38 +1100 > Benjamin Herrenschmidt wrote: > > > On Wed, 2015-03-11 at 23:03 +0100, Greg Kurz wrote: > > > > > /* The host notifier will be swapped in adjust_endianness() according to > > > the > > > * target

Re: [Qemu-devel] configure: enable kvm on x32

2015-03-12 Thread Peter Maydell
On 12 March 2015 at 06:13, Michael Tokarev wrote: > Here's a trivial change to enable kvm on x32 architecture. > I'm not 100% sure the result works correctly in all cases, > but this is a good start and in theory everything should > work. Given the pessimism expressed in this comment, perhaps we

Re: [Qemu-devel] [PATCH] hmp: add info iothreads command

2015-03-12 Thread Fam Zheng
On Thu, 03/12 15:00, Ting Wang wrote: > +if (elem->value) > +monitor_printf(mon, "%s: thread_id=%ld\n", elem->value->id, > +elem->value->thread_id); Braces are required for if. Fam

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote: > Currently we could leave PCI IRQ asserted even after reset, it is safer > to clear it. > > In the case that a buggy driver has disabled MSI-X unintentially, we may > have already injected IRQ in previous virtio_pci_notify, which will not

Re: [Qemu-devel] [PATCH] vnc: fix segmentation fault when invalid vnc parameters are specified

2015-03-12 Thread Gonglei
On 2015/3/12 15:07, Michael Tokarev wrote: > 12.03.2015 06:59, arei.gong...@huawei.com wrote: >> +++ b/ui/vnc.c >> @@ -3698,8 +3698,13 @@ QemuOpts *vnc_parse_func(const char *str) >> { >> QemuOptsList *olist = qemu_find_opts("vnc"); >> QemuOpts *opts = qemu_opts_parse(olist, str, 1); >>

[Qemu-devel] [PATCH 4/6] throttle: Add throttle group support

2015-03-12 Thread Alberto Garcia
The throttle group support use a cooperative round robin scheduling algorithm. The principles of the algorithm are simple: - Each BDS of the group is used as a token in a circular way. - The active BDS computes if a wait must be done and arms the right timer. - If a wait must be done the token t

[Qemu-devel] [PATCH v5 for-2.3 26/28] acpi: restrict the aml emission to PXB host bridges

2015-03-12 Thread Marcel Apfelbaum
Initial implementation assumed that the aml used for any extra root buses would be generic, however this is not always true. Restrict aml emission only to i440fx and PXB because is the only supported combination for now. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c| 5

[Qemu-devel] [PATCH v5 for-2.3 22/28] hw/pci: piix - suport multiple host bridges

2015-03-12 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Instead of assuming it has only one bus, it enumerates all the host bridges until it finds the one with bus number corresponding with the config register. Signed-off-by: Marcel Apfelbaum --- hw/pci-host/piix.c | 57 +-

Re: [Qemu-devel] [PATCH v5 for-2.3 12/28] hw/acpi: add _CRS method for extra root busses

2015-03-12 Thread Michael S. Tsirkin
Comment from 20150308162743.gc31...@redhat.com not addressed yet I think. On Tue, Mar 10, 2015 at 05:31:58PM +0200, Marcel Apfelbaum wrote: > Save the IO/mem/bus numbers ranges assigned to the extra root busses > to be removed from the root bus 0 range. > > Signed-off-by: Marcel Apfelbaum > ---

[Qemu-devel] [PATCH v5 for-2.3 19/28] hw/pci: implement iteration over multiple host bridges

2015-03-12 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 8 include/hw/pci/pci_host.h | 4 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 53598bd..f0cf752 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @

Re: [Qemu-devel] [PATCH v5 for-2.3 12/28] hw/acpi: add _CRS method for extra root busses

2015-03-12 Thread Marcel Apfelbaum
On 03/10/2015 05:38 PM, Michael S. Tsirkin wrote: Comment from 20150308162743.gc31...@redhat.com not addressed yet I think. I'll try to use g_array, let's see how it will look. Thanks, Marcel On Tue, Mar 10, 2015 at 05:31:58PM +0200, Marcel Apfelbaum wrote: Save the IO/mem/bus numbers range

Re: [Qemu-devel] [PATCH v5 for-2.3 27/28] apci: fix PXB behaviour if used with unsupported BIOS

2015-03-12 Thread Marcel Apfelbaum
On 03/10/2015 05:44 PM, Michael S. Tsirkin wrote: On Tue, Mar 10, 2015 at 05:32:13PM +0200, Marcel Apfelbaum wrote: PXB does not work with an unsupported BIOS, but should not interfere with normal OS operation. Fix this by not adding PXB mem/IO chunks to _CRS if they weren't configured by BIOS.

[Qemu-devel] [PATCH v5 for-2.3 04/28] acpi: add aml_lless() term

2015-03-12 Thread Marcel Apfelbaum
Add encoding for ACPI DefLLess Opcode. Reviewed-by: Shannon Zhao Reviewed-by: Igor Mammedov Signed-off-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.

Re: [Qemu-devel] [PATCH v5 for-2.3 00/28] hw/pc: implement multiple primary busses for pc machines

2015-03-12 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 04:01:30PM +0200, Marcel Apfelbaum wrote: > On 03/11/2015 03:51 PM, Gerd Hoffmann wrote: > >On Mi, 2015-03-11 at 15:44 +0200, Marcel Apfelbaum wrote: > >>On 03/11/2015 03:32 PM, Gerd Hoffmann wrote: > >>>Hi, > >>> > v4->v5: > - Rebased on pci branch, tree: >

[Qemu-devel] [PATCH v2] vnc: fix segmentation fault when invalid vnc parameters are specified

2015-03-12 Thread arei.gonglei
From: Gonglei Reproducer: #./qemu-system-x86_64 -vnc :0,ip qemu-system-x86_64: -vnc :1,ip: Invalid parameter 'ip' Segmentation fault (core dumped) Signed-off-by: Gonglei --- v2: remove useless initialization for variable id. (mjt) --- ui/vnc.c | 7 ++- 1 file changed, 6 insertions(+), 1 d

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-12 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 12:06:48PM +0100, Andreas Färber wrote: > Am 11.03.2015 um 09:56 schrieb Michael S. Tsirkin: > > On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas Färber wrote: > >> Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: > >>> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Fä

Re: [Qemu-devel] [PATCH v5 for-2.3 00/28] hw/pc: implement multiple primary busses for pc machines

2015-03-12 Thread Marcel Apfelbaum
On 03/11/2015 04:12 PM, Gerd Hoffmann wrote: On Di, 2015-03-10 at 17:31 +0200, Marcel Apfelbaum wrote: v4->v5: - Rebased on pci branch, tree: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git - Added PXB documentation (patch 28/28) - Addressed Gerd Hoffmann's review: - fix PXB behavio

Re: [Qemu-devel] [Qemu-block] [PATCH v2 06/17] hbitmap: add hbitmap_merge

2015-03-12 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:19:52PM -0500, John Snow wrote: > We add a bitmap merge operation to assist in error cases > where we wish to combine two bitmaps together. > > This is algorithmically O(bits) provided HBITMAP_LEVELS remains > constant. For a full bitmap on a 64bit machine: > sum(bits/64

[Qemu-devel] [PATCH v5 for-2.3 00/28] hw/pc: implement multiple primary busses for pc machines

2015-03-12 Thread Marcel Apfelbaum
Notes: - Sorry for the late submission, I was waiting for dynamic ACPI series to get merged in order to submit - my bad. - The prev version (v2) was wrongfully tagged by me as RFC, it was actually ready but not rebased. V3 only rebases with no actual functionality changed. - This series

Re: [Qemu-devel] [PATCH RFC 0/2] Limit support for encrypted images to qemu-img

2015-03-12 Thread Kevin Wolf
Am 11.03.2015 um 10:59 hat Daniel P. Berrange geschrieben: > On Wed, Mar 11, 2015 at 09:55:16AM +0100, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > FWIW, I could see an improved interaction scheme working as follows > > > > > > First, introduce a new monitor command for setting

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-12 Thread Dr. David Alan Gilbert
* Andrey Korolyov (and...@xdel.ru) wrote: > On Sat, Mar 7, 2015 at 3:00 AM, Andrey Korolyov wrote: > > On Fri, Mar 6, 2015 at 7:57 PM, Bandan Das wrote: > >> Andrey Korolyov writes: > >> > >>> On Fri, Mar 6, 2015 at 1:14 AM, Andrey Korolyov wrote: > Hello, > > recently I`ve got a

[Qemu-devel] [PULL 10/10] bitops.h: sextract64() return type should be int64_t, not uint64_t

2015-03-12 Thread Peter Maydell
The documentation for sextract64() claims that the return type is an int64_t, but the code itself disagrees. Fix the return type to conform to the documentation and to bring it into line with sextract32(), which returns int32_t. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message

Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user

2015-03-12 Thread Michael S. Tsirkin
On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas Färber wrote: > Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin: > > Make it safe to include hw/boards.h in exec.c > > for linux-user configurations. > > We don't need any of its contents though. > > > > Signed-off-by: Michael S. Tsirkin > > ---

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

2015-03-12 Thread John Snow
Adding in Michael Tokarev, I fat-fingered his email address. On 03/10/2015 01:37 PM, John Snow wrote: Our qtest suite relies on many functions available only in glib 2.16+. Even though our base QEMU binary may only require 2.12+, it is confusing to have two separate version requirements. Thus,

Re: [Qemu-devel] [PATCH] configure: bump glib version to 2.16

2015-03-12 Thread Peter Maydell
On 10 March 2015 at 17:43, John Snow wrote: > Wasn't aware we were actually going through with that; it had looked > like we were going to refrain from fiddling with it because we found > a workaround that sufficed for glib 2.12. Well, we're not doing anything before QEMU 2.3 is released. But if

Re: [Qemu-devel] fw_cfg specification ?

2015-03-12 Thread Gerd Hoffmann
Hi, > >> I won't say "better", but it is "committed": check > >> "Documentation/devicetree/bindings/arm/fw-cfg.txt" in the kernel tree. > >> It is intentionally vague on the set of keys and fw_cfg files that qemu > >> provides, because that's a moving target. You can only rely on the qemu > >> s

Re: [Qemu-devel] [PATCH] hw/boards: make it safe to include for linux-user

2015-03-12 Thread Andreas Färber
Am 10.03.2015 um 18:41 schrieb Michael S. Tsirkin: > On Tue, Mar 10, 2015 at 06:34:44PM +0100, Andreas Färber wrote: >> Am 10.03.2015 um 18:33 schrieb Michael S. Tsirkin: >>> Make it safe to include hw/boards.h in exec.c >>> for linux-user configurations. >>> We don't need any of its contents thoug

Re: [Qemu-devel] [PULL 0/7] X86 patches

2015-03-12 Thread Eduardo Habkost
On Tue, Mar 10, 2015 at 11:16:36AM -0300, Eduardo Habkost wrote: > On Tue, Mar 10, 2015 at 11:44:22AM +, Peter Maydell wrote: > > On 9 March 2015 at 20:40, Eduardo Habkost wrote: > > > The following changes since commit > > > 277263e1b320d759a760ba6c5ea75ec268f929e5: > > > > > > Merge remot

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-12 Thread Fam Zheng
On Thu, 03/12 08:22, Michael S. Tsirkin wrote: > On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote: > > Currently we could leave PCI IRQ asserted even after reset, it is safer > > to clear it. > > > > In the case that a buggy driver has disabled MSI-X unintentially, we may > > have already

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-12 Thread Paolo Bonzini
On 10/03/2015 19:16, Dr. David Alan Gilbert wrote: > KVM internal error. Suberror: 1 > emulation failure > EAX= EBX= ECX= EDX=000fd2bc > ESI= EDI= EBP= ESP= > EIP=000fd2c5 EFL=00010007 [-PC] CPL=0 II=0 A20=1 SMM=0 HLT=0 > ES =0010 00

Re: [Qemu-devel] configure: enable kvm on x32

2015-03-12 Thread Michael Tokarev
12.03.2015 10:16, Peter Maydell wrote: > On 12 March 2015 at 06:13, Michael Tokarev wrote: >> Here's a trivial change to enable kvm on x32 architecture. >> I'm not 100% sure the result works correctly in all cases, >> but this is a good start and in theory everything should >> work. > > Given the

Re: [Qemu-devel] [PATCH v2] vnc: fix segmentation fault when invalid vnc parameters are specified

2015-03-12 Thread Gerd Hoffmann
On Do, 2015-03-12 at 15:33 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Reproducer: > #./qemu-system-x86_64 -vnc :0,ip > qemu-system-x86_64: -vnc :1,ip: Invalid parameter 'ip' > Segmentation fault (core dumped) Added to vnc patch queue. thanks, Gerd

[Qemu-devel] KVM emulation failure with recent kernel and QEMU Seabios

2015-03-12 Thread Jan Kiszka
Hi, apparently since the latest QEMU updates I'm getting this once in a while: KVM internal error. Suberror: 1 emulation failure EAX= EBX= ECX= EDX=000fd2bc ESI= EDI= EBP= ESP= EIP=000fd2c5 EFL=00010007 [-PC] CPL=0 II=0 A20=1 SMM=0 HLT=0

Re: [Qemu-devel] KVM emulation failure with recent kernel and QEMU Seabios

2015-03-12 Thread Gerd Hoffmann
On Do, 2015-03-12 at 09:09 +0100, Jan Kiszka wrote: > Hi, > > apparently since the latest QEMU updates I'm getting this once in a > while: http://www.seabios.org/pipermail/seabios/2015-March/008897.html cheers, Gerd

Re: [Qemu-devel] KVM emulation failure with recent kernel and QEMU Seabios

2015-03-12 Thread Jan Kiszka
Am 2015-03-12 um 09:11 schrieb Gerd Hoffmann: > On Do, 2015-03-12 at 09:09 +0100, Jan Kiszka wrote: >> Hi, >> >> apparently since the latest QEMU updates I'm getting this once in a >> while: > > http://www.seabios.org/pipermail/seabios/2015-March/008897.html OK... So we are waiting on a stable re

Re: [Qemu-devel] [PULLv2] qemu-sparc update

2015-03-12 Thread Peter Maydell
On 10 March 2015 at 14:01, Mark Cave-Ayland wrote: > Hi Peter, > > Here are the updates from my qemu-sparc tree. Please pull. > > > ATB, > > Mark. > > v2: update OpenBIOS git submodule and all binaries > > > The following changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5: > > Merge r

Re: [Qemu-devel] [PATCH RFC 0/2] Limit support for encrypted images to qemu-img

2015-03-12 Thread Daniel P. Berrange
On Wed, Mar 11, 2015 at 09:55:16AM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Tue, Mar 10, 2015 at 06:26:38PM +0100, Markus Armbruster wrote: > >> RFC because the series only covers open [PATCH 1], but not create. > >> Also missing: make qemu-img print a warning when

[Qemu-devel] [PATCH 0/2] virtio-ccw: be accesses

2015-03-12 Thread Cornelia Huck
OK, here's what I have for the virtio-ccw be stuff. Patch 1 will go via s390-next with my next pull request, patch 2 is on top of your current virtio-1.0 branch and should possibly be merged into the patch introducing set-revision. Cornelia Huck (2): virtio-ccw: assure BE accesses virtio-ccw:

[Qemu-devel] [PULLv2] s390x/kvm: Features and fixes for 2.3

2015-03-12 Thread Christian Borntraeger
Peter, here is the 2nd version (only one patch changed) that hopefully compiles fine on 32 bit hosts. I only added that patch as followup mail. The following changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream

[Qemu-devel] [vhost-net kernel module]: file.fd = -1 does nothing ?

2015-03-12 Thread Catalin Vasile
Why do vhost init/start functions put out with the work of using a vhost_call(VHOST_NET_SET_BACKEND) with file.fd = -1 in qemu vhost-net sources? >From what I see in vhost-net kernel module it just returns NULL from get_socket(), and that's it. It doesn't set anything.

Re: [Qemu-devel] KVM emulation failure with recent kernel and QEMU Seabios

2015-03-12 Thread Gerd Hoffmann
On Do, 2015-03-12 at 09:14 +0100, Jan Kiszka wrote: > Am 2015-03-12 um 09:11 schrieb Gerd Hoffmann: > > On Do, 2015-03-12 at 09:09 +0100, Jan Kiszka wrote: > >> Hi, > >> > >> apparently since the latest QEMU updates I'm getting this once in a > >> while: > > > > http://www.seabios.org/pipermail/se

Re: [Qemu-devel] [PATCH 7/8] machine: query dump-guest-core machine property rather than qemu opts

2015-03-12 Thread Marcel Apfelbaum
On 03/11/2015 01:06 PM, Andreas Färber wrote: Am 11.03.2015 um 09:56 schrieb Michael S. Tsirkin: On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas Färber wrote: Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin: On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote: Hi, Am 04.02.201

Re: [Qemu-devel] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library

2015-03-12 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 05:01:38PM +0300, Michael Tokarev wrote: > 10.03.2015 16:58, Stefan Hajnoczi пишет: > > On Tue, Mar 10, 2015 at 10:09 AM, Kevin Wolf wrote: > >> Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: > >>> On Tue, 03/10 09:50, Kevin Wolf wrote: > Am 10.03.2015 um 08:06 hat

Re: [Qemu-devel] [PATCH 0/2] ui: two small fixes

2015-03-12 Thread Gerd Hoffmann
On Mi, 2015-03-11 at 16:20 +0800, arei.gong...@huawei.com wrote: > Gonglei (2): > ui/console: fix OVERFLOW_BEFORE_WIDEN > vnc: avoid possible file handler leak added to vnc patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-12 Thread Igor Mammedov
On Tue, 10 Mar 2015 18:57:35 -0300 Eduardo Habkost wrote: > Instead of passing icc_bridge from the PC initialization code to > cpu_x86_create(), make the PC initialization code attach the CPU to > icc_bridge. > > The only difference here is that icc_bridge attachment will now be done > after x86

Re: [Qemu-devel] [PATCH v5 for-2.3 00/28] hw/pc: implement multiple primary busses for pc machines

2015-03-12 Thread Gerd Hoffmann
On Di, 2015-03-10 at 17:31 +0200, Marcel Apfelbaum wrote: > v4->v5: > - Rebased on pci branch, tree: > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git > - Added PXB documentation (patch 28/28) > - Addressed Gerd Hoffmann's review: >- fix PXB behaviour if used with unsupported BIOS (patch

Re: [Qemu-devel] [PATCH] hmp: add info iothreads command

2015-03-12 Thread Wangting (Kathy)
On 2015-3-12 15:20, Fam Zheng wrote: > On Thu, 03/12 15:00, Ting Wang wrote: >> +if (elem->value) >> +monitor_printf(mon, "%s: thread_id=%ld\n", elem->value->id, >> +elem->value->thread_id); > > Braces are required for if. > > Fam > > Okay, will fix in

[Qemu-devel] [PULL v2 1/5] sdl: Refresh debug statements

2015-03-12 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt Put them under a #define similar to the VGA model and make them actually compile. Add a couple too. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) dif

[Qemu-devel] [PULL v2 0/5] sdl patch queue.

2015-03-12 Thread Gerd Hoffmann
branch 'remotes/pmaydell/tags/pull-target-arm-20150311' into staging (2015-03-11 16:30:33 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-sdl-20150312-1 for you to fetch changes up to ecdc9a53acd7a5d0cf48f1b77b83c70e513e81da: pixman: add a bunch of

[Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Ting Wang
Make "info iothreads" available on the HMP monitor. The results are as follows: id1: thread_id1 id2: thread_id2 Signed-off-by: Ting Wang --- v2: add braces for if --- hmp-commands.hx | 2 ++ hmp.c | 22 ++ hmp.h | 1 + monitor.c | 7 +++ 4 fi

[Qemu-devel] [PULL v2 3/5] configure: opengl overhaul

2015-03-12 Thread Gerd Hoffmann
Rename config option from "glx" to "opengl", glx will not be the only option for opengl in near future. Also switch over to pkg-config for opengl support detection. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- configure| 39 +--

[Qemu-devel] [PULL v2 2/5] sdl: Fix crash when calling sdl_switch() with NULL surface

2015-03-12 Thread Gerd Hoffmann
From: Benjamin Herrenschmidt This happens for example when doing ctrl-alt-u and segfaults Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/sdl.c b/ui/sdl.c index b89182a..8bdbf52 100644 ---

[Qemu-devel] qemu-system-ppc TCG assert with git master

2015-03-12 Thread Mark Cave-Ayland
Hi all, Whilst testing git master in preparation for some OpenBIOS updates, I'm seeing the following TCG assert in one of my older test images: $ gdb --args ./qemu-system-ppc -cdrom /home/build/src/qemu/image/ppc/ubuntu-5.10-live-powerpc.iso -boot d -g 800x600x8 GNU gdb (GDB) 7.4.1-debian Copyri

[Qemu-devel] [PULL v2 4/5] Allow the use of X11 from a non standard location.

2015-03-12 Thread Gerd Hoffmann
From: Jeremy White Signed-off-by: Jeremy White [ kraxel: solve opengl patch conflicts ] Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- configure| 24 +++- hw/display/Makefile.objs | 1 + 2 files changed, 20 insertions(+), 5 deletions(-) diff --

Re: [Qemu-devel] [PATCH 2/2 RFC] s390x/pci: rework pci infrastructure modeling

2015-03-12 Thread Frank Blaschka
On Wed, Mar 11, 2015 at 03:57:05PM +0100, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 03:38:44PM +0100, Frank Blaschka wrote: > > I like Alex's idea because: > > 1) It reflects pretty well the actual nature of the pci system in real s390 > > hw > > why do you say this? does real hw has th

Re: [Qemu-devel] [PATCH 0/1] Get the list of arguments from a QMP command

2015-03-12 Thread Alberto Garcia
On Wed, Mar 11, 2015 at 11:21:43AM +0100, Markus Armbruster wrote: > > I can actually try to implement full introspection support, but I > > would like to know what API you would like. Something like this? > > > >'query-commands' > >'query-enums' > >'query-events' > >'query-types'

Re: [Qemu-devel] [Qemu-Dev-QUERY] Related to Live Migration source Code or API for NUMA Node specific

2015-03-12 Thread Arkajit Ghosh
Hi Team, Can anyone please provide their point of views related to my below query. Thanks & Regards Arkajit Ghosh -Arkajit Ghosh/DEL/TCS wrote: - To: qemu-devel@nongnu.org From: Arkajit Ghosh/DEL/TCS Date: 03/12/2015 09:59AM Subject: Re: [Qem

[Qemu-devel] [PULL 7/7] vnc: fix segmentation fault when invalid vnc parameters are specified

2015-03-12 Thread Gerd Hoffmann
From: Gonglei Reproducer: #./qemu-system-x86_64 -vnc :0,ip qemu-system-x86_64: -vnc :1,ip: Invalid parameter 'ip' Segmentation fault (core dumped) Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ui/vnc

[Qemu-devel] [PULL 2/7] vnc: remove dead code

2015-03-12 Thread Gerd Hoffmann
If vs->ws_enabled is set ws_display is non-NULL. Signed-off-by: Gerd Hoffmann Reviewed-by: Gonglei --- ui/vnc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 65ba1c0..bac44ce 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3627,13 +3627,8 @@ voi

[Qemu-devel] [PULL 6/7] vnc: avoid possible file handler leak

2015-03-12 Thread Gerd Hoffmann
From: Gonglei vs->lsock may equal to 0, modify the check condition, avoid possible vs->lsock leak. Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index b514777..1e95445 100644 --- a/ui/vn

Re: [Qemu-devel] [PULLv2] s390x/kvm: Features and fixes for 2.3

2015-03-12 Thread Peter Maydell
On 11 March 2015 at 10:21, Christian Borntraeger wrote: > Peter, > > here is the 2nd version (only one patch changed) that hopefully > compiles fine on 32 bit hosts. > I only added that patch as followup mail. > Applied, thanks. -- PMM

[Qemu-devel] [PULL 5/7] ui/console: fix OVERFLOW_BEFORE_WIDEN

2015-03-12 Thread Gerd Hoffmann
From: Gonglei Signed-off-by: Gonglei Signed-off-by: Gerd Hoffmann --- ui/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/console.c b/ui/console.c index 87af6b5..b15ca87 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1285,9 +1285,9 @@ DisplaySurface *qemu_

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Fam Zheng
On Thu, 03/12 16:35, Ting Wang wrote: > Make "info iothreads" available on the HMP monitor. > > The results are as follows: > id1: thread_id1 > id2: thread_id2 Does this match the actual output format? I think you're missing a "=". > > Signed-off-by: Ting Wang > --- > v2: add braces for if > -

Re: [Qemu-devel] [PATCH 0/4] virtio-scsi: fix up cdb mess

2015-03-12 Thread Alexey Kardashevskiy
On 03/12/2015 12:42 AM, Michael S. Tsirkin wrote: Fam Zheng , Alexey Kardashevskiy , Nikunj A Dadhania all reported that importing linux headers breaks cdb/sense in virtio scsi in qemu. This imports a linux patch fixing that, and does some related cleanups. Lightly tested. Testing would be v

[Qemu-devel] [PULL v2 5/5] pixman: add a bunch of PIXMAN_BE_* defines for 32bpp

2015-03-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/qemu-pixman.h | 16 1 file changed, 16 insertions(+) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h index 3dee576..5d7a9ac 100644 --- a/include/ui/qemu-pixman.h +++ b/include/ui/qemu-pixman.h @

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Ting Wang
On 2015-3-12 17:05, Fam Zheng wrote: > On Thu, 03/12 16:35, Ting Wang wrote: >> Make "info iothreads" available on the HMP monitor. >> >> The results are as follows: >> id1: thread_id1 >> id2: thread_id2 > > Does this match the actual output format? I think you're missing a "=". > Oh, sorry. I

Re: [Qemu-devel] [PULL 0/2] target-mips queue

2015-03-12 Thread Peter Maydell
On 11 March 2015 at 16:15, Leon Alrae wrote: > Hi, > > This pull request contains remaining change for 2.3 which was originally > submitted before soft-freeze. > > Thanks, > Leon > > Cc: Peter Maydell > Cc: Aurelien Jarno > > The following changes since commit 48412371415a260d00fc7fdcdb400da55f2

Re: [Qemu-devel] [PATCH v2 3/3] target-arm: get_phys_addr_lpae: more xn control

2015-03-12 Thread Peter Maydell
On 10 March 2015 at 21:06, Andrew Jones wrote: > This patch makes the following changes to the determination of > whether an address is executable, when translating addresses > using LPAE. > > 1. No longer assumes that PL0 can't execute when it can't read. >It can in AArch64, a difference from

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-12 Thread John Snow
On 03/11/2015 12:18 PM, Stefan Hajnoczi wrote: On Mon, Mar 02, 2015 at 06:20:00PM -0500, John Snow wrote: +static void dirty_bitmap_truncate(BdrvDirtyBitmap *bitmap, uint64_t size) +{ +/* Should only be frozen during a block backup job, which should have + * blocked any resize actions.

[Qemu-devel] [PULL 3/7] vnc: switch to inet_listen_opts

2015-03-12 Thread Gerd Hoffmann
Use inet_listen_opts instead of inet_listen. Allows us to drop some pointless indirection: Format strings just to parse them again later on. Signed-off-by: Gerd Hoffmann Tested-by: Gonglei Reviewed-by: Gonglei --- ui/vnc.c | 75 +++-

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2015-03-12 Thread Mohammed Gamal
Ping. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1297218 Title: guest hangs after live migration due to tsc jump Status in QEMU: New Status in glusterfs package in Ubuntu: Invalid Status in

[Qemu-devel] [PULL 4/7] ui: fix regression in x509verify parameter for VNC server

2015-03-12 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The 'x509verify' parameter is documented as taking a path to the x509 certificates, ie the same syntax as the 'x509' parameter. commit 4db14629c38611061fc19ec6927405923de84f08 Author: Gerd Hoffmann Date: Tue Sep 16 12:33:03 2014 +0200 vnc: switch to QemuO

[Qemu-devel] [PULL 0/7] vnc patch queue.

2015-03-12 Thread Gerd Hoffmann
ble in the git repository at: git://git.kraxel.org/qemu tags/pull-vnc-20150312-1 for you to fetch changes up to 81607cbfa433272d1f09bd0f0ae6c3b14f818972: vnc: fix segmentation fault when invalid vnc parameters are specified (2015-03-12 09:0

[Qemu-devel] [PULL 1/7] vnc: drop display+ws_display from VncDisplay

2015-03-12 Thread Gerd Hoffmann
Nobody cares about those strings, they are only used to check whenever the vnc server / websocket support is enabled or not. Add bools for this and drop the strings. Signed-off-by: Gerd Hoffmann Reviewed-by: Gonglei --- ui/vnc-auth-sasl.c | 2 +- ui/vnc.c | 54 ++

[Qemu-devel] [PATCH] smbios: add max speed comdline option for type-17 (meory device) structure

2015-03-12 Thread Gabriel L. Somlo
Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 10 -- qemu-options.hx | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index f2e9ab6..1341e02 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -91,6 +91,7 @@ static s

Re: [Qemu-devel] [PATCH 2/2 RFC] s390x/pci: rework pci infrastructure modeling

2015-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 09:46:44AM +0100, Frank Blaschka wrote: > On Wed, Mar 11, 2015 at 03:57:05PM +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2015 at 03:38:44PM +0100, Frank Blaschka wrote: > > > I like Alex's idea because: > > > 1) It reflects pretty well the actual nature of the pci s

Re: [Qemu-devel] [PATCH V3 00/14] Support more virtio queues

2015-03-12 Thread Michael S. Tsirkin
On Thu, Mar 05, 2015 at 01:48:37PM +0800, Jason Wang wrote: > We current limit the max virtio queues to 64. This is not sufficient > to support multiqueue deivces (e.g recent Linux support up to 256 > tap queues). So this series try to let virtio to support more queues. For some reason I was Cc'd

Re: [Qemu-devel] [PATCH v6 07/15] spapr_rtas: add ibm, configure-connector RTAS interface

2015-03-12 Thread David Gibson
On Thu, Mar 05, 2015 at 08:12:58AM -0600, Michael Roth wrote: > Quoting David Gibson (2015-03-04 22:30:40) > > On Wed, Mar 04, 2015 at 07:37:08AM -0600, Michael Roth wrote: > > > Quoting Michael Roth (2015-03-03 23:50:34) > > > > Quoting David Gibson (2015-03-02 23:33:39) > > > > > On Mon, Mar 02,

Re: [Qemu-devel] [PATCH v5 15/45] Rework loadvm path for subloops

2015-03-12 Thread David Gibson
On Wed, Feb 25, 2015 at 04:51:38PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Postcopy needs to have two migration streams loading concurrently; > one from memory (with the device state) and the other from the fd > with the memory transactions. > > Split the

Re: [Qemu-devel] [PATCH v5 17/45] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

2015-03-12 Thread David Gibson
On Wed, Feb 25, 2015 at 04:51:40PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The state of the postcopy process is managed via a series of messages; >* Add wrappers and handlers for sending/receiving these messages >* Add state variable that track the

Re: [Qemu-devel] [PATCH v5 16/45] Add migration-capability boolean for postcopy-ram.

2015-03-12 Thread David Gibson
On Wed, Feb 25, 2015 at 04:51:39PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" This absolutely needs a commit message. I shouldn't have to look at the code to find out what the presence of this capability asserts, and from where to where it's communicating that in

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Ting Wang
On 2015-3-12 17:05, Fam Zheng wrote: > On Thu, 03/12 16:35, Ting Wang wrote: >> Make "info iothreads" available on the HMP monitor. >> >> The results are as follows: >> id1: thread_id1 >> id2: thread_id2 > > Does this match the actual output format? I think you're missing a "=". > >> >> Signed-

Re: [Qemu-devel] [PATCH V3 00/14] Support more virtio queues

2015-03-12 Thread Jason Wang
On Thu, Mar 12, 2015 at 5:28 PM, Michael S. Tsirkin wrote: On Thu, Mar 05, 2015 at 01:48:37PM +0800, Jason Wang wrote: We current limit the max virtio queues to 64. This is not sufficient to support multiqueue deivces (e.g recent Linux support up to 256 tap queues). So this series try to

Re: [Qemu-devel] [PATCH v2] hmp: add info iothreads command

2015-03-12 Thread Fam Zheng
On Thu, 03/12 17:32, Ting Wang wrote: > It is a command in "info" group, I think documentation as follows is OK, do > you agree with it? > >> diff --git a/hmp-commands.hx b/hmp-commands.hx > >> index d5022d8..67d76ed 100644 > >> --- a/hmp-commands.hx > >> +++ b/hmp-commands.hx > >> @@ -1746,6 +174

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote: > Currently we could leave PCI IRQ asserted even after reset, it is safer > to clear it. > > In the case that a buggy driver has disabled MSI-X unintentially, we may > have already injected IRQ in previous virtio_pci_notify, which will not

Re: [Qemu-devel] [PATCH RFC v3 13/27] COLO RAM: Flush cached RAM into SVM's memory

2015-03-12 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We only need to flush RAM that is both dirty on PVM and SVM since > last checkpoint. Besides, we must ensure flush RAM cache before load > device state. > > Signed-off-by: zhanghailiang a > Signed-off-by: Lai Jiangshan > Signed-off-by: Li

[Qemu-devel] [PATCH V2] virtio: validate the existence of handle_output before calling it

2015-03-12 Thread Jason Wang
We don't validate the existence of handle_output which may let a buggy guest to trigger a SIGSEV easily. E.g: 1) write 10 to queue_sel to a virtio net device with only 1 queue 2) setup an arbitrary pfn 3) then notify queue 10 Fixing this by validating the existence of handle_output before. Cc: q

Re: [Qemu-devel] [PATCH RFC v3 13/27] COLO RAM: Flush cached RAM into SVM's memory

2015-03-12 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/3/12 4:07, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>We only need to flush RAM that is both dirty on PVM and SVM since > >>last checkpoint. Besides, we must ensure flush RAM cache be

Re: [Qemu-devel] [PATCH 2/2 RFC] s390x/pci: rework pci infrastructure modeling

2015-03-12 Thread Frank Blaschka
On Wed, Mar 11, 2015 at 06:42:34PM +0100, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2015 at 03:38:44PM +0100, Frank Blaschka wrote: > > On Tue, Mar 10, 2015 at 03:26:23PM +0100, Michael S. Tsirkin wrote: > > > On Tue, Mar 10, 2015 at 02:03:34PM +0100, Frank Blaschka wrote: > > > > This patch chan

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-03-12 Thread Dr. David Alan Gilbert
* Andrey Korolyov (and...@xdel.ru) wrote: > On Wed, Mar 11, 2015 at 10:59 PM, Dr. David Alan Gilbert > wrote: > > * Andrey Korolyov (and...@xdel.ru) wrote: > >> On Wed, Mar 11, 2015 at 10:33 PM, Dr. David Alan Gilbert > >> wrote: > >> > * Kevin O'Connor (ke...@koconnor.net) wrote: > >> >> On Wed,

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-12 Thread Fam Zheng
On Thu, 03/12 10:41, Michael S. Tsirkin wrote: > On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote: > > Currently we could leave PCI IRQ asserted even after reset, it is safer > > to clear it. > > > > In the case that a buggy driver has disabled MSI-X unintentially, we may > > have already

Re: [Qemu-devel] [PATCH 2/2 RFC] s390x/pci: rework pci infrastructure modeling

2015-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 10:54:24AM +0100, Frank Blaschka wrote: > On Wed, Mar 11, 2015 at 06:42:34PM +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2015 at 03:38:44PM +0100, Frank Blaschka wrote: > > > On Tue, Mar 10, 2015 at 03:26:23PM +0100, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10,

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 06:00:28PM +0800, Fam Zheng wrote: > On Thu, 03/12 10:41, Michael S. Tsirkin wrote: > > On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote: > > > Currently we could leave PCI IRQ asserted even after reset, it is safer > > > to clear it. > > > > > > In the case that a

Re: [Qemu-devel] [PATCH v2] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv

2015-03-12 Thread Aneesh Kumar K.V
Michael Tokarev writes: > Don't compare syscall return with -1, use "<0" condition. > Don't introduce useless local variables when we already > have similar variable > Rename local variable to be consistent with other usages > Finally make the two methods, read and write, to be similar to each ot

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 06:00:28PM +0800, Fam Zheng wrote: > On Thu, 03/12 10:41, Michael S. Tsirkin wrote: > > On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote: > > > Currently we could leave PCI IRQ asserted even after reset, it is safer > > > to clear it. > > > > > > In the case that a

Re: [Qemu-devel] [PATCH] virtio-pci: Clear IRQ at reset

2015-03-12 Thread Peter Maydell
On 12 March 2015 at 10:16, Michael S. Tsirkin wrote: > So thinking about this more, by the time kdump tries to reset device, > linux has probably already disabled the IRQ at the APIC level. > Isn't that the case? If so, the patch won't help, will it? Trying to deassert (or worse, assert) interrup

  1   2   3   4   >