As noted by Andreas, hw/boards.h shouldn't be used outside softmmu code.
Include it conditionally, and drop the (now unnecessary) ifdef guards in
hw/boards.h
Reported-by: Andreas Färber
Cc: Peter Maydell
Signed-off-by: Michael S. Tsirkin
---
include/hw/boards.h | 4
exec.c |
On Wed, 03/11 15:01, Wen Congyang wrote:
> On 03/11/2015 02:49 PM, Fam Zheng wrote:
> > On Wed, 03/11 14:44, Wen Congyang wrote:
> >> On 03/03/2015 03:59 PM, Fam Zheng wrote:
> >>> On Tue, 03/03 15:53, Wen Congyang wrote:
> I test qcow2_make_empty()'s performance. The result shows that it may
On 11/03/2015 07:58, Michael S. Tsirkin wrote:
> As noted by Andreas, hw/boards.h shouldn't be used outside softmmu code.
> Include it conditionally, and drop the (now unnecessary) ifdef guards in
> hw/boards.h
>
> Reported-by: Andreas Färber
> Cc: Peter Maydell
> Signed-off-by: Michael S. Tsi
On 03/11/2015 03:04 PM, Fam Zheng wrote:
> On Wed, 03/11 15:01, Wen Congyang wrote:
>> On 03/11/2015 02:49 PM, Fam Zheng wrote:
>>> On Wed, 03/11 14:44, Wen Congyang wrote:
On 03/03/2015 03:59 PM, Fam Zheng wrote:
> On Tue, 03/03 15:53, Wen Congyang wrote:
>> I test qcow2_make_empty()'
On Wed, 02/18 22:48, Michael S. Tsirkin wrote:
> Drop duplicated code.
>
> Signed-off-by: Michael S. Tsirkin
> Acked-by: Paolo Bonzini
Michael, this breaks virtio-scsi-pci:
qemu-system-x86_64: wrong size for virtio-scsi headers
Because:
> -
> -/* SCSI command request, followed by CDB and
Andreas Färber writes:
> Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin:
>> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote:
>>> Hi,
>>>
>>> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum:
Fixes a QEMU crash when passing dump_guest_core parameter in command line.
>>>
>>> E
"Gabriel L. Somlo" writes:
> On Tue, Mar 10, 2015 at 09:40:09AM +0100, Markus Armbruster wrote:
>> "Gabriel L. Somlo" writes:
>> > Assuming the above is correct (and that the appropriate glue is added
>> > to qemu-options.hx to tie "-foo name=abc,file=xyz" to QEMU_OPTION_foo),
>> > I'm wondering
Christian Borntraeger writes:
> Am 10.03.2015 um 19:01 schrieb Peter Maydell:
>> On 10 March 2015 at 08:37, Christian Borntraeger
>> wrote:
>>> Peter,
>>>
>>> this pull reuqest contains a header sync to 4.0-rc3. This should cause
>>> no merge conflicts with other header syncs against 4.0-rc2. So
Am 11.03.2015 um 08:57 schrieb Markus Armbruster:
> Christian Borntraeger writes:
>
>> Am 10.03.2015 um 19:01 schrieb Peter Maydell:
>>> On 10 March 2015 at 08:37, Christian Borntraeger
>>> wrote:
Peter,
this pull reuqest contains a header sync to 4.0-rc3. This should cause
n
On Wed, 11 Mar 2015 08:57:34 +0100
Markus Armbruster wrote:
> Christian Borntraeger writes:
>
> > Am 10.03.2015 um 19:01 schrieb Peter Maydell:
> >> On 10 March 2015 at 08:37, Christian Borntraeger
> >> wrote:
> >>> Peter,
> >>>
> >>> this pull reuqest contains a header sync to 4.0-rc3. This s
From: Gonglei
Signed-off-by: Gonglei
---
ui/console.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index 87af6b5..b15ca87 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1285,9 +1285,9 @@ DisplaySurface *qemu_create_displaysurface_guestmem
Paolo Bonzini writes:
> "info profile" is not great in several ways:
>
> 1) half of it only works for TCG, but doesn't say this anywhere.
>
> 2) the division by get_ticks_per_sec() doesn't work since the unit of
> measurement is clock cycles rather than nanoseconds. (Broken since 2006
> by Fabri
From: Gonglei
patch 1 reported by coverity several month ago,
patch 2 is founded by code review.
Gonglei (2):
ui/console: fix OVERFLOW_BEFORE_WIDEN
vnc: avoid possible file handler leak
ui/console.c | 4 ++--
ui/vnc.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--
1.7.1
From: Gonglei
vs->lsock may equal to 0, modify the check condition,
avoid possible vs->lsock leak.
Signed-off-by: Gonglei
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 10a2724..259eca2 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3641,7
On Wed, Mar 11, 2015 at 03:14:16PM +0800, Fam Zheng wrote:
> On Wed, 02/18 22:48, Michael S. Tsirkin wrote:
> > Drop duplicated code.
> >
> > Signed-off-by: Michael S. Tsirkin
> > Acked-by: Paolo Bonzini
>
> Michael, this breaks virtio-scsi-pci:
>
> qemu-system-x86_64: wrong size for virti
On 10 March 2015 at 11:16, Gerd Hoffmann wrote:
> Hi,
>
> Here comes the vnc patch queue with a few vnc bugfixes.
>
> please pull,
> Gerd
>
> The following changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5:
>
> Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstr
On Wed, Mar 11, 2015 at 08:34:09AM +0100, Markus Armbruster wrote:
> Andreas Färber writes:
>
> > Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin:
> >> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote:
> >>> Hi,
> >>>
> >>> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum:
> F
Michael Tokarev writes:
> 10.03.2015 20:41, Aneesh Kumar K.V пишет:
>> Michael Tokarev writes:
>>
>>> 08.03.2015 19:27, Aneesh Kumar K.V wrote:
Michael Tokarev writes:
>>> []
> Actually, after reading almost whole 9pfs and fsdev code, I can
> say with great confidence this code is
"Daniel P. Berrange" writes:
> On Tue, Mar 10, 2015 at 06:26:38PM +0100, Markus Armbruster wrote:
>> RFC because the series only covers open [PATCH 1], but not create.
>> Also missing: make qemu-img print a warning when it creates an
>> encrypted image. Finally, some of the material in the cover
Hello,
On 11.03.2015 07:22, Xiaodong Gong wrote:
>> Hope that clarified things.
...
> first，your patch is very clear，a good sample.
>
> store ascii code in kernel that I said before is a mistake，I mean the
> glibc need the input of arguments of fuction such as fopen（path）is
> ascii code
No:
ASC
On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas Färber wrote:
> Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin:
> > On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote:
> >> Hi,
> >>
> >> Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum:
> >>> Fixes a QEMU crash when passing dump_gue
"Daniel P. Berrange" writes:
> On Tue, Mar 10, 2015 at 06:26:39PM +0100, Markus Armbruster wrote:
[...]
>> diff --git a/include/block/block.h b/include/block/block.h
>> index 649c269..76b6d3c 100644
>> --- a/include/block/block.h
>> +++ b/include/block/block.h
>> @@ -76,6 +76,7 @@ typedef enum {
On Wed, 11 Mar 2015 09:09:21 +0100
Christian Borntraeger wrote:
> Am 11.03.2015 um 08:57 schrieb Markus Armbruster:
> > Christian Borntraeger writes:
> >
> >> Am 10.03.2015 um 19:01 schrieb Peter Maydell:
> >>> On 10 March 2015 at 08:37, Christian Borntraeger
> >>> wrote:
> Peter,
>
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> Hi Dave,
>
> Sorry for the late reply :)
No problem.
> On 2015/3/7 2:30, Dr. David Alan Gilbert wrote:
> >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> >>On 2015/3/5 21:31, Dr. David Alan Gilbert (git) wrote:
> >>>From: "Dr. D
On Fri, Mar 06, 2015 at 10:11:39AM -0700, Eric Blake wrote:
> I'm still thinking about the actual patch, and whether we want
> to commit to this or just bite the bullet and go for full
> introspection. At any rate, it's a bit late for 2.3, so we have the
> full 2.4 cycle to get it right.
I under
Commit "virtio-scsi: use standard-headers" added
cdb and sense into req/rep structures, which
breaks uses of sizeof for these structures,
since qemu adds its own arrays on top.
To fix, replace sizeof with offsetof everywhere.
Reported-by: Fam Zheng
Signed-off-by: Michael S. Tsirkin
---
Note: t
On Tue, Mar 10, 2015 at 11:51:21AM +0300, Denis V. Lunev wrote:
> Try to perform IO for the biggest continuous block possible.
> All blocks abscent in the image are accounted in the same type
> and preallocation is made for all of them at once.
>
> The performance for sequential write is increased
On 2015/3/11 17:06, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
Hi Dave,
Sorry for the late reply :)
No problem.
On 2015/3/7 2:30, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
On 2015/3/5 21:31, Dr. David A
On 03/11/2015 10:45 AM, Michael S. Tsirkin wrote:
On Wed, Mar 11, 2015 at 08:34:09AM +0100, Markus Armbruster wrote:
Andreas Färber writes:
Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin:
On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote:
Hi,
Am 04.02.2015 um 16:43 schrieb
On 03/10/2015 11:36 PM, Andreas Färber wrote:
Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin:
On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote:
Hi,
Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum:
Fixes a QEMU crash when passing dump_guest_core parameter in command line.
Ex
On Wed, Mar 11, 2015 at 09:48:46AM +0800, Gonglei wrote:
> On 2015/3/11 0:27, Daniel P. Berrange wrote:
> > The 'x509verify' parameter is documented as taking a path to the
> > x509 certificates, ie the same syntax as the 'x509' parameter.
> >
> > commit 4db14629c38611061fc19ec6927405923de84f08
On 11/03/2015 09:31, Michael S. Tsirkin wrote:
> On Wed, Mar 11, 2015 at 03:14:16PM +0800, Fam Zheng wrote:
>> On Wed, 02/18 22:48, Michael S. Tsirkin wrote:
>>> Drop duplicated code.
>>>
>>> Signed-off-by: Michael S. Tsirkin
>>> Acked-by: Paolo Bonzini
>>
>> Michael, this breaks virtio-scsi-pc
All fields in structures transmitted by ccws are big endian; assure
we handle them as such.
Reviewed-by: Thomas Huth
Reviewed-by: David Hildenbrand
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a
Hi!
This particular patch broke virtio-scsi in SLOF (ppc64-server firmware),
QEMU just exits:
Populating /pci@8002000/scsi@0
SCSI: Looking for devices
qemu-system-ppc64: wrong size for virtio-scsi headers
This is how I run it:
-device virtio-scsi-pci,id=id3 \
-drive id=id4,if
Am 10.03.2015 um 18:26 hat Markus Armbruster geschrieben:
> Signed-off-by: Markus Armbruster
> ---
> block/qcow.c | 5 +
> block/qcow2.c | 5 +
> include/block/block.h | 3 +--
> qemu-img.c| 1 +
> 4 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --
All fields in structures transmitted by ccws are big endian; assure
we handle them as such for the set-revision ccw as well.
Should be merged into "s390x/virtio-ccw: add virtio set-revision call".
CC: Thomas Huth
Signed-off-by: Cornelia Huck
---
hw/s390x/virtio-ccw.c | 15 +--
1 fi
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> On 2015/3/11 17:06, Dr. David Alan Gilbert wrote:
> >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> >>Hi Dave,
> >>
> >>Sorry for the late reply :)
> >
> >No problem.
> >
> >>On 2015/3/7 2:30, Dr. David Alan Gilbert wrote:
> >>>*
Am 11.03.2015 um 10:00 schrieb Thomas Huth:
> On Wed, 11 Mar 2015 09:09:21 +0100
> Christian Borntraeger wrote:
>
>> Am 11.03.2015 um 08:57 schrieb Markus Armbruster:
>>> Christian Borntraeger writes:
>>>
Am 10.03.2015 um 19:01 schrieb Peter Maydell:
> On 10 March 2015 at 08:37, Christi
From: Thomas Huth
The current bios sits at location 0x7e0 in the guest RAM
and thus prevents loading of bigger ramdisks. By making the
image relocatable we can move it to the end of the RAM so that
it is getting out of the way.
Signed-off-by: Thomas Huth
Message-Id: <1425895973-15239-3-git-
Cc'ing Amos, who grappled with this in the past.
Alberto Garcia writes:
> On Fri, Mar 06, 2015 at 10:11:39AM -0700, Eric Blake wrote:
>
>> I'm still thinking about the actual patch, and whether we want
>> to commit to this or just bite the bullet and go for full
>> introspection. At any rate, i
I noticed this while I was trying to debug something and so was
single stepping through the CPU realize function.
The rcu thread seems to get set up and try to start working too
early in QEMU's initialization process. Specifically, it can try
to do things before we've completed the creation and in
From: Roman Kagan
Implement VFS method for get_block_status to Parallels format driver.
Signed-off-by: Roman Kagan
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 21 +
1 file changed, 21 insertions(+)
BAT means 'block allocation table'. Thus this name is clean and shorter
on writing.
Some obvious formatting fixes in the old code were made to make checkpatch
happy.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 56 +
The check is very simple at the moment. It calculates necessary stats
and fix only the following errors:
- space leak at the end of the image. This would happens due to
preallocation
- clusters outside the image are zeroed. Nothing else could be done here
Signed-off-by: Denis V. Lunev
CC: Roman
Am 06.03.2015 um 18:11 hat Eric Blake geschrieben:
> On 02/24/2015 06:51 AM, Alberto Garcia wrote:
> > Hello,
> >
> > this is a follow-up to the comments from Eric Blake about my patches
> > to extend the block streaming API:
> >
> >https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg042
Support write on Parallels images. The code is almost the same as one
in the previous patch implemented scatter-gather IO for read.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 77
Signed-off-by: Denis V. Lunev
Reviwed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
tests/qemu-iotests/115 | 68 ++
tests/qemu-iotests/115.out | 24
tests/qemu-iotests/group | 1 +
3 files changed, 93 insertions(+)
c
Try to perform IO for the biggest continuous block possible.
The performance for sequential read is increased from 220 Gb/sec to
360 Gb/sec for continous image on my SSD HDD.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 37 +
From: Roman Kagan
Switch the .bdrv_read method implementation from using bdrv_pread() to
bdrv_read() on the underlying file, since the latter is subject to i/o
throttling while the former is not.
Besides, since bdrv_read() operates in sectors rather than bytes, adjust
the helper functions to do
Try to perform IO for the biggest continuous block possible.
All blocks abscent in the image are accounted in the same type
and preallocation is made for all of them at once.
The performance for sequential write is increased from 200 Gb/sec to
235 Gb/sec on my SSD HDD.
Signed-off-by: Denis V. Lun
suggested by Jeff Cody
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
tests/qemu-iotests/076 | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/qemu-iotests/076 b/tests/qemu-iotests/076
index ed2be35..0139976 100
This will allow to use this data as buffer to BAT update directly
without any intermediate buffers.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --g
From: Roman Kagan
Teach parallels_read() to do reads in coarser granularity than just a
single sector: if requested, read up to the cluster end in one go.
Signed-off-by: Roman Kagan
Reviewed-by: Denis V. Lunev
Signed-off-by: Denis V. Lunev
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/paral
The idea is that we do not need to immediately sync BAT to the image as
from the guest point of view there is a possibility that IO is lost
even in the physical controller until flush command was finished.
bdrv_co_flush_to_os is exactly the right place for this purpose.
Technically the patch uses
This patchset provides an ability to create of/write to Parallels
images and some testing of the new code. Readings and writings are
optimized out and I expect the same or slightly better performance
as qcow2.
This patchset consists of not problematic part of the previous
patchset aka
[PATCH v4
This is preparational commit for tweaks in Parallels image expansion.
The idea is that enlarge via truncate by one data block is slow. It
would be much better to use fallocate via bdrv_write_zeroes and
expand by some significant amount at once.
This patch just adds proper parameters into BDRVParal
simple purification..
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 64b169b..306f2e3 100644
--- a/block/par
Do not even care to create WithoutFreeSpace image, it is obsolete.
Always create WithouFreSpacExt one.
The code also does not spend a lot of efforts to fill cylinders and
heads fields, they are not used actually in a real life neither in
QEMU nor in Parallels products.
Signed-off-by: Denis V. Lun
Plain image expansion spends a lot of time to update image file size.
This seriously affects the performance. The following simple test
qemu_img create -f parallels -o cluster_size=64k ./1.hds 64G
qemu_io -n -c "write -P 0x11 0 1024M" ./1.hds
could be improved if the format driver will pre-allo
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
tests/qemu-iotests/076 | 5 +
tests/qemu-iotests/076.out | 10 ++
2 files changed, 15 insertions(+)
diff --git a/tests/qemu-iotests/076 b/tests/qemu-iotests/076
index 0139976..c9b55a
Main approach is taken from qcow2_co_readv.
The patch drops coroutine lock for the duration of IO operation and
peforms normal scatter-gather IO using standard QEMU backend.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 46 +
Signed-off-by: Denis V. Lunev
Reviwed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
tests/qemu-iotests/115 | 9 +
tests/qemu-iotests/115.out | 17 +
2 files changed, 26 insertions(+)
diff --git a/tests/qemu-iotests/115 b/tests/qemu-iotests/115
index f45af
calculate offset of the BAT entry in the image file.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index
The software driver must set inuse field in Parallels header to
0x746F6E59 when the image is opened in read-write mode. The presence of
this magic in the header on open forces image consistency check.
There is an unfortunate trick here. We can not check for inuse in
parallels_check as this will ha
On Thu, Feb 12, 2015 at 04:05:06PM +0100, Andrew Jones wrote:
> This patch makes the following changes to the determination of
> whether an address is executable, when translating addresses
> using LPAE.
>
> 1. No longer assumes that PL0 can't execute when it can't read.
>It can in AArch64, a
This metadata cache would allow to properly batch BAT updates to disk
in next patches. These updates will be properly aligned to avoid
read-modify-write transactions on block level.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c
>From the point of guest each write to real disk prior to disk barrier
operation could be lost. Therefore there is no problem that "not synced"
new block is lost due to not updated allocation table if QEMU is crashed.
This situation is properly detected and handled now using inuse magic
and in para
this follows QEMU coding convention
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 4f9cd8d..dca0df6 100644
-
Am 11.03.2015 um 11:21 hat Markus Armbruster geschrieben:
> Cc'ing Amos, who grappled with this in the past.
>
> Alberto Garcia writes:
>
> > On Fri, Mar 06, 2015 at 10:11:39AM -0700, Eric Blake wrote:
> >
> >> I'm still thinking about the actual patch, and whether we want
> >> to commit to this
Signed-off-by: Denis V. Lunev
Reviwed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 28338ec..7ef3136 100644
--- a/block/parallels.c
+++ b/block/parall
deduplicate copy/paste arithmetcs
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index a7c66dc..6bc5e62 10064
This will help to avoid forward declarations for upcoming parallels_check
Some very obvious formatting fixes were made to the moved code to make
checkpatch happy.
Signed-off-by: Denis V. Lunev
Reviewed-by: Roman Kagan
CC: Kevin Wolf
CC: Stefan Hajnoczi
---
block/parallels.c | 185 +++
On Wed, Mar 11, 2015 at 01:28:12PM +0300, Denis V. Lunev wrote:
> The check is very simple at the moment. It calculates necessary stats
> and fix only the following errors:
> - space leak at the end of the image. This would happens due to
> preallocation
> - clusters outside the image are zeroed.
Hi Michael,
"Michael S. Tsirkin" writes:
> Drop duplicated code.
>
> Signed-off-by: Michael S. Tsirkin
This patch is breaking SLOF. Reason below:
> ---
> include/hw/virtio/virtio-scsi.h | 120
> +++-
> hw/scsi/virtio-scsi.c | 1 +
> 2 files ch
On 03/11/2015 09:13 PM, Alexey Kardashevskiy wrote:
Hi!
This particular patch broke virtio-scsi in SLOF (ppc64-server firmware),
QEMU just exits:
Oops, there was v3 and Nikunj asked there. Ignore this.
Populating /pci@8002000/scsi@0
SCSI: Looking for devices
qemu-system-ppc
From: Claudio Fontana
usage is similar to the commands x, xp.
Example with string: looking for "ELF" header in memory:
(qemu) s/100cb 0x40001000 "ELF"
searching memory area [40001000-400f5240]
40090001
(qemu) x/20b 0x4009
4009: '\x7f' 'E' 'L' 'F' '\x0
Am 11.03.2015 um 09:56 schrieb Michael S. Tsirkin:
> On Tue, Mar 10, 2015 at 10:36:56PM +0100, Andreas Färber wrote:
>> Am 10.03.2015 um 22:24 schrieb Michael S. Tsirkin:
>>> On Tue, Mar 10, 2015 at 06:50:24PM +0100, Andreas Färber wrote:
Hi,
Am 04.02.2015 um 16:43 schrieb Marcel Apf
On 2015/3/11 17:45, Daniel P. Berrange wrote:
> On Wed, Mar 11, 2015 at 09:48:46AM +0800, Gonglei wrote:
>> On 2015/3/11 0:27, Daniel P. Berrange wrote:
>>> The 'x509verify' parameter is documented as taking a path to the
>>> x509 certificates, ie the same syntax as the 'x509' parameter.
>>>
>>>
Am 11.03.2015 um 07:58 schrieb Michael S. Tsirkin:
> As noted by Andreas, hw/boards.h shouldn't be used outside softmmu code.
> Include it conditionally, and drop the (now unnecessary) ifdef guards in
> hw/boards.h
>
> Reported-by: Andreas Färber
> Cc: Peter Maydell
> Signed-off-by: Michael S. T
On Wed, Mar 11, 2015 at 07:07:49PM +0800, Gonglei wrote:
> On 2015/3/11 17:45, Daniel P. Berrange wrote:
> > On Wed, Mar 11, 2015 at 09:48:46AM +0800, Gonglei wrote:
> >> On 2015/3/11 0:27, Daniel P. Berrange wrote:
> >>> The 'x509verify' parameter is documented as taking a path to the
> >>> x509 c
On Tue, Mar 10, 2015 at 11:43:41PM +0100, Andreas Färber wrote:
> Am 10.03.2015 um 22:57 schrieb Eduardo Habkost:
> > Instead of passing icc_bridge from the PC initialization code to
> > cpu_x86_create(), make the PC initialization code attach the CPU to
> > icc_bridge.
> >
> > The only difference
On 25/02/2015 19:08, Max Reitz wrote:
> Just returning -EINVAL for everything is bad. -EIO is often better, and
> sometimes there is an even more fitting value.
Propagating the return value from write_sync is uglier, but it is even
better in terms of returned value.
Paolo
> Signed-off-by: Max
On Mon, 2015-03-09 at 14:45 +0800, Chen, Tiejun wrote:
> On 2015/3/6 20:55, Wei Liu wrote:
> > On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote:
> >> Although we already have 'gfx_passthru' in b_info, this doesn' suffice
On 2015/3/11 19:10, Daniel P. Berrange wrote:
> On Wed, Mar 11, 2015 at 07:07:49PM +0800, Gonglei wrote:
>> On 2015/3/11 17:45, Daniel P. Berrange wrote:
>>> On Wed, Mar 11, 2015 at 09:48:46AM +0800, Gonglei wrote:
On 2015/3/11 0:27, Daniel P. Berrange wrote:
> The 'x509verify' parameter i
On 25/02/2015 19:08, Max Reitz wrote:
> In case the connection is closed before the export length can be read,
> and an export name had been specified, this generally indicates that for
> some reason the export could not be opened (e.g. there is no export with
> that name). Make the error message
On Tue, 2015-03-10 at 17:42 +0800, Tiejun Chen wrote:
> While working with qemu, IGD is a specific device in the case of pass through
> so we need to identify that to handle more later. Here we define a table to
> record all IGD types currently we can support. Also we need to introduce two
> helper
On Wed, Mar 11, 2015 at 07:24:58PM +0800, Gonglei wrote:
> On 2015/3/11 19:10, Daniel P. Berrange wrote:
> > On Wed, Mar 11, 2015 at 07:07:49PM +0800, Gonglei wrote:
> >> On 2015/3/11 17:45, Daniel P. Berrange wrote:
> >>> On Wed, Mar 11, 2015 at 09:48:46AM +0800, Gonglei wrote:
> On 2015/3/11
On 25/02/2015 19:08, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> blockdev-nbd.c | 6 +-
> include/block/nbd.h | 3 ++-
> nbd.c | 19 ---
> qemu-nbd.c | 10 +-
> 4 files changed, 32 insertions(+), 6 deletions(-)
>
> diff --git a/
On 10.03.15 04:20, Alexey Kardashevskiy wrote:
> On 03/10/2015 04:38 PM, Alexander Graf wrote:
>>
>>
>>
>>> Am 09.03.2015 um 23:44 schrieb Alexey Kardashevskiy :
>>>
On 03/10/2015 02:58 PM, David Gibson wrote:
> On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote:
>>
On 2015/3/11 19:03, hw.clau...@gmail.com wrote:
> From: Claudio Fontana
>
> usage is similar to the commands x, xp.
>
> Example with string: looking for "ELF" header in memory:
>
> (qemu) s/100cb 0x40001000 "ELF"
> searching memory area [40001000-400f5240]
> 40090001
On 25/02/2015 19:08, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> include/block/nbd.h | 4 ++--
> qemu-nbd.c | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/include/block/nbd.h b/include/block/nbd.h
> index 2c20138..53726e8 100644
> --- a/include/
On 25/02/2015 19:08, Max Reitz wrote:
> This patch makes sure the result of strtol() does not overflow (by
> storing it in long integers instead of plain integers, and by checking
> errno), allows the user to specify "--discard on" and
> "--detect-zeroes unmap" in any order and strips the trailin
On 2015/3/11 19:27, Daniel P. Berrange wrote:
> On Wed, Mar 11, 2015 at 07:24:58PM +0800, Gonglei wrote:
>> On 2015/3/11 19:10, Daniel P. Berrange wrote:
>>> On Wed, Mar 11, 2015 at 07:07:49PM +0800, Gonglei wrote:
On 2015/3/11 17:45, Daniel P. Berrange wrote:
> On Wed, Mar 11, 2015 at 09:
On 25/02/2015 19:08, Max Reitz wrote:
> If some operation cannot be performed by a block driver, it is normally
> supposed to return an error. In these cases, however, it is fine to
> pretend the operations were carried out successfully because if the NBD
> block driver would not implement discar
On 13 February 2015 at 06:21, Richard Henderson wrote:
> On 02/06/2015 06:02 AM, Peter Maydell wrote:
>> The documentation for sextract64() claims that the return type is
>> an int64_t, but the code itself disagrees. Fix the return type to
>> conform to the documentation and to bring it into line
On Tue, 2015-03-10 at 17:42 +0800, Tiejun Chen wrote:
> Although we already have 'gfx_passthru' in b_info, this doesn' suffice
> after we want to handle IGD specifically. Now we define a new field of
> type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually
> this means we can benef
The following changes since commit 4ba4df405c766b7f9e46ef145e140961155348e6:
Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into
staging (2015-03-11 08:44:59 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git
On 25/02/2015 19:08, Max Reitz wrote:
> This series contains a variety of fixes for qemu's NBD code, with the
> most interesting (and probably most prone to be wrong) thing being a
> timeout of ten seconds for NBD connections.
As a first step, I am applying these patches:
Max Reitz (12):
"Michael S. Tsirkin" writes:
> On Wed, Mar 11, 2015 at 02:47:47PM +0800, Fam Zheng wrote:
>> On Wed, 03/11 07:19, Michael S. Tsirkin wrote:
>> > On Wed, Mar 11, 2015 at 04:29:30PM +1030, Rusty Russell wrote:
>> > > The virtio 'used' ring describes descriptors which have been used. It
>> > > also
"Michael S. Tsirkin" writes:
> On Wed, Mar 11, 2015 at 04:29:32PM +1030, Rusty Russell wrote:
>> We only fill in the 'req->qiov.size' bytes on a (successful) read,
>> not on a write.
>>
>> Signed-off-by: Rusty Russell
>> ---
>> hw/block/virtio-blk.c | 10 +-
>> 1 file changed, 9 inserti
1 - 100 of 345 matches
Mail list logo
