Re: [Qemu-devel] [PATCH 0/2] virtio-s390: Convert to realize()

2015-03-02 Thread Christian Borntraeger
Am 27.02.2015 um 14:55 schrieb Markus Armbruster: > Markus Armbruster (2): > virtio-s390: s390_virtio_device_init() can't fail, simplify > virtio-s390: Convert to realize() > > hw/s390x/s390-virtio-bus.c | 97 > ++ > hw/s390x/s390-virtio-bus.h | 2

Re: [Qemu-devel] [PATCH] Make sysbus EHCI devices ARM only by default

2015-03-02 Thread David Gibson
On Mon, Mar 02, 2015 at 12:45:16PM +0530, Amit Shah wrote: > On (Wed) 18 Feb 2015 [16:01:01], David Gibson wrote: > > A number of ARM embedded boards include EHCI USB host controllers which > > appear as directly mapped devices, rather than sitting on a PCI bus. > > > > At present code to emulate

Re: [Qemu-devel] [PATCH] Make sysbus EHCI devices ARM only by default

2015-03-02 Thread Amit Shah
On (Mon) 02 Mar 2015 [18:28:12], David Gibson wrote: > On Mon, Mar 02, 2015 at 12:45:16PM +0530, Amit Shah wrote: > > On (Wed) 18 Feb 2015 [16:01:01], David Gibson wrote: > > > A number of ARM embedded boards include EHCI USB host controllers which > > > appear as directly mapped devices, rather th

Re: [Qemu-devel] [PATCH 1/1] scsi-hd: fix property unset case

2015-03-02 Thread Markus Armbruster
Ekaterina Tumanova writes: > check conf.blk before calling blkconf_blocksizes > > Signed-off-by: Ekaterina Tumanova > --- > hw/scsi/scsi-disk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index 2921728..df5140e 100644 >

Re: [Qemu-devel] [PATCH 3/3] migrate_incoming: Cleanup/clarify error messages

2015-03-02 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Thu) 26 Feb 2015 [14:54:41], Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Create a separate error for the case where migrate_incoming is > > used after a succesful migrate_incoming. > > > > Reword the error in the

Re: [Qemu-devel] [PATCH V13 3/4] pc: add a Virtual Machine Generation ID device

2015-03-02 Thread Michael S. Tsirkin
On Wed, Feb 25, 2015 at 05:08:52PM +, Igor Mammedov wrote: > diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h > index 1f678b4..a09cb3f 100644 > --- a/include/hw/acpi/acpi.h > +++ b/include/hw/acpi/acpi.h > @@ -25,6 +25,7 @@ > #include "qemu/option.h" > #include "exec/memory.h" >

Re: [Qemu-devel] [PATCH V2 06/11] virtio-s390: switch to bus specific queue limit

2015-03-02 Thread Cornelia Huck
On Sat, 28 Feb 2015 11:31:21 +0800 Jason Wang wrote: > > > On Fri, Feb 27, 2015 at 5:49 PM, Cornelia Huck > wrote: > > On Fri, 27 Feb 2015 06:42:57 +0008 > > Jason Wang wrote: > > > >> On Thu, Feb 26, 2015 at 9:05 PM, Cornelia Huck > >> wrote: > >> > On Thu, 26 Feb 2015 15:04:41 +0800

Re: [Qemu-devel] Announcement: Patchew server is online now

2015-03-02 Thread Markus Armbruster
Fam Zheng writes: > Hello, everyone > > I'm glad to announce the fresh Patchew server deployment: > > http://qemu.patchew.org/ Looks slick! Could the authors be made links, so I could click on myself and see all my submissions?

Re: [Qemu-devel] [PATCH 1/1] scsi-hd: fix property unset case

2015-03-02 Thread Ekaterina Tumanova
On 03/02/2015 11:46 AM, Markus Armbruster wrote: Ekaterina Tumanova writes: check conf.blk before calling blkconf_blocksizes Signed-off-by: Ekaterina Tumanova --- hw/scsi/scsi-disk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-

Re: [Qemu-devel] [PATCH V13 3/4] pc: add a Virtual Machine Generation ID device

2015-03-02 Thread Igor Mammedov
On Mon, 2 Mar 2015 09:50:39 +0100 "Michael S. Tsirkin" wrote: > On Wed, Feb 25, 2015 at 05:08:52PM +, Igor Mammedov wrote: > > diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h > > index 1f678b4..a09cb3f 100644 > > --- a/include/hw/acpi/acpi.h > > +++ b/include/hw/acpi/acpi.h > > @

Re: [Qemu-devel] Announcement: Patchew server is online now

2015-03-02 Thread Fam Zheng
On Mon, 03/02 10:03, Markus Armbruster wrote: > Fam Zheng writes: > > > Hello, everyone > > > > I'm glad to announce the fresh Patchew server deployment: > > > > http://qemu.patchew.org/ > > Looks slick! > > Could the authors be made links, so I could click on myself and see all > my submis

Re: [Qemu-devel] [PATCH v4 00/11] block: Rework bdrv_close_all()

2015-03-02 Thread Kevin Wolf
Am 27.02.2015 um 17:43 hat Max Reitz geschrieben: > Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend, > which can lead to data corruption (see the iotest added in the final > patch of this series) and is most certainly very ugly. > > This series reworks bdrv_close_all() to ins

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-03-02 Thread Paolo Bonzini
On 01/03/2015 11:36, Gerhard Wiesinger wrote: > So far it happened only the PostgreSQL database VM. Kernel is alive > (ping works well). ssh is not working. > console window: after entering one character at login prompt, then crashed: > [1438.384864] Out of memory: Kill process 10115 (pg_dump) sc

Re: [Qemu-devel] [PATCH v3 03/10] acpi, mem-hotplug: Add acpi_send_gpe_event() to rise sci for memory hotplug.

2015-03-02 Thread Igor Mammedov
On Sun, 1 Mar 2015 18:29:39 +0100 "Michael S. Tsirkin" wrote: > On Thu, Feb 26, 2015 at 09:16:45AM +0800, Zhu Guihua wrote: > > From: Tang Chen > > > > Add a new API named acpi_send_gpe_event() to send memory hotplug SCI. > > Doing this is because this procedure will be used by other functions

Re: [Qemu-devel] [PATCH 0/1]

2015-03-02 Thread Kevin Wolf
Am 27.02.2015 um 19:26 hat Ekaterina Tumanova geschrieben: > for Max Reitz: > > Can you please apply this patch and re-test? > > Thanks! > Kate > > p.s. This is supposed to be merged with patch 5/5 of > "Geometry and blocksize detection for backing devices" > > Ekaterina Tumanova (1): > scsi-

Re: [Qemu-devel] [PATCH] qerror.h: Swap definitions that were not in alphabetical order

2015-03-02 Thread Markus Armbruster
Michael Tokarev writes: > Applied to -trivial, thank you! > > Markus, should I add your Reviewed-By (or Acked-By)? I'm working towards getting rid of the whole thing. But until then, keeping it sorted is good. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 0/2] cpus: fix deadlock and segfault

2015-03-02 Thread Leon Alrae
On 27/02/2015 19:05, Paolo Bonzini wrote: > Reported by Leon Alrae on the mailing list, and by > Andreas Gustafsson as Launchpad bug 1426472. > > Paolo Bonzini (2): > cpus: fix deadlock and segfault in qemu_mutex_lock_iothread > cpus: be more paranoid in avoiding deadlocks I don't know this p

Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value

2015-03-02 Thread Markus Armbruster
"Fangyi (C)" writes: > PING Please drop this line, it doesn't belong to the commit message. You copied a bunch of people, but forgot the maintainer: $ scripts/get_maintainer.pl -f nbd.c Paolo Bonzini (odd fixer:Network Block Dev...) I fixed that for you. > The value of reply.error should b

Re: [Qemu-devel] [PATCH 0/2] RFC: Rolling statistics

2015-03-02 Thread Markus Armbruster
Copying qemu-block, because it could be of interest for block I/O accounting. "Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Hi, > This is an attempt at a generic rolling statistics utility to > allow data (e.g. bandwidth usage, times etc) to be collected > easily

Re: [Qemu-devel] [PATCH v3 03/10] acpi, mem-hotplug: Add acpi_send_gpe_event() to rise sci for memory hotplug.

2015-03-02 Thread Michael S. Tsirkin
On Mon, Mar 02, 2015 at 10:27:29AM +0100, Igor Mammedov wrote: > On Sun, 1 Mar 2015 18:29:39 +0100 > "Michael S. Tsirkin" wrote: > > > On Thu, Feb 26, 2015 at 09:16:45AM +0800, Zhu Guihua wrote: > > > From: Tang Chen > > > > > > Add a new API named acpi_send_gpe_event() to send memory hotplug S

Re: [Qemu-devel] [PATCH 2/2] docs: add memory-hotplug.txt

2015-03-02 Thread Paulo Ricardo Paz Vital
In addition to Eric's review. On Thu, 2015-02-26 at 14:49 -0500, Luiz Capitulino wrote: > This document describes how to use memory hotplug in QEMU. > > Signed-off-by: Luiz Capitulino > --- > docs/memory-hotplug.txt | 77 > + > 1 file changed, 77

Re: [Qemu-devel] [PATCH 1/2] Rolling statistics utilities

2015-03-02 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 02/27/2015 12:06 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > There are various places where it's useful to hold a series > > of values that change over time and get summaries about them. > > > > This provides: >

Re: [Qemu-devel] [PATCH RFC 0/5] Another patchset try to clean up around qerror_report_err()

2015-03-02 Thread Markus Armbruster
zhanghailiang writes: > Hi, > > I have noticed Markus's previous patchset > "Clean up around error_get_pretty(), qerror_report_err()". > > This is another patch series trying to do the same thing. > I'm not sure if he has missed this places or these modifies are false. > > So, please review...

Re: [Qemu-devel] [PATCH RFC 1/5] serial-pci: Avoid qerror_report_err() outside QMP command handlers

2015-03-02 Thread Markus Armbruster
zhanghailiang writes: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. Replace by error_report_err() in serial_pci_init() and > multi_serial_pci_init(). > > Signed-off-by: zhanghailiang > --- > hw/

Re: [Qemu-devel] [PATCH RFC v4 06/13] qapi: add dirty-bitmaps migration capability

2015-03-02 Thread Vladimir Sementsov-Ogievskiy
On 27.02.2015 21:29, Eric Blake wrote: On 02/27/2015 10:24 AM, Vladimir Sementsov-Ogievskiy wrote: Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/migration/migration.h | 1 + migration/migration.c | 9 + qapi-schema.json | 5

[Qemu-devel] [PULL 00/15] Misc changes for 2015-03-02

2015-03-02 Thread Paolo Bonzini
The following changes since commit 041ccc922ee474693a2869d4e3b59e920c739bc0: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2015-02-26 12:16:46 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch c

[Qemu-devel] [PULL 03/15] virtio-scsi-dataplane: Call blk_set_aio_context within BQL

2015-03-02 Thread Paolo Bonzini
From: Fam Zheng It's not safe to call blk_set_aio_context from outside BQL because of the bdrv_drain_all there. Let's put it in the hotplug callback which will be called by qdev device realization for each scsi device attached to the bus. Signed-off-by: Fam Zheng Message-Id: <1423969591-23646-3

[Qemu-devel] [PULL 02/15] block: Forbid bdrv_set_aio_context outside BQL

2015-03-02 Thread Paolo Bonzini
From: Fam Zheng Even if the caller has both the old and the new AioContext's, there can be a deadlock, due to the leading bdrv_drain_all. Suppose there are four io threads (A, B, A0, B0) with A and B owning a BDS for each (bs_a, bs_b); Now A wants to move bs_a to iothread A0, and B wants to move

[Qemu-devel] [PULL 06/15] Add specific config options for PCI-E bridges

2015-03-02 Thread Paolo Bonzini
From: David Gibson The i82801b11, ioh3420 and xio3130 PCI Express devices are currently included in the build unconditionally. While they could theoretically appear on any target platform with PCI-E, they're pretty unlikely to appear on platforms that aren't Intel derived. Therefore, to avoid p

[Qemu-devel] [PULL 05/15] bootdevice: fix segment fault when booting guest with '-kernel' and '-initrd'

2015-03-02 Thread Paolo Bonzini
From: Gonglei Reproducer: $./qemu-system-x86_64 --enable-kvm -kernel /home/vmlinuz-2.6.32.12-0.7-default \ -initrd /home/initrd-2.6.32.12-0.7-default -append \ "root=/dev/ram rw console=ttyS0,115200" -dtb guest.dtb -vnc :10 --monitor stdio -smp 2 QEMU 2.2.50 monitor - type 'help' for more

[Qemu-devel] [PULL 07/15] Create specific config option for "platform-bus"

2015-03-02 Thread Paolo Bonzini
From: David Gibson Currently the "platform-bus" device is included for all softmmu builds. This bridge is intended for use on any platforms that require dynamic creation of sysbus devices. However, at present it is used only for the PPC E500 target, with plans for the ARM "virt" target in the im

[Qemu-devel] [PULL 04/15] timer: replace time() with QEMU_CLOCK_HOST

2015-03-02 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch replaces time() function calls with calls to qemu_clock_get_ns(QEMU_CLOCK_HOST). It makes such requests deterministic in record/replay mode of icount. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Message-Id: <20150227131102.11912.89850.stgit@PASHA-

[Qemu-devel] [PULL 14/15] cpus: fix deadlock and segfault in qemu_mutex_lock_iothread

2015-03-02 Thread Paolo Bonzini
When two threads (other than the low-priority TCG VCPU thread) are competing for the iothread lock, a deadlock can happen. This is because iothread_requesting_mutex is set to false by the first thread that gets the mutex, and then the VCPU thread might never yield from the execution loop. If ioth

[Qemu-devel] [PULL 09/15] iscsi: Handle write protected case in reopen

2015-03-02 Thread Paolo Bonzini
From: Fam Zheng Save the write protected flag and check before reopen. Signed-off-by: Fam Zheng Message-Id: <1424839208-5195-1-git-send-email-f...@redhat.com> [Fixed typo in the name of the new field. - Paolo] Signed-off-by: Paolo Bonzini --- block/iscsi.c | 20 +++- 1 file ch

[Qemu-devel] [PULL 13/15] virtio-scsi: Allocate op blocker reason before blocking

2015-03-02 Thread Paolo Bonzini
From: Max Reitz s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is allocated and when it is freed. That does not make a whole lot of sense (and is actually wrong because this leads to s->blocker potentially be

[Qemu-devel] [PULL 15/15] cpus: be more paranoid in avoiding deadlocks

2015-03-02 Thread Paolo Bonzini
For good measure, ensure that the following sequence: thread 1 calls qemu_mutex_lock_iothread thread 2 calls qemu_mutex_lock_iothread VCPU thread are created VCPU thread enters execution loop results in the VCPU threads letting the other two threads run and obeying iothread_requesting

[Qemu-devel] [PULL 08/15] Give ivshmem its own config option

2015-03-02 Thread Paolo Bonzini
From: David Gibson Currently the ivshmem device is built whenever both PCI and KVM support are included. This patch gives it its own config option to allow easier customization of whether to include it. It's enabled by default in the same circumstances as now - when both PCI and KVM are availab

Re: [Qemu-devel] [PATCH RFC 3/5] pci-hotplug-old: Avoid qerror_report_err() outside QMP command handlers

2015-03-02 Thread Markus Armbruster
zhanghailiang writes: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. Replace by error_report_err() in qemu_pci_hot_add_nic(). > > Signed-off-by: zhanghailiang > --- > hw/pci/pci-hotplug-old.c | 3

[Qemu-devel] [PULL 12/15] Makefile.target: binary depends on config-devices

2015-03-02 Thread Paolo Bonzini
From: "Michael S. Tsirkin" relink binary whenever config-devices.mak changes: this makes sense as we are adding/removing devices, so binary has to be relinked to be up to date. Signed-off-by: Michael S. Tsirkin Message-Id: <1424332114-13440-2-git-send-email-...@redhat.com> Signed-off-by: Paolo

[Qemu-devel] [PULL 01/15] scsi: give device a parent before setting properties

2015-03-02 Thread Paolo Bonzini
This mimics what is done in qdev_device_add, and lets the device be freed in case something goes wrong. Otherwise, object_unparent returns immediately without freeing the device, which is on the other hand left in the parent bus's list of children. scsi_bus_legacy_handle_cmdline then returns an e

Re: [Qemu-devel] [PATCH RFC 2/5] qdev: Avoid qerror_report_err() outside QMP command handlers

2015-03-02 Thread Markus Armbruster
zhanghailiang writes: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. Replace by error_report_err() in qdev_init() and > device_post_init(). > > Signed-off-by: zhanghailiang > --- > hw/core/qdev.c

[Qemu-devel] [PULL 10/15] Makefile: fix up parallel building under MSYS+MinGW

2015-03-02 Thread Paolo Bonzini
From: Vasily Efimov This patch enables parallel building of QEMU in MSYS+MinGW environment. Currently an attempt to build QEMU in parallel fails on generation of version.lo (and version.o too). The cause of the failure is that when listing prerequisites "Makefile" references "config-host.h" by a

Re: [Qemu-devel] [PATCH RFC 4/5] pci-assign: Avoid qerror_report_err() outside QMP command handlers

2015-03-02 Thread Markus Armbruster
zhanghailiang writes: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. Replace by error_report_err() in assigned_initfn(). > > Signed-off-by: zhanghailiang > --- > hw/i386/kvm/pci-assign.c | 3 +--

[Qemu-devel] [PULL 11/15] Makefile: don't silence mak file test with V=1

2015-03-02 Thread Paolo Bonzini
From: "Michael S. Tsirkin" V=1 should show what's going on, it's not nice to silence things unconditionally. Signed-off-by: Michael S. Tsirkin Message-Id: <1424332114-13440-1-git-send-email-...@redhat.com> Signed-off-by: Paolo Bonzini --- Makefile | 6 +++--- scripts/make

Re: [Qemu-devel] [PATCH] Makefile.objs: add dummy rule for .dsl files

2015-03-02 Thread Paolo Bonzini
On 01/03/2015 17:50, Michael S. Tsirkin wrote: > Hmm, it turns out while this helps sometimes, > sometimes this results in a hard to debug error > as we try to run preprocessor on the non-existent .dsl. > > If not too late, I suggest you drop this one for now. > If too late, probably not worth r

Re: [Qemu-devel] [PATCH RFC 5/5] savevm: Replace error_report() & error_free() with error_report_err()

2015-03-02 Thread Markus Armbruster
zhanghailiang writes: > Signed-off-by: zhanghailiang > --- > savevm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/savevm.c b/savevm.c > index ce2b6a2..c4f8c39 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -932,8 +932,7 @@ int qemu_loadvm_state(QEMUFile *f) >

Re: [Qemu-devel] [PATCH v3] block/vdi: Add locking for parallel requests

2015-03-02 Thread Paolo Bonzini
On 27/02/2015 20:54, Max Reitz wrote: > When allocating a new cluster, the first write to it must be the one > doing the allocation, because that one pads its write request to the > cluster size; if another write to that cluster is executed before it, > that write will be overwritten due to the p

Re: [Qemu-devel] [PATCH 2/2] virtio_blk: fix comment for virtio 1.0

2015-03-02 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Fix up comment to match virtio 1.0 logic: > virtio_blk_outhdr isn't the first elements anymore, > the only requirement is that it comes first in > the s/g list. > > Signed-off-by: Michael S. Tsirkin Thanks, both applied. Cheers, Rusty.

Re: [Qemu-devel] [PATCH RFC v4 00/13] Dirty bitmaps migration

2015-03-02 Thread Vladimir Sementsov-Ogievskiy
On 27.02.2015 23:13, John Snow wrote: On 02/27/2015 12:24 PM, Vladimir Sementsov-Ogievskiy wrote: These patches provide dirty bitmap migration feature. Only named dirty bitmaps are to be migrated. Migration may be enabled using migration capabilities. v4 significant changes: 0001: tiny bugf

[Qemu-devel] [PULL v3 01/26] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-03-02 Thread Michael S. Tsirkin
From: "Denis V. Lunev" The idea is that all other virtio devices are calling this helper to merge properties of the proxy device. This is the only difference in between this helper and code in inside virtio_instance_init_common. The patch should not cause any harm as property list in generic ball

[Qemu-devel] [PULL v3 00/26] pci, pc, virtio fixes and cleanups

2015-03-02 Thread Michael S. Tsirkin
Hello, Peter! This should be the last big pull as we are entering hard freeze. This is an update of my previous pull request from http://mid.gmane.org/20150226165911.ga20...@redhat.com git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream_rebased as the tree was not rebased since

[Qemu-devel] [PULL v3 06/26] tpm: Support for capability flags of TIS 1.3

2015-03-02 Thread Michael S. Tsirkin
From: Stefan Berger Provide the TIS 1.3 capability flags. The interface now looks like a TIS 1.3 interface. It's fully compatible with previous TIS 1.2 and drivers written for TIS 1.2 continue to work. Signed-off-by: Stefan Berger Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL v3 10/26] pc: acpi: drop manual hole punching for GPE0 resources

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Drops manual hole punching in PCI0._CRS on PIIX4 machine type for GPE0 resources. Resources will be consumed by Device(GPE0) that is attached to PCI namespace. There is GPE device with HID ACPI0006 since ACPI2.0 that should be used for this purpose but none of Windows versions

[Qemu-devel] [PULL v3 09/26] pc: acpi: drop manual hole punching for CPU hotplug resources

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Drops manual hole punching in PCI0._CRS on PIIX4 machine type for CPU hotplug resources. Resources will be consumed by Device(PRES) that is attached to PCI bus. The same way how it currently works for mem hotlpug. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL v3 02/26] tpm: Extend sts register to 32 bit

2015-03-02 Thread Michael S. Tsirkin
From: Stefan Berger More recent TIS specs extend the STS register to 32 bit. While we don't store the TIS interface state, yet, we can extend it without sideeffects. Signed-off-by: Stefan Berger Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/tpm/tpm_tis.h | 2 +- 1 fil

[Qemu-devel] [PULL v3 08/26] pc: acpi: drop manual hole punching for PCI hotplug resources

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Drops manual hole punching in PCI0._CRS for PIIX4 machine type. Resources will be consumed by Device(PHPR) that cwis attached to PCI bus. The same way how it currently works for mem hotlpug. Manual hole in PIIX4 _CRS wasn't correct anyway since it was legacy size 0xF while cu

[Qemu-devel] [PULL v3 15/26] tests: ACPI test blobs update due to PCI0._CRS changes

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov PCI0._CRS was moved into SSDT and became the same for PIIX4/Q35 machines. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 3415 -> 2970 bytes tests/acpi-test-data/pc/SSDT | Bin 2374 ->

[Qemu-devel] [PULL v3 07/26] pc: acpi-build: create PCI0._CRS dynamically

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Replace template patching and runtime calculation in _CRS() method with static _CRS defined in SSDT. No functional change except of as mentined above and _CRS being moved from DSDT to SSDT. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

[Qemu-devel] [PULL v3 04/26] tpm: Support for XFIFO register

2015-03-02 Thread Michael S. Tsirkin
From: Stefan Berger Support for the XFIFO register (range) of the TIS 1.3 specification. We support a range of 64 bytes. Signed-off-by: Stefan Berger Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/tpm/tpm_tis.c | 4 1 file changed, 4 insertions(+) diff --git a/hw

[Qemu-devel] [PULL v3 11/26] pc: acpi-build: drop remaining ssdt_misc template

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov It drops empty ssdt_misc templete. It also hides from user almost all pointer arithmetic when building SSDT which makes resulting code a bit cleaner and concentrating only on composing ASL construct /i.e. a task build_ssdt() should be doing/. Also it makes one binary blob les

[Qemu-devel] [PULL v3 17/26] tests: add ACPI blobs for qemu with bridge cases

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/SSDT.bridge | Bin 0 -> 4352 bytes tests/acpi-test-data/q35/SSDT.bridge | Bin 0 -> 702 bytes 2 files changed, 0 insertions(+), 0 deletions(-) creat

[Qemu-devel] [PULL v3 13/26] pc: export applesmc IO port/len

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov IO port and length will be used in following patch to correctly generate SMC ACPI device in SSDT. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/isa/isa.h | 11 +-- hw/i386/acpi-build.c | 2 +- hw/mis

[Qemu-devel] [PULL v3 03/26] tpm: Allow 32 & 16 bit accesses to the registers

2015-03-02 Thread Michael S. Tsirkin
From: Stefan Berger Improve the access to the registers with 32 and 16 bit reads and writes. Also enable access to a non-base register address, such as reads of the 2nd byte of a register. Map the FIFO byte access to any byte within its 4 byte register (following specs). Signed-off-by: Stefan Be

[Qemu-devel] [PULL v3 14/26] pc: acpi-build: drop template patching and create Device(SMC) dynamically

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov patch moves SMC device into SSDT and creates it only when device is present, which makes ACPI tables smaller in default case when device is not present. Also it fixes wrong IO range in CRS if "iobase" property is set to a non default value. PS: Testing with XP shows that cur

[Qemu-devel] [PULL v3 20/26] pc: acpi-build: drop template patching and create PCI bus tree dynamically

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Replace AML template patching with direct composing of PCI device entries in C. It allows to simplify PCI tree generation further and saves us about 400LOC scattered through different files, confining tree generation to one C function which is much easier to deal with. Signed

[Qemu-devel] [PULL v3 23/26] pci: Give a few helpers internal linkage

2015-03-02 Thread Michael S. Tsirkin
From: Markus Armbruster None of them should be used in new code. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.h | 7 --- hw/pci/pci.c | 14 +++--- 2 files changed, 7 ins

[Qemu-devel] [PULL v3 05/26] tpm: Support for TIS selftest done flag

2015-03-02 Thread Michael S. Tsirkin
From: Stefan Berger Extend the backend to check whether the TPM_ContinueSelfTest finished successfully and provide a flag to the TIS front-end if it successfully finished. The TIS then sets a flag in all localities in the STS register and keeps it until the next reset. Signed-off-by: Stefan Berg

[Qemu-devel] [PULL v3 21/26] pc: acpi: remove not used anymore ssdt-[misc|pcihp].hex.generated blobs

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-misc.hex.generated | 139 -- hw/i386/ssdt-pcihp.hex.generated | 251 --- 2 files changed, 390 deletions(

Re: [Qemu-devel] [PATCH] disas/microblaze: Fix warnings caused by missing 'static' attribute

2015-03-02 Thread Michael Tokarev
01.03.2015 16:18, Stefan Weil wrote: > Warnings from the Sparse static analysis tool: [...] > @@ -738,7 +737,9 @@ get_field_special (long instr, struct op_code_struct * op) > default : > { > if ( instr & IMM_MASK) >> IMM_LOW) ^ op->immval_mask) & 0xE000) > == REG_PVR_MASK) {

[Qemu-devel] [PULL v3 12/26] acpi: add acpi_irq_no_flags() term

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/hw/acpi/aml-build.h b/incl

[Qemu-devel] [PULL v3 24/26] pci-hotplug-old: Has been dead for five major releases, bury

2015-03-02 Thread Michael S. Tsirkin
From: Markus Armbruster Commit 79ca616 (v1.6.0) accidentally disabled legacy x86-only HMP commands pci_add, pci_del: it defined CONFIG_PCI_HOTPLUG only as make variable, not as preprocessor macro, killing the code conditional on defined(CONFIG_PCI_HOTPLUG_OLD). In all this time, nobody reported

[Qemu-devel] [PULL v3 16/26] tests: bios-tables-test: add support for testing bridges

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Adds alternative ACPI table blob selection for testing non default QEMU configurations. If blob file for test variant is not present, fallback to default blob. With this change implement testing with a coldplugged bridge. Signed-off-by: Igor Mammedov Reviewed-by: Michael S.

[Qemu-devel] [PULL v3 18/26] pc: acpi-build: simplify PCI bus tree generation

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops unnecessary loops and bitmaps, creating devices and notification method in the same loop. * saves us ~100LOC Signed-off-by: Igor Mam

[Qemu-devel] [PULL v3 19/26] tests: ACPI: update pc/SSDT.bridge due to new alg of PCI tree creation

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/SSDT.bridge | Bin 4352 -> 4351 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/acpi-test-data/pc/SSDT.bridge b/tests/acpi-

[Qemu-devel] [PULL v3 22/26] acpi: make build_*() routines static to aml-build.c

2015-03-02 Thread Michael S. Tsirkin
From: Igor Mammedov build_*() routines were used for composing AML structures manually in acpi-build.c but after conversion to AML API they are not used outside of aml-build.c anymore, so hide them from external users. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PULL v3 25/26] acpi, mem-hotplug: use PC_DIMM_SLOT_PROP in acpi_memory_plug_cb().

2015-03-02 Thread Michael S. Tsirkin
From: Tang Chen Replace string "slot" in acpi_memory_plug_cb() with macro PC_DIMM_SLOT_PROP. Reviewed-by: Igor Mammedov Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/memory_hotplug.c | 3 ++- 1 file changed,

[Qemu-devel] [PULL v3 26/26] acpi-test-data: update after pci rewrite

2015-03-02 Thread Michael S. Tsirkin
more trivial changes as more code has been rewritten in C. we also got rid of extra Scope operators. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/SSDT | Bin 2480 -> 2476 bytes tests/acpi-test-data/pc/SSDT.bridge | Bin 4351 -> 4335 bytes tests/acpi-test-data/q35/SSDT

Re: [Qemu-devel] [PATCH] disas/microblaze: Fix warnings caused by missing 'static' attribute

2015-03-02 Thread Stefan Weil
Am 02.03.2015 um 12:04 schrieb Michael Tokarev: > 01.03.2015 16:18, Stefan Weil wrote: >> Warnings from the Sparse static analysis tool: > [...] >> @@ -738,7 +737,9 @@ get_field_special (long instr, struct op_code_struct * >> op) >> default : >> { >> if ( instr & IMM_MASK) >>

[Qemu-devel] [PATCH 0/4] block: Convert bdrv_find to blk_by_name and drop it

2015-03-02 Thread Fam Zheng
This is a small step towards a more complete separation from BlockDriverState to block backend users. Fam Zheng (4): monitor: Convert bdrv_find to blk_by_name migration: Convert bdrv_find to blk_by_name blockdev: Convert bdrv_find to blk_by_name block: Drop bdrv_find block.c

[Qemu-devel] [PATCH 2/4] migration: Convert bdrv_find to blk_by_name

2015-03-02 Thread Fam Zheng
Signed-off-by: Fam Zheng --- migration/block.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 0c76106..085c0fa 100644 --- a/migration/block.c +++ b/migration/block.c @@ -23,6 +23,7 @@ #include "migration/block.h" #include "

[Qemu-devel] [PATCH 1/4] monitor: Convert bdrv_find to blk_by_name

2015-03-02 Thread Fam Zheng
Signed-off-by: Fam Zheng --- monitor.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 41900da..6ad777d 100644 --- a/monitor.c +++ b/monitor.c @@ -72,6 +72,7 @@ #include "block/qapi.h" #include "qapi/qmp-event.h" #include "qapi-event.h"

[Qemu-devel] [PATCH 3/4] blockdev: Convert bdrv_find to blk_by_name

2015-03-02 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 92 -- 1 file changed, 59 insertions(+), 33 deletions(-) diff --git a/blockdev.c b/blockdev.c index ae73539..c70d849 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1017,18 +1017,18 @@ fail: void

[Qemu-devel] [PATCH 4/4] block: Drop bdrv_find

2015-03-02 Thread Fam Zheng
All callers are converted, so drop it. Signed-off-by: Fam Zheng --- block.c | 9 - include/block/block.h | 1 - 2 files changed, 10 deletions(-) diff --git a/block.c b/block.c index 9b707e3..742f82c 100644 --- a/block.c +++ b/block.c @@ -3780,15 +3780,6 @@ void bdrv_iterat

[Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

2015-03-02 Thread Michael S. Tsirkin
virtio 1.0 config space is in LE format for all devices, use modern wrappers when accessed through the 1.0 BAR. Reported-by: Rusty Russell Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virt

[Qemu-devel] [PATCH 1/2] virtio: add modern config accessors

2015-03-02 Thread Michael S. Tsirkin
virtio 1.0 defines config space as LE, as opposed to pre-1.0 which was native endian. Add API for transports to execute word/dword accesses in little endian format - will be useful for mmio and pci (byte access is also wrapped, for completeness). For simplicity, we still keep config in host nativ

Re: [Qemu-devel] Qemu and virtio 1.0

2015-03-02 Thread Michael S. Tsirkin
On Wed, Feb 25, 2015 at 02:50:22PM +1030, Rusty Russell wrote: > OK, I am trying to experiment with virtio 1.0 support using the > latest kernel and MST's qemu tree: > > https://git.kernel.org/cgit/virt/kvm/mst/qemu.git/?h=virtio-1.0 > > The first issue is that the device config endian wa

Re: [Qemu-devel] [PATCH 1/2] virtio: add modern config accessors

2015-03-02 Thread Cornelia Huck
On Mon, 2 Mar 2015 12:40:25 +0100 "Michael S. Tsirkin" wrote: > virtio 1.0 defines config space as LE, > as opposed to pre-1.0 which was native endian. > > Add API for transports to execute word/dword accesses in > little endian format - will be useful for mmio > and pci (byte access is also wra

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

2015-03-02 Thread Cornelia Huck
On Mon, 2 Mar 2015 12:40:28 +0100 "Michael S. Tsirkin" wrote: > virtio 1.0 config space is in LE format for all > devices, use modern wrappers when accessed through > the 1.0 BAR. > > Reported-by: Rusty Russell > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio/virtio-pci.c | 12 ++

Re: [Qemu-devel] Qemu and virtio 1.0

2015-03-02 Thread Cornelia Huck
On Mon, 2 Mar 2015 12:43:43 +0100 "Michael S. Tsirkin" wrote: > On Wed, Feb 25, 2015 at 02:50:22PM +1030, Rusty Russell wrote: > > OK, I am trying to experiment with virtio 1.0 support using the > > latest kernel and MST's qemu tree: > > > > https://git.kernel.org/cgit/virt/kvm/mst/qemu.

Re: [Qemu-devel] [PATCH 1/1] scsi-hd: fix property unset case

2015-03-02 Thread Markus Armbruster
Ekaterina Tumanova writes: > On 03/02/2015 11:46 AM, Markus Armbruster wrote: >> Ekaterina Tumanova writes: >> >>> check conf.blk before calling blkconf_blocksizes >>> >>> Signed-off-by: Ekaterina Tumanova >>> --- >>> hw/scsi/scsi-disk.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 delet

Re: [Qemu-devel] [PATCH 1/3] migration: Fix coding style (whitespace issues)

2015-03-02 Thread Michael Tokarev
28.02.2015 21:09, Stefan Weil wrote: > * Remove trailing whitespace (fixes 9 errors from checkpatch.pl). > One comment line was longer than 80 characters, so wrap it > and fix a typo, too. > * Replace tabs by blanks (fixes 1 error). This hunk: > @@ -2421,7 +2421,7 @@ static int qemu_rdma_dest

Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0

2015-03-02 Thread Michael S. Tsirkin
On Mon, Mar 02, 2015 at 12:56:55PM +0100, Cornelia Huck wrote: > On Mon, 2 Mar 2015 12:40:28 +0100 > "Michael S. Tsirkin" wrote: > > > virtio 1.0 config space is in LE format for all > > devices, use modern wrappers when accessed through > > the 1.0 BAR. > > > > Reported-by: Rusty Russell > > S

Re: [Qemu-devel] [PATCH] vhost_net: Add missing 'static' attribute

2015-03-02 Thread Michael Tokarev
Applied to trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] oslib-posix: Fix compiler warning (-Wclobbered) and simplify the code

2015-03-02 Thread Michael Tokarev
Applied to trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] disas/cris: Fix warning caused by missing 'static' attribute

2015-03-02 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] disas/arm: Fix warnings caused by missing 'static' attribute

2015-03-02 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] disas/microblaze: Fix warnings caused by missing 'static' attribute

2015-03-02 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

[Qemu-devel] [PATCH] gdbstub: avoid possible NULL pointer dereference

2015-03-02 Thread Paolo Bonzini
Coverity reports that s->chr is checked after put_packet dereferences it. Move the check earlier, consistent with the code used for user-mode emulation. Signed-off-by: Paolo Bonzini --- gdbstub.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c in

Re: [Qemu-devel] [RFC 01/10] target-arm: protect cpu_exclusive_*.

2015-03-02 Thread Peter Maydell
On 27 February 2015 at 16:54, Mark Burton wrote: > >> On 26 Feb 2015, at 23:56, Peter Maydell wrote: >> cpu_physical_memory_rw would bypass the TLB and so be much slower. >> Make sure you use the functions which go via the TLB if you do >> this in a helper (and remember that they will longjmp out

Re: [Qemu-devel] [RfC PATCH 03/15] virtio-pci: make pci bars configurable

2015-03-02 Thread Michael S. Tsirkin
On Mon, Feb 23, 2015 at 11:23:19AM +0100, Gerd Hoffmann wrote: > Add msix_bar and modern_mem_bar fields to VirtIOPCIProxy. They can be > used to configure which pci regions are used for the virtio 1.0 memory > bar and the msix bar. > > For legacy/transitional devices the legacy bar is region 0 an

  1   2   3   4   >