Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-25 Thread Wen Congyang
On 02/12/2015 04:44 PM, Fam Zheng wrote: > On Thu, 02/12 15:40, Wen Congyang wrote: >> On 02/12/2015 03:21 PM, Fam Zheng wrote: >>> Hi Congyang, >>> >>> On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following is the image of block replication workflow: + +

[Qemu-devel] net devices

2015-02-25 Thread Vasile Catalin-B50542
I'm looking through the qemu sources and I'm trying to understand how net devices work. What is considered a net_client inside qemu sources? I'm asking about this because I came upon two functions which (because of their name) sound like they should be doing the same thing. The functions' name

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-25 Thread Fam Zheng
On Wed, 02/25 16:11, Wen Congyang wrote: > > > >{virtio-blk dev 'foo'} > > | > > | > > | > > [base] <- [mid] <- (foo) > > foo's backing is mid, and mid's backing is base? Yes. Fam

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-25 Thread zhanghailiang
On 2015/2/25 1:24, Daniel P. Berrange wrote: On Tue, Feb 24, 2015 at 09:30:56AM -0700, Eric Blake wrote: On 02/24/2015 02:50 AM, Wen Congyang wrote: Script files are in general very hard to secure. Libvirt marks any domain that uses a script file for controlling networking as tainted, because

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-25 Thread Wen Congyang
On 02/25/2015 10:46 AM, Fam Zheng wrote: > On Tue, 02/24 15:50, Wen Congyang wrote: >> On 02/12/2015 04:44 PM, Fam Zheng wrote: >>> On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: > Hi Congyang, > > On Thu, 02/12 11:07, Wen Congyang wrote: >> +

Re: [Qemu-devel] [PATCH 29/43] linux-user: Fix broken m68k signal handling on 64 bit hosts

2015-02-25 Thread Laurent Vivier
Hi, I think you should use abi_long instead of uint32_t. abi_long has an "aligned" attribute, and on m68k long are aligned on a short boundary. #ifdef TARGET_M68K #define ABI_INT_ALIGNMENT 2 #define ABI_LONG_ALIGNMENT 2 #define ABI_LLONG_ALIGNMENT 2 #endif typedef uint32_t abi_ulong __attr

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

2015-02-25 Thread Igor Mammedov
On Tue, 24 Feb 2015 15:19:28 -0300 Eduardo Habkost wrote: > On Tue, Feb 24, 2015 at 09:01:04AM +0100, Igor Mammedov wrote: > > On Thu, 12 Feb 2015 15:50:35 -0200 > > Eduardo Habkost wrote: > > > > > Instead of silently assigning CPU to node 0 when it is omitted from the > > > command-line, chec

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-25 Thread Fam Zheng
On Wed, 02/25 16:36, Wen Congyang wrote: > On 02/25/2015 10:46 AM, Fam Zheng wrote: > > On Tue, 02/24 15:50, Wen Congyang wrote: > >> On 02/12/2015 04:44 PM, Fam Zheng wrote: > >>> On Thu, 02/12 15:40, Wen Congyang wrote: > On 02/12/2015 03:21 PM, Fam Zheng wrote: > > Hi Congyang, > >

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-25 Thread Wen Congyang
On 02/12/2015 04:44 PM, Fam Zheng wrote: > On Thu, 02/12 15:40, Wen Congyang wrote: >> On 02/12/2015 03:21 PM, Fam Zheng wrote: >>> Hi Congyang, >>> >>> On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following is the image of block replication workflow: + +

Re: [Qemu-devel] [RFC PATCH 2/2] qga: add --getenv option to get env. vars from fw_cfg

2015-02-25 Thread Daniel P. Berrange
On Tue, Feb 24, 2015 at 02:43:07PM -0500, Gabriel L. Somlo wrote: > The new "-g" (or "--getenv") command line option causes qemu-ga to extract > and parse the "etc/guestenv" blob from fw_cfg, and return the value of > the requested key (if available) on stdout. > > Warnings and error messages are

Re: [Qemu-devel] [PATCH RFC v3 19/27] COLO NIC: Implement colo nic device interface configure()

2015-02-25 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/2/16 20:03, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>Implement colo nic device interface configure() > >>add a script to configure nic devices: > >>${QEMU_SCRIPT_DIR}/colo-proxy-scr

Re: [Qemu-devel] [PATCH RFC v3 02/27] migration: Introduce capability 'colo' to migration

2015-02-25 Thread zhanghailiang
On 2015/2/17 5:57, Eric Blake wrote: On 02/11/2015 08:16 PM, zhanghailiang wrote: This capability allows Primary VM (PVM) to be continuously checkpointed to secondary VM. Signed-off-by: zhanghailiang Signed-off-by: Yang Hongyang Signed-off-by: Gonglei Signed-off-by: Lai Jiangshan --- incl

Re: [Qemu-devel] [PATCH 1/3] PPC: Clean up misuse of qdev_init() in kvm-openpic creation

2015-02-25 Thread Markus Armbruster
Scott Wood writes: > On Wed, 2015-02-18 at 15:43 +0100, Markus Armbruster wrote: >> Scott, can you review? >> >> Markus Armbruster writes: >> >> > We call ppce500_init_mpic_kvm() to create a "kvm-openpic". If it >> > fails, we call ppce500_init_mpic_qemu() to fall back to plain >> > "openpic"

Re: [Qemu-devel] Patch Round-up for stable 2.2.1, freeze on 2015-03-05

2015-02-25 Thread Leon Alrae
Hi Michael, On 24/02/2015 21:47, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.2.1: > > https://github.com/mdroth/qemu/commits/stable-2.2-staging > > The release is planned for 2015-03-10: > > http://wiki.qemu.org/Planning/2.2 > > Please re

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-25 Thread Markus Armbruster
Liu Yuan writes: > On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: >> Liu Yuan writes: >> >> > From: Liu Yuan >> > >> > These functions mix up -1 and -errno in return values and would might cause >> > trouble error handling in the call chain. >> > >> > This patch let them re

Re: [Qemu-devel] [PATCH RFC v3 19/27] COLO NIC: Implement colo nic device interface configure()

2015-02-25 Thread zhanghailiang
On 2015/2/25 17:08, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/2/16 20:03, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: Implement colo nic device interface configure() add a script to configure nic devi

[Qemu-devel] [PATCH] [POWERPC] display cpu id dump state

2015-02-25 Thread Fabien Chouteau
From: Tristan Gingold Signed-off-by: Fabien Chouteau --- target-ppc/translate.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 88c18e3..2a78e99 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@

Re: [Qemu-devel] [PATCH RFC v3 19/27] COLO NIC: Implement colo nic device interface configure()

2015-02-25 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/2/25 17:08, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>On 2015/2/16 20:03, Dr. David Alan Gilbert wrote: > >>>* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Implement c

Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-02-25 Thread Stefan Hajnoczi
On Mon, Jan 12, 2015 at 01:12:41AM +0800, Yi Wang wrote: > From b119164ba6715f53594facfc4d1022c198852e9d Mon Sep 17 00:00:00 2001 > From: Yi Wang > Date: Mon, 12 Jan 2015 00:05:40 +0800 > Subject: [PATCH] savevm: create snapshot failed when id_str already exits > > Create snapshot failed in this

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-25 Thread Fam Zheng
On Wed, 02/25 17:10, Wen Congyang wrote: > On 02/12/2015 04:44 PM, Fam Zheng wrote: > > On Thu, 02/12 15:40, Wen Congyang wrote: > >> On 02/12/2015 03:21 PM, Fam Zheng wrote: > >>> Hi Congyang, > >>> > >>> On Thu, 02/12 11:07, Wen Congyang wrote: > +== Workflow == > +The following is the

[Qemu-devel] [PATCH] Openpic: check that cpu id is within the number of cpus

2015-02-25 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- hw/intc/openpic.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c index 7d1f3b9..305377d 100644 --- a/hw/intc/openpic.c +++ b/hw/intc/openpic.c @@ -1013,7 +1013,7 @@ static void openpic_cpu_write_

Re: [Qemu-devel] [PATCH v5 3/4] arm: Add PCIe host bridge in virt machine

2015-02-25 Thread Alexander Graf
On 24.02.15 16:09, Peter Maydell wrote: > On 7 February 2015 at 02:04, Alexander Graf wrote: >> typedef struct MemMapEntry { >> @@ -129,13 +131,21 @@ static const MemMapEntry a15memmap[] = { >> [VIRT_FW_CFG] = { 0x0902, 0x000a }, >> [VIRT_MMIO] = { 0x0a00, 0x

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-25 Thread Wen Congyang
On 02/25/2015 04:58 PM, Fam Zheng wrote: > On Wed, 02/25 16:36, Wen Congyang wrote: >> On 02/25/2015 10:46 AM, Fam Zheng wrote: >>> On Tue, 02/24 15:50, Wen Congyang wrote: On 02/12/2015 04:44 PM, Fam Zheng wrote: > On Thu, 02/12 15:40, Wen Congyang wrote: >> On 02/12/2015 03:21 PM, Fa

Re: [Qemu-devel] [PATCH v4 00/10] cpu: add device_add foo-x86_64-cpu support

2015-02-25 Thread Chen Fan
Hi Andreas, On 02/25/2015 12:56 AM, Andreas Färber wrote: Hi Gu, Am 24.02.2015 um 02:25 schrieb Gu Zheng: The issues you commented in the previous version have been fixed in this one. What I have repeatedly rejected is "device_add foo-x86_64-cpu". This is still in 00/10 and 09/10. Most of the

Re: [Qemu-devel] [PATCH v4 0/5] libqos: Virtio MMIO driver

2015-02-25 Thread Stefan Hajnoczi
On Tue, Feb 24, 2015 at 09:39:22PM +0100, Marc Marí wrote: > El Thu, 19 Feb 2015 18:46:44 +0100 > Kevin Wolf escribió: > > Am 18.02.2015 um 18:07 hat Stefan Hajnoczi geschrieben: > > > On Fri, Jan 23, 2015 at 05:38:48PM +0100, Marc Marí wrote: > > > > Add virtio-mmio support to libqos and test cas

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

2015-02-25 Thread Daniel P. Berrange
On Wed, Feb 25, 2015 at 04:21:15PM +0800, zhanghailiang wrote: > On 2015/2/25 1:24, Daniel P. Berrange wrote: > >On Tue, Feb 24, 2015 at 09:30:56AM -0700, Eric Blake wrote: > >>On 02/24/2015 02:50 AM, Wen Congyang wrote: > Script files are in general very hard to secure. Libvirt marks any > >>

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

2015-02-25 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 02/24/2015 12:59 AM, Markus Armbruster wrote: >> Alexey Kardashevskiy writes: >> >>> This adds a helper to get closest bigger power-of-two value. >>> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> Changes: >>> v2: >>> * s/up_pow_of_two/pow2ceil/ >>> --- >>

Re: [Qemu-devel] [PATCH v5 4/5] libqos: Add malloc generic

2015-02-25 Thread Stefan Hajnoczi
On Tue, Feb 24, 2015 at 10:21:54PM +0100, Marc Marí wrote: > This malloc is a basic interface implementation that works for any platform. > It should be replaced in the future for a real malloc implementation for each > of the platforms. > > Signed-off-by: Marc Marí > --- > tests/libqos/malloc-g

Re: [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo

2015-02-25 Thread Alberto Garcia
On Tue, Feb 24, 2015 at 09:54:13AM -0700, Eric Blake wrote: > Questions - with this series in place, is it ever possible to have > throttling parameters without a throttle group name? Yes, and it will work the same as before. If the throttling parameters are set but no group name is specified the

Re: [Qemu-devel] [PULL 00/21] SCSI, RCU, KVM changes for 2015-02-16

2015-02-25 Thread Peter Maydell
On 17 February 2015 at 03:17, Paolo Bonzini wrote: > The following changes since commit bc5baffa3554e4c0d20c1dbe879aec931866bd69: > > vfio: Fix debug message compile error (2015-02-10 10:25:44 -0700) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-ups

Re: [Qemu-devel] [PATCH v5 0/5] libqos: Virtio MMIO driver

2015-02-25 Thread Stefan Hajnoczi
On Tue, Feb 24, 2015 at 10:21:50PM +0100, Marc Marí wrote: > Add virtio-mmio support to libqos and test case for virtio-blk. > > Changes for version 3: > - Fix leaks and minor bugs > - Extract basic test case to a function > > Changes for version 4: > - Add format=raw to images, to avoid warni

Re: [Qemu-devel] [RESEND PATCH v1 11/13] pc-dimm: Add memory hot unplug support for pc-dimm.

2015-02-25 Thread Zhu Guihua
On 01/29/2015 09:34 PM, Igor Mammedov wrote: On Thu, 8 Jan 2015 09:06:18 +0800 Tang Chen wrote: Implement unplug cb for pc-dimm. It remove the corresponding memory region, and unregister vmstat. At last, it calls memory unplug cb to reset memory status and do unparenting. --- hw/i386/pc.c |

Re: [Qemu-devel] Qemu and virtio 1.0

2015-02-25 Thread Cornelia Huck
On Wed, 25 Feb 2015 14:50:22 +1030 Rusty Russell wrote: > OK, I am trying to experiment with virtio 1.0 support using the > latest kernel and MST's qemu tree: > > https://git.kernel.org/cgit/virt/kvm/mst/qemu.git/?h=virtio-1.0 > > The first issue is that the device config endian was wro

Re: [Qemu-devel] [PATCH 29/43] linux-user: Fix broken m68k signal handling on 64 bit hosts

2015-02-25 Thread Peter Maydell
On 25 February 2015 at 17:39, Laurent Vivier wrote: > Hi, > > I think you should use abi_long instead of uint32_t. > > abi_long has an "aligned" attribute, and on m68k long are aligned on a short > boundary. > > > #ifdef TARGET_M68K > #define ABI_INT_ALIGNMENT 2 > #define ABI_LONG_ALIGNMENT 2 > #

Re: [Qemu-devel] [PATCH v5 3/4] arm: Add PCIe host bridge in virt machine

2015-02-25 Thread Peter Maydell
On 25 February 2015 at 18:52, Alexander Graf wrote: > > > On 24.02.15 16:09, Peter Maydell wrote: >> On 7 February 2015 at 02:04, Alexander Graf wrote: >>> typedef struct MemMapEntry { >>> @@ -129,13 +131,21 @@ static const MemMapEntry a15memmap[] = { >>> [VIRT_FW_CFG] = { 0x0902, 0

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: add myself as SPARC maintainer

2015-02-25 Thread Peter Maydell
On 14 February 2015 at 18:32, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > CC: Peter Maydell > --- > MAINTAINERS |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8c06739..7ef4879 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -

Re: [Qemu-devel] [PULL v2 00/10] Fixes and new commands for QEMU Guest Agent

2015-02-25 Thread Peter Maydell
On 18 February 2015 at 07:40, Michael Roth wrote: > The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into > staging (2015-02-13 11:44:50 +) > > are available in the git repository at: > > > g

Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-02-25 Thread Marcel Apfelbaum
On 02/04/2015 05:43 PM, Marcel Apfelbaum wrote: Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This results in a Qemu crash if a non string option is queried using qemu

Re: [Qemu-devel] [PATCH 29/43] linux-user: Fix broken m68k signal handling on 64 bit hosts

2015-02-25 Thread Laurent Vivier
> Le 25 février 2015 à 12:28, Peter Maydell a écrit : > > > On 25 February 2015 at 17:39, Laurent Vivier wrote: > > Hi, > > > > I think you should use abi_long instead of uint32_t. > > > > abi_long has an "aligned" attribute, and on m68k long are aligned on a short > > boundary. > > > > > > #ifd

Re: [Qemu-devel] QEMU pci mach-virt: setting PCI_INTERRUPT_LINE?

2015-02-25 Thread Claudio Fontana
On 24.02.2015 15:34, Claudio Fontana wrote: > Hello, > > I am trying to set the pci interrupt line field in the configuration space > (offset 0x3c), since it is initialized as zero. > > I would like to set it to the right value as read from the device tree, > in order for other existing softwar

Re: [Qemu-devel] QEMU pci mach-virt: setting PCI_INTERRUPT_LINE?

2015-02-25 Thread Alexander Graf
On 25.02.15 13:07, Claudio Fontana wrote: > > > On 24.02.2015 15:34, Claudio Fontana wrote: >> Hello, >> >> I am trying to set the pci interrupt line field in the configuration space >> (offset 0x3c), since it is initialized as zero. >> >> I would like to set it to the right value as read from

Re: [Qemu-devel] [PATCH 29/43] linux-user: Fix broken m68k signal handling on 64 bit hosts

2015-02-25 Thread Peter Maydell
On 25 February 2015 at 20:58, Laurent Vivier wrote: > >> Le 25 février 2015 à 12:28, Peter Maydell a >> écrit : >> >> >> On 25 February 2015 at 17:39, Laurent Vivier wrote: >> > Hi, >> > >> > I think you should use abi_long instead of uint32_t. >> > >> > abi_long has an "aligned" attribute, and

Re: [Qemu-devel] QEMU pci mach-virt: setting PCI_INTERRUPT_LINE?

2015-02-25 Thread Claudio Fontana
On 25.02.2015 13:08, Alexander Graf wrote: > > > On 25.02.15 13:07, Claudio Fontana wrote: >> >> >> On 24.02.2015 15:34, Claudio Fontana wrote: >>> Hello, >>> >>> I am trying to set the pci interrupt line field in the configuration space >>> (offset 0x3c), since it is initialized as zero. >>> >>>

Re: [Qemu-devel] [RESEND PATCH v1 11/13] pc-dimm: Add memory hot unplug support for pc-dimm.

2015-02-25 Thread Igor Mammedov
On Wed, 25 Feb 2015 19:21:43 +0800 Zhu Guihua wrote: > > On 01/29/2015 09:34 PM, Igor Mammedov wrote: > > On Thu, 8 Jan 2015 09:06:18 +0800 > > Tang Chen wrote: > > > >> Implement unplug cb for pc-dimm. It remove the corresponding > >> memory region, and unregister vmstat. At last, it calls mem

Re: [Qemu-devel] [PULL 0/8] usb: error handling fixes from Markus, make sysbus ehci arm-only.

2015-02-25 Thread Peter Maydell
On 18 February 2015 at 19:08, Gerd Hoffmann wrote: > Hi, > > Here comes the usb patch queue, with error handling fixes from Markus > and David's patch to make sysbus-ehci arm-only. > > please pull, > Gerd > > The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: > > Me

Re: [Qemu-devel] net devices

2015-02-25 Thread Stefan Hajnoczi
On Wed, Feb 25, 2015 at 09:54:40AM +0200, Vasile Catalin-B50542 wrote: > I'm looking through the qemu sources and I'm trying to understand how net > devices work. > What is considered a net_client inside qemu sources? > I'm asking about this because I came upon two functions which (because of > the

Re: [Qemu-devel] [PATCH v3 01/11] iotests: Move _filter_nbd into common.filter

2015-02-25 Thread Max Reitz
On 2015-02-25 at 01:46, Fam Zheng wrote: On Tue, 02/24 10:35, Max Reitz wrote: _filter_nbd can be useful for other NBD tests, too, therefore it should reside in common.filter, and it should support URLs of the "nbd://" format and export names. The NBD log lines ("/your/source/dir/nbd.c:function

Re: [Qemu-devel] [PATCH v3 02/11] iotests: Do not redirect qemu's stderr

2015-02-25 Thread Max Reitz
On 2015-02-25 at 02:04, Fam Zheng wrote: On Tue, 02/24 10:35, Max Reitz wrote: Redirecting qemu's stderr to stdout makes working with the stderr output difficult due to the other file descriptor magic performed in _launch_qemu ("ambiguous redirect"). There is no harm in leaving stderr on stderr

[Qemu-devel] [PATCH 2/2] xbzrle: Drop unused cache_resize()

2015-02-25 Thread Markus Armbruster
Unused since commit fd8cec XBZRLE: Fix qemu crash when resize the xbzrle cache. Signed-off-by: Markus Armbruster --- include/migration/page_cache.h | 11 - page_cache.c | 56 -- 2 files changed, 67 deletions(-) diff --git a/inclu

[Qemu-devel] [PATCH 0/2] Proactive pow2floor() fix, and dead code removal

2015-02-25 Thread Markus Armbruster
I propose to route this through the migration tree, because that's where pow2floor() came from, and where the dead code is removed. Markus Armbruster (2): cutils: Proactively fix pow2floor(), switch to unsigned xbzrle: Drop unused cache_resize() include/migration/page_cache.h | 11 -

[Qemu-devel] [PATCH 1/2] cutils: Proactively fix pow2floor(), switch to unsigned

2015-02-25 Thread Markus Armbruster
The function's stated contract is simple enough: "round down to the nearest power of 2". Suggests the domain is the representable numbers >= 1, because that's the smallest power of two. The implementation doesn't check for domain errors, but returns garbage instead: * For negative arguments, pow

Re: [Qemu-devel] [PATCH v3 05/11] block: Move BDS close notifiers into BB

2015-02-25 Thread Max Reitz
On 2015-02-25 at 02:52, Fam Zheng wrote: On Tue, 02/24 10:35, Max Reitz wrote: The only remaining user of the BDS close notifiers is NBD which uses them to determine when a BDS tree is being ejected. This patch removes the BDS-level close notifiers and adds a notifier list to the BlockBackend st

Re: [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later

2015-02-25 Thread Max Reitz
On 2015-02-24 at 21:23, Wen Congyang wrote: On 02/24/2015 05:31 AM, Max Reitz wrote: On 2015-02-11 at 22:07, Wen Congyang wrote: The secondary qemu starts later than the primary qemu, so we cannot connect to nbd server in bdrv_open(). Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v9] Support vhd type VHD_DIFFERENCING

2015-02-25 Thread Stefan Hajnoczi
On Sun, Feb 15, 2015 at 09:35:49PM +0800, Xiaodong Gong wrote: > Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu > can't read snapshot volume of vhd, and can't support other storage > features of vhd file. > > This patch add read parent information in function "vpc_open", read >

[Qemu-devel] [PATCH 5/6] target-tricore: Add instructions of RRRW opcode format

2015-02-25 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 5108ab0..dc89bdf 100644 --- a/target-tricore/translate.c +++ b/target-

[Qemu-devel] [PATCH 1/6] target-tricore: Add instructions of RRR1 opcode format, which have 0xa3 as first opcode

2015-02-25 Thread Bastian Koppelmann
Add helpers: * sub64_ssov: subs two 64 bit values and saturates the result. * subr_h/_ssov: subs two halfwords from two words in q-format with rounding / and saturates each result independetly. Add microcode generator: * gen_sub64_d: adds two 64 bit values. * ge

[Qemu-devel] [PATCH 0/6] TriCore: add RRR1, RRRR, RRRW, SYS instructions

2015-02-25 Thread Bastian Koppelmann
Hi, this should be the last major bit of the TriCore integer instructions. The floating point ones are a whole different story. These patches depend on my other TriCore patches (https://patchwork.ozlabs.org/patch/438866/) and add the promised mac instructions for subtract. Note here that msub.

[Qemu-devel] [PATCH v5 07/45] Return path: Open a return path on QEMUFile for sockets

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Postcopy needs a method to send messages from the destination back to the source, this is the 'return path'. Wire it up for 'socket' QEMUFile's using a dup'd fd. Signed-off-by: Dr. David Alan Gilbert --- include/migration/qemu-file.h | 7 + migration/qemu-

[Qemu-devel] [PATCH v5 05/45] Create MigrationIncomingState

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" There are currently lots of pieces of incoming migration state scattered around, and postcopy is adding more, and it seems better to try and keep it together. allocate MIS in process_incoming_migration_co Signed-off-by: Dr. David Alan Gilbert --- include/migrati

[Qemu-devel] [PATCH v5 11/45] Return path: Send responses from destination to source

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add migrate_send_rp_message to send a message from destination to source along the return path. (It uses a mutex to let it be called from multiple threads) Add migrate_send_rp_shut to send a 'shut' message to indicate the destination is finished with the RP. Ad

[Qemu-devel] [PATCH v5 16/45] Add migration-capability boolean for postcopy-ram.

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake --- include/migration/migration.h | 1 + migration/migration.c | 9 + qapi-schema.json | 7 ++- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/include/m

[Qemu-devel] [PATCH v5 09/45] Migration commands

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Create QEMU_VM_COMMAND section type for sending commands from source to destination. These commands are not intended to convey guest state but to control the migration process. For use in postcopy. Signed-off-by: Dr. David Alan Gilbert --- include/migration/mig

[Qemu-devel] [PATCH v5 20/45] Modify savevm handlers for postcopy

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Modify save_live_pending to return separate postcopiable and non-postcopiable counts. Add 'can_postcopy' to allow a device to state if it can postcopy Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 15 +-- include/migration/v

[Qemu-devel] [PATCH v5 22/45] postcopy: OS support test

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Provide a check to see if the OS we're running on has all the bits needed for postcopy. Creates postcopy-ram.c which will get most of the other helpers we need. Signed-off-by: Dr. David Alan Gilbert --- include/migration/postcopy-ram.h | 19 + migration/Mak

[Qemu-devel] [PATCH v5 10/45] Return path: Control commands

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add two src->dest commands: * OPEN_RETURN_PATH - To request that the destination open the return path * SEND_PING - Request an acknowledge from the destination Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 2 ++ include/sysemu/s

[Qemu-devel] [PATCH v5 23/45] migrate_start_postcopy: Command to trigger transition to postcopy

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Once postcopy is enabled (with migrate_set_capability), the migration will still start on precopy mode. To cause a transition into postcopy the: migrate_start_postcopy command must be issued. Postcopy will start sometime after this (when it's next checked in t

[Qemu-devel] [PATCH v5 15/45] Rework loadvm path for subloops

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Postcopy needs to have two migration streams loading concurrently; one from memory (with the device state) and the other from the fd with the memory transactions. Split the core of qemu_loadvm_state out so we can use it for both. Allow the inner loadvm loop to qui

[Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Rework the migration thread to setup and start postcopy. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 3 + migration/migration.c | 161 -- trace-events | 4 ++ 3 fil

[Qemu-devel] [PATCH v5 25/45] qemu_savevm_state_complete: Postcopy changes

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When postcopy calls qemu_savevm_state_complete it's not really the end of migration, so skip: a) Finishing postcopiable iterative devices - they'll carry on b) The termination byte on the end of the stream. We then also add: qemu_savevm_state_postcopy_compl

[Qemu-devel] [PATCH v5 41/45] Start up a postcopy/listener thread ready for incoming page data

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The loading of a device state (during postcopy) may access guest memory that's still on the source machine and thus might need a page fill; split off a separate thread that handles the incoming page data so that the original incoming migration code can finish off th

[Qemu-devel] [PATCH v5 44/45] Disable mlock around incoming postcopy

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Userfault doesn't work with mlock; mlock is designed to nail down pages so they don't move, userfault is designed to tell you when they're not there. munlock the pages we userfault protect before postcopy. mlock everything again at the end if mlock is enabled. Sig

[Qemu-devel] R: Re: [Bug 1423124] [NEW] QEMU crash after sending data on host serial port

2015-02-25 Thread Ugo
Hello Stefan, the crash can be described better as a neverending loop started after having received data on serial ports, infact for going out I'm forced to kill the QEMU session from Windows. As result there is unfortunately no system dump in the Windows dump folder. I've tried to generate th

[Qemu-devel] [RFC 1/3] qtest: allow arbitrarily long sends

2015-02-25 Thread John Snow
qtest currently has a static buffer of size 1024 that if we overflow, ignores the additional data silently which leads to hangs or stream failures. Use glib's string facilities to allow arbitrarily long data. Signed-off-by: John Snow --- qtest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[Qemu-devel] [PATCH 17/25] nbd: Employ timeouts

2015-02-25 Thread Max Reitz
Signed-off-by: Max Reitz --- block/nbd-client.c | 35 +++ include/block/nbd.h | 2 ++ nbd.c | 12 ++-- 3 files changed, 43 insertions(+), 6 deletions(-) diff --git a/block/nbd-client.c b/block/nbd-client.c index e1bb919..be6803d 100644 ---

[Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-25 Thread Eduardo Habkost
This was the only caller of cpu_init() that was not checking for NULL yet. Reviewed-by: Paolo Bonzini Signed-off-by: Eduardo Habkost --- linux-user/main.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index d92702a..111c1ff 100

[Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test

2015-02-25 Thread John Snow
This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. mkimg and mkqcow2 are added to libqos for other tests. Signed-off-by: John Snow --- tests/Makefile| 1 + tests/ahci-test.c | 16 ++-- tests/libqos/l

[Qemu-devel] [PATCH v2 1/8] libqos/ahci: Zero-fill AHCI headers

2015-02-25 Thread John Snow
Even though it's just the reserved space, make sure they're zeroes. Signed-off-by: John Snow --- tests/libqos/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index a6105c7..9dc505c 100644 --- a/tests/libqos/ahci.c +++ b/tests/l

[Qemu-devel] [PATCH v2 0/8] ahci: add more IO tests

2015-02-25 Thread John Snow
This series is based on top of my ahci DMA test series, which is in turn based on the ahci preliminary refactoring series. Both are currently pending on stefanha/block. This series adds many variations that expand on the existing trivial DMA I/O case. These pathways check different PRDT configurat

[Qemu-devel] [PATCH v2 6/8] qtest/ahci: add fragmented dma test

2015-02-25 Thread John Snow
Test what happens when we try to use extremely short PRDTs to accomplish a small data transfer. Signed-off-by: John Snow --- tests/ahci-test.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index

[Qemu-devel] [PATCH v2] Fix crash when connecting to VNC through websocket

2015-02-25 Thread Jorge Acereda Maciá
Connecting to VNC through websocket crashes in vnc_flush() when trying to acquire a mutex that hasn't been initialized (vnc_init_state(vs) hasn't been called at this point). Signed-off-by: Jorge Acereda Macia --- ui/vnc-ws.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-25 Thread Peter Maydell
On 26 February 2015 at 04:58, Eduardo Habkost wrote: > This was the only caller of cpu_init() that was not checking for NULL > yet. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Eduardo Habkost > --- > linux-user/main.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PATCH 1/6] target-arm: kvm: save/restore mp state

2015-02-25 Thread Peter Maydell
On 26 February 2015 at 01:02, Alex Bennée wrote: > This adds the saving and restore of the current Multi-Processing state > of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of > potential states for x86 we only use two for ARM. Either the process is > running or not. By this yo

Re: [Qemu-devel] [RFC PATCH 0/2] host->guest environment variables via fw_cfg

2015-02-25 Thread Gabriel L. Somlo
On Wed, Feb 25, 2015 at 10:40:34PM +, Matt Fleming wrote: > > Right, I was thinking about this in the context of configuring the BIOS > (OVMF in my case) with runtime tunable knobs instead of having to > recompile the BIOS image from scratch. > > I'll carve out some time to review your patche

[Qemu-devel] [PATCH v3 00/10] QEMU memory hot unplug support

2015-02-25 Thread Zhu Guihua
Memory hot unplug are both asynchronous procedures. When the unplug operation happens, unplug request cb is called first. And when guest OS finished handling unplug, unplug cb will be called to do the real removal of device. This series depends on the following patchset. [PATCH v2 0/5] Common unpl

[Qemu-devel] [PATCH v3 10/10] acpi: Add hardware implementation for memory hot unplug.

2015-02-25 Thread Zhu Guihua
From: Tang Chen This patch adds a new bit to memory hotplug IO port indicating that ej0 has been evaluated by guest OS. And call pc-dimm unplug cb to do the real removal. Signed-off-by: Hu Tao Signed-off-by: Tang Chen Signed-off-by: Zhu Guihua --- docs/specs/acpi_mem_hotplug.txt | 11 +

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

2015-02-25 Thread Chen Gang S
On 02/26/2015 01:19 AM, Richard Henderson wrote: > On 02/24/2015 05:40 PM, Chen Gang S wrote: +static int gen_shl16insli(struct DisasContext *dc, + unsigned char rdst, unsigned char rsrc, short im16) >>> >>> Use uint16_t, as the field is not signed. >>> >> >

Re: [Qemu-devel] [PATCH v3 05/11] block: Move BDS close notifiers into BB

2015-02-25 Thread Fam Zheng
On Wed, 02/25 09:12, Max Reitz wrote: > Because I need a Notifier pointer to give to > blk_add_{insert,remove}_bs_notifier(), and most importantly because the only > "opaque" object the callbacks will receive is that Notifier pointer (which > in this case is actually a DataPlaneBlkChangeNotifier po

Re: [Qemu-devel] [PATCH v3 02/11] iotests: Do not redirect qemu's stderr

2015-02-25 Thread Fam Zheng
On Wed, 02/25 09:01, Max Reitz wrote: > On 2015-02-25 at 02:04, Fam Zheng wrote: > >On Tue, 02/24 10:35, Max Reitz wrote: > >>Redirecting qemu's stderr to stdout makes working with the stderr output > >>difficult due to the other file descriptor magic performed in > >>_launch_qemu ("ambiguous redir

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-25 Thread Liu Yuan
On Wed, Feb 25, 2015 at 10:35:17AM +0100, Markus Armbruster wrote: > Liu Yuan writes: > > > On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: > >> Liu Yuan writes: > >> > >> > From: Liu Yuan > >> > > >> > These functions mix up -1 and -errno in return values and would might >

Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes

2015-02-25 Thread Li, Liang Z
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Tuesday, February 17, 2015 10:24 PM > To: Juan Quintela > Cc: qemu-devel@nongnu.org; Li, Liang Z > Subject: Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between > pages and bytes > > * Juan

Re: [Qemu-devel] [PATCH v11 0/5] Netduino 2 Machine Model

2015-02-25 Thread Peter Maydell
On 26 February 2015 at 10:53, Alistair Francis wrote: > On Tue, Feb 17, 2015 at 10:38 PM, Alistair Francis > wrote: >> This patch series adds the Netduino 2 Machine to QEMU > > Hello Peter Maydell, > > All of these patches have been reviewed by Peter Crosthwaite. Can this > be committed now? Su

Re: [Qemu-devel] [RFC v3 08/10] vfio-pci: add VFIO_FEATURE_ENABLE_AER_CAP feature

2015-02-25 Thread Chen Fan
On 02/11/2015 12:39 AM, Alex Williamson wrote: On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote: add a new "aercap" feature in vfio device, for controlling whether expose aer capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletion

Re: [Qemu-devel] [PULL 0/3] hmp: Normalize HMP command handler names

2015-02-25 Thread Peter Maydell
On 18 February 2015 at 20:08, Markus Armbruster wrote: > When I can't guess a handler's name, I have to look it up in > hmp-commands.hx. Happens often enough to annoy me. Let's make them > more predictable. > > Touches several subsystems because HMP command handlers are still > spread far and wi

Re: [Qemu-devel] [PATCH target-arm v1 15/15] arm: xlnx-zynq-mp: Add PSCI setup

2015-02-25 Thread Alistair Francis
On Tue, Feb 24, 2015 at 9:04 AM, Peter Crosthwaite wrote: > Use SMC PSCI, with the standard policy of secondaries starting in > power-off. > > Signed-off-by: Peter Crosthwaite > --- > hw/arm/xlnx-zynq-mp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/hw/arm/xlnx-zynq-mp.c b/h

[Qemu-devel] [PATCH V2 00/11] Support more virtio queues

2015-02-25 Thread Jason Wang
We current limit the max virtio queues to 64. This is not sufficient to support some multiqueue deivces (e.g recent Linux support up to 256 tap queues). So this series try to let virtio to support more queues. No much works needs to be done except: - Patch 1 add a check to validate the queues sup

[Qemu-devel] [PATCH V2 05/11] virtio-serial-bus: switch to bus specific queue limit

2015-02-25 Thread Jason Wang
Cc: Amit Shah Signed-off-by: Jason Wang --- hw/char/virtio-serial-bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 37a6f44..f280e95 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial-bus

[Qemu-devel] [PATCH V2 06/11] virtio-s390: switch to bus specific queue limit

2015-02-25 Thread Jason Wang
Instead of depending on marco, switch to use a bus specific queue limit. Left is AdapterRouters->gsi[], this could be done in the future if we want to increase s390's queue limit really. Cc: Alexander Graf Cc: Richard Henderson Cc: Christian Borntraeger Cc: Cornelia Huck Signed-off-by: Jason W

[Qemu-devel] [PATCH V2 09/11] virtio-pci: increase the maximum number of virtqueues to 513

2015-02-25 Thread Jason Wang
This patch increases the maximum number of virtqueues for pci from 64 to 513. This will allow booting a virtio-net-pci device with 256 queue pairs. To keep migration compatibility, 64 was kept for legacy machine types. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Anthony Liguori Cc: Michael S.

Re: [Qemu-devel] [RFC PATCH 1/7] hw/arm/virt: Add a GPIO controller

2015-02-25 Thread Shannon Zhao
On 2015/2/19 1:52, Wei Huang wrote: > > > On 02/17/2015 04:10 AM, Shannon Zhao wrote: >> Add a GPIO controller in machine virt, in order to support cpu hotplug. >> Here we use pl061. >> >> Signed-off-by: Shannon Zhao >> --- >> hw/arm/virt.c | 28 >> 1 files change