Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

On 2/24/15 15:53, Chen Gang S wrote: [...] > diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c > index 5131fa7..82c751e 100644 > --- a/target-tilegx/translate.c > +++ b/target-tilegx/translate.c > @@ -25,18 +25,880 @@ > #include "exec/cpu_ldst.h" > #include "exec/helper-gen.h"

Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

On Thu, 12 Feb 2015 15:50:35 -0200 Eduardo Habkost wrote: > Instead of silently assigning CPU to node 0 when it is omitted from the > command-line, check if all CPUs up to max_cpus are present in the NUMA > configuration. That would also trigger warning for possible (i.e. to be hotplugged) CPUs a

Re: [Qemu-devel] [RFC PATCH v1 13/13] spapr: Memory hotplug support

On Tue, Feb 24, 2015 at 05:26:12PM +1100, David Gibson wrote: > On Thu, Jan 08, 2015 at 11:40:20AM +0530, Bharata B Rao wrote: > > Make use of pc-dimm infrastructure to support memory hotplug > > for PowerPC. > > > > Modelled on i386 memory hotplug. > > > > Signed-off-by: Bharata B Rao > > --- >

Re: [Qemu-devel] [PATCH v5 03/16] spapr_rtas: add get/set-power-level RTAS interfaces

On Mon, Feb 16, 2015 at 08:27:39AM -0600, Michael Roth wrote: > From: Nathan Fontenot > > These interfaces manage the power domains that guest devices are > assigned to and are used to power on/off devices. Currently we > only utilize 1 power domain, the 'live-insertion' domain, which > automates

Re: [Qemu-devel] [PATCH v5 08/16] spapr_events: re-use EPOW event infrastructure for hotplug events

On Mon, Feb 16, 2015 at 08:27:44AM -0600, Michael Roth wrote: > From: Nathan Fontenot > > This extends the data structures currently used to report EPOW events to > guests via the check-exception RTAS interfaces to also include event types > for hotplug/unplug events. > > This is currently undoc

Re: [Qemu-devel] [PATCH v5 05/16] spapr_rtas: add get-sensor-state RTAS interface

On Mon, Feb 16, 2015 at 08:27:41AM -0600, Michael Roth wrote: > From: Mike Day > > This interface allows a guest to read various platform/device sensors. > initially, we only implement support necessary to support hotplug: > reading of the dr-entity-sense sensor, which communicates the state of >

Re: [Qemu-devel] [PATCH v5 07/16] spapr_rtas: add ibm, configure-connector RTAS interface

On Mon, Feb 16, 2015 at 08:27:43AM -0600, Michael Roth wrote: > This interface is used to fetch an OF device-tree nodes that describes a > newly-attached device to guest. It is called multiple times to walk the > device-tree node and fetch individual properties into a 'workarea'/buffer > provided b

Re: [Qemu-devel] [PATCH v5 04/16] spapr_rtas: add set-indicator RTAS interface

On Mon, Feb 16, 2015 at 08:27:40AM -0600, Michael Roth wrote: > From: Mike Day > > This interface allows a guest to control various platform/device > sensors. Initially, we only implement support necessary to control > sensors that are required for hotplug: DR connector indicators/LEDs, > resourc

Re: [Qemu-devel] [PATCH 3/3] Give ivshmem its own config option

On Mon, Feb 23, 2015 at 10:38:06PM -0800, Peter Crosthwaite wrote: > On Mon, Feb 23, 2015 at 3:05 PM, David Gibson > wrote: > > Currently the ivshmem device is built whenever both PCI and KVM support are > > included. This patch gives it its own config option to allow easier > > customization of

Re: [Qemu-devel] [PATCH 1/3] Add specific config options for PCI-E bridges

On Mon, Feb 23, 2015 at 10:17:58PM -0800, Peter Crosthwaite wrote: > On Mon, Feb 23, 2015 at 3:05 PM, David Gibson > wrote: > > The i82801b11, ioh3420 and xio3130 PCI Express devices are currently > > included in the build unconditionally. > > > > While they could theoretically appear on any targe

Re: [Qemu-devel] [PATCH 2/3] Create specific config option for "platform-bus"

On Mon, Feb 23, 2015 at 10:27:20PM -0800, Peter Crosthwaite wrote: > On Mon, Feb 23, 2015 at 3:05 PM, David Gibson > wrote: > > Currently the "platform-bus" device is included for all softmmu builds. > > This bridge is intended for use on any platforms that require dynamic > > creation of sysbus d

Re: [Qemu-devel] [PATCH v7 0/5] Geometry and blocksize detection for backing devices.

Am 16.02.2015 um 12:47 schrieb Ekaterina Tumanova: > Updates v6 -> v7: > > Fix > 1. Set default blocksizes via blkconf_blocksizes call in ide_dev_initfn > and scsi_hd_realise before using these values. > 2. Remove asserts in bdrv functions, check drv for being NULL instead. > 3. Adjust logic in

Re: [Qemu-devel] [PATCH v5 09/16] spapr_events: event-scan RTAS interface

On Mon, Feb 16, 2015 at 08:27:45AM -0600, Michael Roth wrote: > From: Tyrel Datwyler > > We don't actually rely on this interface to surface hotplug events, and > instead rely on the similar-but-interrupt-driven check-exception RTAS > interface used for EPOW events. However, the existence of this

Re: [Qemu-devel] [PATCH v5 10/16] spapr_drc: add spapr_drc_populate_dt()

On Mon, Feb 16, 2015 at 08:27:46AM -0600, Michael Roth wrote: > This function handles generation of ibm,drc-* array device tree > properties to describe DRC topology to guests. This will by used > by the guest to direct RTAS calls to manage any dynamic resources > we associate with a particular DR

Re: [Qemu-devel] [PATCH 1/5] migration: Remove unused functions

On (Thu) 19 Feb 2015 [18:12:19], Thomas Huth wrote: > dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(), > migrate_rdma_pin_all(), qsb_clone() and qsb_set_length() > are completely unused and thus can be deleted. > > Signed-off-by: Thomas Huth > Cc: Juan Quintela > Cc: Amit Shah > --

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

** Changed in: nova Milestone: kilo-3 => None -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images Status in Cinder: Triaged St

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

Eric Blake writes: > On 02/23/2015 10:40 AM, Markus Armbruster wrote: > int64_t pow2floor(int64_t value) { assert(value > 0); return 0x8000u >> clz64(value); } >>> >>> Needs to be 0x8000ull for 32-bit machines to compile correctly. >> >> W

Re: [Qemu-devel] [PATCH] virtio-scsi: Allocate op blocker reason before blocking

Max Reitz writes: > s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places > where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is > allocated and when it is freed. That does not make a whole lot of sense > (and is actually wrong because this leads to s->blocker pote

Re: [Qemu-devel] [PATCH 1/6] ram: make all save_page functions take a uint64_t parameter

On (Thu) 12 Feb 2015 [23:03:06], Juan Quintela wrote: > It used to be an int, but then we can't pass directly the > bytes_transferred parameter, that would happen later in the series. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 11 --- > include/migration/mig

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net

On 02/17/2015 07:50 AM, Eric Blake wrote: > On 02/11/2015 08:17 PM, zhanghailiang wrote: >> The 'colo_nicname' should be assigned with network name, >> for exmple, 'eth2'. It will be parameter of 'colo_script', > > s/exmple/example/ > >> 'colo_script' should be assigned with an scirpt path. > >

Re: [Qemu-devel] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for PHBs

On Mon, Feb 16, 2015 at 08:27:49AM -0600, Michael Roth wrote: > Reserve 32 entries of type PCI in each PHB's initial FDT. This I find this description odd. It's not reallky reserving anything, just publishing the DRCs you already created in the FDT. I wonder if this should be merged with the pre

Re: [Qemu-devel] [PATCH 2/6] ram_find_and_save_block: change calling convention

On (Thu) 12 Feb 2015 [23:03:07], Juan Quintela wrote: > Add a parameter to pass the number of bytes written, and make it return > the number of pages written instead. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 44 ++-- > 1 file changed, 22 inse

Re: [Qemu-devel] [PATCH v5 14/16] pci: make pci_bar useable outside pci.c

On Mon, Feb 16, 2015 at 08:27:50AM -0600, Michael Roth wrote: > We need to work with PCI BARs to generate OF properties > during PCI hotplug for sPAPR guests. > > Signed-off-by: Michael Roth Added Michael Tsirkin to the Cc list, since he usually handles the PCI subsystem. Reviewed-by: David Gib

Re: [Qemu-devel] [PATCH 4/6] save_xbzrle_page: change calling convention

On (Thu) 12 Feb 2015 [23:03:09], Juan Quintela wrote: > Add a parameter to pass the number of bytes written, and make it return > the number of pages written instead. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 44 +--- > 1 file changed, 25 inse

Re: [Qemu-devel] [PATCH v7 0/5] Geometry and blocksize detection for backing devices.

On Mon, Feb 16, 2015 at 12:47:53PM +0100, Ekaterina Tumanova wrote: > > Updates v6 -> v7: > > Fix > 1. Set default blocksizes via blkconf_blocksizes call in ide_dev_initfn > and scsi_hd_realise before using these values. > 2. Remove asserts in bdrv functions, check drv for being NULL instead. >

Re: [Qemu-devel] [PATCH v3 0/3] -incoming defer

On Mon, Feb 23, 2015 at 10:55:53AM +, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@gmail.com) wrote: > > On Thu, Feb 19, 2015 at 11:40:26AM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > This patchset provides a way of setting o

Re: [Qemu-devel] [PATCH RFC v3 00/27] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > 3. Prepare host kernel > colo-proxy kernel module need cooperate with linux kernel. > You should put a kernel patch 'colo-patch-for-kernel.patch' > (It's based on linux kernel-3.19) which you can get from > https://github.com/gao-feng/colo-

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

On Thu, Feb 19, 2015 at 08:24:19PM +0100, Radim Krčmář wrote: > Window 8.0 driver has a particular behavior for a small time frame after > it enables rx interrupts: the interrupt handler never clears > E1000_ICR_RXT0. The handler does this something like this: > set_imc(-1) (1) di

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

On 24 February 2015 at 18:39, Markus Armbruster wrote: > Eric Blake writes: >> Because 0x8000u is only required to be a 'long', and on >> 32-bit machines, your constant would overflow long. See, for example, >> commit 5cb6be2ca. You NEED the 'll' suffix to ensure that the compiler >

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

On Tue, Feb 24, 2015 at 11:35 AM, Stefan Hajnoczi wrote: > On Thu, Feb 19, 2015 at 08:24:19PM +0100, Radim Krčmář wrote: >> Window 8.0 driver has a particular behavior for a small time frame after >> it enables rx interrupts: the interrupt handler never clears >> E1000_ICR_RXT0. The handler does

Re: [Qemu-devel] [PULL v2 00/14] target-mips queue

On 15 February 2015 at 02:44, Leon Alrae wrote: > Hi, > > Here is version 2 of target-mips pullreq - rebased and with signed tag. > > Thanks, > Leon > > Cc: Peter Maydell > Cc: Aurelien Jarno > > The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: > > Merge remote-trac

Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header

On (Thu) 12 Feb 2015 [23:03:11], Juan Quintela wrote: > It has always been a page header, not a block header. Once there, the > flag argument was only passed to make a bit or with it, just do the or > on the caller. I prefer not to do that -- if one looks at the function signature, he'll only not

Re: [Qemu-devel] [PULL 0/7] vnc: fixup some QemuOpts conversion fallout.

On 16 February 2015 at 17:25, Gerd Hoffmann wrote: > Hi, > > The "multiple vnc servers" patch series introduced some issues, mostly > due to the QemuOpts conversion of the vnc option parsing. This pull > fixes most of them. There also is one optimization. > > There is one pending issue related

Re: [Qemu-devel] [PATCH v2] utils: Add pow2ceil()

Peter Maydell writes: > On 24 February 2015 at 18:39, Markus Armbruster wrote: >> Eric Blake writes: >>> Because 0x8000u is only required to be a 'long', and on >>> 32-bit machines, your constant would overflow long. See, for example, >>> commit 5cb6be2ca. You NEED the 'll' suffix

[Qemu-devel] [PATCH 05/10] s390x/kvm: trace all SIGP orders

From: David Hildenbrand This patch adds tracing code for all SIGP orders (including the destination vcpu and the resulting condition code). Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: David Hildenbrand --- target-s390x/kvm.c | 4 +++- trac

[Qemu-devel] [PATCH 01/10] s390x: introduce defines for SIGP condition codes

From: David Hildenbrand This patch introduces defines for the SIGP condition codes and replaces all occurrences of numeral condition codes with the new defines. Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: David Hildenbrand --- target-s390x/cpu.h | 9 ++

[Qemu-devel] [PATCH 09/10] s390x/kvm: deliver SIGP RESTART directly if stopped

From: David Hildenbrand According to the PoP, a restart irq has to be delivered "without first honoring any other pending interruptions", if a cpu is in the STOPPED state. While it is hard to implement this case in kvm, it can easily be handled in qemu. Reviewed-by: Thomas Huth Reviewed-by: C

[Qemu-devel] [PATCH 00/10] s390x: move sigp handling to user space

Cornelia, Alex, Christian, these patches move large parts of SIGP handling from kernel to user space. Please note: This series needs a linux-headers sync with v4.0-rc1 to work and should be applied only after Michael Tsirkin's series "virtio: pull headers from linux" was applied and a header sy

[Qemu-devel] [PATCH 10/10] s390x/kvm: enable the new SIGP handling in user space

From: David Hildenbrand All required SIGP handlers have been implemented in QEMU. Let's enable the new sigp handling in user space if the kernel supports it. Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: David Hildenbrand --- target-s390x/k

[Qemu-devel] [PATCH 06/10] s390x/kvm: implement handling of new SIGP orders

From: David Hildenbrand This patch adds handling code for the following SIGP orders: - SIGP SET ARCHITECTURE - SIGP SET PREFIX - SIGP STOP - SIGP STOP AND STORE STATUS - SIGP STORE STATUS AT ADDRESS SIGP STOP (AND STORE STATUS) are the only orders that can stay pending forever (and may only be i

[Qemu-devel] [PATCH 03/10] s390x/kvm: pass the SIGP instruction parameter to the SIGP handler

From: David Hildenbrand The parameter of the SIGP instruction will be neded in the future. Let's read it out and store it in the struct sigp_info, so it can be passed to the sigp handlers. Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: David Hi

[Qemu-devel] [PATCH 02/10] s390x/kvm: more details for SIGP handler with one destination vcpu

From: David Hildenbrand Whenever a sigp order is to be executed by a target vcpu, we use run_on_cpu(). As we have only one pointer to pass all data to these sigp handlers, let's introduce the struct sigp_info and use it as a transport container. All orders targeting a single vcpu are now dispat

[Qemu-devel] [PATCH 04/10] s390x/kvm: helper to set the SIGP status in SigpInfo

From: David Hildenbrand Whenever we set the SIGP status in the status register, we have to wipe out the lower 4 bytes and keep the higher 4 bytes. Also the condition code will always be set to STATUS_STORED. Let's introduce the wrapper for SigpInfo, as this will avoid most duplicate code in the

[Qemu-devel] [PATCH 07/10] s390x/kvm: SIGP START is only applicable when STOPPED

From: David Hildenbrand In preparation for other CPU states, SIGP START will only start a VCPU if it is in the STOPPED state. Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: David Hildenbrand --- target-s390x/kvm.c | 5 + 1 file changed, 5

[Qemu-devel] [PATCH 08/10] s390x: add function to deliver restart irqs

From: David Hildenbrand This patch adds a helper function to deliver restart irqs. To be able to be used by kvm, the psw load/store methods have to perform special cc-code handling only when running with tcg. Reviewed-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: David Hildenbr

[Qemu-devel] [PATCH 1/1] qmp: Add support for requesting the list of arguments from a command

This patch adds the CommandArgumentInfo type that lists the details of an argument that a QMP command can take. It currently includes its name and whether it's optional or not, but it can be extended in the future to include other information. A new 'query-command-args' command returns a list of a

[Qemu-devel] [PATCH 0/1] Get the list of arguments from a QMP command

Hello, this is a follow-up to the comments from Eric Blake about my patches to extend the block streaming API: https://lists.gnu.org/archive/html/qemu-devel/2015-02/msg04231.html Since QEMU doesn't have an easy way to tell the arguments that a particular QMP command supports, and it seems tha

Re: [Qemu-devel] [PULL v2 00/65] Block patches

On 17 February 2015 at 00:45, Stefan Hajnoczi wrote: > The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into > staging (2015-02-13 11:44:50 +) > > are available in the git repository at: > >

[Qemu-devel] [PULL 08/10] serial: serial_hds_isa_init() shouldn't fail

From: Markus Armbruster It shouldn't fail, and no caller checks for failure. Make failure fatal. Maintainers of affected machines cc'ed. Cc: Richard Henderson Cc: Anthony Liguori Cc: "Michael S. Tsirkin" Cc: Aurelien Jarno Cc: Leon Alrae Cc: Blue Swirl Signed-off-by: Markus Armbruster S

[Qemu-devel] [PULL 05/10] leon3: Replace unchecked qdev_init() by qdev_init_nofail()

From: Markus Armbruster grlib_irqmp_create(), grlib_gptimer_create() and grlib_apbuart_create() are helpers to create and realize GRLIB devices. Their only caller leon3_generic_hw_init() doesn't check for failure. Only the first can actually fail, and only when the caller fails to set up a poin

[Qemu-devel] [PULL 07/10] serial: Factor out common serial_hds_isa_init()

From: Markus Armbruster It's the same old loop copied five times, plus another instance where it's clipped to two iterations and unrolled. No external users of serial_isa_init() are left, so give it internal linkage. Maintainers of affected machines cc'ed. Cc: Richard Henderson Cc: Anthony Li

[Qemu-devel] [PULL 04/10] ide/isa: Replace unchecked qdev_init() by qdev_init_nofail()

From: Markus Armbruster isa_ide_init()'s callers don't check for failure. isa_ide_init() looks like it could fail, but since isa_ide_realizefn() can't fail, it actually can't. Replace its qdev_init() by qdev_init_nofail() to make it obvious. Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by:

Re: [Qemu-devel] [PATCH] virtio-scsi: Allocate op blocker reason before blocking

On 2015-02-24 at 04:43, Markus Armbruster wrote: Max Reitz writes: s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is allocated and when it is freed. That does not make a whole lot of sense (and is actually

[Qemu-devel] [PULL 01/10] qdev: Avoid type assertion in qdev_build_hotpluggable_device_list()

From: Jun Li Currently when *obj is not a TYPE_DEVICE, QEMU will abort. This patch fixes it. When *obj is not a TYPE_DEVICE, just do not add it to hotpluggable device list. This patch also fixes the following issue: 1. boot QEMU using cli: $ /opt/qemu-git-arm/bin/qemu-system-x86_64 -monitor stdi

[Qemu-devel] [PULL 02/10] qom: Fix typo, 'my_class_init' -> 'derived_class_init'

From: Zhoujian Signed-off-by: Zhoujian Signed-off-by: Gonglei Signed-off-by: Andreas Färber --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h index 89c3092..8757573 100644 --- a/include/qom/object.h +++ b/i

[Qemu-devel] [PULL 00/10] QOM devices patch queue 2015-02-24

Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Markus Armbruster The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into staging (2015-02-13

[Qemu-devel] [PULL 09/10] parallel: Factor out common parallel_hds_isa_init()

From: Markus Armbruster Maintainers of affected machines cc'ed. Cc: Anthony Liguori Cc: "Michael S. Tsirkin" Cc: Aurelien Jarno Cc: Leon Alrae Cc: Blue Swirl Signed-off-by: Markus Armbruster Signed-off-by: Andreas Färber --- hw/char/parallel.c | 31 +++ h

[Qemu-devel] [PULL 06/10] etsec: Replace qdev_init() by qdev_init_nofail()

From: Markus Armbruster etsec_create() is a helper to create and realize the eTSEC. It's currently unused. Similar helpers for other NICs use qdev_init_nofail(). Match that. Signed-off-by: Markus Armbruster Signed-off-by: Andreas Färber --- hw/net/fsl_etsec/etsec.c | 5 + 1 file change

[Qemu-devel] [PULL 03/10] qdev: Improve qdev_init_nofail()'s error reporting

From: Markus Armbruster We get two error messages: a specific one from qdev_init(), and a generic one from qdev_init_nofail(). The specific one gets suppressed in QMP context. qdev_init_nofail() failing there is a bug, though. Cut out the qdev_init() middle-man: realize the device, and on erro

Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

Kevin Wolf writes: > Am 23.02.2015 um 13:23 hat Alberto Garcia geschrieben: >> On Fri, Feb 20, 2015 at 03:38:04PM -0700, Eric Blake wrote: >> >> > > +if (has_top) { >> > > +top_bs = bdrv_find_backing_image(bs, top); >> > > +if (top_bs == NULL) { >> > > +error_set(

Re: [Qemu-devel] [PATCH 3/5] vpc: Ignore geometry for large images

On 2015-02-24 at 01:45, Peter Lieven wrote: Am 23.02.2015 um 19:34 schrieb Max Reitz: On 2015-02-23 at 09:27, Peter Lieven wrote: From: Kevin Wolf The CHS calculation as done per the VHD spec imposes a maximum image size of ~127 GB. Real VHD images exist that are larger than that. Apparently

Re: [Qemu-devel] [PATCH 4/5] block/vpc: make calculate_geometry spec conform

On 2015-02-24 at 01:49, Peter Lieven wrote: Am 23.02.2015 um 19:59 schrieb Max Reitz: On 2015-02-23 at 09:27, Peter Lieven wrote: The VHD spec [1] allows for total_sectors of 65535 x 16 x 255 (~127GB) represented by a CHS geometry. If total_sectors is greater than 65535 x 16 x 255 this geometry

[Qemu-devel] [PULL 10/10] parallel: parallel_hds_isa_init() shouldn't fail

From: Markus Armbruster It shouldn't fail, and no caller checks for failure. Make failure fatal. Maintainers of affected machines cc'ed. Cc: Anthony Liguori Cc: "Michael S. Tsirkin" Cc: Aurelien Jarno Cc: Leon Alrae Cc: Blue Swirl Signed-off-by: Markus Armbruster Signed-off-by: Andreas F

Re: [Qemu-devel] [PATCH 2/5] block/vpc: simplify vpc_read

On 2015-02-24 at 01:44, Peter Lieven wrote: Am 23.02.2015 um 19:29 schrieb Max Reitz: On 2015-02-23 at 09:27, Peter Lieven wrote: Signed-off-by: Peter Lieven --- block/vpc.c | 116 +++ 1 file changed, 52 insertions(+), 64 deletions(

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

On 2/24/2015 2:53 AM, Chen Gang S wrote: typedef struct CPUTLState { +uint64_t regs[TILEGX_R_COUNT]; /* Common used registers by outside */ +uint64_t zero; /* Zero register */ +uint64_t pc; /* Current pc */ CPU_COMMON } CPUTLState; I skimm

[Qemu-devel] QEMU pci mach-virt: setting PCI_INTERRUPT_LINE?

Hello, I am trying to set the pci interrupt line field in the configuration space (offset 0x3c), since it is initialized as zero. I would like to set it to the right value as read from the device tree, in order for other existing software which relies on it to be able to work unmodified.. but i

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

On 24 February 2015 at 23:21, Chris Metcalf wrote: > On 2/24/2015 2:53 AM, Chen Gang S wrote: >> >> typedef struct CPUTLState { >> +uint64_t regs[TILEGX_R_COUNT]; /* Common used registers by outside */ >> +uint64_t zero; /* Zero register */ >> +uint64_t pc;

[Qemu-devel] Packet dropps in virtual tap interface

Hello. We use our highly load system in OpenStack environment. And faced with serious problems in network highload guests. At a relatively high CPU load of hypervisor (40-60%) virtual network interfaces of this guests starts to droppart of the packets. We use for virtualization qemu-kvm with vh

Re: [Qemu-devel] unable to set SATA serial with a spaces

Bug 1195660 has been added to the database > On Feb 23, 2015, at 3:41 AM, Michal Privoznik wrote: > > On 23.02.2015 11:18, Markus Armbruster wrote: >> Alan Latteri writes: >> >>> The left padding is important and necessary to keep for my p

Re: [Qemu-devel] [PATCH 0/5] tcg-arm: LPAE: fix and extend xn control

On Thu, Feb 12, 2015 at 04:05:02PM +0100, Andrew Jones wrote: > This series fixes and extends the determination of whether or > not an address is executable for LPAE translations. The main > patch is 4/5, and describes the details in its commit message. > Patches 1-3 prepare for the main patch, and

Re: [Qemu-devel] [PATCH 0/5] tcg-arm: LPAE: fix and extend xn control

On 25 February 2015 at 00:06, Andrew Jones wrote: > Ping? This isn't a huge priority, but I wouldn't want it to get lost either. I'm on holiday :-) Easy stuff is getting done but things that take time (read: code review) are postponed til mid-March. You can wait til then, or find somebody else on

Re: [Qemu-devel] [PATCH v5 3/4] arm: Add PCIe host bridge in virt machine

On 7 February 2015 at 02:04, Alexander Graf wrote: > typedef struct MemMapEntry { > @@ -129,13 +131,21 @@ static const MemMapEntry a15memmap[] = { > [VIRT_FW_CFG] = { 0x0902, 0x000a }, > [VIRT_MMIO] = { 0x0a00, 0x0200 }, > /* ...repeating for a total of NU

[Qemu-devel] [PATCH v3 08/11] block: Make bdrv_close() static

There are no users of bdrv_close() left, except for one of bdrv_open()'s failure paths, bdrv_close_all() and bdrv_delete(), and that is good. Make bdrv_close() static so nobody makes the mistake of directly using bdrv_close() again. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block.c

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

On 2/24/15 22:38, Peter Maydell wrote: > On 24 February 2015 at 23:21, Chris Metcalf wrote: >> On 2/24/2015 2:53 AM, Chen Gang S wrote: >>> >>> typedef struct CPUTLState { >>> +uint64_t regs[TILEGX_R_COUNT]; /* Common used registers by outside */ >>> +uint64_t zero; /* Ze

[Qemu-devel] [PATCH v3 09/11] blockdev: Keep track of monitor-owned BDS

...and release the reference on bdrv_close_all(). Signed-off-by: Max Reitz --- block.c| 5 + blockdev.c | 18 ++ include/block/block_int.h | 4 stubs/Makefile.objs| 1 + stubs

Re: [Qemu-devel] [PATCH 0/5] tcg-arm: LPAE: fix and extend xn control

On Wed, Feb 25, 2015 at 12:08:16AM +0900, Peter Maydell wrote: > On 25 February 2015 at 00:06, Andrew Jones wrote: > > Ping? This isn't a huge priority, but I wouldn't want it to get lost either. > > I'm on holiday :-) Easy stuff is getting done but things that > take time (read: code review) are

[Qemu-devel] [PATCH v3 02/11] iotests: Do not redirect qemu's stderr

Redirecting qemu's stderr to stdout makes working with the stderr output difficult due to the other file descriptor magic performed in _launch_qemu ("ambiguous redirect"). There is no harm in leaving stderr on stderr, so do it. Signed-off-by: Max Reitz --- If someone has a better solution, espec

[Qemu-devel] [PATCH v3 07/11] blockdev: Use blk_remove_bs() in do_drive_del()

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- blockdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index f198be6..e5f5ebc 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2229,11 +2229,7 @@ int do_drive_del(Monitor *mon, const QDict *qdic

[Qemu-devel] [PATCH v3 06/11] block: Use blk_remove_bs() in blk_delete()

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/block-backend.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index 254fde4..7e9d53a 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -163,12 +

[Qemu-devel] [PATCH v3 04/11] quorum: Fix close path

bdrv_unref() can lead to bdrv_close(), which in turn will result in bdrv_drain_all(). This function will later be called blk_drain_all() and iterate only over the BlockBackends for which blk_is_inserted() holds true; therefore, bdrv_is_inserted() and thus quorum_is_inserted() will probably be calle

[Qemu-devel] [PATCH v3 00/11] block: Rework bdrv_close_all()

Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend, which can lead to data corruption (see the iotest added in the final patch of this series) and is most certainly very ugly. This series reworks bdrv_close_all() to instead eject the BDS trees from all BlockBackends and then clo

[Qemu-devel] [PATCH v3 01/11] iotests: Move _filter_nbd into common.filter

_filter_nbd can be useful for other NBD tests, too, therefore it should reside in common.filter, and it should support URLs of the "nbd://" format and export names. The NBD log lines ("/your/source/dir/nbd.c:function():line: error") should not be converted to empty lines but removed altogether. S

[Qemu-devel] [PATCH v3 05/11] block: Move BDS close notifiers into BB

The only remaining user of the BDS close notifiers is NBD which uses them to determine when a BDS tree is being ejected. This patch removes the BDS-level close notifiers and adds a notifier list to the BlockBackend structure that is invoked whenever a BDS is removed. Symmetrically to that, another

[Qemu-devel] [PATCH v3 10/11] block: Eject BDS tree from BB at bdrv_close_all()

When bdrv_close_all() is called, instead of force-closing all root BlockDriverStates, it is better to just drop the reference from all BlockBackends and let them be closed automatically. This prevents BDS from getting closed that are still referenced by other BDS, which may result in loss of cached

[Qemu-devel] [PATCH v3 11/11] iotests: Add test for multiple BB on BDS tree

This adds a test for having multiple BlockBackends in one BDS tree. In this case, there is one BB for the protocol BDS and one BB for the format BDS in a simple two-BDS tree (with the protocol BDS and BB added first). When bdrv_close_all() is executed, no cached data from any BDS should be lost; t

[Qemu-devel] [PATCH v3 03/11] iotests: Add test for eject under NBD server

This patch adds a test for ejecting the BlockBackend an NBD server is connected to (the NBD server is supposed to stop). Signed-off-by: Max Reitz --- tests/qemu-iotests/096 | 89 ++ tests/qemu-iotests/096.out | 16 + tests/qemu-iotests/grou

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

On 2/24/15 22:21, Chris Metcalf wrote: > On 2/24/2015 2:53 AM, Chen Gang S wrote: >> typedef struct CPUTLState { >> +uint64_t regs[TILEGX_R_COUNT]; /* Common used registers by outside */ >> +uint64_t zero; /* Zero register */ >> +uint64_t pc; /* Curre

[Qemu-devel] [PATCH 9/9] block: Remove bdrv_states

Every entry in this list should be a root BDS and as such either be anchored to a BlockBackend or be owned by the monitor. Signed-off-by: Max Reitz --- block.c | 21 + include/block/block.h | 1 - include/block/block_int.h | 2 -- 3 files changed, 1 in

[Qemu-devel] [PATCH 7/9] block: Make bdrv_drain_one() public

We will need it in block/block-backend.c. Signed-off-by: Max Reitz --- block.c | 2 +- include/block/block_int.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index e479042..b81f91d 100644 --- a/block.c +++ b/block.c @@ -1966,7 +1966,7

[Qemu-devel] [PATCH 8/9] block: Move some bdrv_*_all() functions to BB

Move bdrv_drain_all(), bdrv_commit_all(), bdrv_flush_all() and bdrv_invalidate_cache_all() to BB. The only operation left is bdrv_close_all(), which cannot be moved to the BB because it should not only close all BBs, but also all monitor-owned BDSs. Signed-off-by: Max Reitz --- block.c

[Qemu-devel] [PATCH 5/9] blockdev: Add list of monitor-owned BlockBackends

The monitor does hold references to some BlockBackends so it should have a list of those BBs; blk_backends is a different list, as it contains references to all BBs (after a follow-up patch, that is), and that should not be changed because we do need such a list. monitor_remove_blk() is idempotent

[Qemu-devel] [PATCH 2/9] block: Add blk_next_inserted()

This function skips to the next BlockBackend for which blk_is_inserted() is true. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/block-backend.c | 15 +++ include/sysemu/block-backend.h | 1 + 2 files changed, 16 insertions(+) diff --git a/block/block-backend.

[Qemu-devel] [PATCH 0/9] blockdev: Further BlockBackend work

Overall, this series adds more uses for BlockBackends and makes the code follow the "reference theory" more closely, in that any BlockBackend created (through -drive or blockdev-add) has a reference count of 1, and that reference should be held by the monitor. This is reflected here by introducing

Re: [Qemu-devel] [PATCH 1/5] migration: Remove unused functions

On Tue, 24 Feb 2015 14:58:29 +0530 Amit Shah wrote: > On (Thu) 19 Feb 2015 [18:12:19], Thomas Huth wrote: > > dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(), > > migrate_rdma_pin_all(), qsb_clone() and qsb_set_length() > > are completely unused and thus can be deleted. > > > > Sign

[Qemu-devel] [PATCH 1/9] block: Add blk_name_taken()

There may be BlockBackends which are not returned by blk_by_name(), but do exist and have a name. blk_name_taken() allows testing whether a specific name is in use already, independent of whether the BlockBackend with that name is accessible through blk_by_name(). Signed-off-by: Max Reitz Reviewe

Re: [Qemu-devel] [PATCH] virtio-scsi: Allocate op blocker reason before blocking

On 02/24/2015 07:03 AM, Max Reitz wrote: > On 2015-02-24 at 04:43, Markus Armbruster wrote: >> Max Reitz writes: >> >>> s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places >>> where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is >>> allocated and when it is freed.

[Qemu-devel] [PATCH 6/9] blockdev: Remove blk_hide_on_behalf_of_do_drive_del()

This function first removed the BlockBackend from the blk_backends list and cleared its name so it would no longer be found by blk_name(); since blk_next() now iterates through monitor_block_backends (which the BB is removed from in do_drive_del()), this is no longer necessary. Second, bdrv_make_a

[Qemu-devel] QMP events and the migration of halted machines

In writing migration tests for qtest and ahci-test, I ran into an interesting pattern and wanted to know if this was expected: 1) Using blkdebug, I inject an error to execute once for the first flush request. 2) Executing the command, I get a STOP event. 3) I migrate the VM, and poll the sourc

Re: [Qemu-devel] [RfC PATCH 11/15] virtio-vga: add '-vga virtio' support

Hi Gerd I think it's missing qemu-options: diff --git a/qemu-options.hx b/qemu-options.hx index 85ca3ad..9315672 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1077,7 +1077,7 @@ Rotate graphical output some deg left (only PXA LCD). ETEXI DEF("vga", HAS_ARG, QEMU_OPTION_vga, -"-vga

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully

On 2/24/2015 11:31 AM, Chen Gang S wrote: - When dst is zero, in most cases, we can just skip the insn, but in some cases, it may cause exception in user mode (e.g st zero r0). Be careful of skipping instructions in general, since for example a "ld zero, r1" may be targeting an MMIO addr

  1   2   3   >