Re: [Qemu-devel] [PULL 00/96] pci, pc, virtio fixes and cleanups

2015-02-19 Thread Michael S. Tsirkin
On Wed, Feb 18, 2015 at 11:03:53PM +0100, Michael S. Tsirkin wrote: > On Wed, Feb 18, 2015 at 10:48:22PM +0100, Michael S. Tsirkin wrote: > > On Wed, Feb 18, 2015 at 10:43:58PM +0100, Michael S. Tsirkin wrote: > > > A huge patchset, but the scariest part is Igor's patches, > > > and these have been

Re: [Qemu-devel] [RFC PATCH 5/7] target-arm/cpu: Add apic_id property for ARMCPU

2015-02-19 Thread Hanjun Guo
On 2015年02月19日 03:51, Igor Mammedov wrote: On Wed, 18 Feb 2015 18:45:51 +0100 Andreas Färber wrote: Hi, Am 17.02.2015 um 11:10 schrieb Shannon Zhao: Add apic_id property for ARMCPU. It can be used for cpu hotplug. Signed-off-by: Shannon Zhao --- target-arm/cpu-qom.h |1 + target-arm

Re: [Qemu-devel] [PULL 00/96] pci, pc, virtio fixes and cleanups

2015-02-19 Thread Peter Maydell
On 19 February 2015 at 07:03, Michael S. Tsirkin wrote: > OK, I think it's a false alarm - passes fine on all other machines, > and on this one, current master gives the same error: > > GTESTER check-qtest-aarch64 > qemu-system-aarch64: Unknown device 'gpex-pcihost' for default sysbus > Broken pip

[Qemu-devel] [PULL 0/1] seabios: update to 1.8.0 release

2015-02-19 Thread Gerd Hoffmann
5-02-13 11:44:50 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-roms-20150219-1 for you to fetch changes up to 21f5826a04d38e19488f917e1eef22751490c769: seabios: update to 1.8.0 release (2015-02-19 09:3

[Qemu-devel] [PULL 1/1] seabios: update to 1.8.0 release

2015-02-19 Thread Gerd Hoffmann
'git shortlog 8936dbb2..4c59f5d8' for seabios repo: David Woodhouse (4): Update EFI_COMPATIBILITY16_TABLE to match 0.98 spec update build: use -m16 where available instead of asm(".code16gcc") romlayout: Use .code16 not .code16gcc vgabios: Use .code16 not .code16gcc Gerd H

[Qemu-devel] [PATCH] qmp: Provide qmp_query_vnc_servers stub for VNC-free build

2015-02-19 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- qmp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qmp.c b/qmp.c index 7f2d25a..ec070da 100644 --- a/qmp.c +++ b/qmp.c @@ -134,6 +134,12 @@ VncInfo *qmp_query_vnc(Error **errp) error_set(errp, QERR_FEATURE_DISABLED, "vnc"); return NULL; }; + +

Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-02-19 Thread Michael S. Tsirkin
On Thu, Jan 29, 2015 at 05:24:41PM +0300, Denis V. Lunev wrote: > The idea is that all other virtio devices are calling this helper > to merge properties of the proxy device. This is the only difference > in between this helper and code in inside virtio_instance_init_common. > The patch should not

Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-02-19 Thread Denis V. Lunev
On 19/02/15 12:25, Michael S. Tsirkin wrote: On Thu, Jan 29, 2015 at 05:24:41PM +0300, Denis V. Lunev wrote: The idea is that all other virtio devices are calling this helper to merge properties of the proxy device. This is the only difference in between this helper and code in inside virtio_ins

Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-02-19 Thread Michael S. Tsirkin
On Thu, Feb 19, 2015 at 12:36:37PM +0300, Denis V. Lunev wrote: > On 19/02/15 12:25, Michael S. Tsirkin wrote: > >On Thu, Jan 29, 2015 at 05:24:41PM +0300, Denis V. Lunev wrote: > >>The idea is that all other virtio devices are calling this helper > >>to merge properties of the proxy device. This i

Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-02-19 Thread Denis V. Lunev
On 19/02/15 12:39, Michael S. Tsirkin wrote: On Thu, Feb 19, 2015 at 12:36:37PM +0300, Denis V. Lunev wrote: On 19/02/15 12:25, Michael S. Tsirkin wrote: On Thu, Jan 29, 2015 at 05:24:41PM +0300, Denis V. Lunev wrote: The idea is that all other virtio devices are calling this helper to merge p

Re: [Qemu-devel] [PATCH] KVM: s390: Add MEMOP ioctls for reading/writing guest memory

2015-02-19 Thread Cornelia Huck
On Mon, 16 Feb 2015 13:16:41 +0100 Thomas Huth wrote: > On s390, we've got to make sure to hold the IPTE lock while accessing > logical memory. So let's add an ioctl for reading and writing logical > memory to provide this feature for userspace, too. > > Signed-off-by: Thomas Huth > --- > Docu

Re: [Qemu-devel] [PATCH] KVM: s390: Add MEMOP ioctls for reading/writing guest memory

2015-02-19 Thread Thomas Huth
On Thu, 19 Feb 2015 10:47:29 +0100 Cornelia Huck wrote: > On Mon, 16 Feb 2015 13:16:41 +0100 > Thomas Huth wrote: > > > On s390, we've got to make sure to hold the IPTE lock while accessing > > logical memory. So let's add an ioctl for reading and writing logical > > memory to provide this feat

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-19 Thread Paolo Bonzini
On 18/02/2015 22:09, Programmingkid wrote: > + # Take an image and make the image its own icon: > + sips -i ../pc-bios/qemu-nsis.ico > + # Extract the icon to its own resource file: > + DeRez -only icns ../pc-bios/qemu-nsis.ico > tmpicns.rsrc IIUC sips modifies ../pc-bios/qemu-ns

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

2015-02-19 Thread Paolo Bonzini
On 19/02/2015 04:45, Peter Maydell wrote: > > I think it's quite likely that we'll use them, or at least ioh3420, on > > any PCIe machine. So you probably want to add ioh3420 to arm-softmmu > > and aarch64-softmmu as well. I don't know about i82801b11, but it > > doesn't hurt to have it in ARM/

Re: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END

2015-02-19 Thread Cornelia Huck
On Thu, 12 Feb 2015 15:53:49 +0100 Jens Freimann wrote: > On Thu, Feb 12, 2015 at 02:41:15PM +, Peter Maydell wrote: > > On 12 February 2015 at 13:08, Jens Freimann > > wrote: > > > We have defines for VIRTIO_TRANSPORT_F_START/_END in two places. > > > In include/hw/virtio/virtio.h and in l

[Qemu-devel] [PATCH] qapi-types: add C99 index names to arrays

2015-02-19 Thread Michael S. Tsirkin
It's not easy to figure out how monitor translates strings: most QEMU code deals with translated indexes, these are translated using _lookup arrays, so you need to find the array name, and find the appropriate offset. This patch adds C99 indexes to lookup arrays, which makes it possible to find th

Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-02-19 Thread Michael S. Tsirkin
On Thu, Feb 19, 2015 at 12:46:34PM +0300, Denis V. Lunev wrote: > On 19/02/15 12:39, Michael S. Tsirkin wrote: > >On Thu, Feb 19, 2015 at 12:36:37PM +0300, Denis V. Lunev wrote: > >>On 19/02/15 12:25, Michael S. Tsirkin wrote: > >>>On Thu, Jan 29, 2015 at 05:24:41PM +0300, Denis V. Lunev wrote: > >

Re: [Qemu-devel] [PATCH 1/2] target-mips: replace cpu_save/cpu_load with VMStateDescription

2015-02-19 Thread Leon Alrae
Hi, On 18/02/2015 16:59, Andreas Färber wrote: > Hi Leon, > > Am 18.02.2015 um 15:51 schrieb Leon Alrae: >> Create VMStateDescription for MIPS CPU. The new structure contains exactly >> the >> same fields as before, therefore leaving existing version_id. >> >> Signed-off-by: Leon Alrae >> --- >

Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-02-19 Thread Denis V. Lunev
On 19/02/15 13:17, Michael S. Tsirkin wrote: On Thu, Feb 19, 2015 at 12:46:34PM +0300, Denis V. Lunev wrote: On 19/02/15 12:39, Michael S. Tsirkin wrote: On Thu, Feb 19, 2015 at 12:36:37PM +0300, Denis V. Lunev wrote: On 19/02/15 12:25, Michael S. Tsirkin wrote: On Thu, Jan 29, 2015 at 05:24:

Re: [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit

2015-02-19 Thread Dr. David Alan Gilbert
* Michael Tokarev (m...@tls.msk.ru) wrote: > Do not check for rdma->host being empty twice. This removes a large > "if" block, so code indentation is changed. While at it, remove an > ugly goto from the loop, replacing it with a cleaner if logic. And > finally, there's no need to initialize `ret

Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-02-19 Thread Michael S. Tsirkin
On Thu, Feb 19, 2015 at 01:23:03PM +0300, Denis V. Lunev wrote: > >The problem is code duplication: all transports need to know > >about these balloon-specific property. > >Why isn't it handled by virtio_instance_init_common? > > > why it should? > > virtio_instance_init_common is common for all v

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

2015-02-19 Thread Michael S. Tsirkin
On Thu, Feb 19, 2015 at 04:20:36PM +1100, David Gibson wrote: > > On Thu, Feb 19, 2015 at 12:45:23PM +0900, Peter Maydell wrote: > > On 18 February 2015 at 16:57, Paolo Bonzini wrote: > > > On 18/02/2015 05:59, David Gibson wrote: > > >> that are very unlikely to appear on anything other than > >

[Qemu-devel] bus_unparent() can go into infinite loop

2015-02-19 Thread Markus Armbruster
Reproducer (don't ask): $ qemu-system-arm -M virt -S -display none -drive if=scsi,id=foo,bus=1,file=tmp.qcow2 -device nec-usb-xhci -device usb-storage,drive=foo -device virtio-scsi-pci qemu-system-arm: -drive if=scsi,id=foo,bus=1,file=tmp.qcow2: Property 'scsi-disk.drive' can't take val

Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init

2015-02-19 Thread Cornelia Huck
On Thu, 19 Feb 2015 11:29:27 +0100 "Michael S. Tsirkin" wrote: > On Thu, Feb 19, 2015 at 01:23:03PM +0300, Denis V. Lunev wrote: > > >The problem is code duplication: all transports need to know > > >about these balloon-specific property. > > >Why isn't it handled by virtio_instance_init_common?

Re: [Qemu-devel] [PATCH] target-mips: fix CP0.BadVAddr by stopping translation on Address error

2015-02-19 Thread Leon Alrae
On 28/01/2015 00:39, Maciej W. Rozycki wrote: > On Mon, 26 Jan 2015, Leon Alrae wrote: > >> BadVAddr is supposed to capture the most recent address that caused >> the exception. Currently this is not happening as translation is not stopped >> and BadVAddr is updated with subsequent addresses. >> >

[Qemu-devel] [PATCH v3 1/3] Add -incoming defer

2015-02-19 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" -incoming defer causes qemu to wait for an incoming migration to be specified later. The monitor can be used to set migration capabilities that may affect the incoming connection process. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela --- migr

[Qemu-devel] [PATCH v3 0/3] -incoming defer

2015-02-19 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This patchset provides a way of setting options on an incoming migration before the fd/process/socket has been created. start qemu with -incoming defer migrate_incoming theuri v3: s/pause/defer/ (and associated fixups) Add ' around the '-incoming

[Qemu-devel] [PATCH v3 2/3] Add migrate_incoming

2015-02-19 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add migrate_incoming/migrate-incoming to start an incoming migration. Once a qemu has been started with -incoming defer the migration can be started by issuing: migrate_incoming uri Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake --- hmp-

[Qemu-devel] [PATCH v3 3/3] Document -incoming options

2015-02-19 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Document the various URI formats for -incoming, the previous manpage and help text was wrong (out of date?) Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela --- qemu-options.hx | 29 ++--- 1 file changed, 26 insertions(+),

Re: [Qemu-devel] [PATCH RFC v3 05/14] block: add meta bitmaps

2015-02-19 Thread Vladimir Sementsov-Ogievskiy
On 19.02.2015 02:45, John Snow wrote: On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: Meta bitmap is a 'dirty bitmap' for the BdrvDirtyBitmap. It tracks changes (set/unset) of this BdrvDirtyBitmap. It is needed for live migration of block dirty bitmaps. Signed-off-by: Vladimir Sem

Re: [Qemu-devel] [RFC] net: 'Remove vhostforce option in addition to vhost param'

2015-02-19 Thread Pankaj Gupta
Hi, Could you please help/guide me here. As suggested by Jason I did other changes also. But when I did testing still virtio-net.c functions like 'receive()' gets called when vhost is 'ON'. I want to know is there anything I am missing here or is this expected behaviour? I was also searching

Re: [Qemu-devel] [Fwd: [PATCH v2] vpc: Implement bdrv_co_get_block_status()]

2015-02-19 Thread Kevin Wolf
Am 18.02.2015 um 22:03 hat Peter Lieven geschrieben: > Am 18.02.2015 um 21:57 schrieb Peter Lieven: > > This implements bdrv_co_get_block_status() for VHD images. This can > > significantly speed up qemu-img convert operation because only with this > > function implemented sparseness can be conside

[Qemu-devel] [PATCH] target-arm: modifying pc in tcg code for load/store multiple

2015-02-19 Thread ild
From: Ildar Isaev pc wasn't modified in tcg code for load/store multiple, causing translation block to be executed in infinite loop forever Signed-off-by: Ildar Isaev --- target-arm/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate.c b/target-

Re: [Qemu-devel] bus_unparent() can go into infinite loop

2015-02-19 Thread Andreas Färber
Am 19.02.2015 um 11:45 schrieb Markus Armbruster: > Reproducer (don't ask): > > $ qemu-system-arm -M virt -S -display none -drive > if=scsi,id=foo,bus=1,file=tmp.qcow2 -device nec-usb-xhci -device > usb-storage,drive=foo -device virtio-scsi-pci > qemu-system-arm: -drive if=scsi,id=foo,bu

[Qemu-devel] [PATCH] target-arm: always use user mode registers as operands for load/store multiple

2015-02-19 Thread Ildar Isaev
Pseudocode fragment for STM instruction in ARMv8 spec: if registers == '1' then // Store User mode register MemA[address,4] = Rmode[i, M32_User]; Signed-off-by: Ildar Isaev --- target-arm/translate.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/target-a

Re: [Qemu-devel] bus_unparent() can go into infinite loop

2015-02-19 Thread Markus Armbruster
Andreas Färber writes: > Am 19.02.2015 um 11:45 schrieb Markus Armbruster: >> Reproducer (don't ask): >> >> $ qemu-system-arm -M virt -S -display none -drive >> if=scsi,id=foo,bus=1,file=tmp.qcow2 -device nec-usb-xhci -device >> usb-storage,drive=foo -device virtio-scsi-pci >> qemu-syste

Re: [Qemu-devel] [PATCH] target-arm: always use user mode registers as operands for load/store multiple

2015-02-19 Thread Peter Maydell
On 19 February 2015 at 21:55, Ildar Isaev wrote: > Pseudocode fragment for STM instruction in ARMv8 spec: > > if registers == '1' then // Store User mode register > MemA[address,4] = Rmode[i, M32_User]; Again, do you have an example of the code that we mishandle and what we get wrong? thanks

Re: [Qemu-devel] [PATCH] target-arm: modifying pc in tcg code for load/store multiple

2015-02-19 Thread Peter Maydell
On 19 February 2015 at 21:26, wrote: > From: Ildar Isaev > > pc wasn't modified in tcg code for load/store multiple, > causing translation block to be executed in infinite loop forever > > Signed-off-by: Ildar Isaev It would be helpful if you gave an example of guest code which we mishandle. D

Re: [Qemu-devel] [PATCH RFC v3 08/14] migration: add migration/block-dirty-bitmap.c

2015-02-19 Thread Vladimir Sementsov-Ogievskiy
On 19.02.2015 02:47, John Snow wrote: On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: Live migration of dirty bitmaps. Only named dirty bitmaps, associated with root nodes and non-root named nodes are migrated. If destination qemu is already containing a dirty bitmap with the sa

[Qemu-devel] [PATCH] pc: acpi: get rid of IASL warnings in MCRS method

2015-02-19 Thread Igor Mammedov
Newer IASL produces a bunch of false warnings like: ,, MW32, AddressRangeMemory, TypeStatic) Object is not referenced ^ (Name is within method [MCRS]) Caused by local integer constant name DescriptorName in DWordMemory resource macro, it appears that compiler creates a name fo

Re: [Qemu-devel] [PATCH v7 11/25] qcow2: refcount_order parameter for qcow2_create2

2015-02-19 Thread Max Reitz
On 2015-02-18 at 21:51, Eric Blake wrote: On 02/18/2015 03:40 PM, Max Reitz wrote: Add a refcount_order parameter to qcow2_create2(), use that value for the image header and for calculating the size required for preallocation. For now, always pass 4. This addition requires changes to the calcu

Re: [Qemu-devel] [PATCH 2/3] coroutine: Clean up qemu_coroutine_enter()

2015-02-19 Thread Stefan Hajnoczi
On Wed, Feb 18, 2015 at 03:20:26PM +0100, Kevin Wolf wrote: > Am 18.02.2015 um 14:50 hat Stefan Hajnoczi geschrieben: > > On Tue, Feb 10, 2015 at 11:41:27AM +0100, Kevin Wolf wrote: > > > qemu_coroutine_enter() is now the only user of coroutine_swap(). Both > > > functions are short, so inline it.

Re: [Qemu-devel] [RFC] net: 'Remove vhostforce option in addition to vhost param'

2015-02-19 Thread Michael S. Tsirkin
On Thu, Feb 19, 2015 at 07:02:43AM -0500, Pankaj Gupta wrote: > Hi, > > Could you please help/guide me here. As suggested by Jason I did other > changes also. > But when I did testing still virtio-net.c functions like 'receive()' gets > called when vhost is 'ON'. > > I want to know is there any

[Qemu-devel] [Bug 1423528] [NEW] setting unsupported timeout for i6300esb watchdog causes hw reset

2015-02-19 Thread Michael Biebl
Public bug reported: Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778291 Version: 2.1 systemd utilizes existing watchdog hardware and set's a 10min timer on reboot. The i6300esb under qemu doesn't like such a timeout, and immediately resets the hardware: The last message one ge

Re: [Qemu-devel] [PATCH 1/2] qemu-img convert: Rewrite copying logic

2015-02-19 Thread Kevin Wolf
Am 18.02.2015 um 18:18 hat Max Reitz geschrieben: > On 2015-02-18 at 10:19, Kevin Wolf wrote: > >The implementation of qemu-img convert is (a) messy, (b) buggy, and > >(c) less efficient than possible. The changes required to beat some > >sense into it are massive enough that incremental changes wo

Re: [Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP in VMState

2015-02-19 Thread Richard Henderson
On 02/18/2015 06:51 AM, Leon Alrae wrote: > static VMStateField vmstate_fpu_fields[] = { > VMSTATE_FPR_ARRAY(fpr, CPUMIPSFPUContext, 32), > -VMSTATE_INT8(fp_status.float_detect_tininess, CPUMIPSFPUContext), > +VMSTATE_UINT8(fp_status.flush_to_zero, CPUMIPSFPUContext), > VMSTATE_I

Re: [Qemu-devel] [PATCH] qapi-types: add C99 index names to arrays

2015-02-19 Thread Eric Blake
On 02/19/2015 03:13 AM, Michael S. Tsirkin wrote: > It's not easy to figure out how monitor translates > strings: most QEMU code deals with translated indexes, > these are translated using _lookup arrays, > so you need to find the array name, and find the > appropriate offset. > > This patch adds

Re: [Qemu-devel] bus_unparent() can go into infinite loop

2015-02-19 Thread Paolo Bonzini
On 19/02/2015 14:05, Markus Armbruster wrote: > Andreas Färber writes: > >> Am 19.02.2015 um 11:45 schrieb Markus Armbruster: >>> Reproducer (don't ask): >>> >>> $ qemu-system-arm -M virt -S -display none -drive >>> if=scsi,id=foo,bus=1,file=tmp.qcow2 -device nec-usb-xhci -device >>> usb-st

Re: [Qemu-devel] [PATCH] target-arm: modifying pc in tcg code for load/store multiple

2015-02-19 Thread Ildar Isaev
> On 19 February 2015 at 21:26, wrote: > > From: Ildar Isaev > > > > pc wasn't modified in tcg code for load/store multiple, > > causing translation block to be executed in infinite loop forever > > > > Signed-off-by: Ildar Isaev > > It would be helpful if you gave an example of guest > cod

Re: [Qemu-devel] [PATCH 1/2] qemu-img convert: Rewrite copying logic

2015-02-19 Thread Max Reitz
On 2015-02-19 at 10:47, Kevin Wolf wrote: Am 18.02.2015 um 18:18 hat Max Reitz geschrieben: [snip] Actually, now that I'm looking at is_allocated_sectors_min(), if the first sectors is not allocated, it will return false and thus both the current qemu-img convert and the new one after this pa

[Qemu-devel] [PATCH] scsi: give device a parent before setting properties

2015-02-19 Thread Paolo Bonzini
This mimics what is done in qdev_device_add, and lets the device be freed in case something goes wrong. Otherwise, object_unparent returns immediately without freeing the device, which is on the other hand left in the parent bus's list of children. scsi_bus_legacy_handle_cmdline then returns an e

Re: [Qemu-devel] [PATCH v3 0/2] block, virtio-scsi: Fix blk_set_aio_context

2015-02-19 Thread Paolo Bonzini
On 15/02/2015 04:06, Fam Zheng wrote: > This is the simplified fix of: > > [PATCH 0/3] virtio-scsi: Fix unsafe bdrv_set_aio_context calls > > I included the original patch 1 - the function header comment update for > bdrv_set_aio_context and added Paolo's rev-by. > > Fam Zheng (2): > block:

Re: [Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP in VMState

2015-02-19 Thread Leon Alrae
On 19/02/2015 15:43, Richard Henderson wrote: > On 02/18/2015 06:51 AM, Leon Alrae wrote: >> static VMStateField vmstate_fpu_fields[] = { >> VMSTATE_FPR_ARRAY(fpr, CPUMIPSFPUContext, 32), >> -VMSTATE_INT8(fp_status.float_detect_tininess, CPUMIPSFPUContext), >> +VMSTATE_UINT8(fp_status

Re: [Qemu-devel] [PATCH] scsi: give device a parent before setting properties

2015-02-19 Thread Markus Armbruster
Paolo Bonzini writes: > This mimics what is done in qdev_device_add, and lets the device be > freed in case something goes wrong. Otherwise, object_unparent returns > immediately without freeing the device, which is on the other hand left > in the parent bus's list of children. > > scsi_bus_lega

[Qemu-devel] [PATCH 2/5] ui: Removed unused functions

2015-02-19 Thread Thomas Huth
Remove qemu_console_displaystate(), qemu_remove_kbd_event_handler(), qemu_different_endianness_pixelformat() and cpkey(), since they are completely unused. Signed-off-by: Thomas Huth Cc: Anthony Liguori Cc: Gerd Hoffmann --- include/ui/console.h |3 --- ui/console.c | 12

[Qemu-devel] [PATCH 3/5] ui/vnc: Remove vnc_stop_worker_thread()

2015-02-19 Thread Thomas Huth
This function is not used anymore, let's remove it. Signed-off-by: Thomas Huth Cc: Anthony Liguori Cc: Gerd Hoffmann --- ui/vnc-jobs.c | 13 - ui/vnc-jobs.h |1 - 2 files changed, 0 insertions(+), 14 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 68f3d77..c8ee

[Qemu-devel] [PATCH 1/5] migration: Remove unused functions

2015-02-19 Thread Thomas Huth
dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(), migrate_rdma_pin_all(), qsb_clone() and qsb_set_length() are completely unused and thus can be deleted. Signed-off-by: Thomas Huth Cc: Juan Quintela Cc: Amit Shah --- arch_init.c | 10 --- include/migration/m

[Qemu-devel] [PATCH 5/5] xen: Remove xen_cmos_set_s3_resume()

2015-02-19 Thread Thomas Huth
The function is not used anymore, and thus can be deleted. Signed-off-by: Thomas Huth Cc: Stefano Stabellini --- include/hw/xen/xen.h |1 - xen-hvm-stub.c |4 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h index b0ed

[Qemu-devel] [PATCH 4/5] util: Remove unused functions

2015-02-19 Thread Thomas Huth
Delete the unused functions qemu_signalfd_available(), qemu_send_full() and qemu_recv_full(). Signed-off-by: Thomas Huth Cc: Markus Armbruster --- include/qemu-common.h |4 --- include/qemu/compatfd.h |1 - util/compatfd.c | 19 - util/osdep.c| 66 -

[Qemu-devel] [PATCH v2 0/5] Remove unused functions

2015-02-19 Thread Thomas Huth
There are quite a lot of completely unused functions scattered around in the QEMU sources - here are some patches to remove at least some of them. v2: - Incorporated review feedback to keep the functions that still might be usefull (e.g. dropped the patch to remove unused functions in the bloc

Re: [Qemu-devel] [PATCH v4 0/5] libqos: Virtio MMIO driver

2015-02-19 Thread Kevin Wolf
Am 18.02.2015 um 18:07 hat Stefan Hajnoczi geschrieben: > On Fri, Jan 23, 2015 at 05:38:48PM +0100, Marc Marí wrote: > > Add virtio-mmio support to libqos and test case for virtio-blk. > > > > Changes for version 3: > > - Fix leaks and minor bugs > > - Extract basic test case to a function > >

Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-19 Thread Denis V. Lunev
On 17/02/15 20:59, Eric Blake wrote: On 02/17/2015 10:56 AM, Michael Roth wrote: In any case, since I was actually the one who re-invented it, and this code just moves it to another function, I think we can address it as a seperate patch and leave the PULL intact (unless there are other objectio

[Qemu-devel] [PATCH v2 1/2] integrator/cp: Model CP control registers as sysbus device

2015-02-19 Thread Jan Kiszka
No new features yet, just encapsulation. Signed-off-by: Jan Kiszka --- hw/arm/integratorcp.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c index 8c48b68..c5aa1f6 100644 --- a/hw/arm/i

[Qemu-devel] [PATCH v2 0/2] integrator/cp: Working SD card support

2015-02-19 Thread Jan Kiszka
This addresses the review comments on the primitive first version. Jan Jan Kiszka (2): integrator/cp: Model CP control registers as sysbus device integrator/cp: Implement CARDIN and WPROT signals hw/arm/integratorcp.c | 99 --- 1 file changed,

[Qemu-devel] [PATCH v2 2/2] integrator/cp: Implement CARDIN and WPROT signals

2015-02-19 Thread Jan Kiszka
This allows to use the SD card emulation of the board: Forward the signals from the pl181 top the CP control register emulation, report the current state via CP_INTREG, deliver CARDIN IRQ to the secondary interrupt controller and also support clearing that line via CP_INTREG. Signed-off-by: Jan Ki

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-19 Thread Pierre Schweitzer
Thanks Max & Stefan. Could you please let me know when the commit makes it to the QEMU repository? And give me its commit ID? So that I can ask for a bugfix backport in Trusty. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:/

Re: [Qemu-devel] [PATCH RFC v3 11/14] iotests: add dirty bitmap migration test

2015-02-19 Thread John Snow
On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b with dirty bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iote

Re: [Qemu-devel] [PATCH RFC v3 12/14] qapi: add md5 checksum of last dirty bitmap level to query-block

2015-02-19 Thread John Snow
On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c| 1 + include/qemu/hbitmap.h | 8 qapi/block-core.json | 4 +++- util/hbitmap.c | 8 4 files changed, 20 insertions(+), 1 deleti

[Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-19 Thread Radim Krčmář
Window 8.0 driver has a particular behavior for a small time frame after it enables rx interrupts: the interrupt handler never clears E1000_ICR_RXT0. The handler does this something like this: set_imc(-1) (1) disable all interrupts val = read_icr() (2) clear ICR handl

Re: [Qemu-devel] [PATCH RFC v3 13/14] iotests: add dirty bitmap migration test

2015-02-19 Thread John Snow
On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: [the same test as 117, but not using qmp: query-block-dirty-bitmap. only one test from {117, 118} will be in the next patch set version] The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-19 Thread Programmingkid
On Feb 19, 2015, at 4:56 AM, Paolo Bonzini wrote: > > > On 18/02/2015 22:09, Programmingkid wrote: >> +# Take an image and make the image its own icon: >> +sips -i ../pc-bios/qemu-nsis.ico >> +# Extract the icon to its own resource file: >> +DeRez -only icns ../pc-bios/qemu-nsis

Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang

2015-02-19 Thread Radim Krčmář
2015-02-19 20:24+0100, Radim Krčmář: > diff --git a/hw/net/e1000.c b/hw/net/e1000.c > @@ -138,6 +138,10 @@ typedef struct E1000State_st { > +#define E1000_WIN8_WORKAROUND_ICR E1000_ICR_RXT0 > +#define E1000_WIN8_WORKAROUND_DELAY_US 10 > +bool win8_workaround_needed; > @@ -288,7 +292,7 @@

[Qemu-devel] [PATCH 00/11] target-aarch64 fix and improvments

2015-02-19 Thread Richard Henderson
While doing the mechanics of a previous patch set converting translators to use to TCGLabel pointers, I was reminded of several outstanding OPTME comments in the aarch64 translator. I had started with the csel change, which at first failed and took quite some time to debug. See the comment for pa

[Qemu-devel] [PATCH 03/11] target-arm: Handle always condition codes within arm_test_cc

2015-02-19 Thread Richard Henderson
Handling this with TCG_COND_ALWAYS will allow these unlikely cases to be handled without special cases in the rest of the translator. The TCG optimizer ought to be able to reduce these ALWAYS conditions completely. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 9 + t

[Qemu-devel] [PATCH 01/11] target-arm: Introduce DisasCompare

2015-02-19 Thread Richard Henderson
Splitting arm_gen_test_cc into 3 functions, so that it can be reused for non-branch TCG comparisons. Note that this is also a bug fix for aarch64. At present, we have branches using the 32-bit (translate.c) versions of cpu_[NZCV]F, but we set the flags using the 64-bit (translate-a64.c) versions

[Qemu-devel] [PATCH 04/11] target-arm: Recognize SXTB, SXTH, SXTW, ASR

2015-02-19 Thread Richard Henderson
... as aliases of SBFM, and special-case them. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 219e257..0cb60a2 100644 --- a/

[Qemu-devel] [PATCH 05/11] target-arm: Recognize UXTB, UXTH, LSR, LSL

2015-02-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 17 + 1 file changed, 17 insertions(+) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 0cb60a2..54290ad 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -3057,6

[Qemu-devel] [PATCH 06/11] target-arm: Eliminate unnecessary zero-extend in disas_bitfield

2015-02-19 Thread Richard Henderson
For !SF, this initial ext32u can't be optimized away by the current TCG code generator. (It would require backward bit liveness propagation.) But since the range of bits for !SF are already constrained by unallocated_encoding, we'll never reference the high bits anyway. Signed-off-by: Richard He

[Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp branchless

2015-02-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 50 +++--- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 8171a1f..5539ae3 100644 --- a/target-arm/translate-a64

[Qemu-devel] [PATCH 09/11] target-arm: Implement ccmp branchless

2015-02-19 Thread Richard Henderson
This can allow much of a ccmp to be elided when particular flags are subsequently dead. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 62 ++ 1 file changed, 41 insertions(+), 21 deletions(-) diff --git a/target-arm/translate-a64.c

[Qemu-devel] [PATCH 02/11] target-arm: Extend NZCF to 64 bits

2015-02-19 Thread Richard Henderson
The resulting aarch64 translation is a bit cleaner. Sign-extending from 32-bits is simpler than having to use setcond to narrow from 64-bits. Signed-off-by: Richard Henderson --- target-arm/cpu.h | 21 ++-- target-arm/helper.c| 18 ++- target-arm/translate-a64.c | 297 +++

[Qemu-devel] [PATCH 07/11] target-arm: Recognize ROR

2015-02-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index ed97ed6..d139b2d 100644 --- a/target-arm/translate-a64.c +++ b/targ

[Qemu-devel] [PATCH 08/11] target-arm: Use setcond and movcond for csel

2015-02-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 60 +++--- 1 file changed, 24 insertions(+), 36 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index d139b2d..7549267 100644 --- a/target-arm/translate-a64

[Qemu-devel] [PATCH 11/11] target-arm: Implement fcsel with movcond

2015-02-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 48 -- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 5539ae3..1302cec 100644 --- a/target-arm/translate-a64

[Qemu-devel] [PATCH] target-cris: Use movcond and setcond

2015-02-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-cris/translate.c | 27 +++ target-cris/translate_v10.c | 12 ++-- 2 files changed, 9 insertions(+), 30 deletions(-) --- Note that this is relative to an outstanding TCG patch set. The full tree is at git://github.c

[Qemu-devel] [PATCH] target-microblaze: Use setcond for pcmp*

2015-02-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-microblaze/translate.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) --- Note that this is relative to an outstanding TCG patch set. The full tree is at git://github.com/rth7680/qemu.git mb-movcond r~ --- diff --gi

[Qemu-devel] [Bug 1423668] [NEW] Unable to set scsi drive serial if it contains spaces.

2015-02-19 Thread Alan Latteri
Public bug reported: I am virtualzing a physical server for which I need to set the SCSI/SATA drive serial. It is comprised of 12 " " spaces then 8 letter/digits. If I exclude the spaces, the drive serial is not accurate. If I include the spaces I get the following error. error: Failed to start

[Qemu-devel] unable to set SATA serial with a spaces

2015-02-19 Thread Alan Latteri
I am virtualzing a physical server for which I need to set the SCSI/SATA drive serial. It is comprised of 12 " " spaces then 8 letter/digits. If I exclude the spaces, the drive serial is not accurate. If I include the spaces I get the following error. error: Failed to start domain test1 error:

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-19 Thread John Snow
On 02/19/2015 02:48 PM, Alan Latteri wrote: I am virtualzing a physical server for which I need to set the SCSI/SATA drive serial. It is comprised of 12 " " spaces then 8 letter/digits. If I exclude the spaces, the drive serial is not accurate. If I include the spaces I get the following error.

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-19 Thread Alan Latteri
I have a software that I was able to virtualize on VirtualBox by setting the HD serial using the spaces easily. Using the same parameters minus the spaces with QEMU, the software will not license. Only different I can see is this. > On Feb 19, 2015, at 2:12 PM, John Snow wrote: > > > > On

Re: [Qemu-devel] [PATCH v18 1/2] sPAPR: Implement EEH RTAS calls

2015-02-19 Thread Gavin Shan
On Mon, Feb 16, 2015 at 04:32:09PM +1100, Gavin Shan wrote: >On Mon, Feb 16, 2015 at 12:52:48PM +1100, David Gibson wrote: >>On Mon, Feb 16, 2015 at 10:16:01AM +1100, Gavin Shan wrote: >>> The emulation for EEH RTAS requests from guest isn't covered >>> by QEMU yet and the patch implements them. >>

[Qemu-devel] [PATCH 3/8] libqos/ahci: add ahci command helpers

2015-02-19 Thread John Snow
ahci_command_set_flags: Set additional flags in the command header. ahci_command_clr_flags: Clear flags from the command header. ahci_command_set_offset: Change the IO sector from 0. ahci_command_adjust: Adjust many values simultaneously. To be used to adjust the command header if the defaul

[Qemu-devel] [PATCH 2/8] qtest/ahci: Add a macro bootup routine

2015-02-19 Thread John Snow
Add a routine that can be used to engage the AHCI device at a not-granular level so that bringing up the functionality of the HBA is easy in future tests that are not concerned with testing the bring-up process. Signed-off-by: John Snow --- tests/ahci-test.c | 23 +-- 1 file

[Qemu-devel] [PATCH 7/8] qtest/ahci: add qcow2 support to ahci-test

2015-02-19 Thread John Snow
This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. Signed-off-by: John Snow --- tests/ahci-test.c | 15 +-- tests/libqos/libqos.c | 30 ++ tests/libqos/libqos.h | 1 + 3 files chan

[Qemu-devel] [PATCH 8/8] qtest/ahci: test different disk sectors

2015-02-19 Thread John Snow
Test sector offset 0, 1, and the last sector(s) in LBA28 and LBA48 modes. Signed-off-by: John Snow --- tests/ahci-test.c | 69 +++-- tests/libqos/ahci.c | 10 tests/libqos/ahci.h | 4 ++-- 3 files changed, 64 insertions(+), 19 deletions

[Qemu-devel] [PATCH 6/8] qtest/ahci: add fragmented dma test

2015-02-19 Thread John Snow
Test what happens when we try to use extremely short PRDTs to accomplish a small data transfer. Signed-off-by: John Snow --- tests/ahci-test.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index

[Qemu-devel] [PATCH 1/8] libqos/ahci: Zero-fill AHCI headers

2015-02-19 Thread John Snow
Even though it's just the reserved space, make sure they're zeroes. Signed-off-by: John Snow --- tests/libqos/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index 170ec5a..6f6652c 100644 --- a/tests/libqos/ahci.c +++ b/tests/l

[Qemu-devel] [PATCH 0/8] ahci: add more IO tests

2015-02-19 Thread John Snow
This series is based on top of my ahci DMA test series, which is in turn based on the ahci preliminary refactoring series. Both are currently pending on stefanha/block. This series adds many variations that expand on the existing trivial DMA I/O case. These pathways check different PRDT configurat

[Qemu-devel] [PATCH 5/8] qtest/ahci: Add PIO and LBA48 tests

2015-02-19 Thread John Snow
In addition to DMA tests, test PIO and LBA48 command pathways in AHCI. To accomplish this, a primitive multiplexer for gtest is added. Though guests may prefer not to issue PIO commands directly except for single sector cases during early boot and shutdown, these pathways are still used for the tr

[Qemu-devel] [PATCH 4/8] qtest/ahci: Add DMA test variants

2015-02-19 Thread John Snow
These test a few different pathways in the AHCI code. short: Test the minimum transfer size, exactly one sector. simple: Test a transfer using a single PRD, in this case, 4K. double: Test transferring 8K, which we will split up as two PRDs. long: Test transferring a lot of data using many PRDs,

  1   2   >