Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-18 Thread Kevin Wolf
Am 17.02.2015 um 22:33 hat Max Reitz geschrieben: > Concurrently modifying the bmap is not a good idea; Why? I mean, the fact that this fixes something for you probably means that there really is some piece of local state that is invalidated by concurrent writes, but it's not obvious to me what it

Re: [Qemu-devel] [PATCH v3 23/52] pc: acpi-build: drop unsupported PM1b_CNT.SLP_TYP

2015-02-18 Thread Michael S. Tsirkin
On Wed, Feb 18, 2015 at 11:03:47AM +0100, Igor Mammedov wrote: > On Tue, 17 Feb 2015 17:41:03 +0100 > "Michael S. Tsirkin" wrote: > > > On Mon, Feb 09, 2015 at 10:53:45AM +, Igor Mammedov wrote: > > > QEMU doesn't implement/advertize PM1b_CNT_BLK > > > register block so do not set/patch its \

Re: [Qemu-devel] [RFC PATCH v9 04/23] replay: internal functions for replay log

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > This patch adds functions to perform read and write operations > with replay log. > > Signed-off-by: Pavel Dovgalyuk > --- > replay/Makefile.objs |1 > replay/replay-internal.c | 143 > ++ > re

Re: [Qemu-devel] [RFC PATCH v9 08/23] cpu: replay instructions sequence

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > This patch adds calls to replay functions into the icount setup block. > In record mode number of executed instructions is written to the log. > In replay mode number of istructions to execute is taken from the replay log. So much better! If there i

[Qemu-devel] [PATCH] Makefile: fix up parallel building under MSYS+MinGW

2015-02-18 Thread Vasily Efimov
This patch enables parallel building of QEMU in MSYS+MinGW environment. Currently an attempt to build QEMU in parallel fails on generation of version.lo (and version.o too). The cause of the failure is that when listing prerequisites "Makefile" references "config-host.h" by absolute path in some r

Re: [Qemu-devel] [RFC PATCH v9 12/23] timer: replace time() with QEMU_CLOCK_HOST

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > This patch replaces time() function calls with calls to > qemu_clock_get_ns(QEMU_CLOCK_HOST). It makes such requests deterministic > in record/replay mode of icount. > > Signed-off-by: Pavel Dovgalyuk Reviewed-by: Paolo Bonzini > --- > vl.c |

Re: [Qemu-devel] [RFC PATCH v9 15/23] aio: replace stack of bottom halves with queue

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > +QSIMPLEQ_FOREACH_SAFE(bh, &ctx->bh_queue, next, next) { > if (bh->deleted) { > -*bhp = bh->next; > +QSIMPLEQ_REMOVE(&ctx->bh_queue, bh, QEMUBH, next); QSIMPLEQ_REMOVE is very inefficient, so that

Re: [Qemu-devel] [RFC PATCH v9 15/23] aio: replace stack of bottom halves with queue

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > +#define QSIMPLEQ_INSERT_TAIL_RCU(head, elm, field) do { \ > +(elm)->field.sqe_next = NULL; \ Also, smp_wmb() goes here. My fault: in the previous review I wrote "smp_wmb() must be after the

Re: [Qemu-devel] [RFC PATCH v9 19/23] typedef: add typedef for QemuOpts

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > This patch moves typedefs for QemuOpts and related types > to qemu/typedefs.h file. > > Signed-off-by: Pavel Dovgalyuk > --- > include/qemu/option.h |5 + > include/qemu/typedefs.h |3 +++ > 2 files changed, 4 insertions(+), 4 deletio

Re: [Qemu-devel] [PATCH v3 47/52] pc: acpi-build: drop remaining ssdt_misc template and use acpi_def_block()

2015-02-18 Thread Michael S. Tsirkin
On Wed, Feb 18, 2015 at 11:09:04AM +0100, Igor Mammedov wrote: > On Tue, 17 Feb 2015 17:44:31 +0100 > "Michael S. Tsirkin" wrote: > > > On Mon, Feb 09, 2015 at 10:54:09AM +, Igor Mammedov wrote: > > > It completes dynamic SSDT generation and makes it > > > independed of IASL binary blobs. It

Re: [Qemu-devel] [RFC PATCH v9 20/23] replay: initialization and deinitialization

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > +void replay_init_timer(void) > +{ You can call this replay_start. > +fprintf(stderr, "Invalid icount rr option: %s\n", rr); > +exit(1); > +} > + > +fname = qemu_opt_get(opts, "rrfile"); > +if (!fname) { > +fprint

Re: [Qemu-devel] [RFC PATCH v9 22/23] replay: command line options

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > This patch introduces command line options for enabling recording or replaying > virtual machine behavior. "-record" option starts recording of the execution > and saves it into the log, specified with "fname" parameter. "-replay" option > is intended

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-18 Thread Ian Campbell
On Wed, 2015-02-11 at 10:45 +0800, Chen, Tiejun wrote: > On 2015/2/9 19:05, Ian Campbell wrote: > > On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: > > > >> What about this? > > > > I've not read the code in detail,since I'm travelling but from a quick > > glance it looks to be implementing

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-18 Thread Peter Lieven
Am 12.02.2015 um 22:01 schrieb Charles Arnold: On 2/12/2015 at 12:05 PM, Peter Lieven wrote: >> Am 12.02.2015 um 18:18 schrieb Charles Arnold : >> >> On 2/12/2015 at 03:23 AM, Kevin Wolf wrote: Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: >> Am 12.02.2015 um 11:06 schri

Re: [Qemu-devel] [RFC PATCH v9 08/23] cpu: replay instructions sequence

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > +if (replay_state.instructions_count == 0) { Please add an assertion that replay_data_kind is EVENT_INSTRUCTION, since you are consuming it below. > +replay_has_unread_data = 0; > +qemu_notify_event();

Re: [Qemu-devel] [RFC PATCH v9 06/23] replay: introduce icount event

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > +/* nothing to skip - not all instructions used */ > +if (replay_state.instructions_count != 0 > +&& replay_has_unread_data) { > +return stop_event == EVENT_INSTRUCTION; Same here, please assert that replay_data_kind == EVENT_

Re: [Qemu-devel] [PATCH 2/3] coroutine: Clean up qemu_coroutine_enter()

2015-02-18 Thread Stefan Hajnoczi
On Tue, Feb 10, 2015 at 11:41:27AM +0100, Kevin Wolf wrote: > qemu_coroutine_enter() is now the only user of coroutine_swap(). Both > functions are short, so inline it. > > Also, using COROUTINE_YIELD is now even more confusing because this code > is never called during qemu_coroutine_yield() any

Re: [Qemu-devel] [PATCH v3 04/52] acpi: factor out ACPI const int packing out of build_append_value()

2015-02-18 Thread Michael S. Tsirkin
On Wed, Feb 18, 2015 at 10:41:23AM +0100, Igor Mammedov wrote: > On Tue, 17 Feb 2015 20:53:52 +0100 > "Michael S. Tsirkin" wrote: > > > On Mon, Feb 09, 2015 at 10:53:26AM +, Igor Mammedov wrote: > > > it will be reused for adding a plain integer value into AML. > > > > > > Signed-off-by: Igo

Re: [Qemu-devel] [RFC PATCH v9 09/23] replay: interrupts and exceptions

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > +{ > +bool res = false; > +if (replay_mode == REPLAY_MODE_PLAY) { > +replay_account_executed_instructions(); > +replay_mutex_lock(); > +if (skip_async_events(EVENT_EXCEPTION)) { > +res = true; > +}

Re: [Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-18 Thread Stefan Hajnoczi
On Wed, Feb 18, 2015 at 09:11:57AM -, Pierre Schweitzer wrote: > Does that mean it can also affect VMs running with VDI disk(s)? Yes, that's what Max's example showed. Note that only raw, qcow2, and qed support in QEMU is designed for running guests. The other formats like vmdk and vdi are m

[Qemu-devel] [PATCH RFC v3 01/14] qmp: add query-block-dirty-bitmap

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Adds qmp and hmp commands to query/info dirty bitmap. This is needed only for testing. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 41 blockdev.c| 24 + hmp-commands.hx | 2 ++ hmp.c | 32

[Qemu-devel] [PATCH RFC v3 08/14] migration: add migration/block-dirty-bitmap.c

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Live migration of dirty bitmaps. Only named dirty bitmaps, associated with root nodes and non-root named nodes are migrated. If destination qemu is already containing a dirty bitmap with the same name as a migrated bitmap (for the same node), than, if their granularities are the same the migration

[Qemu-devel] [PATCH RFC v3 02/14] hbitmap: serialization

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions are appropriate for dirty bitmap migration, restoring the bitmap i

[Qemu-devel] [PATCH RFC v3 13/14] iotests: add dirty bitmap migration test

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
[the same test as 117, but not using qmp: query-block-dirty-bitmap. only one test from {117, 118} will be in the next patch set version] The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b with dirty bi

[Qemu-devel] [PATCH RFC v3 09/14] iotests: maintain several vms in test

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
The only problem with it is the same qmp socket name (which is vm._monitor_path) for all vms. And because of this second vm couldn't be lauched (vm.launch() fails because of socket is already in use). This patch adds a number of vm into vm._monitor_path Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH RFC v3 03/14] block: BdrvDirtyBitmap serialization interface

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 36 include/block/block.h | 13 + 2 files changed, 49 insertions(+) diff --git a/block.

[Qemu-devel] [PATCH RFC v3 06/14] block: add bdrv_next_dirty_bitmap()

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Like bdrv_next() - bdrv_next_dirty_bitmap() is a function to provide access to private dirty bitmaps list. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 10 ++ include/block/block.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block.c b/block.c inde

[Qemu-devel] [PATCH RFC v3 00/14] Dirty bitmaps migration

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
v3: based on v13 of "block: incremental backup series" by John Snow. changes from v2: removed patch for adding dirty parameter (migration capablities used instead). 0001: printf's dropped, qapi used 0002: part0 -> zeroes 0003: part0 -> zeroes 0005: dirty_dirty -> meta add comments

Re: [Qemu-devel] RFC RFC

2015-02-18 Thread Eric Blake
On 02/18/2015 01:10 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi > > Can anybody explain what the reasons, politics and consequences of > adding RFC into patch header in this mailing list? I think, it is not > worth to add this information to > http://wiki.qemu.org/Contribute/SubmitAPatch Peter's

Re: [Qemu-devel] RFC RFC

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
On 18.02.2015 17:01, Eric Blake wrote: On 02/18/2015 01:10 AM, Vladimir Sementsov-Ogievskiy wrote: Hi Can anybody explain what the reasons, politics and consequences of adding RFC into patch header in this mailing list? I think, it is not worth to add this information to http://wiki.qemu.org/Co

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-18 Thread Eric Blake
[meta-comment] On 02/18/2015 06:38 AM, Peter Lieven wrote: Am 09.02.2015 um 17:09 schrieb Kevin Wolf: > The CHS calculation as done per the VHD spec imposes a maximum That's a LOT of nested quoting. It's okay to trim your reply to cut out the portion of the thre

Re: [Qemu-devel] [RFC PATCH v9 11/23] replay: recording and replaying clock ticks

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > +void replay_read_next_clock(ReplayClockKind kind) This function is called like this: > +if (replay_file) { > +int64_t ret; > +replay_mutex_lock(); > +if (skip_async_events(EVENT_CLOCK + kind)) { > +replay_rea

Re: [Qemu-devel] [RFC PATCH v9 06/23] replay: introduce icount event

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > +/*! Skips async events until some sync event will be found. */ > +bool skip_async_events(int stop_event); > +/*! Skips async events invocations from the input, > +until required data kind is found. If the requested data is not found > +report

Re: [Qemu-devel] [RFC PATCH v9 14/23] replay: checkpoints

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > > + > +if (replay_file) { > +if (replay_mode == REPLAY_MODE_PLAY) { > +replay_mutex_lock(); > +if (!skip_async_events(EVENT_CHECKPOINT + checkpoint)) { > +if (replay_data_kind == EVENT_ASYNC) { > +

Re: [Qemu-devel] [RFC PATCH v9 09/23] replay: interrupts and exceptions

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > if (interrupt_request & CPU_INTERRUPT_POLL) { > cs->interrupt_request &= ~CPU_INTERRUPT_POLL; > apic_poll_irq(cpu->apic_state); > +/* Process one interrupt for a single call. > + In record/replay mode each call

Re: [Qemu-devel] [RFC PATCH v9 00/23] Deterministic replay core

2015-02-18 Thread Paolo Bonzini
On 18/02/2015 12:55, Pavel Dovgalyuk wrote: > This set of patches is related to the reverse execution and deterministic > replay of qemu execution. This implementation of deterministic replay can > be used for deterministic debugging of guest code through gdb remote > interface. > > These patc

Re: [Qemu-devel] [PATCH 2/3] coroutine: Clean up qemu_coroutine_enter()

2015-02-18 Thread Kevin Wolf
Am 18.02.2015 um 14:50 hat Stefan Hajnoczi geschrieben: > On Tue, Feb 10, 2015 at 11:41:27AM +0100, Kevin Wolf wrote: > > qemu_coroutine_enter() is now the only user of coroutine_swap(). Both > > functions are short, so inline it. > > > > Also, using COROUTINE_YIELD is now even more confusing beca

Re: [Qemu-devel] RFC RFC

2015-02-18 Thread Max Filippov
On Wed, Feb 18, 2015 at 5:10 PM, Vladimir Sementsov-Ogievskiy wrote: > On 18.02.2015 17:01, Eric Blake wrote: >> On 02/18/2015 01:10 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Can anybody explain what the reasons, politics and consequences of >>> adding RFC into patch header in this mailing list?

Re: [Qemu-devel] [PATCH v3 11/17] virtio-serial: switch to standard-headers

2015-02-18 Thread Thomas Huth
On Mon, 16 Feb 2015 22:36:26 +0100 "Michael S. Tsirkin" wrote: > Drop duplicate code. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/virtio/virtio-serial.h | 40 > +-- > hw/char/virtio-serial-bus.c | 1 + > 2 files changed, 2 insertions(+),

[Qemu-devel] [PATCH RFC v3 04/14] block: tiny refactoring: minimize hbitmap_(set/reset) usage

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index e95a5ae..a127fd2 100644 --- a/block.c +++ b/block.c @@ -5670,8 +5670,7 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, void bdrv_c

[Qemu-devel] [PATCH RFC v3 07/14] qapi: add dirty-bitmaps migration capability

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/migration/migration.h | 1 + migration/migration.c | 9 + qapi-schema.json | 5 - 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/include/migration/migration.h b/include/migration/migration.h i

[Qemu-devel] [PATCH RFC v3 12/14] qapi: add md5 checksum of last dirty bitmap level to query-block

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c| 1 + include/qemu/hbitmap.h | 8 qapi/block-core.json | 4 +++- util/hbitmap.c | 8 4 files changed, 20 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 4cca55d..9532ccc 100644 -

[Qemu-devel] [PATCH RFC v3 10/14] iotests: add add_incoming_migration to VM class

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index fa756b4..75640b2 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.

[Qemu-devel] [PATCH RFC v3 14/14] migration/qemu-file: make functions qemu_(get/put)_string public

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/migration/qemu-file.h | 17 + migration/block-dirty-bitmap.c | 35 --- migration/qemu-file.c | 18 ++ 3 files changed, 35 insertions(+), 35 deletions(-) diff --git a/

[Qemu-devel] [PATCH RFC v3 05/14] block: add meta bitmaps

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
Meta bitmap is a 'dirty bitmap' for the BdrvDirtyBitmap. It tracks changes (set/unset) of this BdrvDirtyBitmap. It is needed for live migration of block dirty bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 40 include/blo

Re: [Qemu-devel] [PATCH 1/3] PPC: Clean up misuse of qdev_init() in kvm-openpic creation

2015-02-18 Thread Markus Armbruster
Scott, can you review? Markus Armbruster writes: > We call ppce500_init_mpic_kvm() to create a "kvm-openpic". If it > fails, we call ppce500_init_mpic_qemu() to fall back to plain > "openpic". > > ppce500_init_mpic_kvm() uses qdev_init(). qdev_init()'s error > handling has an unwanted side eff

Re: [Qemu-devel] [PATCH 2/3] spapr: Clean up misuse of qdev_init() in xics-kvm creation

2015-02-18 Thread Markus Armbruster
David, your commit 11ad93f suggests you're highly qualified to review. No good deed shall go unpunished ;) Markus Armbruster writes: > We call try_create_xics() to create a "xics-kvm". If it fails, we > call it again to fall back to plain "xics". > > try_create_xics() uses qdev_init(). qdev_in

[Qemu-devel] [PATCH RFC v3 11/14] iotests: add dirty bitmap migration test

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b with dirty bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/117 | 88 ++

Re: [Qemu-devel] [PATCH 3/3] s390x: Replace unchecked qdev_init() by qdev_init_nofail()

2015-02-18 Thread Markus Armbruster
Connie, your commit 7b35d0c suggests you're highly qualified to review. No good deed shall go unpunished ;) Markus Armbruster writes: > s390_flic_init() is a helper to create and realize either > "s390-flic-kvm" or "s390-flic-qemu". When qdev_init() fails, it > complains to stderr and succeeds.

Re: [Qemu-devel] RFC RFC

2015-02-18 Thread Vladimir Sementsov-Ogievskiy
On 18.02.2015 17:01, Eric Blake wrote: On 02/18/2015 01:10 AM, Vladimir Sementsov-Ogievskiy wrote: Hi Can anybody explain what the reasons, politics and consequences of adding RFC into patch header in this mailing list? I think, it is not worth to add this information to http://wiki.qemu.org/Co

Re: [Qemu-devel] [PATCH v3 11/17] virtio-serial: switch to standard-headers

2015-02-18 Thread Michael S. Tsirkin
On Wed, Feb 18, 2015 at 03:34:13PM +0100, Thomas Huth wrote: > On Mon, 16 Feb 2015 22:36:26 +0100 > "Michael S. Tsirkin" wrote: > > > Drop duplicate code. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > include/hw/virtio/virtio-serial.h | 40 > > +-- >

Re: [Qemu-devel] [PATCH v3 03/17] virtio: use standard virtio_ring.h

2015-02-18 Thread Michael S. Tsirkin
On Tue, Feb 17, 2015 at 01:44:26PM +0100, Thomas Huth wrote: > On Mon, 16 Feb 2015 22:35:40 +0100 > "Michael S. Tsirkin" wrote: > > > Switch to virtio_ring.h from standard headers. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > include/hw/virtio/dataplane/vring.h | 2 +- > > include/h

[Qemu-devel] [Bug 1423124] [NEW] QEMU crash after sending data on host serial port

2015-02-18 Thread Ugo
Public bug reported: Good morning, I'm using QEMU for Windows last version. The host system is Windows 7 64bits. I'm excuting the following statment : qemu-system-x86_64w.exe -hda debian.img -m 256 -net nic -net tap,ifname=TAP32 -soundhw all -serial COM9 Qemu starts the emulated Debian and it r

Re: [Qemu-devel] [PATCH v3 02/17] include: import virtio headers from linux 4.0

2015-02-18 Thread Michael S. Tsirkin
On Tue, Feb 17, 2015 at 01:45:28PM +0100, Thomas Huth wrote: > On Mon, 16 Feb 2015 22:35:31 +0100 > "Michael S. Tsirkin" wrote: > > > Add files imported from linux-next (what will become linux 4.0) using > > scripts/update-linux-headers.sh > > > > Signed-off-by: Michael S. Tsirkin > > --- > >

[Qemu-devel] [PATCH 0/2] target-mips: port MIPS CPU to VMState

2015-02-18 Thread Leon Alrae
Hi, This small patchset converts MIPS CPU to use VMStateDescription: [1/2]: ports all the MIPS CPU fields to new VMStateDescription structure [2/2]: adds MSA and corrects FP state. These changes include ported Maciej's updates made for old cpu_load/cpu_save sent some time ago. I tested the

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-18 Thread Max Reitz
On 2015-02-18 at 07:39, Kevin Wolf wrote: Am 17.02.2015 um 22:33 hat Max Reitz geschrieben: Concurrently modifying the bmap is not a good idea; Why? I mean, the fact that this fixes something for you probably means that there really is some piece of local state that is invalidated by concurrent

[Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP in VMState

2015-02-18 Thread Leon Alrae
Correct the structure and store MSA and FP flush_to_zero. Signed-off-by: Leon Alrae --- target-mips/machine.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/target-mips/machine.c b/target-mips/machine.c index 8d75962..c08e593 100644 --- a/target-mips

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-18 Thread Max Reitz
On 2015-02-18 at 02:52, Paolo Bonzini wrote: On 17/02/2015 22:33, Max Reitz wrote: Concurrently modifying the bmap is not a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong without. Signed-off-by: Max Reitz --- block/vdi.c | 23

[Qemu-devel] [PATCH 1/2] target-mips: replace cpu_save/cpu_load with VMStateDescription

2015-02-18 Thread Leon Alrae
Create VMStateDescription for MIPS CPU. The new structure contains exactly the same fields as before, therefore leaving existing version_id. Signed-off-by: Leon Alrae --- target-mips/cpu-qom.h | 4 + target-mips/cpu.c | 1 + target-mips/cpu.h | 2 - target-mips/machine.c | 567

[Qemu-devel] [PATCH 0/2] qemu-img convert: Rewrite copying logic

2015-02-18 Thread Kevin Wolf
See the commit message of patch 1 for the background. Kevin Wolf (2): qemu-img convert: Rewrite copying logic qemu-iotests: Some qemu-img convert tests qemu-img.c | 511 +++-- tests/qemu-iotests/122 | 83 tests/qemu-iotest

[Qemu-devel] [PATCH 1/2] qemu-img convert: Rewrite copying logic

2015-02-18 Thread Kevin Wolf
The implementation of qemu-img convert is (a) messy, (b) buggy, and (c) less efficient than possible. The changes required to beat some sense into it are massive enough that incremental changes would only make my and the reviewers' life harder. So throw it away and reimplement it from scratch. Let

[Qemu-devel] [PATCH 2/2] qemu-iotests: Some qemu-img convert tests

2015-02-18 Thread Kevin Wolf
This adds a regression test for some problems that the qemu-img convert rewrite just fixed. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/122 | 83 ++ tests/qemu-iotests/122.out | 30 + tests/qemu-iotests/group | 1 + 3 files

Re: [Qemu-devel] [PATCH 3/3] s390x: Replace unchecked qdev_init() by qdev_init_nofail()

2015-02-18 Thread Cornelia Huck
On Wed, 18 Feb 2015 15:45:01 +0100 Markus Armbruster wrote: > Connie, your commit 7b35d0c suggests you're highly qualified to review. > No good deed shall go unpunished ;) Yeah, it has been on my todo list... > > Markus Armbruster writes: > > > s390_flic_init() is a helper to create and real

Re: [Qemu-devel] [PATCH v3 11/17] virtio-serial: switch to standard-headers

2015-02-18 Thread Thomas Huth
On Wed, 18 Feb 2015 15:55:54 +0100 "Michael S. Tsirkin" wrote: > On Wed, Feb 18, 2015 at 03:34:13PM +0100, Thomas Huth wrote: > > On Mon, 16 Feb 2015 22:36:26 +0100 > > "Michael S. Tsirkin" wrote: ... > > > diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c > > > index 47fbb3

Re: [Qemu-devel] [PATCH v3 11/17] virtio-serial: switch to standard-headers

2015-02-18 Thread Michael S. Tsirkin
On Wed, Feb 18, 2015 at 04:36:39PM +0100, Thomas Huth wrote: > On Wed, 18 Feb 2015 15:55:54 +0100 > "Michael S. Tsirkin" wrote: > > > On Wed, Feb 18, 2015 at 03:34:13PM +0100, Thomas Huth wrote: > > > On Mon, 16 Feb 2015 22:36:26 +0100 > > > "Michael S. Tsirkin" wrote: > ... > > > > diff --git a

[Qemu-devel] [PATCH 0/4] pulling virtio headers - minor fixes

2015-02-18 Thread Michael S. Tsirkin
This fixes minor issues reported by Thomas. Not really bugs so not respinning the series, to reduce list spam. Michael S. Tsirkin (4): update-linux-headers.sh: s/__inline__/inline/ virtio-serial-bus.c: drop virtio_ids.h standard-headers: include stdint.h virtio_ring.h: s/__inline__/inline/

[Qemu-devel] [PATCH 1/4] update-linux-headers.sh: s/__inline__/inline/

2015-02-18 Thread Michael S. Tsirkin
Thomas Huth noticed that some linux headers use __inline__, change to inline to be consistent with the rest of QEMU. Reported-by: Thomas Huth Signed-off-by: Michael S. Tsirkin --- scripts/update-linux-headers.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/update-linux-headers.sh

[Qemu-devel] [PATCH 4/4] virtio_ring.h: s/__inline__/inline/

2015-02-18 Thread Michael S. Tsirkin
Thomas Huth noticed that some linux headers use __inline__, change to inline to be consistent with the rest of QEMU. Reported-by: Thomas Huth Signed-off-by: Michael S. Tsirkin --- include/standard-headers/linux/virtio_ring.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --gi

[Qemu-devel] [PATCH 2/4] virtio-serial-bus.c: drop virtio_ids.h

2015-02-18 Thread Michael S. Tsirkin
virtio-serial.h pulls that in already. Reported-by: Thomas Huth Signed-off-by: Michael S. Tsirkin --- hw/char/virtio-serial-bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index ba4cf2e..9a029d2 100644 --- a/hw/char/virtio-seria

[Qemu-devel] [PATCH 3/4] standard-headers: include stdint.h

2015-02-18 Thread Michael S. Tsirkin
The importing script got it right already, I just forgot to re-run it. Reported-by: Thomas Huth Signed-off-by: Michael S. Tsirkin --- include/standard-headers/linux/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/standard-headers/linux/types.h b/include/stan

Re: [Qemu-devel] [RFC PATCH 00/14] Block replication for continuous checkpoints

2015-02-18 Thread Paolo Bonzini
On 12/02/2015 04:07, Wen Congyang wrote: > Wen Congyang (14): > docs: block replication's description > quorom: add a new read pattern > quorum: ignore 0-length child > Add new block driver interfaces to control disk replication > quorom: implement block driver interfaces for block repl

Re: [Qemu-devel] [PATCH 1/2] target-mips: replace cpu_save/cpu_load with VMStateDescription

2015-02-18 Thread Andreas Färber
Hi Leon, Am 18.02.2015 um 15:51 schrieb Leon Alrae: > Create VMStateDescription for MIPS CPU. The new structure contains exactly the > same fields as before, therefore leaving existing version_id. > > Signed-off-by: Leon Alrae > --- > target-mips/cpu-qom.h | 4 + > target-mips/cpu.c | 1

Re: [Qemu-devel] [PATCH v4 0/5] libqos: Virtio MMIO driver

2015-02-18 Thread Stefan Hajnoczi
On Fri, Jan 23, 2015 at 05:38:48PM +0100, Marc Marí wrote: > Add virtio-mmio support to libqos and test case for virtio-blk. > > Changes for version 3: > - Fix leaks and minor bugs > - Extract basic test case to a function > > Changes for version 4: > - Add format=raw to images, to avoid warni

Re: [Qemu-devel] [RFC PATCH 0/7] hw/arm/virt: Add cpu-add way cpu hotplug support

2015-02-18 Thread Wei Huang
Nice work. I will help review the patches. Other than the CPU hotplug support, we are also seeking the guest VM powerdown support via ACPI. This feature is important for management tool to control guest VMs. In fact I had a similar GPIO patch for powerdown recently. Given that you already posted a

Re: [Qemu-devel] [PATCH 1/2] qemu-img convert: Rewrite copying logic

2015-02-18 Thread Max Reitz
On 2015-02-18 at 10:19, Kevin Wolf wrote: The implementation of qemu-img convert is (a) messy, (b) buggy, and (c) less efficient than possible. The changes required to beat some sense into it are massive enough that incremental changes would only make my and the reviewers' life harder. So throw i

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Some qemu-img convert tests

2015-02-18 Thread Max Reitz
On 2015-02-18 at 10:19, Kevin Wolf wrote: This adds a regression test for some problems that the qemu-img convert rewrite just fixed. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/122 | 83 ++ tests/qemu-iotests/122.out | 30

Re: [Qemu-devel] [RFC PATCH 0/7] hw/arm/virt: Add cpu-add way cpu hotplug support

2015-02-18 Thread Wei Huang
On 02/18/2015 11:19 AM, Wei Huang wrote: > Nice work. I will help review the patches. > > Other than the CPU hotplug support, we are also seeking the guest VM > powerdown support via ACPI. This feature is important for management > tool to control guest VMs. In fact I had a similar GPIO patch fo

Re: [Qemu-devel] [RFC PATCH 5/7] target-arm/cpu: Add apic_id property for ARMCPU

2015-02-18 Thread Andreas Färber
Hi, Am 17.02.2015 um 11:10 schrieb Shannon Zhao: > Add apic_id property for ARMCPU. It can be used for cpu hotplug. > > Signed-off-by: Shannon Zhao > --- > target-arm/cpu-qom.h |1 + > target-arm/cpu.c | 77 > ++ > target-arm/cpu.h

Re: [Qemu-devel] [RFC PATCH 1/7] hw/arm/virt: Add a GPIO controller

2015-02-18 Thread Wei Huang
On 02/17/2015 04:10 AM, Shannon Zhao wrote: > Add a GPIO controller in machine virt, in order to support cpu hotplug. > Here we use pl061. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt.c | 28 > 1 files changed, 28 insertions(+), 0 deletions(-) > > diff --

[Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers

2015-02-18 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in process_incoming_migration_co(). Signed-off-by: Markus Armbruster --- Based on [PATCH v2 00/10] Clean up around error_get_p

Re: [Qemu-devel] [PATCH] send-email: ask confirmation if given encoding name is very short

2015-02-18 Thread Jeff King
On Mon, Feb 16, 2015 at 02:34:14PM -0800, Junio C Hamano wrote: > Sometimes people respond "y" (or "yes") when asked > this question: > > Which 8bit encoding should I declare [UTF-8]? > > We already have a mechanism to avoid accepting a mistyped e-mail > address (we ask to confirm when the g

[Qemu-devel] [PATCH v4 06/42] acpi: add aml_if() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 4e0685e..d19d1fb 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -356,6 +356,1

[Qemu-devel] [PATCH v4 00/42] ACPI refactoring: replace template patching with C AML API

2015-02-18 Thread Igor Mammedov
changes since v3: * drop acpi_def_block() for now * exclude PCI refactoring * minor ammends as requested on list * not much tested, but XP boots. changes since v2: * rename acpi prefixes in API to aml * reverse conversion order from bottom->top to top->bottom * introduce internal Aml gar

[Qemu-devel] [PATCH v4 07/42] acpi: add aml_name() & aml_name_decl() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 32 include/hw/acpi/aml-build.h | 4 2 files changed, 36 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index d19d1fb..cb00a1b 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acp

[Qemu-devel] [PATCH v4 11/42] acpi: add aml_store() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 99d213c..57e3176 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -408,6 +408

[Qemu-devel] [PATCH v4 03/42] pc: acpi-build: use aml_scope() for \_SB scope

2015-02-18 Thread Igor Mammedov
prepares for incremental conversion of SSDT content to AML API Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 5e4b333..c66fe56 10

[Qemu-devel] [PATCH v4 08/42] acpi: add aml_int() term

2015-02-18 Thread Igor Mammedov
* factor out ACPI const int packing out of build_append_value() and rename build_append_value() to build_append_int_noprefix() it will be reused for adding a plain integer value into AML. will be used by is aml_processor() and CRS macro helpers * extend build_append_int{_noprefix}() to suppor

[Qemu-devel] [PATCH v4 14/42] acpi: add aml_call1(), aml_call2(), aml_call3(), aml_call4() helpers

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 42 ++ include/hw/acpi/aml-build.h | 4 2 files changed, 46 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 3e187fa..18427b6 100644 --- a/hw/acpi/aml-build.c ++

[Qemu-devel] [PATCH v4 01/42] acpi: introduce AML composer aml_append()

2015-02-18 Thread Igor Mammedov
Adds for dynamic AML creation, which will be used for piecing ASL/AML primitives together and hiding from user/caller details about how nested context should be closed/packed leaving less space for mistakes and necessity to know how AML should be encoded, allowing user to concentrate on ASL represe

[Qemu-devel] [PATCH v4 16/42] pc: acpi-build: generate _S[345] packages dynamically

2015-02-18 Thread Igor Mammedov
Replaces template patching with packages composed using AML API. Note on behavior change: If S3 or S4 is disabled, respective packages won't be created and put into SSDT. Which saves us some space in SSDT and doesn't confuse guest OS with mangled package names as it was done originally. Signed-of

[Qemu-devel] [PATCH v4 17/42] acpi: add aml_buffer() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 7 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index fdeeacc..98b1540 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -506,6 +506,13

[Qemu-devel] [PATCH v4 02/42] acpi: add aml_scope() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 20 include/hw/acpi/aml-build.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index caf792b..f891406 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c

[Qemu-devel] [PATCH v4 12/42] acpi: add aml_and() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 57e3176..bb1fbbc 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -417,6 +

[Qemu-devel] [PATCH v4 09/42] acpi: add aml_return() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index aaa80e5..8207d9c 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -355,6 +355,1

[Qemu-devel] [PATCH v4 05/42] acpi: add aml_method() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index c955d66..4e0685e 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -356,6 +356

[Qemu-devel] [PATCH v4 22/42] acpi: add aml_field() & aml_named_field() terms

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 28 include/hw/acpi/aml-build.h | 6 ++ 2 files changed, 34 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index d72d5b4..b91141e 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/

[Qemu-devel] [PATCH v4 15/42] acpi: add aml_package() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 18427b6..fdeeacc 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -505,3 +505,1

[Qemu-devel] [PATCH v4 19/42] acpi: add aml_io() helper

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 16 include/hw/acpi/aml-build.h | 7 +++ 2 files changed, 23 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 070ca81..d7edda1 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c

[Qemu-devel] [PATCH v4 04/42] acpi: add aml_device() term

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index f891406..c955d66 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -355,3

[Qemu-devel] [PATCH v4 18/42] acpi: add aml_resource_template() helper

2015-02-18 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 98b1540..070ca81 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -506,6 +506,1

<    1   2   3   4   >