Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Teruaki Ishizaki
(2015/02/12 16:42), Liu Yuan wrote: On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: At Thu, 12 Feb 2015 15:00:49 +0800, Liu Yuan wrote: On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: At Tue, 10 Feb 2015 18:35:58 +0800, Liu Yuan wrote: On Tue, Feb 10, 2015 at

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > +if (replay_mode != REPLAY_MODE_PLAY) { > > +evt = qemu_input_event_new_key(key, down); > > +if (QTAILQ_EMPTY(&kbd_queue)) { > > +qe

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Liu Yuan
On Thu, Feb 12, 2015 at 05:01:05PM +0900, Teruaki Ishizaki wrote: > (2015/02/12 16:42), Liu Yuan wrote: > >On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: > >>At Thu, 12 Feb 2015 15:00:49 +0800, > >>Liu Yuan wrote: > >>> > >>>On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Hitoshi Mitake
At Thu, 12 Feb 2015 15:42:17 +0800, Liu Yuan wrote: > > On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: > > At Thu, 12 Feb 2015 15:00:49 +0800, > > Liu Yuan wrote: > > > > > > On Thu, Feb 12, 2015 at 03:19:21PM +0900, Hitoshi Mitake wrote: > > > > At Tue, 10 Feb 2015 18:35:58 +080

Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Liu Yuan
On Thu, Feb 12, 2015 at 05:13:55PM +0900, Hitoshi Mitake wrote: > At Thu, 12 Feb 2015 15:42:17 +0800, > Liu Yuan wrote: > > > > On Thu, Feb 12, 2015 at 04:28:01PM +0900, Hitoshi Mitake wrote: > > > At Thu, 12 Feb 2015 15:00:49 +0800, > > > Liu Yuan wrote: > > > > > > > > On Thu, Feb 12, 2015 at 0

Re: [Qemu-devel] [PATCH v2 0/5] qga: add three logical memory hotplug related commands

2015-02-12 Thread zhanghailiang
ping... Any comments/feedbacks are warmly welcomed. Michael? What's your opinion? ;) Thanks. On 2015/1/22 10:40, zhanghailiang wrote: This patch series add three guest commands about memory block: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. With these three

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Fam Zheng
On Thu, 02/12 15:40, Wen Congyang wrote: > On 02/12/2015 03:21 PM, Fam Zheng wrote: > > Hi Congyang, > > > > On Thu, 02/12 11:07, Wen Congyang wrote: > >> +== Workflow == > >> +The following is the image of block replication workflow: > >> + > >> ++--++-

Re: [Qemu-devel] [PULL 2/4] coverity: Model GLib string allocation partially

2015-02-12 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/02/2015 17:24, Markus Armbruster wrote: >> + >> +char *g_strdup(const char *s) >> +{ >> +char *dup; >> +size_t i; >> + >> +if (!s) { >> +return NULL; >> +} >> + >> +__coverity_string_null_sink__(s); >> +__coverity_string_size_sink__(s)

Re: [Qemu-devel] [PATCH 1/3] rcu: do not let RCU callbacks pile up indefinitely

2015-02-12 Thread Fam Zheng
On Wed, 02/11 18:14, Paolo Bonzini wrote: > Always process them within half a second. Even though waiting a little > is useful, it is not okay to delay e.g. qemu_opts_del forever. > > Signed-off-by: Paolo Bonzini > --- > util/rcu.c | 14 -- > 1 file changed, 8 insertions(+), 6 delet

Re: [Qemu-devel] [PULL 0/4] coverity: Improve and extend model

2015-02-12 Thread Markus Armbruster
Paolo Bonzini writes: > \>> It seems like Coverity Scan doesn't like the new model. Possibly the >>> fault of the third patch. >> >> Works for me with a local 7.0.3 installation. Which I just realized is >> outdated. I'll recheck with 7.6.0. >> >>>Will check (for

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-02-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 09/02/2015 13:15, Pavel Dovgaluk wrote: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >>> break; > >>> case QEMU_OPTION_audio_help: > >>> AUD_help (); > >>> @@ -3244,6 +3254,7 @@ int mai

Re: [Qemu-devel] [PATCH v7 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-12 Thread Edgar E. Iglesias
On Thu, Feb 12, 2015 at 02:49:06PM +0800, Greg Bellows wrote: > Added support for running an AArch32 guest on a AArch64 KVM host. Support has > only been added to the QEMU machvirt machine. The addition of CPU properties > specifiable from the command line were added to allow disablement of AArch

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am 10.02.2015 um 14:54 schrieb Kevin Wolf: Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote: Am 10.02.2015 um 12:41 hat Peter Lieven gesc

Re: [Qemu-devel] [PATCH] vnc: fix coverity warning

2015-02-12 Thread Markus Armbruster
Gerd Hoffmann writes: >> > +assert(vs); >> > return vnc_socket_local_addr("%s:%s", vs->lsock); >> > } >> > >> > >> >> If you want, I can just silence the warning in Coverity. > > I think in the source code is better, human readers might wonder too. > > And in case the calling code

Re: [Qemu-devel] [PATCH] vpc: Implement bdrv_co_get_status()

2015-02-12 Thread Kevin Wolf
Am 11.02.2015 um 23:51 hat Max Reitz geschrieben: > On 2015-02-11 at 11:23, Kevin Wolf wrote: > >This implements bdrv_co_get_status() for VHD images. This can > >significantly speed up qemu-img convert operation because only with this > >function implemented sparseness can be considered. (Before, c

Re: [Qemu-devel] [PATCH 3/8] leon3: Replace unchecked qdev_init() by qdev_init_nofail()

2015-02-12 Thread Fabien Chouteau
On 02/04/2015 06:33 PM, Markus Armbruster wrote: > grlib_irqmp_create(), grlib_gptimer_create() and > grlib_apbuart_create() are helpers to create and realize GRLIB > devices. Their only caller leon3_generic_hw_init() doesn't check for > failure. Only the first can actually fail, and only when th

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Wen Congyang
On 02/12/2015 04:44 PM, Fam Zheng wrote: > On Thu, 02/12 15:40, Wen Congyang wrote: >> On 02/12/2015 03:21 PM, Fam Zheng wrote: >>> Hi Congyang, >>> >>> On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following is the image of block replication workflow: + +

[Qemu-devel] Google Summer of Code application submitted

2015-02-12 Thread Stefan Hajnoczi
Hi, I have submitted our Google Summer of Code application for QEMU, libvirt, and KVM. Accepted organizations will be announced on March 2nd at 19:00 UTC on http://google-melange.com/. You can still add project ideas if you wish to mentor: http://qemu-project.org/Google_Summer_of_Code_2015 Mento

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Hongyang Yang
Hi Fam, 在 02/12/2015 04:44 PM, Fam Zheng 写道: On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: Hi Congyang, On Thu, 02/12 11:07, Wen Congyang wrote: +== Workflow == +The following is the image of block replication workflow: + ++--+

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Fam Zheng
On Thu, 02/12 17:33, Wen Congyang wrote: > On 02/12/2015 04:44 PM, Fam Zheng wrote: > > On Thu, 02/12 15:40, Wen Congyang wrote: > >> On 02/12/2015 03:21 PM, Fam Zheng wrote: > >>> Hi Congyang, > >>> > >>> On Thu, 02/12 11:07, Wen Congyang wrote: > +== Workflow == > +The following is the

Re: [Qemu-devel] [PATCH v7 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-12 Thread Greg Bellows
On Thu, Feb 12, 2015 at 5:10 PM, Edgar E. Iglesias wrote: > On Thu, Feb 12, 2015 at 02:49:06PM +0800, Greg Bellows wrote: > > Added support for running an AArch32 guest on a AArch64 KVM host. > Support has > > only been added to the QEMU machvirt machine. The addition of CPU > properties > > spe

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Fam Zheng
On Thu, 02/12 17:36, Hongyang Yang wrote: > Hi Fam, > > 在 02/12/2015 04:44 PM, Fam Zheng 写道: > >On Thu, 02/12 15:40, Wen Congyang wrote: > >>On 02/12/2015 03:21 PM, Fam Zheng wrote: > >>>Hi Congyang, > >>> > >>>On Thu, 02/12 11:07, Wen Congyang wrote: > +== Workflow == > +The following is

[Qemu-devel] [PATCH v2] vpc: Implement bdrv_co_get_block_status()

2015-02-12 Thread Kevin Wolf
This implements bdrv_co_get_block_status() for VHD images. This can significantly speed up qemu-img convert operation because only with this function implemented sparseness can be considered. (Before, converting a 1 TB empty image took several minutes for me, now it's instantaneous.) Signed-off-by

Re: [Qemu-devel] [PATCH] vpc: Fix size in fixed image creation

2015-02-12 Thread Kevin Wolf
Am 11.02.2015 um 23:32 hat Max Reitz geschrieben: > On 2015-02-11 at 11:22, Kevin Wolf wrote: > > If total_sectors is rounded to match the geometry, total_size needs to > be changed as well. Otherwise we end up with an image whose geometry > describes a disk larger than the image file,

Re: [Qemu-devel] [PATCH 1/1] block/raw-posix: fix compilation warning on OSX

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 06:35 hat Denis V. Lunev geschrieben: > block/raw-posix.c:947:19: warning: unused variable 's' [-Wunused-variable] > BDRVRawState *s = aiocb->bs->opaque; > > This variable is used only when on of the following macros are defined > CONFIG_XFS, CONFIG_FALLOCATE, CONFIG_FALLOCATE

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: > Am 10.02.2015 um 15:53 schrieb Kevin Wolf: > >Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: > >>Am 10.02.2015 um 14:54 schrieb Kevin Wolf: > >>>Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: > On Tue, Feb 10, 2015 at 02:34:14PM +0

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am 10.02.2015 um 14:54 schrieb Kevin Wolf: Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: On Tue,

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: > Am 12.02.2015 um 10:58 schrieb Kevin Wolf: > >Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: > >>Am 10.02.2015 um 15:53 schrieb Kevin Wolf: > >>>Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: > Am 10.02.2015 um 14:54 schrieb Kev

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Wen Congyang
On 02/12/2015 05:44 PM, Fam Zheng wrote: > On Thu, 02/12 17:33, Wen Congyang wrote: >> On 02/12/2015 04:44 PM, Fam Zheng wrote: >>> On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote: > Hi Congyang, > > On Thu, 02/12 11:07, Wen Congyang wrote: >> +

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am 10.02.2015 um 15:53 schrieb Kevin Wolf: Am 10.02.2015 um 15:00 hat Peter Lieven geschrieben: Am 1

Re: [Qemu-devel] [PATCH v3 1/4] bootdevice: remove the check about boot_set_handler

2015-02-12 Thread Markus Armbruster
writes: > From: Gonglei > > The reset logic can be done by both machine reset and > boot handler. So we shouldn't return error when the boot > handler callback don't be set. > > Signed-off-by: Gonglei > Reviewed-by: Alexander Graf > --- > bootdevice.c | 10 +++--- > 1 file changed, 3 inse

Re: [Qemu-devel] [PATCH v3 2/4] bootdevice: check boot order argument validation before vm running

2015-02-12 Thread Markus Armbruster
writes: > From: Gonglei > > Either 'once' option or 'order' option can take effect for -boot at > the same time, that is say initial startup processing can check only > one. And pc.c's set_boot_dev() fails when its boot order argument > is invalid. This patch provide a solution fix this problem:

Re: [Qemu-devel] [PATCH v3 4/4] bootdevice: update boot_order in MachineState

2015-02-12 Thread Markus Armbruster
writes: > From: Dinar Valeev > > on sPAPR we need to update boot_order in MachineState in case it > got changed on reset. > > Signed-off-by: Dinar Valeev > Reviewed-by: Alexey Kardashevskiy > Signed-off-by: Gonglei > --- > bootdevice.c | 4 > 1 file changed, 4 insertions(+) > > diff --g

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: > Am 12.02.2015 um 11:06 schrieb Kevin Wolf: > >Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: > >>Am 12.02.2015 um 10:58 schrieb Kevin Wolf: > >>>Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: > Am 10.02.2015 um 15:53 schrieb Kev

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread famz
On Thu, 02/12 18:11, Wen Congyang wrote: > On 02/12/2015 05:44 PM, Fam Zheng wrote: > > On Thu, 02/12 17:33, Wen Congyang wrote: > >> On 02/12/2015 04:44 PM, Fam Zheng wrote: > >>> On Thu, 02/12 15:40, Wen Congyang wrote: > On 02/12/2015 03:21 PM, Fam Zheng wrote: > > Hi Congyang, > >

Re: [Qemu-devel] [RFC] net: 'Remove vhostforce option in addition to vhost param'

2015-02-12 Thread Michael S. Tsirkin
On Thu, Feb 12, 2015 at 11:50:05AM +0530, Pankaj Gupta wrote: > vhostforce was added to enable use of vhost when > guest don't have MSI-X support. > Now, we have scenarios which dont use interrupts > like DPDK and still use vhost. Also, performance of > guests without MSI-X support is getting

[Qemu-devel] [PATCH v8 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-12 Thread Greg Bellows
Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64 execution state hereby forcing EL1 to be AArch32. The new CPU co

[Qemu-devel] [PATCH v8 3/4] target-arm: Add 32/64-bit register sync

2015-02-12 Thread Greg Bellows
Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v6 -> v7 -Fix comment issues v5 -> v6 - Add r14 set in

[Qemu-devel] [PATCH v8 1/4] target-arm: Add CPU property to disable AArch64

2015-02-12 Thread Greg Bellows
Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU invocation would have AArch64 execution state dis

[Qemu-devel] [PATCH v8 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-12 Thread Greg Bellows
Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows --- v7 -> v8 - Fix dynamic cast object v4 -> v5 - Fix target check v3 -> v4 - Add check that to make sure KVM64 is only being used on AArch64 fami

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 11:23 schrieb Kevin Wolf: Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter Lieven geschrieben: Am 1

[Qemu-devel] [PATCH v8 2/4] target-arm: Add feature parsing to virt

2015-02-12 Thread Greg Bellows
Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v3 -> v4 - Fix misspelling v1 -> v2 - Fix multiple property handling --- hw/arm/virt.c | 20

[Qemu-devel] [PATCH 1/3] hmp: Clean up declarations for long-gone info handlers

2015-02-12 Thread Markus Armbruster
Leftovers from d1f2964 qapi: Convert query-spice 791e7c8 qapi: Convert query-migrate 0fe6a7f slirp: Drop statistic code Signed-off-by: Markus Armbruster --- include/migration/migration.h | 4 include/sysemu/sysemu.h | 3 --- include/ui/qemu-spice.h | 3 --- 3 files changed, 10 d

[Qemu-devel] [PATCH 2/3] hmp: Name HMP command handler functions hmp_COMMAND()

2015-02-12 Thread Markus Armbruster
Some are called do_COMMAND() (old ones, usually), some hmp_COMMAND(), and sometimes COMMAND pointlessly differs in spelling. Normalize to hmp_COMMAND(), where COMMAND is exactly the command name with '-' replaced by '_'. Exceptions: * do_device_add() and client_migrate_info() *not* renamed to

[Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names

2015-02-12 Thread Markus Armbruster
When I can't guess a handler's name, I have to look it up in hmp-commands.hx. Happens often enough to annoy me. Let's make them more predictable. Touches several subsystems because HMP command handlers are still spread far and wide, but the changes are trivial. Speak up if you want your subsyst

[Qemu-devel] [PATCH 3/3] hmp: Name HMP info handler functions hmp_info_SUBCOMMAND()

2015-02-12 Thread Markus Armbruster
Some are called do_info_SUBCOMMAND() (old ones, usually), some hmp_info_SUBCOMMAND(), some SUBCOMMAND_info(), sometimes SUBCOMMAND pointlessly differs in spelling. Normalize to hmp_info_SUBCOMMAND(), where SUBCOMMAND is exactly the subcommand name with '-' replaced by '_'. Exceptions: * sun4m_ir

Re: [Qemu-devel] [PATCH RFC v2 4/8] block: add dirty-dirty bitmaps

2015-02-12 Thread Vladimir Sementsov-Ogievskiy
On 11.02.2015 00:30, John Snow wrote: I had hoped it wouldn't come to this :) On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: A dirty-dirty bitmap is a dirty bitmap for BdrvDirtyBitmap. It tracks set/unset changes of BdrvDirtyBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [Qemu-devel] [PATCH RFC v2 5/8] block: add bdrv_dirty_bitmap_enabled()

2015-02-12 Thread Vladimir Sementsov-Ogievskiy
On 11.02.2015 00:30, John Snow wrote: On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 5 + include/block/block.h | 1 + 2 files changed, 6 insertions(+) diff --git a/block.c b/block.c index 8ab724b..1

Re: [Qemu-devel] [RFC] net: 'Remove vhostforce option in addition to vhost param'

2015-02-12 Thread Pankaj Gupta
> On Thu, Feb 12, 2015 at 11:50:05AM +0530, Pankaj Gupta wrote: > > vhostforce was added to enable use of vhost when > > guest don't have MSI-X support. > > Now, we have scenarios which dont use interrupts > > like DPDK and still use vhost. Also, performance of > > guests without MSI-X suppo

Re: [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 11:52 hat Markus Armbruster geschrieben: > When I can't guess a handler's name, I have to look it up in > hmp-commands.hx. Happens often enough to annoy me. Let's make them > more predictable. > > Touches several subsystems because HMP command handlers are still > spread far and

Re: [Qemu-devel] [PATCH v2 00/11] cpu: add i386 cpu hot remove support

2015-02-12 Thread Zhu Guihua
On Tue, 2015-02-10 at 20:38 +0800, Zhi Yong Wu wrote: > On Fri, Feb 6, 2015 at 3:54 PM, Zhu Guihua wrote: > > On Tue, 2015-02-03 at 16:41 +0800, Zhi Yong Wu wrote: > >> HI, > >> > >> Can you push the patchset to a branch on github? It will be convenient > >> for other guys to do some tests. > > >

Re: [Qemu-devel] [v5 05/12] arch_init: Alloc and free data struct for compression

2015-02-12 Thread Juan Quintela
"Li, Liang Z" wrote: > Hi Juan, > > Have you reviewed the 04 patch of the patch series? I didn't see > the reply email. It is ok, going to put the review-by > > Liang > >> -Original Message- >> From: Juan Quintela [mailto:quint...@redhat.com] >> Sent: Wednesday, February 11, 2015 5:

Re: [Qemu-devel] [v5 04/12] qemu-file: Add compression functions to QEMUFile

2015-02-12 Thread Juan Quintela
Liang Li wrote: > qemu_put_compression_data() compress the data and put it to QEMUFile. > qemu_put_qemu_file() put the data in the buffer of source QEMUFile to > destination QEMUFile. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: Juan Quintela

Re: [Qemu-devel] [v5 09/12] migration: Make compression co-work with xbzrle

2015-02-12 Thread Juan Quintela
"Li, Liang Z" wrote: >> Liang Li wrote: >> > Now, multiple thread compression can co-work with xbzrle. when xbzrle >> > is on, multiple thread compression will only work at the first round >> > of RAM data sync. >> > >> > Signed-off-by: Liang Li >> > Signed-off-by: Yang Zhang >> > Reviewed-by:

Re: [Qemu-devel] [v5 02/12] migration: Add the framework of multi-thread compression

2015-02-12 Thread Juan Quintela
"Li, Liang Z" wrote: >> Reviewing patch 8, I found that we need to fix some things here. >> >> > +static int ram_save_compressed_page(QEMUFile *f, RAMBlock *block, >> > +ram_addr_t offset, bool >> > +last_stage) { >> > +int bytes_sent = -1; >> > + >> > +

[Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END

2015-02-12 Thread Jens Freimann
We have defines for VIRTIO_TRANSPORT_F_START/_END in two places. In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h Since we already get virtio_config.h via update-linux-headers.sh, there's no need to have duplicate defines in QEMU headers files. Let's remove this define fro

[Qemu-devel] [PATCH/RFC 0/2] update-linux-headers.sh and virtio

2015-02-12 Thread Jens Freimann
Hi, currently when sync'ing linux-headers against kvm/next, qemu/master won't build because of two problems: 1. virtio_types.h needs to be copied to QEMU linux-headers, as it is now included by virtio_ring.h Patch 2 adds virtio_types.h two update-linux-headers.sh. 2. VIRTIO_TRANSPORT_F_END h

[Qemu-devel] [PATCH 1/2] update-linux-headers.sh: also grap virtio_types.h

2015-02-12 Thread Jens Freimann
Signed-off-by: Jens Freimann --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index c8e026d..0b2e117 100755 --- a/scripts/update-linux-headers.sh +++ b/scripts/update-linux-hea

[Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Peter Lieven
Hi, I have a Windows system which fails to migrate with this error almost reliably when migrating from one host to another (both qemu-2.2.0). The error seems to be gone in master, but I was unable to track the exact fix down yet. It seems that the error is related to the amount of memory. 4G a

Re: [Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 14:20, Peter Lieven wrote: > > > I have a Windows system which fails to migrate with this error almost > reliably when migrating > from one host to another (both qemu-2.2.0). The error seems to be gone > in master, but I was > unable to track the exact fix down yet. It seems that

[Qemu-devel] [PATCH v2 01/10] error: New convenience function error_report_err()

2015-02-12 Thread Markus Armbruster
I've typed error_report("%s", error_get_pretty(ERR)) too many times already, and I've fixed too many instances of qerror_report_err(ERR) to error_report("%s", error_get_pretty(ERR)) as well. Capture the pattern in a convenience function. Since it's almost invariably followed by error_free(), stuf

[Qemu-devel] [PATCH v2 08/10] vl: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helpers machine_set_property() and object_create(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blak

[Qemu-devel] [PATCH v2 04/10] monitor: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in HMP command handler hmp_trace_event(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- monitor.c | 3 +-- 1

[Qemu-devel] [PATCH v2 02/10] error: Use error_report_err() where appropriate

2015-02-12 Thread Markus Armbruster
Coccinelle semantic patch: @@ expression E; @@ -error_report("%s", error_get_pretty(E)); -error_free(E); +error_report_err(E); @@ expression E, S; @@ -error_report("%s", error_get_pretty(E)); +error_report_err(E); ( exit(

[Qemu-devel] [PATCH v2 03/10] monitor: Clean up around monitor_handle_fd_param()

2015-02-12 Thread Markus Armbruster
monitor_handle_fd_param() is a wrapper around monitor_handle_fd_param2() that feeds errors to qerror_report_err() instead of returning them. qerror_report_err() is inappropriate in many contexts. monitor_handle_fd_param() looks simpler than monitor_handle_fd_param2(), which tempts use. Remove th

[Qemu-devel] [PATCH v2 10/10] qemu-char: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in legacy chardev parser qemu_chr_parse_compat(). Legacy chardev syntax is not to be used in QMP. Signed-off-by: Markus Armbru

[Qemu-devel] [PATCH v2 07/10] tpm: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helper configure_tpm(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tpm.c | 6 ++ 1

[Qemu-devel] [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err()

2015-02-12 Thread Markus Armbruster
Tree-wide cleanup, but the tree-wide changes are mechanical. If nobody objects, I'll route it through my own tree. Depends on my "[PATCH] vhost-scsi: Improve error reporting for invalid vhostfd". PATCH 01 introduces a helper function, PATCH 02 puts it to use. Responsible for the bulk of the diff

[Qemu-devel] [PATCH v2 09/10] qemu-img: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qemu-img.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletion

[Qemu-devel] [PATCH v2 05/10] net: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in HMP command handler hmp_host_net_add() and initial startup helpers net_init_client(), net_init_netdev(). Keep it in QMP comm

[Qemu-devel] [PATCH v2 06/10] numa: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helper numa_init_func() and board setup helper memory_region_allocate_system_memory(). Signed-off-by: Markus

Re: [Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-12 Thread Roman Kagan
On Wed, Feb 11, 2015 at 11:26:12AM +, Daniel P. Berrange wrote: > Add a new 'guest-set-user-password' command for changing the password > of guest OS user accounts. This command is needed to enable OpenStack > to support its API for changing the admin password of guests running > on KVM/QEMU. I

Re: [Qemu-devel] [PATCH v2 1/3] numa: Reject CPU indexes > max_cpus

2015-02-12 Thread Igor Mammedov
On Mon, 9 Feb 2015 17:53:14 -0200 Eduardo Habkost wrote: > The CPU indexes for NUMA nodes make sense only up to max_cpus, and CPU > indexes > max_cpus are ignored. Reject configuration which uses invalid > CPU indexes. > > Signed-off-by: Eduardo Habkost > --- > numa.c | 7 --- > 1 file ch

[Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-12 Thread Markus Armbruster
If do_sd_create() fails, it first reports the error returned, then reports a another one with strerror(errno). errno is meaningless at that point. Report just one error combining the valid information from both messages. Reported-by: Eric Blake Signed-off-by: Markus Armbruster --- Applies on t

[Qemu-devel] [virtio] virtqueue request size

2015-02-12 Thread Vasile Catalin-B50542
I'm trying to work out virtqueue from the virtio API. I've been able to send a message from guest to qemu, but there is something strange that I don't understand. virtqueue_get_avail_bytes() returns 0 number of "in" bytes, but if I hard code iov_to_buf() to get 5 bytes, it actually gets my messa

[Qemu-devel] Several sheepdog functions mix up -1 and -errno in return values

2015-02-12 Thread Markus Armbruster
Two common conventions for functions returning int that may fail: 1. Return non-negative value on success, -1 value on failure. 2. Return non-negative value on success, a negative errno error code on failure. Both work. But mixing them in the same function is not a good idea. Suspicious fun

Re: [Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-12 Thread Daniel P. Berrange
On Thu, Feb 12, 2015 at 04:21:09PM +0300, Roman Kagan wrote: > On Wed, Feb 11, 2015 at 11:26:12AM +, Daniel P. Berrange wrote: > > Add a new 'guest-set-user-password' command for changing the password > > of guest OS user accounts. This command is needed to enable OpenStack > > to support its A

Re: [Qemu-devel] [PATCH v2] vpc: Implement bdrv_co_get_block_status()

2015-02-12 Thread Max Reitz
On 2015-02-12 at 04:46, Kevin Wolf wrote: This implements bdrv_co_get_block_status() for VHD images. This can significantly speed up qemu-img convert operation because only with this function implemented sparseness can be considered. (Before, converting a 1 TB empty image took several minutes for

Re: [Qemu-devel] [PULL 0/4] coverity: Improve and extend model

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 10:11, Markus Armbruster wrote: > > Yes, the last patch seems to be the culprit. It failed immediately with > > the __coverity_mark_as_afm_freed__(ptr, "g_free") model; > > Any diagnostics? None. It just says roughly "the build had a temporary problem and will be rescheduled".

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 10:12, Pavel Dovgaluk wrote: >>> > > >>> > > Replay for audio adapter will be added in latter patches. >>> > > Trying to record/replay machine with audio using current >>> > > set of patches will break the replay. >> > >> > For this case you can try adding a mechanism similar to mi

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Igor Mammedov
On Mon, 9 Feb 2015 17:53:15 -0200 Eduardo Habkost wrote: > Each CPU can appear in only one NUMA node on the NUMA config. Reject > configuration if a CPU appears in multiple nodes. > > Signed-off-by: Eduardo Habkost > --- > numa.c | 27 +++ > 1 file changed, 27 insertio

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 06:21, Fam Zheng wrote: > Before processing a request, virtio-scsi dataplane will check if the > backend runs on the same context with it. If not, it has to be moved, > with bdrv_set_aio_context. > > However this function is unsafe to be called from IOThread outside BQL. > The reas

[Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
TLB Flush: We have spent a few days on this issue, and still haven’t resolved the best path. Our solution seems to work, most of the time, but we still have some strange issues - so I want to check that what we are proposing has a chance of working. Our plan is to allow all CPU’s to continue

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 09:08, Pavel Dovgaluk wrote: >> > >> > This is wrong. You have different lifetimes for different modes. Please >> > make a copy of the event in the implementation of record mode. > What is the correct way for cloning the QAPI type? > I should invent the cloning visitor or just cre

Re: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END

2015-02-12 Thread Peter Maydell
On 12 February 2015 at 13:08, Jens Freimann wrote: > We have defines for VIRTIO_TRANSPORT_F_START/_END in two places. > In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h > > Since we already get virtio_config.h via update-linux-headers.sh, > there's no need to have duplicate

Re: [Qemu-devel] [PATCH RFC 0/1] qtest: Generic PCI device test

2015-02-12 Thread Markus Armbruster
Andreas Färber writes: > Hi Markus, > > Again thanks for digging into this. > > Am 29.01.2015 um 15:58 schrieb Markus Armbruster: >> This test does everything a number of existing tests currently do: >> >> ac97-test.c e1000-test.c es1370-test.c eepro100-test.c >> ne2000-test.c nvme-test.

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Alexander Graf
> On 12.02.2015, at 15:35, Mark Burton wrote: > > > TLB Flush: > > We have spent a few days on this issue, and still haven’t resolved the best > path. > > Our solution seems to work, most of the time, but we still have some strange > issues - so I want to check that what we are proposing ha

Re: [Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Peter Lieven
Am 12.02.2015 um 14:24 schrieb Paolo Bonzini: On 12/02/2015 14:20, Peter Lieven wrote: I have a Windows system which fails to migrate with this error almost reliably when migrating from one host to another (both qemu-2.2.0). The error seems to be gone in master, but I was unable to track the e

Re: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END

2015-02-12 Thread Jens Freimann
On Thu, Feb 12, 2015 at 02:41:15PM +, Peter Maydell wrote: > On 12 February 2015 at 13:08, Jens Freimann wrote: > > We have defines for VIRTIO_TRANSPORT_F_START/_END in two places. > > In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h > > > > Since we already get virtio_

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Peter Maydell
On 12 February 2015 at 14:45, Alexander Graf wrote: > almost nobody except x86 does global flushes All ARM TLB maintenance operations have both "this CPU only" and "all TLBs in the Inner Shareable domain" [that's ARM-speak for "every CPU core in the cluster"] variants (the latter being the TLB *I

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Peter Maydell
On 12 February 2015 at 14:45, Alexander Graf wrote: > >> On 12.02.2015, at 15:35, Mark Burton wrote: >> We are proposing to implement this by signalling all other CPU’s >> to exit (and requesting they flush before re-starting). In other >> words, this would happen asynchronously. > > For global f

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Igor Mammedov
On Mon, 9 Feb 2015 17:53:15 -0200 Eduardo Habkost wrote: > Each CPU can appear in only one NUMA node on the NUMA config. Reject > configuration if a CPU appears in multiple nodes. > > Signed-off-by: Eduardo Habkost > --- > numa.c | 27 +++ > 1 file changed, 27 insertio

[Qemu-devel] [PATCH 0/5] tcg-arm: LPAE: fix and extend xn control

2015-02-12 Thread Andrew Jones
This series fixes and extends the determination of whether or not an address is executable for LPAE translations. The main patch is 4/5, and describes the details in its commit message. Patches 1-3 prepare for the main patch, and patch 5/5 is a code cleanup made possible by introducing a new helper

[Qemu-devel] [PATCH 3/5] target-arm: add an is_user param to get_rw_prot

2015-02-12 Thread Andrew Jones
Give callers the ability to get page protection flags for PL0, even if not currently operating in PL0. This puts the burden of determining 'is_user' on the caller (again - it was this way before regime_is_user was introduced), but will be useful in a following patch. Signed-off-by: Andrew Jones -

[Qemu-devel] [PATCH 2/5] target-arm: enable get_rw_prot to take simple AP

2015-02-12 Thread Andrew Jones
Teach get_rw_prot about the simple AP format AP[2:1]. An additional switch was added, as opposed to converting ap := AP[2:1] to AP[2:0] with a simple shift - and then modifying cases 0,2,4,6, because the resulting code is easier to read with the switch. Signed-off-by: Andrew Jones --- target-arm

[Qemu-devel] [PATCH 5/5] target-arm: apply get_S1prot to get_phys_addr_v6

2015-02-12 Thread Andrew Jones
Now that we have get_S1prot, we can apply it to get_phys_addr_v6 for a minor code cleanup. Signed-off-by: Andrew Jones --- target-arm/helper.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 20e5753b

[Qemu-devel] [PATCH 1/5] target-arm: convert check_ap to get_rw_prot

2015-02-12 Thread Andrew Jones
Instead of mixing access permission checking with access permissions to page protection flags translation, just do the translation, and leave it to the caller to check the protection flags against the access type. As this function only considers READ/WRITE, not EXEC, then name it accordingly. Sign

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
> On 12 Feb 2015, at 16:01, Peter Maydell wrote: > > On 12 February 2015 at 14:45, Alexander Graf wrote: >> >>> On 12.02.2015, at 15:35, Mark Burton wrote: >>> We are proposing to implement this by signalling all other CPU’s >>> to exit (and requesting they flush before re-starting). In other

Re: [Qemu-devel] [v5 09/12] migration: Make compression co-work with xbzrle

2015-02-12 Thread Li, Liang Z
> >> Drop this patch and just give an error when trying to set xbzrle and > >> compression? User have to pick one and only one, no second guess > him/her? > >> > > > > Live migration can benefit from compression co-work with xbzrle. You > > know, xbzrle transfer the raw RAM pages to destination in

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
OK - Alex - your implication is that it has to be atomic, we need the sync… :-( I have a horrid feeling that the atomicity of global flush can’t be causing the (almost, but not quite reproducible) errors we’re seeing - but… anyway ;-) Cheers Mark. > On 12 Feb 2015, at 15:45, Alexander

  1   2   3   >