Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-11 Thread Chen, Tiejun
On 2015/2/11 11:46, Peter Maydell wrote: On 11 February 2015 at 02:50, Chen, Tiejun wrote: On 2015/2/11 10:03, Peter Maydell wrote: The linux-headers/ directory contains header files which can only validly be included if the host we're compiling on is Linux. Some of them will cause compile fai

Re: [Qemu-devel] CPU TLB flush with multithread TCG.

2015-02-11 Thread Mark Burton
> On 11 Feb 2015, at 04:33, Alex Bennée wrote: > > > Frederic Konrad writes: > >> Hi everybody, >> >> In multithread tlb_flush is broken as CPUA can flush an other CPUB and >> CPUB can be >> executing code, and fixing this can be quite hard: >> * We need to exit the CPU which is flushed.

Re: [Qemu-devel] QEMU data passing between modules

2015-02-11 Thread boddu pavan
Ping again! Are there any docs for QOM ?? or the historical parent of QOM , so that it is easy to relate. Thanks,Sai Pavan On Tuesday, February 10, 2015 11:50 PM, boddu pavan wrote: Ok fine. I always think there should be basic doc for QOM model for the QEMU beginners as this poin

Re: [Qemu-devel] CPU TLB flush with multithread TCG.

2015-02-11 Thread Frederic Konrad
On 11/02/2015 04:33, Alex Bennée wrote: Frederic Konrad writes: Hi everybody, In multithread tlb_flush is broken as CPUA can flush an other CPUB and CPUB can be executing code, and fixing this can be quite hard: * We need to exit the CPU which is flushed. * Makes sure the CPU is stopp

Re: [Qemu-devel] [v5 01/12] docs: Add a doc about multiple thread compression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Give some details about the multiple thread (de)compression and > how to use it in live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 9/9] Convert ram_list to RCU

2015-02-11 Thread Fam Zheng
On Fri, 02/06 17:55, Paolo Bonzini wrote: > From: Mike Day > > Allow "unlocked" reads of the ram_list by using an RCU-enabled QLIST. > > The ramlist mutex is kept, because call_rcu callbacks are not run within > the iothread lock. Thus, writers still need to take the ramlist mutex, > but they n

Re: [Qemu-devel] [v5 02/12] migration: Add the framework of multi-thread compression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Add the code to create and destroy the multiple threads those will > be used to do data compression. Left some functions empty to keep > clearness, and the code will be added later. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert R

Re: [Qemu-devel] [v5 03/12] migration: Add the framework of multi-thread decompression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Add the code to create and destroy the multiple threads those will be > used to do data decompression. Left some functions empty just to keep > clearness, and the code will be added later. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilb

Re: [Qemu-devel] [v5 02/12] migration: Add the framework of multi-thread compression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Add the code to create and destroy the multiple threads those will > be used to do data compression. Left some functions empty to keep > clearness, and the code will be added later. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert /

Re: [Qemu-devel] [v5 05/12] arch_init: Alloc and free data struct for compression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Define the data structure and variables used to do multiple thread > compression, and add the code to initialize and free them. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [v5 06/12] arch_init: Add and free data struct for decompression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Define the data structure and variables used to do multiple thread > decompression, and add the code to initialize and free them. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [v5 07/12] migration: Split the function ram_save_page

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Split the function ram_save_page for code reuse purpose. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block()

2015-02-11 Thread Kevin Wolf
Am 10.02.2015 um 21:02 hat Max Reitz geschrieben: > Under certain circumstances, making the refcount table grow can result > in leaking clusters. The first patch fixes at least some of those > circumstances (maybe there are more, but these are the ones I am aware > of), and the second patch adds a

Re: [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device

2015-02-11 Thread Stefan Hajnoczi
On Wed, Feb 04, 2015 at 10:54:17PM -0800, sfel...@gmail.com wrote: > diff --git a/default-configs/pci.mak b/default-configs/pci.mak > index a186c39..a7f3278 100644 > --- a/default-configs/pci.mak > +++ b/default-configs/pci.mak > @@ -32,3 +32,4 @@ CONFIG_PCI_TESTDEV=y > CONFIG_NVME_PCI=y > CONFIG

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-11 Thread Kevin Wolf
Am 10.02.2015 um 18:20 hat Eric Blake geschrieben: > On 02/10/2015 09:34 AM, Markus Armbruster wrote: > > I've typed error_report("%s", error_get_pretty(ERR)) too many times > > already, and I've fixed too many instances of qerror_report_err(ERR) > > to error_report("%s", error_get_pretty(ERR)) as

Re: [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device

2015-02-11 Thread Paolo Bonzini
On 11/02/2015 10:49, Stefan Hajnoczi wrote: > This poses a new problem: when QEMU is built without rocker the > QMP/HMP commands fail to link because rocker_find() and friends are > missing (they live in rocker.c). > > There are two options compile out the HMP/QMP commands (see how > SPICE does

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-11 Thread Paolo Bonzini
On 10/02/2015 23:04, Eduardo Habkost wrote: > $ spatch --sp-file /tmp/error_report.spatch $(git grep -l error_report) > > /tmp/error_report.patch Does it work without specifying any include path? I tried this a while ago: @@ identifier s, fld; @@ struct s { ... - QEMUTimer *fld; + Q

[Qemu-devel] [PATCH RFC v6 1/5] qemu-iotests: qemu machine type support

2015-02-11 Thread Xiao Guang Chen
This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type and alias of the default machine type the reference output file can now vary from the default to a machine specific output file if necessary. When using a machine specific reference file if the de

[Qemu-devel] [PATCH RFC v6 3/5] qemu-iotests: s390x: fix test 041

2015-02-11 Thread Xiao Guang Chen
There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/041 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/04

[Qemu-devel] [PATCH RFC v6 2/5] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 081 and 087

2015-02-11 Thread Xiao Guang Chen
This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy and cdrom. Output files for test case 067, 071, 08

[Qemu-devel] [PATCH RFC v6 4/5] qemu-iotests: s390x: fix test 055

2015-02-11 Thread Xiao Guang Chen
There is no 'ide-cd' device defined on s390 platform, so test_medium_not_found() test should be skipped. Reviewed-by: Max Reitz Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/055 | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/qemu-iotests

[Qemu-devel] [PATCH RFC v6 0/5] Update tests/qemu-iotests failing cases for the s390 platform

2015-02-11 Thread Xiao Guang Chen
v6. 1. Change the filter name from _filter_s390 to _filter_orphan. 2. Update the output file for tese case 081 because no default floopy and cd-rom. v5: 1. Add a pc specific output file for test 051. 2. Add a filter to test case 051 to filter s390 specific warnings. 3. Check whether the machine t

[Qemu-devel] [PATCH RFC v6 5/5] qemu-iotests: s390x: fix test 051

2015-02-11 Thread Xiao Guang Chen
The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A x86 platform specific output file is also needed.

Re: [Qemu-devel] [v5 07/12] migration: Split the function ram_save_page

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Split the function ram_save_page for code reuse purpose. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang you can do s/ram_save_page/ram_save_zero_page/ on $subject?

[Qemu-devel] [PATCH] qemu-img convert: Fix copy length for the iteration

2015-02-11 Thread Kevin Wolf
qemu-img converts already checks the block status of the next sectors to copy and skips them if it knows that they don't need to be copied (e.g. because they are zero and the destination is zero-initialised). It doesn't, however, limit the number of sectors read to the number of allocated sectors

Re: [Qemu-devel] [v5 02/12] migration: Add the framework of multi-thread compression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Add the code to create and destroy the multiple threads those will > be used to do data compression. Left some functions empty to keep > clearness, and the code will be added later. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert A

Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs

2015-02-11 Thread Amit Shah
On (Fri) 06 Feb 2015 [13:41:26], Tiejun Chen wrote: > Actually we define these device IDs in virtio standard, so > we'd better put them into one common place to manage conveniently. > Here I also add VIRTIO_ID_RESERVE according to virtio spec. > > Signed-off-by: Tiejun Chen Reviewed-by: Amit Sha

Re: [Qemu-devel] [PATCH 9/9] Convert ram_list to RCU

2015-02-11 Thread Paolo Bonzini
On 11/02/2015 09:47, Fam Zheng wrote: >> > +rcu_read_lock(); >> > +block = atomic_rcu_read(&ram_list.mru_block); >> > if (block && block->host && host - block->host < block->max_length) { >> > goto found; >> > } >> > >> > -QLIST_FOREACH(block, &ram_list.blocks, ne

[Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-11 Thread Daniel P. Berrange
Add a new 'guest-set-user-password' command for changing the password of guest OS user accounts. This command is needed to enable OpenStack to support its API for changing the admin password of guests running on KVM/QEMU. It is not practical to provide a command at the QEMU level explicitly targett

[Qemu-devel] [PATCH] cutils: refine strtol error handling in parse_debug_env

2015-02-11 Thread Paolo Bonzini
Avoid truncation of a 64-bit long to a 32-bit int, and check for errno (especially ERANGE). Signed-off-by: Paolo Bonzini --- v1->v2: clear errno before strtol --- util/cutils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/util/cutils.c b/util/cutils.c index db

Re: [Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Implement the core logic of the multiple thread compression. At this > point, multiple thread compression can't co-work with xbzrle yet. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- a/arch_init.c > +++ b/arch_init.c > @@ -363,18 +363,44 @@ static QemuMutex *c

Re: [Qemu-devel] [v5 09/12] migration: Make compression co-work with xbzrle

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Now, multiple thread compression can co-work with xbzrle. when > xbzrle is on, multiple thread compression will only work at the > first round of RAM data sync. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert Drop this patch and ju

Re: [Qemu-devel] [v5 10/12] migration: Add the core code for decompression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Implement the core logic of multiple thread decompression, > the decompression can work now. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang I think it should be a good idea to use the same scheme for compression and decompression. So, if you decide to use my proposal

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] openpic: convert to vmstate

2015-02-11 Thread Amit Shah
On (Fri) 06 Feb 2015 [15:41:38], Mark Cave-Ayland wrote: > On 06/02/15 14:51, Alexander Graf wrote: > > > On 06.02.15 15:36, Mark Cave-Ayland wrote: > >> This patchset follows on from my ppc loadvm/savevm work and converts > >> openpic over to vmstate. > >> > >> With these patches applied, I can s

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Add the qmp and hmp commands to tune and query the parameters used in > live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang I agree with the existence of this changes, and we could use them for existing paramenters like migration_speed (independent of this

Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs

2015-02-11 Thread Amit Shah
On (Mon) 09 Feb 2015 [20:57:42], Michael S. Tsirkin wrote: > On Fri, Feb 06, 2015 at 01:41:26PM +0800, Tiejun Chen wrote: > > Actually we define these device IDs in virtio standard, so > > we'd better put them into one common place to manage conveniently. > > Here I also add VIRTIO_ID_RESERVE accor

Re: [Qemu-devel] [PATCH] Add 'setup' phase to docs for query-migrate QMP command

2015-02-11 Thread Juan Quintela
Alex Bligh wrote: > The QMP command 'query-migrate' returns the state 'setup' during > the setup phase. This patch documents it. > > Signed-off-by: Alex Bligh Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 8/9] balloon: Factor out common "is balloon active" test

2015-02-11 Thread Markus Armbruster
Eric Blake writes: > On 02/10/2015 11:39 AM, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >>> Signed-off-by: Markus Armbruster >>> --- >>> balloon.c | 29 +++-- >>> 1 file changed, 15 insertions(+), 14 deletions(-) >>> >>> diff --git a/

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.02.2015 um 18:20 hat Eric Blake geschrieben: >> On 02/10/2015 09:34 AM, Markus Armbruster wrote: >> > I've typed error_report("%s", error_get_pretty(ERR)) too many times >> > already, and I've fixed too many instances of qerror_report_err(ERR) >> > to error_report("%s",

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-11 Thread Michael S. Tsirkin
On Wed, Feb 11, 2015 at 03:46:20AM +, Peter Maydell wrote: > On 11 February 2015 at 02:50, Chen, Tiejun wrote: > > On 2015/2/11 10:03, Peter Maydell wrote: > >> The linux-headers/ directory contains header files which can only > >> validly be included if the host we're compiling on is Linux. S

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-11 Thread Michael S. Tsirkin
On Wed, Feb 11, 2015 at 02:12:35AM +, Peter Maydell wrote: > On 9 February 2015 at 19:56, Michael S. Tsirkin wrote: > > +rm -rf "$output/standard-headers/linux" > > +mkdir -p "$output/standard-headers/linux" > > +for f in $tmpdir/include/linux/virtio*h; do > > +header=$(expr "$f" : '.*/\(.

Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs

2015-02-11 Thread Michael S. Tsirkin
On Wed, Feb 11, 2015 at 05:25:29PM +0530, Amit Shah wrote: > On (Mon) 09 Feb 2015 [20:57:42], Michael S. Tsirkin wrote: > > On Fri, Feb 06, 2015 at 01:41:26PM +0800, Tiejun Chen wrote: > > > Actually we define these device IDs in virtio standard, so > > > we'd better put them into one common place

Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs

2015-02-11 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 09:47:20AM +0100, Cornelia Huck wrote: > On Mon, 09 Feb 2015 15:10:17 +0800 > "Chen, Tiejun" wrote: > > > On 2015/2/9 15:02, Michael S. Tsirkin wrote: > > > On Mon, Feb 09, 2015 at 03:01:15PM +0800, Chen, Tiejun wrote: > > >> On 2015/2/8 18:48, Michael S. Tsirkin wrote: >

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/02/2015 17:34, Markus Armbruster wrote: >> I've typed error_report("%s", error_get_pretty(ERR)) too many times >> already, and I've fixed too many instances of qerror_report_err(ERR) >> to error_report("%s", error_get_pretty(ERR)) as well. Capture the >> pattern in

Re: [Qemu-devel] [PATCH] balloon: Fix typo

2015-02-11 Thread Markus Armbruster
Eric Blake writes: > Commit 422e0501 introduced a typo (unless removing an 'o' from > balloon is how you deflate it?) > > Signed-off-by: Eric Blake > --- > > I'm usually good at spotting typos when giving my R-b. Oh well, > Dave is doing well to make sure my ego doesn't get too inflated :) You

Re: [Qemu-devel] [PATCH] monitor: Fix Resource leak

2015-02-11 Thread Markus Armbruster
writes: > From: Gonglei > > Coverity spot: > qemu_using_spice allocates memory that is stored into err, > but not freed before return. > > Cc:Markus Armbruster > Signed-off-by: Gonglei > --- > monitor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/monitor.c b/mon

Re: [Qemu-devel] [RFC PATCH v8 16/21] replay: bottom halves

2015-02-11 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces bottom half event for replay queue. It saves the > > events > > into the queue and process them at the checkpoints and instructions > > execution. > > Which bottom halves mu

[Qemu-devel] Coccinelle semantic patches (was Re: [PATCH 1/9] error: New convenience function error_report_err())

2015-02-11 Thread Eduardo Habkost
On Wed, Feb 11, 2015 at 11:17:40AM +0100, Paolo Bonzini wrote: > > > On 10/02/2015 23:04, Eduardo Habkost wrote: > > $ spatch --sp-file /tmp/error_report.spatch $(git grep -l error_report) > > > /tmp/error_report.patch > > Does it work without specifying any include path? I didn't even know it

Re: [Qemu-devel] [PATCH] memory: unregister AddressSpace MemoryListener within BQL

2015-02-11 Thread Michael Roth
Quoting Paolo Bonzini (2015-02-11 01:30:00) > On 11/02/2015 06:13, Michael Roth wrote: > > (gdb) print node > > $1 = (struct rcu_head *) 0x11189a68 > > (gdb) print node->func > > $2 = (RCUCBFunc *) 0x0 > > (gdb) print node->next > > $3 = (struct rcu_head *) 0x3fff9800d4f0 > > > > I've seen it on b

Re: [Qemu-devel] [PATCH] softfloat: roundAndPackFloat16 should return FPInfinity and FPMaxNormal based on overflow_to_inf.

2015-02-11 Thread Peter Maydell
On 9 February 2015 at 14:56, Xiangyu Hu wrote: > Flag overflow_to_inf is specified by ARM manual to decide if > FPInfinity(sign) or FPMaxNormal(sign) is returned. Current > codepath fails to check it. > Fixed by adding overflow_to_inf flag to return infinity when it's > true and maxnormal otherwis

Re: [Qemu-devel] [PATCH] memory: unregister AddressSpace MemoryListener within BQL

2015-02-11 Thread Paolo Bonzini
On 11/02/2015 14:16, Michael Roth wrote: > Since the AddressSpace is a fields of PCIDevice, do we maybe need to make > sure it's refcount doesn't drop to 0 prior to the RCU callback taking > place? Yes, but then the problem is that objects are finalized outside the big QEMU lock. This is a pret

Re: [Qemu-devel] [PATCH v2 1/2] target-mips: Rework ABIs to allow all required configurations

2015-02-11 Thread Maciej W. Rozycki
On Mon, 9 Feb 2015, Peter Maydell wrote: > >> I'm not sure if it's a good idea to change the meaning of linux-user > >> qemu-mips64 and qemu-mips64el, this will cause unnecessary confusion in > >> my opinion. I think we’d be better off leaving it consistent across QEMU > >> versions. > > > > Well

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-11 Thread Peter Maydell
On 11 February 2015 at 12:33, Michael S. Tsirkin wrote: > On Wed, Feb 11, 2015 at 02:12:35AM +, Peter Maydell wrote: >> On 9 February 2015 at 19:56, Michael S. Tsirkin wrote: >> > +rm -rf "$output/standard-headers/linux" >> > +mkdir -p "$output/standard-headers/linux" >> > +for f in $tmpdir/i

Re: [Qemu-devel] [PATCH] block:Fix FIXED base vpc be probed to raw format

2015-02-11 Thread Stefan Hajnoczi
On Tue, Feb 10, 2015 at 11:04:31PM +0800, Xiaodong Gong wrote: > On Mon, Feb 9, 2015 at 10:54 PM, Stefan Hajnoczi wrote: > > > On Sun, Feb 08, 2015 at 08:39:52PM +0800, Xiaodong Gong wrote: > > > When open the vpc snapshot based FIXED format, its backing file, > > > this FIXED vpc image, could be

Re: [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg

2015-02-11 Thread Markus Armbruster
writes: > From: Gonglei > > Yestoday, I found that some files have superflous '\n' charactor > around error_report/error_setg when reviewed patches. > > By a simply script, the below files were listed. Classify and fix > them. It's suitable for appling via qemu-trivial IMHO. You can find my scr

Re: [Qemu-devel] [PATCH] cutils: refine strtol error handling in parse_debug_env

2015-02-11 Thread Eric Blake
On 02/11/2015 04:30 AM, Paolo Bonzini wrote: > Avoid truncation of a 64-bit long to a 32-bit int, and check for errno > (especially ERANGE). > > Signed-off-by: Paolo Bonzini > --- > v1->v2: clear errno before strtol > --- > util/cutils.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 dele

Re: [Qemu-devel] [PATCH v6 01/24] qcow2: Add two new fields to BDRVQcowState

2015-02-11 Thread Eric Blake
On 02/10/2015 01:28 PM, Max Reitz wrote: > Add two new fields regarding refcount information (the bit width of > every entry and the maximum refcount value) to the BDRVQcowState. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 4 ++-- > block/qcow2.c | 3 +++ > block/qcow2

Re: [Qemu-devel] [PATCH RFC] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-11 Thread Michael S. Tsirkin
On Wed, Feb 11, 2015 at 01:29:53PM +, Peter Maydell wrote: > On 11 February 2015 at 12:33, Michael S. Tsirkin wrote: > > On Wed, Feb 11, 2015 at 02:12:35AM +, Peter Maydell wrote: > >> On 9 February 2015 at 19:56, Michael S. Tsirkin wrote: > >> > +rm -rf "$output/standard-headers/linux" >

Re: [Qemu-devel] [PATCH] qemu-img convert: Fix copy length for the iteration

2015-02-11 Thread Max Reitz
On 2015-02-11 at 06:08, Kevin Wolf wrote: qemu-img converts already checks the block status of the next sectors to copy and skips them if it knows that they don't need to be copied (e.g. because they are zero and the destination is zero-initialised). It doesn't, however, limit the number of sect

Re: [Qemu-devel] [PULL 0/4] coverity: Improve and extend model

2015-02-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/02/2015 18:11, Peter Maydell wrote: >> On 5 February 2015 at 16:24, Markus Armbruster wrote: >>> The following changes since commit ec6f25e788ef57ce1e9f734984ef8885172fd9e2: >>> >>> Merge remote-tracking branch >>> remotes/rth/tags/pull-tg-s390-20150203' into stag

[Qemu-devel] [PATCH 0/2] qemu-img: Fix qemu-img convert -n

2015-02-11 Thread Max Reitz
Even when specifying -n to suppress image creation with qemu-img convert, that function tried to verify that the target protocol and driver are suited for image creation. This verification should be suppressed, too (which is what the first patch in this series does, the second one adds a test for i

[Qemu-devel] [PATCH 2/2] iotests: Add test for qemu-img convert to NBD

2015-02-11 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/123 | 62 ++ tests/qemu-iotests/123.out | 9 +++ tests/qemu-iotests/group | 1 + 3 files changed, 72 insertions(+) create mode 100755 tests/qemu-iotests/123 create mode 100644 tests/qemu-iote

[Qemu-devel] [PATCH 1/2] qemu-img: Fix qemu-img convert -n

2015-02-11 Thread Max Reitz
If -n is specified, it does not matter whether the output format and protocol support image creation; building the creation options should simply be skipped. Signed-off-by: Max Reitz --- qemu-img.c | 50 ++ 1 file changed, 26 insertions(+), 24 dele

Re: [Qemu-devel] [PATCH v2 0/4] Add support for passthru cards to libcacard

2015-02-11 Thread Jeremy White
Ping? Anything I can do to get review/motion on these patches? Cheers, Jeremy On 01/20/2015 09:38 AM, Jeremy White wrote: > This differs from v1 by: > * checkpatch review > * Patch series, instead of one patch > * Remove internal queue in favor of relying on thread safety of pcsclite >

Re: [Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err()

2015-02-11 Thread Eric Blake
On 02/10/2015 09:34 AM, Markus Armbruster wrote: > Tree-wide cleanup, but the tree-wide changes are mechanical. If > nobody objects, I'll route it through my own tree. > > Depends on my "[PATCH] vhost-scsi: Improve error reporting for invalid > vhostfd". > > PATCH 01 is responsible for the bulk

Re: [Qemu-devel] [PATCH 0/6] TriCore: Add RRR1 and RRR2 instructions

2015-02-11 Thread Bastian Koppelmann
On 02/10/2015 03:18 PM, Bastian Koppelmann wrote: Hi, the patchset fixes two minor bugs and takes care of all the packed/fixed point mac instructions. So far I only implemented all the multiply-add instructions, since the multiply-sub instructions are similar and I don't want the reviewers to f

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Fix qemu-img convert -n

2015-02-11 Thread Eric Blake
On 02/11/2015 07:58 AM, Max Reitz wrote: > Even when specifying -n to suppress image creation with qemu-img > convert, that function tried to verify that the target protocol and > driver are suited for image creation. This verification should be > suppressed, too (which is what the first patch in t

Re: [Qemu-devel] [PATCH] qemu-img convert: Fix copy length for the iteration

2015-02-11 Thread Kevin Wolf
Am 11.02.2015 um 15:39 hat Max Reitz geschrieben: > On 2015-02-11 at 06:08, Kevin Wolf wrote: > >qemu-img converts already checks the block status of the next sectors to > >copy and skips them if it knows that they don't need to be copied (e.g. > >because they are zero and the destination is zero-i

Re: [Qemu-devel] [PATCH v6 04/24] qcow2: Only return status from qcow2_get_refcount

2015-02-11 Thread Eric Blake
On 02/10/2015 01:28 PM, Max Reitz wrote: > Refcounts can theoretically be of type uint64_t; in order to be able to > represent the full range, qcow2_get_refcount() cannot use a single > variable to represent both all refcount values and also keep some values > reserved for errors. > > One solution

[Qemu-devel] [PATCH v2 0/6] TriCore: Add RRR1 and RRR2 instructions

2015-02-11 Thread Bastian Koppelmann
Hi, the patchset fixes two minor bugs and takes care of all the packed/fixed point mac instructions. So far I only implemented all the multiply-add instructions, since the multiply-sub instructions are similar and I don't want the reviewers to find the same mistakes twice. Once these are reviewed

[Qemu-devel] [PATCH v2 4/6] target-tricore: Add instructions of RRR1 opcode format, which have 0x83 as first opcode

2015-02-11 Thread Bastian Koppelmann
Add helpers: * add64_ssov: adds two 64 bit values and saturates the result. * addr_h/_ssov: adds two halfwords with two words in q-format with rounding / and saturates each result independetly. Add microcode generator: * gen_add64_d: adds two 64 bit values. * ge

[Qemu-devel] [PATCH v2 1/6] target-tricore: Fix RLC_ADDI, RLC_ADDIH using wrong microcode helper

2015-02-11 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index a73b700..cfd6a77 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c @@ -4183

[Qemu-devel] [PATCH v2 2/6] target-tricore: fix msub32_suov return wrong results

2015-02-11 Thread Bastian Koppelmann
If the signed result of the multiplication overflows, we would get a negative value, which would result in a addition instead of a subtraction. Now we do the overflow calculation and saturation by hand instead of using suov32_neg. Signed-off-by: Bastian Koppelmann --- target-tricore/op_helper.c

[Qemu-devel] [PATCH v2 3/6] target-tricore: Add instructions of RRR2 opcode format

2015-02-11 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 149 +++ target-tricore/tricore-opcodes.h | 2 +- 2 files changed, 136 insertions(+), 15 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index cfd6a77.

[Qemu-devel] [PATCH v2 5/6] target-tricore: Add instructions of RRR1 opcode format, which have 0x43 as first opcode

2015-02-11 Thread Bastian Koppelmann
Add helpers: * madd64_q_ssov: multiply two 32 bit q-format number, add them with a 64 bit q-format number and saturate. * madd32_q_add_ssov: add two 64 bit q-format numbers and return a 32 bit result. * maddr_q_ssov: multiplay two 32 bit q-f

[Qemu-devel] [PATCH v2 6/6] target-tricore: Add instructions of RRR1 opcode format, which have 0xc3 as first opcode

2015-02-11 Thread Bastian Koppelmann
Add helpers helper_addsur_h/_ssov which adds one halfword and subtracts one halfword, rounds / and saturates each half word independently. Add microcode helper functions: * gen_maddsu_h/sus_h: multiply two halfwords left justified and add to the first one word and sub

Re: [Qemu-devel] [PATCH RFC v6 2/5] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 081 and 087

2015-02-11 Thread Max Reitz
On 2015-02-11 at 05:37, Xiao Guang Chen wrote: This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices such as the floopy a

Re: [Qemu-devel] [PATCH RFC v6 5/5] qemu-iotests: s390x: fix test 051

2015-02-11 Thread Max Reitz
On 2015-02-11 at 05:37, Xiao Guang Chen wrote: The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A

[Qemu-devel] [PATCH] vpc: Fix size in fixed image creation

2015-02-11 Thread Kevin Wolf
If total_sectors is rounded to match the geometry, total_size needs to be changed as well. Otherwise we end up with an image whose geometry describes a disk larger than the image file, which doesn't end well. Signed-off-by: Kevin Wolf --- block/vpc.c | 10 +++--- 1 file changed, 3 insertions

[Qemu-devel] [RFC PATCH v3 0/3] VFIO support for AMBA devices

2015-02-11 Thread Baptiste Reynal
The following series add VFIO support for AMBA devices. It introduces multiple compatible string support to deal with arm,primecell compatible string. The VFIOPlatformDevice now checks for this string and performs amba specific operations if it is present (change path of the device, add clock in

[Qemu-devel] [PATCH] vpc: Implement bdrv_co_get_status()

2015-02-11 Thread Kevin Wolf
This implements bdrv_co_get_status() for VHD images. This can significantly speed up qemu-img convert operation because only with this function implemented sparseness can be considered. (Before, converting a 1 TB empty image took several minutes for me, now it's instantaneous.) Signed-off-by: Kevi

[Qemu-devel] [RFC PATCH v3 1/3] hw/vfio/sysbus-fdt: helper routines to create fdt nodes

2015-02-11 Thread Baptiste Reynal
Creates set_interrupts_fdt_node and set_regions_fdt_node for code reusability. Signed-off-by: Baptiste Reynal --- v2 -> v3: handle intermediate ret values in set_regions_fdt_node and set_interrupts_fdt_node --- hw/arm/sysbus-fdt.c | 129 1 fi

[Qemu-devel] [RFC PATCH v3 2/3] hw/vfio: amba device support

2015-02-11 Thread Baptiste Reynal
Add VFIO_DEVICE_TYPE_AMBA. Differentiate amba and platform devices according to compatible string. Signed-off-by: Baptiste Reynal --- v2 -> v3: add amba flag check in vfio_populate_device --- hw/vfio/platform.c| 20 +++- include/hw/vfio/vfio-common.h | 1 + 2 files

Re: [Qemu-devel] [PATCH RFC v6 5/5] qemu-iotests: s390x: fix test 051

2015-02-11 Thread Max Reitz
On 2015-02-11 at 11:23, Markus Armbruster wrote: Max Reitz writes: On 2015-02-11 at 05:37, Xiao Guang Chen wrote: The tests for device type "ide_cd" should only be tested for the pc platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new va

[Qemu-devel] [RFC PATCH v3 3/3] hw/vfio: add pl330 device support

2015-02-11 Thread Baptiste Reynal
Create a meta-device for PL330 DMA. Add add_arm_pl330_fdt_node function, with multiple compatible string and clocks support. Signed-off-by: Baptiste Reynal --- v2 -> v3: got to fail in case of apb_pclk missing free nodename in fail case --- hw/arm/sysbus-fdt.c | 85

Re: [Qemu-devel] [PATCH v12 05/17] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable

2015-02-11 Thread Max Reitz
On 2015-02-09 at 20:35, John Snow wrote: This allows to put the dirty bitmap into a disabled state where it is read only. A disabled bitmap will ignore any attempts to set or reset any of its bits, but can otherwise be renamed, deleted, or re-enabled. It will be used before backup or writing to

[Qemu-devel] [RFC PATCH v2 1/4] linux-headers update

2015-02-11 Thread Baptiste Reynal
Add VFIO device property constants Signed-off-by: Baptiste Reynal --- linux-headers/linux/vfio.h | 25 + 1 file changed, 25 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index 58f549c..1d16c12 100644 --- a/linux-headers/linux/vfio.h +

[Qemu-devel] [RFC PATCH v2 4/4] hw/arm/sysbus-fdt: arm, pl330 vfio device property

2015-02-11 Thread Baptiste Reynal
Adapt arm,pl330 function to use the vfio device property API. Clock apb-pclk is the default if a clock is needed by the device. Three optional parameters are taken into account : - #dma-cells - #dma-channels - #dma-requests Signed-off-by: Baptiste Reynal --- v1 -> v2: add some comments free po

[Qemu-devel] [RFC PATCH v2 0/4] VFIO platform: Use device properties API

2015-02-11 Thread Baptiste Reynal
This RFC shows the implementation on QEMU side of the device properties interface presented in kernel patch series: [RFC PATCH v3 0/3] vfio: platform: return device properties for a platform device from branch vfio-device-properties-v3 on the repository: https://github.com/virtualopensystems/linu

[Qemu-devel] [RFC PATCH v2 2/4] hw/vfio/common.c : vfio_get_dev_property

2015-02-11 Thread Baptiste Reynal
Add a function to handle ioctl VFIO_DEVICE_GET_DEV_PROPERTY to retrieve properties from a VFIO device. Signed-off-by: Baptiste Reynal --- v1 -> v2: fix property->length initialization --- hw/vfio/common.c | 32 include/hw/vfio/vfio-common.h | 2 ++

[Qemu-devel] [RFC PATCH v2 3/4] hw/arm/sysbus-fdt: vfio device property for interrupts

2015-02-11 Thread Baptiste Reynal
Use the VFIO device property API to retrieve interrupt information (type and flags) during device node creation. Signed-off-by: Baptiste Reynal --- v1 -> v2: check irq_prop->data size add some comments --- hw/arm/sysbus-fdt.c | 23 +-- 1 file changed, 17 insertions(+), 6 del

Re: [Qemu-devel] [PATCH] vpc: Implement bdrv_co_get_status()

2015-02-11 Thread Kevin Wolf
Am 11.02.2015 um 17:23 hat Kevin Wolf geschrieben: > This implements bdrv_co_get_status() for VHD images. This can s/bdrv_co_get_status/bdrv_co_get_block_status/, obviously (in the subject as well). > significantly speed up qemu-img convert operation because only with this > function implemented

[Qemu-devel] [PATCH] vnc: fix coverity warning

2015-02-11 Thread Gerd Hoffmann
vnc_display_local_addr will not be called with an invalid display id. Add assert() to silence coverity warning about a null pointer dereference. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/vnc.c b/ui/vnc.c index e291987..25ba340 100644 --- a/u

Re: [Qemu-devel] [PATCH v6 05/24] qcow2: Use unsigned addend for update_refcount()

2015-02-11 Thread Eric Blake
On 02/10/2015 01:28 PM, Max Reitz wrote: > update_refcount() and qcow2_update_cluster_refcount() currently take a > signed addend. At least one caller passes a value directly derived from > an absolute refcount that should be reached ("l2_refcount - 1" in > expand_zero_clusters_in_l1()). Therefore,

Re: [Qemu-devel] [PATCH] vnc: fix coverity warning

2015-02-11 Thread Paolo Bonzini
On 11/02/2015 17:37, Gerd Hoffmann wrote: > vnc_display_local_addr will not be called with an invalid display id. > Add assert() to silence coverity warning about a null pointer dereference. > > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

[Qemu-devel] [PATCH] spice: fix memory leak

2015-02-11 Thread Gerd Hoffmann
Found by coverity. Signed-off-by: Gerd Hoffmann --- monitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/monitor.c b/monitor.c index c3cc060..29d7e5b 100644 --- a/monitor.c +++ b/monitor.c @@ -1101,6 +1101,7 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict, if (s

Re: [Qemu-devel] [PATCH] spice: fix memory leak

2015-02-11 Thread Paolo Bonzini
On 11/02/2015 17:44, Gerd Hoffmann wrote: > Found by coverity. > > Signed-off-by: Gerd Hoffmann > --- > monitor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor.c b/monitor.c > index c3cc060..29d7e5b 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1101,6 +1101,7 @@ static i

[Qemu-devel] [PATCH v2 3/3] Document -incoming options

2015-02-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Document the various URI formats for -incoming, the previous manpage and help text was wrong (out of date?) Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela --- qemu-options.hx | 29 ++--- 1 file changed, 26 insertions(+),

[Qemu-devel] [PATCH v2 0/3] -incoming pause

2015-02-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This patchset provides a way of setting options on an incoming migration before the fd/process/socket has been created. start qemu with -incoming pause migrate_incoming theuri v2: Create migrate_incoming/migrate-incoming rather than squashing the -u

[Qemu-devel] [PATCH v2 1/3] Add -incoming pause

2015-02-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" -incoming pause causes qemu to wait for an incoming migration to be specified later. The monitor can be used to set migration capabilities that may affect the incoming connection process. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela --- migr

  1   2   3   >