[Qemu-devel] [PULL 13/46] qemu-log: Correct help text of 'log cpu_reset'

2015-02-10 Thread Michael Tokarev
From: Thomas Huth The logging of the CPU state during reset is done for all architectures nowadays (see cpu_common_reset() in qom/cpu.c), so the "x86 only" text does not apply here anymore. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- qemu-log.c | 2 +- 1 file changed, 1 inse

[Qemu-devel] [PULL 14/46] cpu-exec: drop dead assignment

2015-02-10 Thread Michael Tokarev
From: Paolo Bonzini All uses of TB inside cpu_exec are dominated by "tb = tb_find_fast(env)", and there are no uses after the switch statement. So the assignment is dead, as reported by Coverity. Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- cpu-exec.c | 1 - 1 file changed

[Qemu-devel] [PULL 27/46] util/uri: realloc2n() can't fail, drop dead error handling

2015-02-10 Thread Michael Tokarev
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Michael Tokarev --- util/uri.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/util/uri.c b/util/uri.c index aa39694..b9a7b54 100644 --- a/util/uri.c +++ b/util/uri.c @@ -1049,14 +1049,12 @@ uri_

[Qemu-devel] [PULL 31/46] onenand: g_malloc() can't fail, bury dead error handling

2015-02-10 Thread Michael Tokarev
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Gonglei Signed-off-by: Michael Tokarev --- hw/block/onenand.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/block/onenand.c b/hw/block/onenand.c index 348630d..1b2c89

Re: [Qemu-devel] [PATCH v2] nbd: fix the co_queue multi-adding bug

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 08:20, Bin Wu wrote: > From: Bin Wu > > When we tested the VM migartion between different hosts with NBD > devices, we found if we sent a cancel command after the drive_mirror > was just started, a coroutine re-enter error would occur. The stack > was as follow: > > (gdb) bt > 00

Re: [Qemu-devel] [PULL 14/46] cpu-exec: drop dead assignment

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 06:34, Michael Tokarev wrote: > From: Paolo Bonzini > > All uses of TB inside cpu_exec are dominated by "tb = tb_find_fast(env)", > and there are no uses after the switch statement. So the assignment > is dead, as reported by Coverity. > > Signed-off-by: Paolo Bonzini > S

Re: [Qemu-devel] [PULL 14/46] cpu-exec: drop dead assignment

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 10:15, Peter Maydell wrote: > > -tb = (TranslationBlock *)(next_tb & ~TB_EXIT_MASK); > > next_tb = 0; > > break; > > case TB_EXIT_ICOUNT_EXPIRED: > > True, I guess, but presumably this mea

Re: [Qemu-devel] [PATCH 1/2] vga: Expose framebuffer byteorder as a QOM property

2015-02-10 Thread Gerd Hoffmann
On Di, 2015-02-10 at 15:36 +1100, David Gibson wrote: > The VGA device model now supports having the framebuffer in either endian, > and can be switched between these by the guest via a register in the qext > region. > > However, in some cases (e.g. LE OS on the pseries machine) we have > existing

Re: [Qemu-devel] [PATCH] memsave: Improve and disambiguate error message

2015-02-10 Thread Borislav Petkov
On Sun, Feb 08, 2015 at 10:46:05PM +0100, Paolo Bonzini wrote: > I use ":set shiftwidth=4 expandtab" and c-indent mode. > > Quick googling for "vim four spaces" suggests the following alternatives: > > * ":set tabstop=8 expandtab shiftwidth=4 softtabstop=4" > > * "set tabstop=8 softtabstop=0 exp

[Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Hi, while migrating vServers from 2.1.0 to 2.2.0 I see the following assertion that seems to have been introduced between 2.1.0 and 2.2.0 trigger on the destination. This happens in a serious amount of cases. In most cases it works flawlessly on the second attempt to migrate the vServer (same

Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a valid modifier"

2015-02-10 Thread Christian Borntraeger
Am 09.02.2015 um 23:54 schrieb Peter Maydell: > On 9 February 2015 at 19:43, Christian Borntraeger > wrote: >> From: Andy Whitcroft >> >> checkpatch currently loops on fpu/softfloat.c >> Turns out this is fixed in the Linux version of checkpatch. >> >> So this is a port of Andy Whitcrofts fix fro

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 10:26, Peter Lieven wrote: > Hi, > > while migrating vServers from 2.1.0 to 2.2.0 I see the following > assertion that seems to have > been introduced between 2.1.0 and 2.2.0 trigger on the destination. This > happens in a serious > amount of cases. In most cases it works flawlessl

Re: [Qemu-devel] [PATCH v2 16/17] ahci: Recompute cur_cmd on migrate post load

2015-02-10 Thread Stefan Hajnoczi
On Tue, Dec 16, 2014 at 08:36:06PM -0500, John Snow wrote: > When the AHCI HBA device is migrated, all of the information that > led to the request being created is stored in the AHCIDevice > structures, except for pointers into guest data where return > information needs to be stored. > > The "cu

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-10 Thread Teruaki Ishizaki
(2015/02/10 17:58), Liu Yuan wrote: On Tue, Feb 10, 2015 at 05:22:02PM +0900, Teruaki Ishizaki wrote: (2015/02/10 12:10), Liu Yuan wrote: On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enab

Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2015-02-10 Thread Stefan Hajnoczi
On Tue, Dec 16, 2014 at 08:35:50PM -0500, John Snow wrote: > This series was written mostly by Paolo Bonzini to do two things: > > 1. Unify the restart callbacks for ISA, AHCI and BMDMA > 2. Ensure we can restart a command after migration > > Many of the early patches only make much sense conside

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 10:49 schrieb Paolo Bonzini: On 10/02/2015 10:26, Peter Lieven wrote: Hi, while migrating vServers from 2.1.0 to 2.2.0 I see the following assertion that seems to have been introduced between 2.1.0 and 2.2.0 trigger on the destination. This happens in a serious amount of cases

[Qemu-devel] [PULL 40/46] migration: Fix warnings caused by missing 'static' attribute

2015-02-10 Thread Michael Tokarev
From: Stefan Weil Warnings from the Sparse static analysis tool: migration-rdma.c:151:12: warning: symbol 'wrid_desc' was not declared. Should it be static? migration-rdma.c:190:12: warning: symbol 'control_desc' was not declared. Should it be static? migration-rdma.c:3301:19: warning: symbol

[Qemu-devel] [PULL 46/46] virtio: Fix warning caused by missing 'static' attribute

2015-02-10 Thread Michael Tokarev
From: Stefan Weil Warning from the Sparse static analysis tool: hw/char/virtio-serial-bus.c:31:3: warning: symbol 'vserdevices' was not declared. Should it be static? Cc: Amit Shah Cc: Anthony Liguori Cc: Michael S. Tsirkin Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw

[Qemu-devel] [PULL 20/46] linux-user: wrong TARGET_SI_PAD_SIZE value for some targets.

2015-02-10 Thread Michael Tokarev
From: Maxim Ostapenko Fix TARGET_SI_PAD_SIZE calculation to match the way the kernel does it. Use different TARGET_SI_PREAMBLE_SIZE for 32-bit and 64-bit targets. Signed-off-by: Maxim Ostapenko Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- linux-user/syscall_defs.h | 9 ++

[Qemu-devel] [PULL 05/46] Add/convert trace calls in pcnet-pci.c.

2015-02-10 Thread Michael Tokarev
From: Don Koch Add trace calls. Convert some #ifdef DEBUG printfs to trace. Signed-off-by: Don Koch Signed-off-by: Michael Tokarev --- hw/net/pcnet-pci.c | 49 +++-- trace-events | 12 2 files changed, 31 insertions(+), 30 deletio

[Qemu-devel] [PULL 23/46] qemu-option: Pair g_malloc() with g_free(), not free()

2015-02-10 Thread Michael Tokarev
From: Markus Armbruster Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled and my "coverity: Model g_free() isn't necessarily free()" model patch applied. Signed-off-by: Markus Armbruster Reviewed-by: Gonglei Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- util/

Re: [Qemu-devel] [PATCH v2] qemu-coroutine: segfault when restarting co_queue

2015-02-10 Thread Kevin Wolf
Am 09.02.2015 um 15:48 hat Stefan Hajnoczi geschrieben: > On Mon, Feb 09, 2015 at 02:50:39PM +0800, Bin Wu wrote: > > From: Bin Wu > > > > We tested VMs migration with their disk images by drive_mirror. With > > migration, two VMs copyed large files between each other. During the > > test, a segf

[Qemu-devel] [PULL 33/46] kvm: g_malloc() can't fail, bury dead error handling

2015-02-10 Thread Michael Tokarev
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Gonglei Signed-off-by: Michael Tokarev --- kvm-all.c | 4 1 file changed, 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 2f21a4e..05a79c2 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -20

Re: [Qemu-devel] [PATCH v2 0/3] fix qemu crash about vnc

2015-02-10 Thread Gerd Hoffmann
On Fr, 2015-01-30 at 10:14 +0800, arei.gong...@huawei.com wrote: > Gonglei (3): > vnc: fix qemu crash when not configure vnc option > vnc: correct missing property about vnc_display > vnc: using bool type instead of int for QEMU_OPT_BOOL Added to vnc queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 0/2] vnc: fix two bugs about qmp_change vnc

2015-02-10 Thread Gerd Hoffmann
On Do, 2015-02-05 at 17:43 +0800, arei.gong...@huawei.com wrote: > Gonglei (2): > vnc: introduce an wrapper for auto assign vnc id > vnc: auto assian an id when calling change vnc qmp interface Added to vnc patch queue. thanks, Gerd

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 11:03, Peter Lieven wrote: > > My hope was that anyone has observed this post 2.2.0 already and there > is a fix available ;-) > > Can you indicate what info would be helpful debugging this? > > Cmdline is: > /usr/bin/qemu-2.2.0 -enable-kvm -M pc-i440fx-2.1 -nodefaults -netdev

Re: [Qemu-devel] [PATCH] ui/vnc: optimize full scanline updates

2015-02-10 Thread Gerd Hoffmann
On Mo, 2015-02-02 at 16:25 +0100, Peter Lieven wrote: > in case we send and update for a complete scanline increment > the y offset to avoid running to find_next_bit for that lines > twice. Added to vnc patch queue. thanks, Gerd

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 11:17 schrieb Paolo Bonzini: On 10/02/2015 11:03, Peter Lieven wrote: My hope was that anyone has observed this post 2.2.0 already and there is a fix available ;-) Can you indicate what info would be helpful debugging this? Cmdline is: /usr/bin/qemu-2.2.0 -enable-kvm -M pc-

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 11:24, Peter Lieven wrote: >>> >> First of all (but unrelated to the bug) do not use "-cpu qemu64" with >> KVM. > > I remember there was an issue with kvm64 anytime in the past, but this > is ages ago I think. I will change that for new vserver starts. What > (which flag) is the e

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 11:17 schrieb Paolo Bonzini: On 10/02/2015 11:03, Peter Lieven wrote: My hope was that anyone has observed this post 2.2.0 already and there is a fix available ;-) Can you indicate what info would be helpful debugging this? Cmdline is: /usr/bin/qemu-2.2.0 -enable-kvm -M pc-

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 16:46, Michael S. Tsirkin wrote: > On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: >> From: Linhaifeng >> >> Slave should reply to master and set u64 to 0 if >> mmap all regions success otherwise set u64 to 1. >> >> Signed-off-by: Linhaifeng > > How does this work with

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 11:25 schrieb Paolo Bonzini: On 10/02/2015 11:24, Peter Lieven wrote: First of all (but unrelated to the bug) do not use "-cpu qemu64" with KVM. I remember there was an issue with kvm64 anytime in the past, but this is ages ago I think. I will change that for new vserver star

Re: [Qemu-devel] [PATCH v3] qemu-coroutine: segfault when restarting co_queue

2015-02-10 Thread Kevin Wolf
Am 10.02.2015 um 06:16 hat Bin Wu geschrieben: > From: Bin Wu > > We tested VMs migration with their disk images by drive_mirror. With > migration, two VMs copyed large files between each other. During the > test, a segfault occured. The stack was as follow: > > 00) 0x7fa5a0c63fc5 in qemu_c

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-10 Thread Liu Yuan
On Tue, Feb 10, 2015 at 06:56:33PM +0900, Teruaki Ishizaki wrote: > (2015/02/10 17:58), Liu Yuan wrote: > >On Tue, Feb 10, 2015 at 05:22:02PM +0900, Teruaki Ishizaki wrote: > >>(2015/02/10 12:10), Liu Yuan wrote: > >>>On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > Previousl

[Qemu-devel] [PATCH 2/3] coroutine: Clean up qemu_coroutine_enter()

2015-02-10 Thread Kevin Wolf
qemu_coroutine_enter() is now the only user of coroutine_swap(). Both functions are short, so inline it. Also, using COROUTINE_YIELD is now even more confusing because this code is never called during qemu_coroutine_yield() any more. In fact, this value is never read back, so we can just introduce

[Qemu-devel] [PATCH 0/3] coroutine: Fix qemu_coroutine_yield()

2015-02-10 Thread Kevin Wolf
Kevin Wolf (2): coroutine: Fix use after free with qemu_coroutine_yield() coroutine: Clean up qemu_coroutine_enter() Stefan Hajnoczi (1): test-coroutine: Regression test for yield bug include/block/coroutine_int.h | 1 + qemu-coroutine.c | 38 -

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 06:27:04PM +0800, Linhaifeng wrote: > > > On 2015/2/10 16:46, Michael S. Tsirkin wrote: > > On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: > >> From: Linhaifeng > >> > >> Slave should reply to master and set u64 to 0 if > >> mmap all regions success otherwise

[Qemu-devel] [PATCH 3/3] test-coroutine: Regression test for yield bug

2015-02-10 Thread Kevin Wolf
From: Stefan Hajnoczi This adds a test for reentering a coroutine that previously yielded to a coroutine that has meanwhile terminated. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/test-coroutine.c | 26 ++ 1 file changed, 26 insertions(+) diff -

[Qemu-devel] [PATCH 1/3] coroutine: Fix use after free with qemu_coroutine_yield()

2015-02-10 Thread Kevin Wolf
Instead of using the same function for entering and exiting coroutines, and hoping that it doesn't add any functionality that hurts with the parameters used for exiting, we can just directly call into the real task switch in qemu_coroutine_switch(). This fixes a use-after-free scenario where reent

Re: [Qemu-devel] [PULL 00/46] Trivial patches for 2015-02-10

2015-02-10 Thread Peter Maydell
On 10 February 2015 at 07:29, Michael Tokarev wrote: > The following changes since commit 89db21771782fd6050335e73542064f1187c9ced: > > qmp: unbreak build for non-vnc configuration (2015-02-09 22:36:04 +) > > are available in the git repository at: > > git://git.corpit.ru/qemu.git tags/pul

Re: [Qemu-devel] [PATCH 7/7] target-mips: Add IEEE 754-2008 features support

2015-02-10 Thread Leon Alrae
On 09/02/2015 20:55, Maciej W. Rozycki wrote: >>> +uint32_t helper_float_chs_s(CPUMIPSState *env, uint32_t fst0) >>> +{ >>> +uint32_t fst1; >>> + >>> +fst1 = float32_sub(0, fst0, &env->active_fpu.fp_status); >>> +update_fcr31(env, GETPC()); >>> +return fst1; >>> +} >> >> I think the

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 11:30, Peter Lieven wrote: >>> >> QEMU64 does not resemble any actual processor. You want the lowest >> denominator of your cluster, probably Nehalem. > > Ah okay. Normally, I compare the available cpu flags of my cluster > and pass those flags individually. Maybe I have to revisi

[Qemu-devel] [PATCH v4 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-02-10 Thread Greg Bellows
Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64 execution state hereby forcing EL1 to be AArch32. The new CPU co

[Qemu-devel] [PATCH v4 2/4] target-arm: Add feature parsing to virt

2015-02-10 Thread Greg Bellows
Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v3 -> v4 - Fix misspelling v1 -> v2 - Fix multiple property handling --- hw/arm/virt.c | 20

[Qemu-devel] [PATCH v4 3/4] target-arm: Add 32/64-bit register sync

2015-02-10 Thread Greg Bellows
Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows --- v3 -> v4 - Rework sync routines to cover various exception levels - Move sync routin

[Qemu-devel] [PATCH v4 1/4] target-arm: Add CPU property to disable AArch64

2015-02-10 Thread Greg Bellows
Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU invocation would have AArch64 execution state dis

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Marcelo Tosatti
On Tue, Feb 10, 2015 at 10:26:33AM +0100, Peter Lieven wrote: > Hi, > > while migrating vServers from 2.1.0 to 2.2.0 I see the following assertion > that seems to have > been introduced between 2.1.0 and 2.2.0 trigger on the destination. This > happens in a serious > amount of cases. In most cas

[Qemu-devel] [PATCH v4 4/4] target-arm: Add AArch32 guest support to KVM64

2015-02-10 Thread Greg Bellows
Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows --- v3 -> v4 - Add check that to make sure KVM64 is only being used on AArch64 family of machines. - Relocate register sync to follow register fet

Re: [Qemu-devel] [PATCH 2/3] coroutine: Clean up qemu_coroutine_enter()

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 11:41, Kevin Wolf wrote: > +ret = qemu_coroutine_switch(self, co, COROUTINE_ENTER); > + > +qemu_co_queue_run_restart(co); > + > +switch (ret) { > +case COROUTINE_YIELD: > +return; > +case COROUTINE_TERMINATE: > +trace_qemu_coroutine_terminate(co);

Re: [Qemu-devel] [PATCH 1/2] vga: Expose framebuffer byteorder as a QOM property

2015-02-10 Thread David Gibson
On Tue, Feb 10, 2015 at 10:19:58AM +0100, Gerd Hoffmann wrote: > On Di, 2015-02-10 at 15:36 +1100, David Gibson wrote: > > The VGA device model now supports having the framebuffer in either endian, > > and can be switched between these by the guest via a register in the qext > > region. > > > > Ho

Re: [Qemu-devel] [PATCH 2/3] coroutine: Clean up qemu_coroutine_enter()

2015-02-10 Thread Kevin Wolf
Am 10.02.2015 um 11:55 hat Paolo Bonzini geschrieben: > > > On 10/02/2015 11:41, Kevin Wolf wrote: > > +ret = qemu_coroutine_switch(self, co, COROUTINE_ENTER); > > + > > +qemu_co_queue_run_restart(co); > > + > > +switch (ret) { > > +case COROUTINE_YIELD: > > +return; > > +

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-10 Thread Liu Yuan
On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additio

Re: [Qemu-devel] [PATCH v3] qemu-coroutine: segfault when restarting co_queue

2015-02-10 Thread Bin Wu
On 2015/2/10 18:32, Kevin Wolf wrote: > Am 10.02.2015 um 06:16 hat Bin Wu geschrieben: >> From: Bin Wu >> >> We tested VMs migration with their disk images by drive_mirror. With >> migration, two VMs copyed large files between each other. During the >> test, a segfault occured. The stack was as f

Re: [Qemu-devel] [PATCH 2/3] coroutine: Clean up qemu_coroutine_enter()

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 12:09, Kevin Wolf wrote: >> > >> > 4 mutex->locked = false; >> > qemu_co_queue_next(&mutex->queue); >> >'--> qemu_co_queue_do_restart(queue, true); >> > '--> QTAILQ_REMOVE(&queue->entries, next, co_queue_next); >> > QTAILQ_INSERT_TAIL(&self->co_queue_wake

[Qemu-devel] [PULL 35/46] vnc: g_realloc() can't fail, bury dead error handling

2015-02-10 Thread Michael Tokarev
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Gonglei Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- ui/vnc.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index a742c90..02552ee 100644 --- a/ui/vnc.c

[Qemu-devel] [PULL 16/46] qemu-sockets: improve error reporting in unix_listen_opts

2015-02-10 Thread Michael Tokarev
From: Paolo Bonzini Coverity complains about not checking the returned value of mkstemp. While at it, also improve error checking for snprintf, and refine error messages in general. Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- util/qemu-sockets.c | 24 ++---

[Qemu-devel] [PULL 15/46] cpu-exec: simplify icount code

2015-02-10 Thread Michael Tokarev
From: Paolo Bonzini Use MIN instead of an "if" statement. Move "tb" assignment where the value is actually used. Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- cpu-exec.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c

[Qemu-devel] [PULL 44/46] stubs: Fix warning caused by missing include statement

2015-02-10 Thread Michael Tokarev
From: Stefan Weil Warning from the Sparse static analysis tool: stubs/qtest.c:14:6: warning: symbol 'qtest_allowed' was not declared. Should it be static? Add the missing include statement which declares qtest_allowed. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- stubs/qte

[Qemu-devel] [PULL 22/46] qemu-option: Replace pointless use of g_malloc0() by g_malloc()

2015-02-10 Thread Michael Tokarev
From: Markus Armbruster get_opt_value() takes a write-only buffer, so zeroing it is pointless. We don't do it elsewhere, either. Signed-off-by: Markus Armbruster Reviewed-by: Gonglei Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- util/qemu-option.c | 4 ++-- 1 file changed, 2 in

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-10 Thread Peter Lieven
Am 09.02.2015 um 17:09 schrieb Kevin Wolf: The CHS calculation as done per the VHD spec imposes a maximum image size of ~127 GB. Real VHD images exist that are larger than that. Apparently there are two separate non-standard ways to achieve this: You could use more heads than the spec does - thi

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Linhaifeng
On 2015/2/10 18:41, Michael S. Tsirkin wrote: > On Tue, Feb 10, 2015 at 06:27:04PM +0800, Linhaifeng wrote: >> >> >> On 2015/2/10 16:46, Michael S. Tsirkin wrote: >>> On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng wrote: From: Linhaifeng Slave should reply to master and set

Re: [Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a valid modifier"

2015-02-10 Thread Markus Armbruster
Christian Borntraeger writes: > Am 09.02.2015 um 23:54 schrieb Peter Maydell: >> On 9 February 2015 at 19:43, Christian Borntraeger >> wrote: >>> From: Andy Whitcroft >>> >>> checkpatch currently loops on fpu/softfloat.c >>> Turns out this is fixed in the Linux version of checkpatch. >>> >>> So

Re: [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad

2015-02-10 Thread Markus Armbruster
Since maintainers haven't picked it up: could this go in via -trivial? Peter Crosthwaite writes: > On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster wrote: >> The "fall through" added by the commit is clearly intentional. Mark >> it so. Hushes up Coverity. >> >> Signed-off-by: Markus Armbrus

Re: [Qemu-devel] [PATCH v1 1/2] vhost-user: support SET_MEM_TABLE waite the result of mmap

2015-02-10 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 07:59:16PM +0800, Linhaifeng wrote: > > > On 2015/2/10 18:41, Michael S. Tsirkin wrote: > > On Tue, Feb 10, 2015 at 06:27:04PM +0800, Linhaifeng wrote: > >> > >> > >> On 2015/2/10 16:46, Michael S. Tsirkin wrote: > >>> On Tue, Feb 10, 2015 at 01:48:12PM +0800, linhaifeng w

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 11:50 schrieb Marcelo Tosatti: On Tue, Feb 10, 2015 at 10:26:33AM +0100, Peter Lieven wrote: Hi, while migrating vServers from 2.1.0 to 2.2.0 I see the following assertion that seems to have been introduced between 2.1.0 and 2.2.0 trigger on the destination. This happens in a

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 13:17, Peter Lieven wrote: > > I have build my kvm module from > > http://git.kiszka.org/?p=kvm-kmod.git > > but it seems not to have been updates since October. > The patch is not in there. > > Is that repository not up to date anymore? Ahem, 3.19 was released last Sunday. Gi

Re: [Qemu-devel] [PATCH v2 00/11] cpu: add i386 cpu hot remove support

2015-02-10 Thread Zhi Yong Wu
On Fri, Feb 6, 2015 at 3:54 PM, Zhu Guihua wrote: > On Tue, 2015-02-03 at 16:41 +0800, Zhi Yong Wu wrote: >> HI, >> >> Can you push the patchset to a branch on github? It will be convenient >> for other guys to do some tests. > > sorry for late reply. > I had pushed into https://github.com/zhugh/q

[Qemu-devel] [PATCH] memory: unregister AddressSpace MemoryListener within BQL

2015-02-10 Thread Paolo Bonzini
address_space_destroy_dispatch is called from an RCU callback and hence outside the iothread mutex (BQL). However, after address_space_destroy no new accesses can hit the destroyed AddressSpace so it is not necessary to observe changes to the memory map. Move the memory_listener_unregister call e

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 13:35 schrieb Paolo Bonzini: On 10/02/2015 13:17, Peter Lieven wrote: I have build my kvm module from http://git.kiszka.org/?p=kvm-kmod.git but it seems not to have been updates since October. The patch is not in there. Is that repository not up to date anymore? Ahem, 3.19

Re: [Qemu-devel] [PATCH v2 03/12] acpi, mem-hotplug: Add acpi_memory_hotplug_sci() to rise sci for memory hotplug.

2015-02-10 Thread Igor Mammedov
On Wed, 4 Feb 2015 10:51:17 +0800 Zhu Guihua wrote: > From: Tang Chen > > Add a new API named acpi_memory_hotplug_sci() to send memory hotplug SCI. > Doing this is because this procedure will be used by other functions in the > next coming patches. Commit subj/message should be amended to refle

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 13:56, Peter Lieven wrote: >> Ahem, 3.19 was released last Sunday. Give us some breathing room... > > I missed the next branch. I checked that out and updated the submodule > to commit bfa76d49576599a4b9f9b7a71f23d73d6dcff735. > > Does that make sense? Yes, but it is still not r

[Qemu-devel] QEMU data passing between modules

2015-02-10 Thread boddu pavan
I am trying to emulate a status reg in qemu, but the value is dependent of the value of the register in another module. How can I communicate between the two modules to update the status register.Thanks

Re: [Qemu-devel] [PATCH v3 01/12] qcow2: Add new overlap check functions

2015-02-10 Thread Eric Blake
On 02/09/2015 12:25 PM, Max Reitz wrote: > The existing qcow2 metadata overlap detection function used existing > structures to determine the location of the image metadata, from plain > fields such as l1_table_offset and l1_size in the BDRVQcowState, over > image structures in memory such as the L

[Qemu-devel] [PATCH] savevm: Improve error message for blocked migration

2015-02-10 Thread Kevin Wolf
If an internal snapshot can't be saved because migration is blocked (most commonly probably because of AHCI), we had a really bad error message: $ echo -e "savevm foo\nquit" | qemu -M q35 /tmp/test.qcow2 -monitor stdio QEMU 2.2.50 monitor - type 'help' for more information (qemu) savevm foo Error

Re: [Qemu-devel] QEMU data passing between modules

2015-02-10 Thread Paolo Bonzini
[no private messages please] On 10/02/2015 14:27, boddu pavan wrote: > Hi paolo, > I have a aes module and its status should also be updated in register of > another block, which is said to be public register. The one in which its > updating is a private register. > How to get the data passed and

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 14:15 schrieb Paolo Bonzini: On 10/02/2015 13:56, Peter Lieven wrote: Ahem, 3.19 was released last Sunday. Give us some breathing room... I missed the next branch. I checked that out and updated the submodule to commit bfa76d49576599a4b9f9b7a71f23d73d6dcff735. Does that make

Re: [Qemu-devel] QEMU data passing between modules

2015-02-10 Thread boddu pavan
Yes its hardware block, and yes they are of same SOC. status is 16bit. On Tuesday, February 10, 2015 7:00 PM, Paolo Bonzini wrote: [no private messages please] On 10/02/2015 14:27, boddu pavan wrote: > Hi paolo, > I have a aes module and its status should also be updated in register

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-10 Thread Kevin Wolf
Am 10.02.2015 um 12:41 hat Peter Lieven geschrieben: > Am 09.02.2015 um 17:09 schrieb Kevin Wolf: > >The CHS calculation as done per the VHD spec imposes a maximum image > >size of ~127 GB. Real VHD images exist that are larger than that. > > > >Apparently there are two separate non-standard ways t

Re: [Qemu-devel] [PATCH v2 12/12] acpi: Add hardware implementation for memory hot unplug.

2015-02-10 Thread Igor Mammedov
On Wed, 4 Feb 2015 10:51:26 +0800 Zhu Guihua wrote: > From: Tang Chen > > This patch adds a new bit to memory hotplug IO port indicating that > ej0 has been evaluated by guest OS. And call pc-dimm unplug cb to do > the real removal. > > Signed-off-by: Hu Tao > Signed-off-by: Tang Chen > Sign

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 14:31, Peter Lieven wrote: >>> >> Yes, but it is still not ready. It only works with 3.18 and 3.16. > > Okay, but for testing I will use 3.19 with the patch for testing if the > assertion disappears?! If you use 3.19 in the host, you don't need kvm-kmod. If you use 3.19 with kvm

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-10 Thread Jeff Cody
On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote: > Am 10.02.2015 um 12:41 hat Peter Lieven geschrieben: > > Am 09.02.2015 um 17:09 schrieb Kevin Wolf: > > >The CHS calculation as done per the VHD spec imposes a maximum > > >image size of ~127 GB. Real VHD images exist that are larger tha

Re: [Qemu-devel] QEMU data passing between modules

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 14:34, boddu pavan wrote: > Yes its hardware block, and yes they are of same SOC. status is 16bit. For simplicity you can make them the same DeviceState. In order of increasing accuracy: - save the AES module's address in a global variable, and add a qemu_irq raised by the AES mo

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-10 Thread Kevin Wolf
Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: > On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote: > > Am 10.02.2015 um 12:41 hat Peter Lieven geschrieben: > > > Am 09.02.2015 um 17:09 schrieb Kevin Wolf: > > > >The CHS calculation as done per the VHD spec imposes a maximum > > > >imag

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 14:40 schrieb Paolo Bonzini: On 10/02/2015 14:31, Peter Lieven wrote: Yes, but it is still not ready. It only works with 3.18 and 3.16. Okay, but for testing I will use 3.19 with the patch for testing if the assertion disappears?! If you use 3.19 in the host, you don't need

Re: [Qemu-devel] [PATCH v2 00/12] QEmu memory hot unplug support

2015-02-10 Thread Igor Mammedov
On Wed, 4 Feb 2015 10:51:14 +0800 Zhu Guihua wrote: > Memory hot unplug are both asynchronize procedures. > When the unplug operation happens, unplug request cb is called first. > And when ghest OS finished handling unplug, unplug cb will be called > to do the real removal of device. please chec

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-10 Thread Peter Lieven
Am 10.02.2015 um 14:54 schrieb Kevin Wolf: Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote: Am 10.02.2015 um 12:41 hat Peter Lieven geschrieben: Am 09.02.2015 um 17:09 schrieb Kevin Wolf: The CHS calculation as done per the VHD spec

Re: [Qemu-devel] QEMU data passing between modules

2015-02-10 Thread boddu pavan
yup, thanks Paolo. But i have another basic question. I hope we have some docs on this. QOM model.I always really confuse with this series obj->DeviceState->SysBusDevice->hw_perip state. I simple assume that all the hw_emulations will be connected to SysBus(mostly). The device state is different

Re: [Qemu-devel] [PATCH v2 08/12] acpi, mem-hotplug: Add unplug cb for memory device.

2015-02-10 Thread Igor Mammedov
On Wed, 4 Feb 2015 10:51:22 +0800 Zhu Guihua wrote: > From: Tang Chen > > Reset all memory status, and unparent the memory device. > > Signed-off-by: Zhu Guihua > --- > hw/acpi/memory_hotplug.c | 34 ++ > hw/core/qdev.c | 2 +- > inc

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-10 Thread Jeff Cody
On Tue, Feb 10, 2015 at 02:54:39PM +0100, Kevin Wolf wrote: > Am 10.02.2015 um 14:42 hat Jeff Cody geschrieben: > > On Tue, Feb 10, 2015 at 02:34:14PM +0100, Kevin Wolf wrote: > > > Am 10.02.2015 um 12:41 hat Peter Lieven geschrieben: > > > > Am 09.02.2015 um 17:09 schrieb Kevin Wolf: > > > > >The

[Qemu-devel] [PATCH 1/6] target-tricore: Fix RLC_ADDI, RLC_ADDIH using wrong microcode helper

2015-02-10 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index a73b700..cfd6a77 100644 --- a/target-tricore/translate.c +++ b/target-tricore/translate.c @@ -4183

[Qemu-devel] [PATCH 2/6] target-tricore: fix msub32_suov return wrong results

2015-02-10 Thread Bastian Koppelmann
If the signed result of the multiplication overflows, we would get a negative value, which would result in a addition instead of a subtraction. Now we do the overflow calculation and saturation by hand instead of using suov32_neg. Signed-off-by: Bastian Koppelmann --- target-tricore/op_helper.c

[Qemu-devel] [PATCH 4/6] target-tricore: Add instructions of RRR1 opcode format, which have 0x83 as first opcode

2015-02-10 Thread Bastian Koppelmann
Add helpers: * add64_ssov: adds two 64 bit values and saturates the result. * addr_h/_ssov: adds two halfwords with two words in q-format with rounding / and saturates each result independetly. Add microcode generator: * gen_add64_d: adds two 64 bit values. * ge

[Qemu-devel] [PATCH 0/6] TriCore: Add RRR1 and RRR2 instructions

2015-02-10 Thread Bastian Koppelmann
Hi, the patchset fixes two minor bugs and takes care of all the packed/fixed point mac instructions. So far I only implemented all the multiply-add instructions, since the multiply-sub instructions are similar and I don't want the reviewers to find the same mistakes twice. Once these are reviewed

[Qemu-devel] [PATCH 6/6] target-tricore: Add instructions of RRR1 opcode format, which have 0xc3 as first opcode

2015-02-10 Thread Bastian Koppelmann
Add helpers helper_addsur_h/_ssov which adds one halfword and subtracts one halfword, rounds / and saturates each half word independently. Add microcode helper functions: * gen_maddsu_h/sus_h: multiply two halfwords left justified and add to the first one word and sub

[Qemu-devel] [PATCH 3/6] target-tricore: Add instructions of RRR2 opcode format

2015-02-10 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 149 +++ target-tricore/tricore-opcodes.h | 2 +- 2 files changed, 136 insertions(+), 15 deletions(-) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index cfd6a77.

[Qemu-devel] [PATCH 5/6] target-tricore: Add instructions of RRR1 opcode format, which have 0x43 as first opcode

2015-02-10 Thread Bastian Koppelmann
Add helpers: * madd64_q_ssov: multiply two 32 bit q-format number, add them with a 64 bit q-format number and saturate. * madd32_q_add_ssov: add two 64 bit q-format numbers and return a 32 bit result. * maddr_q_ssov: multiplay two 32 bit q-f

Re: [Qemu-devel] [PATCH v2 02/12] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus.

2015-02-10 Thread Igor Mammedov
On Wed, 4 Feb 2015 10:51:16 +0800 Zhu Guihua wrote: > From: Tang Chen > > Add a new API named acpi_memory_get_slot_status_descriptor() to obtain > a single memory slot status. Doing this is because this procedure will > be used by other functions in the next coming patches. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] savevm: Improve error message for blocked migration

2015-02-10 Thread Eric Blake
On 02/10/2015 06:25 AM, Kevin Wolf wrote: > If an internal snapshot can't be saved because migration is blocked > (most commonly probably because of AHCI), we had a really bad error > message: > > $ echo -e "savevm foo\nquit" | qemu -M q35 /tmp/test.qcow2 -monitor stdio You know, 'echo -e' is non

Re: [Qemu-devel] kvmclock_current_nsec: Assertion `time.tsc_timestamp <= migration_tsc'

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 14:58, Peter Lieven wrote: >> Yes, but it is still not ready. It only works with 3.18 and 3.16. >>> Okay, but for testing I will use 3.19 with the patch for testing if the >>> assertion disappears?! >> If you use 3.19 in the host, you don't need kvm-kmod. >> >> If you use 3.19

Re: [Qemu-devel] QEMU data passing between modules

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 15:02, boddu pavan wrote: > > Does all the hw_peripherals has any root node kind of thing. Which makes > all our nodes connected ? > The common superclass of the devices is DeviceState. The root object that connects the devices is the QEMUMachine. Paolo

<    1   2   3   4   >