Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls

Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: On w64, setjmp is implemented by _setjmp which needs a second parameter. This parameter should be NULL to allow using longjump from generated code. This patch replaces all usages of setjmp.h with new header files which replaces setjmp with _setjmp f

Re: [Qemu-devel] [PATCH RFC v4 5/6] qemu-iotests: s390x: fix test 051

On 02/05/2015 11:11 PM, Max Reitz wrote: On 2015-02-04 at 22:44, Xiao Guang Chen wrote: From: Mao Chuan Li The tests for device type "ide_cd" are skipped for the s390 platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_i

Re: [Qemu-devel] [PATCH] win64: perform correct setjmp calls

> From: Stefan Weil [mailto:s...@weilnetz.de] > Am 09.02.2015 um 08:55 schrieb Pavel Dovgalyuk: > > On w64, setjmp is implemented by _setjmp which needs a second parameter. > > This parameter should be NULL to allow using longjump from generated code. > > This patch replaces all usages of setjmp.h

[Qemu-devel] [PATCH] Makefile: Allow "make cscope TAGS" in unconfigured source tree

It doesn't make much sense to ask one to switch to build dir in order to make these two targets. Signed-off-by: Fam Zheng --- Makefile | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 6817c6f..257bef6 100644 --- a/Makefile +++ b/Makefile

Re: [Qemu-devel] [PATCH] qemu-coroutine-lock: fix co_queue multi-adding bug

On Sat, 02/07 17:51, w00214312 wrote: > From: Bin Wu > > When a coroutine holds a lock, other coroutines who want to get > the lock must wait on a co_queue by adding themselves to the > CoQueue. However, if a waiting coroutine is woken up with the > lock still be holding by other coroutine, this

Re: [Qemu-devel] [PATCH] Makefile: Allow "make cscope TAGS" in unconfigured source tree

On 9 February 2015 at 08:08, Fam Zheng wrote: > It doesn't make much sense to ask one to switch to build dir in order to > make these two targets. > > Signed-off-by: Fam Zheng > --- > Makefile | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/Makefile b/Makef

Re: [Qemu-devel] Definition of the UI layer's "key number" ?

On Do, 2015-02-05 at 17:36 +, Peter Maydell wrote: > Hi; I'm trying to find out what the UI layer's definition of > a "key number" is (ie what qemu_input_event_send_key_number()'s > "num" parameter is). We don't seem to document this anywhere, > which makes writing UI frontends tricky... Well,

Re: [Qemu-devel] Definition of the UI layer's "key number" ?

On 9 February 2015 at 08:27, Gerd Hoffmann wrote: > Well, we have two ways to represent a key code in qemu, unfortunately in > the QMP api (see KeyValue in qapi-schema.json). > > One is QKeyCode (defined in qapi-schema.json too), the other "key > number" is the key coding used pretty much everywhe

Re: [Qemu-devel] [PATCH v2 0/3] fix qemu crash about vnc

Hi, > It seems that Gerd is not in maillist recently. Was sick, back online now, I'll try to have a closer look ASAP but I have a big email backlog now ... cheers, Gerd

Re: [Qemu-devel] [RFC] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

On Fri, 06 Feb 2015 08:56:32 +0100 Alexander Graf wrote: > > > On 06.02.15 03:54, David Gibson wrote: > > On Thu, Feb 05, 2015 at 12:55:45PM +0100, Alexander Graf wrote: > >> > >> > >> On 05.02.15 12:30, David Gibson wrote: > >>> On Thu, Feb 05, 2015 at 11:22:13AM +0100, Alexander Graf wrote: >

[Qemu-devel] [Bug 1301047] Re: Windows guest freezes while using passthrough on USB audio recorder.

** Changed in: qemu Status: In Progress => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1301047 Title: Windows guest freezes while using passthrough on USB audio recorder. Status i

Re: [Qemu-devel] [PATCH] Makefile: Allow "make cscope TAGS" in unconfigured source tree

On Mon, 02/09 08:25, Peter Maydell wrote: > On 9 February 2015 at 08:08, Fam Zheng wrote: > > It doesn't make much sense to ask one to switch to build dir in order to > > make these two targets. > > > > Signed-off-by: Fam Zheng > > --- > > Makefile | 13 - > > 1 file changed, 8 inser

Re: [Qemu-devel] [PATCH v2 0/3] fix qemu crash about vnc

On 2015/2/9 16:33, Gerd Hoffmann wrote: > Hi, > >> It seems that Gerd is not in maillist recently. > > Was sick, back online now, I'll try to have a closer look ASAP but I > have a big email backlog now ... > Hope you feel better now :) Regards, -Gonglei

Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs

On Mon, 09 Feb 2015 15:10:17 +0800 "Chen, Tiejun" wrote: > On 2015/2/9 15:02, Michael S. Tsirkin wrote: > > On Mon, Feb 09, 2015 at 03:01:15PM +0800, Chen, Tiejun wrote: > >> On 2015/2/8 18:48, Michael S. Tsirkin wrote: > >>> On Fri, Feb 06, 2015 at 01:14:46PM +0100, Cornelia Huck wrote: > O

Re: [Qemu-devel] [PATCH v3 2/7] qom/cpu: move register_vmstate to common CPUClass.realizefn

On 01/29/2015 10:04 PM, Igor Mammedov wrote: On Wed, 14 Jan 2015 15:27:25 +0800 Zhu Guihua wrote: From: Gu Zheng Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, and use cc->get_arch_id as the instance id that suggested by Igor to fix the migration issue. Signed-off-

Re: [Qemu-devel] [PATCH v2] qemu-coroutine: segfault when restarting co_queue

On 09/02/2015 07:50, Bin Wu wrote: > From: Bin Wu > > We tested VMs migration with their disk images by drive_mirror. With > migration, two VMs copyed large files between each other. During the > test, a segfault occured. The stack was as follow: > > (gdb) bt > qemu-coroutine-lock.c:66 > to=0x

Re: [Qemu-devel] [PATCH 0/7] NUMA code cleanup

On 08/02/2015 19:51, Eduardo Habkost wrote: > This cleans up some of the NUMA code: moves declarations to numa.h, rename > some > functions, and remove some existing code that was inside main(). > > Eduardo Habkost (7): > numa: Move NUMA declarations from sysemu.h to numa.h > vl.c: Remove u

Re: [Qemu-devel] Definition of the UI layer's "key number" ?

On Mo, 2015-02-09 at 08:31 +, Peter Maydell wrote: > On 9 February 2015 at 08:27, Gerd Hoffmann wrote: > > Well, we have two ways to represent a key code in qemu, unfortunately in > > the QMP api (see KeyValue in qapi-schema.json). > > > > One is QKeyCode (defined in qapi-schema.json too), the

Re: [Qemu-devel] [PATCH 0/4] target-arm: fix various clang UB sanitizer warnings

Peter Maydell writes: > On 6 February 2015 at 17:37, Eric Blake wrote: >> On 02/06/2015 07:34 AM, Peter Maydell wrote: >> HACKING already implies we assume sane 2's complement behavior of shifts >> (maybe it's worth another line for this particular case of shifting into >> the signed bit of a si

Re: [Qemu-devel] [PATCH v2 0/7] isa: remove isa_mem_base variable

On 01/02/2015 08:12, Hervé Poussineau wrote: > Hi, > > This patchset removes the isa_mem_base variable in VGA display devices. > This variable is a global variable telling at which address is the > ISA memory base address in the system memory address space. > > Once removed, we're paving the way

Re: [Qemu-devel] [PATCH] fix the co_queue multi-adding bug

On 07/02/2015 10:51, w00214312 wrote: > From: Bin Wu > > When we test the drive_mirror between different hosts by ndb devices, > we find that, during the cancel phase the qemu process crashes sometimes. > By checking the crash core file, we find the stack as follows, which means > a coroutine

Re: [Qemu-devel] [PATCH] qemu-coroutine-lock: fix co_queue multi-adding bug

On 2015/2/9 16:12, Fam Zheng wrote: > On Sat, 02/07 17:51, w00214312 wrote: >> From: Bin Wu >> >> When a coroutine holds a lock, other coroutines who want to get >> the lock must wait on a co_queue by adding themselves to the >> CoQueue. However, if a waiting coroutine is woken up with the >> lock

Re: [Qemu-devel] [PATCH] hmp: Fix warning from smatch (wrong argument in function call)

Stefan Weil writes: > Fix this warning: > hmp.c:414:38: warning: Using plain integer as NULL pointer > > qmp_query_block expects a pointer argument, so passing false is wrong. > > Cc: Luiz Capitulino > Signed-off-by: Stefan Weil Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] fix the co_queue multi-adding bug

On 2015/2/9 17:23, Paolo Bonzini wrote: > > > On 07/02/2015 10:51, w00214312 wrote: >> From: Bin Wu >> >> When we test the drive_mirror between different hosts by ndb devices, >> we find that, during the cancel phase the qemu process crashes sometimes. >> By checking the crash core file, we fin

[Qemu-devel] CPU TLB flush with multithread TCG.

Hi everybody, In multithread tlb_flush is broken as CPUA can flush an other CPUB and CPUB can be executing code, and fixing this can be quite hard: * We need to exit the CPU which is flushed. * Makes sure the CPU is stopped. * Then we can flush tlb. The big issues are: * Two threads can

Re: [Qemu-devel] [PATCH] qemu-coroutine-lock: fix co_queue multi-adding bug

Am 09.02.2015 um 10:36 hat Bin Wu geschrieben: > On 2015/2/9 16:12, Fam Zheng wrote: > > On Sat, 02/07 17:51, w00214312 wrote: > >> From: Bin Wu > >> > >> When a coroutine holds a lock, other coroutines who want to get > >> the lock must wait on a co_queue by adding themselves to the > >> CoQueue.

[Qemu-devel] --disable-vnc broken?

Hello, is some #ifdef CONFIG_VNC missing in the latest vnc changes in mainline QEMU? I ask because configuring with --disable-vnc and then building now gets me: ../qmp-marshal.o: In function `qmp_marshal_input_query_vnc_servers': qemu/qmp-marshal.c:2899: undefined reference to `qmp_query_vnc_ser

Re: [Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrupt

On Fri, Feb 06, 2015 at 05:07:17PM +, Frediano Ziglio wrote: > 2015-02-06 16:54 GMT+00:00 Stefan Hajnoczi : > > On Thu, Jan 08, 2015 at 06:38:23PM +, Frediano Ziglio wrote: > >> Test behaviour of timers and interrupts related to timeouts. > >> > >> Signed-off-by: Frediano Ziglio > >> --- >

Re: [Qemu-devel] --disable-vnc broken?

On Mo, 2015-02-09 at 11:14 +0100, Claudio Fontana wrote: > Hello, > > is some #ifdef CONFIG_VNC missing in the latest vnc changes in mainline QEMU? > > I ask because configuring with --disable-vnc and then building now gets me: > > ../qmp-marshal.o: In function `qmp_marshal_input_query_vnc_serve

Re: [Qemu-devel] [PATCH] qemu-coroutine-lock: fix co_queue multi-adding bug

On 09/02/2015 10:36, Bin Wu wrote: > During the mirror phase with nbd devices, if we send a cancel command or > physical network breaks down, the source qemu process will receive a readable > event and the main loop will invoke nbd_reply_ready to deal with it. This > function finds the connection

Re: [Qemu-devel] [PATCH v2] qemu-coroutine: segfault when restarting co_queue

Am 09.02.2015 um 07:50 hat Bin Wu geschrieben: > From: Bin Wu > > We tested VMs migration with their disk images by drive_mirror. With > migration, two VMs copyed large files between each other. During the > test, a segfault occured. The stack was as follow: > > (gdb) bt > qemu-coroutine-lock.c:

[Qemu-devel] [PATCHv2] Prevent segmentation fault in case of relative resolve of uri

From: Miroslav Rezanina It was possible to call strcmp with NULL argument, that can cause segmentation fault. Properly checking parameters to prevent this situation. Signed-off-by: Miroslav Rezanina --- v2: - instead of adding NULL checks to strcmp call refactor whole NULL checking path. Th

[Qemu-devel] [PATCH] vhost-scsi: Improve error reporting for invalid vhostfd

We get two error messages: one from monitor_handle_fd_param2(), and another one from vhost_scsi_realize(). The second one gets suppressed in QMP context. That's because monitor_handle_fd_param() calls qerror_report_err(). Calling qerror_report_err() is always inappropriate in realize methods, bec

[Qemu-devel] [PATCH v3 03/52] pc: acpi: make top level ACPI tables blob Aml*

it will permit to add a separate tables into blob like other AML constructs using aml_append() routine and hide from user need to invoke linker manually for tables, handling it automatically inside of aml_append() helper. Later when all tables are converted to use AML API, it would be possible to

[Qemu-devel] [PATCH v3 02/52] pc: acpi: use local var for accessing ACPI tables blob in acpi_build()

except of shortening of lines and making code a bit more readable, it will reduce renaming noise when changing tables blob from GArray* to Aml* type. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 69 ++-- 1 file changed, 35 insertions(+),

[Qemu-devel] [PATCH v3 04/52] acpi: factor out ACPI const int packing out of build_append_value()

it will be reused for adding a plain integer value into AML. Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 19 +++ hw/i386/acpi-build.c | 6 +++--- 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 096f347..

[Qemu-devel] [PATCH v3 00/52] ACPI refactoring: replace template patching with C AML API

changes since v2: * rename acpi prefixes in API to aml * reverse conversion order from bottom->top to top->bottom * introduce internal Aml garbage collector and 2 API functions to initialize and cleanup it up * replace acpi_argX() helpers with a single aml_arg(X) helper do the same

[Qemu-devel] [PATCH v3 09/52] acpi: add aml_device() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 31a3786..e38a222 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -393,3

[Qemu-devel] [PATCH v3 06/52] pc: acpi-build: use aml_def_block() for declaring SSDT table

it replaces prebuilt SSDT table header template copying/patching with AML API Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 553c86b..fcefa07

[Qemu-devel] [PATCH v3 11/52] acpi: add aml_if() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 7389009..9f43fef 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -383,6 +383,1

[Qemu-devel] [PATCH v3 01/52] acpi: introduce AML composer aml_append()

Adds for dynamic AML creation, which will be used for piecing ASL/AML primitives together and hiding from user/caller details about how nested context should be closed/packed leaving less space for mistakes and necessity to know how AML should be encoded, allowing user to concentrate on ASL represe

[Qemu-devel] [PATCH v3 07/52] acpi: add aml_scope() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 20 include/hw/acpi/aml-build.h | 1 + 2 files changed, 21 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index cb1a1bd..31a3786 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @

[Qemu-devel] [PATCH v3 08/52] pc: acpi-build: use aml_scope() for \_SB scope

prepares for incremental conversion of SSDT contents to AML API Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index fcefa07..bdc343f 100644 ---

[Qemu-devel] [PATCH v3 10/52] acpi: add aml_method() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index e38a222..7389009 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -383,6 +383

[Qemu-devel] [PATCH v3 16/52] acpi: add aml_arg() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 2a29c8f..12f0653 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -437,6

[Qemu-devel] [PATCH v3 12/52] acpi: add aml_name() & aml_name_decl() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 32 include/hw/acpi/aml-build.h | 4 2 files changed, 36 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 9f43fef..5d6553c 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acp

[Qemu-devel] [PATCH v3 15/52] acpi: add aml_return() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index de775e2..2a29c8f 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -395,6 +395,1

[Qemu-devel] [PATCH v3 05/52] acpi: add aml_def_block() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 38 ++ hw/i386/acpi-build.c| 4 include/hw/acpi/aml-build.h | 10 ++ 3 files changed, 48 insertions(+), 4 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c i

[Qemu-devel] [PATCH v3 13/52] acpi: extend build_append_{value|int}() to support 64-bit values

it will be used for generating 64bit _CRS entries Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 ++--- include/hw/acpi/aml-build.h | 4 ++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 5d6553c..d71b236 1006

[Qemu-devel] [PATCH v3 20/52] acpi: add aml_call1(), aml_call2(), aml_call3(), aml_call4() helpers

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 42 ++ include/hw/acpi/aml-build.h | 4 2 files changed, 46 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index c5feb61..0328a57 100644 --- a/hw/acpi/aml-build.c ++

[Qemu-devel] [PATCH v3 19/52] acpi: add aml_notify() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 61149dc..c5feb61 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -467,6 +467

[Qemu-devel] [PATCH v3 22/52] acpi: add aml_package() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 0328a57..31e999d 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -556,3 +556,1

[Qemu-devel] [PATCH v3 14/52] acpi: add aml_int() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index d71b236..de775e2 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -396,6

[Qemu-devel] [PATCH v3 18/52] acpi: add aml_and() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index ae84b25..61149dc 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -457,6 +

[Qemu-devel] [PATCH v3 28/52] acpi: include PkgLength size only when requested

Named/Reserved{Field} definition uses PkgLength [1] encoding to specify field length, however it doesn't include size of PkgLength field itself, while other block objects that have explicit length of its body account for PkgLength size while encoding it [2]. This special casing isn't mentioned in A

[Qemu-devel] [PATCH v3 17/52] acpi: add aml_store() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 9 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 12f0653..ae84b25 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -448,6 +448

[Qemu-devel] [PATCH v3 24/52] pc: acpi-build: generate _S[345] packages dynamically

Replaces template patching with packages composed using AML API. Note on behavior change: If S3 or S4 is disabled, respective packages won't be created and put into SSDT. Which saves us some space in SSDT and doesn't confuse guest OS with mangled package names as it was done originally. Signed-of

[Qemu-devel] [PATCH v3 23/52] pc: acpi-build: drop unsupported PM1b_CNT.SLP_TYP

QEMU doesn't implement/advertize PM1b_CNT_BLK register block so do not set/patch its \_Sx values to avoid confusion. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 3 +-- hw/i386/ssdt-misc.dsl | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/i386/acpi-build.c

[Qemu-devel] [PATCH v3 27/52] acpi: add aml_io() helper

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 16 include/hw/acpi/aml-build.h | 7 +++ 2 files changed, 23 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 452db25..a5d5b83 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c

[Qemu-devel] [PATCH v3 31/52] acpi: add aml_local() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 11 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 10995a9..cb58e19 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -647,3

[Qemu-devel] [PATCH v3 21/52] pc: acpi-build: drop template patching and create PCI bus tree dynamically

Replace AML template patching with direct composing of PCI device entries in C. It allows to simplify PCI tree generation further and saves us about 400LOC scattered through different files, confining tree generation to one C function which is much easier to deal with. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH v3 36/52] acpi: add aml_processor() term

Signed-off-by: Igor Mammedov --- v2: * use build_append_value() to pack PblkAddr instead of doing it manually --- hw/acpi/aml-build.c | 15 +++ include/hw/acpi/aml-build.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.

[Qemu-devel] [PATCH v3 29/52] acpi: add aml_operation_region() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 14 ++ include/hw/acpi/aml-build.h | 7 +++ 2 files changed, 21 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 8c6b6a3..05d4a3d 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @

[Qemu-devel] [PATCH v3 30/52] acpi: add aml_field() & aml_named_field() terms

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 28 include/hw/acpi/aml-build.h | 6 ++ 2 files changed, 34 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 05d4a3d..10995a9 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/

[Qemu-devel] [PATCH v3 25/52] acpi: add aml_buffer() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 7 +++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 31e999d..6488433 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -557,6 +557,13

[Qemu-devel] [PATCH v3 34/52] acpi: add aml_varpackage() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 3929de9..90b7b65 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -683,3 +683,1

[Qemu-devel] [PATCH v3 26/52] acpi: add aml_resource_template() helper

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 6488433..452db25 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -557,6 +557,1

[Qemu-devel] [PATCH v3 39/52] pc: acpi-build: create CPU hotplug IO region dynamically

it replaces a static complied in DSDT MMIO region for CPU hotplug with one created at runtime leaving only truly static CPU hotplug related ASL bits in DSDT. It also puts CPU_HOTPLUG_RESOURCE_DEVICE into PCI0 scope and reserves resources from it, preparing for dropping manual hole punching in PCI0.

[Qemu-devel] [PATCH v3 35/52] acpi: add aml_equal() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 90b7b65..670d3e9 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -554,6 +

[Qemu-devel] [PATCH v3 38/52] pc: acpi-build: drop template patching and CPU hotplug objects dynamically

in addition it saves us ~400LOC and makes it one binary blob less stored in QEMU source tree by removing need to keep and update hw/i386/ssdt-proc.hex.generated file there. Signed-off-by: Igor Mammedov --- hw/i386/Makefile.objs | 2 +- hw/i386/acpi-build.c| 95 ++

[Qemu-devel] [PATCH v3 47/52] pc: acpi-build: drop remaining ssdt_misc template and use acpi_def_block()

It completes dynamic SSDT generation and makes it independed of IASL binary blobs. It also hides from user all pointer arithmetic when building SSDT which makes resulting code a bit cleaner and concentrating only on composing ASL construct /i.e. a task build_ssdt() should be doing/. Also it makes

[Qemu-devel] [PATCH v3 37/52] acpi: add aml_eisaid() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 29 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 30 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index aa5ef59..90c1272 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-

[Qemu-devel] [PATCH v3 40/52] acpi: add aml_reserved_field() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 10 ++ include/hw/acpi/aml-build.h | 6 ++ 2 files changed, 16 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 90c1272..1b23459 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -64

[Qemu-devel] [PATCH v3 41/52] pc: acpi-build: drop template patching and memory hotplug objects dynamically

in addition it saves us ~330LOC and makes it one binary blob less stored in QEMU source tree by removing need to keep and update hw/i386/ssdt-mem.hex.generated file there. Signed-off-by: Igor Mammedov --- hw/i386/Makefile.objs | 2 +- hw/i386/acpi-build.c | 133 +

[Qemu-devel] [PATCH v3 46/52] pc: acpi-build: create PCI0._CRS dynamically

Replace template patching and runtime calculation in _CRS() method with static _CRS defined in SSDT. It also drops manual hole patching for reserved PCI/MEM/CPU hoptlug MMIO resources and utilizes the fact that MMIO resources are reserved by respective child /i.e. PHPR, MHPD, PRES/ containers. Si

[Qemu-devel] [PATCH v3 32/52] acpi: add aml_string() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 25 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 26 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index cb58e19..3929de9 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-buil

[Qemu-devel] [PATCH v3 43/52] acpi: add aml_word_bus_number(), aml_word_io(), aml_dword_memory(), aml_qword_memory() terms

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 161 include/hw/acpi/aml-build.h | 72 2 files changed, 233 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 1b23459..bfebdb4 100644 --- a/h

[Qemu-devel] [PATCH v3 51/52] pc: acpi-build: update [q35-]acpi-dsdt.hex.generated due to moved SMC

so that build on IASL less hosts won't fail due to present but unused variable warning Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt.hex.generated | 714 ++-- hw/i386/q35-acpi-dsdt.hex.generated | 662 ++--- 2 files changed, 58

[Qemu-devel] [PATCH v3 44/52] pc: pcihp: expose MMIO base and len as properties

it will be used later to dynamically reserve MMIO region instead of manually punching holes in PCI0._CRS Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 18 -- hw/acpi/piix4.c | 2 +- include/hw/acpi/pcihp.h | 7 ++- 3 files changed, 19 insertions(+), 8 d

[Qemu-devel] [PATCH v3 52/52] acpi: make build_*() routines static to aml-build.c

build_*() routines were used for composing AML structures manually in acpi-build.c but after conversion to AML API they are not used outside of aml-build.c anymore, so hide them from external users. Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 22 +++--- include

[Qemu-devel] [PATCH v3 45/52] pc: acpi-build: reserve PCIHP MMIO resources

Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 256870b..e195017 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -105,6 +105,8 @@ typedef struct

[Qemu-devel] [PATCH v3 42/52] pc: acpi-build: create memory hotplug IO region dynamically

it replaces a static complied in DSDT MMIO region for memory hotplug with one created at runtime leaving only truly static memory hotplug related ASL bits in DSDT. And replaces template patching of MEMORY_SLOTS_NUMBER value with ASL API created named value. Later it also would make easier to reuse

[Qemu-devel] [PATCH v3 48/52] acpi: add acpi_irq_no_flags() term

Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 21 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 22 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index bfebdb4..3f87d51 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c

[Qemu-devel] [PATCH v3 33/52] pc: acpi-build: generate pvpanic device description dynamically

Drops AML template patching and allows to save some space in SSDT if pvpanic device doesn't exist by not including disabled device description into SSDT. It also makes device description smaller by replacing _STA method with named value and dropping _INI method. Signed-off-by: Igor Mammedov ---

[Qemu-devel] [PATCH v3 49/52] pc: export applesmc IO port/len

IO port and length will be used in following patch to correctly generate SMC ACPI device in SSDT. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 2 +- hw/misc/applesmc.c | 5 ++--- include/hw/isa/isa.h | 11 +-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PATCH v3 50/52] pc: acpi-build: drop template patching and create Device(SMC) dynamically

patch moves SMC device into SSDT and creates it only when device is present, which makes ACPI tables smaller in default case when device is not present. PS: also it fixes wrong IO range in CRS if "iobase" property is set to a not default value. Signed-off-by: Igor Mammedov --- hw/i386/acpi-buil

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

On Mon, 2015-02-09 at 14:28 +0800, Chen, Tiejun wrote: > What about this? I've not read the code in detail,since I'm travelling but from a quick glance it looks to be implementing the sort of thing I meant, thanks. A couple of higher level comments: I'd suggest to put the code for reading the v

[Qemu-devel] [PATCH v4 0/2] buildsys: Fix and enable module build

v4: Fix patch 1 by: - Squashing Paolo's patch in reply to v2, to fix static build. - Fix "pie" check to allow module build on ARM (and hopefully other platforms). - Tested {$DEFAULT,--enable-modules,--disable-modules} on {x86_64, arm} hosts. "--static" is not tested becau

[Qemu-devel] [PATCH v4 1/2] configure: Default to enable module build

We have module build support around for a while, but also had it bitrot several times. It probably makes sense to enable it by default so that people can notice and use it. Add --disable-modules as a counterpart to --enable-modules, which is now turned on by default. If both are omitted, support

[Qemu-devel] [PATCH v4 2/2] .travis.yml: Add "--disable-modules"

Now we default to "--enable-modules", let's cover the old way in travis. Signed-off-by: Fam Zheng --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 0ac170b..12bf1db 100644 --- a/.travis.yml +++ b/.travis.yml @@ -99,5 +99,5 @@ matr

Re: [Qemu-devel] [PATCH v2 1/2] target-mips: Rework ABIs to allow all required configurations

On 11/12/2014 00:21, Maciej W. Rozycki wrote: > Rework the MIPS ABIs and CPU emulations available according to the > following target list: > > - mips|mipsel -- 32-bit CPUs only, system and user emulation mode, >o32 user ABI, > > - mips64|mips64el -- 32-bit and 6

Re: [Qemu-devel] [PATCHv2] Prevent segmentation fault in case of relative resolve of uri

On 09/02/2015 11:47, mreza...@redhat.com wrote: > From: Miroslav Rezanina > > It was possible to call strcmp with NULL argument, that can cause > segmentation fault. Properly checking parameters to prevent this > situation. > > Signed-off-by: Miroslav Rezanina > --- > v2: > - instead of addi

Re: [Qemu-devel] [PATCH] linux-user: correct stat structure in MIPS N32

Hi Leon, On 30/01/15 15:08, Leon Alrae wrote: > Simple "hello world" MIPS N32 userland program crashes with segfault due to > incorrectly defined stat structure in QEMU. > > Correct "target_stat" definition to match kernel's "stat64" as in MIPS N32 > there are only plain "stat" syscalls using 64-

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > > This patch introduces command line options for enabling recording or > > replaying > > virtual machine behavior. "-record" option starts recording of the execution > > and saves it into the log, sp

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/7] Six coverity fixes and a cleanup

Paolo Bonzini wrote: > On 07/02/2015 10:00, Michael Tokarev wrote: >>> > Patch 2 is the cleanup. The other six patches make the tcg, utils and >>> > migration components clean. >> Applied to -trivial patches 1,2,3,4 and 6, not applied 5 (due to >> questionable errno checking addition) and 7, due

[Qemu-devel] [PATCH] checkpatch: port fix from kernel "## is not a valid modifier"

From: Andy Whitcroft checkpatch currently loops on fpu/softfloat.c Turns out this is fixed in the Linux version of checkpatch. So this is a port of Andy Whitcrofts fix from Linux, Original commit was commit 89a883530fe7 ("checkpatch: ## is not a valid modifier") Cc: Andy Whitcroft Signed-off-b

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

On 09/02/2015 13:15, Pavel Dovgaluk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 22/01/2015 09:53, Pavel Dovgalyuk wrote: >>> This patch introduces command line options for enabling recording or >>> replaying >>> virtual machine behavior. "-record" option starts recording of

Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop BDS backpointer

On 06/02/2015 22:06, Max Reitz wrote: > @@ -889,7 +889,7 @@ void nbd_client_put(NBDClient *client) > } > } > > -void nbd_client_close(NBDClient *client) > +static void client_close(NBDClient *client) > { > if (client->closing) { > return; Probably NBDClient should be renam

Re: [Qemu-devel] [PATCH 2/2] openpic: convert to vmstate

Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/intc/openpic.c | 253 > + > 1 file changed, 119 insertions(+), 134 deletions(-) > > +static const VMStateDescription vmstate_openpic_irq_queue = { > +.name = "openpic_i

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] openpic: convert to vmstate

On 09.02.15 13:39, Juan Quintela wrote: > Mark Cave-Ayland wrote: >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/intc/openpic.c | 253 >> + >> 1 file changed, 119 insertions(+), 134 deletions(-) >> > >> +static const VMStateDescription vm

  1   2   3   4   >