Re: [Qemu-devel] [RFC] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

2015-02-06 Thread Alexander Graf
On 06.02.15 03:54, David Gibson wrote: > On Thu, Feb 05, 2015 at 12:55:45PM +0100, Alexander Graf wrote: >> >> >> On 05.02.15 12:30, David Gibson wrote: >>> On Thu, Feb 05, 2015 at 11:22:13AM +0100, Alexander Graf wrote: > [snip] >> [snip] >> >>> +ret1 = kvmppc_enable_

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-06 Thread Teruaki Ishizaki
(2015/02/06 11:18), Liu Yuan wrote: On Wed, Feb 04, 2015 at 01:54:19PM +0900, Teruaki Ishizaki wrote: (2015/02/02 15:52), Liu Yuan wrote: On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enab

Re: [Qemu-devel] [PATCH v2 0/3] bootdevcie: change the boot order validation logic

2015-02-06 Thread Gonglei
On 2015/2/3 20:34, Gonglei (Arei) wrote: > From: Gonglei > > The reset logic can be done by both machine reset and > boot handler. So we shouldn't return error when the boot > handler callback don't be set in patch 1. > > Patch 2 check boot order argument validation > before vm running. > > Pa

Re: [Qemu-devel] Intel X86 hardware transactional memory

2015-02-06 Thread Peter Maydell
On 5 February 2015 at 05:09, Patrick Williams III wrote: > Consider two virtual addresses that point to the same physical address. One > thread uses the first virtual address in a transaction; another thread > writes to the second virtual address while the transaction is going on. > This should c

Re: [Qemu-devel] [PATCH] block: introduce BDRV_REQUEST_MAX_SECTORS

2015-02-06 Thread Peter Lieven
Am 03.02.2015 um 16:33 schrieb Denis V. Lunev: > On 03/02/15 17:30, Peter Lieven wrote: >> Am 03.02.2015 um 14:29 schrieb Denis V. Lunev: >>> On 03/02/15 15:12, Peter Lieven wrote: we check and adjust request sizes at several places with sometimes inconsistent checks or default values: >>

Re: [Qemu-devel] [PATCH v2 1/3] bootdevice: remove the check about boot_set_handler

2015-02-06 Thread Markus Armbruster
writes: > From: Gonglei > > The reset logic can be done by both machine reset and > boot handler. So we shouldn't return error when the boot > handler callback don't be set. > > Signed-off-by: Gonglei > Reviewed-by: Alexander Graf > --- > bootdevice.c | 10 +++--- > 1 file changed, 3 inse

Re: [Qemu-devel] [PATCH v2 2/3] bootdevice: check boot order argument validation before vm running

2015-02-06 Thread Markus Armbruster
writes: > From: Gonglei > > Either 'once' option or 'order' option can take effect for -boot at > the same time, that is say initial startup processing can check only > one. And pc.c's set_boot_dev() fails when its boot order argument > is invalid. This patch provide a solution fix this problem:

Re: [Qemu-devel] [PATCH v2 1/3] bootdevice: remove the check about boot_set_handler

2015-02-06 Thread Gonglei
On 2015/2/6 16:56, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> The reset logic can be done by both machine reset and >> boot handler. So we shouldn't return error when the boot >> handler callback don't be set. >> >> Signed-off-by: Gonglei >> Reviewed-by: Alexander Graf >> ---

Re: [Qemu-devel] [PATCH v2 2/3] bootdevice: check boot order argument validation before vm running

2015-02-06 Thread Gonglei
On 2015/2/6 17:06, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> Either 'once' option or 'order' option can take effect for -boot at >> the same time, that is say initial startup processing can check only >> one. And pc.c's set_boot_dev() fails when its boot order argument >> is i

Re: [Qemu-devel] [PATCH 3/4] net: del hub port when peer is deleted

2015-02-06 Thread Jason Wang
On Thu, Feb 5, 2015 at 10:25 PM, Stefan Hajnoczi wrote: On Mon, Feb 02, 2015 at 03:06:37PM +0800, Jason Wang wrote: We should del hub port when peer is deleted since it will not be reused and will only be freed during exit. Signed-off-by: Jason Wang --- net/net.c | 2 ++ 1 file c

Re: [Qemu-devel] [PATCH] block: introduce BDRV_REQUEST_MAX_SECTORS

2015-02-06 Thread Denis V. Lunev
On 06/02/15 11:49, Peter Lieven wrote: Am 03.02.2015 um 16:33 schrieb Denis V. Lunev: On 03/02/15 17:30, Peter Lieven wrote: Am 03.02.2015 um 14:29 schrieb Denis V. Lunev: On 03/02/15 15:12, Peter Lieven wrote: we check and adjust request sizes at several places with sometimes inconsistent ch

Re: [Qemu-devel] [PATCH] block: Give always priority to unused entries in the qcow2 L2 cache

2015-02-06 Thread Alberto Garcia
On Thu, Feb 05, 2015 at 03:17:19PM +0100, Kevin Wolf wrote: > > By never allowing the hit count to go down to zero, we make sure > > that all unused entries are chosen first before a valid one is > > discarded. > > But does this actually improve a lot? cache_hits is only 0 for the > first few acc

Re: [Qemu-devel] [v4 02/13] migration: Add the framework of multi-thread compression

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Add the code to create and destroy the multiple threads those will > be used to do data compression. Left some functions empty to keep > clearness, and the code will be added later. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: D

Re: [Qemu-devel] [v4 03/13] migration: Add the framework of multi-thread decompression

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Add the code to create and destroy the multiple threads those will be > used to do data decompression. Left some functions empty just to keep > clearness, and the code will be added later. Reviewed-by: Dr. David Alan Gilbert > > Signed-off-by: Liang Li

Re: [Qemu-devel] [PATCH v2 1/1] Print PID and time in stderr traces

2015-02-06 Thread Stefan Hajnoczi
On Tue, Jan 20, 2015 at 09:41:15AM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When debugging migration it's useful to know the PID of > each trace message so you can figure out if it came from the source > or the destination. > > Printing the time makes it ea

Re: [Qemu-devel] [v4 04/13] qemu-file: Add compression functions to QEMUFile

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > qemu_put_compression_data() compress the data and put it to QEMUFile. > qemu_put_qemu_file() put the data in the buffer of source QEMUFile to > destination QEMUFile. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > include/migration/qemu

Re: [Qemu-devel] [PULL 00/10] Migration queue

2015-02-06 Thread Peter Maydell
On 5 February 2015 at 16:24, Juan Quintela wrote: > Hi > > This is the migration queue. Thanks to Amit for doing almost all the work. > There were a Makefile missing dependency to make test-vmstate compile with > the json changes, > Alex agreed with the changes. > > List of things: > - vmstate c

Re: [Qemu-devel] [PATCH v2 10/19] qtest/ahci: add ahci_write_fis

2015-02-06 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 11:19:16AM -0500, John Snow wrote: > > > On 02/05/2015 08:29 AM, Stefan Hajnoczi wrote: > >On Tue, Feb 03, 2015 at 04:46:30PM -0500, John Snow wrote: > >>Similar to ahci_set_command_header, add a helper that takes an > >>in-memory representation of a command FIS and writes

Re: [Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-02-06 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 03:29:17PM +0100, Peter Lieven wrote: > Am 05.02.2015 um 15:00 schrieb Stefan Hajnoczi: > >On Fri, Jan 30, 2015 at 10:08:02PM +0100, Peter Lieven wrote: > >>Just wondering if VIRTQUEUE_MAX_SIZE in include/hw/virtio/virtio.h should > >>not be equal to IOV_MAX instead of the

Re: [Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-02-06 Thread Peter Lieven
Am 06.02.2015 um 11:42 schrieb Stefan Hajnoczi: > On Thu, Feb 05, 2015 at 03:29:17PM +0100, Peter Lieven wrote: >> Am 05.02.2015 um 15:00 schrieb Stefan Hajnoczi: >>> On Fri, Jan 30, 2015 at 10:08:02PM +0100, Peter Lieven wrote: Just wondering if VIRTQUEUE_MAX_SIZE in include/hw/virtio/virtio.

Re: [Qemu-devel] [v4 05/13] arch_init: Alloc and free data struct for compression

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Define the data structure and variables used to do multiple thread > compression, and add the code to initialize and free them. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: Dr. David Alan Gilbert > --- > arch_init.c | 34

Re: [Qemu-devel] [v4 06/13] arch_init: Add and free data struct for decompression

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Define the data structure and variables used to do multiple thread > decompression, and add the code to initialize and free them. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: Dr. David Alan Gilbert > --- > arch_init.c | 13 ++

[Qemu-devel] [PATCH V2] block: introduce BDRV_REQUEST_MAX_SECTORS

2015-02-06 Thread Peter Lieven
we check and adjust request sizes at several places with sometimes inconsistent checks or default values: INT_MAX INT_MAX >> BDRV_SECTOR_BITS UINT_MAX >> BDRV_SECTOR_BITS SIZE_MAX >> BDRV_SECTOR_BITS This patches introdocues a macro for the maximal allowed sectors per request and uses it at se

Re: [Qemu-devel] [v4 07/13] migration: Split the function ram_save_page

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Split the function ram_save_page for code reuse purpose. That's better, but I still think there is an XBZRLE problem; see below. > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 102 > +--

Re: [Qemu-devel] [PATCH] block: Give always priority to unused entries in the qcow2 L2 cache

2015-02-06 Thread Kevin Wolf
Am 06.02.2015 um 10:44 hat Alberto Garcia geschrieben: > On Thu, Feb 05, 2015 at 03:17:19PM +0100, Kevin Wolf wrote: > > > > By never allowing the hit count to go down to zero, we make sure > > > that all unused entries are chosen first before a valid one is > > > discarded. > > > > But does this

[Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Denis V. Lunev
nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t as the length in bytes of the data to discard due to the following definition: struct nbd_request { uint32_t magic; uint32_t type; uint64_t handle; uint64_t from; uint32_t len; <-- the length of data to be d

Re: [Qemu-devel] [PATCH V2] block: introduce BDRV_REQUEST_MAX_SECTORS

2015-02-06 Thread Denis V. Lunev
On 06/02/15 13:54, Peter Lieven wrote: we check and adjust request sizes at several places with sometimes inconsistent checks or default values: INT_MAX INT_MAX >> BDRV_SECTOR_BITS UINT_MAX >> BDRV_SECTOR_BITS SIZE_MAX >> BDRV_SECTOR_BITS This patches introdocues a macro for the maximal

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Kevin Wolf
Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: > nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t > as the length in bytes of the data to discard due to the following > definition: > > struct nbd_request { > uint32_t magic; > uint32_t type; > uint64_t hand

Re: [Qemu-devel] [PATCH 1/5] virtio: rename VIRTIO_PCI_QUEUE_MAX to VIRTIO_QUEUE_MAX

2015-02-06 Thread Cornelia Huck
On Fri, 6 Feb 2015 15:54:09 +0800 Jason Wang wrote: > VIRTIO_PCI_QUEUE_MAX was not specific to pci, so rename it to > VIRTIO_QUEUE_MAX. > > Cc: Amit Shah > Cc: Anthony Liguori > Cc: Michael S. Tsirkin > Cc: Alexander Graf > Cc: Richard Henderson > Cc: Cornelia Huck > Cc: Christian Borntr

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Denis V. Lunev
On 06/02/15 14:53, Kevin Wolf wrote: Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t as the length in bytes of the data to discard due to the following definition: struct nbd_request { uint32_t magic; uint32

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Peter Lieven
Am 06.02.2015 um 12:59 schrieb Denis V. Lunev: > On 06/02/15 14:53, Kevin Wolf wrote: >> Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: >>> nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t >>> as the length in bytes of the data to discard due to the following >>> defin

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Kevin Wolf
Am 06.02.2015 um 12:59 hat Denis V. Lunev geschrieben: > On 06/02/15 14:53, Kevin Wolf wrote: > >Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: > >>nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t > >>as the length in bytes of the data to discard due to the following >

Re: [Qemu-devel] [v4 08/13] migration: Add the core code of multi-thread compression

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Implement the core logic of the multiple thread compression. At this > point, multiple thread compression can't co-work with xbzrle yet. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 167 > ++

Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs

2015-02-06 Thread Cornelia Huck
On Fri, 6 Feb 2015 13:41:26 +0800 Tiejun Chen wrote: > Actually we define these device IDs in virtio standard, so > we'd better put them into one common place to manage conveniently. > Here I also add VIRTIO_ID_RESERVE according to virtio spec. > > Signed-off-by: Tiejun Chen > --- > hw/9pfs/v

Re: [Qemu-devel] [v4 09/13] migration: Make compression co-work with xbzrle

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Now, multiple thread compression can co-work with xbzrle. when > xbzrle is on, multiple thread compression will only work at the > first round of RAM data sync. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 11 ++

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Peter Lieven
Am 06.02.2015 um 12:53 schrieb Kevin Wolf: > Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: >> nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t >> as the length in bytes of the data to discard due to the following >> definition: >> >> struct nbd_request { >> uint32

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Denis V. Lunev
On 06/02/15 15:07, Kevin Wolf wrote: Am 06.02.2015 um 12:59 hat Denis V. Lunev geschrieben: On 06/02/15 14:53, Kevin Wolf wrote: Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t as the length in bytes of the data to d

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Denis V. Lunev
On 06/02/15 15:22, Peter Lieven wrote: Am 06.02.2015 um 13:17 schrieb Denis V. Lunev: On 06/02/15 15:07, Kevin Wolf wrote: Am 06.02.2015 um 12:59 hat Denis V. Lunev geschrieben: On 06/02/15 14:53, Kevin Wolf wrote: Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: nbd_co_discard calls n

Re: [Qemu-devel] [v4 10/13] migration: Add the core code for decompression

2015-02-06 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Implement the core logic of multiple thread decompression, > the decompression can work now. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 49 +++-- > 1 file changed, 47 insert

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Peter Lieven
Am 06.02.2015 um 13:17 schrieb Denis V. Lunev: > On 06/02/15 15:07, Kevin Wolf wrote: >> Am 06.02.2015 um 12:59 hat Denis V. Lunev geschrieben: >>> On 06/02/15 14:53, Kevin Wolf wrote: Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: > nbd_co_discard calls nbd_client_session_co_disca

Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length

2015-02-06 Thread Kevin Wolf
Am 06.02.2015 um 13:16 hat Peter Lieven geschrieben: > Am 06.02.2015 um 12:53 schrieb Kevin Wolf: > > Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: > >> nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t > >> as the length in bytes of the data to discard due to the foll

Re: [Qemu-devel] [PATCH] blkdebug: fix "once" rule

2015-02-06 Thread Max Reitz
On 2015-02-05 at 19:28, John Snow wrote: On 02/05/2015 06:43 PM, Max Reitz wrote: On 2015-02-05 at 18:15, John Snow wrote: The blkdebug scripts are currently engineered so that when a debug event occurs, a prefilter browses a master list of parsed rules for a certain event and adds them to a

Re: [Qemu-devel] value of VIRTQUEUE_MAX_SIZE

2015-02-06 Thread Eric Blake
On 02/06/2015 03:45 AM, Peter Lieven wrote: >>> The idea was that IOV_MAX is the limit in case of at least virtio-blk. The >>> host >>> will not support more than IOV_MAX iovecs passed to a block request. >> Is there an issue in practice? > > If there is no platform where IOV_MAX is less than 10

Re: [Qemu-devel] [RFC v2 2/8] vfio-pci: add aer capability support

2015-02-06 Thread Alex Williamson
On Fri, 2015-02-06 at 15:03 +0800, Chen Fan wrote: > On 02/03/2015 04:15 AM, Alex Williamson wrote: > > On Wed, 2015-01-28 at 16:37 +0800, Chen Fan wrote: > >> if we detect the aer capability in vfio device, then > >> we should initialize the vfio device aer rigister bits. > >> so guest OS can set

[Qemu-devel] [PULL 1/1] trace: Print PID and time in stderr traces

2015-02-06 Thread Stefan Hajnoczi
From: "Dr. David Alan Gilbert" When debugging migration it's useful to know the PID of each trace message so you can figure out if it came from the source or the destination. Printing the time makes it easy to do latency measurements or timings between trace points. Signed-off-by: Dr. David Ala

[Qemu-devel] [PULL 0/1] Tracing patches

2015-02-06 Thread Stefan Hajnoczi
The following changes since commit 16017c48547960539fcadb1f91d252124f442482: softfloat: Clarify license status (2015-01-29 16:45:45 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to dd9fe29c80b8a35f12d9

Re: [Qemu-devel] [PATCH 2/2] e1000: unconditionally enable bus mastering

2015-02-06 Thread Stefan Hajnoczi
On Wed, Jan 07, 2015 at 04:08:29PM +, Stefan Hajnoczi wrote: > On Thu, Dec 18, 2014 at 05:22:19PM +0800, Amos Kong wrote: > > After enabled network debug of e1000 in Win2012-64r2 guest, > > Bus mastering of e1000 can't be enabled by e1000 driver. It > > caused guest can't get IP address. > > >

Re: [Qemu-devel] [PATCH] block: Give always priority to unused entries in the qcow2 L2 cache

2015-02-06 Thread Alberto Garcia
On Fri, Feb 06, 2015 at 12:18:07PM +0100, Kevin Wolf wrote: > > I wanted to measure the actual impact of this, so I modified the > > current code to implement a quick and dirty LRU algorithm and made > > some numbers. > > Cool, thanks. I think switching to an LRU algorithm is an option > that mig

Re: [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion

2015-02-06 Thread Stefan Hajnoczi
On Mon, Jan 19, 2015 at 12:27:11PM +0100, Paolo Bonzini wrote: > On 02/01/2015 17:20, Paolo Bonzini wrote: > >> > > >> > The assert can be dropped completely since the code already has an > >> > equivalent assert: > >> > > >> > queues = qemu_find_net_clients_except(nc->name, ncs, > >> >

[Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t

2015-02-06 Thread Peter Maydell
The documentation for sextract64() claims that the return type is an int64_t, but the code itself disagrees. Fix the return type to conform to the documentation and to bring it into line with sextract32(), which returns int32_t. Signed-off-by: Peter Maydell --- I quickly eyeballed all the callers

Re: [Qemu-devel] [PATCH] rtl8139: simplify timer logic

2015-02-06 Thread Stefan Hajnoczi
On Tue, Jan 20, 2015 at 03:44:59PM +0100, Paolo Bonzini wrote: > Pavel Dovgalyuk reports that TimerExpire and the timer are not restored > correctly on the receiving end of migration. > > It is not clear to me whether this is really the case, but we can take > the occasion to get rid of the compli

Re: [Qemu-devel] [PATCH 3/4] net: del hub port when peer is deleted

2015-02-06 Thread Stefan Hajnoczi
On Fri, Feb 06, 2015 at 09:37:54AM +0008, Jason Wang wrote: > On Thu, Feb 5, 2015 at 10:25 PM, Stefan Hajnoczi wrote: > >On Mon, Feb 02, 2015 at 03:06:37PM +0800, Jason Wang wrote: > >> We should del hub port when peer is deleted since it will not be reused > >> and will only be freed during exit.

Re: [Qemu-devel] [PATCH 1/4] monitor: print hub port name during info network

2015-02-06 Thread Stefan Hajnoczi
On Mon, Feb 02, 2015 at 03:06:35PM +0800, Jason Wang wrote: > Signed-off-by: Jason Wang > --- > net/hub.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan pgpS_3oP0TnC2.pgp Description: PGP signatur

Re: [Qemu-devel] [PATCH v2] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Kevin Wolf
Am 05.02.2015 um 16:58 hat Max Reitz geschrieben: > qcow2_alloc_bytes() is a function with insufficient error handling and > an unnecessary goto. This patch rewrites it. > > Signed-off-by: Max Reitz > --- > v2: > - s/free_cluster_index/free_byte_index/ [Eric] > - added an assertion at the start o

Re: [Qemu-devel] [PATCH] block: Give always priority to unused entries in the qcow2 L2 cache

2015-02-06 Thread Kevin Wolf
Am 05.02.2015 um 13:55 hat Alberto Garcia geschrieben: > The current algorithm to replace entries from the L2 cache gives > priority to newer hits by dividing the hit count of all existing > entries by two everytime there is a cache miss. > > However, if there are several cache misses the hit coun

[Qemu-devel] [PULL 0/6] Net patches

2015-02-06 Thread Stefan Hajnoczi
The following changes since commit 16017c48547960539fcadb1f91d252124f442482: softfloat: Clarify license status (2015-01-29 16:45:45 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you to fetch changes up to 2c4681f512822b4aa3537168

[Qemu-devel] [PULL 3/6] monitor: print hub port name during info network

2015-02-06 Thread Stefan Hajnoczi
From: Jason Wang Signed-off-by: Jason Wang Message-id: 1422860798-17495-1-git-send-email-jasow...@redhat.com Signed-off-by: Stefan Hajnoczi --- net/hub.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/hub.c b/net/hub.c index 7e0f2d6..ef09d5f 100644 --- a/net/hub.c

[Qemu-devel] [PULL 1/6] MAINTAINERS: add Jason Wang as net subsystem maintainer

2015-02-06 Thread Stefan Hajnoczi
Jason Wang will be co-maintaining the QEMU net subsystem with me. He has contributed improvements and reviewed patches over the past years as part of working on virtio-net and virtualized networking. Jason has already been backing me up with patch reviews. For the time being I will continue to s

[Qemu-devel] [PULL 4/6] net: remove the wrong comment in net_init_hubport()

2015-02-06 Thread Stefan Hajnoczi
From: Jason Wang Not only nic could be the one to peer. Signed-off-by: Jason Wang Message-id: 1422860798-17495-2-git-send-email-jasow...@redhat.com Signed-off-by: Stefan Hajnoczi --- net/hub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/hub.c b/net/hub.c index ef09d5f..2b60ab9 1006

[Qemu-devel] [PULL 2/6] rtl8139: simplify timer logic

2015-02-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Pavel Dovgalyuk reports that TimerExpire and the timer are not restored correctly on the receiving end of migration. It is not clear to me whether this is really the case, but we can take the occasion to get rid of the complicated code that computes PCSTimeout on the fly upon

[Qemu-devel] [PULL 5/6] net: del hub port when peer is deleted

2015-02-06 Thread Stefan Hajnoczi
From: Jason Wang We should del hub port when peer is deleted since it will not be reused and will only be freed during exit. Signed-off-by: Jason Wang Message-id: 1422860798-17495-3-git-send-email-jasow...@redhat.com Signed-off-by: Stefan Hajnoczi --- net/net.c | 2 ++ 1 file changed, 2 inser

Re: [Qemu-devel] [PATCH v2] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Max Reitz
On 2015-02-06 at 09:08, Kevin Wolf wrote: Am 05.02.2015 um 16:58 hat Max Reitz geschrieben: qcow2_alloc_bytes() is a function with insufficient error handling and an unnecessary goto. This patch rewrites it. Signed-off-by: Max Reitz --- v2: - s/free_cluster_index/free_byte_index/ [Eric] - adde

[Qemu-devel] [PULL 6/6] monitor: more accurate completion for host_net_remove()

2015-02-06 Thread Stefan Hajnoczi
From: Jason Wang Current completion for host_net_remove will show hub ports and clients that were not peered with hub ports. Fix this. Cc: Luiz Capitulino Signed-off-by: Jason Wang Message-id: 1422860798-17495-4-git-send-email-jasow...@redhat.com Signed-off-by: Stefan Hajnoczi --- monitor.c

[Qemu-devel] [PATCH 0/4] target-arm: fix various clang UB sanitizer warnings

2015-02-06 Thread Peter Maydell
This patchset fixes a collection of warnings emitted by the clang undefined behaviour sanitizer in the course of booting an AArch64 Linux guest to a shell prompt. These are all various kinds of bad shift (shifting into the sign bit, left shifting negative values, shifting by more than the size of t

[Qemu-devel] [PATCH 2/4] target-arm: A64: Fix handling of rotate in logic_imm_decode_wmask

2015-02-06 Thread Peter Maydell
The code in logic_imm_decode_wmask attempts to rotate a mask value within the bottom 'e' bits of the value with mask = (mask >> r) | (mask << (e - r)); This has two issues: * if the element size is 64 then a rotate by zero results in a shift left by 64, which is undefined behaviour * if th

[Qemu-devel] [PATCH 4/4] target-arm: A64: Avoid signed shifts in disas_ldst_pair()

2015-02-06 Thread Peter Maydell
Avoid shifting potentially negative signed offset values in disas_ldst_pair() by keeping the offset in a uint64_t rather than an int64_t. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/t

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2015-02-06 Thread Peter Maydell
On 6 February 2015 at 13:45, Stefan Hajnoczi wrote: > The following changes since commit 16017c48547960539fcadb1f91d252124f442482: > > softfloat: Clarify license status (2015-01-29 16:45:45 +) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-p

[Qemu-devel] [PATCH 1/4] target-arm: A64: Fix shifts into sign bit

2015-02-06 Thread Peter Maydell
Fix attempts to shift into the sign bit of an int, which is undefined behaviour in C and warned about by the clang sanitizer. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-arm/translate-a64.c b/target-

[Qemu-devel] [PATCH 3/4] target-arm: A64: Avoid left shifting negative integers in disas_pc_rel_addr

2015-02-06 Thread Peter Maydell
Shifting a negative integer left is undefined behaviour in C. Avoid it by assembling and shifting the offset fields as unsigned values and then sign extending as the final action. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(

[Qemu-devel] [PATCH 2/2] openpic: convert to vmstate

2015-02-06 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/intc/openpic.c | 253 + 1 file changed, 119 insertions(+), 134 deletions(-) diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c index 2a3144f..1ceac97 100644 --- a/hw/intc/openpic.c +++ b/hw/intc/openpic.c

[Qemu-devel] [PATCH 0/2] openpic: convert to vmstate

2015-02-06 Thread Mark Cave-Ayland
This patchset follows on from my ppc loadvm/savevm work and converts openpic over to vmstate. With these patches applied, I can successfully a savevm/loadvm pair under -M mac99 within OpenBIOS, the same result as with the previous patchset applied. Alex: if you're happy with this, I could fixup t

[Qemu-devel] [PATCH 1/2] openpic: switch IRQQueue queue from inline to bitmap

2015-02-06 Thread Mark Cave-Ayland
This is in preparation for using VMSTATE_BITMAP in a followup vmstate migration patch. Signed-off-by: Mark Cave-Ayland --- hw/intc/openpic.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c index 4194cef..2a314

Re: [Qemu-devel] [PATCH 1/7] softfloat: Fix sNaN handling in FP conversion operations

2015-02-06 Thread Maciej W. Rozycki
On Thu, 5 Feb 2015, Peter Maydell wrote: > > Fix sNaN handling in floating-point format conversion operations, that > > are classified by the IEEE 754-2008 standard as general-computational > > operations [1]: > > > > "5.4 formatOf general-computational operations > > > > "5.4.2 Conversion operati

[Qemu-devel] [PATCH v3] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Max Reitz
qcow2_alloc_bytes() is a function with insufficient error handling and an unnecessary goto. This patch rewrites it. Signed-off-by: Max Reitz --- v3: - Use alloc_clusters_noref() and update_refcount() [Kevin] - Only modify s->free_byte_offset if the function is successful; this is now necessary

Re: [Qemu-devel] [PATCH v11 12/13] qemu-iotests: Add tests for drive-backup sync=dirty-bitmap

2015-02-06 Thread Vladimir Sementsov-Ogievskiy
On 12.01.2015 19:31, John Snow wrote: From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: John Snow --- tests/qemu-iotests/056| 33 ++--- tests/qemu-iotests/056.out| 4 ++-- tests/qemu-iotests/iotests.py | 8 3 files changed, 40 inse

Re: [Qemu-devel] [PATCH 1/7] softfloat: Fix sNaN handling in FP conversion operations

2015-02-06 Thread Peter Maydell
On 6 February 2015 at 14:37, Maciej W. Rozycki wrote: > On Thu, 5 Feb 2015, Peter Maydell wrote: >> Have you looked at the other architectures that use these >> functions to convert float values to see what their NaN >> handling semantics are? I agree about what the spec says, >> but we may well h

Re: [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion

2015-02-06 Thread Paolo Bonzini
On 06/02/2015 14:54, Stefan Hajnoczi wrote: > On Mon, Jan 19, 2015 at 12:27:11PM +0100, Paolo Bonzini wrote: >> On 02/01/2015 17:20, Paolo Bonzini wrote: > > The assert can be dropped completely since the code already has an > equivalent assert: > > queues = qemu_find_net_cl

Re: [Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrupt

2015-02-06 Thread Paolo Bonzini
This patch is marked as RFC, but I think it should be included. Stefan/Jason, can you pull it in the next net pull request? Paolo On 08/01/2015 19:38, Frediano Ziglio wrote: > Test behaviour of timers and interrupts related to timeouts. > > Signed-off-by: Frediano Ziglio > --- > tests/Makefile

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] openpic: convert to vmstate

2015-02-06 Thread Alexander Graf
On 06.02.15 15:36, Mark Cave-Ayland wrote: > This patchset follows on from my ppc loadvm/savevm work and converts > openpic over to vmstate. > > With these patches applied, I can successfully a savevm/loadvm pair > under -M mac99 within OpenBIOS, the same result as with the previous > patchset a

Re: [Qemu-devel] [PATCH v3] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Kevin Wolf
Am 06.02.2015 um 15:39 hat Max Reitz geschrieben: > qcow2_alloc_bytes() is a function with insufficient error handling and > an unnecessary goto. This patch rewrites it. > > Signed-off-by: Max Reitz > --- > v3: > - Use alloc_clusters_noref() and update_refcount() [Kevin] > - Only modify s->free_b

Re: [Qemu-devel] [PATCH v3] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Eric Blake
On 02/06/2015 07:39 AM, Max Reitz wrote: > qcow2_alloc_bytes() is a function with insufficient error handling and > an unnecessary goto. This patch rewrites it. > > Signed-off-by: Max Reitz > --- > v3: > - Use alloc_clusters_noref() and update_refcount() [Kevin] Ouch. Not done quite right. Kev

Re: [Qemu-devel] [PATCH v3] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Eric Blake
On 02/06/2015 08:27 AM, Eric Blake wrote: >> >> -/* The cluster refcount was incremented, either by >> qcow2_alloc_clusters() >> - * or explicitly by qcow2_update_cluster_refcount(). Refcount blocks >> must >> - * be flushed before the caller's L2 table updates. >> - */ >> +

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] openpic: convert to vmstate

2015-02-06 Thread Mark Cave-Ayland
On 06/02/15 14:51, Alexander Graf wrote: > On 06.02.15 15:36, Mark Cave-Ayland wrote: >> This patchset follows on from my ppc loadvm/savevm work and converts >> openpic over to vmstate. >> >> With these patches applied, I can successfully a savevm/loadvm pair >> under -M mac99 within OpenBIOS, the

Re: [Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros

2015-02-06 Thread Peter Maydell
On 2 February 2015 at 21:37, Richard Henderson wrote: > On 02/02/2015 12:31 PM, Peter Maydell wrote: >> Peter Maydell (3): >> softfloat: Expand out the STATUS_PARAM macro >> softfloat: expand out STATUS_VAR >> softfloat: expand out STATUS macro >> >> fpu/softfloat-specialize.h | 124 ++-- >

Re: [Qemu-devel] [PATCH 1/2] target-i386: Simplify listflags() function

2015-02-06 Thread Paolo Bonzini
On 03/02/2015 19:08, Eduardo Habkost wrote: > listflags() had lots of unnecessary complexity. Instead of printing to a > buffer that will be immediately printed, simply call the printing > function directly. Also, remove the fbits and flags arguments that were > always set to the same value. Also

Re: [Qemu-devel] [PATCH 0/4] target-arm: fix various clang UB sanitizer warnings

2015-02-06 Thread Greg Bellows
On Fri, Feb 6, 2015 at 8:34 AM, Peter Maydell wrote: > This patchset fixes a collection of warnings emitted by the clang > undefined behaviour sanitizer in the course of booting an AArch64 > Linux guest to a shell prompt. These are all various kinds of bad > shift (shifting into the sign bit, lef

Re: [Qemu-devel] [PATCH v2 0/1] dataplane vs. endianness

2015-02-06 Thread Stefan Hajnoczi
On Mon, Jan 26, 2015 at 05:26:41PM +0100, Cornelia Huck wrote: > Stefan: > > Here's v2 of my endianness patch for dataplane, with the extraneous > vdev argument dropped from get_desc(). > > I orginally planned to send my virtio-1 patchset as well, but I haven't > found the time for it; therefore,

Re: [Qemu-devel] [PULL 0/6] Net patches

2015-02-06 Thread Peter Maydell
On 6 February 2015 at 14:10, Stefan Hajnoczi wrote: > The following changes since commit 16017c48547960539fcadb1f91d252124f442482: > > softfloat: Clarify license status (2015-01-29 16:45:45 +) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/net-pull-

Re: [Qemu-devel] [PATCH 0/4] target-arm: fix various clang UB sanitizer warnings

2015-02-06 Thread Richard Henderson
On 02/06/2015 07:57 AM, Greg Bellows wrote: > Similar to the #define approach, but possibly with the benefits of the enum. > What if you declare each enum separately as const unsigned int? This is not c++. That won't do what you want. r~

Re: [Qemu-devel] [PATCH v3 04/19] libqos/ahci: Add command header helpers

2015-02-06 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 12:41:15PM -0500, John Snow wrote: > Adds command header helper functions: > -ahci_command_header_set > -ahci_command_header_get, > -ahci_command_destroy, and > -ahci_cmd_pick > > These helpers help to quickly manage the command header information in > the AHCI device. > >

Re: [Qemu-devel] [PATCH v3 10/19] qtest/ahci: add ahci_write_fis

2015-02-06 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 12:41:21PM -0500, John Snow wrote: > Similar to ahci_set_command_header, add a helper that takes an > in-memory representation of a command FIS and writes it to guest > memory, handling endianness as-needed. > > Signed-off-by: John Snow > --- > tests/ahci-test.c | 2 +-

Re: [Qemu-devel] Google Summer of Code 2015 - Implement Mac OS 9 support

2015-02-06 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 11:07:40AM -0500, Programmingkid wrote: > Implement support for Mac OS 9 in QEMU. > > QEMU has gone a long way in emulating a Macintosh. But we can still improve. > Adding support for Mac OS 9 would be a great imporovement. This would allow > everyone who misses their old

Re: [Qemu-devel] [PATCH 0/4] target-arm: fix various clang UB sanitizer warnings

2015-02-06 Thread Richard Henderson
On 02/06/2015 06:34 AM, Peter Maydell wrote: > I can't see any nice way of avoiding this. Possible nasty ways: > > (1) Drop the enum and just use old-fashioned > #define EC_AA64_BKPT 0x3cU > since then we can force them to be unsigned > (2) Cast the constant to unsigned at point of use > (3) Keep

Re: [Qemu-devel] [PATCH v3] qcow2: Rewrite qcow2_alloc_bytes()

2015-02-06 Thread Kevin Wolf
Am 06.02.2015 um 16:31 hat Eric Blake geschrieben: > On 02/06/2015 08:27 AM, Eric Blake wrote: > > >> > >> -/* The cluster refcount was incremented, either by > >> qcow2_alloc_clusters() > >> - * or explicitly by qcow2_update_cluster_refcount(). Refcount blocks > >> must > >> - *

Re: [Qemu-devel] [PATCH 2/5] virtio: increase VIRITO_QUEUE_MAX to 513

2015-02-06 Thread Stefan Hajnoczi
On Fri, Feb 06, 2015 at 03:54:10PM +0800, Jason Wang wrote: Subject has a typo s/VIRITIO/VIRTIO/ > Recent linux kernel supports up to 256 tap queues. Increase the limit > to 513 (256 * 2 + 1(ctrl vq)). For other reviewers: sizeof(VirtQueue) on x86_64 is 88 bytes. We waste memory but it's only o

Re: [Qemu-devel] [PATCH 0/5] Support more virtio queues

2015-02-06 Thread Stefan Hajnoczi
On Fri, Feb 06, 2015 at 03:54:08PM +0800, Jason Wang wrote: > We current limit the max virtio queues to 64. This is not sufficient > to support some multiqueue deivces (e.g recent Linux support up to 256 > tap queues). So this series try to let virtio to support more queues. > > No much works need

Re: [Qemu-devel] [v2][RFC][PATCH] virtio: uniform virtio device IDs

2015-02-06 Thread Stefan Hajnoczi
On Fri, Feb 06, 2015 at 01:41:26PM +0800, Tiejun Chen wrote: > Actually we define these device IDs in virtio standard, so > we'd better put them into one common place to manage conveniently. > Here I also add VIRTIO_ID_RESERVE according to virtio spec. > > Signed-off-by: Tiejun Chen > --- > hw/9

[Qemu-devel] [PULL 01/42] Restore atapi_dma flag across migration

2015-02-06 Thread Kevin Wolf
From: "Dr. David Alan Gilbert" If a migration happens just after the guest has kicked off an ATAPI command and kicked off DMA, we lose the atapi_dma flag, and the destination tries to complete the command as PIO rather than DMA. This upsets Linux; modern libata based kernels stumble and recover

[Qemu-devel] [PULL 00/42] Block patches

2015-02-06 Thread Kevin Wolf
The following changes since commit cebbae86b4f7ee3d3dd9df906b97d269e70d9cc7: Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into staging (2015-02-06 14:35:52 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

[Qemu-devel] [PULL 10/42] qemu-img: Add QEMU_PKGVERSION to QEMU_IMG_VERSION

2015-02-06 Thread Kevin Wolf
From: Don Slutz This is the same way vl.c handles this. Signed-off-by: Don Slutz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 4e9a7f5..e148af8 100644 --- a/qemu-img.c +++ b/q

  1   2   3   >