Re: [Qemu-devel] [RFC] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

2015-02-04 Thread David Gibson
On Thu, Feb 05, 2015 at 01:54:39AM +0100, Alexander Graf wrote: > > > On 05.02.15 01:48, David Gibson wrote: > > On Wed, Feb 04, 2015 at 04:19:14PM +0100, Alexander Graf wrote: > >> > >> > >> On 04.02.15 02:32, David Gibson wrote: > >>> On Wed, Feb 04, 2015 at 08:19:06AM +1100, Paul Mackerras wro

[Qemu-devel] [PATCH RFC v4 0/6] Update tests/qemu-iotests failing cases for the s390 platform

2015-02-04 Thread Xiao Guang Chen
v4: 1. Generate all patches based on the latest master branch. 2. Rearrange patches v3: 1. Fix a typo in v2. v2: 1. Drop the patches for test 039 for it has been fixed in upstream. 2. Integrate patches for test 071, 067 and 087. 3. Keep the other patches. v1: 1. updated the test suite to be def

[Qemu-devel] [PATCH RFC v4 4/6] qemu-iotests: s390x: fix test 041

2015-02-04 Thread Xiao Guang Chen
From: Mao Chuan Li There is no such device 'ide-cd' defined on the s390 platform, so test_medium_not_found() test is skipped. Reviewed-by: Michael Mueller Signed-off-by: Mao Chuan Li --- tests/qemu-iotests/041 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/041

[Qemu-devel] [PATCH RFC v4 5/6] qemu-iotests: s390x: fix test 051

2015-02-04 Thread Xiao Guang Chen
From: Mao Chuan Li The tests for device type "ide_cd" are skipped for the s390 platform. The default device id of hard disk on the s390 platform differs to that of the x86 platform. A new variable device_id is defined and "virtio0" set for the s390 platform. A s390 platform specific output file i

[Qemu-devel] [PATCH RFC v4 3/6] qemu-iotests: fix tests 067, 071 and 087

2015-02-04 Thread Xiao Guang Chen
Update the output files for test case 067, 071 and 087 because qemu option -nodefaults was used to start a guest so there are no default floppy and cdrom for guests any more. Use virtio-blk instead of virtio-blk-pci as the device driver for test case 067. For virtio-blk-pci is the same with virtio-

[Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with -nodefaults

2015-02-04 Thread Xiao Guang Chen
This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation of default devices. Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen ---

[Qemu-devel] [PATCH RFC v4 2/6] qemu-iotests: qemu machine type support

2015-02-04 Thread Xiao Guang Chen
From: Mao Chuan Li This patch adds qemu machine type support to the io test suite. Based on the qemu default machine type the reference output file can now vary from the default to a machine specific output file if necessary. That shall allow all platforms to use this test suite. Reviewed-by:

[Qemu-devel] [PATCH RFC v4 6/6] qemu-iotests: s390x: fix test 055

2015-02-04 Thread Xiao Guang Chen
There is no such device 'ide-cd' defined on the s390 platform, so test_medium_not_found() test is skipped. Reviewed-by: Michael Mueller Signed-off-by: Xiao Guang Chen --- tests/qemu-iotests/055 | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/qemu-iotests/055 b/tests/qemu-io

Re: [Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with -nodefaults

2015-02-04 Thread Fam Zheng
On Thu, 02/05 11:44, Xiao Guang Chen wrote: > This patch fixes an io test suite issue that was introduced with the > commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only > a single "stdio" character device'. The option supresses the creation of > default devices. > > Reviewed-by

Re: [Qemu-devel] [PATCH v4 11/18] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2015-02-04 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:23PM +1100, Alexey Kardashevskiy wrote: > This implements DDW for emulated and VFIO PHB. > > This removes all DMA windows on reset and creates the default window, > same is done on the "ibm,reset-pe-dma-window" call. > This converts sPAPRPHBClass::finish_realize to sP

Re: [Qemu-devel] [PATCH v4 12/18] spapr_rtas: Add Dynamic DMA windows (DDW) RTAS handlers

2015-02-04 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:24PM +1100, Alexey Kardashevskiy wrote: > This adds support for Dynamic DMA Windows (DDW) option defined by > the SPAPR specification which allows to have additional DMA window(s) > which can support page sizes other than 4K. > > The existing implementation of DDW in

Re: [Qemu-devel] [PATCH v4 13/18] spapr_pci: Advertise dynamic DMA windows to guest

2015-02-04 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:25PM +1100, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy Needs a commit message. > --- > hw/ppc/spapr.c | 5 + > hw/ppc/spapr_pci.c | 25 + > 2 files changed, 30 insertions(+) > > diff --git a/hw/ppc/spapr.c b/

Re: [Qemu-devel] [PATCH v4 15/18] spapr_pci_vfio: Enable multiple groups per container

2015-02-04 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:27PM +1100, Alexey Kardashevskiy wrote: > This enables multiple IOMMU groups in one VFIO container which means > that multiple devices from different groups can share the same IOMMU table > and locked pages counting can be done once as there is no need to have > severa

Re: [Qemu-devel] [PATCH v4 16/18] spapr_rtas_ddw: Workaround broken LE guests

2015-02-04 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:28PM +1100, Alexey Kardashevskiy wrote: > Recent kernels do parse results of what DDW RTAS calls return incorrectly > if compiled with LITTLE_ENDIAN=yes. > > This adds special handling for such guests. I don't really follow this commit message. You need to justify i

Re: [Qemu-devel] [PATCH v4 17/18] target-ppc: kvm: make use of KVM_CREATE_SPAPR_TCE_64

2015-02-04 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:29PM +1100, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy Needs a commit message, in particular explaining what KVM_CREATE_SPAPR_TCE_64 is and why we want it. I mean, I can guess, but I wrote the original KVM_CREATE_SPAPR_TCE, so I'm hardly typic

Re: [Qemu-devel] [PATCH v4 18/18] vfio: Enable in-kernel acceleration via VFIO KVM device

2015-02-04 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:30PM +1100, Alexey Kardashevskiy wrote: > TCE hypercalls (H_PUT_TCE, H_PUT_TCE_INDIRECT, H_STUFF_TCE) use a logical bus > number (LIOBN) to identify which TCE table the request is addressed to. > However VFIO kernel driver operates with IOMMU group IDs and has no idea

Re: [Qemu-devel] Intel X86 hardware transactional memory

2015-02-04 Thread Patrick Williams III
>I think one possible way is to clear the software tlb on entry to the>transaction and disable (not install any translations) the software>TLB till the end of the transaction. >In the softmmu helper functions, the memory addresses as well as>value can then be tracked in a hashtable and committed to

Re: [Qemu-devel] [PATCH v16 1/2] sPAPR: Implement EEH RTAS calls

2015-02-04 Thread Gavin Shan
On Thu, Feb 05, 2015 at 02:19:49PM +1100, David Gibson wrote: >On Wed, Feb 04, 2015 at 01:27:35PM +1100, Gavin Shan wrote: >> The emulation for EEH RTAS requests from guest isn't covered >> by QEMU yet and the patch implements them. >> >> The patch defines constants used by EEH RTAS calls and adds

Re: [Qemu-devel] [PATCH RFC v4 1/6] qemu-iotests: run qemu with -nodefaults

2015-02-04 Thread chen xiao guang
On 02/05/2015 11:52 AM, Fam Zheng wrote: On Thu, 02/05 11:44, Xiao Guang Chen wrote: This patch fixes an io test suite issue that was introduced with the commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only a single "stdio" character device'. The option supresses the creation

Re: [Qemu-devel] [PATCH v16 2/2] sPAPR: Implement sPAPRPHBClass::eeh_handler

2015-02-04 Thread Gavin Shan
On Thu, Feb 05, 2015 at 02:26:16PM +1100, David Gibson wrote: >On Wed, Feb 04, 2015 at 01:27:36PM +1100, Gavin Shan wrote: >> The patch implements sPAPRPHBClass::eeh_handler so that the >> EEH RTAS requests can be routed to VFIO for further handling. >> >> Signed-off-by: Gavin Shan >> --- >> hw/

Re: [Qemu-devel] [PATCH v5 07/10] qmp: add rocker device support

2015-02-04 Thread Scott Feldman
On Tue, Feb 3, 2015 at 7:10 AM, Eric Blake wrote: > On 01/22/2015 01:03 AM, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> Add QMP/HMP support for rocker devices. This is mostly for debugging >> purposes >> to see inside the device's tables and port configurations. Some examples: >> > >

Re: [Qemu-devel] [PATCH 5/9] exec: protect mru_block with RCU

2015-02-04 Thread Fam Zheng
On Tue, 02/03 13:52, Paolo Bonzini wrote: > Hence, freeing a RAMBlock has to be switched to call_rcu. > > Signed-off-by: Paolo Bonzini > --- > exec.c | 60 > +++--- > include/exec/cpu-all.h | 2 ++ > 2 files changed, 44 insertions(+),

Re: [Qemu-devel] [PATCH v5 03/10] rocker: add register programming guide

2015-02-04 Thread Scott Feldman
On Tue, Feb 3, 2015 at 8:40 AM, Eric Blake wrote: > On 01/22/2015 01:03 AM, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> This is the register programming guide for the Rocker device. It's intended >> for driver writers and device writers. It covers the device's PCI space, >> the regist

Re: [Qemu-devel] [PATCH v5 03/10] rocker: add register programming guide

2015-02-04 Thread Scott Feldman
On Mon, Feb 2, 2015 at 8:19 AM, Stefan Hajnoczi wrote: > On Thu, Jan 22, 2015 at 12:03:52AM -0800, sfel...@gmail.com wrote: >> +SECTION 7: Switch Control >> += >> + >> +This section covers switch-wide register settings. >> + >> +Control >> +--- >> + >> +This register is

[Qemu-devel] [PATCH v6 00/10] rocker: add new rocker ethernet switch device

2015-02-04 Thread sfeldma
From: Scott Feldman v6: - Per Stefan Hajnoczi review: - Move tests to tests/rocker - Fix some mem leaks - Fix doc grammer/spelling - Per Eric Blake review: - Add #optional to optional args comments in qmp interface - Add "query-" prefix to qmp cmds - Fix doc gramm

[Qemu-devel] [PATCH v6 04/10] pci: add rocker device ID

2015-02-04 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- docs/specs/pci-ids.txt |1 + include/hw/pci/pci.h |1 + 2 files changed, 2 insertions(+) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index c6732fe..e4a4490 100644 --- a/docs/specs/pci-ids

[Qemu-devel] [PATCH v6 08/10] rocker: add tests

2015-02-04 Thread sfeldma
From: Scott Feldman Add some basic test for rocker to test L2/L3/L4 functionality. Requires an external test environment, simp, located here: https://github.com/scottfeldman/simp To run tests, simp environment must be installed and a suitable VM image built and installed with a Linux 3.18 (or

[Qemu-devel] [PATCH v6 02/10] virtio-net: use qemu_mac_strdup_printf

2015-02-04 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Reviewed-by: Eric Blake --- hw/net/virtio-net.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 45da34a..698156f 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/vir

[Qemu-devel] [PATCH v6 01/10] net: add MAC address string printer

2015-02-04 Thread sfeldma
From: Scott Feldman We can use this in virtio-net code as well as new Rocker driver code, so up-level this. Signed-off-by: Scott Feldman Reviewed-by: Eric Blake --- include/net/net.h |1 + net/net.c |7 +++ 2 files changed, 8 insertions(+) diff --git a/include/net/net.h b

[Qemu-devel] [PATCH v6 07/10] qmp: add rocker device support

2015-02-04 Thread sfeldma
From: Scott Feldman Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port configurations. Some examples: (qemu) info rocker sw1 name: sw1 id: 0x013512005452 ports: 4 (qemu) info rocker-ports sw1 ena/speed/

[Qemu-devel] [PATCH v6 09/10] MAINTAINERS: add rocker

2015-02-04 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 430688d..8b6f8d4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -736,6 +736,12 @@ S: Maintained F: hw/net/vmxn

[Qemu-devel] [PATCH v6 10/10] rocker: timestamp on the debug logs helps correlate with events in the VM

2015-02-04 Thread sfeldma
From: David Ahern Signed-off-by: David Ahern Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- hw/net/rocker/rocker.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h index ef77487..5ae8aff 100644 --- a/

[Qemu-devel] [PATCH v6 03/10] rocker: add register programming guide

2015-02-04 Thread sfeldma
From: Scott Feldman This is the register programming guide for the Rocker device. It's intended for driver writers and device writers. It covers the device's PCI space, the register set, DMA interface, and interrupts. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- docs/specs/roc

[Qemu-devel] [PATCH v6 05/10] pci: add network device class 'other' for network switches

2015-02-04 Thread sfeldma
From: Scott Feldman Rocker is an ethernet switch device, so add 'other' network device class as defined by PCI to cover these types of devices. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko --- include/hw/pci/pci_ids.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/hw

[Qemu-devel] [PULL 5/9] qmp: Simplify recognition of capability negotiation command

2015-02-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- monitor.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 8323de3..2ac40c9 100644 --- a/monitor.c +++ b/monitor.c @@ -4783,9 +4783,9 @@ static int monitor_can_read(void *opaqu

[Qemu-devel] [PULL 3/9] hmp: Compile hmp_info_spice() only with CONFIG_SPICE

2015-02-04 Thread Markus Armbruster
It's dead code when CONFIG_SPICE is off. If it wasn't, it would crash dereferencing the null pointer returned by the qmp_query_spice() dummy in qmp.c. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Gerd Hoffmann --- hmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --

[Qemu-devel] [PULL 9/9] balloon: Eliminate silly QERR_ macros

2015-02-04 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. They're used with error_set() and qerror_report(), and expand into the first *two* arguments. This trickiness has become pointless. Clean up the balloon ones. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-o

[Qemu-devel] [PULL 2/9] qmp hmp: Improve error messages when SPICE is not in use

2015-02-04 Thread Markus Armbruster
Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, probably because adding another error seemed cumbersome overkill. Produces "No spice device has been activated", which is awkward. We've since abandoned our quest for "rich" error objects. Time to undo the damage to this error message

[Qemu-devel] [PULL 6/9] qmp: Eliminate silly QERR_COMMAND_NOT_FOUND macro

2015-02-04 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. They're used with error_set() and qerror_report(), and expand into the first *two* arguments. This trickiness has become pointless. Clean this one up. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qap

[Qemu-devel] [PULL 0/9] qmp hmp balloon: Cleanups around error reporting

2015-02-04 Thread Markus Armbruster
Luiz asked me to request a pull rather than going through his tree. The following changes since commit 83761b9244ad2ed39d3cfabe8a0e901ab906f7bf: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20150127' into staging (2015-01-27 22:25:56 +) are available in the git reposito

[Qemu-devel] [PULL 1/9] qmp hmp: Factor out common "using spice" test

2015-02-04 Thread Markus Armbruster
Into qemu_using_spice(). For want of a better place, put it next the existing monitor command handler dummies in qemu-spice.h. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Gerd Hoffmann --- include/ui/qemu-spice.h | 10 ++ monitor.c | 5 +++-- q

[Qemu-devel] [PULL 7/9] balloon: Inline qemu_balloon(), qemu_balloon_status()

2015-02-04 Thread Markus Armbruster
... and simplify a bit. Permits factoring out common error checks in the next commit. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- balloon.c | 42 +- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/balloon.c b/balloon.c in

[Qemu-devel] [PULL 8/9] balloon: Factor out common "is balloon active" test

2015-02-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- balloon.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/balloon.c b/balloon.c index 2884c2d..728bb70 100644 --- a/balloon.c +++ b/balloon.c @@ -36,6 +36,19 @@ static QEMUBalloonEven

[Qemu-devel] [PULL 4/9] qmp: Clean up qmp_query_spice() #ifndef !CONFIG_SPICE dummy

2015-02-04 Thread Markus Armbruster
QMP command query-spice exists only #ifdef CONFIG_SPICE. Due to QAPI limitations, we need a dummy function anyway, but it's unreachable. Our current dummy function goes out of its way to produce the exact same error as the QMP core does for unknown commands. Cute, but both unclean and unnecessar

Re: [Qemu-devel] RFC: Universal encryption on QEMU I/O channels

2015-02-04 Thread Markus Armbruster
Peter Maydell writes: > On 4 February 2015 at 16:33, Markus Armbruster wrote: >> Peter Maydell writes: >>> On 4 February 2015 at 13:49, Markus Armbruster wrote: Remind me: what GLib version are we targeting, and why? >>> >>> Our current minimum is 2.12 (or 2.20 in Windows specific code),

<    1   2   3