On 2014/11/27 20:49, Markus Armbruster wrote:
> writes:
>
>> From: Gonglei
>>
>> Signed-off-by: Gonglei
>
> Reviewed-by: Markus Armbruster
Hi, Michael
I guess Paolo forgot this patch :(
Maybe this one can be picked up by qemu-trivial. Thanks.
Regards,
-Gonglei
16.01.2015 22:21, Don Koch wrote:
> Add trace calls for debugging xenfb, ps2 and pcnet.
Applied series to -trivial, thanks!
/mjt
13.01.2015 16:19, Markus Armbruster wrote:
> monitor_parse() desugars --monitor, --qmp and -qmp-pretty to --mon.
> The ID it picks can clash with a user-specified ID. When it happens,
> the error message is misleading.
Thanks, applied to -trivial.
/mjt
21.01.2015 11:00, Gonglei wrote:
[]
> Hi, Michael
>
> I guess Paolo forgot this patch :(
> Maybe this one can be picked up by qemu-trivial. Thanks.
I picked it up and applied to -trivial.
It is not a problem if the same patch will be applied to
several trees at once, so if Paolo will send a pull
On Thu, 8 Jan 2015 12:19:47 +
Peter Maydell wrote:
> The function end_exclusive() isn't used on all targets; mark it as
> such to avoid a clang warning.
>
> Signed-off-by: Peter Maydell
> ---
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lin
On Tue, Jan 20, 2015 at 11:18:37AM +0100, Igor Mammedov wrote:
> On Mon, 12 Jan 2015 09:32:34 +0530
> Bharata B Rao wrote:
>
> > Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed
> > by PowerPC memory hotplug code too.
> >
> > Signed-off-by: Bharata B Rao
> > ---
> > hw/i
NOTE to maintainer: please update test data (ACPI blobs) in test cases
changes from v4:
* rebased on top of PCI tree, dropping 2 patches
that are already there
changes from v3:
* rename acpi_gen_utils.[ch] to acpi-build-utils.[ch]
* copy GLP license block from acpi-build.c
* assert on wron
Signed-off-by: Igor Mammedov
Reviewed-by: Claudio Fontana
---
hw/acpi/acpi-build-utils.c | 14 --
hw/i386/acpi-build.c | 13 ++---
include/hw/acpi/acpi-build-utils.h | 4 ++--
3 files changed, 12 insertions(+), 19 deletions(-)
diff --git a/hw/acpi/acpi
zero initialize AcpiPmInfo struct to reduce code bloat
a little bit.
Signed-off-by: Igor Mammedov
Reviewed-by: Claudio Fontana
---
hw/i386/acpi-build.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 77a124e..4c0536f
Use build_append_namestring() instead of build_append_nameseg()
So user won't have to care whether name is NameSeg, NamePath or
NameString.
See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding
Signed-off-by: Igor Mammedov
Reviewed-by: Claudio Fontana
---
v3:
assert on wrong Segcount earlier
the will be later used for composing AML primitives
and all that could be reused later for ARM machines
as well.
Signed-off-by: Igor Mammedov
---
v3:
* rename acpi_gen_utils.[ch] to acpi-build-utils.[ch]
* copy GLP license block from acpi-build.c
v2:
* fix wrong ident in moved code
---
hw/
On 01/21/2015 11:09 AM, Igor Mammedov wrote:
zero initialize AcpiPmInfo struct to reduce code bloat
a little bit.
Signed-off-by: Igor Mammedov
Reviewed-by: Claudio Fontana
---
hw/i386/acpi-build.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/i386/acpi-build
On 01/21/2015 11:09 AM, Igor Mammedov wrote:
the will be later used for composing AML primitives
and all that could be reused later for ARM machines
as well.
Signed-off-by: Igor Mammedov
---
v3:
* rename acpi_gen_utils.[ch] to acpi-build-utils.[ch]
* copy GLP license block from acpi-build
* Amit Shah (amit.s...@redhat.com) wrote:
> On (Tue) 20 Jan 2015 [14:48:02], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Mostly on the load side, so that when we get a complaint about
> > a migration failure we can figure out what it didn't like.
>
> Nice!
>
>
On 01/21/2015 11:09 AM, Igor Mammedov wrote:
Use build_append_namestring() instead of build_append_nameseg()
So user won't have to care whether name is NameSeg, NamePath or
NameString.
See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding
Signed-off-by: Igor Mammedov
Reviewed-by: Claudio Fon
On 01/21/2015 11:09 AM, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov
Reviewed-by: Claudio Fontana
---
hw/acpi/acpi-build-utils.c | 14 --
hw/i386/acpi-build.c | 13 ++---
include/hw/acpi/acpi-build-utils.h | 4 ++--
3 files changed, 12 insert
20.01.2015 19:23, Paolo Bonzini wrote:
> --- a/hw/audio/sb16.c
> +++ b/hw/audio/sb16.c
> @@ -999,7 +999,7 @@ static IO_READ_PROTO (dsp_read)
> retval = (!s->out_data_len || s->highspeed) ? 0 : 0x80;
> if (s->mixer_regs[0x82] & 1) {
> ack = 1;
> -s->mixer_r
John Snow writes:
> On 01/20/2015 03:26 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>>> On 01/19/2015 05:08 AM, Markus Armbruster wrote:
John Snow writes:
> On 01/16/2015 10:36 AM, Max Reitz wrote:
>> On 2015-01-12 at 11:30, John Snow wrote:
>>> From: Fam Zheng
>
it basicaly does the same as original approach,
* just without bus/notify tables tracking (less obscure)
which is easier to follow.
* drops unnecessary loops and bitmaps,
creating devices and notification method in the same loop.
* saves us ~100LOC
Signed-off-by: Igor Mammedov
---
v4:
* kee
On Tue, 20 Jan 2015 13:33:27 +0100
Markus Armbruster wrote:
> Cornelia Huck writes:
>
> > On Tue, 20 Jan 2015 10:45:41 +0100
> > Markus Armbruster wrote:
> >
> >> This patch makes Coverity unhappy:
> >>
> >> *** CID 1264326: Unintended sign extension (SIGN_EXTENSION)
> >> /hw/s390x/s390-pci
On 01/21/2015 11:09 AM, Igor Mammedov wrote:
it basicaly does the same as original approach,
* just without bus/notify tables tracking (less obscure)
which is easier to follow.
* drops unnecessary loops and bitmaps,
creating devices and notification method in the same loop.
* saves us ~100L
On Tue, 20 Jan 2015 10:56:37 +0100
Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> hw/s390x/s390-pci-bus.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 1201b8d..d25ac74 100644
> --- a/hw
On 21/01/2015 10:32, Michael Tokarev wrote:
>> > --- a/hw/audio/sb16.c
>> > +++ b/hw/audio/sb16.c
>> > @@ -999,7 +999,7 @@ static IO_READ_PROTO (dsp_read)
>> > retval = (!s->out_data_len || s->highspeed) ? 0 : 0x80;
>> > if (s->mixer_regs[0x82] & 1) {
>> > ack = 1;
On 01/16/2015 03:56 PM, Chen Fan wrote:
On 01/12/2015 09:56 PM, Marcel Apfelbaum wrote:
On 01/12/2015 05:04 AM, Chen Fan wrote:
in spec "PCI Express 3.0" section 6.2.6 Figure 6-3 virtual bridge part,
the flowchart showing tell us SERR# enable at Bridge Control register
associate with system e
From: "Dr. David Alan Gilbert"
Tidy up some old printfs
Add some more error_reports that previously just failed with invalid.
Add lots and lots of tracing.
Dr. David Alan Gilbert (3):
savevm: Convert fprintf to error_report
Migration: Add lots of trace events
Print errors in some of the ea
From: "Dr. David Alan Gilbert"
Convert a bunch of fprintfs to error_reports
Signed-off-by: Dr. David Alan Gilbert
---
migration/vmstate.c | 7 ---
savevm.c| 21 +++--
2 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/migration/vmstate.c b/migrati
From: "Dr. David Alan Gilbert"
Mostly on the load side, so that when we get a complaint about
a migration failure we can figure out what it didn't like.
Signed-off-by: Dr. David Alan Gilbert
---
migration/vmstate.c | 24
savevm.c| 10 +++---
trace-event
From: "Dr. David Alan Gilbert"
Signed-off-by: Dr. David Alan Gilbert
---
savevm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 1cc0f02..98895fe 100644
--- a/savevm.c
+++ b/savevm.c
@@ -883,16 +883,20 @@ int qemu_loadvm_state(QEMUFile *f)
On Fri, Jan 16, 2015 at 11:21 AM, Mohammed Gamal <
mohammed.ga...@profitbricks.com> wrote:
> On Thu, Jan 15, 2015 at 06:27:54PM +0100, Paolo Bonzini wrote:
> >
> >
> > On 15/01/2015 17:39, Mohammed Gamal wrote:
> > > The increase in the jitter and offset values is well within the 500 ppm
> > > fre
Hi,
On Tue, Jan 20, 2015 at 02:54:20PM +, Peter Maydell wrote:
> Ping!
I've just updated my linux-user-for-upstream tree. I'll get it
reviewed/tested tonight.
> thanks
> -- PMM
>
> On 8 January 2015 at 12:19, Peter Maydell wrote:
> > This patchset fixes warnings produced by clang in the li
Hi,
Does drive_mirror support incremental backup a running vm?
Or other mechanism does?
incremental backup a running vm requirements:
First time backup, all of the allocated data will be mirrored to destination,
then a copied bitmap will be saved to a file, then the bitmap file will log
dirty fo
On Wed, 21 Jan 2015 14:28:18 +0530
Bharata B Rao wrote:
> On Tue, Jan 20, 2015 at 11:18:37AM +0100, Igor Mammedov wrote:
> > On Mon, 12 Jan 2015 09:32:34 +0530
> > Bharata B Rao wrote:
> >
> > > Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed
> > > by PowerPC memory hotp
On 21/01/2015 11:32, Zhang Haoyu wrote:
> Hi,
>
> Does drive_mirror support incremental backup a running vm?
> Or other mechanism does?
>
> incremental backup a running vm requirements:
> First time backup, all of the allocated data will be mirrored to destination,
> then a copied bitmap will b
On 21/01/2015 03:14, Gonglei wrote:
> On 2015/1/21 0:10, Paolo Bonzini wrote:
>
>>
>>
>> On 19/01/2015 14:23, arei.gong...@huawei.com wrote:
>>> @@ -780,6 +788,12 @@ static int qdev_get_fw_dev_path_helper(DeviceState
>>> *dev, char *p, int size)
>>> d = bus_get_fw_dev_path(dev->par
Greg Bellows writes:
> On Tue, Jan 20, 2015 at 10:57 AM, Alex Bennée wrote:
>>
>> Greg Bellows writes:
>>
>>> Add 32-bit to/from 64-bit register synchronization on register gets and
>>> puts.
>>> Set EL1_32BIT feature flag passed to KVM
>>>
>>> Signed-off-by: Greg Bellows
>>> }
>>>
>>>
On 21 January 2015 at 08:40, Thomas Huth wrote:
> IMHO it might be better to add a proper #ifdef guard around that
> function. Consider that the calls to end_exclusive() might get removed
> completely one day, then you won't get a compiler warning about the
> unused function anymore if you used th
On 21 January 2015 at 10:54, Alex Bennée wrote:
>
> Greg Bellows writes:
>
>> On Tue, Jan 20, 2015 at 10:57 AM, Alex Bennée wrote:
>>> I know why we do this (especially given where my attempt ended up) but
>>> perhaps we could at list have a single state aware accessor so we don't
>>> end up dup
Greg Bellows writes:
> Thanks Alex comments inline
>
>>
>> Aren't we leaking here? strtok returns the next token (or NULL) so don't
>> we loose the original ptr?
>>
>>
> As I understand it, strtok uses static pointers to track the location
> within an existing string rather than allocating
The command is not implemented correctly yet. The documentation allows
to not pass any value to set, in which case the time is re-read from
RTC. However, reading CMOS on Windows is not trivial to implement. So
instead of pretending we've set the correct time, fail explicitly.
Signed-off-by: Michal
On Tue, 20 Jan 2015 11:08:24 +
Stefan Hajnoczi wrote:
> On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote:
> > @@ -608,6 +631,25 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
> > }
> > }
> > break;
> > +case CCW_CMD_SET_VIRTIO_REV:
> > +
On Tue, 20 Jan 2015 16:45:19 -0600
Greg Bellows wrote:
> On Tue, Jan 20, 2015 at 10:25 AM, Igor Mammedov wrote:
> > On Tue, 20 Jan 2015 16:08:09 +
> > Peter Maydell wrote:
> >
> >> On 20 January 2015 at 15:59, Igor Mammedov wrote:
> >> > On Tue, 20 Jan 2015 15:34:23 +
> >> > Peter Mayd
Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to
support IGD GFX passthrough"):
> When we're working to support IGD GFX passthrough with qemu
> upstream, instead of "-gfx_passthru" we'd like to make that
> a machine option, "-machine xxx,gfx_passthru=on". This need
> to bri
On Thu, Dec 11, 2014 at 10:20:23AM +0800, Hu Tao wrote:
> This makes code more readable.
>
> Signed-off-by: Hu Tao
> Reviewed-by: Marcel Apfelbaum
> ---
> include/hw/pci/pci.h | 39 ---
> 1 file changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/inc
On Thu, Dec 11, 2014 at 10:20:24AM +0800, Hu Tao wrote:
> This makes code more readable.
>
> Signed-off-by: Hu Tao
> Reviewed-by: Marcel Apfelbaum
> ---
> hw/mips/gt64xxx_pci.c | 4 ++--
> hw/pci/pci_host.c | 5 +++--
> include/hw/pci/pci_host.h | 5 +
> 3 files changed, 10 inse
On Wed, 21 Jan 2015 12:23:18 +0100
Cornelia Huck wrote:
> On Tue, 20 Jan 2015 11:08:24 +
> Stefan Hajnoczi wrote:
>
> > On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote:
> > > @@ -608,6 +631,25 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
> > > }
> > >
On Thu, Dec 11, 2014 at 10:20:25AM +0800, Hu Tao wrote:
> PCI_HOST_BRIDGE_CONFIG_ADDR and PCI_HOST_BRIDGE_CONFIG_DATA are
> defined in PCI specification, so move them to common place.
they are listed in the spec, but they are still PC specific.
Spec says:
Two DWORD I/O locations are used
Markus Armbruster writes:
> Frank Blaschka writes:
>
>> On Tue, Jan 20, 2015 at 01:56:09PM +0100, Markus Armbruster wrote:
>>> Markus Armbruster writes:
>>>
>>> > Cornelia Huck writes:
>>> >
>>> >> On Tue, 20 Jan 2015 10:45:41 +0100
>>> >> Markus Armbruster wrote:
>>> >>
>>> >>> This patch m
On Wed, 2015-01-21 at 11:37 +, Ian Jackson wrote:
> Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to
> support IGD GFX passthrough"):
> > When we're working to support IGD GFX passthrough with qemu
> > upstream, instead of "-gfx_passthru" we'd like to make that
> > a ma
On Thu, Dec 11, 2014 at 10:20:26AM +0800, Hu Tao wrote:
> Since the limit parameter is always set to the size of pci device's
> configuration space, and we can determine the size from the type of pci
> device.
>
> Signed-off-by: Hu Tao
Not true e.g. for pci_data_read, is it?
Need a bit more comm
On Thu, Dec 11, 2014 at 10:20:27AM +0800, Hu Tao wrote:
> Since the limit parameter is always set to the size of pci device's
> configuration space, and we can determine the size from the type of pci
> device.
Same comment.
> Signed-off-by: Hu Tao
> ---
> hw/pci/pci_host.c | 13
On Thu, Dec 11, 2014 at 10:20:28AM +0800, Hu Tao wrote:
> Introduce PCI_DEVFN_AUTO rather than using -1 in code.
>
> Signed-off-by: Hu Tao
> ---
> hw/core/qdev-properties.c | 1 +
> hw/pci/pci.c | 5 ++---
> include/hw/pci/pci.h | 2 ++
> 3 files changed, 5 insertions(+), 3 del
On Fri, 12 Dec 2014 10:01:46 +0100
Cornelia Huck wrote:
> Several places check against the feature bit number instead of against
> the feature bit. Fix them.
>
> Reported-by: Thomas Huth
> Signed-off-by: Cornelia Huck
> ---
> hw/scsi/virtio-scsi.c | 2 +-
> hw/virtio/dataplane/vring.c |
On Wed, Jan 21, 2015 at 02:41:33PM +0800, Hu Tao wrote:
> ping...
At some point you said "will resend".
> On Thu, Dec 11, 2014 at 10:20:22AM +0800, Hu Tao wrote:
> > Hi,
> >
> > This is v3 of PCI clenaup series. See each patch for the detail.
> >
> > Regards,
> > Hu
> >
> > changes:
> >
> > v
On Wed, 21 Jan 2015 12:51:41 +0100
Thomas Huth wrote:
> On Wed, 21 Jan 2015 12:23:18 +0100
> Cornelia Huck wrote:
>
> > On Tue, 20 Jan 2015 11:08:24 +
> > Stefan Hajnoczi wrote:
> >
> > > On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote:
> > > > @@ -608,6 +631,25 @@ static in
this patch avoids sign extension and fixes a data conversion
bug in stpcifc. Both issues where found by Coverity.
Signed-off-by: Frank Blaschka
---
hw/s390x/s390-pci-inst.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst
We're using the Coverity Scan service[*]. We've put in some effort, and
we've gotten some mileage out of it, but I feel we could get more.
Judging from the report e-mail I have lying about, we're scanning about
once a month on average. These reports cuts off after 20 new defects.
When there are
SYS_signalfd is deprecated and absent on some Linux systems that do
support signalfd().
Also, in 2015 the signalfd() libc function should be available wherever
the underlying syscall(s) are available.
Drop SYS_signalfd and check for & use signalfd() directly.
Laszlo Ersek (2):
qemu_signalfd_av
Noone calls qemu_signalfd_available(), let's remove it.
Signed-off-by: Laszlo Ersek
---
include/qemu/compatfd.h | 1 -
util/compatfd.c | 19 ---
2 files changed, 20 deletions(-)
diff --git a/include/qemu/compatfd.h b/include/qemu/compatfd.h
index 6b04877..fc37915 100644
On 21 January 2015 at 12:47, Markus Armbruster wrote:
> We're using the Coverity Scan service[*]. We've put in some effort, and
> we've gotten some mileage out of it, but I feel we could get more.
>
> Judging from the report e-mail I have lying about, we're scanning about
> once a month on averag
qemu_signalfd() provides the (effects of the) Linux signalfd() syscall on
platforms that lack it. However, the check for the availability of
signalfd() in configure, and its use in qemu_signalfd() when it *is*
available, are seriously outdated (they date back to 2010-2011).
To wit, the SYS_signalf
Hi Alex,
are you planning a respin of this one?
Between your series and Alvise's I would just need one of the two to get
merged, they are both fine for me, pending some small things that have been
raised in the comments..
Ciao & thanks,
Claudio
On 06.01.2015 17:03, Alexander Graf wrote:
> Li
On 21.01.15 13:59, Claudio Fontana wrote:
> Hi Alex,
>
> are you planning a respin of this one?
Yup, will send a respin with 4 IRQs this week.
Alex
On 21 January 2015 at 13:01, Alexander Graf wrote:
>
>
> On 21.01.15 13:59, Claudio Fontana wrote:
>> Hi Alex,
>>
>> are you planning a respin of this one?
>
> Yup, will send a respin with 4 IRQs this week.
I've finished reading my thousand-page book on PCIe,
so hopefully will be able to review t
Coverity reports
Error: MISSING_BREAK:
target-tricore/translate.c:1648: unterminated_case: This case (value
"OPC1_32_B_JLA") is not terminated by a 'break' statement.
target-tricore/translate.c:1650: fallthrough: The above case falls through
to this one.
Here's the code:
case O
Commit 22382bb96c8bd88370c1ff0cb28c3ee6bee79ed3 renamed the
'hw_cursor_x' and 'hw_cursor_y' fields in cirrus_vga. Update the static
checker's whitelist to allow matching against the old and new names.
Signed-off-by: Amit Shah
---
scripts/vmstate-static-checker.py | 2 ++
1 file changed, 2 inser
On 21 January 2015 at 11:54, Markus Armbruster wrote:
> Markus Armbruster writes:
>
>> Frank Blaschka writes:
>>
>>> On Tue, Jan 20, 2015 at 01:56:09PM +0100, Markus Armbruster wrote:
Markus Armbruster writes:
> 1. pbdev->isc gets promoted from uint8_t to int as operand of binary <<
>
On 21/01/2015 13:57, Laszlo Ersek wrote:
> SYS_signalfd is deprecated and absent on some Linux systems that do
> support signalfd().
>
> Also, in 2015 the signalfd() libc function should be available wherever
> the underlying syscall(s) are available.
>
> Drop SYS_signalfd and check for & use s
The "fall through" added by the commit is clearly intentional. Mark
it so. Hushes up Coverity.
Signed-off-by: Markus Armbruster
---
hw/net/xilinx_ethlite.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
index 9536f64..ad6b553 100644
--- a/
On Mon, 19 Jan 2015 17:04:36 +
Stefan Hajnoczi wrote:
> vring_more_avail() was an inline function in vring.h. No external
> callers use it so it's not necessary to export it.
>
> Furthermore, we'll need virtio-access.h for endian-aware memory accesses
> but that only works in per-target obj
On Tue, Jan 20, 2015 at 4:27 PM, Cornelia Huck wrote:
> @@ -154,7 +157,7 @@ bool vring_should_notify(VirtIODevice *vdev, Vring *vring)
> }
>
>
> -static int get_desc(Vring *vring, VirtQueueElement *elem,
> +static int get_desc(VirtIODevice *vdev, Vring *vring, VirtQueueElement *elem,
>
On Mon, Jan 19, 2015 at 5:04 PM, Stefan Hajnoczi wrote:
> In commit 0f5d1d2a49778863db54b4b1ac2dc008a8f21f11 ("virtio: memory accessors
> for endian-ambivalent targets") endian-aware memory accessors were added to
> support bi-endian targets like recent ppc64 systems.
>
> The dataplane vring.c cod
On Wed, Jan 21, 2015 at 01:47:22PM +0100, Markus Armbruster wrote:
> We're using the Coverity Scan service[*]. We've put in some effort, and
> we've gotten some mileage out of it, but I feel we could get more.
>
> Judging from the report e-mail I have lying about, we're scanning about
> once a mo
This patch adds an emulation model for i2c controller found on most of the FSL
SoCs.
It also integrates the RTC(ds1338) that sits on the i2c Bus with e500 machine
model.
Signed-off-by: Amit Singh Tomar
---
Changes in v4:
* Addressed Alex's comments given for v2.
Changes in v3:
On Mi, 2015-01-21 at 18:36 +0530, Amit Shah wrote:
> Commit 22382bb96c8bd88370c1ff0cb28c3ee6bee79ed3 renamed the
> 'hw_cursor_x' and 'hw_cursor_y' fields in cirrus_vga. Update the
> static
> checker's whitelist to allow matching against the old and new names.
>
> Signed-off-by: Amit Shah
Review
Peter Maydell writes:
> On 21 January 2015 at 11:54, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>>> Frank Blaschka writes:
>>>
On Tue, Jan 20, 2015 at 01:56:09PM +0100, Markus Armbruster wrote:
> Markus Armbruster writes:
> > 1. pbdev->isc gets promoted from uint8_t
On Mi, 2015-01-21 at 11:37 +, Ian Jackson wrote:
> Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to
> support IGD GFX passthrough"):
> > When we're working to support IGD GFX passthrough with qemu
> > upstream, instead of "-gfx_passthru" we'd like to make that
> > a mac
Peter Maydell writes:
> On 21 January 2015 at 12:47, Markus Armbruster wrote:
>> We're using the Coverity Scan service[*]. We've put in some effort, and
>> we've gotten some mileage out of it, but I feel we could get more.
>>
>> Judging from the report e-mail I have lying about, we're scanning
On Wed, Jan 21, 2015 at 01:07:59PM +0100, Thomas Huth wrote:
> On Fri, 12 Dec 2014 10:01:46 +0100
> Cornelia Huck wrote:
>
> > Several places check against the feature bit number instead of against
> > the feature bit. Fix them.
> >
> > Reported-by: Thomas Huth
> > Signed-off-by: Cornelia Huck
Hello,
Is it possible to do -loadvm with a read-only image? What I'm trying to do
is running already booted OS but discarding all the changes. So basically,
I'd like to combine -loadvm and -snapshot. The image needs to be read-only
because there are multiple simultaneous instances running. As a wo
On Tue, Jan 20, 2015 at 02:32:33PM +0100, Paolo Bonzini wrote:
> This is used by "-realtime mlock=on".
>
> Signed-off-by: Paolo Bonzini
> ---
> qemu-seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index b0c6269..f9de0d3 100644
> --- a/qemu-se
On 21/01/2015 13:47, Markus Armbruster wrote:
> I also use Coverity locally (requires a license) with a derived model
> for GLib to increase scanning power. Since last July, the number of
> defects I get that way has increased from ~400 to ~700. Not quite as
> bad as it sounds, because ~100 of
On Sat, Dec 06, 2014 at 06:52:56PM +0200, Nikolay Nikolaev wrote:
> Vhost-user will implement the multiqueueu support in a similar way to what
> vhost already has - a separate thread for each queue.
>
> To enable multiquue funcionality - a new command line parameter
> "queues" is introduced for th
On Jan 21, 2015, at 2:54 AM, Markus Armbruster wrote:
> Programmingkid writes:
>
>> On Jan 20, 2015, at 3:28 PM, Markus Armbruster wrote:
>>
>>> Programmingkid writes:
>>>
On Jan 20, 2015, at 10:22 AM, Eric Blake wrote:
> On 01/20/2015 07:29 AM, Programmingkid wrote:
>>
>
On 21 January 2015 at 13:41, Markus Armbruster wrote:
> I suspect we shift signed values all over the place, without regard for
> signed overflow. Machines are fine with that, but some day some
> compiler wiseguy may find a way to save a femtosecond or two for some
> program that never does that,
Paolo Bonzini writes:
> On 21/01/2015 13:47, Markus Armbruster wrote:
>> I also use Coverity locally (requires a license) with a derived model
>> for GLib to increase scanning power. Since last July, the number of
>> defects I get that way has increased from ~400 to ~700. Not quite as
>> bad as
On Tue, Jan 20, 2015 at 02:32:33PM +0100, Paolo Bonzini wrote:
> This is used by "-realtime mlock=on".
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Eduardo Habkost
Tested-by: Eduardo Habkost
--
Eduardo
On 21/01/2015 15:57, Markus Armbruster wrote:
>> QEMU is also using a GLib model on Coverity Scan, as well as a
>> QEMU-specific model, which suggests one of the following:
>
> What do you mean by "a GLib model"? scripts/coverity-model.c?
Yes. It models g_malloc0 in a way that avoids a lot of
Coverity flags this as "dereference after null check". Not quite a
dereference, since it will just EFAULT, but still nice to fix.
Signed-off-by: Paolo Bonzini
---
exec.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/exec.c b/exec.c
index 081818e..bfbfd23 1006
On Mon, Nov 24, 2014 at 04:56:59PM +0100, Max Reitz wrote:
> @@ -136,6 +138,34 @@ int qcow2_read_snapshots(BlockDriverState *bs)
>size_to_clusters(s, sn->l1_size *
>sizeof(uint64_t)),
>
On 21/01/2015 14:41, Markus Armbruster wrote:
> I suspect we shift signed values all over the place, without regard for
> signed overflow. Machines are fine with that, but some day some
> compiler wiseguy may find a way to save a femtosecond or two for some
> program that never does that, breaki
On Mon, Nov 24, 2014 at 04:57:00PM +0100, Max Reitz wrote:
> @@ -2166,126 +2166,6 @@ fail:
> return ret;
> }
>
> -#define overlaps_with(ofs, sz) \
> -ranges_overlap(offset, size, ofs, sz)
Dropping this macro makes me happy.
pgpxA8Q5wIqTT.pgp
Description: PGP signature
On 20/01/15 15:01, Paolo Bonzini wrote:
> On 23/12/2014 01:36, Mark Cave-Ayland wrote:
>> Since env->msr has already been restored by the time cpu_post_load is called,
>> make sure that ppc_store_msr() is explicitly called with all msr bits marked
>> as invalid.
>>
>> This solves the issue where M
On Wed, 21 Jan 2015 13:30:02 +
Stefan Hajnoczi wrote:
> On Tue, Jan 20, 2015 at 4:27 PM, Cornelia Huck
> wrote:
> > @@ -154,7 +157,7 @@ bool vring_should_notify(VirtIODevice *vdev, Vring
> > *vring)
> > }
> >
> >
> > -static int get_desc(Vring *vring, VirtQueueElement *elem,
> > +static i
On 01/21/2015 02:34 AM, Markus Armbruster wrote:
> Opinions?
>
I'm still thinking about my reply (it's a big enough question that I
want to make sure I consider ramifications), so this is just a
meta-reply to let you know I'm tracking this conversation.
CC'ing Eric Blake, as well, for comme
"Daniel P. Berrange" writes:
> On Wed, Jan 21, 2015 at 01:47:22PM +0100, Markus Armbruster wrote:
>> We're using the Coverity Scan service[*]. We've put in some effort, and
>> we've gotten some mileage out of it, but I feel we could get more.
>>
>> Judging from the report e-mail I have lying ab
this patch avoids sign extension and fixes a data conversion
bug in stpcifc. Both issues where found by Coverity.
Signed-off-by: Frank Blaschka
---
hw/s390x/s390-pci-inst.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-in
On 21 January 2015 at 15:55, Markus Armbruster wrote:
> I wasn't bold enough to suggest "daily", let alone "release blocker".
I think the Coverity FAQ says we can't do more than 2
scans a week for a project of QEMU's size anyway...
-- PMM
Otherwise when cpu_post_load calls ppc_store_sdr1() when restoring a VM
snapshot the value is deemed unchanged and so the internal env->htab*
variables aren't set correctly.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Paolo Bonzini
---
target-ppc/misc_helper.c |7 ++-
target-ppc/mmu_he
This ensures that the macio PCI device is correctly configured when restoring
from a VM snapshot.
Signed-off-by: Mark Cave-Ayland
---
hw/misc/macio/macio.c | 24
1 file changed, 24 insertions(+)
diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c
index e0f1e88.
This patchset fixes up various bugs in loadvm/savevm for -M g3beige and
-M mac99 so that it is becomes possible to save and restore image snapshots.
The focus of this patchset is on -M g3beige since this matches the majority
of my test images, but there were some easy fixes to be made to -M mac99
1 - 100 of 193 matches
Mail list logo
