Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-01-12 Thread Jan Kiszka
On 2014-10-22 13:38, Pavel Dovgalyuk wrote: > This patch fixes instructions counting when execution is stopped on > breakpoint (e.g. set from gdb). Without a patch extra instruction is > translated > and icount is incremented by invalid value (which equals to number of > executed instructions + 1)

Re: [Qemu-devel] How to clone a running vm?

2015-01-12 Thread Zhang Haoyu
On 2015-01-12 15:50:13, Zhang Haoyu wrote: >Hi, > >I want to clone a running vm without shutoff, >can below method work? >1) create a snapshot for the vm >2) create a new qcow2 image from the snapshot, but how? >3) use the new qcow2 image as backing image to clone vms > Can drive_mirror clone a ru

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-01-12 Thread Pavel Dovgaluk
> From: Jan Kiszka [mailto:jan.kis...@siemens.com] > On 2014-10-22 13:38, Pavel Dovgalyuk wrote: > > This patch fixes instructions counting when execution is stopped on > > breakpoint (e.g. set from gdb). Without a patch extra instruction is > > translated > > and icount is incremented by invalid

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-01-12 Thread Jan Kiszka
On 2015-01-12 09:26, Pavel Dovgaluk wrote: >> From: Jan Kiszka [mailto:jan.kis...@siemens.com] >> On 2014-10-22 13:38, Pavel Dovgalyuk wrote: >>> This patch fixes instructions counting when execution is stopped on >>> breakpoint (e.g. set from gdb). Without a patch extra instruction is >>> transla

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vt82c686: avoid out-of-bounds read

2015-01-12 Thread Michael Tokarev
10.12.2014 12:17, Paolo Bonzini wrote: > superio_ioport_readb can read the 256th element of the array. > Coverity reports an out-of-bounds write in superio_ioport_writeb, > but it does not show the corresponding out-of-bounds read > because it cannot prove that it can happen. Fix the root > cause

Re: [Qemu-devel] [PATCH 0/3] miscellaneous minor clang fixes

2015-01-12 Thread Michael Tokarev
24.12.2014 01:26, Peter Maydell wrote: > This is a collection of three miscellaneous minor fixes for > clang compile warnings, which I think could reasonably go via > the -trivial tree. The map_exec patch has been on list and > reviewed before; the other two are new. > > Peter Maydell (2): > tes

Re: [Qemu-devel] [PATCH 0/3] Fix new typos found by codespell

2015-01-12 Thread Michael Tokarev
03.01.2015 16:41, Stefan Weil wrote: > [PATCH 1/3] target-tricore: Fix new typos > [PATCH 2/3] target-arm: Fix typo in comment (seperately -> separately) > [PATCH 3/3] misc: Fix new typos in comments Applied all to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 09:30, Jan Kiszka wrote: > I think this would only cure a symptom, but it doesn't explain why we > now hit cpu_handle_guest_debug which we do not before the patch: That means we now exit with EXCP_DEBUG and we didn't before? Something like this would be a more complete fix (it wor

Re: [Qemu-devel] [PATCH 1/1] Do not hang on full PTY

2015-01-12 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] target-openrisc: bugfix for dec_sys to decode instructions correctly

2015-01-12 Thread Michael Tokarev
06.01.2015 20:06, David Morrison wrote: > Fixed the decoding of "system" instructions (starting with 0x2) > in dec_sys() in translate.c. In particular, the l.trap instruction > is now correctly decoded, which enables for singlestepping and > breakpoints to be set in GDB. Applied to -trivial, than

Re: [Qemu-devel] [PATCH] blizzard: do not depend on VGA internals

2015-01-12 Thread Michael Tokarev
09.01.2015 12:59, Paolo Bonzini wrote: > There is nothing that is used by this ARM-specific device. Indeed. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: Remove config.status and common.env during 'make distclean'

2015-01-12 Thread Michael Tokarev
15.12.2014 13:19, Thomas Huth wrote: > config.status and tests/qemu-iotests/common.env are generated files > that should be deleted during 'make distclean'. Somehow I missed this one previously. Applied to -trivial now, thank you! (I'm not sure why did you combine po/*.mo and .../common.env into

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] vl.c: fix some alignment issues

2015-01-12 Thread Michael Tokarev
11.01.2015 13:56, Marcel Apfelbaum wrote: > The misalignment was caused by tabs which were used instead of spaces. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH v2] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-12 Thread Gerd Hoffmann
Hi, > +/* Determines the pixel format of the frame buffer */ > +if (surface->format == PIXMAN_b8g8r8x8) { > +bitmap_info = kCGBitmapByteOrder32Big | kCGImageAlphaNoneSkipFirst; > +} That certainly goes into the right direction. PIXMAN_* is native endian though, so I expect

Re: [Qemu-devel] How to clone a running vm?

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 09:15, Zhang Haoyu wrote: > > I want to clone a running vm without shutoff, > > can below method work? > > 1) create a snapshot for the vm > > 2) create a new qcow2 image from the snapshot, but how? > > 3) use the new qcow2 image as backing image to clone vms > > Can drive_mirror cl

[Qemu-devel] Missing Diag/Debug Registers in lsi53c895a emulation

2015-01-12 Thread Peter Lieven
Hi, while trying to run an ASA1000V appliance I found that registers 0x09 and 0x3c-3f are read during boot up. Which currently results in an exit(1). The appliance uses an quite ancient 2.6.29.6 Linux kernel. These registers are mainly for diag and debug purposes so I came up with the followin

Re: [Qemu-devel] Missing Diag/Debug Registers in lsi53c895a emulation

2015-01-12 Thread Peter Lieven
On 12.01.2015 10:28, Peter Lieven wrote: Hi, while trying to run an ASA1000V appliance I found that registers 0x09 and 0x3c-3f are read during boot up. Which currently results in an exit(1). The appliance uses an quite ancient 2.6.29.6 Linux kernel. These registers are mainly for diag and debu

Re: [Qemu-devel] Missing Diag/Debug Registers in lsi53c895a emulation

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 10:39, Peter Lieven wrote: > On 12.01.2015 10:28, Peter Lieven wrote: >> Hi, >> >> while trying to run an ASA1000V appliance I found that registers 0x09 >> and 0x3c-3f are read during boot up. Which >> currently results in an exit(1). The appliance uses an quite ancient >> 2.6.29.6

[Qemu-devel] [PATCH] pci: add diagnostics for invalid BAR addresses

2015-01-12 Thread hw . claudio
From: Claudio Fontana show diagnostics when the reprogrammed BAR addresses are invalid, either because of a guest mistake or because of QEMU limitations. Signed-off-by: Claudio Fontana --- hw/pci/pci.c | 42 +++--- 1 file changed, 31 insertions(+), 11 deleti

Re: [Qemu-devel] Missing Diag/Debug Registers in lsi53c895a emulation

2015-01-12 Thread Peter Lieven
On 12.01.2015 10:42, Paolo Bonzini wrote: On 12/01/2015 10:39, Peter Lieven wrote: On 12.01.2015 10:28, Peter Lieven wrote: Hi, while trying to run an ASA1000V appliance I found that registers 0x09 and 0x3c-3f are read during boot up. Which currently results in an exit(1). The appliance uses

[Qemu-devel] [PATCH] hw/scsi/lsi53c895a: add support for additional diag / debug registers

2015-01-12 Thread Peter Lieven
Some ancient Linux kernels read from registers 0x09 and 0x3c-3f during boot. According to the spec these registers are for diag and debug purposes only. If they are absend qemu aborts on read. Signed-off-by: Peter Lieven --- hw/scsi/lsi53c895a.c |6 ++ 1 file changed, 6 insertions(+) di

Re: [Qemu-devel] [PULL 00/26] Block patches

2015-01-12 Thread Fam Zheng
On Sat, 01/10 19:10, Peter Maydell wrote: > On 10 January 2015 at 19:05, Peter Maydell wrote: > > On 9 January 2015 at 10:16, Stefan Hajnoczi wrote: > >> This pull request depends on the previous block pull request which has not > >> been > >> merged yet. It was sent on Monday, 5th of January (

[Qemu-devel] [PULL v3 1/7] s390x/ccw: fix oddity in machine class init

2015-01-12 Thread Cornelia Huck
ccw_machine_class_init() uses ',' instead of ';' while initializing the class' fields. This is almost certainly a copy/paste error and, while legal C, rather on the unusual side. Just use ';' everywhere. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-o

[Qemu-devel] [PULL v3 3/7] s390x/kvm: sync register support helper function

2015-01-12 Thread Cornelia Huck
From: David Hildenbrand Let's unify the code to sync registers by moving the checks into a helper function can_sync_regs(). Signed-off-by: David Hildenbrand Signed-off-by: Jens Freimann Reviewed-by: Cornelia Huck Signed-off-by: Cornelia Huck --- target-s390x/kvm.c | 22 ---

[Qemu-devel] [PULL v3 0/7] s390x patches for 2.3

2015-01-12 Thread Cornelia Huck
aging (2015-01-10 22:29:09 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20150112-v3 for you to fetch changes up to 9e03a0405d56b4af8952b794d0e5dd9206ee7329: kvm: extend kvm_irqchip_add_msi_route to work on s390 (2015-0

[Qemu-devel] [PULL v3 2/7] s390x/css: Clean up unnecessary CONFIG_USER_ONLY wrappers

2015-01-12 Thread Cornelia Huck
From: Thomas Huth The css functions are only used from ioinst.c and other files that are only built for CONFIG_SOFTMMU. So we do not need the dummy wrappers for the CONFIG_USER_ONLY target in the cpu.h header. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: Jason J. Herne

[Qemu-devel] [PULL v3 5/7] s390: Add PCI bus support

2015-01-12 Thread Cornelia Huck
From: Frank Blaschka This patch implements a pci bus for s390x together with infrastructure to generate and handle hotplug events, to configure/unconfigure via sclp instruction, to do iommu translations and provide s390 support for MSI/MSI-X notification processing. Signed-off-by: Frank Blaschka

[Qemu-devel] [PULL v3 4/7] s390x/kvm: avoid syscalls by syncing registers with kvm_run

2015-01-12 Thread Cornelia Huck
From: David Hildenbrand We can avoid loads of syscalls when dropping to user space by storing the values of more registers directly within kvm_run. Support is added for: - ARCH0: CPU timer, clock comparator, TOD programmable register, guest breaking-event register, program parameter - P

Re: [Qemu-devel] [PULL 00/10] Linked list for tcg ops

2015-01-12 Thread Peter Maydell
On 9 January 2015 at 21:23, Richard Henderson wrote: > Finally revisiting these since early November. Thanks to > Bastian Koppelmann for reviewing most of these. This seems to break ppc linux-user: /home/petmay01/linaro/qemu-for-merges/build/all-linux-static/ppc-linux-user/qemu-ppc -L ./gnemul/

[Qemu-devel] [PULL v3 6/7] s390: implement pci instructions

2015-01-12 Thread Cornelia Huck
From: Frank Blaschka This patch implements the s390 pci instructions in qemu. It allows to access and drive pci devices attached to the s390 pci bus. Because of platform constrains devices using IO BARs are not supported. Also a device has to support MSI/MSI-X to run on s390. Signed-off-by: Fran

[Qemu-devel] [PULL v3 7/7] kvm: extend kvm_irqchip_add_msi_route to work on s390

2015-01-12 Thread Cornelia Huck
From: Frank Blaschka on s390 MSI-X irqs are presented as thin or adapter interrupts for this we have to reorganize the routing entry to contain valid information for the adapter interrupt code on s390. To minimize impact on existing code we introduce an architecture function to fixup the routing

Re: [Qemu-devel] [PULL 00/10] Linked list for tcg ops

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 10:06, Peter Maydell wrote: > On 9 January 2015 at 21:23, Richard Henderson wrote: >> Finally revisiting these since early November. Thanks to >> Bastian Koppelmann for reviewing most of these. > > This seems to break ppc linux-user: NB: I had to resolve what looked like s

Re: [Qemu-devel] [PATCH] vl.c: fix regression when reading memory size from config file

2015-01-12 Thread Paolo Bonzini
On 11/01/2015 11:38, Marcel Apfelbaum wrote: > This is happening because an actual logic is performed on the memory > arguments inside the main's switch, disregarding the config file content. > > Solved by extracting the logic on a separate function and calling it > after the switch. > > Signed

Re: [Qemu-devel] [PATCH] hw/scsi/lsi53c895a: add support for additional diag / debug registers

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 10:45, Peter Lieven wrote: > Some ancient Linux kernels read from registers 0x09 and 0x3c-3f during > boot. According to the spec these registers are for diag and debug > purposes only. If they are absend qemu aborts on read. > > Signed-off-by: Peter Lieven > --- > hw/scsi/lsi53c

Re: [Qemu-devel] [PATCH v2 2/2] e1000: decrement RDT if equal to RDH

2015-01-12 Thread Michael S. Tsirkin
On Thu, Dec 18, 2014 at 12:01:48AM -0500, Jason Wang wrote: > > > - Original Message - > > Some drivers set RDT=RDH. Oddly, this works on real hardware. To work > > around this, autodecrement RDT when this happens. > > > > Signed-off-by: Richard Tollerton > > Signed-off-by: Jeff Westfah

Re: [Qemu-devel] [PATCH 2/3] configure: Default to enable module build

2015-01-12 Thread Andreas Färber
Am 12.01.2015 um 05:43 schrieb Fam Zheng: > We have module build support around for a while, but also had it bitrot > several times. It probably makes sense to enable it by default so that > people can notice and use it. > > Counterpart to --enable-modules, which is turned as default, > --disable-

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Marcel Apfelbaum
On 12/16/2014 01:23 PM, Amit Shah wrote: PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM functions. Add such properties to the ICH9 chipset as well for the Q35 machine type. S3 / S4 are not guaranteed to always work (needs work in the guest as well as QEMU for things to w

[Qemu-devel] [PULL 3/4] hw/net/xen_nic.c: Need free 'netdev->nic' in net_free() instead of net_disconnect()

2015-01-12 Thread Stefan Hajnoczi
From: Chen Gang net_init() and net_free() are pairs, net_connect() and net_disconnect() are pairs. net_init() creates 'netdev->nic', so also need free it in net_free(). Signed-off-by: Chen Gang Signed-off-by: Stefan Hajnoczi --- hw/net/xen_nic.c | 8 1 file changed, 4 insertions(+),

[Qemu-devel] [PULL 0/4] Net patches

2015-01-12 Thread Stefan Hajnoczi
The following changes since commit 64ea8038ffbf703dcd438a108d2d5499c8ff95d9: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150109.0' into staging (2015-01-10 22:29:09 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request

[Qemu-devel] [PULL 4/4] hw/net/xen_nic.c: Set 'netdev->mac' to NULL after free it

2015-01-12 Thread Stefan Hajnoczi
From: Chen Gang Since net_init() checks whether 'netdev->mac' is NULL, before alloc it; net_release() also need set 'netdev->mac' to NULL after free it. Signed-off-by: Chen Gang Signed-off-by: Stefan Hajnoczi --- hw/net/xen_nic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/xen_

[Qemu-devel] [PULL 1/4] net: remove all cleanup methods from NIC NetClientInfos

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini All NICs have a cleanup function that, in most cases, zeroes the pointer to the NICState. In some cases, it frees data belonging to the NIC. However, this function is never called except when exiting from QEMU. It is not necessary to NULL pointers and free data here; the rig

[Qemu-devel] [PULL 2/4] hw/net/xen_nic.c: Free 'netdev->txs' when map 'netdev->rxs' fails

2015-01-12 Thread Stefan Hajnoczi
From: Chen Gang When map 'netdev->rxs' fails, need free the original resource, or will cause resource leak. Signed-off-by: Chen Gang Signed-off-by: Stefan Hajnoczi --- hw/net/xen_nic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.

Re: [Qemu-devel] [PATCH 0/3] buildsys: Fix and enable module build

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 05:43, Fam Zheng wrote: > The first patch fixes the module build: it doesn't fail but it links all the > module objects into executables. > > The second patch enables modules by default. > > The last patch adds a non-module build in travis config. > > > Fam Zheng (3): > rules.

Re: [Qemu-devel] [PULL 00/26] Block patches

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 10:52, Fam Zheng wrote: > On Sat, 01/10 19:10, Peter Maydell wrote: >> On 10 January 2015 at 19:05, Peter Maydell wrote: >>> On 9 January 2015 at 10:16, Stefan Hajnoczi wrote: This pull request depends on the previous block pull request which has not been merged ye

[Qemu-devel] [PATCH] scsi: fix cancellation when I/O was completed but DMA was not.

2015-01-12 Thread Paolo Bonzini
Commit d577646 (scsi: Introduce scsi_req_cancel_complete, 2014-09-25) was supposed to have no semantic change, but it missed a case. When r->aiocb has already been NULLed, but DMA was not complete and the SCSI layer was waiting for scsi_req_continue, after the patch the SCSI layer will not call th

[Qemu-devel] Setting up an OVF environment in qemu

2015-01-12 Thread Peter Lieven
Hi, has anyone ever successfully set up an OVF environment in qemu? As far as I understand one way is to present a special XML file on a virtual CDROM to pass parameters to the vServer. If anyone has additional info or done this before I would be grateful for additional background info. Thanks

Re: [Qemu-devel] [PATCH v4] block: add event when disk usage exceeds threshold

2015-01-12 Thread Francesco Romani
Hi, thanks for the review! - Original Message - > From: "Eric Blake" > To: "Francesco Romani" , qemu-devel@nongnu.org > Cc: kw...@redhat.com, mdr...@linux.vnet.ibm.com, stefa...@redhat.com, > lcapitul...@redhat.com > Sent: Friday, January 9, 2015 5:54:40 PM > Subject: Re: [Qemu-devel] [

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Amit Shah
On (Mon) 12 Jan 2015 [12:26:08], Marcel Apfelbaum wrote: > On 12/16/2014 01:23 PM, Amit Shah wrote: > >PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM > >functions. Add such properties to the ICH9 chipset as well for the Q35 > >machine type. > > > >S3 / S4 are not guaranteed

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Michael S. Tsirkin
On Mon, Jan 12, 2015 at 04:25:01PM +0530, Amit Shah wrote: > On (Mon) 12 Jan 2015 [12:26:08], Marcel Apfelbaum wrote: > > On 12/16/2014 01:23 PM, Amit Shah wrote: > > >PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM > > >functions. Add such properties to the ICH9 chipset as

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Amit Shah
On (Mon) 12 Jan 2015 [13:01:28], Michael S. Tsirkin wrote: > On Mon, Jan 12, 2015 at 04:25:01PM +0530, Amit Shah wrote: > > On (Mon) 12 Jan 2015 [12:26:08], Marcel Apfelbaum wrote: > > > On 12/16/2014 01:23 PM, Amit Shah wrote: > > > >PIIX4 has disable_s3 and disable_s4 properties to enable or disa

Re: [Qemu-devel] [PULL v3 0/7] s390x patches for 2.3

2015-01-12 Thread Peter Maydell
ote-tracking branch 'remotes/awilliam/tags/vfio-update-20150109.0' > into staging (2015-01-10 22:29:09 +) > > are available in the git repository at: > > > git://github.com/cohuck/qemu tags/s390x-20150112-v3 > > for you to fetch changes up

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Michael S. Tsirkin
On Mon, Jan 12, 2015 at 04:41:03PM +0530, Amit Shah wrote: > On (Mon) 12 Jan 2015 [13:01:28], Michael S. Tsirkin wrote: > > On Mon, Jan 12, 2015 at 04:25:01PM +0530, Amit Shah wrote: > > > On (Mon) 12 Jan 2015 [12:26:08], Marcel Apfelbaum wrote: > > > > On 12/16/2014 01:23 PM, Amit Shah wrote: > >

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2015-01-12 Thread Stefano Stabellini
On Wed, 3 Dec 2014, Don Slutz wrote: > From: Stefano Stabellini > > Increase maxmem before calling xc_domain_populate_physmap_exact to > avoid the risk of running out of guest memory. This way we can also > avoid complex memory calculations in libxl at domain construction > time. > > This patch

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Amit Shah
On (Mon) 12 Jan 2015 [13:16:46], Michael S. Tsirkin wrote: > On Mon, Jan 12, 2015 at 04:41:03PM +0530, Amit Shah wrote: > > On (Mon) 12 Jan 2015 [13:01:28], Michael S. Tsirkin wrote: > > > On Mon, Jan 12, 2015 at 04:25:01PM +0530, Amit Shah wrote: > > > > On (Mon) 12 Jan 2015 [12:26:08], Marcel Apf

Re: [Qemu-devel] [PATCH] xen-pt: Fix PCI devices re-attach failed

2015-01-12 Thread Stefano Stabellini
On Wed, 24 Dec 2014, Liang Li wrote: > Use the 'xl pci-attach $DomU $BDF' command to attach more then > one PCI devices to the guest, then detach the devices with > 'xl pci-detach $DomU $BDF', after that, re-attach these PCI > devices again, an error message will be reported like following: > > li

Re: [Qemu-devel] [PATCH v3 3/9] rocker: add register programming guide

2015-01-12 Thread Paolo Bonzini
On 11/01/2015 04:57, sfel...@gmail.com wrote: > From: Scott Feldman > > This is the register programming guide for the Rocker device. It's intended > for driver writers and device writers. It covers the device's PCI space, > the register set, DMA interface, and interrupts. > > Signed-off-by:

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-12 Thread Gerhard Wiesinger
On 08.01.2015 23:28, Gerhard Wiesinger wrote: On 08.01.2015 19:22, Paolo Bonzini wrote: Indeed. Can you try the 2.2.0 qemu-kvm release, available in the fedora-virt-preview repository? http://fedoraproject.org/wiki/Virtualization_Preview_Repository Updated to 2.2.0 qemu-kvm release, worked

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 12:41, Gerhard Wiesinger wrote: >> >> Updated to 2.2.0 qemu-kvm release, worked seemless so far for all VMs. >> >> I'll keep you up to date in the next days whether it happens again or >> not. > > With qemu-kvm 2.2.0 release from the above repository the 100% usage > didn't happen

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Marcel Apfelbaum
On 01/12/2015 12:55 PM, Amit Shah wrote: On (Mon) 12 Jan 2015 [12:26:08], Marcel Apfelbaum wrote: On 12/16/2014 01:23 PM, Amit Shah wrote: PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM functions. Add such properties to the ICH9 chipset as well for the Q35 machine type.

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-12 Thread Gerhard Wiesinger
On 12.01.2015 12:46, Paolo Bonzini wrote: On 12/01/2015 12:41, Gerhard Wiesinger wrote: Updated to 2.2.0 qemu-kvm release, worked seemless so far for all VMs. I'll keep you up to date in the next days whether it happens again or not. With qemu-kvm 2.2.0 release from the above repository the 1

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 12:53, Gerhard Wiesinger wrote: >>> >> That's difficult without bisection pointing out where the bugs were >> fixed. 2.1.3 is scheduled real soon now and it will be the last release >> from the 2.1.x branch. > > So no security updates planned for 2.1.x afterwards? Distros usually

[Qemu-devel] [RFC PATCH v7 00/21] Deterministic replay core

2015-01-12 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution This implementation of deterministic replay can be used for deterministic debugging of guest code through gdb remote interface. These patches include only core function of the replay, excluding th

[Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-12 Thread Pavel Dovgalyuk
This patch adds global variables, defines, functions declarations, and function stubs for deterministic VM replay used by external modules. Signed-off-by: Pavel Dovgalyuk --- Makefile.target |1 + qapi-schema.json | 32 replay/Makefile.objs |1

[Qemu-devel] [RFC PATCH v7 05/21] replay: introduce icount event

2015-01-12 Thread Pavel Dovgalyuk
This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 14 ++ replay/replay-internal.h | 18 +

[Qemu-devel] [RFC PATCH v7 08/21] replay: interrupts and exceptions

2015-01-12 Thread Pavel Dovgalyuk
This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [RFC PATCH v7 01/21] i386: partial revert of interrupt poll fix

2015-01-12 Thread Pavel Dovgalyuk
Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c|6 ++ target-i386/cpu.c | 10 ++--

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Amit Shah
On (Mon) 12 Jan 2015 [13:51:00], Marcel Apfelbaum wrote: > On 01/12/2015 12:55 PM, Amit Shah wrote: > >On (Mon) 12 Jan 2015 [12:26:08], Marcel Apfelbaum wrote: > >>On 12/16/2014 01:23 PM, Amit Shah wrote: > >>>PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM > >>>functions. A

[Qemu-devel] [RFC PATCH v7 07/21] cpu: replay instructions sequence

2015-01-12 Thread Pavel Dovgalyuk
This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c |1 + cpus.c

[Qemu-devel] [RFC PATCH v7 10/21] cpus: make icount warp deterministic in replay mode

2015-01-12 Thread Pavel Dovgalyuk
This patch fixes icount warp rt timer. It should be based on virtual_rt clock to be deterministic. Signed-off-by: Pavel Dovgalyuk --- cpus.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index 0c368f2..8787277 100644 --- a/cpus.c +++ b/cpus.c @@ -325,7

[Qemu-devel] [PATCH v2 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Amit Shah
PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM functions. Add such properties to the ICH9 chipset as well for the Q35 machine type. S3 / S4 are not guaranteed to always work (needs work in the guest as well as QEMU for things to work properly), and disabling advertising of

[Qemu-devel] [RFC PATCH v7 03/21] sysemu: system functions for replay

2015-01-12 Thread Pavel Dovgalyuk
This patch removes "static" specifier from several qemu function to make them visible to the replay module. It also invents several system functions that will be used by replay. Signed-off-by: Pavel Dovgalyuk --- cpus.c |4 ++-- include/exec/exec-all.h |1 + include/qom/

[Qemu-devel] [RFC PATCH v7 09/21] replay: asynchronous events infrastructure

2015-01-12 Thread Pavel Dovgalyuk
This patch adds module for saving and replaying asynchronous events. These events include network packets, keyboard and mouse input, USB packets, thread pool and bottom halves callbacks. All events are stored in the queue to be processed at synchronization points such as beginning of TB execution,

[Qemu-devel] [RFC PATCH v7 14/21] replay: shutdown event

2015-01-12 Thread Pavel Dovgalyuk
This patch records and replays simulator shutdown event. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/sysemu.h |1 + replay/replay-internal.h |2 ++ replay/replay.c | 11 +++ replay/replay.h |5 + vl.c |8 +++- 5 files

[Qemu-devel] [RFC PATCH v7 04/21] replay: internal functions for replay log

2015-01-12 Thread Pavel Dovgalyuk
This patch adds functions to perform read and write operations with replay log. Signed-off-by: Pavel Dovgalyuk --- replay/Makefile.objs |1 replay/replay-internal.c | 141 ++ replay/replay-internal.h | 50 3 files changed,

[Qemu-devel] [RFC PATCH v7 16/21] replay: bottom halves

2015-01-12 Thread Pavel Dovgalyuk
This patch introduces bottom half event for replay queue. It saves the events into the queue and process them at the checkpoints and instructions execution. Signed-off-by: Pavel Dovgalyuk --- async.c | 46 -- dma-helpers.c

[Qemu-devel] [RFC PATCH v7 11/21] timer: fix usage of clock functions

2015-01-12 Thread Pavel Dovgalyuk
This patch replaces calling of get_clock_realtime() everywhere except the timer module. All calls are replaced with host clock requests. Patch also replaces get_clock() calls with realtime clock requests. Usage of this interface simplifies implementation of record/replay. Signed-off-by: Pavel Dovg

[Qemu-devel] [RFC PATCH v7 13/21] replay: recording and replaying different timers

2015-01-12 Thread Pavel Dovgalyuk
This patch introduces functions for recording and replaying realtime sources, that do not use qemu-clock interface. These include return value of time() function in time_t and struct tm forms. Patch also adds warning to get_timedate function to prevent its usage in recording mode, because it may le

[Qemu-devel] [RFC PATCH v7 06/21] cpu-exec: allow temporary disabling icount

2015-01-12 Thread Pavel Dovgalyuk
This patch is required for deterministic replay to generate an exception by trying executing an instruction without changing icount. It adds new flag to TB for disabling icount while translating it. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c |7

[Qemu-devel] [RFC PATCH v7 17/21] replay: replay aio requests

2015-01-12 Thread Pavel Dovgalyuk
This patch adds identifier to aio requests. ID is used for creating bottom halves and identifying them while replaying. The patch also introduces several functions that make possible replaying of the aio requests. Signed-off-by: Pavel Dovgalyuk --- block.c| 81 +

[Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-12 Thread Pavel Dovgalyuk
This patch introduces checkpoints that synchronize cpu thread and iothread. When checkpoint is met in the code all asynchronous events from the queue are executed. Signed-off-by: Pavel Dovgalyuk --- block.c | 11 +++ cpus.c |7 ++- include/qem

Re: [Qemu-devel] [RFC PATCH v7 10/21] cpus: make icount warp deterministic in replay mode

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:00, Pavel Dovgalyuk wrote: > This patch fixes icount warp rt timer. It should be based on virtual_rt > clock to be deterministic. > > Signed-off-by: Pavel Dovgalyuk > --- > cpus.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/cpus.c b/cpus.c >

[Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks

2015-01-12 Thread Pavel Dovgalyuk
Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock, rdtsc, and some other timers). When replaying the execution corresponding values are read from log and transfered to th

[Qemu-devel] [RFC PATCH v7 20/21] replay: command line options

2015-01-12 Thread Pavel Dovgalyuk
This patch introduces command line options for enabling recording or replaying virtual machine behavior. "-record" option starts recording of the execution and saves it into the log, specified with "fname" parameter. "-replay" option is intended for replaying previously saved log. Signed-off-by: P

[Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user input

2015-01-12 Thread Pavel Dovgalyuk
This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 48 replay/replay-input.c

[Qemu-devel] [RFC PATCH v7 18/21] replay: thread pool

2015-01-12 Thread Pavel Dovgalyuk
This patch modifies thread pool to allow replaying asynchronous thread tasks synchronously in replay mode. Signed-off-by: Pavel Dovgalyuk --- block/raw-posix.c |6 - block/raw-win32.c |4 +++- include/block/thread-pool.h |4 +++- replay/replay-events.c |

Re: [Qemu-devel] [RFC PATCH v7 11/21] timer: fix usage of clock functions

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:00, Pavel Dovgalyuk wrote: > This patch replaces calling of get_clock_realtime() everywhere > except the timer module. All calls are replaced with host clock requests. > Patch also replaces get_clock() calls with realtime clock requests. > Usage of this interface simplifies imple

[Qemu-devel] [RFC PATCH v7 19/21] replay: initialization and deinitialization

2015-01-12 Thread Pavel Dovgalyuk
This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Signed-off-by: Pavel Dovgalyuk --- block.c |2 - exec.c |1 replay/replay-internal.h |2 + replay/replay.c | 134 +

Re: [Qemu-devel] [PULL 0/4] Net patches

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 10:27, Stefan Hajnoczi wrote: > The following changes since commit 64ea8038ffbf703dcd438a108d2d5499c8ff95d9: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150109.0' > into staging (2015-01-10 22:29:09 +) > > are available in the git repository a

Re: [Qemu-devel] [RFC PATCH v7 14/21] replay: shutdown event

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > +void qemu_system_shutdown_request_impl(void) > { > trace_qemu_system_shutdown_request(); > shutdown_requested = 1; > qemu_notify_event(); > } > > +void qemu_system_shutdown_request(void) > +{ > +replay_shutdown_request(); > +

Re: [Qemu-devel] [RFC PATCH v7 13/21] replay: recording and replaying different timers

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > +if (replay_mode == REPLAY_MODE_RECORD) { > +qemu_get_timedate_no_warning(&tm, 0); > +replay_save_tm(&tm); > +} else if (replay_mode == REPLAY_MODE_PLAY) { > +replay_read_tm(&tm); > +} else { > +qemu_get_tim

Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:00, Pavel Dovgalyuk wrote: > +/*! Reads next clock event from the input. */ > +int64_t replay_read_clock(unsigned int kind) > +{ > +if (kind >= REPLAY_CLOCK_COUNT) { > +fprintf(stderr, "invalid clock ID %d for replay\n", kind); > +exit(1); > +} > + > +

Re: [Qemu-devel] [PATCH v2 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-12 Thread Marcel Apfelbaum
On 01/12/2015 02:00 PM, Amit Shah wrote: PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM functions. Add such properties to the ICH9 chipset as well for the Q35 machine type. S3 / S4 are not guaranteed to always work (needs work in the guest as well as QEMU for things to w

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > +default: > +case QEMU_CLOCK_VIRTUAL: > +if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running()) > +|| !replay_checkpoint(run_all ? 2 : 3)) { > +return false; > +} > +break; Please docum

Re: [Qemu-devel] [RFC PATCH v7 16/21] replay: bottom halves

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > -bh->next = ctx->first_bh; > -/* Make sure that the members are ready before putting bh into list */ > -smp_wmb(); > -ctx->first_bh = bh; > +if (replay_mode != REPLAY_MODE_NONE) { > +/* Slower way, but this is a queue and n

Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 12:59, Pavel Dovgalyuk wrote: > +## > +# ReplaySubmode: > +# > +# Submode of the replay subsystem. > +# > +# @unknown: used for modes different from play. > +# > +# @normal: normal replay mode. > +# > +# Since: 2.3 > +## > +{ 'enum': 'ReplaySubmode', > + 'data': [ 'unknown', 'norma

Re: [Qemu-devel] [RFC PATCH v7 09/21] replay: asynchronous events infrastructure

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:00, Pavel Dovgalyuk wrote: > +void replay_flush_events(void) > +{ > +qemu_mutex_lock(&lock); > +while (!QTAILQ_EMPTY(&events_list)) { > +Event *event = QTAILQ_FIRST(&events_list); > +replay_run_event(event); > +QTAILQ_REMOVE(&events_list, event, ev

Re: [Qemu-devel] [RFC PATCH v7 20/21] replay: command line options

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > This patch introduces command line options for enabling recording or replaying > virtual machine behavior. "-record" option starts recording of the execution > and saves it into the log, specified with "fname" parameter. "-replay" option > is intended

Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 12/01/2015 12:59, Pavel Dovgalyuk wrote: > > +## > > +# ReplaySubmode: > > +# > > +# Submode of the replay subsystem. > > +# > > +# @unknown: used for modes different from play. > > +# > > +# @normal: normal replay mode. > > +# > > +# Since: 2

Re: [Qemu-devel] [RFC PATCH v7 20/21] replay: command line options

2015-01-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > > This patch introduces command line options for enabling recording or > > replaying > > virtual machine behavior. "-record" option starts recording of the execution > > and saves it into the log, sp

Re: [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user input

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > +void qemu_input_event_send(QemuConsole *src, InputEvent *evt) > { > -QemuInputHandlerState *s; > - > if (!runstate_is_running() && !runstate_check(RUN_STATE_SUSPENDED)) { > return; > } > > +if (replay_mode == REPLAY_MODE

  1   2   3   4   >