Re: [Qemu-devel] [RFC v2 3/4] hw/pci-host: Add a generic PCI host controller for virtual platforms

2015-01-06 Thread alvise rigo
Hi, On Mon, Jan 5, 2015 at 6:13 PM, Alexander Graf wrote: > > > On 21.11.14 19:07, Alvise Rigo wrote: >> Add a generic PCI host controller for virtual platforms, based on the >> previous work by Rob Herring: >> http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg03482.html >> >> The controlle

Re: [Qemu-devel] [PATCH] vl.c: fix -usb option assertion failure in qemu_opt_get_bool_helper()

2015-01-06 Thread Chen, Tiejun
On 2015/1/6 14:20, Shannon Zhao wrote: On 2015/1/6 10:37, Chen, Tiejun wrote: On 2015/1/5 20:14, Marcel Apfelbaum wrote: On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote: On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka wrote: On 2015-01-05 12:22, Stefan Hajnoczi wrote: Commit 49d2e648e8087d154d8bf

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-06 Thread Eric Auger
On 01/05/2015 05:14 PM, alvise rigo wrote: > Hi, > > On Mon, Jan 5, 2015 at 4:36 PM, Peter Maydell > wrote: >> On 24 November 2014 at 11:47, Claudio Fontana >> wrote: >>> On 21.11.2014 19:07, Alvise Rigo wrote: Keep a global list with all the functions that need to modify the device t

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-06 Thread alvise rigo
Hi Eric, You are right. In fact, I've also spent some time to see if it was possible to use the code you mentioned. However, it's not needed anymore: the node generation will happen at machine init for the reasons discussed in this thread. Regards, alvise On Tue, Jan 6, 2015 at 10:18 AM, Eric Au

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 00:22, Programmingkid wrote: > http://virtuallyfun.superglobalmegacorp.com/?p=3197 > This is how Mac OS X looks like in QEMU with a Mac OS X host. The colors are > all wrong. Right, so that says there is a bug somewhere. But this patch isn't fixing a bug, it's adding a comma

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 09:18, Eric Auger wrote: > Besides the PCI aspects, the dt generation problem that is addressed > here is identical to the one related to VFIO platform device dt node > generation that also needs to happen after machine init. Right, for VFIO we need it; but for PCI we don't,

Re: [Qemu-devel] [PATCH v2 01/10] pci: move REDHAT_SDHCI device ID to make room for Rocker

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 02:24, wrote: > From: Scott Feldman > > The rocker device uses same PCI device ID as sdhci. Since rocker device > driver > has already been accepted into Linux 3.18, and REDHAT_SDHCI device ID isn't > used by any drivers, it's safe to move REDHAT_SDHCI device ID, avoiding

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-06 Thread alvise rigo
Thank you. I will keep this in mind for the next spin of the patches. Regards, alvise On Mon, Jan 5, 2015 at 7:07 PM, Peter Maydell wrote: > On 5 January 2015 at 17:35, alvise rigo wrote: >> So I suppose we need to define a fixed number of PCI slots according >> to the number of interrupts avai

Re: [Qemu-devel] [RFC PATCH v3 2/3] hw/arm/virt: Don't add memory node in creat_fdt

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 05:57, Shannon Zhao wrote: > To support memory NUMA, don't add memory node in creat_fdt. > But add it in a new function which takes into accout NUMA > topology. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-

Re: [Qemu-devel] [RFC PATCH v3 3/3] hw/arm/boot: Generate memory dtb according to NUMA topology

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 05:57, Shannon Zhao wrote: > Add a new function arm_generate_memory_dtb which is used to > generate memory dtb according to NUMA topology and set the > NUMA topology property of every cpu. > > Signed-off-by: Shannon Zhao This looks a lot nicer than the previous patchset. It

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 09:47, Peter Maydell wrote: > Yes, but it's basically making the user manually toggle a > setting which we should be getting right ourselves. We > should find out what QEMU's actually not doing correctly > and fix that. First step to find out what's happening: which of the fo

Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

2015-01-06 Thread Eric Auger
On 01/06/2015 10:51 AM, Peter Maydell wrote: > On 6 January 2015 at 09:18, Eric Auger wrote: >> Besides the PCI aspects, the dt generation problem that is addressed >> here is identical to the one related to VFIO platform device dt node >> generation that also needs to happen after machine init. >

Re: [Qemu-devel] [RFC PATCH v3 2/3] hw/arm/virt: Don't add memory node in creat_fdt

2015-01-06 Thread Shannon Zhao
On 2015/1/6 17:55, Peter Maydell wrote: > On 6 January 2015 at 05:57, Shannon Zhao wrote: >> To support memory NUMA, don't add memory node in creat_fdt. >> But add it in a new function which takes into accout NUMA >> topology. >> >> Signed-off-by: Shannon Zhao >> --- >> hw/arm/virt.c |2 -- >

Re: [Qemu-devel] [RFC PATCH v3 3/3] hw/arm/boot: Generate memory dtb according to NUMA topology

2015-01-06 Thread Shannon Zhao
On 2015/1/6 17:58, Peter Maydell wrote: > On 6 January 2015 at 05:57, Shannon Zhao wrote: >> Add a new function arm_generate_memory_dtb which is used to >> generate memory dtb according to NUMA topology and set the >> NUMA topology property of every cpu. >> >> Signed-off-by: Shannon Zhao > > Thi

Re: [Qemu-devel] [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1

2015-01-06 Thread Lokesha, Amulya
Comments inline -Original Message- From: Jeff Cody [mailto:jc...@redhat.com] Sent: Tuesday, December 23, 2014 7:33 PM To: Lokesha, Amulya Cc: Max Reitz; qemu-devel@nongnu.org; kw...@redhat.com; stefa...@redhat.com Subject: Re: [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has

Re: [Qemu-devel] [PULL 09/10] monitor: add query-vnc2 command

2015-01-06 Thread Gerd Hoffmann
> > Add new query vnc qmp command, for the lack of better ideas just name it > > "query-vnc2". Changes over query-vnc: > Call it query-vnc-servers? Fine with me, done. > Maybe just VncPrimaryAuth, since there's precedence for abbreviating > authentication that way. Done. > > ## > > +# @quer

Re: [Qemu-devel] [PULL 09/10] monitor: add query-vnc2 command

2015-01-06 Thread Gerd Hoffmann
Hi, > > If the schema let us specify the enumeration values, we could avoid the > > mapping altogether. > > Ooh, cool thought: what if we allowed: > > { 'enum': 'Foo', 'data': [ > { 'name': 'One', 'value': 1 }, > { 'name': 'Two', 'value': 2 } ] } Looks nice. Where is the patch? cheers,

Re: [Qemu-devel] [Xen-devel] bind interdomain ioctl error xen-kvm.c

2015-01-06 Thread Ian Campbell
On Mon, 2015-01-05 at 11:10 -0800, Rishi Ranjan wrote: > Hi Stefano, > Please find my answers inline. > > > However Anthony (CC'ed) should have some patches for it. > > Anthony, can you please share any patch that can help me with this? > > > > > Can you post the

Re: [Qemu-devel] bind interdomain ioctl error xen-kvm.c

2015-01-06 Thread Anthony PERARD
On Mon, Jan 05, 2015 at 11:10:34AM -0800, Rishi Ranjan wrote: > However Anthony (CC'ed) should have some patches for it. > Anthony, can you please share any patch that can help me with this? Hi, The "patches" are in two repos: git://xenbits.xen.org/people/aperard/xen-unstable.git branch: mac

Re: [Qemu-devel] [RFC v2 3/4] hw/pci-host: Add a generic PCI host controller for virtual platforms

2015-01-06 Thread Alexander Graf
On 06.01.15 09:47, alvise rigo wrote: > Hi, > > On Mon, Jan 5, 2015 at 6:13 PM, Alexander Graf wrote: >> >> >> On 21.11.14 19:07, Alvise Rigo wrote: >>> Add a generic PCI host controller for virtual platforms, based on the >>> previous work by Rob Herring: >>> http://lists.gnu.org/archive/html/

Re: [Qemu-devel] bind interdomain ioctl error xen-kvm.c

2015-01-06 Thread Anthony PERARD
On Tue, Jan 06, 2015 at 11:11:48AM +, Anthony PERARD wrote: > On Mon, Jan 05, 2015 at 11:10:34AM -0800, Rishi Ranjan wrote: > > However Anthony (CC'ed) should have some patches for it. > > Anthony, can you please share any patch that can help me with this? > > Hi, > > The "patches" are i

Re: [Qemu-devel] [PATCH v2] libqos: Convert malloc-pc allocator to a generic allocator

2015-01-06 Thread Stefan Hajnoczi
On Thu, Oct 23, 2014 at 10:12:42AM +0200, Marc MarĂ­ wrote: > The allocator in malloc-pc has been extracted, so it can be used in every > arch. > This operation showed that both the alloc and free functions can be also > generic. > Because of this, the QGuestAllocator has been removed from is funct

Re: [Qemu-devel] [PATCH v3 0/5] libqos: Virtio MMIO driver

2015-01-06 Thread Stefan Hajnoczi
On Wed, Dec 03, 2014 at 10:31:32AM +0100, Marc MarĂ­ wrote: > Add virtio-mmio support to libqos and test case for virtio-blk. > > This series depends on patch "libqos: Convert malloc-pc allocator to a > generic > allocator" > > Changes from version 2: > - Fix leaks and minor bugs > - Extract b

Re: [Qemu-devel] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 05:12:10PM +0400, Andrey Korolyov wrote: > On Fri, Jan 2, 2015 at 4:04 PM, Stefan Hajnoczi wrote: > > On Thu, Dec 18, 2014 at 07:38:59PM +0400, Andrey Korolyov wrote: > >> 2.1-stable is currently crashing with the > >> > >> Co-routine re-entered recursively > >> 2014-12-16

Re: [Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 05:11:50PM -, timsoft wrote: > have used wireshark on host and nothing is coming through when I try to ping > the host from the client. (bare with me as I haven't used wireshark before). > I'm just upgrading the client to slack64 14.1 so I can get wireshark > running

Re: [Qemu-devel] 2.1 unexpected stop after exporting blockdev via nbd server

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 05:12:10PM +0400, Andrey Korolyov wrote: > On Fri, Jan 2, 2015 at 4:04 PM, Stefan Hajnoczi wrote: > > On Thu, Dec 18, 2014 at 07:38:59PM +0400, Andrey Korolyov wrote: > >> 2.1-stable is currently crashing with the > >> > >> Co-routine re-entered recursively > >> 2014-12-16

Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option

2015-01-06 Thread Stefan Hajnoczi
On Sun, Dec 21, 2014 at 07:17:42AM +, Roy Vardi wrote: > When using "-net tap" flag today, the tap interface is not released on > shutdown. This is the default behavior and I'm not breaking it. ... > . /qemu-system -net tap,ifname=tap0,script=no,downscript=no That is not the behavior that I o

Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos

2015-01-06 Thread Stefan Hajnoczi
On Fri, Jan 02, 2015 at 05:22:27PM +0100, Paolo Bonzini wrote: > > > On 02/01/2015 15:00, Stefan Hajnoczi wrote: > >>> This cleanup function gets in the way of making the > >>> NetClientStates for the NIC hold an object_ref reference to > >>> the object, so get rid of it. > > This patch does not

Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos

2015-01-06 Thread Stefan Hajnoczi
On Tue, Dec 23, 2014 at 05:53:19PM +0100, Paolo Bonzini wrote: > All NICs have a cleanup function that, in most cases, zeroes the pointer > to the NICState. In some cases, it frees data belonging to the NIC. > > However, this function is never called except when exiting from QEMU. > It is not nec

[Qemu-devel] [PATCH 3/6] hw/usb: simplified usb_enabled

2015-01-06 Thread Marcel Apfelbaum
The argument is not longer used and the implementation uses now QOM instead of QemuOpts. Signed-off-by: Marcel Apfelbaum --- hw/arm/nseries.c| 2 +- hw/arm/pxa2xx.c | 4 ++-- hw/arm/realview.c | 2 +- hw/arm/versatilepb.c| 2 +- hw/i386/pc_piix.c | 2 +- hw/i

[Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Marcel Apfelbaum
Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This resulted in a Qemu crash: $ qemu-system-x86_64 -usb qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helpe

[Qemu-devel] [PATCH 6/6] hw/ppc/mac_newworld: simplify usb controller creation logic

2015-01-06 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/ppc/mac_newworld.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index b54f94a..c377012 100644 --- a/hw/ppc/mac_newworld.c +++ b/hw/ppc/mac_newworld.c @@ -371,6 +371,7 @@ static void ppc

[Qemu-devel] [PATCH 2/6] hw/machine: added machine_usb wrapper

2015-01-06 Thread Marcel Apfelbaum
Following QOM convention, object properties should not be accessed directly. Signed-off-by: Marcel Apfelbaum --- hw/core/machine.c | 5 + include/hw/boards.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index a0ae5f9..fbd91be 100644 --- a/hw/

[Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines

2015-01-06 Thread Marcel Apfelbaum
Some ppc machines create a default usb controller based on a 'machine condition'. Until now the logic was: create the usb controller if: - the usb option was supplied in cli and value is true or - the usb option was absent and both set_defaults and the machine condition were true. Modifie

[Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-06 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/ppc/spapr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 72c3102..53c4116 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine)

[Qemu-devel] [PATCH 4/6] hw/ppc/mac_newworld: QOMified mac99 machines

2015-01-06 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum --- hw/ppc/mac_newworld.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index ed37d6b..b54f94a 100644 --- a/hw/ppc/mac_newworld.c +++ b/hw/ppc/mac_newworld.c @@ -502

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Marcel Apfelbaum
On 01/05/2015 11:21 AM, Gal Hammer wrote: The monitor's auto-completion feature stopped working when stdio is used as an input and qemu was resumed after it was suspended (using ctrl-z). Thanks Gal, it works now! Tested-by: Marcel Apfelbaum Signed-off-by: Gal Hammer --- qemu-char.c | 11

Re: [Qemu-devel] [PATCH 01/10] block/dmg: properly detect the UDIF trailer

2015-01-06 Thread Stefan Hajnoczi
On Sat, Dec 27, 2014 at 04:01:35PM +0100, Peter Wu wrote: > diff --git a/block/dmg.c b/block/dmg.c > index e455886..df274f9 100644 > --- a/block/dmg.c > +++ b/block/dmg.c > @@ -131,6 +131,39 @@ static void update_max_chunk_size(BDRVDMGState *s, > uint32_t chunk, > } > } > > +static int64_t

Re: [Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding functionality

2015-01-06 Thread Stefan Hajnoczi
On Sat, Dec 27, 2014 at 04:01:36PM +0100, Peter Wu wrote: > Extract the mish block decoder such that this can be used for other > formats in the future. A new DmgHeaderState struct is introduced to > share state while decoding. > > The code is kept unchanged as much as possible, a "fail" label is

[Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Catalin Vasile
Hi, I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if they

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Peter Maydell
On 5 January 2015 at 09:21, Gal Hammer wrote: > The monitor's auto-completion feature stopped working when stdio is used > as an input and qemu was resumed after it was suspended (using ctrl-z). > > Signed-off-by: Gal Hammer > --- > qemu-char.c | 11 +++ > 1 file changed, 11 insertions(+

[Qemu-devel] [Bug 491345] Re: remote migration fails with message "load of migration failed"

2015-01-06 Thread yogananth Subramanian
The bug can be closed since I do not have access to VM now to re-verify the issue. ** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/491345 Titl

[Qemu-devel] Sources and makefile system

2015-01-06 Thread Vasile Catalin-B50542
I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the src>Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if they

[Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Vasile Catalin-B50542
Hi, I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if

[Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Catalin Vasile
Hi, I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if they

[Qemu-devel] Custom machine configuration for QEMU

2015-01-06 Thread Radha Krishna Srimanthula
Hi, I am posting here after searching in vain for quite sometime. Hopefully I've reached the right forum, and hope that I'll get an answer to my questions. We have a board that has a multicore processor - an ARM9 core and a R4 core - and a few peripherals around. We run embedded linux on the ARM9

[Qemu-devel] Sources and makefile system

2015-01-06 Thread Vasile Catalin-B50542
I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the src>Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if they

[Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Vasile Catalin-B50542
Hi, I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the src>Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if

Re: [Qemu-devel] Custom machine configuration for QEMU

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 11:26, Radha Krishna Srimanthula wrote: > We have a board that has a multicore processor - an ARM9 core and a R4 core > - and a few peripherals around. We run embedded linux on the ARM9 core and a > realtime OS on the R4 core with a custom protocol providing for the > communic

Re: [Qemu-devel] [PATCH v4] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-06 Thread Stefan Hajnoczi
On Fri, Jan 02, 2015 at 04:44:38PM -0500, Programmingkid wrote: > Removes redundant ret variable and renames sectorSize variable to meet QEMU > coding standards. This is a changelog item for v4 of this patch. Changelogs should go below the '---' line so they are not merged into git history. Th

Re: [Qemu-devel] Custom machine configuration for QEMU

2015-01-06 Thread Radha Krishna Srimanthula
On Tue Jan 06 2015 at 19:30:02 Peter Maydell wrote: > On 6 January 2015 at 11:26, Radha Krishna Srimanthula > wrote: > > We have a board that has a multicore processor - an ARM9 core and a R4 > core > > - and a few peripherals around. We run embedded linux on the ARM9 core > and a > > realtime O

Re: [Qemu-devel] Custom machine configuration for QEMU

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 14:20, Radha Krishna Srimanthula wrote: > If it was a symmetric CPU cluster, how do I go about creating a machine > configuration? Any pointers please? Look at an existing board model (preferably one that has been recently added or maintained) and see what it does... -- PMM

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Gal Hammer
On 06/01/2015 15:49, Peter Maydell wrote: On 5 January 2015 at 09:21, Gal Hammer wrote: The monitor's auto-completion feature stopped working when stdio is used as an input and qemu was resumed after it was suspended (using ctrl-z). Signed-off-by: Gal Hammer --- qemu-char.c | 11 +++

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 14:30, Gal Hammer wrote: > On 06/01/2015 15:49, Peter Maydell wrote: >> >> On 5 January 2015 at 09:21, Gal Hammer wrote: >>> >>> The monitor's auto-completion feature stopped working when stdio is used >>> as an input and qemu was resumed after it was suspended (using ctrl-z)

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
On Jan 6, 2015, at 5:04 AM, Peter Maydell wrote: > On 6 January 2015 at 09:47, Peter Maydell wrote: >> Yes, but it's basically making the user manually toggle a >> setting which we should be getting right ourselves. We >> should find out what QEMU's actually not doing correctly >> and fix that.

Re: [Qemu-devel] [Xen-devel] [v3 1/5] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-01-06 Thread Xu, Quan
> -Original Message- > From: xen-devel-boun...@lists.xen.org > [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Eric Blake > Sent: Tuesday, January 06, 2015 12:07 AM > To: Xu, Quan; qemu-devel@nongnu.org > Cc: lcapitul...@redhat.com; arm...@redhat.com; xen-de...@lists.xen.org > Subje

Re: [Qemu-devel] [PATCH v4 0/7] tests: Add check-block to "make check"

2015-01-06 Thread Stefan Hajnoczi
On Sun, Jan 04, 2015 at 09:53:45AM +0800, Fam Zheng wrote: > qemu-iotests contains useful tests that have a nice coverage of block layer > code. Adding check-block (which calls tests/qemu-iotests-quick.sh) to "make > check" is good for developers' self-testing. > > v4: 06: Use CONFIG_LINUX instead

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: > On 2015/1/6 9:21, Chen, Tiejun wrote: > >On 2015/1/6 1:13, Eric Blake wrote: > >>On 01/04/2015 10:35 PM, Tiejun Chen wrote: > >>>After one commit 49d2e648e808, "machine: remove qemu_machine_opts > >>>global list", is introduced, QEMU d

Re: [Qemu-devel] [PATCH] vl.c: fix -usb option assertion failure in qemu_opt_get_bool_helper()

2015-01-06 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 10:37:25AM +0800, Chen, Tiejun wrote: > On 2015/1/5 20:14, Marcel Apfelbaum wrote: > >On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote: > >>On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka > >>wrote: > >>>On 2015-01-05 12:22, Stefan Hajnoczi wrote: > Commit 49d2e648e8087d154d8b

Re: [Qemu-devel] [PATCH v4] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-06 Thread Programmingkid
On Jan 6, 2015, at 9:02 AM, Stefan Hajnoczi wrote: > On Fri, Jan 02, 2015 at 04:44:38PM -0500, Programmingkid wrote: >> Removes redundant ret variable and renames sectorSize variable to meet QEMU >> coding standards. > > This is a changelog item for v4 of this patch. Changelogs should go > be

Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 06:24:58PM -0800, sfel...@gmail.com wrote: > From: Scott Feldman > > Rocker is a simulated ethernet switch device. The device supports up to 62 > front-panel ports and supports L2 switching and L3 routing functions, as well > as L2/L3/L4 ACLs. The device presents a singl

Re: [Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 06:24:59PM -0800, sfel...@gmail.com wrote: > From: Scott Feldman > > Add QMP/HMP support for rocker devices. This is mostly for debugging purposes > to see inside the device's tables and port configurations. Some examples: > > (qemu) rocker sw1 > name: sw1 > id: 0x0

Re: [Qemu-devel] [PATCH v2 0/7] coroutine: optimizations

2015-01-06 Thread Stefan Hajnoczi
On Tue, Dec 02, 2014 at 12:05:43PM +0100, Paolo Bonzini wrote: > As discussed in the other thread, this brings speedups from > dropping the coroutine mutex (which serializes multiple iothreads, > too) and using ELF thread-local storage. > > The speedup in perf/cost is about 50% (190->125). Window

Re: [Qemu-devel] [PATCH v3 1/5] QJSON: Add JSON writer

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > To support programmatic JSON assembly while keeping the code that generates it > readable, this patch introduces a simple JSON writer. It emits JSON serially > into a buffer in memory. > > The nice thing about this writer is its simplicity and low me

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 12:29:49PM +0100, Peter Lieven wrote: > If bs->bl.max_write_zeroes is large and we end up in the unsupported > path we might allocate a lot of memory for the iovector and/or even > generate an oversized requests. > > Fix this by limiting the request by the minimum of the re

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 03:34:07PM +0300, Denis V. Lunev wrote: > Though pls consider my patch v3, it avoids allocation of 16 Mb here and > uses only 1 Mb of memory. Once your patch has Reviewed-by: it will show up on my radar for merge. If you and Peter need a 2nd opinion in your discussions abo

Re: [Qemu-devel] [PATCH v3 2/5] QJSON: Add JSON writer

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > To support programmatic JSON assembly while keeping the code that generates it > readable, this patch introduces a simple JSON writer. It emits JSON serially > into a buffer in memory. > > The nice thing about this writer is its simplicity and low me

Re: [Qemu-devel] [PATCH v3 3/5] qemu-file: Add fast ftell code path

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > For ftell we flush the output buffer to ensure that we don't have anything > lingering in our internal buffers. This is a very safe thing to do. > > However, with the dynamic size measurement that the dynamic vmstate > description will bring this wou

Re: [Qemu-devel] [PATCH v3 4/5] migration: Append JSON description of migration stream

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > One of the annoyances of the current migration format is the fact that > it's not self-describing. In fact, it's not properly describing at all. > Some code randomly scattered throughout QEMU elaborates roughly how to > read and write a stream of byte

[Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Alexander Graf
Some ARM platforms can successfully map PCI devices into the guest, so it only makes sense to also add support for the Bochs virtual VGA adapter on those. Signed-off-by: Alexander Graf --- default-configs/arm-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/default-configs/arm-sof

[Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-06 Thread Alexander Graf
Now that we have a working "generic" PCIe host bridge driver, we can plug it into ARMs virt machine to always have PCIe available to normal ARM VMs. I've successfully managed to expose a Bochs VGA device, XHCI and an e1000 into an AArch64 VM with this and they all lived happily ever after. Signed

[Qemu-devel] [PATCH 0/4] ARM: Add support for a generic PCI Express host bridge

2015-01-06 Thread Alexander Graf
Linux implements a nice binding to describe a "generic" PCI Express host bridge using only device tree. This patch set adds enough emulation logic to expose the parts that are "generic" as a simple sysbus device and maps it into ARM's virt machine. With this patch set, we can finally spawn PCI de

[Qemu-devel] [PATCH 2/4] pci: Add generic PCIe host bridge

2015-01-06 Thread Alexander Graf
With simple exposure of MMFG, ioport window, mmio window and an IRQ line we can successfully create a workable PCIe host bridge that can be mapped anywhere and only needs to get described to the OS using whatever means it likes. This patch implements such a "generic" host bridge. It only supports

Re: [Qemu-devel] [PATCH v3 5/5] Add migration stream analyzation script

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > This patch adds a python tool to the scripts directory that can read > a dumped migration stream if it contains the JSON description of the > device states. I constructs a human readable JSON stream out of it. > > It's very simple to use: > > $ qe

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 16:03, Alexander Graf wrote: > Some ARM platforms can successfully map PCI devices into the guest, so it only > makes sense to also add support for the Bochs virtual VGA adapter on those. > > Signed-off-by: Alexander Graf > --- > default-configs/arm-softmmu.mak | 1 + > 1 fi

[Qemu-devel] [PATCH 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-06 Thread Alexander Graf
The mmcfg space is a memory region that allows access to PCI config space in the PCIe world. To maintain abstraction layers, I would like to expose the mmcfg space as a sysbus mmio region rather than have it mapped straight into the system's memory address space though. So this patch splits the in

Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device

2015-01-06 Thread Scott Feldman
On Tue, Jan 6, 2015 at 7:12 AM, Stefan Hajnoczi wrote: > On Mon, Jan 05, 2015 at 06:24:58PM -0800, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> Rocker is a simulated ethernet switch device. The device supports up to 62 >> front-panel ports and supports L2 switching and L3 routing functi

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Marcel Apfelbaum
On 01/06/2015 04:56 PM, Stefan Hajnoczi wrote: On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: On 2015/1/6 9:21, Chen, Tiejun wrote: On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts g

Re: [Qemu-devel] [PATCH] vl.c: fix -usb option assertion failure in qemu_opt_get_bool_helper()

2015-01-06 Thread Marcel Apfelbaum
On 01/06/2015 11:01 AM, Chen, Tiejun wrote: On 2015/1/6 14:20, Shannon Zhao wrote: On 2015/1/6 10:37, Chen, Tiejun wrote: On 2015/1/5 20:14, Marcel Apfelbaum wrote: On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote: On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka wrote: On 2015-01-05 12:22, Stefan

[Qemu-devel] [PATCH v2] target-openrisc: bugfix for dec_sys to decode instructions correctly

2015-01-06 Thread David Morrison
Fixed the decoding of "system" instructions (starting with 0x2) in dec_sys() in translate.c. In particular, the l.trap instruction is now correctly decoded, which enables for singlestepping and breakpoints to be set in GDB. Signed-off-by: David R. Morrison --- target-openrisc/translate.c | 2 +-

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
On Jan 6, 2015, at 11:46 AM, Peter Maydell wrote: > On 6 January 2015 at 16:30, Programmingkid wrote: >> I was doing some searching and thought I should show you this: >> file: vga.c >> >> This indicates that all operations are expected to be in the little endian >> format. > > That controls

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 17:19, Programmingkid wrote: > After investigating the TARGET_WORDS_BIGENDIAN code, I noticed > that s->default_endian_fb was being set to true. So I undefined > the macro and then ran QEMU. The i386 target showed no change > in colors. The ppc target still had the same incorr

[Qemu-devel] [PATCH] vl.c: fix regression when reading machine type from config file

2015-01-06 Thread Marcel Apfelbaum
After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and remains the default. Fixed that by querying the machine options after the configuration file is lo

[Qemu-devel] [PATCH v2 04/12] block/dmg: process a buffer instead of reading ints

2015-01-06 Thread Peter Wu
As the decoded plist XML is not a pointer in the file, dmg_read_mish_block must be able to process a buffer instead of a file pointer. Since the full buffer must be processed, let's change the return value again to just a success flag. Signed-off-by: Peter Wu Reviewed-by: John Snow --- v2: adde

[Qemu-devel] [PATCH v2 00/12] block/dmg: (compatibility) fixes and bzip2 support

2015-01-06 Thread Peter Wu
Hi, This is the second revision of improvements to DMG image file support. See [1] for an overview of the previous patchset. Thanks to John Snow for his efforts in reviewing patches and providing suggestions. The errp suggestion from Stefan Hajnoczi is also incorporated. An overview of changes s

[Qemu-devel] [PATCH v2 05/12] block/dmg: validate chunk size to avoid overflow

2015-01-06 Thread Peter Wu
Previously the chunk size was not checked, allowing for a large memory allocation. This patch checks whether the chunks size is within the resource fork length, and whether the resource fork is below the trailer of the dmg file. Signed-off-by: Peter Wu --- v2: added resource fork offset check --

[Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-06 Thread Peter Wu
DMG files have a variable length with a UDIF trailer at the end of a file. This UDIF trailer is essential as it describes the contents of the image. At the moment however, the start of this trailer is almost always incorrect as bdrv_getlength() returns a multiple of the block size (rounded up). Thi

[Qemu-devel] [PATCH v2 09/12] block/dmg: use SectorNumber from BLKX header

2015-01-06 Thread Peter Wu
Previously the sector table parsing relied on the previous offset of the DMG file. Now it uses the sector number from the BLKX header (see http://newosxbook.com/DMG.html). The implementation of dmg2img (from vu1tur) does not base the output sector on the location of the terminator (0x) eit

[Qemu-devel] [PATCH v2 08/12] block/dmg: fix sector data offset calculation

2015-01-06 Thread Peter Wu
This patch addresses two issues: - The data fork offset was not taken into account, resulting in failure to read an InstallESD.dmg file (5164763151 bytes) which had a non-zero DataForkOffset field. - The offset of the previous block ("partition") was unconditionally added to the current

[Qemu-devel] [PATCH v2 07/12] block/dmg: set virtual size to a non-zero value

2015-01-06 Thread Peter Wu
Right now the virtual size is always reported as zero which makes it impossible to convert between formats. After this patch, the number of sectors will be read from the trailer ("koly" block). To verify the behavior, the output of `dmg2img foo.dmg foo.img` was compared against `qemu-img convert

[Qemu-devel] [PATCH v2 06/12] block/dmg: process XML plists

2015-01-06 Thread Peter Wu
The format is simple enough to avoid using a full-blown XML parser. It assumes that all BLKX items begin with the "mish" magic word, therefore it is not a problem if other values get matched which are not a BLKX block. The offsets are based on the description at http://newosxbook.com/DMG.html Sig

[Qemu-devel] [PATCH v2 03/12] block/dmg: extract processing of resource forks

2015-01-06 Thread Peter Wu
Besides the offset, also read the resource length. This length is now used in the extracted function to verify the end of the resource fork against "count" from the resource fork. Instead of relying on the value of offset to conclude whether the resource fork is available or not (info_begin==0), c

[Qemu-devel] [PATCH v2 10/12] block/dmg: factor out block type check

2015-01-06 Thread Peter Wu
In preparation for adding bzip2 support, split the type check into a separate function. Make all offsets relative to the begin of a chunk such that it is easier to recognize the position without having to add up all offsets. Some comments are added to describe the fields. There is no functional ch

[Qemu-devel] [PATCH v2 12/12] block/dmg: improve zeroes handling

2015-01-06 Thread Peter Wu
Disk images may contain large all-zeroes gaps (1.66k sectors or 812 MiB is seen in the real world). These blocks (type 2) do not need to be extracted into a temporary buffer, there is no need to allocate memory for these blocks nor to check its length. (For the test image, the maximum uncompressed

[Qemu-devel] [PATCH v2 02/12] block/dmg: extract mish block decoding functionality

2015-01-06 Thread Peter Wu
Extract the mish block decoder such that this can be used for other formats in the future. A new DmgHeaderState struct is introduced to share state while decoding. The code is kept unchanged as much as possible, a "fail" label is added for example where a simple return would probably do. In dmg_op

Re: [Qemu-devel] [PATCH v8 2/3] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-01-06 Thread Peter Maydell
On 5 January 2015 at 16:14, Eric Auger wrote: > Device tree nodes for the platform bus and its children dynamic sysbus > devices are added in a machine init done notifier. To load the dtb once, > after those latter nodes are built and before ROM freeze, the actual > arm_load_kernel existing code i

[Qemu-devel] [PATCH v2 11/12] block/dmg: support bzip2 block entry types

2015-01-06 Thread Peter Wu
This patch adds support for bzip2-compressed block entries as introduced with OS X 10.4 (source: https://en.wikipedia.org/wiki/Apple_Disk_Image). It was tested against a 5.2G "OS X Yosemite" installation image which stores the BLXX block in the XML property list (instead of resource forks) and has

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-06 Thread Denis V. Lunev
On 06/01/15 18:43, Stefan Hajnoczi wrote: On Mon, Jan 05, 2015 at 03:34:07PM +0300, Denis V. Lunev wrote: Though pls consider my patch v3, it avoids allocation of 16 Mb here and uses only 1 Mb of memory. Once your patch has Reviewed-by: it will show up on my radar for merge. If you and Peter

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
On Jan 6, 2015, at 12:30 PM, Peter Maydell wrote: > On 6 January 2015 at 17:19, Programmingkid wrote: >> After investigating the TARGET_WORDS_BIGENDIAN code, I noticed >> that s->default_endian_fb was being set to true. So I undefined >> the macro and then ran QEMU. The i386 target showed no cha

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
https://opensource.apple.com/source/IOGraphics/IOGraphics-45.3/IOGraphicsFamily/IOBootFramebuffer.cpp This file is used for the frame buffer in Mac OS 10.2. There is no mention of the endian format for the pixels. That seems to indicate an oversight on Apple's part. http://www.mcamafia.de/pdf/i

  1   2   >