Re: [Qemu-devel] [PATCH] qapi: Fix document for BlockStats.node-name

2014-12-16 Thread Eric Blake
[adding qemu-trivial in cc] On 12/15/2014 06:40 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 6e8db15..2d8bd25 100644 > --- a/qapi/block-co

Re: [Qemu-devel] Need more info about scsi passthrough

2014-12-16 Thread Eduard Matei
Hi, Can someone provide some info? (see previous post) Thanks. On Wed, Dec 10, 2014 at 3:44 PM, Eduard Matei < eduard.ma...@cloudfounders.com> wrote: > Hi everyone, > Not sure if this is the right ML to post to, i need some help figuring out > scsi passthrough on qemu. > > I have qemu-system-x86

Re: [Qemu-devel] [PATCH v6 3/3] hw/arm/virt: add dynamic sysbus device support

2014-12-16 Thread Eric Auger
On 12/16/2014 06:41 AM, Shannon Zhao wrote: > On 2014/12/9 18:29, Eric Auger wrote: >> Allows sysbus devices to be instantiated from command line by >> using -device option. Machvirt creates a platform bus at init. >> The dynamic sysbus devices are attached to this platform bus device. >> >> The pl

Re: [Qemu-devel] [PATCH] qapi: Fix document for BlockStats.node-name

2014-12-16 Thread Max Reitz
On 2014-12-16 at 02:40, Fam Zheng wrote: Signed-off-by: Fam Zheng --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 6e8db15..2d8bd25 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -42

[Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-16 Thread fred . konrad
From: KONRAD Frederic This adds a lock to avoid multiple exclusive access at the same time in case of TCG multithread. Signed-off-by: KONRAD Frederic --- target-arm/cpu.c | 15 +++ target-arm/cpu.h | 3 +++ target-arm/helper.h| 3 +++ target-arm/op_helper.c | 10 +

Re: [Qemu-devel] [PATCH v6 1/3] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2014-12-16 Thread Eric Auger
On 12/16/2014 06:56 AM, Shannon Zhao wrote: > On 2014/12/9 18:29, Eric Auger wrote: >> This new C module will be used by ARM machine files to generate >> platform bus node and their dynamic sysbus device tree nodes. >> >> Dynamic sysbus device node addition is done in a machine init >> done notifie

[Qemu-devel] Qemu with Microsoft VSS

2014-12-16 Thread xuanmao_001
I use the qemu guest agent, and freeze filesystem with vss, but I don't know what can vss do? use in which scenario ? anyone explain to me, thanks! xuanmao_001

[Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux

2014-12-16 Thread Frank Blaschka
From: Frank Blaschka Remove unnecessary and wrong includes. Fix get_rt_sto and get_st_pto to build on 32-bit. Signed-off-by: Frank Blaschka --- hw/s390x/s390-pci-bus.c | 25 +++-- hw/s390x/s390-pci-inst.c | 30 +++--- 2 files changed, 14 insertions(

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-16 Thread Paolo Bonzini
On 16/12/2014 10:13, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This adds a lock to avoid multiple exclusive access at the same time in case > of > TCG multithread. > > Signed-off-by: KONRAD Frederic > --- > target-arm/cpu.c | 15 +++ > target-arm/cpu.h

[Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

2014-12-16 Thread Max Reitz
@Mario, in theory an image "that should be taking up 30 GB" with four snapshots should be taking up at most about 150 GB, of course. Now the question is what you mean by "should be taking up 30 GB" and by "is taking 600+ GB". For the latter, did you query the file length (ls -l) or the actual size

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-16 Thread Frederic Konrad
On 16/12/2014 10:31, Paolo Bonzini wrote: On 16/12/2014 10:13, fred.kon...@greensocs.com wrote: From: KONRAD Frederic This adds a lock to avoid multiple exclusive access at the same time in case of TCG multithread. Signed-off-by: KONRAD Frederic --- target-arm/cpu.c | 15 +++

Re: [Qemu-devel] [RfC PATCH 1/3] configure: opengl overhaul

2014-12-16 Thread Gerd Hoffmann
On Mo, 2014-12-15 at 17:46 +0100, Michael Walle wrote: > Am 2014-12-11 12:05, schrieb Gerd Hoffmann: > > Rename config option from "glx" to "opengl", glx will not be the only > > option for opengl in near future. Also switch over to pkg-config for > > opengl support detection. > > I'm ok with tha

Re: [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows

2014-12-16 Thread Yan Vugenfirer
Hi, My suggestion is to handle the case when the newer OS will be installed in the guest as well. Please look at version helper API - http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972(v=vs.85).aspx

Re: [Qemu-devel] [PATCH v2] block: fix spoiling all dirty bitmaps by mirror and migration

2014-12-16 Thread Max Reitz
On 2014-11-27 at 10:40, Vladimir Sementsov-Ogievskiy wrote: Mirror and migration use dirty bitmaps for their purposes, and since commit [block: per caller dirty bitmap] they use their own bitmaps, not the global one. But they use old functions bdrv_set_dirty and bdrv_reset_dirty, which change all

Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file

2014-12-16 Thread Alexander Graf
> Am 16.12.2014 um 02:24 schrieb David Gibson : > >> On Tue, Dec 16, 2014 at 01:59:01AM +0100, Alexander Graf wrote: >> >> >>> On 16.12.14 01:43, David Gibson wrote: >>> At the moment the RTAS (firmware/hypervisor) time of day functions are >>> implemented in spapr_rtas.c along with a bunch o

Re: [Qemu-devel] [PATCH 4/5] pseries: Export /machine "rtc-time" property

2014-12-16 Thread Alexander Graf
> Am 16.12.2014 um 03:18 schrieb David Gibson : > >> On Tue, Dec 16, 2014 at 02:04:49AM +0100, Alexander Graf wrote: >> >> >>> On 16.12.14 01:43, David Gibson wrote: >>> On x86, the guest's RTC can be read with QMP via the "rtc-time" property >>> on the /machine object. This is due to an exp

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-16 Thread Paolo Bonzini
On 16/12/2014 10:36, Frederic Konrad wrote: > On 16/12/2014 10:31, Paolo Bonzini wrote: >> >> On 16/12/2014 10:13, fred.kon...@greensocs.com wrote: >>> From: KONRAD Frederic >>> >>> This adds a lock to avoid multiple exclusive access at the same time >>> in case of >>> TCG multithread. >>> >>> S

[Qemu-devel] [PULL 3/5] bootdevice: add Error **errp argument for qemu_boot_set()

2014-12-16 Thread arei . gonglei
From: Gonglei We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. Signed-off-by: Gonglei --- bootdevice.c| 14 ++ include/sysemu/sysemu.h |2 +- monitor.c | 14 ++ 3 f

[Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread arei . gonglei
From: Gonglei We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. For x86 architecture, we pass &error_abort to set_boot_dev() when vm startup in pc_coms_init(). Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: Blue Swirl Cc: q

[Qemu-devel] [PULL 1/5] bootdevice: move code about bootorder from vl.c to bootdevice.c

2014-12-16 Thread arei . gonglei
From: Gonglei First, we can downsize vl.c, make it simpler by little and little. Second, I can maintain those code and make some improvement. Cc: Jan Kiszka Signed-off-by: Gonglei --- bootdevice.c| 62 +++ include/hw/hw.h |

[Qemu-devel] [PULL 0/5] bootdevice patches

2014-12-16 Thread arei . gonglei
since commit 54600752a1dd67844c2cf3c467db562c39499838: Merge remote-tracking branch 'remotes/rth/tags/x86-next-20141214' into staging (2014-12-15 11:11:52 +) are available in the git repository at: https://github.com/gongleiarei/qemu.git tags/bootdevice-next-20141216 for yo

Re: [Qemu-devel] [RFC PATCH] target-arm: protect cpu_exclusive_*.

2014-12-16 Thread Frederic Konrad
On 16/12/2014 10:49, Paolo Bonzini wrote: On 16/12/2014 10:36, Frederic Konrad wrote: On 16/12/2014 10:31, Paolo Bonzini wrote: On 16/12/2014 10:13, fred.kon...@greensocs.com wrote: From: KONRAD Frederic This adds a lock to avoid multiple exclusive access at the same time in case of TCG mul

[Qemu-devel] [PULL 4/5] bootdevice: add validate check for qemu_boot_set()

2014-12-16 Thread arei . gonglei
From: Gonglei Signed-off-by: Gonglei --- bootdevice.c |8 1 file changed, 8 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index 7f07507..9de34ba 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -49,12 +49,20 @@ void qemu_register_boot_set(QEMUBootSetHandler *func, void *o

[Qemu-devel] [PULL 2/5] bootdevice: add Error **errp argument for validate_bootdevices()

2014-12-16 Thread arei . gonglei
From: Gonglei We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. Signed-off-by: Gonglei --- bootdevice.c| 10 +- include/sysemu/sysemu.h |2 +- vl.c| 15 +-- 3 file

[Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread arei.gonglei
From: Gonglei We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. For x86 architecture, we pass &error_abort to set_boot_dev() when vm startup in pc_coms_init(). Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: Blue Swirl Cc: q

[Qemu-devel] [PULL 0/5] bootdevice patches

2014-12-16 Thread arei.gonglei
changes since commit 54600752a1dd67844c2cf3c467db562c39499838: Merge remote-tracking branch 'remotes/rth/tags/x86-next-20141214' into staging (2014-12-15 11:11:52 +) are available in the git repository at: https://github.com/gongleiarei/qemu.git tags/bootdevice-next-20141216 for yo

[Qemu-devel] [PULL 1/5] bootdevice: move code about bootorder from vl.c to bootdevice.c

2014-12-16 Thread arei.gonglei
From: Gonglei First, we can downsize vl.c, make it simpler by little and little. Second, I can maintain those code and make some improvement. Cc: Jan Kiszka Signed-off-by: Gonglei --- bootdevice.c| 62 +++ include/hw/hw.h |

[Qemu-devel] [PULL 3/5] bootdevice: add Error **errp argument for qemu_boot_set()

2014-12-16 Thread arei.gonglei
From: Gonglei We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. Signed-off-by: Gonglei --- bootdevice.c| 14 ++ include/sysemu/sysemu.h |2 +- monitor.c | 14 ++ 3 f

[Qemu-devel] [PULL 4/5] bootdevice: add validate check for qemu_boot_set()

2014-12-16 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- bootdevice.c |8 1 file changed, 8 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index 7f07507..9de34ba 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -49,12 +49,20 @@ void qemu_register_boot_set(QEMUBootSetHandler *func, void *o

Re: [Qemu-devel] [PATCH] target-mips: add CPU definition for MIPS-II

2014-12-16 Thread Daniel Sanders
> As there will be a need to verify the support for MIPS2, we should aim > for the platform that we can physically get at some point and use for > testing/verification and improvement of the model. I agree. I'm not sure where I'm likely to find one though. > Untested support is not what you would

[Qemu-devel] [PULL 2/5] bootdevice: add Error **errp argument for validate_bootdevices()

2014-12-16 Thread arei.gonglei
From: Gonglei We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. Signed-off-by: Gonglei --- bootdevice.c| 10 +- include/sysemu/sysemu.h |2 +- vl.c| 15 +-- 3 file

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-16 Thread Gerd Hoffmann
Hi, > > How does this look like (incremental fixup attached, docs to be > > updated) ? > Might be worth separate docs for the enums (we've done it elsewhere). Sure, as mentioned above docs where not done yet ... > But the interface looks fine to me. ... as I wanted to check this first ;) S

Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux

2014-12-16 Thread Alexander Graf
> Am 16.12.2014 um 10:28 schrieb Frank Blaschka : > > From: Frank Blaschka > > Remove unnecessary and wrong includes. Fix get_rt_sto and > get_st_pto to build on 32-bit. > > Signed-off-by: Frank Blaschka Could you please roll the fixes into the offending patches and repost the set? Otherw

[Qemu-devel] [PATCH v7 1/3] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2014-12-16 Thread Eric Auger
This new C module will be used by ARM machine files to generate platform bus node and their dynamic sysbus device tree nodes. Dynamic sysbus device node addition is done in a machine init done notifier. arm_register_platform_bus_fdt_creator does the registration of this latter and is supposed to b

[Qemu-devel] [PATCH v7 2/3] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2014-12-16 Thread Eric Auger
Device tree nodes for the platform bus and its children dynamic sysbus devices are added in a machine init done notifier. To load the dtb once, after those latter nodes are built and before ROM freeze, the actual arm_load_kernel existing code is moved into a notifier notify function, arm_load_kerne

[Qemu-devel] [PATCH v7 0/3] machvirt dynamic sysbus device instantiation

2014-12-16 Thread Eric Auger
This patch series enables machvirt to dynamically instantiate sysbus devices from command line (using -device option). All those sysbus devices are plugged onto a platform bus. This latter device is instantiated in machvirt and takes care of the binding of children sysbus devices on a machine init

[Qemu-devel] [PATCH v7 3/3] hw/arm/virt: add dynamic sysbus device support

2014-12-16 Thread Eric Auger
Allows sysbus devices to be instantiated from command line by using -device option. Machvirt creates a platform bus at init. The dynamic sysbus devices are attached to this platform bus device. The platform bus device registers a machine init done notifier whose role will be to bind the dynamic sy

[Qemu-devel] [PATCH V2 0/8] pc: acpi: various fixes and cleanups

2014-12-16 Thread Igor Mammedov
changes from v1: * drop: [PATCH 7/9] acpi: replace opencoded notify codes with named values * use Michael's suggestion to improve build_append_nameseg() * drop long scope names and go back to recursion, but still significantly simplify building of PCI tree this series is an attempt to shave

[Qemu-devel] [PATCH V2 1/8] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled

2014-12-16 Thread Igor Mammedov
ACPI parser in XP considers PNP0A06 devices of CPU and memory hotplug as duplicates. Adding unique _UID to CPU hotplug device fixes BSOD. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw

[Qemu-devel] [PATCH V2 5/8] acpi: move generic aml building helpers into dedictated file

2014-12-16 Thread Igor Mammedov
the will be later used for composing AML primitives and all that could be reused later for ARM machines as well. Signed-off-by: Igor Mammedov --- hw/acpi/Makefile.objs| 1 + hw/acpi/acpi_gen_utils.c | 166 +++ hw/i386/acpi-build.c

[Qemu-devel] [PATCH V2 2/8] pc: acpi: decribe bridge device as not hotpluggable

2014-12-16 Thread Igor Mammedov
when bridge hotplug is disabled, i.e. for machine types less then 2.0, bridge device was created as hotpluggable by mistake since commit 133a2da. Fix it by just creating it as a present device. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Qemu-devel] [PATCH V2 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization

2014-12-16 Thread Igor Mammedov
zero initialize AcpiPmInfo struct to reduce code bloat a little bit. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 1fb92e5..f5ec66a 100644 --- a/hw/i386/acpi-buil

[Qemu-devel] [PATCH V2 8/8] pc: acpi-build: simplify PCI bus tree generation

2014-12-16 Thread Igor Mammedov
it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops unnecessary loops and bitmaps, creating devices and notification method in the same loop. * saves us ~100LOC Signed-off-by: Igor Mammedov --- hw/i386/ac

[Qemu-devel] [PATCH V2 6/8] acpi: add build_append_namestring() helper

2014-12-16 Thread Igor Mammedov
Use build_append_namestring() instead of build_append_nameseg() So user won't have to care whether name is NameSeg, NamePath or NameString. See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding Signed-off-by: Igor Mammedov --- hw/acpi/acpi_gen_utils.c | 86

[Qemu-devel] [PATCH V2 4/8] acpi: build_append_nameseg(): add padding if necessary

2014-12-16 Thread Igor Mammedov
According to ACPI spec NameSeg shorter than 4 characters must be padded up to 4 characters with "_" symbol. ACPI 5.0: 20.2.2 "Name Objects Encoding" Do it in build_append_nameseg() so that caller shouldn't know or care about it. Signed-off-by: Igor Mammedov --- v2: * simplify padding, suggest

[Qemu-devel] [PATCH V2 7/8] acpi: drop min-bytes in build_package()

2014-12-16 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/acpi_gen_utils.c | 14 -- hw/i386/acpi-build.c | 13 ++--- include/hw/acpi/acpi_gen_utils.h | 4 ++-- 3 files changed, 12 insertions(+), 19 deletions(-) diff --git a/hw/acpi/acpi_gen_utils.c b/hw/acpi/acpi_gen_util

Re: [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows

2014-12-16 Thread zhanghailiang
On 2014/12/16 17:38, Yan Vugenfirer wrote: Hi, My suggestion is to handle the case when the newer OS will be installed in the guest as well. Yes, we can do this when we install guest OS, save the version info into some places, and get the info when we need, But it is not so flexible, especi

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-16 Thread Kevin Wolf
Am 11.12.2014 um 14:52 hat Paolo Bonzini geschrieben: > Keep a queue of requests that were not submitted; pass them to > the kernel when a completion is reported, unless the queue is > plugged. > > The array of iocbs is rebuilt every time from scratch. This > avoids keeping the iocbs array and li

[Qemu-devel] [PATCH v4 2/5] raw-posix: Factor block size detection out of raw_probe_alignment()

2014-12-16 Thread Ekaterina Tumanova
Put it in new probe_logical_blocksize(). Signed-off-by: Ekaterina Tumanova --- block/raw-posix.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index e51293a..38172ca 100644 --- a/block/raw-pos

[Qemu-devel] [PATCH v4 0/5] Geometry and blocksize detection for backing devices.

2014-12-16 Thread Ekaterina Tumanova
Updates: v2 -> v3: 1. Fix comments 2. Fix error codes to -ENOTSUP. 3. Reduce LOC in probe_logical_blocksize. 4. Adjust #ifdef - #else logic in couple of places. 5. Rebased. I hope that I addressed all the comments from the last round of review. If you think it's ok now, can you please give me your

[Qemu-devel] [PATCH v4 1/5] block: add bdrv functions for geometry and blocksize

2014-12-16 Thread Ekaterina Tumanova
Add driver functions for geometry and blocksize detection Signed-off-by: Ekaterina Tumanova Reviewed-by: Thomas Huth --- block.c | 34 ++ include/block/block.h | 13 + include/block/block_int.h | 15 +++ 3 files chang

[Qemu-devel] [PATCH v4 4/5] block-backend: Add wrappers for blocksizes and geometry probing

2014-12-16 Thread Ekaterina Tumanova
Signed-off-by: Ekaterina Tumanova --- block/block-backend.c | 10 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index ef16d73..4b9ed85 100644 --- a/block/block-backend.c +++ b/block/block-b

[Qemu-devel] [PATCH v4 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-16 Thread Ekaterina Tumanova
Introduce driver methods of defining disk blocksizes (physical and logical) and hard drive geometry. Methods are only implemented for "host_device". For "raw" devices driver calls child's method. For now geometry detection will only work for DASD devices. To check that a local check_for_dasd funct

[Qemu-devel] [PATCH v4 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2014-12-16 Thread Ekaterina Tumanova
geometry: hd_geometry_guess function autodetects the drive geometry. This patch adds a block backend call, that probes the backing device geometry. If the inner driver method is implemented and succeeds (currently only for DASDs), the blkconf_geometry will pass-through the backing device geometry.

[Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2014-12-16 Thread Amit Shah
PIIX4 has disable_s3 and disable_s4 properties to enable or disable PM functions. Add such properties to the ICH9 chipset as well for the Q35 machine type. S3 / S4 are not guaranteed to always work (needs work in the guest as well as QEMU for things to work properly), and disabling advertising of

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-16 Thread Paolo Bonzini
On 16/12/2014 12:07, Kevin Wolf wrote: > Am 11.12.2014 um 14:52 hat Paolo Bonzini geschrieben: >> Keep a queue of requests that were not submitted; pass them to >> the kernel when a completion is reported, unless the queue is >> plugged. >> >> The array of iocbs is rebuilt every time from scratch

Re: [Qemu-devel] [PATCH v4 0/5] Geometry and blocksize detection for backing devices.

2014-12-16 Thread Christian Borntraeger
Am 16.12.2014 um 12:10 schrieb Ekaterina Tumanova: > Updates: > v2 -> v3: > 1. Fix comments > 2. Fix error codes to -ENOTSUP. > 3. Reduce LOC in probe_logical_blocksize. > 4. Adjust #ifdef - #else logic in couple of places. > 5. Rebased. > > I hope that I addressed all the comments from the last r

Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux

2014-12-16 Thread Frank Blaschka
On Tue, Dec 16, 2014 at 11:35:19AM +0100, Alexander Graf wrote: > > > > > Am 16.12.2014 um 10:28 schrieb Frank Blaschka : > > > > From: Frank Blaschka > > > > Remove unnecessary and wrong includes. Fix get_rt_sto and > > get_st_pto to build on 32-bit. > > > > Signed-off-by: Frank Blaschka >

Re: [Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version for windows

2014-12-16 Thread Yan Vugenfirer
> On Dec 16, 2014, at 9:30 AM, zhanghailiang > wrote: > > We can get guest's OS version info by using 'guest-get-os-version', > The return value contains version name and type (32-bit or 64-bit). > For example: > {"return":{"name":"Microsoft Windows Server 2012 R2","type":64}} > > Signed-off-b

Re: [Qemu-devel] [PATCH v7 0/3] machvirt dynamic sysbus device instantiation

2014-12-16 Thread Alexander Graf
On 16.12.14 11:42, Eric Auger wrote: > This patch series enables machvirt to dynamically instantiate sysbus > devices from command line (using -device option). > > All those sysbus devices are plugged onto a platform bus. This latter > device is instantiated in machvirt and takes care of the bin

Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux

2014-12-16 Thread Alexander Graf
On 16.12.14 12:46, Frank Blaschka wrote: > On Tue, Dec 16, 2014 at 11:35:19AM +0100, Alexander Graf wrote: >> >> >> >>> Am 16.12.2014 um 10:28 schrieb Frank Blaschka : >>> >>> From: Frank Blaschka >>> >>> Remove unnecessary and wrong includes. Fix get_rt_sto and >>> get_st_pto to build on 32-bit

Re: [Qemu-devel] [PATCH] target-mips: add CPU definition for MIPS-II

2014-12-16 Thread Leon Alrae
Hi Daniel, On 15/12/2014 14:03, Daniel Sanders wrote: > Hi, > > > > FWIW, the R6000 was a MIPS-II processor but I understand there was never > a proper manual for it. http://www.linux-mips.org/wiki/R6000 has a small > amount of information but not enough to accurately fill in qemu's structure.

Re: [Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-16 Thread Alexander Graf
On 12.12.14 16:58, Laszlo Ersek wrote: > The "data_memwidth" property is capable of changing the maximum valid > access size to the MMIO data register, and (corresponding to the previous > patch) resizes the memory region similarly, at device realization time. > > (Because "data_iomem" is config

Re: [Qemu-devel] readconfig with machine section and type option ignored

2014-12-16 Thread Markus Armbruster
William Dauchy writes: > Hello, > > I'm trying to specify machine type using the config file; for example: > > [machine] > type = "pc-i440fx-2.1" > > It seems to be ignored: > > qom-get path=/machine property=type > { u'return': u'pc-i440fx-2.2-machine'} > > It does work with the command lin

Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux

2014-12-16 Thread Frank Blaschka
On Tue, Dec 16, 2014 at 12:56:58PM +0100, Alexander Graf wrote: > > > On 16.12.14 12:46, Frank Blaschka wrote: > > On Tue, Dec 16, 2014 at 11:35:19AM +0100, Alexander Graf wrote: > >> > >> > >> > >>> Am 16.12.2014 um 10:28 schrieb Frank Blaschka > >>> : > >>> > >>> From: Frank Blaschka > >>> >

Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux

2014-12-16 Thread Cornelia Huck
On Tue, 16 Dec 2014 12:46:49 +0100 Frank Blaschka wrote: > On Tue, Dec 16, 2014 at 11:35:19AM +0100, Alexander Graf wrote: > > > > > > > > > Am 16.12.2014 um 10:28 schrieb Frank Blaschka > > > : > > > > > > From: Frank Blaschka > > > > > > Remove unnecessary and wrong includes. Fix get_rt_

Re: [Qemu-devel] [PATCH v4 7/8] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

2014-12-16 Thread Alexander Graf
On 12.12.14 16:58, Laszlo Ersek wrote: > Introduce the new boolean field "arm_boot_info.firmware_loaded". When this > field is set, it means that the portion of guest DRAM that the VCPU > normally starts to execute, or the pflash chip that the VCPU normally > starts to execute, has been populated

Re: [Qemu-devel] [PATCH v4 7/8] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

2014-12-16 Thread Peter Maydell
On 16 December 2014 at 12:15, Alexander Graf wrote: > I don't understand this. On AArch64 I can simply do -kernel Image and it > boots without decompressing anything, no? Yes, but if you pass -kernel Image.gz then it won't work unless the bootloader (ie QEMU) does the decompression for you. AArch

Re: [Qemu-devel] [PATCH v4 7/8] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

2014-12-16 Thread Alexander Graf
On 16.12.14 13:18, Peter Maydell wrote: > On 16 December 2014 at 12:15, Alexander Graf wrote: >> I don't understand this. On AArch64 I can simply do -kernel Image and it >> boots without decompressing anything, no? > > Yes, but if you pass -kernel Image.gz then it won't work unless the > bootlo

Re: [Qemu-devel] [PATCH v4 7/8] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

2014-12-16 Thread Peter Maydell
On 16 December 2014 at 12:20, Alexander Graf wrote: > The patch as is assumes that AArch64 images are always gzipped. I don't > think this assumption is correct - if you do "make Image" on a kernel > source tree, you will get an uncompressed Image file. > > I think we'd be better off trying to loa

[Qemu-devel] [PULL v2] Migration pull for 2.3

2014-12-16 Thread Amit Shah
The following changes since commit 54600752a1dd67844c2cf3c467db562c39499838: Merge remote-tracking branch 'remotes/rth/tags/x86-next-20141214' into staging (2014-12-15 11:11:52 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/for-

Re: [Qemu-devel] [PULL 00/47] Patches for KVM, x86, SCSI, migration fixes (2014-12-15)

2014-12-16 Thread Peter Maydell
On 15 December 2014 at 16:37, Paolo Bonzini wrote: > The following changes since commit 2528043f1f299e0e88cb026f1ca7c40bbb4e1f80: > > Update version for v2.2.0-rc3 release (2014-11-25 18:23:54 +) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-ups

Re: [Qemu-devel] [PATCH v1] [Review Request] RTC Support in e500

2014-12-16 Thread Alexander Graf
On 08.12.14 15:19, Amit Tomar wrote: > I am new to QEMU and tried to provide support for RTC in e500. > > Please review the following set of patches that would add RTC support in e500 > and guide me. > > Tested it on both x86 and ppc host machines. > > > Signed-off-by: Amit Singh Tomar >

Re: [Qemu-devel] readconfig with machine section and type option ignored

2014-12-16 Thread William Dauchy
On Dec16 13:09, Markus Armbruster wrote: > Broken since main()'s case QEMU_OPTION_machine doesn't just parse its > option argument with qemu_opts_parse(), it also implements parameter > "type". Copying Marcel because "he touched it, he owns it". yes indeed, the type option is also not working, an

Re: [Qemu-devel] [PATCH v4 7/8] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

2014-12-16 Thread Richard W.M. Jones
On Tue, Dec 16, 2014 at 12:25:41PM +, Peter Maydell wrote: > On 16 December 2014 at 12:20, Alexander Graf wrote: > > The patch as is assumes that AArch64 images are always gzipped. I don't > > think this assumption is correct - if you do "make Image" on a kernel > > source tree, you will get a

Re: [Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-16 Thread Laszlo Ersek
On 12/16/14 13:06, Alexander Graf wrote: > > > On 12.12.14 16:58, Laszlo Ersek wrote: >> The "data_memwidth" property is capable of changing the maximum valid >> access size to the MMIO data register, and (corresponding to the previous >> patch) resizes the memory region similarly, at device real

Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread Peter Maydell
On 16 December 2014 at 09:22, wrote: > @@ -412,9 +411,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t > above_4g_mem_size, > object_property_set_link(OBJECT(machine), OBJECT(s), > "rtc_state", &error_abort); > > -if (set_boot_dev(s, boot_device)) { >

Re: [Qemu-devel] [PATCH v4 7/8] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

2014-12-16 Thread Laszlo Ersek
On 12/16/14 13:42, Richard W.M. Jones wrote: > On Tue, Dec 16, 2014 at 12:25:41PM +, Peter Maydell wrote: >> On 16 December 2014 at 12:20, Alexander Graf wrote: >>> The patch as is assumes that AArch64 images are always gzipped. I don't >>> think this assumption is correct - if you do "make Im

[Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

2014-12-16 Thread Mario
@serge, what version would I need to upgrade to be able to use the external snapshots? that sounds like it would solve my problems -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1025244 Title: qcow2

Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread Gonglei
On 2014/12/16 20:42, Peter Maydell wrote: > On 16 December 2014 at 09:22, wrote: >> @@ -412,9 +411,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t >> above_4g_mem_size, >> object_property_set_link(OBJECT(machine), OBJECT(s), >> "rtc_state", &error_abort

[Qemu-devel] TCG multithreaded

2014-12-16 Thread alvise rigo
Hello, Related to TCG multithreaded, at Virtual Open Systems, we have also been working on it. More specifically we are looking on how to enable a basic multithreaded vCPU infrastructure with one cache per CPU. We intend to focus on the vCPU private tcg structures (instantiation/initialization), a

Re: [Qemu-devel] [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0

2014-12-16 Thread Michael S. Tsirkin
On Thu, Dec 11, 2014 at 02:25:19PM +0100, Cornelia Huck wrote: > virtio-net (non-vhost) now should have everything in place to support > virtio 1.0: let's enable the feature bit for it. > > Note that VIRTIO_F_VERSION_1 is technically a transport feature; once > every device is ready for virtio 1.0

Re: [Qemu-devel] [PATCH v2 1/5] linux-aio: queue requests that cannot be submitted

2014-12-16 Thread Kevin Wolf
Am 16.12.2014 um 12:28 hat Paolo Bonzini geschrieben: > > > On 16/12/2014 12:07, Kevin Wolf wrote: > > Am 11.12.2014 um 14:52 hat Paolo Bonzini geschrieben: > >> Keep a queue of requests that were not submitted; pass them to > >> the kernel when a completion is reported, unless the queue is > >>

[Qemu-devel] [PATCH v3 03/10] vnc: add display id to acl names

2014-12-16 Thread Gerd Hoffmann
In case the display id is "default" (which is the one you get if you don't explicitly assign one) we keep the old name scheme, without display, for backward compatibility reasons. Signed-off-by: Gerd Hoffmann Reviewed-by: Gonglei --- ui/vnc.c | 22 -- 1 file changed, 20 inse

[Qemu-devel] [PATCH v3 00/10] vnc: add support for multiple vnc displays

2014-12-16 Thread Gerd Hoffmann
Hi, New and hopefully final version multiple vnc display patch series. Monitor commands (last two patches) got sorted, otherwise only minor tweaks here and there. Added some reviewed-by tags. please review, Gerd Gerd Hoffmann (10): vnc: remove vnc_display global vnc: remove unused Displ

[Qemu-devel] [PATCH v3 10/10] monitor: add vnc websockets

2014-12-16 Thread Gerd Hoffmann
Add websockets bool to VncBasicInfo, report websocket server sockets, flag websocket client connections. Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 5 - ui/vnc.c | 15 --- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-sc

[Qemu-devel] [PATCH v3 01/10] vnc: remove vnc_display global

2014-12-16 Thread Gerd Hoffmann
Replace with a vnc_displays list, so we can have multiple vnc server instances. Add vnc_server_find function to lookup a display by id. With no id supplied return the first vnc server, for backward compatibility reasons. It is not possible (yet) to actually create multiple vnc server instances.

[Qemu-devel] [PATCH v3 02/10] vnc: remove unused DisplayState parameter, add id instead.

2014-12-16 Thread Gerd Hoffmann
DisplayState isn't used anywhere, drop it. Add the vnc server ID as parameter instead, so it is possible to specify the server instance. Signed-off-by: Gerd Hoffmann Reviewed-by: Gonglei --- include/ui/console.h | 16 ui/vnc.c | 29 ++--- vl

[Qemu-devel] [PATCH v3 05/10] vnc: allow binding servers to qemu consoles

2014-12-16 Thread Gerd Hoffmann
This patch adds a display= parameter to the vnc options. This allows to bind a vnc server instance to a specific display, allowing to create a multiseat setup with a vnc server for each seat. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 50 +++--- 1 fi

[Qemu-devel] [PATCH v3 06/10] vnc: update docs/multiseat.txt

2014-12-16 Thread Gerd Hoffmann
vnc joins the party ;) Also some s/head/seat/ to clarify. Signed-off-by: Gerd Hoffmann --- docs/multiseat.txt | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/docs/multiseat.txt b/docs/multiseat.txt index 67151e0..b963665 100644 --- a/docs/multiseat.txt +++

[Qemu-devel] [PATCH v3 08/10] vnc: factor out qmp_query_client_list

2014-12-16 Thread Gerd Hoffmann
so we can reuse it for the new vnc query command. Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 8d189e7..d04802c 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -385,6 +385,20 @@ st

[Qemu-devel] [PATCH v3 04/10] vnc: switch to QemuOpts, allow multiple servers

2014-12-16 Thread Gerd Hoffmann
This patch switches vnc over to QemuOpts, and it (more or less as side effect) allows multiple vnc server instances. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 +- qmp.c| 15 ++- ui/vnc.c | 271 --- vl.

[Qemu-devel] [PATCH v3 07/10] vnc: track & limit connections

2014-12-16 Thread Gerd Hoffmann
Also track the number of connections in "connecting" and "shared" state (in addition to the "exclusive" state). Apply a configurable limit to these connections. The logic to apply the limit to connections in "shared" state is pretty simple: When the limit is reached no new connections are allowe

[Qemu-devel] [PATCH v3 09/10] monitor: add query-vnc2 command

2014-12-16 Thread Gerd Hoffmann
Add new query vnc qmp command, for the lack of better ideas just name it "query-vnc2". Changes over query-vnc: * It returns a list of vnc servers, so multiple vnc server instances are covered. * Each vnc server returns a list of server sockets. Followup patch will use that to also report

Re: [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-16 Thread Peter Maydell
On 16 December 2014 at 13:04, Gonglei wrote: > On 2014/12/16 20:42, Peter Maydell wrote: > >> On 16 December 2014 at 09:22, wrote: >>> @@ -412,9 +411,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t >>> above_4g_mem_size, >>> object_property_set_link(OBJECT(machine), OBJECT(s), >>>

[Qemu-devel] [PATCH v2 02/10] sdl2: rename sdl2_state to sdl2_console, move to header file

2014-12-16 Thread Gerd Hoffmann
Create sdl2.h header file, in preparation for sdl2 code splitup. Populate it with sdl2_console struct (renamed from sdl2_state). Signed-off-by: Gerd Hoffmann --- include/ui/sdl2.h | 16 ++ ui/sdl2.c | 63 --- 2 files changed

[Qemu-devel] [PATCH v2 00/10] sdl2: fixes, cleanups and opengl preparation.

2014-12-16 Thread Gerd Hoffmann
Hi, Fixed up some issues pointed out by Max Reitz, also added revieed-by tags. /me plans to send a pull for this (plus the two fixes from max) before xmas, the sdl opengl bits have to wait until next year. please review, Gerd Gerd Hoffmann (10): sdl: move version logic from source code to

[Qemu-devel] [PATCH v2 03/10] sdl2: move keyboard input code to new sdl2-input.c

2014-12-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/sdl2.h | 4 +++ ui/Makefile.objs | 2 +- ui/sdl2-input.c | 106 ++ ui/sdl2.c | 75 ++ 4 files changed, 114 insertions(+), 73 deletions(-) create mod

[Qemu-devel] [PATCH v2 04/10] sdl2: turn on keyboard grabs

2014-12-16 Thread Gerd Hoffmann
Makes quite some keys actually go to the guest instead of being captured by the host window manager. Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index b8d592f..9b66017 100644 --- a/ui/sdl2.c +++ b/ui/

[Qemu-devel] [PATCH v2 09/10] sdl2: factor out sdl2_poll_events

2014-12-16 Thread Gerd Hoffmann
Create a new function to poll and handle sdl2 events, which is then just called from the refresh timer. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- include/ui/sdl2.h | 1 + ui/sdl2.c | 23 +-- 2 files changed, 14 insertions(+), 10 deletions(-) diff --gi

  1   2   3   >