[Qemu-devel] MultiThread TCG mail list

All - to make things easier to track, there is now a mail list specifically for MultiThread development issues mt...@listserver.greensocs.com You can subscribe etc here: http://listserver.greensocs.com/wws/info/mttcg If you send

Re: [Qemu-devel] advent calendar

On 03/12/2014 04:22, Paul Ford wrote: > Love the advent calendar! Wonderful idea. > > One tiny note: On a Mac with qemu installed via the brew installer I > don't have access to kvm, so to run the Slackware image I had to remove > the kvm command-line option from the "Run" shell script. > > It

Re: [Qemu-devel] [PATCH for-2.3 v2 3/6] vmdk: Clean up descriptor file reading

Fam Zheng writes: > Zeroing a buffer that will be filled right after is not necessary, and > allocating a power of two + 1 is naughty. > > Suggested-by: Markus Armbruster > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH] qemu-iotests: Skip 099 for VMDK subformats with desc file

On 2014-12-03 at 02:49, Fam Zheng wrote: VMDK extent parsing code doesn't handle the JSON file name, so the case fails for these subformats. Disabled them. Signed-off-by: Fam Zheng --- tests/qemu-iotests/099 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iot

Re: [Qemu-devel] KVM call for agenda for 2014-12-08

Hi Juan, is this for the 9th, or did I get the day wrong Anyway - I would like to talk about Multi-core - a huge thank you to everybody for your feedback, we’ll be starting work on this, and I’d like to bring a proposal in terms of the path we’ll take and get consensus on the first steps. Cheer

Re: [Qemu-devel] [PATCH RESCEND v2] target-i386: Intel xsaves

On 03/12/2014 03:36, Wanpeng Li wrote: > Add xsaves related definition, it also adds corresponding part > to kvm_get/put, and vmstate. > > Signed-off-by: Wanpeng Li > --- > v1 -> v2: > * use a subsection instead of bumping the version number. > > target-i386/cpu.h | 2 ++ > target-i386

[Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059

There are two instances of iotest 059 using qemu-io on a qcow2 image. As of "qemu-iotests: Use qemu-io -f $IMGFMT" the iotests can no longer rely on $QEMU_IO doing probing, therefore the qcow2 format has to be specified explicitly here. Signed-off-by: Max Reitz --- tests/qemu-iotests/059 | 4 ++-

Re: [Qemu-devel] [PATCH for-2.3 v2 3/6] vmdk: Clean up descriptor file reading

On Wed, 12/03 09:21, Markus Armbruster wrote: > Fam Zheng writes: > > > Zeroing a buffer that will be filled right after is not necessary, and > > allocating a power of two + 1 is naughty. > > > > Suggested-by: Markus Armbruster > > Signed-off-by: Fam Zheng > > --- > > block/vmdk.c | 5 +++-- >

[Qemu-devel] [PATCH 0/2] vmdk: Fix error for JSON descriptor file names

This series improves the error message emitted when a vmdk file has a JSON file name and the vmdk driver tries to read the extent files (which will not work), and adds an appropriate test case. This series depends on "[PATCH] iotests: Specify qcow2 format for qemu-io in 059". Max Reitz (2): vm

[Qemu-devel] [PATCH 2/2] iotests: Add test for vmdk JSON file names

Add a test for vmdk files which use a file with a JSON file name, and which then try to open extents. That should fail and the error message should at least try to look helpful. Signed-off-by: Max Reitz --- tests/qemu-iotests/059 | 6 ++ tests/qemu-iotests/059.out | 4 2 files chang

[Qemu-devel] [PATCH 1/2] vmdk: Fix error for JSON descriptor file names

If vmdk blindly tries to use path_combine() using bs->file->filename as the base file name, this will result in a bad error message for JSON file names when calling bdrv_open(). It is better to only try bs->file->exact_filename; if that is empty, bs->file->filename will be useless for path_combine(

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Tue, 2 Dec 2014 21:03:45 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > void virtio_queue_set_num(VirtIODevice *vdev, int n, int num) > > { > > +/* > > + * For virtio-1 devices, the number of buffers may only be > > + * upda

[Qemu-devel] [PATCH v3 1/5] libqos: Change use of pointers to uint64_t in virtio

Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 20 +++- tests/libqos/virtio

[Qemu-devel] [PATCH v3 0/5] libqos: Virtio MMIO driver

Add virtio-mmio support to libqos and test case for virtio-blk. This series depends on patch "libqos: Convert malloc-pc allocator to a generic allocator" Changes from version 2: - Fix leaks and minor bugs - Extract basic test case to a function Marc Marí (5): libqos: Change use of pointers

[Qemu-devel] [PATCH v3 3/5] libqos: Remove PCI assumptions in constants of virtio driver

Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 30 +++--- tests/libqos/virtio-pci.h | 24 tests/virtio-blk-test.c | 11 ++- 3 files changed, 33 insertions(+),

[Qemu-devel] [PATCH v3 4/5] libqos: Add malloc generic

This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí --- tests/libqos/malloc-generic.c | 50 + tests/libqos/m

[Qemu-devel] [PATCH v3 2/5] tests: Prepare virtio-blk-test for multi-arch implementation

Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí --- tests/virtio-blk-test.c | 146 +++ 1 file changed, 85 insertions(+), 61 deletions(-) diff --git a/tests/virtio-blk-test.c b/tests/vir

[Qemu-devel] [PATCH v3 5/5] libqos: Add virtio MMIO support

Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí --- tests/Makefile |4 +- tests/libqos/virtio-mmio.c | 190 tests/libqos/virtio-mmio.h | 46 +++ tests/virtio-blk-test.c| 81 +++

Re: [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059

On Wed, 12/03 10:15, Max Reitz wrote: > There are two instances of iotest 059 using qemu-io on a qcow2 image. As > of "qemu-iotests: Use qemu-io -f $IMGFMT" the iotests can no longer rely > on $QEMU_IO doing probing, therefore the qcow2 format has to be > specified explicitly here. > > Signed-off-

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

On Wed, Dec 03, 2014 at 02:55:40PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > A bonus of this feature is that supporting different > people (in different countries) using defferent keyboard > to connect the same guest but not need to configure > command line or libivrt xml file the

Re: [Qemu-devel] [PATCH 1/2] vmdk: Fix error for JSON descriptor file names

On Wed, 12/03 10:23, Max Reitz wrote: > If vmdk blindly tries to use path_combine() using bs->file->filename as > the base file name, this will result in a bad error message for JSON > file names when calling bdrv_open(). It is better to only try > bs->file->exact_filename; if that is empty, bs->fi

Re: [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059

On Wed, 12/03 10:15, Max Reitz wrote: > There are two instances of iotest 059 using qemu-io on a qcow2 image. As > of "qemu-iotests: Use qemu-io -f $IMGFMT" the iotests can no longer rely > on $QEMU_IO doing probing, therefore the qcow2 format has to be > specified explicitly here. > > Signed-off-

Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for vmdk JSON file names

On Wed, 12/03 10:23, Max Reitz wrote: > Add a test for vmdk files which use a file with a JSON file name, and > which then try to open extents. That should fail and the error message > should at least try to look helpful. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/059 | 6 ++

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

oneiric has seen the end of its life and is no longer receiving any updates. Marking the oneiric task for this ticket as "Won't Fix". ** Changed in: qemu-kvm (Ubuntu Oneiric) Status: Fix Committed => Won't Fix -- You received this bug notification because you are a member of qemu- devel-m

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Wed, 3 Dec 2014 10:27:36 +0100 Cornelia Huck wrote: > On Tue, 2 Dec 2014 21:03:45 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > > void virtio_queue_set_num(VirtIODevice *vdev, int n, int num) > > > { > > > +/* > > > + *

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

On 2014/12/3 17:38, Daniel P. Berrange wrote: > On Wed, Dec 03, 2014 at 02:55:40PM +0800, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> A bonus of this feature is that supporting different >> people (in different countries) using defferent keyboard >> to connect the same guest but not nee

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

On Wed, Dec 03, 2014 at 05:50:57PM +0800, Gonglei wrote: > On 2014/12/3 17:38, Daniel P. Berrange wrote: > > > On Wed, Dec 03, 2014 at 02:55:40PM +0800, arei.gong...@huawei.com wrote: > >> From: Gonglei > >> > >> A bonus of this feature is that supporting different > >> people (in different count

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

On 2014/12/3 17:54, Daniel P. Berrange wrote: > On Wed, Dec 03, 2014 at 05:50:57PM +0800, Gonglei wrote: >> On 2014/12/3 17:38, Daniel P. Berrange wrote: >> >>> On Wed, Dec 03, 2014 at 02:55:40PM +0800, arei.gong...@huawei.com wrote: From: Gonglei A bonus of this feature is that su

Re: [Qemu-devel] [RFC PATCH v5 07/31] icount: implement icount requesting

On 26/11/2014 11:39, Pavel Dovgalyuk wrote: > +int64_t cpu_get_instructions_counter(void) > +{ > +/* This function calls are synchnonized to timer changes, > + calling cpu_get_instructions_counter_locked without lock is safe */ > +int64_t icount = timers_state.qemu_icount; > +CP

Re: [Qemu-devel] Vhost-user - multi queue support

On Tue, Dec 2, 2014 at 1:42 PM, Long, Thomas wrote: > Hi All, > > I’m just wondering what the status is with regards to supporting > multi-queue in Vhost-user? > > > > I see that Nikolaev has developed a patch to support this feature: > > > https://github.com/SnabbCo/qemu/commit/f41eeccf4ab6ea59

[Qemu-devel] [PATCH] Drop superfluous conditionals around qemu_opts_del()

Signed-off-by: Markus Armbruster --- hw/core/qdev.c | 4 +--- qemu-char.c| 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 35fd00d..901f289 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1141,9 +1141,7 @@ static void device_fi

[Qemu-devel] [PATCH v3 0/6] vmdk: A few small fixes

v3: Fix 3/6 again. (Markus) v2: 3/6: Don't overwrite the last byte of buffer. (Don) Other patches are unchanged (added Markus' rev-by line). Here are some improvements on miscellaneous things such as CID generation, comments, input validation. Fam Zheng (6): vmdk: Use g_random_int to gener

[Qemu-devel] [PATCH v3 5/6] vmdk: Remove unnecessary initialization

It will be assigned to the return value of vmdk_read_desc. Suggested-by: Markus Armbruster Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 045fd7a..ed492bd 100644 ---

[Qemu-devel] [PATCH v3 3/6] vmdk: Clean up descriptor file reading

Zeroing a buffer that will be filled right after is not necessary, and allocating a power of two + 1 is naughty. Suggested-by: Markus Armbruster Signed-off-by: Fam Zheng --- block/vmdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 2

[Qemu-devel] [PATCH v3 2/6] vmdk: Fix comment to match code of extent lines

commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent type but the comment above the changed code is left out. Update the comment so they are consistent. Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster --- block/vmdk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around qemu_opts_del()

On 03/12/2014 11:28, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/core/qdev.c | 4 +--- > qemu-char.c| 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index 35fd00d..901f289 100644 > --- a/hw/core/qdev.

[Qemu-devel] [PATCH v3 6/6] vmdk: Set errp on failures in vmdk_open_vmdk4

Reported-by: Markus Armbruster Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster --- block/vmdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index ed492bd..127479d 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -642,6 +642,7 @@ static int vmdk_open

[Qemu-devel] [PATCH v3 1/6] vmdk: Use g_random_int to generate CID

This replaces two "time(NULL)" invocations with "g_random_int()". According to VMDK spec, CID "is a random 32‐bit value updated the first time the content of the virtual disk is modified after the virtual disk is opened". Using "seconds since epoch" is just a "lame way" to generate it, and not comp

[Qemu-devel] [PATCH v3 4/6] vmdk: Check descriptor file length when reading it

Since a too small file cannot be a valid VMDK image, and also since the buffer's first 4 bytes will be unconditionally examined by vmdk_open_sparse, let's error out the small file case to be clear. Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster --- block/vmdk.c | 5 + 1 file change

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

[ CCed Benoît and Max, this is blockdev work ] [ CCed Jeff, we're also talking about op blockers ] Not stripping quoted text for their convenience. Am 02.12.2014 um 20:06 hat Markus Armbruster geschrieben: > = Introduction = > > The block layer and its monitor commands have evolved, resulting in

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around qemu_opts_del()

On 2014/12/3 18:28, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/core/qdev.c | 4 +--- > qemu-char.c| 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > Reviewed-by: Gonglei > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index 35fd00d..901f289 100644

Re: [Qemu-devel] [PATCH 1/2] linux-headers: Update KVM headers from linux-next tag ToBeFilled

On Tue, Dec 02, 2014 at 06:28:13PM +, Eric Auger wrote: > Syncup KVM related linux headers from linux-next tree using > scripts/update-linux-headers.sh. > > Add a new group/attribute in VGIC KVM device enabling to force > vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT > > Sig

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 10:27:36 +0100 > Cornelia Huck wrote: > > > On Tue, 2 Dec 2014 21:03:45 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 02, 2014 at 04:41:36PM +0100, Cornelia Huck wrote: > > > > void virtio_queue_s

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote: [...] > hw_error("xc_domain_getinfo failed"); > } > -if (xc_domain_setmaxmem(xen_xc, xen_domid, info.max_memkb + > -(nr_pfn * XC_PAGE_SIZE / 1024)) < 0) { > +max_page

Re: [Qemu-devel] [PATCH 1/2] linux-headers: Update KVM headers from linux-next tag ToBeFilled

On 12/03/2014 11:49 AM, Christoffer Dall wrote: > On Tue, Dec 02, 2014 at 06:28:13PM +, Eric Auger wrote: >> Syncup KVM related linux headers from linux-next tree using >> scripts/update-linux-headers.sh. >> >> Add a new group/attribute in VGIC KVM device enabling to force >> vgic init: KVM_DEV

Re: [Qemu-devel] [PATCH 1/2] linux-headers: Update KVM headers from linux-next tag ToBeFilled

On Wed, Dec 03, 2014 at 11:53:58AM +0100, Eric Auger wrote: > On 12/03/2014 11:49 AM, Christoffer Dall wrote: > > On Tue, Dec 02, 2014 at 06:28:13PM +, Eric Auger wrote: > >> Syncup KVM related linux headers from linux-next tree using > >> scripts/update-linux-headers.sh. > >> > >> Add a new gr

[Qemu-devel] [PATCH v4 REPOST 1/2] Add device listener interface

The Xen ioreq-server API, introduced in Xen 4.5, requires that PCI device models explicitly register with Xen for config space accesses. This patch adds a listener interface into qdev-core which can be used by the Xen interface code to monitor for arrival and departure of PCI devices. Signed-off-b

[Qemu-devel] [PATCH v4 REPOST 2/2] Use ioreq-server API

This patch series is a re-post v4 of what was originally the single patch "Xen: Use the ioreq-server API when available". It was originally posted on October 16th and pinged on October 29th. I am still awaiting an ack/nack for patch #1, hence the re-post. v2 of the series moved the code that added

Re: [Qemu-devel] [PATCH 1/2] linux-headers: Update KVM headers from linux-next tag ToBeFilled

On 12/03/2014 12:03 PM, Christoffer Dall wrote: > On Wed, Dec 03, 2014 at 11:53:58AM +0100, Eric Auger wrote: >> On 12/03/2014 11:49 AM, Christoffer Dall wrote: >>> On Tue, Dec 02, 2014 at 06:28:13PM +, Eric Auger wrote: Syncup KVM related linux headers from linux-next tree using scri

[Qemu-devel] [PATCH v4 REPOST 2/2] Xen: Use the ioreq-server API when available

The ioreq-server API added to Xen 4.5 offers better security than the existing Xen/QEMU interface because the shared pages that are used to pass emulation request/results back and forth are removed from the guest's memory space before any requests are serviced. This prevents the guest from mapping

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

On 03/12/2014 06:52, Fam Zheng wrote: >> > * drive-backup >> > >> > @device names a backend. >> > >> > Do we want to be able to back up any node, or only a backend? If non-backend nodes are read-only, we can just copy them outside QEMU. >> > Note: documentation of @target sounds like it

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Wed, 3 Dec 2014 12:52:51 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > index 43b7e02..1e2a720 100644 > > --- a/hw/virtio/virtio-mmio.c > > +++ b/hw/virtio/virtio-mmio.c

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Wed, Dec 03, 2014 at 12:14:10PM +0100, Cornelia Huck wrote: > On Wed, 3 Dec 2014 12:52:51 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > > > index 43b7e02..1e2a72

Re: [Qemu-devel] [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout

On Wed, 3 Dec 2014 13:19:17 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 03, 2014 at 12:14:10PM +0100, Cornelia Huck wrote: > > On Wed, 3 Dec 2014 12:52:51 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Dec 03, 2014 at 10:50:04AM +0100, Cornelia Huck wrote: > > > > @@ -748,6 +756,1

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

Hi, > Hi, Daniel > Actually, my team had received the requirement of changing VNC keyboard > layout dynamically on the scenario of Desktop Cloud. The clientele just use > the simplest tight vnc client, but not GTK-VNC etc. I think we should support > this scenario, isn't it ? It boils down to

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

On Wed, 3 Dec 2014, Wei Liu wrote: > On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote: > [...] > > hw_error("xc_domain_getinfo failed"); > > } > > -if (xc_domain_setmaxmem(xen_xc, xen_domid, info.max_memkb + > > -(nr_pfn * X

Re: [Qemu-devel] [PATCH v4 REPOST 1/2] Add device listener interface

The second patch is already Acked. You just need a review on this one to move forward, right? Andreas, Michael? On Wed, 3 Dec 2014, Paul Durrant wrote: > The Xen ioreq-server API, introduced in Xen 4.5, requires that PCI device > models explicitly register with Xen for config space accesses. This

[Qemu-devel] [PATCH] ide: Check validity of logical block size

Our IDE emulation can't handle logical block sizes other than 512. Check for it. The original assumption was that other values would silently be ignored (which is bad enough), but it's not quite true: The physical block size is exposed in IDENTIFY DEVICE as a multiple of the logical block size. Se

[Qemu-devel] qemu rdma live migration

Hello. I don't find info about how qemu doing live migration via RDAM - my specific qeustion - does it need ethernet connection for some info, or can use native RDMA and resolve nodes via GUIDs ? -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru

Re: [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059

Am 03.12.2014 um 10:15 hat Max Reitz geschrieben: > There are two instances of iotest 059 using qemu-io on a qcow2 image. As > of "qemu-iotests: Use qemu-io -f $IMGFMT" the iotests can no longer rely > on $QEMU_IO doing probing, therefore the qcow2 format has to be > specified explicitly here. > >

Re: [Qemu-devel] [PATCH 1/2] vmdk: Fix error for JSON descriptor file names

Am 03.12.2014 um 10:23 hat Max Reitz geschrieben: > If vmdk blindly tries to use path_combine() using bs->file->filename as > the base file name, this will result in a bad error message for JSON > file names when calling bdrv_open(). It is better to only try > bs->file->exact_filename; if that is e

Re: [Qemu-devel] [PATCH 0/3 V1] add PCI support for the s390 platform

On Wed, 26 Nov 2014 10:05:10 +0100 Frank Blaschka wrote: > This set of patches implemets PCI support for the s390 platform. > Now it is possible to run virtio-net-pci and potentially all > virtual pci devices conforming to s390 platform constrains. > > V1 added lot of feedback from Alex Graf >

Re: [Qemu-devel] [PATCH 1/2] vmdk: Fix error for JSON descriptor file names

On 2014-12-03 at 13:44, Kevin Wolf wrote: Am 03.12.2014 um 10:23 hat Max Reitz geschrieben: If vmdk blindly tries to use path_combine() using bs->file->filename as the base file name, this will result in a bad error message for JSON file names when calling bdrv_open(). It is better to only try b

[Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

From: Stefano Stabellini Increase maxmem before calling xc_domain_populate_physmap_exact to avoid the risk of running out of guest memory. This way we can also avoid complex memory calculations in libxl at domain construction time. This patch fixes an abort() when assigning more than 4 NICs to a

[Qemu-devel] [PATCH v4 01/26] qcow2: Add two new fields to BDRVQcowState

Add two new fields regarding refcount information (the bit width of every entry and the maximum refcount value) to the BDRVQcowState. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 2 +- block/qcow2.c | 3 +++ block/qcow2.h | 2 ++ 3 files changed, 6 insertions(+), 1 del

[Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info

Add the bit width of every refcount entry to the format-specific information. In contrast to lazy_refcounts and the corrupt flag, this should be always emitted, even for compat=0.10 although it does not support any refcount width other than 16 bits. This is because if a boolean is optional, one no

[Qemu-devel] [PATCH v4 05/26] qcow2: Use unsigned addend for update_refcount()

update_refcount() and qcow2_update_cluster_refcount() currently take a signed addend. At least one caller passes a value directly derived from an absolute refcount that should be reached ("l2_refcount - 1" in expand_zero_clusters_in_l1()). Therefore, the addend should be unsigned because unsigned o

[Qemu-devel] [PATCH v4 00/26] qcow2: Support refcount orders != 4

As of version 3, the qcow2 file format supports different widths for refcount entries, ranging from 1 to 64 bit (only powers of two). Currently, qemu only supports 16 bit, which is the only width supported by version 2 (compat=0.10) images. This series adds support to qemu for all other valid refc

[Qemu-devel] [PATCH v4 04/26] qcow2: Only return status from qcow2_get_refcount

Refcounts can theoretically be of type uint64_t; in order to be able to represent the full range, qcow2_get_refcount() cannot use a single variable to represent both all refcount values and also keep some values reserved for errors. One solution would be to add an Error pointer parameter to qcow2_

[Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after refcount update

qcow2_update_cluster_refcount() does not have any quick access to the new refcount value, it has to call qcow2_get_refcount(). Some callers do not need that new value at all, others call qcow2_get_refcount() themselves anyway (albeit in a different code path, which can however be easily changed), t

[Qemu-devel] [PATCH v4 06/26] qcow2: Use 64 bits for refcount values

Refcounts may have a width of up to 64 bits, so qemu should use the same width to represent refcount values internally. Signed-off-by: Max Reitz --- block/qcow2-cluster.c | 2 +- block/qcow2-refcount.c | 42 -- block/qcow2.h | 4 ++-- 3 files c

Re: [Qemu-devel] qemu rdma live migration

* Vasiliy Tolstov (v.tols...@selfip.ru) wrote: > Hello. I don't find info about how qemu doing live migration via RDAM > - my specific qeustion - does it need ethernet connection for some > info, or can use native RDMA and resolve nodes via GUIDs ? The entire migration stream is passed over the RD

[Qemu-devel] [PATCH v4 08/26] qcow2: Refcount overflow and qcow2_alloc_bytes()

qcow2_alloc_bytes() may reuse a cluster multiple times, in which case the refcount is increased accordingly. However, if this would lead to an overflow the function should instead just not reuse this cluster and allocate a new one. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 31 +++

[Qemu-devel] [PATCH v4 07/26] qcow2: Respect error in qcow2_alloc_bytes()

qcow2_update_cluster_refcount() may fail, and qcow2_alloc_bytes() should mind that case. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c ind

[Qemu-devel] [PATCH v4 10/26] qcow2: Helper function for refcount modification

Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for accessing them, two helper functions are used (a getter and a setter). Those functions are called indirectly through function poi

[Qemu-devel] [PATCH v4 17/26] progress: Allow regressing progress

Progress may regress; this should be displayed correctly by qemu_progress_print(). While touching that area of code, drop the redundant parentheses in the same condition. Signed-off-by: Max Reitz --- util/qemu-progress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util

[Qemu-devel] [PATCH v4 09/26] qcow2: Helper for refcount array reallocation

Add a helper function for reallocating a refcount array, independent of the refcount order. The newly allocated space is zeroed and the function handles failed reallocations gracefully. The helper function will always align the buffer size to a cluster boundary; if storing the refcounts in such an

[Qemu-devel] [PATCH v4 13/26] qcow2: refcount_order parameter for qcow2_create2

Add a refcount_order parameter to qcow2_create2(), use that value for the image header and for calculating the size required for preallocation. For now, always pass 4. This addition requires changes to the calculation of the file size for the "full" and "falloc" preallocation modes. That in turn

[Qemu-devel] [PATCH v4 16/26] qcow2: Allow creation with refcount order != 4

Add a creation option to qcow2 for setting the refcount order of images to be created, and respect that option's value. This breaks some test outputs, fix them. Signed-off-by: Max Reitz --- block/qcow2.c | 20 include/block/block_int.h | 1 + tests/qemu-iotests/049.out

[Qemu-devel] [PATCH v4 20/26] qcow2: Use abort() instead of assert(false)

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index ed86370..63e07bc 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2718,9 +2718,9 @@ stati

[Qemu-devel] [PATCH v4 22/26] qcow2: Use intermediate helper CB for amend

If there is more than one time-consuming operation to be performed for qcow2_amend_options(), we need an intermediate CB which coordinates the progress of the individual operations and passes the result to the original status callback. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/

[Qemu-devel] [PATCH v4 11/26] qcow2: More helpers for refcount modification

Add helper functions for getting and setting refcounts in a refcount array for any possible refcount order, and choose the correct one during refcount initialization. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 121 - 1 file changed, 119

[Qemu-devel] [PATCH v4 21/26] qcow2: Split upgrade/downgrade paths for amend

If the image version should be upgraded, that is the first we should do; if it should be downgraded, that is the last we should do. So split the version change block into an upgrade part at the start and a downgrade part at the end. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: S

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

On 12/03/14 07:20, Stefano Stabellini wrote: On Wed, 3 Dec 2014, Wei Liu wrote: On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote: [...] hw_error("xc_domain_getinfo failed"); } -if (xc_domain_setmaxmem(xen_xc, xen_domid, info.max_memkb + -

[Qemu-devel] [PATCH v4 12/26] qcow2: Open images with refcount order != 4

No longer refuse to open images with a different refcount entry width than 16 bits; only reject images with a refcount width larger than 64 bits (which is prohibited by the specification). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 8 -

[Qemu-devel] [PATCH v4 23/26] qcow2: Add function for refcount order amendment

Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 452 + block/qcow2.h | 4 + 2 files changed, 456 insertions(+) diff --git a/bl

[Qemu-devel] [PATCH v4 24/26] qcow2: Invoke refcount order amendment function

Make use of qcow2_change_refcount_order() to support changing the refcount order with qemu-img amend. Signed-off-by: Max Reitz --- block/qcow2.c | 44 +++- 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 6

[Qemu-devel] [PATCH v4 19/26] qcow2: Use error_report() in qcow2_amend_options()

Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 14 ++ tests/qemu-iotests/061.out | 14 +++--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index b028a4a..ed86370

[Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in check

If a reference count is not representable with the current refcount order, the image check should point to qemu-img amend for increasing the refcount order. However, qemu-img amend needs write access to the image which cannot be provided if the image is marked corrupt; and the image check will not

Re: [Qemu-devel] [PATCH v3 00/13] block: Various Coverity-spotted fixes

Am 02.12.2014 um 18:32 hat Max Reitz geschrieben: > This series fixes various issues spotted by Coverity. None of these is > critical; most are just "If you do something crazy, qemu-img crashes" or > "But what if there is no qcow2 driver?". > > Also, none is security-relevant. The only crashes whi

[Qemu-devel] [PATCH v4 26/26] iotests: Add test for different refcount widths

Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_bits=1). Signed-off-by: Max Reitz --- tests/qemu-iotests/112 | 296 + tests/qemu-iotests/112.out | 155 +

Re: [Qemu-devel] [PATCH v4 REPOST 1/2] Add device listener interface

On Wed, Dec 03, 2014 at 12:29:43PM +, Stefano Stabellini wrote: > The second patch is already Acked. > You just need a review on this one to move forward, right? > > Andreas, Michael? Looks like a generic qdev thing, nothing to do with me. > On Wed, 3 Dec 2014, Paul Durrant wrote: > > The Xe

Re: [Qemu-devel] [PATCH v4 REPOST 1/2] Add device listener interface

On 03/12/2014 14:40, Michael S. Tsirkin wrote: > On Wed, Dec 03, 2014 at 12:29:43PM +, Stefano Stabellini wrote: >> The second patch is already Acked. >> You just need a review on this one to move forward, right? >> >> Andreas, Michael? > > Looks like a generic qdev thing, nothing to do with

[Qemu-devel] [PATCH v4 15/26] iotests: Prepare for refcount_bits option

Some tests do not work well with certain refcount widths (i.e. you cannot create internal snapshots with refcount_bits=1), so make those widths unsupported. Furthermore, add another filter to _filter_img_create in common.filter which filters out the refcount_bits value. This is necessary for test

[Qemu-devel] [PATCH v2 2/2] iotests: Add test for vmdk JSON file names

Add a test for vmdk files which use a file with a JSON file name, and which then try to open extents. That should fail and the error message should at least try to look helpful. Signed-off-by: Max Reitz --- tests/qemu-iotests/059 | 6 ++ tests/qemu-iotests/059.out | 4 2 files chang

[Qemu-devel] [PATCH v2 1/2] vmdk: Fix error for JSON descriptor file names

If vmdk blindly tries to use path_combine() using bs->file->filename as the base file name, this will result in a bad error message for JSON file names when calling bdrv_open(). It is better to only try bs->file->exact_filename; if that is empty, bs->file->filename will be useless for path_combine(

[Qemu-devel] [PATCH v4 14/26] qcow2: Use symbolic macros in qcow2_amend_options

qcow2_amend_options() should not compare options against some inline strings but rather use the symbolic macros available for each of the creation options. Signed-off-by: Max Reitz --- block/qcow2.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --g

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

On 12/03/2014 03:30 AM, Kevin Wolf wrote: > [ CCed Benoît and Max, this is blockdev work ] > [ CCed Jeff, we're also talking about op blockers ] > > Not stripping quoted text for their convenience. I still intend to go through this mail in more detail, but off of a quick glance, I see you missed

Re: [Qemu-devel] qemu rdma live migration

2014-12-03 16:38 GMT+03:00 Dr. David Alan Gilbert : > The entire migration stream is passed over the RDMA; however > I'm not clear how the address lookup works, what you pass to the > migration command is the IP associated with the interface. > > Dave Yes i see this. So as i understand working et

[Qemu-devel] [PATCH] ARM64: support access to more performance registers in AA64 mode

In AA64 mode, certain system registers are access through MSR/MRS instructions instead of MCR/MRC. This patch added more such registers: /* ARMv8 manual, D8.4.10 */ PMINTENCLR_EL1 /* ARMv8 manual, D8.4.11 */ PMINTENSET_EL1 /* ARMv8 manual, D8.4.12 */ PMOVSCLR_EL0 /* ARMv8 manual, D8.4.14 */ PM

  1   2   3   >