Re: [Qemu-devel] [PATCH 2/5] exec: qemu_ram_alloc_device, qemu_ram_resize

2014-11-17 Thread Michael S. Tsirkin
On Tue, Nov 18, 2014 at 07:03:58AM +0100, Paolo Bonzini wrote: > > > On 17/11/2014 21:08, Michael S. Tsirkin wrote: > > Add API to manage on-device RAM. > > This looks just like regular RAM from migration POV, > > but has two special properties internally: > > > > - block is sized on migrati

Re: [Qemu-devel] [PATCH 1/9] l2tpv3: fix fd leak

2014-11-17 Thread Markus Armbruster
Michael Tokarev writes: > 15.11.2014 13:06, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> In this false branch, fd will leak when it is zero. >> Change the testing condition. > > Why fd==0 is a concern here? It is a very unlikely > situation that fd0 will be picked - firstly because >

<    1   2   3