Re: [Qemu-devel] [PATCH] icc_bus: rename ICC_BRIGDE to ICC_BRIDGE

2014-11-03 Thread Michael Tokarev
03.11.2014 14:43, Zhu Guihua wrote: [] > For Igor's opinion, it is better to change the subject. > So should I send v2 to fix this? I fixed it in git, no need to resend. (/me tries to minimize "noize" list traffic, but it's not so easy... ;) Thanks, /mjt

[Qemu-devel] [PULL 42/53] iotests: Expand test 061

2014-11-03 Thread Stefan Hajnoczi
From: Max Reitz Add some tests for progress output to 061. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf Reviewed-by: Benoit Canet Message-id: 1414404776-4919-8-git-send-email-mre...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/q

Re: [Qemu-devel] [PATCH 0/2] block: JSON filenames and relative backing files

2014-11-03 Thread Max Reitz
On 2014-11-03 at 12:41, Stefan Hajnoczi wrote: On Thu, Oct 23, 2014 at 04:56:13PM +0200, Max Reitz wrote: Sometimes, qemu does not have a filename to work with (it then generates a JSON filename), so it does not know which directory to use for a backing file specified by a relative filename. In

[Qemu-devel] [PULL 43/53] block: acquire AioContext in generic blockjob QMP commands

2014-11-03 Thread Stefan Hajnoczi
block-job-set-speed, block-job-cancel, block-job-pause, block-job-resume, and block-job-complete must acquire the BlockDriverState AioContext so that it is safe to access bs. At the moment bs->job is always NULL when dataplane is active because op blockers prevent blockjobs from starting. Once th

Re: [Qemu-devel] [PATCH v2 00/14] TCG ppc speedups

2014-11-03 Thread Alexander Graf
On 15.09.14 17:03, Paolo Bonzini wrote: > Patches 1-3 speed up softmmu emulation by avoiding TLB flushes on changes > to IR/DR. > > Patches 4-14 speed up emulation in general by rewriting the handling of > condition registers. The only change that seemed to not require a respin and was uncontro

[Qemu-devel] [PULL 3/3] elf: take phdr offset into account when calculating the program load address

2014-11-03 Thread riku . voipio
From: Jonas Maebe The first program header does not necessarily start at offset 0. This change corresponds to what the Linux kernel does in load_elf_binary(). Signed-off-by: Jonas Maebe Signed-off-by: Riku Voipio --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v4 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-11-03 Thread Markus Armbruster
Marcel Apfelbaum writes: > Hot-plugging a device that has a romfile (either supplied by user > or built-in) using rombar=0 option is a user error, > do not allow the device to be hot-plugged. > > Reviewed-by: Eric Blake > Signed-off-by: Marcel Apfelbaum > --- > hw/pci/pci.c | 9 + > 1

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-03 Thread Paolo Bonzini
On 03/11/2014 12:47, Chen, Tiejun wrote: > On 2014/11/3 19:36, Chen, Tiejun wrote: >> On 2014/11/3 19:35, Paolo Bonzini wrote: >>> On 03/11/2014 08:48, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots

[Qemu-devel] [PULL 50/53] block: let stream blockjob run in BDS AioContext

2014-11-03 Thread Stefan Hajnoczi
The stream block job must run in the BlockDriverState AioContext so that it works with dataplane. The basics of acquiring the AioContext are easy in blockdev.c. The tricky part is the completion code which drops part of the backing file chain. This must be done in the main loop where bdrv_unref(

[Qemu-devel] [PULL 0/3] linux-user changes for 2.2

2014-11-03 Thread riku . voipio
From: Riku Voipio The following changes since commit 0a2923f8488498000eec54871456aa64a4391da4: tcg/mips: fix store softmmu slow path (2014-11-02 13:30:00 +0100) are available in the git repository at: git://git.linaro.org/people/riku.voipio/qemu.git tags/pull-linux-user-20141101 for you t

[Qemu-devel] [PULL 2/3] linux-user: Fix fault address truncation AArch64

2014-11-03 Thread riku . voipio
From: Riku Voipio On AArch64 the si_addr field of siginfo_t is truncated to 32 bits because the fault address passes through an uint32_t variable. Follow Peters suggestion and drop the uint32_t variable since its only used once in the Aarch64 loop. Reported-by: Amanieu d'Antras Reviewed-by: Pe

[Qemu-devel] [PULL 52/53] block: let commit blockjob run in BDS AioContext

2014-11-03 Thread Stefan Hajnoczi
The commit block job must run in the BlockDriverState AioContext so that it works with dataplane. Acquire the AioContext in blockdev.c so starting the block job is safe. One detail here is that the bdrv_drain_all() must be moved inside the aio_context_acquire() region so requests cannot sneak in b

Re: [Qemu-devel] [PATCH] pc-bios: petalogix-s3adsp1800.dtb: Use 'xlnx, xps-ethernetlite-2.00.a' instead of 'xlnx, xps-ethernetlite-2.00.b'

2014-11-03 Thread Michael Tokarev
03.11.2014 12:26, Chen Gang wrote: > For Linux upstream kernel (e.g. 3.17-rc7), the related compatible string > 'xlnx,xps-ethernetlite-2.00.a' is supported, but 'b' is not supported, > so change qemu dtb file to match kernel driver. /me does not know anything about this stuff at all. But anyway..

[Qemu-devel] [PULL 1/3] linux-user: Let user specify random seed

2014-11-03 Thread riku . voipio
From: Magnus Reftel This patch introduces the -seed command line option and the QEMU_RAND_SEED environment variable for setting the random seed, which is used for the AT_RANDOM ELF aux entry. Signed-off-by: Magnus Reftel Reviewed-by: Eric Blake Signed-off-by: Riku Voipio --- linux-user/elflo

[Qemu-devel] [PULL 53/53] block: declare blockjobs and dataplane friends!

2014-11-03 Thread Stefan Hajnoczi
Now that blockjobs use AioContext they are safe for use with dataplane. Unblock them! Signed-off-by: Stefan Hajnoczi Reviewed-by: Max Reitz Message-id: 1413889440-32577-12-git-send-email-stefa...@redhat.com --- blockjob.c | 1 + hw/block/dataplane/virtio-blk.c | 5 + 2

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-03 Thread Stefano Stabellini
On Sun, 2 Nov 2014, Quan Xu wrote: > This drvier transfers any request/repond between TPM xenstubdoms > driver and Xen vTPM stubdom, and facilitates communications between > Xen vTPM stubdom domain and vTPM xenstubdoms driver > > Signed-off-by: Quan Xu Please describe what changes did make to xe

[Qemu-devel] [question] updating the base image for all clones which have been running for months

2014-11-03 Thread Zhang Haoyu
Hi, all I used base image A to clone so many vm, after running for months, each vm has its own private applications and data, which maybe different from each other. Now, I want to install some applications for all of the clones, what should I do? Can I rebase image A to B which have the applicat

Re: [Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-03 Thread Paolo Bonzini
On 02/11/2014 07:39, Quan Xu wrote: > This drvier transfers any request/repond between TPM xenstubdoms > driver and Xen vTPM stubdom, and facilitates communications between > Xen vTPM stubdom domain and vTPM xenstubdoms driver > > Signed-off-by: Quan Xu > --- > hw/xen/Makefile.objs |

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-11-03 Thread Eduardo Habkost
On Mon, Nov 03, 2014 at 08:53:54AM +, Dr. David Alan Gilbert wrote: [...] > > But tidy organization is a good thing while needless renaming is not. The > > only goal that the suggested renames would appear to accomplish is > > additional obfuscation. How about just moving them into a subdirecto

Re: [Qemu-devel] [question] updating the base image for all clones which have been running for months

2014-11-03 Thread Kevin Wolf
Am 03.11.2014 um 13:04 hat Zhang Haoyu geschrieben: > Hi, all > > I used base image A to clone so many vm, > after running for months, each vm has its own private applications and data, > which maybe different from each other. > Now, I want to install some applications for all of the clones, > wh

Re: [Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create()

2014-11-03 Thread Max Reitz
On 2014-10-29 at 11:42, Stefan Hajnoczi wrote: On Mon, Oct 27, 2014 at 01:30:07PM +0100, Max Reitz wrote: Currently, when trying to create a backed image without specifying its size, when the backing file does not exist or is not accessible, an appropriate error message will be generated which i

Re: [Qemu-devel] slirp-smb broken with Samba 4.1

2014-11-03 Thread Peter Wu
Hi, On Friday 24 October 2014 18:55:07 Jan Kiszka wrote: > writing to you as you provided a fix for the last related issue: > > I just noticed that the samba-based share is broken again with smbd > version 4.1.11. Tried to look briefly at it, realized that it is a > permission thing (different er

Re: [Qemu-devel] [PATCH 3/4] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms driver.

2014-11-03 Thread Stefano Stabellini
On Sun, 2 Nov 2014, Quan Xu wrote: > This driver provides vTPM initialization and sending data and TPM > commends to a Xen stubdom vTPM domain. ^ commands Driver for what? QEMU usually doesn't have drivers, QEMU has emulated devices. Is this an emulated device? Is it supposed to be run inside

Re: [Qemu-devel] [PATCH] virtio-serial: avoid crash when port has no name

2014-11-03 Thread Amit Shah
On (Wed) 29 Oct 2014 [17:32:27], Marc-André Lureau wrote: > It seems "name" is not mandatory, and the following command line (based > on one generated by current libvirt) will crash qemu at start: > > qemu-system-x86_64 \ > -device virtio-serial-pci \ > -device virtserialport,name=foo \ >

Re: [Qemu-devel] [block PATCH v2 0/3] AHCI device fixes

2014-11-03 Thread Paolo Bonzini
On 31/10/2014 21:03, John Snow wrote: > - Adjust the prepare_buf() callback to return, simply, the number > of bytes it was able to prepare, or -1 on error. This resolves > an ambiguity around the nature of its return code meaning > "no sectors" or "no bytes" which led to bad error pathways.

Re: [Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-11-03 Thread Peter Maydell
On 3 November 2014 09:16, Michael Tokarev wrote: > 03.11.2014 11:18, SeokYeon Hwang wrote: >>> --- a/translate-all.c >>> +++ b/translate-all.c >>> @@ -270,14 +270,14 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t >>> retaddr) } >>> >>> #ifdef _WIN32 >>> -static inline void map_exec(void *add

Re: [Qemu-devel] [PATCH 4/4] Qemu-Xen-vTPM: QEMU machine class is initialized before tpm_init()

2014-11-03 Thread Paolo Bonzini
On 02/11/2014 07:39, Quan Xu wrote: > make sure QEMU machine class is initialized and QEMU has registered > Xen stubdom vTPM driver when call tpm_init() [vl.c] > > Signed-off-by: Quan Xu > --- > vl.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/vl.c

Re: [Qemu-devel] [PATCH 0/9] valgrind/i386/s390x: memcheck false positives

2014-11-03 Thread Paolo Bonzini
On 30/10/2014 14:20, Christian Borntraeger wrote: > Am 30.10.2014 14:03, schrieb Paolo Bonzini: >> On 10/30/2014 10:36 AM, Christian Borntraeger wrote: >>> Some of these things could >>> also be fixed in valgrind, but it will take a while until these changes >>> hit a release or distros. >> >> Ok

Re: [Qemu-devel] [question] updating the base image for all clones which havebeen running for months

2014-11-03 Thread Zhang Haoyu
>> Hi, all >> >> I used base image A to clone so many vm, >> after running for months, each vm has its own private applications and data, >> which maybe different from each other. >> Now, I want to install some applications for all of the clones, >> what should I do? > >Install the applications o

Re: [Qemu-devel] [PATCH v3 0/2] actual checks of KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE

2014-11-03 Thread Paolo Bonzini
On 31/10/2014 14:38, Eric Auger wrote: > This patch series replaces direct settings of kvm_irqfds_allowed > in architecture specific files by actual check of the KVM_CAP_IRQFD > extension in kvm-all.c. > > Also A new kvm_resamplefds_enabled() enables to check > KVM_CAP_IRQFD_RESAMPLE. In the secon

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 12:31:42PM +0100, Paolo Bonzini wrote: > > On 02/11/2014 11:19, Michael S. Tsirkin wrote: > > > Add AVX512 feature bits, register definition and corresponding > > > xsave/vmstate support. > > > > > > Signed-off-by: Chao Peng > > > > Thanks! > > > > As this was first pos

[Qemu-devel] [PATCH] qemu-img: Omit error_report() after img_open()

2014-11-03 Thread Max Reitz
img_open() already prints an error if the operation failed, so there should not be another error_report() afterwards. Signed-off-by: Max Reitz --- qemu-img.c | 4 1 file changed, 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 66a7eb4..a42335c 100644 --- a/qemu-img.c +++ b/qemu-i

[Qemu-devel] [PULL 04/29] pc: Fix disabling of vapic for compat PC models

2014-11-03 Thread Michael S. Tsirkin
From: Jan Kiszka We used to be able to address both the QEMU and the KVM APIC via "apic". This doesn't work anymore. So we need to use their parent class to turn off the vapic on machines that should not expose them. Signed-off-by: Jan Kiszka Reviewed-by: Michael S. Tsirkin Signed-off-by: Mich

[Qemu-devel] [PULL 00/29] pc, virtio, misc bugfixes

2014-11-03 Thread Michael S. Tsirkin
The following changes since commit ee29498e4f0f3eff90eeeb7f5fa1703abedd2fb6: Merge remote-tracking branch 'remotes/sstabellini/xen-2014-10-30' into staging (2014-10-30 20:28:09 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstrea

[Qemu-devel] [PULL 01/29] smbios: Fix assertion on socket count calculation

2014-11-03 Thread Michael S. Tsirkin
From: Eduardo Habkost QEMU currently allows the number of VCPUs to not be a multiple of the number of threads per socket, but the smbios socket count calculation introduced by commit c97294ec1b9e36887e119589d456557d72ab37b5 doesn't take that into account, triggering an assertion. e.g.: $ ./x86

[Qemu-devel] [PULL 02/29] well-defined listing order for machine types

2014-11-03 Thread Michael S. Tsirkin
From: Laszlo Ersek Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine list") broke the ordering of the machine types in the user-visible output of qemu-system- -M \? This occurred because registration was rebased from a manually maintained linked list to GLib hash tables

[Qemu-devel] [PULL 05/29] i386: Add an ACPI_EXTRACT_NAME_BUFFER16 directive.

2014-11-03 Thread Michael S. Tsirkin
From: Gal Hammer Add a 16-bytes buffer to allow storing a 128-bit UUID value in an ACPI table. Signed-off-by: Gal Hammer Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- scripts/acpi_extract.py | 23 ++- 1 file changed, 14

[Qemu-devel] [PULL 06/29] pcie: change confused comment clearer

2014-11-03 Thread Michael S. Tsirkin
From: Gonglei This comment applies to all functions below it. It is not appropriate that called capability allocation functions, change it into capability list management functions. Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2

[Qemu-devel] [PULL 03/29] i386/pc: add piix and q35 machtypes to sorting families for -M \?

2014-11-03 Thread Michael S. Tsirkin
From: Laszlo Ersek With this patch applied, the output of -M \? is > Supported machines are: > pc Standard PC (i440FX + PIIX, 1996) (alias of > pc-i440fx-2.2) > pc-i440fx-2.2Standard PC (i440FX + PIIX, 1996) (default) > pc-i440fx-2.1Standard PC (i440FX + PIIX,

[Qemu-devel] [PULL 10/29] acpi: create separate file for TCPA log

2014-11-03 Thread Michael S. Tsirkin
From: Stefan Berger Create the TCPA log in a separate file rather than allocating ACPI table memory for it. Signed-off-by: Stefan Berger Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 22 +++--- 1 file changed, 15 insertions(+), 7

[Qemu-devel] [PULL 16/29] qom/cpu: remove the unused CPU hot-plug notifier

2014-11-03 Thread Michael S. Tsirkin
From: Gu Zheng Remove the unused CPU hot-plug notifier. Reviewed-by: Igor Mammedov Signed-off-by: Gu Zheng Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- include/sysemu/sysemu.h | 3 --- qom/cpu.c | 10 -- 2 files change

[Qemu-devel] [PULL 07/29] virtio-pci: fix migration for pci bus master

2014-11-03 Thread Michael S. Tsirkin
Current support for bus master (clearing OK bit) together with the need to support guests which do not enable PCI bus mastering, leads to extra state in VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of cross-version migration for the case when guests use the device before setting D

[Qemu-devel] [PULL 08/29] intel_iommu: fix VTD_SID_TO_BUS

2014-11-03 Thread Michael S. Tsirkin
(((sid) >> 8) && 0xff) makes no sense (((sid) >> 8) & 0xff) seems to be what was meant. https://bugs.launchpad.net/qemu/+bug/1382477 Signed-off-by: Michael S. Tsirkin --- include/hw/i386/intel_iommu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/intel_iom

[Qemu-devel] [PULL 13/29] acpi:piix4: convert cpu hotplug to hotplug_handler API

2014-11-03 Thread Michael S. Tsirkin
From: Gu Zheng Convert notifier based hotplug to hotplug_handler API, and remove the unused AcpiCpuHotplug_add(). Reviewed-by: Igor Mammedov Signed-off-by: Gu Zheng Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- include/hw/acpi/cpu_hotplug.h |

[Qemu-devel] [PULL 17/29] cpu-hotplug: rename function for better readability

2014-11-03 Thread Michael S. Tsirkin
From: Gu Zheng Rename: AcpiCpuHotplug_init --> acpi_cpu_hotplug_init AcpiCpuHotplug_ops --> acpi_cpu_hotplug_ops for better readability, just cleanup. Reviewed-by: Igor Mammedov Signed-off-by: Gu Zheng Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov

[Qemu-devel] [PULL 18/29] acpi/cpu-hotplug: introduce helper function to keep bit setting in one place

2014-11-03 Thread Michael S. Tsirkin
From: Gu Zheng Introduce helper function acpi_set_cpu_present_bit() to simplify acpi_cpu_plug_cb and acpi_cpu_hotplug_init, so that we can keep bit setting in one place. Signed-off-by: Gu Zheng Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- hw

[Qemu-devel] [PULL 12/29] acpi:ich9: convert cpu hotplug to hotplug_handler API

2014-11-03 Thread Michael S. Tsirkin
From: Gu Zheng Convert notifier based hotplug to hotplug_handler API. Reviewed-by: Igor Mammedov Signed-off-by: Gu Zheng Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- include/hw/acpi/ich9.h | 1 - hw/acpi/ich9.c | 13 ++--- 2

[Qemu-devel] [PULL 09/29] tests: fix rebuild-expected-aml.sh for acpi-test rename

2014-11-03 Thread Michael S. Tsirkin
From: Paolo Bonzini This is now called bios-tables-test. Signed-off-by: Paolo Bonzini Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/rebuild-expected-aml.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/acpi-test-data

[Qemu-devel] [PULL 15/29] pc: Update rtc_cmos in pc_cpu_plug

2014-11-03 Thread Michael S. Tsirkin
From: Gu Zheng Update rtc_cmos in pc_cpu_plug() directly, instead of the notifier. Reviewed-by: Igor Mammedov Signed-off-by: Gu Zheng Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- include/hw/i386/pc.h | 3 ++- hw/i386/pc.c | 37 +

[Qemu-devel] [PULL 20/29] hw/pci: fixed error flow in pci_qdev_init

2014-11-03 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Verify return code for pci_add_option_rom. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Markus Armbruster --- hw/pci/pci.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/pc

[Qemu-devel] [PULL 11/29] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-11-03 Thread Michael S. Tsirkin
From: Gu Zheng Add cpu hotplug callback function (acpi_cpu_plug_cb) to match hotplug_handler API. Reviewed-by: Igor Mammedov Signed-off-by: Gu Zheng Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- include/hw/acpi/cpu_hotplug.h | 3 +++ hw/acp

Re: [Qemu-devel] [PATCH v4 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 01:03:30PM +0100, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > Hot-plugging a device that has a romfile (either supplied by user > > or built-in) using rombar=0 option is a user error, > > do not allow the > > device to be hot-plugged. > > > > Reviewed-by: Er

[Qemu-devel] [PULL 24/29] smbios: Encode UUID according to SMBIOS specification

2014-11-03 Thread Michael S. Tsirkin
From: Eduardo Habkost Differently from older versions, SMBIOS version 2.6 is explicit about the encoding of UUID fields: > Although RFC 4122 recommends network byte order for all fields, the PC > industry (including the ACPI, UEFI, and Microsoft specifications) has > consistently used little-end

[Qemu-devel] [PULL 28/29] vga: add default display to machine class

2014-11-03 Thread Michael S. Tsirkin
From: Gerd Hoffmann This allows machine classes to specify which display device they want as default. If unspecified the current behavior (try cirrus, failing that try stdvga, failing that use no display) will be used. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by

[Qemu-devel] [PULL 23/29] pc: Add pc_compat_2_1() function

2014-11-03 Thread Michael S. Tsirkin
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 13 - hw/i386/pc_q35.c | 13 - 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc

[Qemu-devel] [PULL 14/29] pc: add cpu hotplug handler to PC_MACHINE

2014-11-03 Thread Michael S. Tsirkin
From: Gu Zheng Add cpu hotplug handler to PC_MACHINE, which will perform the acpi cpu hotplug callback via hotplug_handler API. Reviewed-by: Igor Mammedov Signed-off-by: Gu Zheng Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- hw/i386/pc.c | 28

[Qemu-devel] [PULL 27/29] vhost-user: fix mmap offset calculation

2014-11-03 Thread Michael S. Tsirkin
qemu_get_ram_block_host_ptr should get ram_addr_t, vhost-user passes in GPA. That's very wrong. Reported-by: Linhaifeng Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.

[Qemu-devel] [PULL 25/29] hw/i386/acpi-build.c: Fix memory leak in acpi_build_tables_cleanup()

2014-11-03 Thread Michael S. Tsirkin
From: Nikita Belov There are three ACPI tables: 'linker_data', 'rsdp' and 'table_data'. They are used differently. Two of them are being copied before using and only the copy is used later. But the third is used directly. Because of that we need to free two tables completely and delete only wrapp

Re: [Qemu-devel] [PATCH 4/7] runstate: migration allows more transitions now

2014-11-03 Thread Amit Shah
On (Wed) 15 Oct 2014 [09:55:07], Juan Quintela wrote: > Next commit would allow to move from incoming migration to error happening on > source. > > Should we add more states to this transition? Luiz? Yes; e.g. migrating in suspend-to-ram state. Amit

[Qemu-devel] [PULL 19/29] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-11-03 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" This is a pc & q35 only machine opt. VMWare apparently doesn't like running under QEMU due to our incomplete emulation of it's special IO Port. This adds a pc & q35 property to allow it to be turned off. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Don S

[Qemu-devel] [PULL 26/29] qemu-char: fix tcp_get_fds

2014-11-03 Thread Michael S. Tsirkin
tcp_get_fds API discards fds if there's more than 1 of these. It's tricky to fix this without API changes in the generic case. However, this API is only used by tests ATM, and tests know how many fds they expect. So let's not waste cycles trying to fix this properly: simply assume at most 16 fds

[Qemu-devel] [PATCH] qemu-doc.texi: fix typos for x509 examples

2014-11-03 Thread arei.gonglei
From: Gonglei Fix typos made people confuesd: 1) $ certtool --generate-certificate \ --load-ca-certificate ca-cert.pem \ --load-ca-privkey ca-key.pem \ --load-privkey server server-key.pem \ --template server.info \ --outfile server-cert.pem

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Remove the --git-chief-penguins option

2014-11-03 Thread Thomas Huth
On Wed, 22 Oct 2014 15:16:29 -0400 Don Slutz wrote: > On 10/22/14 08:28, Thomas Huth wrote: > > Linus likely does not want to get e-mails about QEMU, so let's > > just remove this option. > > > > Suggested-by: Michael S. Tsirkin > > Signed-off-by: Thomas Huth > > Looks good to me. > > Reviewe

[Qemu-devel] [PULL 21/29] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-11-03 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Hot-plugging a device that has a romfile (either supplied by user or built-in) using rombar=0 option is a user error, do not allow the device to be hot-plugged. Reviewed-by: Eric Blake Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michae

Re: [Qemu-devel] slirp-smb broken with Samba 4.1

2014-11-03 Thread Michael Tokarev
03.11.2014 15:22, Peter Wu wrote: [] > As an aside, would it be possible to override the samba binary at runtime, > without compiling? Either an envvar (SMBD) or an option (-net > user,smb=...,smbd=...). The whole thing needs to be rewritten to use a shell script to create smb.conf and to call smb

[Qemu-devel] [PULL 29/29] vga: flip qemu 2.2 pc machine types from cirrus to stdvga

2014-11-03 Thread Michael S. Tsirkin
From: Gerd Hoffmann This patch switches the default display from cirrus to vga for the new (qemu 2.2+) machine types. Old machines types stay as-is for compatibility reasons. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c

[Qemu-devel] [PULL 22/29] hw/virtio/vring/event_idx: fix the vring_avail_event error

2014-11-03 Thread Michael S. Tsirkin
From: Bin Wu The event idx in virtio is an effective way to reduce the number of interrupts and exits of the guest. When the guest puts an request into the virtio ring, it doesn't exit immediately to inform the backend. Instead, the guest checks the "avail" event idx to determine the notification

Re: [Qemu-devel] [PULL v2 2/9] well-defined listing order for machine types

2014-11-03 Thread Laszlo Ersek
On 10/22/14 10:18, Michael S. Tsirkin wrote: > From: Laszlo Ersek > > Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine > list") broke the ordering of the machine types in the user-visible output > of > > qemu-system- -M \? > > This occurred because registration was reb

Re: [Qemu-devel] [PATCH v4 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-11-03 Thread Marcel Apfelbaum
On Mon, 2014-11-03 at 13:03 +0100, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > Hot-plugging a device that has a romfile (either supplied by user > > or built-in) using rombar=0 option is a user error, > > do not allow the device to be hot-plugged. > > > > Reviewed-by: Eric Blake >

[Qemu-devel] ui/gtk.c vs old gtk versions

2014-11-03 Thread Cornelia Huck
After the latest gtk updates, master fails to build for me on a SLES11SP3 machine: /home/cohuck/git/qemu/ui/gtk.c: In function ‘gd_key_event’: /home/cohuck/git/qemu/ui/gtk.c:943: error: ‘GDK_KEY_Pause’ undeclared (first use in this function) /home/cohuck/git/qemu/ui/gtk.c:943: error: (Each undecl

Re: [Qemu-devel] [PULL v2 2/9] well-defined listing order for machine types

2014-11-03 Thread Laszlo Ersek
On 11/03/14 14:04, Laszlo Ersek wrote: > On 10/22/14 10:18, Michael S. Tsirkin wrote: >> From: Laszlo Ersek > > May I ask about the fate of this PULL request (in particular I care > about this patch, and the next one)? Never mind, I can see Michael's new PULL req, posted about half an hour ago.

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 01:01:03PM +0100, Paolo Bonzini wrote: > > > On 03/11/2014 12:47, Chen, Tiejun wrote: > > On 2014/11/3 19:36, Chen, Tiejun wrote: > >> On 2014/11/3 19:35, Paolo Bonzini wrote: > >>> On 03/11/2014 08:48, Chen, Tiejun wrote: > I think the point was mostly to reserve

Re: [Qemu-devel] [PULL v2 2/9] well-defined listing order for machine types

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 02:04:25PM +0100, Laszlo Ersek wrote: > On 10/22/14 10:18, Michael S. Tsirkin wrote: > > From: Laszlo Ersek > > > > Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine > > list") broke the ordering of the machine types in the user-visible output > > of > >

Re: [Qemu-devel] ui/gtk.c vs old gtk versions

2014-11-03 Thread Kevin Wolf
Am 03.11.2014 um 14:06 hat Cornelia Huck geschrieben: > After the latest gtk updates, master fails to build for me on a > SLES11SP3 machine: > > /home/cohuck/git/qemu/ui/gtk.c: In function ‘gd_key_event’: > /home/cohuck/git/qemu/ui/gtk.c:943: error: ‘GDK_KEY_Pause’ undeclared (first > use in this

Re: [Qemu-devel] [PULL v2 2/9] well-defined listing order for machine types

2014-11-03 Thread Andreas Färber
Am 03.11.2014 um 14:04 schrieb Laszlo Ersek: > On 10/22/14 10:18, Michael S. Tsirkin wrote: >> From: Laszlo Ersek >> >> Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine >> list") broke the ordering of the machine types in the user-visible output >> of >> >> qemu-system- -

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-03 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:22PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Open a return path, and handle messages that are received upon it. > > > > Signed-off-by: Dr. David Alan Gilbert > > [s

Re: [Qemu-devel] ui/gtk.c vs old gtk versions

2014-11-03 Thread Daniel P. Berrange
On Mon, Nov 03, 2014 at 02:11:35PM +0100, Kevin Wolf wrote: > Am 03.11.2014 um 14:06 hat Cornelia Huck geschrieben: > > After the latest gtk updates, master fails to build for me on a > > SLES11SP3 machine: > > > > /home/cohuck/git/qemu/ui/gtk.c: In function ‘gd_key_event’: > > /home/cohuck/git/qe

Re: [Qemu-devel] [PATCH] qemu-img: Omit error_report() after img_open()

2014-11-03 Thread Kevin Wolf
Am 03.11.2014 um 13:40 hat Max Reitz geschrieben: > img_open() already prints an error if the operation failed, so there > should not be another error_report() afterwards. > > Signed-off-by: Max Reitz Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself as bootdevice.c maintainer

2014-11-03 Thread Markus Armbruster
Gonglei writes: > On 2014/10/22 11:07, Gonglei (Arei) wrote: > >> From: Gonglei >> >> bootdevice.c was created by me, and I wrote most of >> the code in this file. And now I can maintain it, >> I'd hope nobody object this. >> >> Cc: Gerd Hoffmann >> Signed-off-by: Gonglei >> --- >> MAINTAIN

Re: [Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create()

2014-11-03 Thread Kevin Wolf
Am 03.11.2014 um 13:33 hat Max Reitz geschrieben: > On 2014-10-29 at 11:42, Stefan Hajnoczi wrote: > >On Mon, Oct 27, 2014 at 01:30:07PM +0100, Max Reitz wrote: > >>Currently, when trying to create a backed image without specifying its > >>size, when the backing file does not exist or is not access

Re: [Qemu-devel] [PATCH v4 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-11-03 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Mon, 2014-11-03 at 13:03 +0100, Markus Armbruster wrote: >> Marcel Apfelbaum writes: >> >> > Hot-plugging a device that has a romfile (either supplied by user >> > or built-in) using rombar=0 option is a user error, >> > do not allow the device to be hot-plugged. >

Re: [Qemu-devel] [PATCH] pc-bios: petalogix-s3adsp1800.dtb: Use 'xlnx, xps-ethernetlite-2.00.a' instead of 'xlnx, xps-ethernetlite-2.00.b'

2014-11-03 Thread Chen Gang
As far as I know, It is a hardware description file. Can convert it to dts format which is a text file, then can read and edit it, after finish, can convert it to dtb format again. dts and dtb can convert with each other without any information lost. One tool for converting is "scripts/dts/dts" i

Re: [Qemu-devel] [PATCH v4 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-11-03 Thread Marcel Apfelbaum
On Mon, 2014-11-03 at 14:40 +0100, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > On Mon, 2014-11-03 at 13:03 +0100, Markus Armbruster wrote: > >> Marcel Apfelbaum writes: > >> > >> > Hot-plugging a device that has a romfile (either supplied by user > >> > or built-in) using rombar=0

Re: [Qemu-devel] [PATCH] qemu-img: Omit error_report() after img_open()

2014-11-03 Thread Markus Armbruster
Max Reitz writes: > img_open() already prints an error if the operation failed, so there > should not be another error_report() afterwards. > > Signed-off-by: Max Reitz Especially not when only 4 out of 12 callers do it. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 0/5] Trivial patch about qemu-char

2014-11-03 Thread Michael Tokarev
03.11.2014 14:39, zhanghailiang wrote: > On 2014/11/3 18:03, Michael Tokarev wrote: >> 03.11.2014 12:44, zhanghailiang wrote: >>> Patch 1~3 fix wrong check about in-parameter. >>> The last two patches convert some open functions to use Error API. >>> >>> v2: >>> - don't use error_setg when followed

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-doc.texi: fix typos for x509 examples

2014-11-03 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp/smbd: disable printer in smb config

2014-11-03 Thread Michael Tokarev
03.11.2014 13:52, Peter Wu wrote: > The file sharing module should not handle printers, so disable it. > The options 'load printers' and 'printing' have been available since the > beginning (May 1996, commit 0e8fd3398771da2f016d72830179507f3edda51b). > Option 'disable spoolss' is available since Sa

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp/smbd: disable printer in smb config

2014-11-03 Thread Michael Tokarev
03.11.2014 17:15, Michael Tokarev wrote: > I picked it up for -trivial, and also Cc'ing Jan. And also changed subject to slirp/smbd: modify/set several parameters in generated smbd.conf -- a bit too generic, but at least it does not hide that many other parameters are being changed. Thanks,

Re: [Qemu-devel] [PATCH] translate-all: wrapped map_exec() in #ifdef

2014-11-03 Thread Michael Tokarev
03.11.2014 15:25, Peter Maydell wrote: > On 3 November 2014 09:16, Michael Tokarev wrote: >> 03.11.2014 11:18, SeokYeon Hwang wrote: --- a/translate-all.c +++ b/translate-all.c @@ -270,14 +270,14 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr) } #ifdef _

[Qemu-devel] [PATCH 1/2] s390x/kvm: Fix opcode decoding for eb instruction handler

2014-11-03 Thread Cornelia Huck
From: Frank Blaschka The second byte of the opcode is encoded in the lowest byte of the ipb field, not the lowest byte of the ipa field. Signed-off-by: Frank Blaschka Signed-off-by: Cornelia Huck --- target-s390x/kvm.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PATCH 0/2] s390x bugfixes for 2.2

2014-11-03 Thread Cornelia Huck
Two small bugfixes for s390x; nothing earthshattering. Frank Blaschka (1): s390x/kvm: Fix opcode decoding for eb instruction handler Thomas Huth (1): s390x/kvm: Fix warning from sparse target-s390x/kvm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) -- 1.7.9.5

[Qemu-devel] [PATCH 2/2] s390x/kvm: Fix warning from sparse

2014-11-03 Thread Cornelia Huck
From: Thomas Huth When running "sparse" with the s390x kvm.c code, it complains that "constant 0x00400f1d4033 is so big it is long" - let's fix this by appending a proper suffix. Signed-off-by: Thomas Huth Reviewed-by: David Hildenbrand Acked-by: Cornelia Huck Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup'

2014-11-03 Thread Kevin Wolf
Am 03.11.2014 um 02:46 hat Fam Zheng geschrieben: > On Fri, 10/31 10:01, Kevin Wolf wrote: > > Am 11.09.2014 um 07:05 hat Fam Zheng geschrieben: > > > Similar to drive-backup, but this command uses a device id as target > > > instead of creating/opening an image file. > > > > > > Also add blocker

Re: [Qemu-devel] [Nbd] spec, RFC: TLS support for NBDµ

2014-11-03 Thread Stefan Hajnoczi
On Fri, Oct 31, 2014 at 07:15:08PM +0100, Wouter Verhelst wrote: > On Thu, Oct 30, 2014 at 10:40:56AM +, Stefan Hajnoczi wrote: > > Also, I suggest at least developing a prototype before releasing the > > specification changes. Issues that were unknown ahead of time might be > > discovered dur

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_pci.c: Avoid functions not in glib 2.12 (g_hash_table_iter_*)

2014-11-03 Thread Alexander Graf
On 30.10.14 13:33, Peter Maydell wrote: > Ping! It would be nice to be able to get glib2.12 builds fixed... Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory

2014-11-03 Thread Markus Armbruster
Michael Tokarev writes: > 03.11.2014 10:56, Markus Armbruster wrote: >> Michael Tokarev writes: > [] >>> I'm not sure this qualifies as -trivial really. Yes the change >>> does not affect anything but the `info' command, and is rather >>> simple, but... I'm not sure. >> >> Fortunately, monitor

Re: [Qemu-devel] [PATCH] Add new instruction for M68K family

2014-11-03 Thread Thomas Huth
On Fri, 31 Oct 2014 04:28:16 + "Guo, Lei" wrote: > This patch aims to add new instructions (ABCD) for M68K family. > The original TCG for M68k doesn’t include all instructions,so I intend to add > the unrealized instruction or fix wrong instructions step by step. > This instruction is realiz

Re: [Qemu-devel] [PATCH 1/2] s390x/kvm: Fix opcode decoding for eb instruction handler

2014-11-03 Thread Thomas Huth
On Mon, 3 Nov 2014 15:30:33 +0100 Cornelia Huck wrote: > From: Frank Blaschka > > The second byte of the opcode is encoded in the lowest byte of the ipb > field, not the lowest byte of the ipa field. > > Signed-off-by: Frank Blaschka > Signed-off-by: Cornelia Huck > --- > target-s390x/kvm.

Re: [Qemu-devel] [PATCH][v2] inetd enabled qemu-nbd

2014-11-03 Thread Markus Armbruster
Copying the maintainer. Please do that yourself in future patch submissions. You can list maintainers with "scripts/get_maintainer.pl --no-git-fallback *.patch". Jun Sheng writes: > run qemu-nbd as an inetd service has some benefits > * more scriptable, such as serve multiple images to differe

Re: [Qemu-devel] [RFC PATCH] target-ppc: explicitly save page table headers in big endian

2014-11-03 Thread Alexander Graf
On 27.10.14 11:23, Cédric Le Goater wrote: > Currently, when the page tables are saved, the kvm_get_htab_header structs > and the ptes are assumed being big endian and dumped as a indistinct blob > in the statefile. This is no longer true when the host is little endian > and this breaks restor

<    1   2   3   4   >