Re: [Qemu-devel] [PATCH v2 2/5] vmware-vga: add vmsvga_verify_rect

2014-10-16 Thread Don Koch
On Wed, 15 Oct 2014 12:10:36 +0200 Gerd Hoffmann wrote: > Add verification function for rectangles, returning > true if verification passes and false otherwise. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Gerd Hoffmann Reviewed-by: Don Koch > --- > hw/display/vmware_vga.c | 53 > +++

Re: [Qemu-devel] [PATCH v2 5/5] vmware-vga: use vmsvga_verify_rect in vmsvga_fill_rect

2014-10-16 Thread Don Koch
On Wed, 15 Oct 2014 12:10:39 +0200 Gerd Hoffmann wrote: > Add verification to vmsvga_fill_rect, re-enable HW_FILL_ACCEL. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Gerd Hoffmann > --- > hw/display/vmware_vga.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure during check

2014-10-16 Thread Max Reitz
Am 09.10.2014 um 01:09 schrieb Eric Blake: On 08/29/2014 03:41 PM, Max Reitz wrote: + * cluster_count clusters; therefore, we have to allocate + * cluster_count - contiguous_free_clusters new clusters at the end of + * the image (which is the current value of cluster; not

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Thu, 16 Oct 2014, Peter Maydell wrote: > On 16 October 2014 13:29, Stefano Stabellini > wrote: > > Unfortunately even though it is pretty x86 specific, it is still > > compiled on ARM, even though it is never actually used (it is used in > > i386 emulation with Xen acceleration support, while o

Re: [Qemu-devel] [PATCH v5 08/11] qcow2: Rebuild refcount structure during check

2014-10-16 Thread Eric Blake
On 10/16/2014 09:27 AM, Max Reitz wrote: >>> +memset(*refcount_table + old_nb_clusters, 0, >>> + (*nb_clusters - old_nb_clusters) * sizeof(uint16_t)); >> Is this calculation unnecessarily hard-coded to refcount_order==4? > > While now in the process of editing this patch, no

Re: [Qemu-devel] Counting barrier instructions in ARM

2014-10-16 Thread Pranith Kumar
Hi Peter, On Thu, Oct 16, 2014 at 4:05 AM, Peter Maydell wrote: > On 16 October 2014 03:45, Pranith Kumar wrote: >> The problem I am facing is that this seems to be crashing when run with a >> multi-threaded executable. > > This is nothing to do with your changes -- user-mode QEMU does not > sup

Re: [Qemu-devel] Counting barrier instructions in ARM

2014-10-16 Thread Pranith Kumar
On Wed, Oct 15, 2014 at 10:12 PM, Max Filippov wrote: > On Thu, Oct 16, 2014 at 6:00 AM, Pranith Kumar wrote: +tcg_gen_add_i32(cpu_fence_count, cpu_fence_count, 1); >>> >>> tcg_gen_addi_i32, as you're adding an immediate. >>> Enabling TCG debug would catch such errors. >>> Not sure i

Re: [Qemu-devel] [PATCH v6 30/32] target-arm: make c13 cp regs banked (FCSEIDR, ...)

2014-10-16 Thread Greg Bellows
Yes, good catch. Not sure why it did not come up in my search. Will fix in v7. Greg On 14 October 2014 22:17, Edgar E. Iglesias wrote: > On Fri, Oct 10, 2014 at 11:03:41AM -0500, Greg Bellows wrote: > > From: Fabian Aggeler > > > > When EL3 is running in AArch32 (or ARMv7 with Security Exten

Re: [Qemu-devel] [PATCH v5] numa: make 'info numa' take into account hotplugged memory

2014-10-16 Thread zhanghailiang
On 2014/10/16 20:50, Gonglei wrote: On 2014/10/16 20:02, zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Reviewed-by: Igor Mammedov Signe

Re: [Qemu-devel] [PATCH v5] numa: make 'info numa' take into account hotplugged memory

2014-10-16 Thread Gonglei
On 2014/10/17 8:45, Zhanghailiang wrote: > On 2014/10/16 20:50, Gonglei wrote: >> On 2014/10/16 20:02, zhanghailiang wrote: >> >>> When do memory hotplug, if there is numa node, we should add >>> the memory size to the corresponding node memory size. >>> >>> For now, it mainly affects the result o

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself under 'general project admin' section

2014-10-16 Thread Edgar E. Iglesias
On Wed, Oct 15, 2014 at 09:30:52PM +0100, Peter Maydell wrote: > Signed-off-by: Peter Maydell > --- > Update the 'general project admin' section to include me as > well as Anthony, given that I've been in practice doing a > bunch of said admin, and the general consensus at the QEMU > Summit yester

Re: [Qemu-devel] [PATCH v6 11/32] target-arm: add CPREG secure state support

2014-10-16 Thread Edgar E. Iglesias
On Fri, Oct 10, 2014 at 11:03:22AM -0500, Greg Bellows wrote: > From: Fabian Aggeler > > Prepare ARMCPRegInfo to support specifying two fieldoffsets per > register definition. This will allow us to keep one register > definition for banked registers (different offsets for secure/ > non-secure wor

Re: [Qemu-devel] [PATCH v5] numa: make 'info numa' take into account hotplugged memory

2014-10-16 Thread zhanghailiang
On 2014/10/17 9:06, Gonglei wrote: On 2014/10/17 8:45, Zhanghailiang wrote: On 2014/10/16 20:50, Gonglei wrote: On 2014/10/16 20:02, zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly af

[Qemu-devel] PCI passthrough device

2014-10-16 Thread Sanjay Kumar
Hi, Please let me know if I attach a drive to KVM guest using PCI pass-through, then will BDRV block layer receives IO? Thanks & Regards, Sanjay ***Legal Disclaimer*** "This communication may contain confidential and privileged material for the

Re: [Qemu-devel] [PATCH v3 2/2] monitor: add del completion for peripheral device

2014-10-16 Thread Zhu Guihua
On Thu, 2014-10-16 at 13:50 +0200, Igor Mammedov wrote: > On Mon, 6 Oct 2014 19:38:44 +0800 > Zhu Guihua wrote: > > > Add peripheral_device_del_completion() to let peripheral device del > > completion be possible. > > > > Signed-off-by: Zhu Guihua > > --- > > monitor.c | 24 +++

Re: [Qemu-devel] [PATCH 6/6] vnc: track & limit connections

2014-10-16 Thread Gonglei
On 2014/10/16 18:46, Gerd Hoffmann wrote: > Hi, > >>> I try to prevent that by dropping the *oldest* connection, so you have a >>> chance to connect even if a unprivileged attacker tries to use up all >>> connection slots. >> >> Lets say the limit is 5. The bad guy has 5 open idle connections.

Re: [Qemu-devel] [PATCH 6/6] vnc: track & limit connections

2014-10-16 Thread Daniel P. Berrange
On Fri, Oct 17, 2014 at 02:34:07PM +0800, Gonglei wrote: > On 2014/10/16 18:46, Gerd Hoffmann wrote: > > > Hi, > > > >>> I try to prevent that by dropping the *oldest* connection, so you have a > >>> chance to connect even if a unprivileged attacker tries to use up all > >>> connection slots. >

Re: [Qemu-devel] [PATCH 6/6] vnc: track & limit connections

2014-10-16 Thread Gonglei
On 2014/10/17 14:38, Daniel P. Berrange wrote: > On Fri, Oct 17, 2014 at 02:34:07PM +0800, Gonglei wrote: >> On 2014/10/16 18:46, Gerd Hoffmann wrote: >> >>> Hi, >>> > I try to prevent that by dropping the *oldest* connection, so you have a > chance to connect even if a unprivileged atta

<    1   2