[Qemu-devel] [PULL 44/47] qom: Add description field in ObjectProperty struct

2014-10-14 Thread Andreas Färber
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. Copy property descriptions when copying alias properties. Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by

[Qemu-devel] [PULL 12/47] tests: usb: Move uhci port test code to libqos/usb.c

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Move code necessary for testing uhci port into library so it could be used by other USB tests. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- tests/Makefile| 3 ++- tests/libqos/usb.c| 37

[Qemu-devel] [PULL 26/47] virtio-serial: Convert to hotplug-handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/char/virtio-serial-bus.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw

[Qemu-devel] [PULL 32/47] scsi: Convert pvscsi HBA to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/scsi/vmw_pvscsi.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 5734d19..d3a92fb

[Qemu-devel] [PULL 23/47] qdev: Drop hotplug check from bus_add_child()

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Check is too restrictive and does not allow to add children to just created bus during hotplug when the bus is part of composite device. Removing check from bus_add_child() doesn't affect devices creatable with device_add/del commands since they have a similar builtin check a

[Qemu-devel] [PULL 24/47] target-i386: ICC bus: Drop BusState::allow_hotplug

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Since bus_add_child() no longer cares if BUS is hotpluggable or not, there is no need in setting allow_hotplug field. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/cpu/icc_bus.c | 8 1 file changed, 8 deletions(-) d

Re: [Qemu-devel] [PATCH v6 30/32] target-arm: make c13 cp regs banked (FCSEIDR, ...)

2014-10-14 Thread Edgar E. Iglesias
On Fri, Oct 10, 2014 at 11:03:41AM -0500, Greg Bellows wrote: > From: Fabian Aggeler > > When EL3 is running in AArch32 (or ARMv7 with Security Extensions) > FCSEIDR, CONTEXTIDR, TPIDRURW, TPIDRURO and TPIDRPRW have a secure > and a non-secure instance. > > Signed-off-by: Fabian Aggeler > Signe

[Qemu-devel] [PULL 33/47] scsi: Convert virtio-scsi HBA to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/scsi/virtio-scsi.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/

[Qemu-devel] [PULL 27/47] virtio-mmio: Drop useless bus->allow_hotplug = 0

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Bus by default is not hotpluggable. virtio-mmio-bus and its parent types do not set allow_hotplug anywhere explicitly, so remove not needed field access and wrapper along with it. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signe

[Qemu-devel] [PULL 30/47] s390x: Convert virtio-ccw to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/s390x/virtio-ccw.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-cc

[Qemu-devel] [PULL 29/47] s390x: Convert s390-virtio to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Beside of conversion, patch drops present unplug handling, effectively disabling hot-unplug of s390-virtio devices. Signed-off-by: Igor Mammedov Reviewed-by: Cornelia Huck Signed-off-by: Andreas Färber --- hw/s390x/s390-virtio-bus.c | 10 +- 1 file changed, 5 inse

[Qemu-devel] [PULL 39/47] usb: Convert usb devices to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/usb/bus.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index da1eba9..986b2d8 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -24,10 +24,12 @@ stati

[Qemu-devel] [PULL 36/47] usb-bot: Drop not needed "allow_hotplug = 0"

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Drop useless hack that disables hotplug on bus by setting "allow_hotplug = 0". Even if bus is hotpluggable, It won't be possible to add another SCSI device to bus since its realization will fail early with error "no free target" in scsi_qdev_realize() method. Signed-off-by: I

[Qemu-devel] [PULL 37/47] usb-storage: Drop not needed "allow_hotplug = 0"

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Drop useless hack that disables hotplug on bus, after backend storage was added to it, by setting "allow_hotplug = 0". Even if bus is hotpluggable, it won't be possible to add another SCSI device to bus since its realize will fail early with error "no free target" in scsi_qdev

[Qemu-devel] [PULL 31/47] scsi: Set SCSI BUS itself as default HotplugHandler

2014-10-14 Thread Andreas Färber
From: Igor Mammedov That would allow to handle SCSI device unplug on HBAs without dedicated hot(un)plug handlers and avoid making such HBAs explicitly hotpluggable. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/scsi/scsi-bus.c | 8 +++- 1 fi

[Qemu-devel] [PULL 42/47] qdev: device_del: Search for to be unplugged device in 'peripheral' container

2014-10-14 Thread Andreas Färber
From: Igor Mammedov device_add puts every device with 'id' inside of 'peripheral' container using id's value as the last component name. Use it by replacing recursive search on sysbus with path lookup in 'peripheral' container, which could handle both BUS and BUS-less device cases. Signed-off-by

[Qemu-devel] [PULL 35/47] usb-bot: Mark device as non hotpluggable

2014-10-14 Thread Andreas Färber
From: Igor Mammedov usb-bot creates SCSI bus and immediately makes it non hotpluggable which was making not possible to hotplug usb-bot since QEMU would abort at bus_add_child(scsi-hd) time when usb-bot is realized. Mark usb-bot as not hotpluggable so that attempt to hotplug it would error out e

[Qemu-devel] [PULL 45/47] qdev: Set the object property's description to the qdev property's.

2014-10-14 Thread Andreas Färber
From: Gonglei Set all static qdev properties' descriptions to object property's description. Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/core/qdev.c | 5 + 1 file changed, 5 insertions(+)

[Qemu-devel] [PULL 43/47] qdev: Add description field in PropertyInfo struct

2014-10-14 Thread Andreas Färber
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. Cc: Markus Armbruster Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/cor

[Qemu-devel] [PULL 38/47] usb: Convert usb-ccid to hotplug handler API

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/usb/dev-smartcard-reader.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index d37ed02..78ce681 100644 --- a/hw/usb/d

[Qemu-devel] [PULL 46/47] qmp: Print descriptions of object properties

2014-10-14 Thread Andreas Färber
From: Gonglei Add a new "description" field to DevicePropertyInfo. The descriptions can serve as documentation in the code, and they can be used to provide better help. For example: $./qemu-system-x86_64 -device virtio-blk-pci,? Before this patch: virtio-blk-pci.iothread=link virtio-blk-pci.x-

[Qemu-devel] [PULL 41/47] qdev: HotplugHandler: Add support for unplugging BUS-less devices

2014-10-14 Thread Andreas Färber
From: Igor Mammedov Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- hw/core/qdev.c | 61 -- 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 3e58dd0..7685e07 100644 --- a

[Qemu-devel] [PULL 47/47] qdev: Drop legacy_name from qdev properties

2014-10-14 Thread Andreas Färber
From: Gonglei The legacy_name is useless now, better help information is provided by description field of property. Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- hw/core/qdev-properties-system.c | 4

[Qemu-devel] [PULL 40/47] qdev: Drop legacy hotplug fields/methods

2014-10-14 Thread Andreas Färber
From: Igor Mammedov It removes not needed anymore BusState::allow_hotplug field and DeviceClass::unplug callback. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev.c | 16 +++- include/hw/qdev-core.h | 5 + 2 files

[Qemu-devel] Does the event idx mechanism in virtio work in the correct way?

2014-10-14 Thread Bin Wu
Hi, The event idx in virtio is an effective way to reduce the number of interrupts and exits of the guest. When the guest puts an request into the virtio ring, it doesn't exit immediately to inform the backend. Instead, the guest checks the "avail" event idx to determine the notification. For

<    1   2