Re: [Qemu-devel] [PATCH v5 01/33] target-arm: increase arrays of registers R13 & R14

2014-10-06 Thread Greg Bellows
Fixed in v6. On 30 September 2014 16:49, Greg Bellows wrote: > From: Fabian Aggeler > > Increasing banked_r13 and banked_r14 to store LR_mon and SP_mon (bank > index 7). > > Signed-off-by: Fabian Aggeler > Reviewed-by: Edgar E. Iglesias > Signed-off-by: Greg Bellows > --- > target-arm/cpu.h

Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml

2014-10-06 Thread Peter Maydell
On 6 October 2014 20:14, David Hildenbrand wrote: > actually the questions were addressed in the last review. Haven't received any > answer from you to my reply. Maybe some mails got lost in the system. > > 32bit arm: > -"On my way through the possible architecture names > (binutils-gdb/gdb/feat

Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function

2014-10-06 Thread Greg Bellows
On 6 October 2014 09:56, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > From: Fabian Aggeler > > > > arm_is_secure() function allows to determine CPU security state > > if the CPU implements Security Extensions/EL3. > > arm_is_secure_below_el3() returns true if CPU i

Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml

2014-10-06 Thread David Hildenbrand
> On 30 September 2014 16:23, Jens Freimann wrote: > > From: David Hildenbrand > > > > This patch provides the name of the architecture in the target.xml if > > available. > > > > This allows the remote gdb to detect the target architecture on its own - so > > there is no need to specify it manu

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread Corey Minyard
On 10/06/2014 01:36 PM, Eric Blake wrote: > On 10/06/2014 11:59 AM, miny...@acm.org wrote: >> From: Corey Minyard >> >> If reconnect was set, errors wouldn't always be reported. >> Fix that and also only report a connect error once until a >> connection has been made. >> >> The primary purpose of

Re: [Qemu-devel] [PATCH v5 04/33] target-arm: rename arm_current_pl to arm_current_el

2014-10-06 Thread Greg Bellows
On 6 October 2014 10:10, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > Renamed the arm_current_pl CPU function to more accurately represent > that it > > returns the ARMv8 EL rather than ARMv7 PL. > Comment added in v6. > > > > Signed-off-by: Greg Bellows > > ---

Re: [Qemu-devel] [PATCH] gdb: provide the name of the architecture in the target.xml

2014-10-06 Thread David Hildenbrand
> On 6 October 2014 20:14, David Hildenbrand wrote: > > actually the questions were addressed in the last review. Haven't received > > any > > answer from you to my reply. Maybe some mails got lost in the system. > > > > 32bit arm: > > -"On my way through the possible architecture names > > (bi

Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function

2014-10-06 Thread Peter Maydell
On 6 October 2014 20:45, Greg Bellows wrote: > On 6 October 2014 09:56, Peter Maydell wrote: >> I checked your git tree and we don't actually use >> arm_is_secure_below_el3() anywhere except in >> arm_is_secure(), do we? That suggests to me we should >> just fold the two functions together. > > >

Re: [Qemu-devel] [PATCH v4 38/47] Add assertion to check migration_dirty_pages

2014-10-06 Thread Paolo Bonzini
Il 06/10/2014 20:51, Dr. David Alan Gilbert ha scritto: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: >>> >>> I've seen it go negative once during dev, it shouldn't >>> happen. >> >> You can move it earlier, perhaps even as patch 1,

Re: [Qemu-devel] [PATCH 1/2] qemu-char: Fix reconnect socket error reporting

2014-10-06 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 06/10/2014 20:36, Eric Blake ha scritto: >>> -qemu_chr_socket_restart_timer(chr); + >>> check_report_connect_error(chr, "Unable to connect to"); > Works in English, but if there is ever translation of the message > printed in check_report_c

[Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double free

2014-10-06 Thread Chris Spiegel
If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is freed. If "err" is not set to NULL before calling bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on error, and will be freed again. This can be triggered by starting a VM with at least two drives and then att

Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function

2014-10-06 Thread Greg Bellows
On 6 October 2014 15:07, Peter Maydell wrote: > On 6 October 2014 20:45, Greg Bellows wrote: > > On 6 October 2014 09:56, Peter Maydell wrote: > >> I checked your git tree and we don't actually use > >> arm_is_secure_below_el3() anywhere except in > >> arm_is_secure(), do we? That suggests to m

Re: [Qemu-devel] [PATCH v5 05/33] target-arm: make arm_current_pl() return PL3

2014-10-06 Thread Greg Bellows
On 6 October 2014 10:34, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > From: Fabian Aggeler > > > > Make arm_current_pl() return PL3 for secure PL1 and monitor mode. > > Increase MMU modes since mmu_index is directly infered from arm_ > > current_pl(). Changes asser

Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function

2014-10-06 Thread Peter Maydell
On 6 October 2014 21:47, Greg Bellows wrote: > > > On 6 October 2014 15:07, Peter Maydell wrote: >> You should use is_a64() rather than directly looking at >> env->aarch64, incidentally. > > > Since I am touching arm_current_el(), should I go ahead and fix it to use > is_a64() as well? Optional.

Re: [Qemu-devel] [RFC PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-06 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2014 09:03 PM, Stefan Hajnoczi wrote: > On Fri, Oct 03, 2014 at 02:12:06PM +1000, Alexey Kardashevskiy wrote: >> BDRV_O_INCOMING is only set when QEMU is about to receive migration >> and we do not want QEMU to check the file at opening time a

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-06 Thread Chen, Tiejun
Ping... Thanks Tiejun On 2014/9/30 10:43, Chen, Tiejun wrote: On 2014/9/29 18:01, Michael S. Tsirkin wrote: On Sun, Sep 28, 2014 at 10:59:05AM +0800, Chen, Tiejun wrote: On 2014/9/3 9:40, Kay, Allen M wrote: -Original Message- From: Chen, Tiejun Sent: Monday, September 01, 2014 12

[Qemu-devel] [Bug 638955] Re: emulated netcards don't work with recent sunos kernel

2014-10-06 Thread dblade
apparently it has something to do with x2apic. simply refining my cpu line to be -cpu kvm64,-x2apic leads to a working network. source of inspiration: http://forum.proxmox.com/threads/15850-Solaris-10 -Guest-no-network-traffic-after-upgrade-to-proxmox-3-1 -- You received this bug notification b

Re: [Qemu-devel] [PATCH v5 06/33] target-arm: A32: Emulate the SMC instruction

2014-10-06 Thread Greg Bellows
On 6 October 2014 10:46, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > From: Fabian Aggeler > > > > Implements SMC instruction in Aarch32 using the A32 syndrome. When > executing > > SMC instruction from monitor CPU mode SCR.NS bit is reset. > > > > Signed-off-by: S

Re: [Qemu-devel] [PATCH v5 07/33] target-arm: extend async excp masking

2014-10-06 Thread Greg Bellows
On 6 October 2014 10:53, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > From: Fabian Aggeler > > > > This patch extends arm_excp_unmasked() according to ARM ARMv7 and > > ARM ARMv8 (all EL running in Aarch32) and adds comments. > > "AA" (just do a search and replace

Re: [Qemu-devel] [PATCH v5 08/33] target-arm: add async excp target_el function

2014-10-06 Thread Greg Bellows
On 6 October 2014 11:02, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > From: Fabian Aggeler > > > > Adds a dedicated function for IRQ and FIQ exceptions to determine > > target_el and mode (Aarch32) according to tables in ARM ARMv8 and > > ARM ARM v7. > > > > Signed

Re: [Qemu-devel] [PATCH v5 09/33] target-arm: add macros to access banked registers

2014-10-06 Thread Greg Bellows
Right, we need the macros to do string concatenation so they have to be macros. That combination occurs 3 times from a quick look. I agree that it may be cumbersome to try and invent a name. Anything to do on this? On 6 October 2014 11:09, Peter Maydell wrote: > On 30 September 2014 22:49, Gr

Re: [Qemu-devel] [PATCH v5 10/33] target-arm: add non-secure Translation Block flag

2014-10-06 Thread Greg Bellows
On 6 October 2014 13:10, Sergey Fedorov wrote: > On 06.10.2014 09:13, Peter Maydell wrote: > > On 30 September 2014 22:49, Greg Bellows > wrote: > >> From: Sergey Fedorov > >> > >> This patch is based on idea found in patch at > >> git://github.com/jowinter/qemu-trustzone.git > >> f3d955c6c0ed8

Re: [Qemu-devel] [PATCH v4 00/47] Postcopy implementation

2014-10-06 Thread Cristian Klein
On 04 Oct 2014, at 4:21 , Dr. David Alan Gilbert wrote: > > I've updated our github at: > https://github.com/orbitfp7/qemu/tree/wp3-postcopy > > to have this version. > > and it corresponds to the tag: > https://github.com/orbitfp7/qemu/releases/tag/wp3-postcopy-v4 Hi Dave, I just tested thi

Re: [Qemu-devel] [PATCH v5 11/33] target-arm: arrayfying fieldoffset for banking

2014-10-06 Thread Greg Bellows
On 6 October 2014 11:19, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > From: Fabian Aggeler > > > > Prepare ARMCPRegInfo to support specifying two fieldoffsets per > > register definition. This will allow us to keep one register > > definition for banked registers (

Re: [Qemu-devel] [PATCH v5 32/33] target-arm: add GDB scr register

2014-10-06 Thread Greg Bellows
Dropped in v6 On 6 October 2014 11:27, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > Added the ability to print the scr register like can be done with the > cpsr. > > > > Signed-off-by: Greg Bellows > > Not sure you can just arbitrarily add new core registers > if

Re: [Qemu-devel] [PATCH v5 12/33] target-arm: insert Aarch32 cpregs twice into hashtable

2014-10-06 Thread Greg Bellows
On 6 October 2014 11:25, Peter Maydell wrote: > On 30 September 2014 22:49, Greg Bellows wrote: > > From: Fabian Aggeler > > > > Prepare for cp register banking by inserting every cp register twice, > > once for secure world and once for non-secure world. > > > > Signed-off-by: Fabian Aggeler

[Qemu-devel] [PATCH v5 3/5] qdev: set the object property's description to the qdev property's.

2014-10-06 Thread arei.gonglei
From: Gonglei Set all static qdev properties' descriptions to object property's description. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin --- hw/core/qdev.c | 5 + 1 file changed, 5 ins

[Qemu-devel] [PATCH v5 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-10-06 Thread arei.gonglei
From: Gonglei v5 -> v4: 1. add some improvements by Michael's suggtion, Thanks. (Michael) 2. add 'Reviewed-by' tag (Paolo, Michael, Eric) v4 -> v3: 1. rebase on qom-next tree (Andreas) 2. fix memory leak in PATCH 2, move object_property_set_description calling in object_property_add_alia

[Qemu-devel] [PATCH v5 4/5] qmp: print descriptions of object properties

2014-10-06 Thread arei.gonglei
From: Gonglei Add a new "description" field to DevicePropertyInfo. The descriptions can serve as documentation in the code, and they can be used to provide better help. For example: $./qemu-system-x86_64 -device virtio-blk-pci,? Before this patch: virtio-blk-pci.iothread=link virtio-blk-pci.x-

[Qemu-devel] [PATCH v5 1/5] qdev: add description field in PropertyInfo struct

2014-10-06 Thread arei.gonglei
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PATCH v5 5/5] qdev: drop legacy_name from qdev properties

2014-10-06 Thread arei.gonglei
From: Gonglei The legacy_name is useless now, the better help information provided by description field of property. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin --- hw/core/qdev-properties

[Qemu-devel] [PATCH v5 2/5] qom: add description field in ObjectProperty struct

2014-10-06 Thread arei.gonglei
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. Copy property descriptions when copying alias properties. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei Reviewed-by: Paolo Bonzini Rev

Re: [Qemu-devel] [PATCH] snapshot: Reset err to NULL to avoid double free

2014-10-06 Thread Markus Armbruster
Copying stable and maintainers. Chris Spiegel writes: > If an error occurs in bdrv_snapshot_delete_by_id_or_name(), "err" is > freed. If "err" is not set to NULL before calling > bdrv_snapshot_delete_by_id_or_name() again, it will not be updated on > error, and will be freed again. > > This can

[Qemu-devel] [PATCH] pcie: change confused comment clearer

2014-10-06 Thread arei.gonglei
From: Gonglei This comment applies to all functions below it. It is not appropriate that called capability allocation functions, change it into capability list management functions. Signed-off-by: Gonglei --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH v5 09/33] target-arm: add macros to access banked registers

2014-10-06 Thread Peter Maydell
On 7 October 2014 05:02, Greg Bellows wrote: > Right, we need the macros to do string concatenation so they have to be > macros. That combination occurs 3 times from a quick look. I agree that it > may be cumbersome to try and invent a name. > > Anything to do on this? Make USE_SECURE_REG into

<    1   2