[Qemu-devel] [PATCH] configure: trivial fixes

2014-09-20 Thread arei.gonglei
From: Gonglei Make them consistent with the others. Cc: qemu-triv...@nongnu.org Signed-off-by: Gonglei --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index fb194fd..8ea93fc 100755 --- a/configure +++ b/configure @@ -1349,7 +1349,7

[Qemu-devel] Looking for sponsors for Outreach Program for Women 2014 December-March

2014-09-20 Thread Stefan Hajnoczi
Dear QEMU, libvirt, and KVM communities, Thanks to mentors from our communities, we have assembled project ideas for Outreach Program for Women 2014 December-March (with more on the way!): http://qemu-project.org/Outreach_Program_for_Women_2014_DecemberMarch OPW is a program that allows women to w

[Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-20 Thread Stefan Hajnoczi
It is easy to typo a blkdebug configuration and waste a lot of time figuring out why no rules are matching. Push the Error** down into add_rule() so we can report an error when the event name is invalid. Signed-off-by: Stefan Hajnoczi --- block/blkdebug.c | 22 +++--- 1 file cha

Re: [Qemu-devel] [PATCH v2] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-09-20 Thread zhanghailiang
On 2014/9/19 21:51, Igor Mammedov wrote: On Thu, 18 Sep 2014 20:07:08 +0800 zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Signed-off-by

Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-20 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names > > It is easy to typo a blkdebug configuration and waste a lot of time > figuring out why no rules are matching. > > Push the Error** down into add_rule() so we can report an error when the > event name is invalid. >

[Qemu-devel] [Bug 1371915] [NEW] Make Uninstall Rule Requested

2014-09-20 Thread jean-christophe manciot
Public bug reported: Environment: Ubuntu 14.04 - Qemu 2.1.1 -- I've configured qemu with some --prefix, compiled the sources and installed the binaries; now, for some reason, I need to uninstall qemu to configure it with the default prefix, recompile the sources and reinstall the

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: trivial fixes

2014-09-20 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] vl: Print maxmem in hex format for error message

2014-09-20 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 1/1] qemu-img: Cannot create fixed vhdx image

2014-09-20 Thread Michael Tokarev
18.09.2014 19:17, Adelina Tuvenie wrote: > > When trying to create a fixed vhd image qemu-img will return the > following error: > > qemu-img: test.vhdx: Could not create image: Cannot allocate memory > > This happens because of a incorrect check in vhdx.c. Specifficaly, > in vhdx_create_bat(),

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pc: Add missing 'static' attribute

2014-09-20 Thread Michael Tokarev
Applied, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1] vl: Fix possible freed memory accessing

2014-09-20 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH v3 02/23] block: New BlockBackend

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: A block device consists of a frontend device model and a backend. A block backend has a tree of block drivers doing the actual work. The tree is managed by the block layer. We currently use a single abstraction BlockDriverState both for tree nodes a

Re: [Qemu-devel] [PATCH v3 03/23] block: Connect BlockBackend to BlockDriverState

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: The pointer from BlockBackend to BlockDriverState is a strong reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is a weak one. Convenience function blk_new_with_bs() creates a BlockBackend with its BlockDriverState. Callers have to

Re: [Qemu-devel] [PATCH v3 04/23] block: Connect BlockBackend and DriveInfo

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: Make the BlockBackend own the DriveInfo. Change blockdev_init() to return the BlockBackend instead of the DriveInfo. Signed-off-by: Markus Armbruster --- block.c | 2 -- block/block-backend.c | 38

Re: [Qemu-devel] [PATCH v3 05/23] block: Code motion to get rid of stubs/blockdev.c

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet --- block/block-backend.c | 15 +++ blockdev.c| 13 - include/sysemu/blockdev.h | 1 - stubs/Makefile.objs | 1 - stubs/blockdev.c

Re: [Qemu-devel] [PATCH v3 06/23] block: Make BlockBackend own its BlockDriverState

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: On BlockBackend destruction, unref its BlockDriverState. Replaces the callers' unrefs. Signed-off-by: Markus Armbruster --- block/block-backend.c | 6 ++ blockdev.c| 8 ++-- hw/block/xen_disk.c | 6 +++--- qemu-img.c

Re: [Qemu-devel] [PATCH v3 07/23] block: Eliminate bdrv_iterate(), use bdrv_next()

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet --- block-migration.c | 30 +++--- block.c | 9 - blockdev.c| 31 +-- include/block/block.h |

Re: [Qemu-devel] [PATCH v3 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: device_name[] can become non-empty only in bdrv_new_root() and bdrv_move_feature_fields(). The latter is used only to undo damage done by bdrv_swap(). The former is called only by blk_new_with_bs(). Therefore, when a BlockDriverState's device_name[]

Re: [Qemu-devel] [PATCH v3 09/23] block: Merge BlockBackend and BlockDriverState name spaces

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: BlockBackend's name space is separate only to keep the initial patches simple. Time to merge the two. Signed-off-by: Markus Armbruster Reviewed-by: Benoît Canet --- block.c | 11 +++ block/block-backend.c | 13 ++--

Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: The patch is big, but all it really does is replacing dinfo->bdrv by blk_bs(blk_by_legacy_dinfo(dinfo)) The replacement is repetitive, but the conversion of device models to BlockBackend is imminent, and will shorten it to just blk_legac

Re: [Qemu-devel] [PATCH v3 11/23] block: Rename BlockDriverAIOCB* to BlockAIOCB*

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: I'll use BlockDriverAIOCB with block backends shortly, and the name is going to fit badly there. It's a block layer thing anyway, not just a block driver thing. Signed-off-by: Markus Armbruster --- block-migration.c | 2 +- block.c

Re: [Qemu-devel] [PATCH v3 12/23] virtio-blk: Drop redundant VirtIOBlock member conf

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: Commit 12c5674 turned it into a pointer to member blk.conf. Signed-off-by: Markus Armbruster --- hw/block/virtio-blk.c | 28 ++-- include/hw/virtio/virtio-blk.h | 1 - 2 files changed, 14 insertions(+), 15 delet

Re: [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: This is consistent with how VirtIOFOOConf variables are named elsewhere, and makes blk available for BlockBackend variables. Signed-off-by: Markus Armbruster --- hw/block/dataplane/virtio-blk.c | 33 +- hw/block/dataplane/

Re: [Qemu-devel] [PATCH v3 14/23] hw: Convert from BlockDriverState to BlockBackend, mostly

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: Just four uses of BlockDriverState are left: * The Xen paravirtual block device backend (xen_disk.c) opens images itself when set up via xenbus, bypassing blockdev.c. I figure it should go through qmp_blockdev_add() instead. * Device model "u

Re: [Qemu-devel] [PATCH v3 15/23] ide: Complete conversion from BlockDriverState to BlockBackend

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: Add a BlockBackend member to TrimAIOCB, so ide_issue_trim_cb() can use blk_aio_discard() instead of bdrv_aio_discard(). Signed-off-by: Markus Armbruster --- hw/ide/core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH v3 16/23] pc87312: Drop unused members of PC87312State

2014-09-20 Thread Max Reitz
On 16.09.2014 20:12, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/hw/isa/pc87312.h | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 17/23] target-tricore: Remove the dummy interrupt boilerplate

2014-09-20 Thread Bastian Koppelmann
Thanks for the effort cleaning up the cpu-exec file. This looks good to me. I'll add it again, in the next TriCore patchset. Reviewed-by: Bastian Koppelmann On 09/13/2014 05:45 PM, Richard Henderson wrote: It can go back in when it actually does something. Cc: Bastian Koppelmann Signed-off-