Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
Hi, > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged > > Benoît Canet writes: > > >> EOF > >> --- > >> If you have feedback or questions, let us know. The process can be > >> tweaked as time goes on so we can continue to improve. > > > > Great mail. > > Yup

Re: [Qemu-devel] [PATCH 2/2] iotests: Send the correct fd in socket_scm_helper

2014-09-12 Thread Markus Armbruster
Stratos Psomadakis writes: > Make sure to pass the correct fd via SCM_RIGHTS in socket_scm_helper.c > (i.e. fd_to_send, not socket-fd). > > Signed-off-by: Stratos Psomadakis > Signed-off-by: Dimitris Aragiorgis > --- > tests/qemu-iotests/socket_scm_helper.c |2 +- > 1 file changed, 1 inser

[Qemu-devel] [PATCH] virtio-balloon: Add some trace events

2014-09-12 Thread zhanghailiang
Add some trace events for easier debugging Signed-off-by: zhanghailiang --- hw/virtio/virtio-balloon.c | 6 ++ trace-events | 4 2 files changed, 10 insertions(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 2c30b3d..112f97c 100644 --- a/hw/v

Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report

2014-09-12 Thread Markus Armbruster
writes: > From: Gonglei > > qerror_report() is a transitional interface to help with converting > existing HMP commands to QMP. It should not be used elsewhere. > > Gonglei (2): > redirect.c: Don't use qerror_report() > dev-network: Don't use qerror_report_err() > > hw/usb/dev-network.c |

Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Friday, September 12, 2014 3:11 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Huangweidong (C); kra...@redhat.com > Subject: Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report > > writes: > > > From: Gonglei > > > > qerr

[Qemu-devel] [PATCH v2 1/2] redirect.c: Don't use qerror_report()

2014-09-12 Thread arei.gonglei
From: Gonglei qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Replace by error_report(). Signed-off-by: Gonglei Reviewed-by: Markus Armbruster --- hw/usb/redirect.c | 8 1 file changed, 4 insertions(+

[Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread arei.gonglei
From: Gonglei qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. v2 -> v1: - update including head files, remove qerror.h and monitor.h, add error-report.h (Markus) - add 'Reviewed-by' tag. Gonglei (2): redi

[Qemu-devel] [PATCH v2 2/2] dev-network: Don't use qerror_report_err()

2014-09-12 Thread arei.gonglei
From: Gonglei qerror_report_err() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Signed-off-by: Gonglei Reviewed-by: Markus Armbruster --- hw/usb/dev-network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Qemu-devel] [RFC PATCH v3] Add HMP command "info memory-devices"

2014-09-12 Thread Zhu Guihua
Provides HMP equivalent of QMP query-memory-devices command. Signed-off-by: Zhu Guihua --- Changes since v2: - print address in hex. - change the loop control from while to for. - modify some variables' name. - optimize the time to print memory devices' kind. Changes since v1: - fix bug that a

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-12 Thread Bharata B Rao
On Fri, Sep 12, 2014 at 6:54 AM, Gu Zheng wrote: > Is guest os enabled acpi cpu hotplug? What's the guest's cpu info? > Please try latest QEMU, and any feedback is welcome. > Tried with latest QEMU git + your patchset and Fedora 20 guest, but QEMU monitor still shows the removed CPU. Guest kerne

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Kevin Wolf
Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: > Hi, > > > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > > merged > > > > Benoît Canet writes: > > > > >> EOF > > >> --- > > >> If you have feedback or questions, let us know. The process can be > > >> tweake

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-12 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 11:40:16AM +0200, Marc Marí wrote: > Increase the clock step to avoid Travis failure in some builds due to > overagressive timeout. > > Signed-off-by: Marc Marí > --- > tests/libqos/virtio.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stef

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-12 Thread Peter Maydell
On 12 September 2014 09:27, Stefan Hajnoczi wrote: > On Thu, Sep 11, 2014 at 11:40:16AM +0200, Marc Marí wrote: >> Increase the clock step to avoid Travis failure in some builds due to >> overagressive timeout. >> >> Signed-off-by: Marc Marí >> --- >> tests/libqos/virtio.c |4 ++-- >> 1 file

Re: [Qemu-devel] [PATCH 2/2] iotests: Send the correct fd in socket_scm_helper

2014-09-12 Thread Kevin Wolf
Am 12.09.2014 um 09:04 hat Markus Armbruster geschrieben: > Stratos Psomadakis writes: > > > Make sure to pass the correct fd via SCM_RIGHTS in socket_scm_helper.c > > (i.e. fd_to_send, not socket-fd). > > > > Signed-off-by: Stratos Psomadakis > > Signed-off-by: Dimitris Aragiorgis Thanks, app

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Friday, September 12, 2014 4:14 PM > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged > > Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: > > Hi, > > > > > Subject: Re: [Qemu-devel] New requirement for ge

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Paolo Bonzini
Il 12/09/2014 09:30, arei.gong...@huawei.com ha scritto: > From: Gonglei > > qerror_report() is a transitional interface to help with converting > existing HMP commands to QMP. It should not be used elsewhere. > > v2 -> v1: > - update including head files, remove qerror.h and monitor.h, >a

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Kevin Wolf
Am 12.09.2014 um 10:32 hat Gonglei (Arei) geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Sent: Friday, September 12, 2014 4:14 PM > > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > > merged > > > > Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben:

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 12, 2014 4:35 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); kra...@redhat.com; arm...@redhat.com > Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report > > Il

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Friday, September 12, 2014 4:46 PM > To: Gonglei (Arei) > Cc: Markus Armbruster; Benoît Canet; qemu-devel@nongnu.org; Stefan > Hajnoczi > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged > > Am 12.09.2014 um 10:

[Qemu-devel] [PATCH] ohci: Convert fprint/DPRINTF/print to traces

2014-09-12 Thread Alexey Kardashevskiy
This converts many kinds of debug prints to traces. This implements packets logging to avoid unnecessary calculations if usb_ohci_td_pkt_short/usb_ohci_td_pkt_long is not enabled. This makes OHCI errors (such as "DMA error") invisible by default. Signed-off-by: Alexey Kardashevskiy --- First

[Qemu-devel] qemu-img: unable to convert raw image > 2GB with git master

2014-09-12 Thread Mark Cave-Ayland
Hi all, I've been trying to convert a raw disk partition from my laptop for use on VMWare player and I'm seeing the following error from qemu-img git master during conversion: # qemu-img convert -f raw -O vmdk /dev/mapper/vm-raw out.vmdk qemu-img: error while writing sector 4247552: Invalid a

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Paolo Bonzini
Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: >> > Any chance you could convert USB from init to realize, instead? Then >> > you can remove the error printing altogether, and just the obsolete >> > functions. >> > > As far as I can tell, almost all devices belong to USB sub-system are > using i

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Markus Armbruster
"Gonglei (Arei)" writes: >> From: Kevin Wolf [mailto:kw...@redhat.com] [...] >> I'll probably keep reviewing paches without an R-b when they are simple >> or in my area of expertise (like qcow2), like any other reviewer should. >> The point is just that when I don't, before you ping us maintainer

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Friday, September 12, 2014 5:02 PM > To: Gonglei (Arei) > Cc: Kevin Wolf; Benoît Canet; Stefan Hajnoczi; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged > > "Gonglei (Arei)" wri

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 12, 2014 4:59 PM > Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report > > Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: > >> > Any chance you could convert USB from init to realize

Re: [Qemu-devel] [virtio-dev] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-12 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: > diff --git a/docs/specs/virtio-gpu.txt b/docs/specs/virtio-gpu.txt > new file mode 100644 > index 000..9455383 > --- /dev/null > +++ b/docs/specs/virtio-gpu.txt > @@ -0,0 +1,165 @@ > +virtio-gpu specification > +==

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Stefan Hajnoczi
On Fri, Sep 12, 2014 at 10:14:01AM +0200, Kevin Wolf wrote: > Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: > > > > Now we need a wiki entry describing the process. > > > > Also we need something reminding who is the maintainer of the current > > > week. > > > > > > Usually obvious from t

[Qemu-devel] [PATCH V2 0/7] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-09-12 Thread Gu Zheng
Previously we use cpu_added_notifiers to register cpu hotplug notifier callback which is not able to pass/handle errors, so we switch it to unified hotplug handler API which allows to pass errors and would allow to cancel device_add in case of error. Thanks very much for Igor's review and suggestio

[Qemu-devel] [PATCH V2 1/7] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-12 Thread Gu Zheng
--- v2: -add errp argument to catch error. -return error instead of aborting if cpu id is invalid. -make acpi_cpu_plug_cb as a wrapper around AcpiCpuHotplug_add. --- Signed-off-by: Gu Zheng --- hw/acpi/cpu_hotplug.c | 17 + include/hw/acpi/cpu_hotplug.h |3 +++ 2

[Qemu-devel] [PATCH V2 2/7] acpi:ich9: convert cpu hotplug handle to hotplug_handler API

2014-09-12 Thread Gu Zheng
Convert notifier based hotplug handle to hotplug_handler API. Signed-off-by: Gu Zheng --- hw/acpi/ich9.c | 14 +++--- include/hw/acpi/ich9.h |1 - 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 7b14bbb..c53d4ab 100644 -

[Qemu-devel] [PATCH V2 3/7] acpi:piix4: convert cpu hotplug handle to hotplug_handler API

2014-09-12 Thread Gu Zheng
Convert notifier based hotplug handle to hotplug_handler API, and remove the unused AcpiCpuHotplug_add(). Signed-off-by: Gu Zheng --- hw/acpi/cpu_hotplug.c | 14 ++ hw/acpi/piix4.c | 14 ++ include/hw/acpi/cpu_hotplug.h |2 -- 3 files changed

[Qemu-devel] [PATCH V2 4/7] pc: add cpu hotplug handler to PC_MACHINE

2014-09-12 Thread Gu Zheng
Add cpu hotplug handler to PC_MACHINE, which will perform the acpi cpu hotplug callback via hotplug_handler API. Signed-off-by: Gu Zheng --- hw/i386/pc.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index b6c9b61..

[Qemu-devel] [PATCH V2 5/7] pc: Update rtc_cmos in pc_cpu_plug

2014-09-12 Thread Gu Zheng
Update rtc_cmos in pc_cpu_plug directly instead of the notifier, with this change, there will no user of CPU hot-plug notifier any more, so remove it. Signed-off-by: Gu Zheng --- hw/i386/pc.c| 25 ++--- include/sysemu/sysemu.h |3 --- qom/cpu.c

[Qemu-devel] [PATCH V2 6/7] cpu-hotplug: rename function for better readability

2014-09-12 Thread Gu Zheng
Rename: AcpiCpuHotplug_init --> acpi_cpu_hotplug_init AcpiCpuHotplug_ops --> acpi_cpu_hotplug_ops for better readability, just cleanup. Signed-off-by: Gu Zheng --- hw/acpi/cpu_hotplug.c |4 ++-- hw/acpi/ich9.c|4 ++-- hw/acpi/piix4.c |4 ++-- inc

[Qemu-devel] [PATCH V2 7/7] acpi/cpu-hotplug: introduce help function to keep bit setting in one place

2014-09-12 Thread Gu Zheng
Introduce help function acpi_set_local_sts() to simplify acpi_cpu_plug_cb and acpi_cpu_hotplug_init, so that we can keep bit setting in one place. Signed-off-by: Gu Zheng --- hw/acpi/cpu_hotplug.c | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/hw/a

Re: [Qemu-devel] [PATCH v15 0/5] qcow2, raw: add preallocation=full and preallocation=falloc

2014-09-12 Thread Hu Tao
ping? On Wed, Sep 10, 2014 at 05:05:44PM +0800, Hu Tao wrote: > This series adds two preallocation mode to qcow2 and raw: > > Option preallocation=full preallocates disk space for image by writing > zeros to disk, this ensures disk space in any cases. > > Option preallocation=falloc preallocates

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-12 Thread BALATON Zoltan
On Thu, 11 Sep 2014, Gabriel L. Somlo wrote: On Thu, Sep 11, 2014 at 11:34:03PM +0200, Alexander Graf wrote: XNU also populates its device tree based on the DSDT. Maybe there's a subtle difference there? This was the low hanging fruit, so I checked it first :) Pulled the DSDT using the OS X ve

Re: [Qemu-devel] qemu-img: unable to convert raw image > 2GB with git master

2014-09-12 Thread Fam Zheng
On Fri, 09/12 09:57, Mark Cave-Ayland wrote: > Hi all, > > I've been trying to convert a raw disk partition from my laptop for use on > VMWare player and I'm seeing the following error from qemu-img git master > during conversion: > > # qemu-img convert -f raw -O vmdk /dev/mapper/vm-raw out.vmdk

[Qemu-devel] [PATCH v10 04/30] fw_cfg: add fw_cfg_machine_reset function

2014-09-12 Thread arei.gonglei
From: Gonglei We must assure that the changed bootindex can take effect when guest is rebooted. So we introduce fw_cfg_machine_reset(), which change the fw_cfg file's bootindex data using the new global fw_boot_order list. Signed-off-by: Chenliang Signed-off-by: Gonglei --- hw/nvram/fw_cfg.c

[Qemu-devel] [PATCH v10 09/30] e1000: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/e1000.c | 10 ++ 1 file changed, 10 ins

[Qemu-devel] [PATCH v10 00/30] modify boot order of guest, and take effect after rebooting

2014-09-12 Thread arei.gonglei
From: Gonglei Sometimes, we want to modify boot order of a guest, but no need to shutdown it. We can call dynamic changing bootindex of a guest, which can be assured taking effect just after the guest rebooting. For example, in P2V scene, we boot a guest and then attach a new system disk, for co

[Qemu-devel] [PATCH v10 13/30] rtl8139: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/rtl8139.c | 10 ++ 1 file changed, 10 i

[Qemu-devel] [PATCH v10 05/30] bootindex: rework add_boot_device_path function

2014-09-12 Thread arei.gonglei
From: Gonglei Add the function of updating bootindex about fw_boot_order list in add_boot_device_path(). We should delete the old one if a device has existed in global fw_boot_order list. Signed-off-by: Gonglei --- bootdevice.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bootdevice.c

[Qemu-devel] [PATCH v10 02/30] bootindex: add check bootindex function

2014-09-12 Thread arei.gonglei
From: Gonglei Determine whether a given bootindex exists or not. If exists, we report an error. Signed-off-by: Gonglei --- bootdevice.c| 15 +++ include/sysemu/sysemu.h | 1 + 2 files changed, 16 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index d5b8789..f5

[Qemu-devel] [PATCH v10 01/30] bootdevice: move bootdevice related code to new file bootdevice.c

2014-09-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- Makefile.target | 2 +- bootdevice.c| 142 include/sysemu/sysemu.h | 1 + vl.c| 118 +--- 4 files changed, 145 insertions(+),

[Qemu-devel] [PATCH v10 15/30] vmxnet3: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/vmxnet3.c | 8 1 file changed, 8 inser

[Qemu-devel] [PATCH v10 08/30] virtio-net: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/virtio-net.c | 3 +++ 1 file changed, 3 inserti

[Qemu-devel] [PATCH v10 25/30] ide: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/ide/qdev.c | 42 +++

[Qemu-devel] [PATCH v10 03/30] bootindex: add del_boot_device_path function

2014-09-12 Thread arei.gonglei
From: Gonglei Introduce del_boot_device_path() to clean up fw_cfg content when hot-unplugging a device that refers to a bootindex or update a existent devcie's bootindex. Signed-off-by: Gonglei Signed-off-by: Chenliang --- bootdevice.c| 20 include/sysemu/syse

[Qemu-devel] [PATCH v10 06/30] bootindex: support to set a existent device's bootindex to -1

2014-09-12 Thread arei.gonglei
From: Gonglei When set a device's bootindex to -1, we remove it from global fw_boot_order list. Signed-off-by: Gonglei --- bootdevice.c | 1 + 1 file changed, 1 insertion(+) diff --git a/bootdevice.c b/bootdevice.c index aac0ffb..a38479a 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -77,6 +

[Qemu-devel] [PATCH v10 07/30] bootindex: add a setter/getter functions wrapper for bootindex property

2014-09-12 Thread arei.gonglei
From: Gonglei when we remove bootindex form qdev.property to qom.property, we can use those functions set/get bootindex property for all correlative devices. Meanwhile set the initial value of bootindex to -1. Signed-off-by: Gonglei --- bootdevice.c| 73

[Qemu-devel] [PATCH v10 12/30] pcnet: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/lance.c | 12 hw/net/pcnet-pci

[Qemu-devel] [PATCH v10 28/30] ide: add calling add_boot_device_patch in bootindex setter function

2014-09-12 Thread arei.gonglei
From: Gonglei On this way, we can assure the new bootindex take effect during vm rebooting. Meanwhile set the initial value of bootindex to -1. Because ide devcies's unit property maybe do not initialize when set_bootindex function is called, so that we don't know its suffix. So we have to save

[Qemu-devel] [PATCH v10 10/30] eepro100: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/eepro100.c | 11 ++- 1 file changed, 10

[Qemu-devel] [PATCH v10 11/30] ne2000: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/ne2000.c | 12 1 file changed, 12

[Qemu-devel] [PATCH v10 26/30] virtio-blk: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/block/virtio-blk.c | 3 +++ 1 file changed, 3 inser

[Qemu-devel] [PATCH v10 14/30] spapr_lian: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/spapr_llan.c | 10 ++ 1 file changed, 1

[Qemu-devel] [PATCH v10 19/30] host-libusb: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/usb/host-libusb.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v10 16/30] usb-net: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/usb/dev-network.c | 11 +++ 1 file changed,

[Qemu-devel] [PATCH v10 24/30] scsi: add bootindex to qom property

2014-09-12 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/scsi/scsi-bus.c | 11 +++ 1 file changed, 1

[Qemu-devel] [PATCH v10 18/30] virtio-net: alias bootindex property explicitly for virt-net-pci/ccw/s390

2014-09-12 Thread arei.gonglei
From: Gonglei Since the "bootindex" property is a QOM property and not a qdev property now, we must alias it explicitly for virtio-net-pci, as well as CCW and s390-virtio. Signed-off-by: Gonglei --- hw/s390x/s390-virtio-bus.c | 2 ++ hw/s390x/virtio-ccw.c | 2 ++ hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH v10 17/30] net: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- include/net/net.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/net

[Qemu-devel] [PATCH v10 27/30] block: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/scsi/scsi-disk.c | 1 - hw/scsi/scsi-generic.c | 1 - include/hw/block/block.h | 1 - 3 f

[Qemu-devel] [PATCH v10 20/30] pci-assign: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/i386/kvm/pci-assign.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff -

[Qemu-devel] [PATCH v10 23/30] isa-fdc: remove bootindexA/B property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei Remove bootindexA/B form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/block/fdc.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH v10 22/30] redirect: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/usb/redirect.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH v10 30/30] bootindex: delete bootindex when device is removed

2014-09-12 Thread arei.gonglei
From: Gonglei Device should be removed from global boot list when it is hot-unplugged. Signed-off-by: Gonglei --- bootdevice.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index db72098..f816259 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -225,6 +225,8

[Qemu-devel] [PATCH v10 29/30] bootindex: move calling add_boot_device_patch to bootindex setter function

2014-09-12 Thread arei.gonglei
From: Gonglei On this way, we can assure the new bootindex take effect during vm rebooting. Signed-off-by: Gonglei --- bootdevice.c | 2 ++ hw/block/fdc.c | 3 --- hw/block/virtio-blk.c| 2 -- hw/i386/kvm/pci-assign.c | 2 -- hw/misc/vfio.c | 1 - hw/net/e10

[Qemu-devel] [PATCH v10 21/30] vfio: remove bootindex property from qdev to qom

2014-09-12 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/misc/vfio.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PATCH] vmdk: Fix integer overflow in offset calculation

2014-09-12 Thread Fam Zheng
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster allocation). $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k' write failed: Invalid argument Reported-by: Mark Cave-Ayland Signed-off-by: Fam Zheng --- block/vmdk.c | 2 +- tests/qemu-iotests/059

Re: [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets

2014-09-12 Thread Paolo Bonzini
Il 12/09/2014 03:39, TeLeMan ha scritto: > On Wed, Jul 9, 2014 at 5:53 PM, Paolo Bonzini wrote: >> diff --git a/aio-win32.c b/aio-win32.c >> index 4542270..61e3d2d 100644 >> --- a/aio-win32.c >> +++ b/aio-win32.c >> +bool was_dispatching, progress, have_select_revents, first; > have_select_rev

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-12 Thread Gu Zheng
Hi Bharata, On 09/12/2014 04:09 PM, Bharata B Rao wrote: > On Fri, Sep 12, 2014 at 6:54 AM, Gu Zheng wrote: >> Is guest os enabled acpi cpu hotplug? What's the guest's cpu info? >> Please try latest QEMU, and any feedback is welcome. >> > > Tried with latest QEMU git + your patchset and Fedora 2

[Qemu-devel] [PATCH] aio-win32: fix uninitialized use of have_select_revents

2014-09-12 Thread Paolo Bonzini
Always initialize it with the return value of aio_prepare. Reported-by: TeLeMan Signed-off-by: Paolo Bonzini --- aio-win32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aio-win32.c b/aio-win32.c index 61e3d2d..7daeae1 100644 --- a/aio-win32.c +++ b/aio-win32.c @@ -28

Re: [Qemu-devel] [PATCH 1/3] qapi: add visit_start_union and visit_end_union

2014-09-12 Thread Paolo Bonzini
Il 12/09/2014 01:20, Michael Roth ha scritto: > In some cases an input visitor might bail out on filling out a > struct for various reasons, such as missing fields when running > in strict mode. In the case of a QAPI Union type, this may lead > to cases where the .kind field which encodes the union

Re: [Qemu-devel] [PATCH v10 00/30] modify boot order of guest, and take effect after rebooting

2014-09-12 Thread Gerd Hoffmann
On Fr, 2014-09-12 at 17:35 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Sometimes, we want to modify boot order of a guest, but no need to > shutdown it. We can call dynamic changing bootindex of a guest, which > can be assured taking effect just after the guest rebooting. > > For e

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-12 Thread Bharata B Rao
On Fri, Sep 12, 2014 at 3:23 PM, Gu Zheng wrote: > Hi Bharata, > On 09/12/2014 04:09 PM, Bharata B Rao wrote: > >> On Fri, Sep 12, 2014 at 6:54 AM, Gu Zheng wrote: >>> Is guest os enabled acpi cpu hotplug? What's the guest's cpu info? >>> Please try latest QEMU, and any feedback is welcome. >>> >

Re: [Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-12 Thread Nikunj A Dadhania
Alex Williamson writes: > On Fri, 2014-09-12 at 10:12 +0530, Nikunj A Dadhania wrote: >> The PCI MMIO might be disabled or the device in the reset state. >> Make sure we do not dump these memory regions. >> >> Signed-off-by: Nikunj A Dadhania >> --- > > If you don't want to dump a memory region

[Qemu-devel] checkpatch.pl false positive

2014-09-12 Thread Gerd Hoffmann
Hi, Hooked up checkpatch to my testbuild-patch-series script. Catched some issues, now trapped into what I think is a false positive: ERROR: Macros with complex values should be enclosed in parenthesis #995: FILE: include/hw/virtio/virtio-gpu.h:99: +#define DEFINE_VIRTIO_GPU_PCI_PROPERTIES(_sta

Re: [Qemu-devel] checkpatch.pl false positive

2014-09-12 Thread Peter Maydell
On 12 September 2014 11:35, Gerd Hoffmann wrote: > Hi, > > Hooked up checkpatch to my testbuild-patch-series script. > Catched some issues, now trapped into what I think is a false positive: > > ERROR: Macros with complex values should be enclosed in parenthesis > #995: FILE: include/hw/virtio/v

Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file

2014-09-12 Thread Gerd Hoffmann
Hi, > > @@ -0,0 +1,158 @@ > > +#ifndef VIRTGPU_HW_H > > +#define VIRTGPU_HW_H > > Non-trivial file, deserves a copyright and license notice. Added. > > + > > +enum virtgpu_ctrl_type { > > +VIRTGPU_UNDEFINED = 0, > > + > > +/* 2d commands */ > > +VIRTGPU_CMD_GET_DISPLAY

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-12 Thread Anshul Makkar
During plugging we can see this event: echo 1 > cpu8/online. But during unplugging , we can't see the event echo 0 > cpu8/online. Just for additional check, in my code I have added following udev rule echo 0 > cpu[0-9]*/online. May be this is of any help. Thanks Anshul Makkar On Fri, Sep 12,

[Qemu-devel] [PATCH v2] Add skip_dump flag to ignore memory region during dump

2014-09-12 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania --- V1: * Make the flag generic in place of using vfio_mmap (Alex) hw/misc/vfio.c| 1 + include/exec/memory.h | 19 +++

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-12 Thread Gerd Hoffmann
Hi, > > +++ b/docs/specs/virtio-gpu.txt > > @@ -0,0 +1,165 @@ > > +virtio-gpu specification > > I know you are just following existing bad practice in this directory, > but it would be nice to declare copyright and license on this file. Added copyright for now. Dunno about license, IIRC GPLv2

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-12 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 06:44:08PM +0100, Dr. David Alan Gilbert wrote: > (I've cc'd in Fam, Stefan, and Kevin for Block stuff, and > Yang and Eddie for Colo) > > * Walid Nouri (walid.no...@gmail.com) wrote: > > Hello Michael, Hello Paolo > > i have ???studied??? the available docum

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-12 Thread Dr. David Alan Gilbert
* Hongyang Yang (yan...@cn.fujitsu.com) wrote: > > > ??? 08/01/2014 11:03 PM, Dr. David Alan Gilbert ??: > >* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > >>+static int do_colo_transaction(MigrationState *s, QEMUFile *control, > >>+ QEMUFile *trans) > >>+{ >

[Qemu-devel] [PATCHv2 1/4] BlockLimits: introduce max_transfer_length

2014-09-12 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg --- block.c |4 include/block/block_int.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/block.c b/block.c index d06dd51..c87e9fd 100644 --- a/block.c +++ b/block.c @@ -529,6 +529,7 @@ void bdrv_refr

[Qemu-devel] [PATCHv2 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-09-12 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index 965e9bc..2b9be99 100644 --- a/block.c +++ b/block.c @@ -4554,6 +4554,11 @@ static int multiwrite_merge(BlockDriverState *bs, BlockRequest *req

[Qemu-devel] [PATCHv2 3/4] block/iscsi: set max_transfer_length

2014-09-12 Thread Peter Lieven
the limit of 0xff for 16 byte CDBs is intentional to avoid overflows on 32-bit architectures. Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg --- block/iscsi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3e

[Qemu-devel] [PATCHv2 0/4] introduce max_transfer_length

2014-09-12 Thread Peter Lieven
This series adds the basics for introducing a maximum transfer length to the block layer. Its main purpose is currently avoiding that a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. This is a required bug fix. Discussed reporting of this maximum in the SCSI Disk Inquiry Emula

[Qemu-devel] [PATCHv2 2/4] block: immediately cancel oversized read/write requests

2014-09-12 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 14 ++ trace-events |2 ++ 2 files changed, 16 insertions(+) diff --git a/block.c b/block.c index c87e9fd..965e9bc 100644 --- a/block.c +++ b/block.c @@ -3215,6 +3215,13 @@ static int coroutine_fn bdrv_co_do_readv(BlockDriverState

Re: [Qemu-devel] [PATCH v3 03/47] Start documenting how postcopy works.

2014-09-12 Thread Dr. David Alan Gilbert
* Hongyang Yang (yan...@cn.fujitsu.com) wrote: > > > ??? 08/28/2014 11:03 PM, Dr. David Alan Gilbert (git) ??: > >From: "Dr. David Alan Gilbert" > > > >Signed-off-by: Dr. David Alan Gilbert > >--- > >+Postcopy can be combined with precopy (i.e. normal migration) so that if > >precopy > >

Re: [Qemu-devel] [PATCH v10 00/30] modify boot order of guest, and take effect after rebooting

2014-09-12 Thread Gonglei (Arei)
> Subject: Re: [PATCH v10 00/30] modify boot order of guest, and take effect > after rebooting > > On Fr, 2014-09-12 at 17:35 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Sometimes, we want to modify boot order of a guest, but no need to > > shutdown it. We can call dynamic cha

Re: [Qemu-devel] [virtio-dev] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt

2014-09-12 Thread Gerd Hoffmann
On Fr, 2014-09-12 at 10:10 +0100, Stefan Hajnoczi wrote: > On Thu, Sep 11, 2014 at 05:09:33PM +0200, Gerd Hoffmann wrote: > > diff --git a/docs/specs/virtio-gpu.txt b/docs/specs/virtio-gpu.txt > > new file mode 100644 > > index 000..9455383 > > --- /dev/null > > +++ b/docs/specs/virtio-gpu.txt

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-12 Thread Hongyang Yang
在 09/12/2014 07:17 PM, Dr. David Alan Gilbert 写道: * Hongyang Yang (yan...@cn.fujitsu.com) wrote: ??? 08/01/2014 11:03 PM, Dr. David Alan Gilbert ??: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: +static int do_colo_transaction(MigrationState *s, QEMUFile *control, +

Re: [Qemu-devel] [PATCH 2/4] block: immediately cancel oversized read/write requests

2014-09-12 Thread Peter Lieven
Am 08.09.2014 um 18:29 schrieb Paolo Bonzini: > Il 08/09/2014 18:18, Peter Lieven ha scritto: When copying data, gparted will try using very large I/O sizes. Of course if something breaks it will just use a smaller size, but it would make performance worse. I tried now (wi

Re: [Qemu-devel] [PATCH v2 0/9] virtio: fix virtio child recount in transports

2014-09-12 Thread Gonglei (Arei)
Ping... Any comments will be appreciated! Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, September 09, 2014 2:35 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com; stefa...@redhat.com; > Huangweidong (C); ag...@suse.de; Huangp

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-12 Thread Dr. David Alan Gilbert
* Hongyang Yang (yan...@cn.fujitsu.com) wrote: > > > ??? 09/12/2014 07:17 PM, Dr. David Alan Gilbert ??: > >* Hongyang Yang (yan...@cn.fujitsu.com) wrote: > >> > >> > >>??? 08/01/2014 11:03 PM, Dr. David Alan Gilbert ??: > >>>* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > > > > > > > >>

[Qemu-devel] [PATCH 0/2] target-arm: implement architectural breakpoints

2014-09-12 Thread Peter Maydell
Implement support for the ARM architecturally mandated hardware breakpoints, for ARMv8 and ARMv7. Tested that hardware bps work for both v7 and v8 kernels (including v8 compat userspace in a 32 bit kernel). There are a few odd subfeatures which we don't implement (yet): * address-mismatch breakpo

[Qemu-devel] [PATCH 2/2] target-arm: Implement handling of breakpoint firing

2014-09-12 Thread Peter Maydell
Implement handling of breakpoint event firing to correctly inject the debug exception into the guest. Since the breakpoint and watchpoint control register format is very similar we adjust wp_matches() to also handle breakpoints as well rather than using a separate function. Signed-off-by: Peter M

[Qemu-devel] [PATCH 1/2] target-arm: Implement setting guest breakpoints

2014-09-12 Thread Peter Maydell
This patch adds support for setting guest breakpoints based on values the guest writes to the DBGBVR and DBGBCR registers. (It doesn't include the code to handle when these breakpoints fire, so has no guest-visible effect.) Signed-off-by: Peter Maydell --- target-arm/cpu.c | 1 + target-

  1   2   3   >