Re: [Qemu-devel] [PATCH 2/3] qapi: dealloc visitor, implement visit_start_union

2014-09-11 Thread Eric Blake
On 09/11/2014 05:20 PM, Michael Roth wrote: > If the .data field of a QAPI Union is NULL, we don't need to free > any of the union fields.. intentional double dot? > > Make use of the new visit_start_union interface to access this > information and instruct the generated code to not visit these

[Qemu-devel] [PATCH 4/3] qemu-iotests: Test missing "driver" key for blockdev-add

2014-09-11 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/087 | 17 + tests/qemu-iotests/087.out | 13 + 2 files changed, 30 insertions(+) diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087 index 82c56b1..d7454d1 100755 --- a/tests/qemu-iotests/087 +++ b/tests/qem

Re: [Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union types

2014-09-11 Thread Fam Zheng
On Thu, 09/11 18:20, Michael Roth wrote: > This series introduces visit_start_enum and visit_end_enum as a way > of allowing visitors to trigger generated code to bail out on visiting > union fields if the visitor implementation deems doing so to be unsafe. > > See patch 1 for the circumstances th

Re: [Qemu-devel] [PATCH 1/2] virtio-net: drop assert on vm stop

2014-09-11 Thread Jason Wang
On 09/12/2014 12:18 AM, Michael S. Tsirkin wrote: > On vm stop, vm_running state set to stopped > before device is notified, so callbacks can get envoked with > vm_running = false; and this is not an error. This is consistent with virtio-blk which also has such kinds of callbacks. This fixes the i

Re: [Qemu-devel] [PATCH 2/2] Revert "virtio: don't call device on !vm_running"

2014-09-11 Thread Jason Wang
On 09/12/2014 12:18 AM, Michael S. Tsirkin wrote: > This reverts commit a1bc7b827e422e1ff065640d8ec5347c4aadfcd8. > virtio: don't call device on !vm_running > It turns out that virtio net assumes that vm_running > is updated before device status callback in many places, > so this change leads t

Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE

2014-09-11 Thread Gu Zheng
Hi Igor, On 09/10/2014 09:55 PM, Igor Mammedov wrote: > On Wed, 3 Sep 2014 17:06:16 +0800 > Gu Zheng wrote: > >> Add cpu hotplug handler to PC_MACHINE, which will perform the acpi >> cpu hotplug callback via hotplug_handler API. >> >> Signed-off-by: Gu Zheng >> --- >> hw/i386/pc.c | 26

Re: [Qemu-devel] [question] virtio-blk performance degradation happened with virito-serial

2014-09-11 Thread Zhang Haoyu
>>> > > If virtio-blk and virtio-serial share an IRQ, the guest operating >>> > > system has to check each virtqueue for activity. Maybe there is some >>> > > inefficiency doing that. >>> > > AFAIK virtio-serial registers 64 virtqueues (on 31 ports + console) >>> > > even if everything is unused

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-11 Thread Fam Zheng
On Tue, 09/09 14:28, Benoît Canet wrote: > On Tue, Sep 09, 2014 at 01:56:46PM +0200, Kevin Wolf wrote: > > Am 22.08.2014 um 18:11 hat Benoît Canet geschrieben: > > > Since the block layer code is starting to modify the BDS graph right in > > > the > > > middle of BDS chains (block-mirror's replace

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Alexey Kardashevskiy
On 09/11/2014 09:02 PM, Alexey Kardashevskiy wrote: > On 09/11/2014 08:38 PM, Gerd Hoffmann wrote: >> Hi, >> >>> Another question - I noticed that XHCI migration is broken in quite recent >>> upstream QEMU, smells like memory corruption. Is it just me or just PPC or >>> is it known issue? >> >> 2

Re: [Qemu-devel] [PATCH 4/3] qemu-iotests: Test missing "driver" key for blockdev-add

2014-09-11 Thread Eric Blake
On 09/11/2014 09:04 PM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/087 | 17 + > tests/qemu-iotests/087.out | 13 + > 2 files changed, 30 insertions(+) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libv

[Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-11 Thread Nikunj A Dadhania
The PCI MMIO might be disabled or the device in the reset state. Make sure we do not dump these memory regions. Signed-off-by: Nikunj A Dadhania --- hw/misc/vfio.c| 2 +- include/exec/memory.h | 27 +++ memory.c | 16 memory_mapping.

Re: [Qemu-devel] [PATCH] Skip vfio mmap bar regions during memory dump

2014-09-11 Thread Alex Williamson
On Fri, 2014-09-12 at 10:12 +0530, Nikunj A Dadhania wrote: > The PCI MMIO might be disabled or the device in the reset state. > Make sure we do not dump these memory regions. > > Signed-off-by: Nikunj A Dadhania > --- If you don't want to dump a memory region then add the ability to set a no-du

Re: [Qemu-devel] [RESEND PATCH v3 5/8] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-09-11 Thread zhanghailiang
On 2014/9/4 21:28, Igor Mammedov wrote: On Wed, 27 Aug 2014 16:08:36 +0800 Tang Chen wrote: From: Hu Tao Implement unrealize function for pc-dimm device. It delete subregion from s/delete/removes/ hotplug region, and delete ram address range from guest ram list. Signed-off-by: Hu Tao Sign

[Qemu-devel] [PATCH 2/2] rdma: Fix incorrect description in comments

2014-09-11 Thread zhanghailiang
Since we have supported memory hotplug, VM's ram include pc.ram and hotplug-memory. Fix the confused description for rdma migration: pc.ram -> VM's ram Signed-off-by: zhanghailiang --- docs/rdma.txt| 6 +++--- migration-rdma.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH 1/2] vl: Fix the confused logic for '-m' option

2014-09-11 Thread zhanghailiang
It should be valid for the follow configure: -m 256,slots=0 -m 256,maxmem=256M -m 256,slots=0,maxmem=256M -m 256,slots=x,maxmem=y where x > 0 and y > 256M Fix the confused code logic and use error_report instead of fprintf. Printing the maxmem in hex, same with ram_size. Signed-off-by: zhanghai

Re: [Qemu-devel] [RFC PATCH 11/17] COLO ctl: implement colo checkpoint protocol

2014-09-11 Thread Hongyang Yang
在 08/01/2014 11:03 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: implement colo checkpoint protocol. Checkpoint synchronzing points. Primary Secondary NEW @ Suspend

Re: [Qemu-devel] [RFC PATCH 16/17] COLO ram cache: implement colo ram cache on slaver

2014-09-11 Thread Hongyang Yang
在 08/01/2014 11:10 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: The ram cache was initially the same as PVM's memory. At checkpoint, we cache the dirty memory of PVM into ram cache (so that ram cache always the same as PVM's memory at every checkpoint), flush c

Re: [Qemu-devel] ui causes latest master build failure on rhel6

2014-09-11 Thread Gerd Hoffmann
> > pixman-0.21.8 is the oldest release which has PIXMAN_TYPE_RGBA. > > We don't check for a minimum version. > > RHEL-6 is probably older. Uhm, well, it isn't (any more): [root@rhel6 ~]# rpm -q pixman pixman-0.26.2-5.1.el6_5.x86_64 Seems to be rebased somewhen (used to be 0.16 for RHEL-6.0 IIRC

Re: [Qemu-devel] [RFC PATCH 04/17] COLO info: use colo info to tell migration target colo is enabled

2014-09-11 Thread Hongyang Yang
在 08/01/2014 10:43 PM, Dr. David Alan Gilbert 写道: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: migrate colo info to migration target to tell the target colo is enabled. If I understand this correctly this means that you send a 'colo info' device information for migrations that don't have C

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Markus Armbruster
Eric Blake writes: > On 09/11/2014 01:34 PM, Benoît Canet wrote: >> The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : >>> Benoît Canet writes: >>> > + blk_bs(blk_by_legacy_dinfo(dinfo))); This seems to be a fairly common patter

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: >> EOF >> --- >> If you have feedback or questions, let us know. The process can be >> tweaked as time goes on so we can continue to improve. > > Great mail. Yup. Let's see how it works out. > Now we need a wiki entry describing the process. > Also we need something remin

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > take effect after rebooting > > Am 11.09.2014 um 07:58 schrieb Gonglei (Arei): > >>> ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 > -drive \ > >>> file=/home/win7_32_2U,if=none,id=drive-ide0-0-0 -devi

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-11 Thread Gerd Hoffmann
Hi, > With OVMF, I have EHCI with the high-speed (and working) > keyboard+mouse, but ONLY ONE UHCI device (UHCI3). UHCI1 UHCI2 do not > get detected. Now *that* is really strange, especially as UHCI1 is pci function 0, without probing that successfully you wouldn't see the other pci functions (1

Re: [Qemu-devel] [PATCH 1/2] vl: Fix the confused logic for '-m' option

2014-09-11 Thread Li Liu
On 2014/9/12 13:58, zhanghailiang wrote: > It should be valid for the follow configure: > -m 256,slots=0 > -m 256,maxmem=256M > -m 256,slots=0,maxmem=256M > -m 256,slots=x,maxmem=y where x > 0 and y > 256M > > Fix the confused code logic and use error_report instead of fprintf. > > Printing th

Re: [Qemu-devel] [PATCH 0/2] Monitor-related fixes

2014-09-11 Thread Markus Armbruster
You neglected to cc maintainers. Stratos Psomadakis writes: > Hi, > > the first patch fixes an issue with HMP monitors, which was exposed > with v2.1.0 (commits cdaa86a and 812c10). Copying Luiz. > The second one fixes a typo in a helper C program used in > qemu-iotests. Copying Kevin and Ste

Re: [Qemu-devel] [PATCH 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED

2014-09-11 Thread Markus Armbruster
Stratos Psomadakis writes: > Commit cdaa86a54 ("Add G_IO_HUP handler for socket chardev") exposed a > bug in the way the HMP monitor handles its input. When a client closes > the connection to the monitor, tcp_chr_read() will catch the HUP > 'signal' and call tcp_chr_disconnect() to close the se

<    1   2   3