Re: [Qemu-devel] [PATCH v9 05/30] bootindex: rework add_boot_device_path function

2014-09-11 Thread Gerd Hoffmann
> +static void del_original_boot_device(DeviceState *dev, const char *suffix) Hmm, now we have two simliar delete functions. One which deletes all entries belonging to a device, and one deleting only in case the suffix matches (the later being needed to handle the floppy case I guess?). Can't we

[Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Alexey Kardashevskiy
When the guest performs kexec() (for example, as a part of kdump), new kernel does PCI probing. As a part of it, PCI_COMMAND_MASTER gets disabled which disables bus master memory region. Since ohci_frame_boundary() timer is not stopped at this point as OHCI device was not reset, the device tries ac

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Gerd Hoffmann
On Do, 2014-09-11 at 17:11 +1000, Alexey Kardashevskiy wrote: > When the guest performs kexec() (for example, as a part of kdump), > new kernel does PCI probing. As a part of it, PCI_COMMAND_MASTER > gets disabled which disables bus master memory region. > Since ohci_frame_boundary() timer is not s

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-11 Thread Paolo Bonzini
Il 10/09/2014 17:43, Walid Nouri ha scritto: > The drive-mirror (and live migration) does not rely on shared storage > and allow live block device copy and incremental syncing. I think your analysis is right. However, just for completeness I'll note that quorum doesn't need shared storage. To do

Re: [Qemu-devel] [PATCH v9 05/30] bootindex: rework add_boot_device_path function

2014-09-11 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v9 05/30] bootindex: rework add_boot_device_path > function > > > +static void del_original_boot_device(DeviceState *dev, const char *suffix) > > Hmm, now we have two simliar delete functions. One which deletes all > entries belonging to a device, and one deleting only

Re: [Qemu-devel] [RESEND RFC PATCH v2] Add HMP command "info memory-devices"

2014-09-11 Thread Markus Armbruster
Zhu Guihua writes: > This patch provides HMP equivalent of QMP query-memory-devices command. By > this command "info memory-devices", user can know all information about > hotpluggable memmory device such as id. With id of devices, hot removing > hotpluggable memory devices becomes possible by

Re: [Qemu-devel] [PATCH v6 00/22] block: Asynchronous request cancellation

2014-09-11 Thread Paolo Bonzini
Il 11/09/2014 07:41, Fam Zheng ha scritto: > v6: Drop bdrv_em_aiocb_info.cancel in patch 5. (Paolo) > > v5: Fix IDE callback. (Paolo) > Fix blkdebug. (Paolo) > Drop the DMA fix which is independent of this series. (Paolo) > Incorperate Yuan's patch on quorum_aio_cancel. (Benoît) >

Re: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery duringeoi broadcast

2014-09-11 Thread Zhang Haoyu
>> Currently, we call ioapic_service() immediately when we find the irq is still >> active during eoi broadcast. But for real hardware, there's some dealy >> between >> the EOI writing and irq delivery (system bus latency?). So we need to emulate >> this behavior. Otherwise, for a guest who haven'

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Gonglei (Arei)
> > 主题: RE: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > take > > effect after rebooting > > > > > > 主题: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > > > > take effect after rebooting > > > > > > > > From: Gonglei > > > > > > > > Sometimes, we want to modify b

[Qemu-devel] [PATCH 1/2] redirect.c: Don't use qerror_report()

2014-09-11 Thread arei.gonglei
From: Gonglei qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Replace by error_report(). Signed-off-by: Gonglei --- hw/usb/redirect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report

2014-09-11 Thread arei.gonglei
From: Gonglei qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Gonglei (2): redirect.c: Don't use qerror_report() dev-network: Don't use qerror_report_err() hw/usb/dev-network.c | 2 +- hw/usb/redirect.c

[Qemu-devel] [PATCH 2/2] dev-network: Don't use qerror_report_err()

2014-09-11 Thread arei.gonglei
From: Gonglei qerror_report_err() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. Signed-off-by: Gonglei --- hw/usb/dev-network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-network.c b/hw/us

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Alexey Kardashevskiy
On 09/11/2014 05:22 PM, Gerd Hoffmann wrote: > On Do, 2014-09-11 at 17:11 +1000, Alexey Kardashevskiy wrote: >> When the guest performs kexec() (for example, as a part of kdump), >> new kernel does PCI probing. As a part of it, PCI_COMMAND_MASTER >> gets disabled which disables bus master memory re

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-11 Thread Markus Armbruster
Eric Blake writes: > On 09/10/2014 05:03 AM, Benoît Canet wrote: >> The Wednesday 10 Sep 2014 à 10:13:30 (+0200), Markus Armbruster wrote : >>> Creating an anonymous BDS can't fail. Make that obvious. >>> >>> Signed-off-by: Markus Armbruster >>> --- > >>> /* create a new block device (by defau

Re: [Qemu-devel] [PATCH] gdbstub: init mon_chr through qemu_chr_alloc

2014-09-11 Thread Paolo Bonzini
Il 10/09/2014 16:34, Pavel Dovgalyuk ha scritto: > This patch initializes monitor for gdbstub with the qemu_chr_alloc function > instead of just allocating the memory. Initialization function call > is required, because it also creates chr_write_lock mutex, which is used > when writing to this char

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 10:13:30 (+0200), Markus Armbruster wrote : >> Creating an anonymous BDS can't fail. Make that obvious. >> >> Signed-off-by: Markus Armbruster >> --- >> block.c | 26 +++--- >> block/iscsi.c | 2 +- >

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-11 Thread Alexander Graf
On 11.09.14 04:55, Alexey Kardashevskiy wrote: > On 09/11/2014 07:17 AM, Alexander Graf wrote: >> >> >> On 10.09.14 17:00, Alexey Kardashevskiy wrote: >>> On 09/10/2014 11:03 PM, Alexander Graf wrote: On 29.08.14 12:12, Alexey Kardashevskiy wrote: > This implements DDW for VFIO

Re: [Qemu-devel] [Important] Query regarding bdrv_co_discard

2014-09-11 Thread Sanjay Kumar2
Hi Stefan, Sorry for delay in response as I was sick. Actually I have below two very important queries. Answer to both queries are valuable to me. We are planning to add block driver with the new protocol after proper testing. 1. With my new network based disk protocol, if I use 'raw' format,

[Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery duringeoi broadcast

2014-09-11 Thread Zhang Haoyu
Currently, we call ioapic_service() immediately when we find the irq is still active during eoi broadcast. But for real hardware, there's some dealy between the EOI writing and irq delivery (system bus latency?). So we need to emulate this behavior. Otherwise, for a guest who haven't register a pro

[Qemu-devel] request for wiki account, please

2014-09-11 Thread Walid Nouri

Re: [Qemu-devel] [TRIVIAL][PATCH] libqos virtio: Increase ISR timeout

2014-09-11 Thread Stefan Hajnoczi
On Tue, Sep 09, 2014 at 11:25:38AM +0200, Marc Marí wrote: > Signed-off-by: Marc Marí > --- > tests/libqos/virtio.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Missing a commit description. Please justify this patch. Why do you need to bump the clock step amount? What was f

Re: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery duringeoi broadcast

2014-09-11 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery > duringeoi broadcast > > Currently, we call ioapic_service() immediately when we find the irq is still > active during eoi broadcast. But for real hardware, there's some dealy between > the EOI writing and irq delivery

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-11 Thread Bharata B Rao
On Thu, Aug 28, 2014 at 9:06 AM, Gu Zheng wrote: > After ACPI get a signal to eject a vCPU, the vCPU must be > removed from CPU list,before the vCPU really removed, then > release the all related vCPU objects. > But we do not close KVM vcpu fd, just record it into a list, in > order to reuse it.

[Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-11 Thread Marc Marí
Increase the clock step to avoid Travis failure in some builds due to overagressive timeout. Signed-off-by: Marc Marí --- tests/libqos/virtio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c index 128dbd0..9b6de2c 100644 -

Re: [Qemu-devel] [BUG] Guest kernel divide error in kvm_unlock_kick

2014-09-11 Thread Paolo Bonzini
Il 08/09/2014 15:28, Chris Webb ha scritto: > divide error: [#1] PREEMPT SMP > Modules linked in: > CPU: 0 PID: 743 Comm: syslogd Not tainted 3.16.2-guest #2 > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS > rel-1.7.5-0-ge51488c-20140602_164612-nilsson.home.kraxel.org 04/01/2014 >

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-11 Thread Gu Zheng
On 09/11/2014 05:35 PM, Bharata B Rao wrote: > On Thu, Aug 28, 2014 at 9:06 AM, Gu Zheng wrote: >> After ACPI get a signal to eject a vCPU, the vCPU must be >> removed from CPU list,before the vCPU really removed, then >> release the all related vCPU objects. >> But we do not close KVM vcpu fd,

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-11 Thread Anshul Makkar
Bharata, this not expected. info cpus should indicate report proper number of cpus after deletion. Anshul Makkar On Thu, Sep 11, 2014 at 11:35 AM, Bharata B Rao wrote: > from

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.09.2014 um 10:13 hat Markus Armbruster geschrieben: >> A block device consists of a frontend device model and a backend. >> >> A block backend has a tree of block drivers doing the actual work. >> The tree is managed by the block layer. >> >> We currently use a single

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-11 Thread Gu Zheng
On 09/11/2014 05:35 PM, Bharata B Rao wrote: > On Thu, Aug 28, 2014 at 9:06 AM, Gu Zheng wrote: >> After ACPI get a signal to eject a vCPU, the vCPU must be >> removed from CPU list,before the vCPU really removed, then >> release the all related vCPU objects. >> But we do not close KVM vcpu fd,

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 10:13:31 (+0200), Markus Armbruster wrote : >> A block device consists of a frontend device model and a backend. >> >> A block backend has a tree of block drivers doing the actual work. >> The tree is managed by the block layer. >> >> We current

Re: [Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-11 Thread Igor Mammedov
On Thu, 11 Sep 2014 11:04:10 +0800 Gu Zheng wrote: > Hi Igor, > On 09/10/2014 09:28 PM, Igor Mammedov wrote: > > > On Wed, 3 Sep 2014 17:06:13 +0800 > > Gu Zheng wrote: > > > >> > >> Signed-off-by: Gu Zheng > >> --- > >> hw/acpi/cpu_hotplug.c | 17 + > >> include/h

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Gerd Hoffmann
Hi, > To be precise, it is kdump. Ok, kdump is a different story, radically turn off all DMA is reasonable in that case, normal driver shutdown might be unreliable after panic and it also changes system state too much for a useful dump. ohci (and probably others too, but without spamming the l

[Qemu-devel] [PATCH 0/2] virtio-scsi: Optimizing request allocation

2014-09-11 Thread Fam Zheng
Zeroing is relatively expensive since we have big request structures. VirtQueueElement (> 4k) and sense_buf (256 bytes) are two points to look at. This visibly reduces overhead of request handling when testing with the unmerged "null" driver and virtio-scsi dataplane. Before, the issue is very obv

[Qemu-devel] [PATCH 1/2] scsi: Optimize scsi_req_alloc

2014-09-11 Thread Fam Zheng
Zeroing sense buffer for each scsi request is not efficient, we can just leave it uninitialized because sense_len is set to 0. Move the implicitly zeroes fields to the end of the structure and use a partial memset. Also change g_malloc0 to g_slice_alloc. Signed-off-by: Fam Zheng --- hw/scsi/sc

[Qemu-devel] [PATCH 2/2] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-11 Thread Fam Zheng
The VirtQueueElement is a very big structure (> 4k), since it will be initialzed by virtqueue_pop, we can save the expensive zeroing here. This saves a few nanoseconds per request in my test: [fio-test] rw bs iodepthjobs bw iops latency --

Re: [Qemu-devel] [RESEND RFC PATCH v2] Add HMP command "info memory-devices"

2014-09-11 Thread Igor Mammedov
On Wed, 10 Sep 2014 16:38:09 +0800 Zhu Guihua wrote: > This patch provides HMP equivalent of QMP query-memory-devices command. By > this command "info memory-devices", user can know all information about > hotpluggable memmory device such as id. With id of devices, hot removing > hotpluggable

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.1.1 Stable released

2014-09-11 Thread Dietmar Maurer
Seems that we get a crash when we live-migrate a VMs using virtio-net-pci (vhost=on). This worked in 2.1.0. Any ideas? > I am pleased to announce that the QEMU v2.1.1 stable release is now available > at:

[Qemu-devel] [Bug 1366836] Re: Core2Duo and KVM may not boot Win8 properly on 3.x kernels

2014-09-11 Thread Erik Rull
I found a new trace - using the ipipe patch that I have, there seems to be an issue in the 3.4 kernels, but as it looks also in the 3.10 kernels. http://www.xenomai.org/pipermail/xenomai/2013-March/027865.html Is there an update on that already existing? It was not completely clear if this issue

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : >> A block device consists of a frontend device model and a backend. >> >> A block backend has a tree of block drivers doing the actual work. >> The tree is managed by the block layer. >> >> We curren

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 14:40:42 (+0200), Benoît Canet wrote : >> The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : [...] >> > diff --git a/qemu-img.c b/qemu-img.c >> > index 4490a22..bad3f64 100644 >> > --- a/qemu-img.c >> > +++ b/qemu-img.c >> >

Re: [Qemu-devel] [PATCH 06/23] block: Eliminate bdrv_states, use block_next() instead

2014-09-11 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:35 (+0200), Markus Armbruster wrote : > Signed-off-by: Markus Armbruster > --- > block.c | 43 +++ > block/block-backend.c | 4 > include/block/block_int.h | 2 -- > 3 files changed, 23 insertio

[Qemu-devel] [PATCH] PPC: openpic_kvm: Only map first occurence in address space

2014-09-11 Thread Alexander Graf
The in-kernel OpenPIC emulation only supports a single map. However, we map the OpenPIC at 2 locations: The CPU visible one and the PCI visible one. For KVM acceleration, we only care about the first one. To make sure that we only map that first mapping and not the PCI map that happens dynamically

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] PPC: openpic_kvm: Filter region callbacks based on memory region offset

2014-09-11 Thread Alexander Graf
On 11.09.14 12:14, bogdan.purcare...@freescale.com wrote: >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Wednesday, September 10, 2014 4:56 PM >> To: Purcareata Bogdan-B43198; Wood Scott-B07421 >> Cc: Caraman Mihai Claudiu-B02008; qemu-...@nongnu.org; qemu-d

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Alexey Kardashevskiy
On 09/11/2014 08:15 PM, Gerd Hoffmann wrote: > Hi, > >> To be precise, it is kdump. > > Ok, kdump is a different story, radically turn off all DMA is reasonable > in that case, normal driver shutdown might be unreliable after panic and > it also changes system state too much for a useful dump.

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Gerd Hoffmann
Hi, > Another question - I noticed that XHCI migration is broken in quite recent > upstream QEMU, smells like memory corruption. Is it just me or just PPC or > is it known issue? 2.0 -> 2.1 migration being broken is a known issue (patch for that one was on the list earlier this week, unfortunat

Re: [Qemu-devel] [PULL 0/1] xhci PCIe endpoint migration compatibility fix

2014-09-11 Thread Peter Maydell
On 10 September 2014 06:55, Gerd Hoffmann wrote: > Hi, > > Qemu 2.1.1 release is delayed a bit, so I have the chance to squeeze > in a last-minute fix for a migration compatibility bug in xhci. > > please pull, > Gerd > > The following changes since commit f102f224556f292f55b6e25147741bb8c48c9

Re: [Qemu-devel] [PATCH 07/23] block: Eliminate bdrv_iterate(), use bdrv_next()

2014-09-11 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:36 (+0200), Markus Armbruster wrote : > Signed-off-by: Markus Armbruster > --- > block-migration.c | 30 +++--- > block.c | 9 - > blockdev.c| 31 +-- > include/block/block

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] PPC: openpic_kvm: Filter region callbacks based on memory region offset

2014-09-11 Thread bogdan.purcare...@freescale.com
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Wednesday, September 10, 2014 4:56 PM > To: Purcareata Bogdan-B43198; Wood Scott-B07421 > Cc: Caraman Mihai Claudiu-B02008; qemu-...@nongnu.org; qemu-devel@nongnu.org > Subject: Re: [Qemu-ppc] [PATCH 2/2] PPC: openpi

Re: [Qemu-devel] [PATCH 03/23] block: Connect BlockBackend to BlockDriverState

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 10:13:32 (+0200), Markus Armbruster wrote : >> The pointer from BlockBackend to BlockDriverState is a strong >> reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is >> a weak one. >> >> Convenience function blk_new_with_bs() cr

Re: [Qemu-devel] [PATCH 1/2] scsi: Optimize scsi_req_alloc

2014-09-11 Thread Paolo Bonzini
Just a few nits... Il 11/09/2014 12:16, Fam Zheng ha scritto: > +uint32_t sense_len; sense_len is initialized to zero, might as well do that via memset. > +uint8_t sense[SCSI_SENSE_BUF_SIZE]; > +bool enqueued; > +bool io_canceled; > +

Re: [Qemu-devel] [PATCH 00/10] Implement ARM architectural watchpoints

2014-09-11 Thread Peter Maydell
On 29 August 2014 17:49, Richard Henderson wrote: > On 08/29/2014 04:21 AM, Peter Maydell wrote: >> Peter Maydell (10): >> exec.c: Relax restrictions on watchpoint length and alignment >> exec.c: Provide full set of dummy wp remove functions in user-mode >> exec.c: Record watchpoint fault ad

Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled

2014-09-11 Thread Alexey Kardashevskiy
On 09/11/2014 08:38 PM, Gerd Hoffmann wrote: > Hi, > >> Another question - I noticed that XHCI migration is broken in quite recent >> upstream QEMU, smells like memory corruption. Is it just me or just PPC or >> is it known issue? > > 2.0 -> 2.1 migration being broken is a known issue (patch fo

Re: [Qemu-devel] [PATCH v2 2/4] hw/arm/boot: pass an address limit to and return size from load_dtb()

2014-09-11 Thread Peter Maydell
On 10 September 2014 11:59, Ard Biesheuvel wrote: > Add an address limit input parameter to load_dtb() so that we can > tell it how much memory the dtb is allowed to consume. If the dtb > doesn't fit, return 0, otherwise return the actual size of the > loaded dtb, or -1 on error. > > Signed-off-by

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi: Optimize virtio_scsi_init_req

2014-09-11 Thread Paolo Bonzini
Similar nits to patch 1, but a good patch nevertheless! Il 11/09/2014 12:16, Fam Zheng ha scritto: > The VirtQueueElement is a very big structure (> 4k), since it will be > initialzed by virtqueue_pop, we can save the expensive zeroing here. > > This saves a few nanoseconds per request in my test

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-11 Thread Kevin Wolf
Am 10.09.2014 um 17:49 hat Benoît Canet geschrieben: > On Wed, Sep 10, 2014 at 09:14:35AM -0600, Eric Blake wrote: > > On 09/10/2014 02:54 AM, Fam Zheng wrote: > > > > >> Let's think of a situation that recursive blockers protect but > > >> backing_blocker does not: > > >> > > >> a <- b <- c <- d

Re: [Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

2014-09-11 Thread Owen Smith
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 11 September 2014 01:33 > To: Owen Smith > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabellini > Subject: Re: [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

Re: [Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-11 Thread Owen Smith
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 11 September 2014 02:01 > To: Owen Smith > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabellini > Subject: Re: [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

Re: [Qemu-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-11 Thread Owen Smith
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 11 September 2014 02:23 > To: Owen Smith > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Stefano Stabellini > Subject: Re: [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows > P

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : > device_name[] is can become non-empty only in bdrv_new_named() and > bdrv_move_feature_fields(). The latter is used only to undo damage > done by bdrv_swap(). The former is called only by blk_new_with_bs(). > Therefore, whe

Re: [Qemu-devel] [PULL v2 0/8] console: pixman conversion continued

2014-09-11 Thread Peter Maydell
On 10 September 2014 11:56, Gerd Hoffmann wrote: > Hi, > > This patch series makes the console code use pixman format codes > internally. It also adds some helper functions for gfx emulation > code. I have some wip patches for pl110 using them, but they are > not ready yet so they are not incl

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Benoît Canet
The Thursday 11 Sep 2014 à 13:34:33 (+0200), Benoît Canet wrote : > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : > > device_name[] is can become non-empty only in bdrv_new_named() and > > bdrv_move_feature_fields(). The latter is used only to undo damage > > done by bdrv

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: [...] >>> diff --git a/qemu-img.c b/qemu-img.c >>> index 4490a22..bad3f64 100644 >>> --- a/qemu-img.c >>> +++ b/qemu-img.c >> >> Won't comment on each hunk in qemu-img, but in many cases, on >> bdrv_new_open() failure, blk is leaked. > > I'll check

[Qemu-devel] [Bug 1368178] [NEW] Windows ME falsely detects qemu's videocards as Number Nine Imagine 128

2014-09-11 Thread OIiver
Public bug reported: A fresh installation of Windows Millennium Edition (Windows ME, WinME) as guest OS on qemu interprets qemu's videocards as Number Nine Imagine 128 with the consequence, that 1. It is impossible to change color depth. 2. WinME uses the i128.drv Driver that is shipped with Win

[Qemu-devel] [Bug 1368178] Re: Windows ME falsely detects qemu's videocards as Number Nine Imagine 128

2014-09-11 Thread OIiver
Here's a screenshot of the driver problem, that WinME shows up. It says error "code 23", whatever that means. ** Attachment added: "qemu_windme_number_nine_core_23.png" https://bugs.launchpad.net/qemu/+bug/1368178/+attachment/4201320/+files/qemu_windme_number_nine_core_23.png -- You receive

[Qemu-devel] [Bug 1368178] Re: Windows ME falsely detects qemu's videocards as Number Nine Imagine 128

2014-09-11 Thread OIiver
Here's a picture of the allowed color depth. As long as the videocard isn't detected properly, using another driver won't help and without another driver the color depth stays at 16 colors. ** Attachment added: "qemu_windme_color_depth_problem.png" https://bugs.launchpad.net/qemu/+bug/136817

[Qemu-devel] [Bug 1368178] Re: Windows ME falsely detects qemu's videocards as Number Nine Imagine 128

2014-09-11 Thread OIiver
In console mode, info pci gives the following information (see attachted screenshot) ** Attachment added: "qemu_windme_monitor_mode_info_pci.png" https://bugs.launchpad.net/qemu/+bug/1368178/+attachment/4201333/+files/qemu_windme_monitor_mode_info_pci.png -- You received this bug notificati

[Qemu-devel] [Bug 1361912] Re: qemu-mips64 Segmentation fault

2014-09-11 Thread Leon Alrae
Could you please provide backtrace and give more details to reproduce the issue? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1361912 Title: qemu-mips64 Segmentation fault Status in QEMU: New

Re: [Qemu-devel] [PATCH 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo()

2014-09-11 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:39 (+0200), Markus Armbruster wrote : > Signed-off-by: Markus Armbruster > --- > blockdev.c | 3 +-- > hw/arm/collie.c | 9 + > hw/arm/gumstix.c | 5 +++-- > hw/arm/mainston

Re: [Qemu-devel] [PATCH v6 08/16] hw/vfio: create common module

2014-09-11 Thread Eric Auger
On 09/10/2014 03:09 PM, Alexander Graf wrote: > > > On 09.09.14 09:31, Eric Auger wrote: >> A new common module is created. It implements all functions >> that have no device specificity (PCI, Platform). >> >> This patch only consists in move (no functional changes) >> >> Signed-off-by: Kim Phill

Re: [Qemu-devel] [PATCH v6 08/16] hw/vfio: create common module

2014-09-11 Thread Alexander Graf
On 11.09.14 14:11, Eric Auger wrote: > On 09/10/2014 03:09 PM, Alexander Graf wrote: >> >> >> On 09.09.14 09:31, Eric Auger wrote: >>> A new common module is created. It implements all functions >>> that have no device specificity (PCI, Platform). >>> >>> This patch only consists in move (no func

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Revert "vfio: Make BARs native endian"

2014-09-11 Thread Greg Kurz
On Tue, 9 Sep 2014 21:34:46 +1000 Alexey Kardashevskiy wrote: > This reverts commit c40708176a6b52b73bec14796b7c71b882ceb102. > > The idea not to swap bytes at all did not work out as MMIO interface > is defined as target host endian and it is always big-endian for PPC64 s/target host endian/t

Re: [Qemu-devel] [PATCH 11/23] block: Rename BlockDriverAIOCB* to BlockAIOCB*

2014-09-11 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:40 (+0200), Markus Armbruster wrote : > I'll use BlockDriverAIOCB with block backends shortly, and the name is > going to fit badly there. It's a block layer thing anyway, not just a > block driver thing. > > Signed-off-by: Markus Armbruster > --- > block-migra

Re: [Qemu-devel] [PULL 3/6] virtio: don't call device on !vm_running

2014-09-11 Thread Christian Borntraeger
On 04/09/14 18:38, Stefan Hajnoczi wrote: > From: "Michael S. Tsirkin" > > On vm stop, virtio changes vm_running state > too soon, so callbacks can get envoked with > vm_running = false; > > Cc: qemu-sta...@nongnu.org > Cc: Jason Wang > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Stefan

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] Enabling floating point instruction to 440x5 CPUs

2014-09-11 Thread Tom Musta
On 9/10/2014 5:43 PM, Pierre Mallard wrote: > On Wed, Sep 10, 2014 at 7:15 PM, Tom Musta > wrote: > > > (1) Eliminate the TARGET_PPC64 checks for all six FP Doubleword Integer > Conversion instructions. > > > There is also fcfids and fcfidus which leads to 8 ins

[Qemu-devel] [Bug 1368204] [NEW] WinME isn't able to detect QEMU's cdrom drive and other hard drives automatically

2014-09-11 Thread OIiver
Public bug reported: On a fresh installation of Windows Millennium (WinME) in qemu, Windows Me isn't able to find the CD-ROM drive or additional hard drives other than -hda at first place. Only if i add manually an IDE controller driver in Windows ME's device manager, the CD-ROM inserted in QEMU

Re: [Qemu-devel] [PULL 3/6] virtio: don't call device on !vm_running

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 02:19:42PM +0200, Christian Borntraeger wrote: > On 04/09/14 18:38, Stefan Hajnoczi wrote: > > From: "Michael S. Tsirkin" > > > > On vm stop, virtio changes vm_running state > > too soon, so callbacks can get envoked with > > vm_running = false; > > > > Cc: qemu-sta...@no

Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

2014-09-11 Thread Bharata B Rao
On Thu, Sep 11, 2014 at 3:23 PM, Gu Zheng wrote: > On 09/11/2014 05:35 PM, Bharata B Rao wrote: > >> On Thu, Aug 28, 2014 at 9:06 AM, Gu Zheng wrote: >>> After ACPI get a signal to eject a vCPU, the vCPU must be >>> removed from CPU list,before the vCPU really removed, then >>> release the all r

Re: [Qemu-devel] [PULL 3/6] virtio: don't call device on !vm_running

2014-09-11 Thread Christian Borntraeger
On 11/09/14 14:38, Michael S. Tsirkin wrote: >> > >> > This broke managedsave on s390x: >> > qemu-system-s390x: hw/net/virtio-net.c:1348: virtio_net_save: Assertion >> > `!n->vhost_started' failed. >> > reverting that commit makes it working again. >> > Any ideas? >> > >> > Christian > > Does i

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Andreas Färber
Am 11.09.2014 um 07:58 schrieb Gonglei (Arei): >>> ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -drive \ >>> file=/home/win7_32_2U,if=none,id=drive-ide0-0-0 -device ide-hd,bus=ide.0,\ >>> unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=1 -drive \ >>> file=/home/rhel-server-7.0-

[Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path

2014-09-11 Thread Stefan Hajnoczi
Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc ("block: Replace in_use with operation blocker") broke the error path because it consumed local_err instead of propagating it. The caller has no way to know that the function failed. This caused virtio-blk to start "successfully" even though there w

Re: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery during eoi broadcast

2014-09-11 Thread Zhang Haoyu
>> Subject: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery >> duringeoi broadcast >> >> Currently, we call ioapic_service() immediately when we find the irq is still >> active during eoi broadcast. But for real hardware, there's some dealy >> between >> the EOI writing and irq

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Eric Blake
On 09/11/2014 05:34 AM, Benoît Canet wrote: > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : >> device_name[] is can become non-empty only in bdrv_new_named() and >> bdrv_move_feature_fields(). The latter is used only to undo damage >> done by bdrv_swap(). The former is c

Re: [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path

2014-09-11 Thread Eric Blake
On 09/11/2014 06:49 AM, Stefan Hajnoczi wrote: > Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc ("block: Replace in_use > with operation blocker") broke the error path because it consumed > local_err instead of propagating it. > > The caller has no way to know that the function failed. This caus

Re: [Qemu-devel] [PATCH 0/3 RESEND] s390x: css patches and small sclp cleanup

2014-09-11 Thread Christian Borntraeger
On 05/09/14 09:33, Jens Freimann wrote: > Cornelia, Christian, Alex, > > here are two css patches and a small sclp cleanup. > > Patch 1 remove duplicate defines in SCLP code > Patch 2 adds support for format-0 ccws > Patch 3 a css bugfix adding a limit of 255 to ccws chains without data > tran

[Qemu-devel] [PATCH v2] kvm: ioapic: conditionally delay irq delivery duringeoi broadcast

2014-09-11 Thread Zhang Haoyu
Currently, we call ioapic_service() immediately when we find the irq is still active during eoi broadcast. But for real hardware, there's some dealy between the EOI writing and irq delivery (system bus latency?). So we need to emulate this behavior. Otherwise, for a guest who haven't register a pro

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-11 Thread Benoît Canet
The Thursday 11 Sep 2014 à 07:00:41 (-0600), Eric Blake wrote : > On 09/11/2014 05:34 AM, Benoît Canet wrote: > > The Wednesday 10 Sep 2014 à 10:13:37 (+0200), Markus Armbruster wrote : > >> device_name[] is can become non-empty only in bdrv_new_named() and > >> bdrv_move_feature_fields(). The lat

[Qemu-devel] [Bug 1366836] Re: Core2Duo and KVM may not boot Win8 properly on 3.x kernels

2014-09-11 Thread Erik Rull
attached the trace.dat (tar-gzipped) as recommended. Hope this helps finding the issue. The file should capture the following: - windows 8 with screen that shows that the last boot attempts failed - issued system_reset on qemu commandline - startup of windows 8 that stalls ** Attachment added: "

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.1.1 Stable released

2014-09-11 Thread Michael Roth
Quoting Dietmar Maurer (2014-09-11 04:55:05) > Seems that we get a crash when we live-migrate a VMs using virtio-net-pci > (vhost=on). > This worked in 2.1.0. Any ideas? Is this what you're seeing on the source side? qemu-system-x86_64: /home/mdroth/w/qemu3.git/hw/net/virtio-net.c:1348: virtio_

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.1.1 Stable released

2014-09-11 Thread Michael S. Tsirkin
On Thu, Sep 11, 2014 at 09:11:40AM -0500, Michael Roth wrote: > Quoting Dietmar Maurer (2014-09-11 04:55:05) > > Seems that we get a crash when we live-migrate a VMs using virtio-net-pci > > (vhost=on). > > This worked in 2.1.0. Any ideas? > > Is this what you're seeing on the source side? > > q

Re: [Qemu-devel] [PATCH v6 11/16] hw/arm/dyn_sysbus_devtree: enable vfio-calxeda-xgmac dynamic instantiation

2014-09-11 Thread Eric Auger
On 09/10/2014 03:12 PM, Alexander Graf wrote: > > > On 09.09.14 09:31, Eric Auger wrote: >> vfio-calxeda-xgmac now can be instantiated using the -device option >> >> Signed-off-by: Eric Auger >> >> --- >> >> v2 -> v3: >> - correct bug of reg_attr[2*i] in vfio_fdt_add_device_node >> - fix a bug r

[Qemu-devel] [Bug 1366836] Re: Core2Duo and KVM may not boot Win8 properly on 3.x kernels

2014-09-11 Thread Erik Rull
sorry for the corrupt file, this one should be fine now. ** Attachment added: "trace.tgz" https://bugs.launchpad.net/qemu/+bug/1366836/+attachment/4201455/+files/trace.tgz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

Re: [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path

2014-09-11 Thread Kevin Wolf
Am 11.09.2014 um 14:49 hat Stefan Hajnoczi geschrieben: > Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc ("block: Replace in_use > with operation blocker") broke the error path because it consumed > local_err instead of propagating it. > > The caller has no way to know that the function failed.

Re: [Qemu-devel] [PATCH v6 08/16] hw/vfio: create common module

2014-09-11 Thread Eric Auger
On 09/11/2014 02:13 PM, Alexander Graf wrote: > > > On 11.09.14 14:11, Eric Auger wrote: >> On 09/10/2014 03:09 PM, Alexander Graf wrote: >>> >>> >>> On 09.09.14 09:31, Eric Auger wrote: A new common module is created. It implements all functions that have no device specificity (PCI, Pl

[Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR with reason string

2014-09-11 Thread Luiz Capitulino
BLOCK_IO_ERROR events are logged by libvirt, which helps with post mortem analysis of guests. However, one information that we miss today is a human readable string describing the cause of the I/O error. This commit adds that string it to BLOCK_IO_ERROR. Note that this string is a debugging aid fo

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-11 Thread Michael Roth
Quoting Fam Zheng (2014-09-10 23:38:03) > On Wed, 09/10 22:17, Eric Blake wrote: > > On 09/10/2014 06:53 PM, Fam Zheng wrote: > > > On Wed, 09/10 17:32, Paolo Bonzini wrote: > > >> Il 10/09/2014 17:02, Fam Zheng ha scritto: > > A bit hackish, but I don't have any better idea. > > > >

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-11 Thread Paolo Bonzini
Il 11/09/2014 16:26, Michael Roth ha scritto: > Also, the .kind field of a QAPI Union type is something we generate for use > by the generated visitor code. In the case of an unspecified discriminator > we generated the enum type for that field internally. In the case where it's > specified, we use

Re: [Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR with reason string

2014-09-11 Thread Kevin Wolf
Am 11.09.2014 um 16:25 hat Luiz Capitulino geschrieben: > BLOCK_IO_ERROR events are logged by libvirt, which helps with > post mortem analysis of guests. However, one information that > we miss today is a human readable string describing the cause > of the I/O error. > > This commit adds that stri

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: [...] >>> diff --git a/blockdev.c b/blockdev.c >>> index 9fbd888..86596bc 100644 >>> --- a/blockdev.c >>> +++ b/blockdev.c [...] >>> @@ -1770,7 +1778,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict, >>> QObject **ret_data) >>> */ >>>

[Qemu-devel] [PATCH] blockdev: Refuse to drive_del something added with blockdev-add

2014-09-11 Thread Markus Armbruster
For some device models, the guest can prevent unplug. Some users need a way to forcibly revoke device model access to the block backend then, so the underlying images can be safely used for something else. drive_del lets you do that. Unfortunately, it conflates revoking access with destroying th

Re: [Qemu-devel] [RFC PATCH 1/1] TPM: Support Physical Presence Interface Spec

2014-09-11 Thread Stefan Berger
On 09/02/2014 10:27 AM, Stefan Berger wrote: From: Stefan Berger To (try to) avoid SeaBIOS from having to implement a menu for managing the various states of a TPM device, implement the TCG Physical Presence Interface Specification that allows a root user on Linux (for example) to set the opcod

  1   2   3   >