Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-10 Thread Alexander Graf
On 29.08.14 12:12, Alexey Kardashevskiy wrote: > This implements DDW for emulated PHB. > > This advertises the query/create/remove RTAS tokens in device tree. > This does not advertise the reset RTAS token though, will be added later. > > The "ddw" property is enabled by default on a PHB but fo

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-10 Thread Alexander Graf
On 29.08.14 12:12, Alexey Kardashevskiy wrote: > This implements DDW for VFIO. Host kernel support is required for this. > > After this patch DDW will be enabled on all machines but pseries-2.1. I fail to see the code that restricts DDW to pseries-2.1. Can you please point me to it? Alex

Re: [Qemu-devel] [PATCH 04/23] block: Connect BlockBackend and DriveInfo

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:33 (+0200), Markus Armbruster wrote : > Make the BlockBackend own the DriveInfo. Change blockdev_init() to > return the BlockBackend instead of the DriveInfo. > > Signed-off-by: Markus Armbruster > --- > block/block-backend.c | 38 +++ >

Re: [Qemu-devel] [PATCH v6 08/16] hw/vfio: create common module

2014-09-10 Thread Alexander Graf
On 09.09.14 09:31, Eric Auger wrote: > A new common module is created. It implements all functions > that have no device specificity (PCI, Platform). > > This patch only consists in move (no functional changes) > > Signed-off-by: Kim Phillips > Signed-off-by: Eric Auger > > --- > v5 -> v6: >

[Qemu-devel] [PATCH v8 14/30] spapr_lian: add bootindex to qom property

2014-09-10 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/spapr_llan.c | 24 1 f

Re: [Qemu-devel] [PATCH v6 11/16] hw/arm/dyn_sysbus_devtree: enable vfio-calxeda-xgmac dynamic instantiation

2014-09-10 Thread Alexander Graf
On 09.09.14 09:31, Eric Auger wrote: > vfio-calxeda-xgmac now can be instantiated using the -device option > > Signed-off-by: Eric Auger > > --- > > v2 -> v3: > - correct bug of reg_attr[2*i] in vfio_fdt_add_device_node > - fix a bug related to compat_str_len computed on original compat > i

Re: [Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 15:18:22 (+0800), Liu Yuan wrote : > On Sun, Sep 07, 2014 at 05:12:31PM +0200, Benoît Canet wrote: > > The Monday 01 Sep 2014 à 15:43:06 (+0800), Liu Yuan wrote : > > > This patch set mainly add mainly two logics to implement device recover > > > - notify qourum driver o

Re: [Qemu-devel] [RFC v1 1/6] stm32f205_timer: Add the stm32f205 SoC Timer2 to 5

2014-09-10 Thread Alistair Francis
On Wed, Sep 10, 2014 at 10:07 PM, Peter Crosthwaite wrote: > On Wed, Sep 10, 2014 at 9:52 AM, Alistair Francis > wrote: >> On Tue, Sep 9, 2014 at 10:44 PM, Peter Crosthwaite >> wrote: >>> On Tue, Sep 9, 2014 at 6:23 PM, Alistair Francis >>> wrote: This patch adds the stm32f205 timers: TI

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc : Make hreg_store_msr returns exception

2014-09-10 Thread Alexander Graf
On 05.09.14 15:45, Pierre Mallard wrote: > hreg_store_msr was both returning 0 or an exception number which could be > POWERPC_EXCP_NONE. In case POWERPC_EXCP_NONE was returned, helper_store_msr > was handling uncorrectly this return value and raise an exception. This patch > correct this beha

[Qemu-devel] [PATCH v8 17/30] net: remove bootindex property from qdev to qom

2014-09-10 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- include/net/net.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/net

[Qemu-devel] [RFC PATCH v3] Support vhd type VHD_DIFFERENCING

2014-09-10 Thread Xiaodong Gong
Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu can't read snapshot volume of vhd, and can't support other storage features of vhd file. This patch add read parent information in function "vpc_open", read bitmap in "vpc_read", and change bitmap in "vpc_write". Signed-off-by: Xi

Re: [Qemu-devel] [PATCH v6 1/3] block: Introduce "null" drivers

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 11:08:46 (+0800), Fam Zheng wrote : > This is an analogue to Linux null_blk. It can be used for testing or > benchmarking block device emulation and general block layer > functionalities such as coroutines and throttling, where disk IO is not > necessary or wanted. > >

Re: [Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-10 Thread Igor Mammedov
On Wed, 3 Sep 2014 17:06:13 +0800 Gu Zheng wrote: > > Signed-off-by: Gu Zheng > --- > hw/acpi/cpu_hotplug.c | 17 + > include/hw/acpi/cpu_hotplug.h |3 +++ > 2 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_h

[Qemu-devel] [PATCH v9 05/30] bootindex: rework add_boot_device_path function

2014-09-10 Thread arei.gonglei
From: Gonglei Add the function of updating bootindex about fw_boot_order list in add_boot_device_path(). We should delete the old one if a device has existed in global fw_boot_order list. Signed-off-by: Gonglei --- bootdevice.c | 21 + 1 file changed, 21 insertions(+) diff

Re: [Qemu-devel] [PATCH 04/23] block: Connect BlockBackend and DriveInfo

2014-09-10 Thread Kevin Wolf
Am 10.09.2014 um 10:13 hat Markus Armbruster geschrieben: > Make the BlockBackend own the DriveInfo. Change blockdev_init() to > return the BlockBackend instead of the DriveInfo. > > Signed-off-by: Markus Armbruster > --- > block/block-backend.c | 38 +++ > blockdev.c

Re: [Qemu-devel] [PATCH v6 2/3] qapi: Sort BlockdevDriver enum data list

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 11:08:47 (+0800), Fam Zheng wrote : > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index bf0cb23..35191b4 100644 > --- a/qapi/blo

[Qemu-devel] [PATCH v9 15/30] vmxnet3: add bootindex to qom property

2014-09-10 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/vmxnet3.c | 8 1 file changed, 8 inser

[Qemu-devel] [RFC PATCH v3] Support vhd type VHD_DIFFERENCING

2014-09-10 Thread Xiaodong Gong
Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu can't read snapshot volume of vhd, and can't support other storage features of vhd file. This patch add read parent information in function "vpc_open", read bitmap in "vpc_read", and change bitmap in "vpc_write". Signed-off-by: Xi

[Qemu-devel] [PATCH v9 10/30] eepro100: add bootindex to qom property

2014-09-10 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/net/eepro100.c | 11 ++- 1 file changed, 10

Re: [Qemu-devel] [PATCH v6 3/3] qapi: Sort items in BlockdevOptions definition

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 11:08:48 (+0800), Fam Zheng wrote : > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 35191b4..5

[Qemu-devel] [PATCH v9 04/30] fw_cfg: add fw_cfg_machine_reset function

2014-09-10 Thread arei.gonglei
From: Gonglei We must assure that the changed bootindex can take effect when guest is rebooted. So we introduce fw_cfg_machine_reset(), which change the fw_cfg file's bootindex data using the new global fw_boot_order list. Signed-off-by: Chenliang Signed-off-by: Gonglei --- hw/nvram/fw_cfg.c

[Qemu-devel] [PATCH v9 27/30] block: remove bootindex property from qdev to qom

2014-09-10 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/scsi/scsi-disk.c | 1 - hw/scsi/scsi-generic.c | 1 - include/hw/block/block.h | 1 - 3 f

Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-09-10 Thread Eric Auger
On 09/10/2014 12:09 PM, Alexander Graf wrote: > > > On 10.09.14 12:05, Paolo Bonzini wrote: >> Il 10/09/2014 11:56, Alexander Graf ha scritto: >>> >>> >>> On 10.09.14 11:43, Paolo Bonzini wrote: Il 10/09/2014 11:31, Alexander Graf ha scritto: >>> Yeah, please do the registration in sysbu

Re: [Qemu-devel] [RFC v1 4/6] target_arm: Update armv7_init to support more parameters

2014-09-10 Thread Alistair Francis
On Wed, Sep 10, 2014 at 10:32 PM, Martin Galvan wrote: > On Tue, Sep 9, 2014 at 8:43 PM, Alistair Francis wrote: >> On Wed, Sep 10, 2014 at 12:03 AM, Martin Galvan >> wrote: > @@ -259,7 +272,13 @@ qemu_irq *armv7m_init(MemoryRegion *system_memory, > vmstate_register_ram_global(hack)

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 14:40:42 (+0200), Benoît Canet wrote : > The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : > > A block device consists of a frontend device model and a backend. > > > > A block backend has a tree of block drivers doing the actual work. > > The tree

Re: [Qemu-devel] [RFC v1 4/6] target_arm: Update armv7_init to support more parameters

2014-09-10 Thread Martin Galvan
On Tue, Sep 9, 2014 at 8:43 PM, Alistair Francis wrote: > On Wed, Sep 10, 2014 at 12:03 AM, Martin Galvan > wrote: @@ -259,7 +272,13 @@ qemu_irq *armv7m_init(MemoryRegion *system_memory, vmstate_register_ram_global(hack); memory_region_add_subregion(system_memory, 0xf

Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE

2014-09-10 Thread Igor Mammedov
On Wed, 3 Sep 2014 17:06:16 +0800 Gu Zheng wrote: > Add cpu hotplug handler to PC_MACHINE, which will perform the acpi > cpu hotplug callback via hotplug_handler API. > > Signed-off-by: Gu Zheng > --- > hw/i386/pc.c | 26 +- > qom/cpu.c|1 - > 2 files changed

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] PPC: openpic_kvm: Filter region callbacks based on memory region offset

2014-09-10 Thread Alexander Graf
On 10.09.14 13:40, bogdan.purcare...@freescale.com wrote: >> -Original Message- >> From: Wood Scott-B07421 >> Sent: Friday, September 05, 2014 6:47 PM >> To: Purcareata Bogdan-B43198 >> Cc: qemu-...@nongnu.org; Caraman Mihai Claudiu-B02008; qemu-devel@nongnu.org >> Subject: Re: [Qemu-ppc]

Re: [Qemu-devel] [PATCH 5/5] cpu/hotplug: remove the left unused cpu hotplug notifier function

2014-09-10 Thread Igor Mammedov
On Wed, 3 Sep 2014 17:06:17 +0800 Gu Zheng wrote: > Remove the left unused cpu hotplug notifier function, and rename > AcpiCpuHotplug_init --> acpi_cpu_hotplug_init > AcpiCpuHotplug_ops --> acpi_cpu_hotplug_ops > to match the coding style. split renaming into separate patch please > > Signed-o

Re: [Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE

2014-09-10 Thread Igor Mammedov
On Wed, 3 Sep 2014 17:06:16 +0800 Gu Zheng wrote: > diff --git a/qom/cpu.c b/qom/cpu.c > index b32dd0a..af8e83f 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -304,7 +304,6 @@ static void cpu_common_realizefn(DeviceState *dev, Error > **errp) > if (dev->hotplugged) { > cpu_synch

Re: [Qemu-devel] [RFC v1 1/6] stm32f205_timer: Add the stm32f205 SoC Timer2 to 5

2014-09-10 Thread Peter Crosthwaite
On Wed, Sep 10, 2014 at 9:52 AM, Alistair Francis wrote: > On Tue, Sep 9, 2014 at 10:44 PM, Peter Crosthwaite > wrote: >> On Tue, Sep 9, 2014 at 6:23 PM, Alistair Francis >> wrote: >>> This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5 >>> to QEMU. >>> >>> Signed-off-by: Alistair F

Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse

2014-09-10 Thread Gabriel L. Somlo
Hi Gerd & Laszlo, On Wed, Sep 10, 2014 at 09:59:27AM +0200, Laszlo Ersek wrote: > On 09/10/14 08:31, Gerd Hoffmann wrote: > > > > What happens if you build ovmf with uhci but without ehci driver? Does > > that work? > > I'm glad I happened to suggest the same. ;) Commenting out MdeModulePkg/Bu

[Qemu-devel] [PATCH v8 24/30] scsi: add bootindex to qom property

2014-09-10 Thread arei.gonglei
From: Gonglei Add a qom property with the same name 'bootindex', when we remove it form qdev property, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/scsi/scsi-bus.c | 11 +++ 1 file changed, 1

Re: [Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-09-10 Thread Igor Mammedov
On Wed, 3 Sep 2014 17:06:12 +0800 Gu Zheng wrote: > > Gu Zheng (5): > acpi/cpu: add cpu hotplug callback function to match hotplug_handler > API > acpi:ich9: convert cpu hotplug handle to hotplug_handler API > acpi:piix4: convert cpu hotplug handle to hotplug_handler API > pc: add c

[Qemu-devel] [PATCH v9 21/30] vfio: remove bootindex property from qdev to qom

2014-09-10 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/misc/vfio.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PATCH v8 22/30] redirect: remove bootindex property from qdev to qom

2014-09-10 Thread arei.gonglei
From: Gonglei Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei --- hw/usb/redirect.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-10 Thread Benoît Canet
On Wed, Sep 10, 2014 at 04:54:19PM +0800, Fam Zheng wrote: > On Thu, 09/04 21:42, Stefan Hajnoczi wrote: > > On Tue, Aug 26, 2014 at 06:45:54AM +, Benoît Canet wrote: > > > On Tue, Aug 26, 2014 at 12:42:04PM +0800, Fam Zheng wrote: > > > > On Mon, 08/25 12:12, Benoît Canet wrote: > > > > > On M

Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-09-10 Thread Paolo Bonzini
Il 10/09/2014 15:51, Eric Auger ha scritto: > On 09/10/2014 12:09 PM, Alexander Graf wrote: >> >> >> On 10.09.14 12:05, Paolo Bonzini wrote: >>> Il 10/09/2014 11:56, Alexander Graf ha scritto: On 10.09.14 11:43, Paolo Bonzini wrote: > Il 10/09/2014 11:31, Alexander Graf ha scritt

[Qemu-devel] [PATCH] gdbstub: init mon_chr through qemu_chr_alloc

2014-09-10 Thread Pavel Dovgalyuk
This patch initializes monitor for gdbstub with the qemu_chr_alloc function instead of just allocating the memory. Initialization function call is required, because it also creates chr_write_lock mutex, which is used when writing to this character device. Signed-off-by: Pavel Dovgalyuk --- gdbst

Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-09-10 Thread Alexander Graf
> Am 10.09.2014 um 16:18 schrieb Paolo Bonzini : > > Il 10/09/2014 15:51, Eric Auger ha scritto: >>> On 09/10/2014 12:09 PM, Alexander Graf wrote: >>> >>> On 10.09.14 12:05, Paolo Bonzini wrote: Il 10/09/2014 11:56, Alexander Graf ha scritto: > > >> On 10.09.14 11:43, P

Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-09-10 Thread Paolo Bonzini
Il 10/09/2014 16:38, Alexander Graf ha scritto: >> > I don't think so, but maybe I misunderstood what Alex wrote. > I still think it shouldn't be inside the sysbus files. You can use sysbus > devices without a platform bus. If you want to separate the files, that's fine. It should still be in hw

Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-10 Thread Alexey Kardashevskiy
On 09/10/2014 11:01 PM, Alexander Graf wrote: > > > On 29.08.14 12:12, Alexey Kardashevskiy wrote: >> This implements DDW for emulated PHB. >> >> This advertises the query/create/remove RTAS tokens in device tree. >> This does not advertise the reset RTAS token though, will be added later. >> >>

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-10 Thread Alexey Kardashevskiy
On 09/10/2014 11:03 PM, Alexander Graf wrote: > > > On 29.08.14 12:12, Alexey Kardashevskiy wrote: >> This implements DDW for VFIO. Host kernel support is required for this. >> >> After this patch DDW will be enabled on all machines but pseries-2.1. > > I fail to see the code that restricts DDW

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Fam Zheng
On Wed, 09/10 15:01, Paolo Bonzini wrote: > Il 10/09/2014 14:30, Fam Zheng ha scritto: > > We shouldn't do anything in the switch block in enum's visit_type_ > > function, when the enum data's ->kind is not valid at all. This happens > > when the dealloc visitor is called, after qmp input visitor r

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Eric Blake
On 09/10/2014 05:03 AM, Benoît Canet wrote: > The Wednesday 10 Sep 2014 à 10:13:30 (+0200), Markus Armbruster wrote : >> Creating an anonymous BDS can't fail. Make that obvious. >> >> Signed-off-by: Markus Armbruster >> --- >> /* create a new block device (by default it is empty) */ >> -BlockDr

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Eric Blake
On 09/10/2014 02:13 AM, Markus Armbruster wrote: > Creating an anonymous BDS can't fail. Make that obvious. > > Signed-off-by: Markus Armbruster > --- > block.c | 26 +++--- > block/iscsi.c | 2 +- > block/vvfat.c | 2 +- > blockdev.c

Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Update OPC_SYNCI

2014-09-10 Thread Yongbok Kim
Reviewed-by: Yongbok Kim Note that there is a microMIPS version of SYNCI, it would be even better if you could update it as well. Best Regards, Yongbok Kim -Original Message- From: qemu-devel-bounces+yongbok.kim=imgtec@nongnu.org [mailto:qemu-devel-bounces+yongbok.kim=imgtec@

Re: [Qemu-devel] [PATCH 1/2] target-mips: Add synci instruction test

2014-09-10 Thread Yongbok Kim
Tested-by: Yongbok Kim -Original Message- From: qemu-devel-bounces+yongbok.kim=imgtec@nongnu.org [mailto:qemu-devel-bounces+yongbok.kim=imgtec@nongnu.org] On Behalf Of Dongxue Zhang Sent: Tuesday, July 29, 2014 2:48 PM To: qemu-devel@nongnu.org Cc: peter.mayd...@linaro.org; Don

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-10 Thread Eric Blake
On 09/10/2014 02:54 AM, Fam Zheng wrote: >> Let's think of a situation that recursive blockers protect but >> backing_blocker does not: >> >> a <- b <- c <- d >> >> c is the backing file and is therefore protected by the op blocker. >> >> The block-commit command works with node-names, however, so

Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-09-10 Thread Alexander Graf
> Am 10.09.2014 um 16:39 schrieb Paolo Bonzini : > > Il 10/09/2014 16:38, Alexander Graf ha scritto: I don't think so, but maybe I misunderstood what Alex wrote. >> I still think it shouldn't be inside the sysbus files. You can use sysbus >> devices without a platform bus. > > If you want

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:30 (+0200), Markus Armbruster wrote : > Creating an anonymous BDS can't fail. Make that obvious. > > Signed-off-by: Markus Armbruster > --- > block.c | 26 +++--- > block/iscsi.c | 2 +- > block/vvfat.c | 2 +-

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Paolo Bonzini
Il 10/09/2014 17:02, Fam Zheng ha scritto: > > A bit hackish, but I don't have any better idea. > > > > Hmm... what about adding a new member to the visitors for "invalid enum" > > value? The dealloc visitor could override it to do nothing, while the > > default could abort or set an error. Woul

Re: [Qemu-devel] [PATCH v3 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-10 Thread Greg Bellows
We also have v4 of the TZ patches which do provide 32-bit EL3 support, but not EL2. Maybe good to align with this code as well. http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg07347.html On 9 September 2014 16:59, Peter Maydell wrote: > On 9 September 2014 22:51, Ard Biesheuvel > wro

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-10 Thread Walid Nouri
Hello Michael, Hello Paolo i have „studied“ the available documentation/Information and tried to get an idea of the QEMU live block operation possibilities. I think the MC protocol doesn’t need synchronous block device replication because primary and secondary VM are not synchronous. The stat

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-10 Thread Benoît Canet
On Wed, Sep 10, 2014 at 09:14:35AM -0600, Eric Blake wrote: > On 09/10/2014 02:54 AM, Fam Zheng wrote: > > >> Let's think of a situation that recursive blockers protect but > >> backing_blocker does not: > >> > >> a <- b <- c <- d > >> > >> c is the backing file and is therefore protected by the o

Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[]

2014-09-10 Thread Eric Blake
On 09/10/2014 02:13 AM, Markus Armbruster wrote: > device_name[] is can become non-empty only in bdrv_new_named() and s/is // > bdrv_move_feature_fields(). The latter is used only to undo damage > done by bdrv_swap(). The former is called only by blk_new_with_bs(). > Therefore, when a BlockDriv

Re: [Qemu-devel] [PATCH v3 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-10 Thread Ard Biesheuvel
On 10 September 2014 17:42, Greg Bellows wrote: > We also have v4 of the TZ patches which do provide 32-bit EL3 support, but > not EL2. Maybe good to align with this code as well. > > http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg07347.html > As far as I can tell, there is very little

Re: [Qemu-devel] [PATCH v3 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-10 Thread Peter Maydell
On 10 September 2014 17:13, Ard Biesheuvel wrote: > As far as I can tell, there is very little overlap, only patch 8/33 > contains some stuff that we added as well. > I expect PSCI handling and emulation of hvc and/or smc to be mutually > exclusive, nothing we won't be able to handle with a couple

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3] target-ppc : Add PPC_FLOAT_64 flag to instructions type

2014-09-10 Thread Tom Musta
On 9/10/2014 4:18 AM, Alexander Graf wrote: > > > On 10.09.14 07:03, Pierre Mallard wrote: >> This patch declare a new floating point instruction flag PPC_FLOAT_64 to be >> used >> by fcfid, fctid[z] operations. Note that due to limited number of bit, >> FSEL and FRES points now to same value,

Re: [Qemu-devel] [PATCH v3 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-10 Thread Greg Bellows
No problem, just wanted to point it out in case it helps. Greg On 10 September 2014 11:13, Ard Biesheuvel wrote: > On 10 September 2014 17:42, Greg Bellows wrote: > > We also have v4 of the TZ patches which do provide 32-bit EL3 support, > but > > not EL2. Maybe good to align with this code a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] target-ppc : Add PPC_FLOAT_64 type to fctid, fctidz and fcfid and remove their TARGET_PPC64 restriction

2014-09-10 Thread Tom Musta
On 9/10/2014 4:19 AM, Alexander Graf wrote: > > > On 10.09.14 07:03, Pierre Mallard wrote: >> Apply the new PPC_FLOAT_64 flag to fctid[z] and fcfid. >> May also be applyed to fctidu[z] and fcfid[su][z], but since they are not >> mentionned in xilinx documentation it might not be needed yet. >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] Enabling floating point instruction to 440x5 CPUs

2014-09-10 Thread Tom Musta
On 9/10/2014 4:20 AM, Alexander Graf wrote: > > > On 10.09.14 07:03, Pierre Mallard wrote: >> This patch series enable floating point instruction in 440x5 CPUs >> which have the capabilities to have optional APU FPU. >> >> 1) Add floating point standard insns flag to 440x5 in case there is an ap

[Qemu-devel] [PATCH v2] virtio-pci: enable bus master for old guests

2014-09-10 Thread Michael S. Tsirkin
commit cc943c36faa192cd4b32af8fe5edb31894017d35 pci: Use bus master address space for delivering MSI/MSI-X messages breaks virtio-net for rhel6.[56] x86 guests because they don't enable bus mastering for virtio PCI devices Old guests forgot to enable bus mastering, enable it automatically when

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] Enabling floating point instruction to 440x5 CPUs

2014-09-10 Thread Pierre Mallard
Thanks for your review Alexander and Tom. All your proposition looks fine to me. Xilinx Virtex5 is not ISA compliant and does not support unsigned conversions, that's why I left all unsigned version as it was but you are right, PPC_FLOAT_64 is such a bad name ! Adding this flag to all CPU seems ok

[Qemu-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-10 Thread Owen smith
Windows PV frontend requires absolute mouse values in the range [0, 0x7fff]. Add a feature to not rescale the axes to DisplaySurface size. Also allows Windows PV frontend to connect without a vfb device. Moves the rescaling of axes to a seperate function with additional null-pointer checks. Signed

[Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

2014-09-10 Thread Owen smith
Keyboard event handler was replaced with a new handler on disconnect. Use the unregister function to remove keyboard handler. Signed-off-by: Owen smith --- hw/display/xenfb.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.

[Qemu-devel] [PATCH 0/3] xenfb: Add support for Windows PV frontend

2014-09-10 Thread Owen smith
This patch series contains improvments for the Xen vkbd backend to support a Windows PV frontend mouse and keyboard. This allows VNC connections to have an absolute pointer without the USB tablet device enabled, and any unneccessary polling associated with the USB devices. This patch series conta

[Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-10 Thread Owen smith
The vkbd device should be able to use a grant reference to map the shared page. Signed-off-by: Owen smith --- hw/display/xenfb.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 2c39753..c4

Re: [Qemu-devel] [Xen-devel] [RFC Patch v3 23/22] Introduce "xen-load-devices-state"

2014-09-10 Thread Stefano Stabellini
On Tue, 9 Sep 2014, Wen Congyang wrote: > At 09/06/2014 05:57 AM, Stefano Stabellini Write: > > On Fri, 5 Sep 2014, Wen Congyang wrote: > >> introduce a "xen-load-devices-state" QAPI command that can be used to load > >> the state of all devices, but not the RAM or the block devices of the > >> VM.

[Qemu-devel] [ANNOUNCE] QEMU 2.1.1 Stable released

2014-09-10 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v2.1.1 stable release is now available at: http://wiki.qemu.org/download/qemu-2.1.1.tar.bz2 v2.1.1 is now tagged in the official qemu.git repository, and the stable-2.1 branch has been updated accordingly: http://git.qemu.org/?p=qemu.git;a

Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-10 Thread Alexander Graf
On 10.09.14 16:58, Alexey Kardashevskiy wrote: > On 09/10/2014 11:01 PM, Alexander Graf wrote: >> >> >> On 29.08.14 12:12, Alexey Kardashevskiy wrote: >>> This implements DDW for emulated PHB. >>> >>> This advertises the query/create/remove RTAS tokens in device tree. >>> This does not advertise

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-10 Thread Alexander Graf
On 10.09.14 17:00, Alexey Kardashevskiy wrote: > On 09/10/2014 11:03 PM, Alexander Graf wrote: >> >> >> On 29.08.14 12:12, Alexey Kardashevskiy wrote: >>> This implements DDW for VFIO. Host kernel support is required for this. >>> >>> After this patch DDW will be enabled on all machines but pseri

Re: [Qemu-devel] [PATCH 01/23] block: Split bdrv_new_named() off bdrv_new()

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:30 (+0200), Markus Armbruster wrote : > Creating an anonymous BDS can't fail. Make that obvious. > > Signed-off-by: Markus Armbruster > --- > block.c | 26 +++--- > block/iscsi.c | 2 +- > block/vvfat.c | 2 +-

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] Enabling floating point instruction to 440x5 CPUs

2014-09-10 Thread Pierre Mallard
On Wed, Sep 10, 2014 at 7:15 PM, Tom Musta wrote: > > (1) Eliminate the TARGET_PPC64 checks for all six FP Doubleword Integer > Conversion instructions. > There is also fcfids and fcfidus which leads to 8 instructions (fcfid, fcfids, fcfidu, fcfidus and fctid, fctidz, fctidu, fctiduz), is this r

Re: [Qemu-devel] [edk2] OVMF, Q35 and USB keyboard/mouse

2014-09-10 Thread Paolo Bonzini
Il 10/09/2014 16:06, Gabriel L. Somlo ha scritto: > If it's in QEMU, it's only tickled by the OVMF + OSX combination. > Fedora works (around it) fine, and everyone's happy when using > SeaBIOS (and Chameleon, in OSX's case). > > BTW, when I do something like this: > > -usb -device ich9-usb-uhci1,

Re: [Qemu-devel] [PATCH 1/3] xenfb: Unregister keyboard event handler correctly

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > Keyboard event handler was replaced with a new handler on disconnect. > Use the unregister function to remove keyboard handler. > > Signed-off-by: Owen smith > --- > hw/display/xenfb.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-10 Thread Fam Zheng
On Wed, 09/10 09:14, Eric Blake wrote: > On 09/10/2014 02:54 AM, Fam Zheng wrote: > > >> Let's think of a situation that recursive blockers protect but > >> backing_blocker does not: > >> > >> a <- b <- c <- d > >> > >> c is the backing file and is therefore protected by the op blocker. > >> > >>

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Fam Zheng
On Wed, 09/10 17:32, Paolo Bonzini wrote: > Il 10/09/2014 17:02, Fam Zheng ha scritto: > > > A bit hackish, but I don't have any better idea. > > > > > > Hmm... what about adding a new member to the visitors for "invalid enum" > > > value? The dealloc visitor could override it to do nothing, whil

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Michael Roth
Quoting Fam Zheng (2014-09-10 07:30:39) > We shouldn't do anything in the switch block in enum's visit_type_ > function, when the enum data's ->kind is not valid at all. This happens > when the dealloc visitor is called, after qmp input visitor returned > error. Comment is kind of confusing. Enum

[Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator

2014-09-10 Thread Michael Roth
This more an exercise of the dealloc visitor, where it may erroneously use an uninitialized discriminator field as indication that union fields corresponding to that disciminator field/type are present, which can lead to attempts to free random chunks of heap memory. Signed-off-by: Michael Roth -

Re: [Qemu-devel] [PATCH 2/3] xenfb: Add option to use grant ref for shared page.

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > The vkbd device should be able to use a grant reference to map the > shared page. > > Signed-off-by: Owen smith > --- > hw/display/xenfb.c | 39 +-- > 1 file changed, 29 insertions(+), 10 deletions(-) > > diff --git a/

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/4] target-ppc: Build error log

2014-09-10 Thread Alexey Kardashevskiy
On 09/05/2014 06:28 PM, Aravinda Prasad wrote: > > > On Friday 05 September 2014 01:34 PM, Alexander Graf wrote: >> >> >> On 04.09.14 13:13, Aravinda Prasad wrote: >>> Whenever there is a physical memory error due to bit >>> flips, which cannot be corrected by hardware, the error >>> is passed on

Re: [Qemu-devel] [PATCH 3/3] xenfb: Add "feature-no-abs-rescale" for Windows PV frontend

2014-09-10 Thread Stefano Stabellini
On Wed, 10 Sep 2014, Owen smith wrote: > Windows PV frontend requires absolute mouse values in the range > [0, 0x7fff]. Add a feature to not rescale the axes to DisplaySurface > size. Also allows Windows PV frontend to connect without a vfb > device. Moves the rescaling of axes to a seperate functi

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-10 Thread Michael R. Hines
On 09/10/2014 11:43 PM, Walid Nouri wrote: Hello Michael, Hello Paolo i have „studied“ the available documentation/Information and tried to get an idea of the QEMU live block operation possibilities. I think the MC protocol doesn’t need synchronous block device replication because primary and

Re: [Qemu-devel] ballooning not working on hotplugged pc-dimm

2014-09-10 Thread Michael R. Hines
On 09/10/2014 05:00 PM, zhanghailiang wrote: On 2014/9/9 11:05, Alexandre DERUMIER wrote: Hello, I was playing with pc-dimm hotplug, and I notice that balloning is not working on memory space of pc-dimm devices. example: qemu -m size=1024,slots=255,maxmem=15000M #free -m : 1024M -> qmp ba

Re: [Qemu-devel] [PATCH v2] blkdebug: make the fault injection functionality callable from QMP

2014-09-10 Thread Hitoshi Mitake
Hi Stefan, Eric, Sorry for my late reply. At Tue, 2 Sep 2014 16:29:14 +0100, Stefan Hajnoczi wrote: > > [1 ] > On Thu, Aug 28, 2014 at 03:18:48PM +0900, Hitoshi Mitake wrote: > > At Wed, 27 Aug 2014 06:43:49 -0600, > > Eric Blake wrote: > > > > > > [1 ] > > > On 08/26/2014 11:34 PM, Hitoshi M

Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-10 Thread Alexey Kardashevskiy
On 09/11/2014 07:16 AM, Alexander Graf wrote: > > > On 10.09.14 16:58, Alexey Kardashevskiy wrote: >> On 09/10/2014 11:01 PM, Alexander Graf wrote: >>> >>> >>> On 29.08.14 12:12, Alexey Kardashevskiy wrote: This implements DDW for emulated PHB. This advertises the query/create/remo

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-10 Thread Alexey Kardashevskiy
On 09/11/2014 07:17 AM, Alexander Graf wrote: > > > On 10.09.14 17:00, Alexey Kardashevskiy wrote: >> On 09/10/2014 11:03 PM, Alexander Graf wrote: >>> >>> >>> On 29.08.14 12:12, Alexey Kardashevskiy wrote: This implements DDW for VFIO. Host kernel support is required for this. Aft

Re: [Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-09-10 Thread Gu Zheng
Hi Igor, Thanks very much for your review and suggestion. On 09/10/2014 10:12 PM, Igor Mammedov wrote: > On Wed, 3 Sep 2014 17:06:12 +0800 > Gu Zheng wrote: > >> >> Gu Zheng (5): >> acpi/cpu: add cpu hotplug callback function to match hotplug_handler >> API >> acpi:ich9: convert cpu hot

Re: [Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-10 Thread Gu Zheng
Hi Igor, On 09/10/2014 09:28 PM, Igor Mammedov wrote: > On Wed, 3 Sep 2014 17:06:13 +0800 > Gu Zheng wrote: > >> >> Signed-off-by: Gu Zheng >> --- >> hw/acpi/cpu_hotplug.c | 17 + >> include/hw/acpi/cpu_hotplug.h |3 +++ >> 2 files changed, 20 insertions(+), 0 de

Re: [Qemu-devel] [RFC V2 04/10] x86: add x86_cpu_unrealizefn() for cpu apic remove

2014-09-10 Thread Gu Zheng
Hi Igor, On 09/09/2014 09:58 PM, Igor Mammedov wrote: > On Thu, 28 Aug 2014 11:36:36 +0800 > Gu Zheng wrote: > >> From: Chen Fan >> >> Implement x86_cpu_unrealizefn() for corresponding x86_cpu_realizefn(), >> which is mostly used to clean the apic related allocation and vmstates >> at here. >>

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Eric Blake
On 09/10/2014 06:53 PM, Fam Zheng wrote: > On Wed, 09/10 17:32, Paolo Bonzini wrote: >> Il 10/09/2014 17:02, Fam Zheng ha scritto: A bit hackish, but I don't have any better idea. Hmm... what about adding a new member to the visitors for "invalid enum" value? The dealloc visito

Re: [Qemu-devel] [PATCH] tests: add QMP input visitor test for unions with no discriminator

2014-09-10 Thread Eric Blake
On 09/10/2014 07:02 PM, Michael Roth wrote: > This more an exercise of the dealloc visitor, where it may erroneously This is more of an exercise... > use an uninitialized discriminator field as indication that union > fields corresponding to that disciminator field/type are present, discriminato

Re: [Qemu-devel] [PATCH] qapi: Fix crash with enum dealloc when kind is invalid

2014-09-10 Thread Fam Zheng
On Wed, 09/10 22:17, Eric Blake wrote: > On 09/10/2014 06:53 PM, Fam Zheng wrote: > > On Wed, 09/10 17:32, Paolo Bonzini wrote: > >> Il 10/09/2014 17:02, Fam Zheng ha scritto: > A bit hackish, but I don't have any better idea. > > Hmm... what about adding a new member to the visitors

Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration

2014-09-10 Thread Jan Vesely
Hi Gerd, sorry for taking so long to get back to this. My schedule has been super busy past couple of months. I have rebased the patches and moved the usb version desc selection to hid_initfn as you suggested. I also made the changes follow the tablet example as closely as possible I tested the p

[Qemu-devel] [PATCH 3/3] usb-hid: Add high speed keyboard configuration

2014-09-10 Thread Jan Vesely
Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 66 +++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 643b013..ac7e393 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -226,6 +22

[Qemu-devel] [PATCH v3 2/3] usb-hid: Add high speed mouse configuration

2014-09-10 Thread Jan Vesely
v2: add usb_mouse_properties use macros for bmAttributes v3: rebase Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 71 +++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index b3d02b2..6

[Qemu-devel] [PATCH 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-10 Thread Jan Vesely
Signed-off-by: Jan Vesely --- hw/usb/dev-hid.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 67a57f1..b3d02b2 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -566,9 +566,22 @@ static v

Re: [Qemu-devel] [Xen-devel] [RFC Patch v3 23/22] Introduce "xen-load-devices-state"

2014-09-10 Thread Wen Congyang
On 09/11/2014 03:15 AM, Stefano Stabellini wrote: > On Tue, 9 Sep 2014, Wen Congyang wrote: >> At 09/06/2014 05:57 AM, Stefano Stabellini Write: >>> On Fri, 5 Sep 2014, Wen Congyang wrote: introduce a "xen-load-devices-state" QAPI command that can be used to load the state of all devices,

[Qemu-devel] [PATCH 2/3] block: Add blockdev-backup to transaction

2014-09-10 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev.c | 48 qapi-schema.json | 3 +++ 2 files changed, 51 insertions(+) diff --git a/blockdev.c b/blockdev.c index 516de7f..58565d7 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1424,6 +1424,49 @@ static voi

<    1   2   3   4   >