[Qemu-devel] [PATCH] hw/dma: Print error message only once

2014-09-09 Thread Philipp Hahn
otherwise the message dma: unregistered DMA channel used nchan=0 dma_pos=0 dma_len=1 gets printed every time and fills up the log-file with 50 MiB / minute. Signed-off-by: Philipp Hahn --- hw/dma/i8257.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/dm

[Qemu-devel] [Bug 1366836] Re: Core2Duo and KVM may not boot Win8 properly on 3.x kernels

2014-09-09 Thread Erik Rull
Here the register dump of the stalled Win8 QEMU 2.1.0 monitor - type 'help' for more information (qemu) info registers EAX=3e2009e3 EBX=3e2009e3 ECX=8000 EDX=8000 ESI=3e2009e3 EDI=8220c108 EBP=81f9b33c ESP=81f9b2f0 EIP=80c98d83 EFL=00010282 [--S] CPL=0 II=0 A20=1 SMM=0 HLT=0 ES =0023 00

[Qemu-devel] [PATCH v6 00/16] KVM platform device passthrough

2014-09-09 Thread Eric Auger
This RFC series aims at enabling KVM platform device passthrough. It implements a VFIO platform device, derived from VFIO PCI device. The VFIO platform device uses the host VFIO platform driver which must be bound to the assigned device prior to the QEMU system start. - the guest can directly acc

[Qemu-devel] [PATCH v6 02/16] hw/vfio/pci: Rename VFIODevice into VFIOPCIDevice

2014-09-09 Thread Eric Auger
This prepares for the introduction of VFIOPlatformDevice Signed-off-by: Eric Auger --- hw/vfio/pci.c | 209 +- 1 file changed, 105 insertions(+), 104 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 7e6a1bc..ad5da4b 100644 ---

[Qemu-devel] [PATCH v6 03/16] hw/vfio/pci: introduce VFIODevice

2014-09-09 Thread Eric Auger
Introduce the VFIODevice struct that is going to be shared by VFIOPCIDevice and VFIOPlatformDevice. Additional fields will be added there later on for review convenience. the group's device_list becomes a list of VFIODevice This obliges to rework the reset_handler which becomes generic and calls

[Qemu-devel] [PATCH v6 01/16] vfio: move hw/misc/vfio.c to hw/vfio/pci.c Move vfio.h into include/hw/vfio

2014-09-09 Thread Eric Auger
From: Kim Phillips This is done in preparation for the addition of VFIO platform device support. Signed-off-by: Kim Phillips --- LICENSE | 2 +- MAINTAINERS | 2 +- hw/Makefile.objs | 1 + hw/misc/Makefile.objs| 1 - hw/

[Qemu-devel] [PATCH v6 04/16] hw/vfio/pci: Introduce VFIORegion

2014-09-09 Thread Eric Auger
This structure is going to be shared by VFIOPCIDevice and VFIOPlatformDevice. VFIOBAR includes it. vfio_eoi becomes an ops of VFIODevice specialized by parent device. This makes possible to transform vfio_bar_write/read into generic vfio_region_write/read that will be used by VFIOPlatformDevice to

[Qemu-devel] [PATCH v6 10/16] hw/vfio: calxeda xgmac device

2014-09-09 Thread Eric Auger
The platform device class has become abstract. The device can be be instantiated on command line using such option. -device vfio-calxeda-xgmac,host="fff51000.ethernet" compat string is hardcoded in the code except if user overrides it Signed-off-by: Eric Auger --- v5 -> v6 - back again followi

[Qemu-devel] [PATCH v6 09/16] hw/vfio/platform: add vfio-platform support

2014-09-09 Thread Eric Auger
Minimal VFIO platform implementation supporting - register space user mapping, - IRQ assignment based on eventfds handled on qemu side. irqfd kernel acceleration comes in a subsequent patch. Signed-off-by: Kim Phillips Signed-off-by: Eric Auger --- v5 -> v6: - vfio_device property renamed int

[Qemu-devel] [PATCH v6 05/16] hw/vfio/pci: split vfio_get_device

2014-09-09 Thread Eric Auger
vfio_get_device now takes a VFIODevice as argument. The function is split into 2 parts: vfio_get_device which is generic and vfio_populate_device which is bus specific. 3 new fields are introduced in VFIODevice to store dev_info. vfio_put_base_device is created. --- v5->v6: - simplifies the spl

[Qemu-devel] [PATCH v6 11/16] hw/arm/dyn_sysbus_devtree: enable vfio-calxeda-xgmac dynamic instantiation

2014-09-09 Thread Eric Auger
vfio-calxeda-xgmac now can be instantiated using the -device option Signed-off-by: Eric Auger --- v2 -> v3: - correct bug of reg_attr[2*i] in vfio_fdt_add_device_node - fix a bug related to compat_str_len computed on original compat instead of corrected compat - wrap_vfio_fdt_add_node take a

[Qemu-devel] [PATCH v6 13/16] hw/vfio/platform: Add irqfd support

2014-09-09 Thread Eric Auger
This patch aims at optimizing IRQ handling using irqfd framework. Instead of handling the eventfds on user-side they are handled on kernel side using - the KVM irqfd framework, - the VFIO driver virqfd framework. the virtual IRQ completion is trapped at interrupt controller This removes the need

[Qemu-devel] [PATCH v6 07/16] hw/vfio/pci: use name field in format strings

2014-09-09 Thread Eric Auger
Signed-off-by: Eric Auger --- hw/vfio/pci.c | 213 -- trace-events | 105 ++--- 2 files changed, 111 insertions(+), 207 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 5623539..c617b79 100644 --- a/hw/

[Qemu-devel] [PATCH v6 12/16] vfio/platform: add fake injection modality

2014-09-09 Thread Eric Auger
This code is aimed at testing multiple IRQ injection with user-side handled eventfds. Principle is a timer periodically triggers an IRQ at VFIO driver level. Then this IRQ follows regular VFIO driver -> eventfd trigger -> user-side eventfd handler. The IRQ is not injected into the guest. the IRQ is

[Qemu-devel] [PATCH v6 14/16] linux-headers: Update KVM headers from linux-next tag ToBeFilled

2014-09-09 Thread Eric Auger
Syncup KVM related linux headers from linux-next tree using scripts/update-linux-headers.sh. Integrate updated KVM-VFIO API related to forwarded IRQ Signed-off-by: Eric Auger --- linux-headers/linux/kvm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/linux-headers/linux/kvm.h b/l

[Qemu-devel] [PATCH v6 15/16] VFIO: COMMON: vfio_kvm_device_fd moved in the common header

2014-09-09 Thread Eric Auger
the device is now used in platform for forwarded IRQ setup Signed-off-by: Eric Auger --- hw/vfio/common.c | 3 ++- include/hw/vfio/vfio-common.h | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 252c0b8..466b0e8 100644

[Qemu-devel] [PATCH v6 16/16] VFIO: PLATFORM: add forwarded irq support

2014-09-09 Thread Eric Auger
Tests whether the forwarded IRQ modality is available. In the positive device IRQs are forwarded. This control is achieved with KVM-VFIO device. with such a modality injection still is handled through irqfds. However end of interrupt is not trapped anymore. As soon as the guest completes its virtua

[Qemu-devel] [PATCH] Prevent segmentation fault in case of relative resolve of uri

2014-09-09 Thread mrezanin
From: Miroslav Rezanina It was possible to call strcmp with NULL argument, that can cause segmentation fault. Properly checking parameters to prevent this situation. Signed-off-by: Miroslav Rezanina --- util/uri.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/uri.c

[Qemu-devel] [PATCH v6 06/16] hw/vfio/pci: rename group_list into vfio_group_list

2014-09-09 Thread Eric Auger
better fit in the rest of the namespace Signed-off-by: Eric Auger --- hw/vfio/pci.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index d48ca04..5623539 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -283,7 +283,7 @@

[Qemu-devel] [PATCH v6 08/16] hw/vfio: create common module

2014-09-09 Thread Eric Auger
A new common module is created. It implements all functions that have no device specificity (PCI, Platform). This patch only consists in move (no functional changes) Signed-off-by: Kim Phillips Signed-off-by: Eric Auger --- v5 -> v6: - follow all evolutions of original PCI code from v5 to V6 -

Re: [Qemu-devel] [PATCH] hw/dma: Print error message only once

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 09:01, Philipp Hahn ha scritto: > otherwise the message > dma: unregistered DMA channel used nchan=0 dma_pos=0 dma_len=1 > gets printed every time and fills up the log-file with 50 MiB / minute. > > Signed-off-by: Philipp Hahn > --- > hw/dma/i8257.c | 10 -- > 1 file

[Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-09-09 Thread Eric Auger
This new module implements routines which help in dynamic device binding (mmio regions, irq). They are supposed to be used by machine files that support dynamic sysbus instantiation. Signed-off-by: Alexander Graf Signed-off-by: Eric Auger --- v1 -> v2: - platform_devices renamed into dyn_sysbu

[Qemu-devel] [PATCH v3 2/6] hw/arm/dyn_sysbus_devtree: helpers for sysbus device dynamic dt node generation

2014-09-09 Thread Eric Auger
This module will be used by ARM machine files to generate device tree nodes of dynamically instantiated sysbus devices (ie. those instantiated with -device option). Signed-off-by: Alexander Graf Signed-off-by: Eric Auger --- v2 -> v3: - add arm_ prefix - arm_sysbus_device_create_devtree become

[Qemu-devel] [PATCH v3 0/6] machvirt dynamic sysbus device instantiation

2014-09-09 Thread Eric Auger
This patch series enables machvirt to dynamically instantiate sysbus devices from command line (using -device option). It applies on top of Alex Graf's series - "Dynamic sysbus device allocation support" http://lists.gnu.org/archive/html/qemu-ppc/2014-07/msg00047.html and transposes the work do

[Qemu-devel] [PATCH v3 4/6] hw/arm/boot: load_dtb becomes non static arm_load_dtb

2014-09-09 Thread Eric Auger
load_dtb is renamed into arm_load_dtb and becomes non static. it will be used by machvirt for dynamic instantiation of platform devices Signed-off-by: Eric Auger --- v2 -> v3: load_dtb renamed into arm_load_dtb --- hw/arm/boot.c| 4 ++-- include/hw/arm/arm.h | 1 + 2 files changed, 3 i

[Qemu-devel] [PATCH v3 6/6] hw/arm/virt: Support dynamically spawned sysbus devices

2014-09-09 Thread Eric Auger
Allows sysbus devices to be instantiated from command line by using -device option Signed-off-by: Alexander Graf Signed-off-by: Eric Auger --- v2 -> v3 - renaming of arm_platform_bus_create_devtree and arm_load_dtb - add copyright in hw/arm/dyn_sysbus_devtree.c v1 -> v2: - remove useless vfio

[Qemu-devel] [PATCH v3 3/6] PPC: e500: use dyn_sysbus_binding helper routines

2014-09-09 Thread Eric Auger
From: Alexander Graf Now platform_bus_init_notify and functions it calls were moved to dyn_sysbus_binding.c, remove those functions from e500. PPCE500Params includes a DynSysbusParams struct which contains the settings related to platform device instantiation. Signed-off-by: Eric Auger --- v

[Qemu-devel] [PATCH v3 5/6] hw/arm/virt: new add_fdt_*_node functions

2014-09-09 Thread Eric Auger
Create new functions: - add_fdt_uart_node - add_fdt_rtc_node - add_fdt_virtio_nodes They will be used for dynamic sysbus instantiation. Signed-off-by: Eric Auger --- v2 -> v3: reword title to avoid content violation --- hw/arm/virt.c | 67 +++---

Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property

2014-09-09 Thread Gonglei (Arei)
Hi, > Subject: RE: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property > > > Subject: Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom > property > > > > On Fri, Sep 05, 2014 at 04:37:32PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > Add a qom pro

Re: [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom property

2014-09-09 Thread Gonglei (Arei)
Hi, > > Subject: Re: [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom > > property > > > > On Fri, Sep 05, 2014 at 04:37:16PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > Add a qom property with the same name 'bootindex', > > > when we remove it form qdev pr

Re: [Qemu-devel] [PATCH] Fix typos and misspellings in comments

2014-09-09 Thread Peter Maydell
On 9 September 2014 04:23, zhanghailiang wrote: > Found by codespell: > > occured -> occurred > formated -> formatted > Comander -> Commander > gaurantee -> guarantee > > Signed-off-by: zhanghailiang > --- > hw/ppc/spapr.c | 2 +- > hw/usb/quirks.h

Re: [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI

2014-09-09 Thread Peter Maydell
On 9 September 2014 07:47, Paolo Bonzini wrote: > Il 02/09/2014 12:24, Peter Maydell ha scritto: >> This patchset converts the two remaining legacy chardevs >> ('socket' and 'udp') to use the new-style parse/kind >> mechanisms, and removes all the no-longer-required >> legacy machinery. >> Peter

Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount

2014-09-09 Thread Kevin Wolf
Am 09.09.2014 um 04:52 hat Jun Li geschrieben: > On Fri, 09/05 12:21, Kevin Wolf wrote: > > Am 01.09.2014 um 12:52 hat Jun Li geschrieben: > > > When every item of refcount block is NULL, free refcount block and reset > > > the > > > corresponding item of refcount table with NULL. > > > > > > Sig

[Qemu-devel] [RFC v1 0/6] Netduino 2 Machine Model

2014-09-09 Thread Alistair Francis
This patch series adds the Netduino 2 Machine to QEMU Information on the board is avalible at: http://www.netduino.com/netduino2/specs.htm The git tree can be found at: https://github.com/alistair23/qemu/tree/netduino2.1 This is a fully implemented machine, except for the hack changes that have

[Qemu-devel] [RFC v1 1/6] stm32f205_timer: Add the stm32f205 SoC Timer2 to 5

2014-09-09 Thread Alistair Francis
This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5 to QEMU. Signed-off-by: Alistair Francis --- V2: - Small changes to functionality and style. Thanks to Peter C - Rename for the Netduino 2 and it's SoC default-configs/arm-softmmu.mak| 1 + hw/timer/Makefile.objs

[Qemu-devel] [RFC v1 2/6] stm32f205_USART: Add the stm32f205 SoC USART Controller

2014-09-09 Thread Alistair Francis
This patch adds the stm32f205 USART controller (UART also uses the same controller). Signed-off-by: Alistair Francis --- V2: - Small changes thanks to Peter C - Rename for the Netduino 2 and it's SoC hw/char/Makefile.objs | 1 + hw/char/stm32f205_usart.c | 205 ++

[Qemu-devel] [RFC v1 3/6] stm32f205_SYSCFG: Add the stm32f205 SYSCFG

2014-09-09 Thread Alistair Francis
This patch adds the stm32f205 System Configuration Controller. This is used to configure what memory is mapped at address 0 (although that is not supported) as well as configure how the EXTI interrupts work (also not supported at the moment). This device is not required for basic examples, but mor

[Qemu-devel] [RFC v1 4/6] target_arm: Update armv7_init to support more parameters

2014-09-09 Thread Alistair Francis
This patch is a hack This patch makes the smallest number of changes possible to extend armv7m_init() so that it can be used to init the Netduino 2. Signed-off-by: Alistair Francis --- I understand that this is probably not the way that everyone would like this done. What I do want to know thou

[Qemu-devel] [RFC v1 5/6] stm32f205: Add the SoC

2014-09-09 Thread Alistair Francis
This patch adds the stm32f205 SoC. This will be used by the Netduino 2 to create a machine Signed-off-by: Alistair Francis --- hw/arm/Makefile.objs | 2 +- hw/arm/stm32f205_soc.c | 140 + include/hw/arm/stm32f205_soc.h | 61 ++

Re: [Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR event with nospace indicator

2014-09-09 Thread Kevin Wolf
Am 08.09.2014 um 18:57 hat Luiz Capitulino geschrieben: > On Mon, 8 Sep 2014 17:33:18 +0200 > Kevin Wolf wrote: > > > Am 08.09.2014 um 16:42 hat Luiz Capitulino geschrieben: > > > On Fri, 29 Aug 2014 16:07:27 -0400 > > > Luiz Capitulino wrote: > > > > > > > Management software, such as RHEV's v

[Qemu-devel] [RFC v1 6/6] netduino2: Add the Netduino 2 Machine

2014-09-09 Thread Alistair Francis
This patch adds the Netduino 2 Machine. This is a Cortex-M3 based machine. Information can be found at: http://www.netduino.com/netduino2/specs.htm Signed-off-by: Alistair Francis --- hw/arm/Makefile.objs | 2 +- hw/arm/netduino2.c | 60

Re: [Qemu-devel] [PATCH 0/4] Block-related miscellaneous cleanups

2014-09-09 Thread Kevin Wolf
Am 08.09.2014 um 18:50 hat Markus Armbruster geschrieben: > Random crap I ran into while working on a bigger task. > > Markus Armbruster (4): > qemu-io: Clean up openfile() after commit 2e40134 > xen_disk: Plug memory leak on error path > xen: Drop redundant bdrv_close() from pci_piix3_xen_i

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-09 Thread Kevin Wolf
Am 31.08.2014 um 10:32 hat Valentin Manea geschrieben: > > Set the IDE MMIO memory type to little endian. The ATA specs identify > words part of the control commands encoded as little endian. > While this has no impact on little endian systems, it's required for big > endian systems(eg OpenRisc).

Re: [Qemu-devel] [PATCH v2] Support vhd type VHD_DIFFERENCING

2014-09-09 Thread Philipp Hahn
Hello, I'm no qemu-devel expert, but as I tried myself at adding VHD_DIFF support some time ago, here are some comments: On 08.09.2014 16:41, Xiaodong Gong wrote: > diff --git a/block/vpc.c b/block/vpc.c ... > +/* Read backing file location from dyn header table */ > +if (dyndisk_

[Qemu-devel] [TRIVIAL][PATCH] libqos virtio: Increase ISR timeout

2014-09-09 Thread Marc Marí
Signed-off-by: Marc Marí --- tests/libqos/virtio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c index 128dbd0..9b6de2c 100644 --- a/tests/libqos/virtio.c +++ b/tests/libqos/virtio.c @@ -82,7 +82,7 @@ bool qvirtio_wait_que

Re: [Qemu-devel] [PATCH 0/4] Extract block accounting statistic code in it's own module

2014-09-09 Thread Kevin Wolf
Am 05.09.2014 um 15:46 hat Benoît Canet geschrieben: > With the need to add new statistics it's better to modularize asap the I/O > block accounting code. > > This series takes care of extracting this code and making it independant of > the > BlockDriverState structure. > > Compile tested and ba

[Qemu-devel] [PATCH 1/1] xhci PCIe endpoint migration compatibility fix

2014-09-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add back the PCIe config capabilities on XHCI cards in non-PCIe slots, but only for machine types before 2.1. This fixes a migration incompatibility in the XHCI PCI devices caused by: 058fdcf52cdbf57b67e7 - xhci: add endpoint cap on express bus only Note that i

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-09-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 15:03, Pavel Dovgaluk ha scritto: > >> > Hmm, probably not. The bug would not be other timers accessing the > >> > APIC, because that would also call apic_sync_vapic and the only effect > >> > would be an extra useless synchronizat

Re: [Qemu-devel] [PATCH 0/4] Extract block accounting statistic code in it's own module

2014-09-09 Thread Benoît Canet
On Tue, Sep 09, 2014 at 11:56:28AM +0200, Kevin Wolf wrote: > Am 05.09.2014 um 15:46 hat Benoît Canet geschrieben: > > With the need to add new statistics it's better to modularize asap the I/O > > block accounting code. > > > > This series takes care of extracting this code and making it independ

Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 09:54, Eric Auger ha scritto: > This new module implements routines which help in dynamic device > binding (mmio regions, irq). They are supposed to be used by machine > files that support dynamic sysbus instantiation. > > Signed-off-by: Alexander Graf > Signed-off-by: Eric Auger >

Re: [Qemu-devel] [PATCH v3 2/6] hw/arm/dyn_sysbus_devtree: helpers for sysbus device dynamic dt node generation

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 09:54, Eric Auger ha scritto: > This module will be used by ARM machine files to generate > device tree nodes of dynamically instantiated sysbus devices (ie. > those instantiated with -device option). > > Signed-off-by: Alexander Graf > Signed-off-by: Eric Auger > > --- > > v2 ->

Re: [Qemu-devel] [PATCH v3 5/6] hw/arm/virt: new add_fdt_*_node functions

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 09:54, Eric Auger ha scritto: > Create new functions: > - add_fdt_uart_node > - add_fdt_rtc_node > - add_fdt_virtio_nodes Actually they are fdt_add_uart_node etc. > They will be used for dynamic sysbus instantiation. > > Signed-off-by: Eric Auger > > --- > > v2 -> v3: > reword t

Re: [Qemu-devel] [PATCH v3 6/6] hw/arm/virt: Support dynamically spawned sysbus devices

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 09:54, Eric Auger ha scritto: > Allows sysbus devices to be instantiated from command line by > using -device option > > Signed-off-by: Alexander Graf > Signed-off-by: Eric Auger > > --- > > v2 -> v3 > - renaming of arm_platform_bus_create_devtree and arm_load_dtb > - add copyrig

Re: [Qemu-devel] [PATCH v3 6/6] hw/arm/virt: Support dynamically spawned sysbus devices

2014-09-09 Thread Peter Maydell
On 9 September 2014 12:11, Paolo Bonzini wrote: > And if arm_load_dtb used rom_add_blob_fixed > instead of cpu_physical_memory_write, you wouldn't need a reset hook at all. We need to do this anyway, because currently we don't do anything to ensure the DTB hangs around for the OS to find again on

Re: [Qemu-devel] [PATCH v7 RESEND 3/8] memory: add parameter errp to memory_region_init_ram_ptr

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 07:27, Hu Tao ha scritto: > Add parameter errp to memory_region_init_ram_ptr and update all call > sites to pass in &error_abort. > > Reviewed-by: Peter Crosthwaite > Signed-off-by: Hu Tao Aborting in VFIO would be wrong, since VFIO devices can be hotplugged. But actually, ram_b

[Qemu-devel] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-09-09 Thread john.liuli
From: Li Liu Eeay to reproduce, just try "qemu -monitor stdio -nographic" and type "quit", then the terminal will be crashed. There are two pathes try to call tcgetattr of stdio in vl.c: 1) Monitor_parse(optarg, "readline"); . qemu_opts_foreach(qemu_find_opts("chardev"),

Re: [Qemu-devel] [PATCH v7 RESEND 4/8] memory: add parameter errp to memory_region_init_rom_device

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 07:27, Hu Tao ha scritto: > Add parameter errp to memory_region_init_rom_device and update all call > sites to pass in &error_abort. > > Reviewed-by: Peter Crosthwaite > Signed-off-by: Hu Tao Better not use error_abort if we can avoid it, and here it's particularly easy... Paolo

Re: [Qemu-devel] [PATCH v7 RESEND 6/8] exec: file_ram_alloc: don't exit if failed to preallocate memory

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 07:27, Hu Tao ha scritto: > diff --git a/exec.c b/exec.c > index 2b9c4c5..0362cd8 100644 > --- a/exec.c > +++ b/exec.c > @@ -1129,8 +1129,8 @@ static void *file_ram_alloc(RAMBlock *block, > return area; > > error: > -if (mem_prealloc) { > -exit(1); > +if (area

Re: [Qemu-devel] [PATCH v7 RESEND 2/8] memory: add parameter errp to memory_region_init_ram

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 07:27, Hu Tao ha scritto: > Add parameter errp to memory_region_init_ram and update all call sites > to pass in &error_abort. > > Signed-off-by: Hu Tao > Reviewed-by: Peter Crosthwaite > --- > backends/hostmem-ram.c | 2 +- > hw/alpha/typhoon.c

Re: [Qemu-devel] [PATCH v7 RESEND 0/8] memory API improvements and bug fixes for memory backends

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 07:27, Hu Tao ha scritto: > This is merely a rebase of v7, and fixes two merge conflicts. > > This series includes two parts: > > 1. part 1 includes patches 1-4, which improves error handling of > memory_region_init_ram, memory_region_init_ram_ptr and > memory_region_in

[Qemu-devel] ppc: Test

2014-09-09 Thread mihai.cara...@freescale.com
Please ignore this mail.

[Qemu-devel] [PATCH 0/2] vfio: Another try to fix ROM BAR endianness

2014-09-09 Thread Alexey Kardashevskiy
I did some tests on LE/BE guest/host combinations and came up with these 2 patches. Please comment. Thanks. Alexey Kardashevskiy (1): Revert "vfio: Make BARs native endian" Nikunj A Dadhania (1): vfio: make rom read endian sensitive hw/misc/vfio.c | 24 1 file cha

[Qemu-devel] [PATCH 2/2] vfio: make rom read endian sensitive

2014-09-09 Thread Alexey Kardashevskiy
From: Nikunj A Dadhania All memory regions used by VFIO are LITTLE_ENDIAN and they already take care of endiannes when accessing real device BARs except ROM - it was broken on BE hosts. This fixes endiannes for ROM BARs the same way as it is done for other BARs. Signed-off-by: Nikunj A Dadhania

[Qemu-devel] [PATCH 1/2] Revert "vfio: Make BARs native endian"

2014-09-09 Thread Alexey Kardashevskiy
This reverts commit c40708176a6b52b73bec14796b7c71b882ceb102. The idea not to swap bytes at all did not work out as MMIO interface is defined as target host endian and it is always big-endian for PPC64 so the original part broke PPC64 guests on LE hosts (x86/ppc64le). Signed-off-by: Alexey Kardas

Re: [Qemu-devel] the userspace process vapp mmap filed // [PULL 13/37] vhost-user: fix regions provied with VHOST_USER_SET_MEM_TABLE message

2014-09-09 Thread linhafieng
On 2014/9/3 15:08, Michael S. Tsirkin wrote: > On Wed, Sep 03, 2014 at 02:26:03PM +0800, linhafieng wrote: >> I run the user process vapp to test the VHOST_USER_SET_MEM_TABLE message >> found that the user sapce failed to mmap. > > Why off-list? > pls copy qemu mailing list and pbonz...@redhat.c

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-09 Thread Kevin Wolf
Am 22.08.2014 um 18:11 hat Benoît Canet geschrieben: > Since the block layer code is starting to modify the BDS graph right in the > middle of BDS chains (block-mirror's replace parameter for example) QEMU needs > to properly block and unblock whole BDS subtrees; recursion is a neat way to > achiev

Re: [Qemu-devel] [PATCH v14 1/5] block: round up file size to nearest sector

2014-09-09 Thread Benoît Canet
The Tuesday 09 Sep 2014 à 11:54:27 (+0800), Hu Tao wrote : Taking the time to systematically write a nice sentence in the commit message body about why your commit exists and explaining the long term purpose of the patch will: -improve the quality of your commit -please everyone involved in the r

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 12:30, Pavel Dovgaluk ha scritto: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Il 27/08/2014 15:03, Pavel Dovgaluk ha scritto: > Hmm, probably not. The bug would not be other timers accessing the > APIC, because that would also call apic_sync_vapic and the only effe

Re: [Qemu-devel] [RFC V2 02/10] qom/cpu: move register_vmstate to common CPUClass.realizefn

2014-09-09 Thread Igor Mammedov
On Thu, 28 Aug 2014 11:36:34 +0800 Gu Zheng wrote: > Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, > apic vmstate register into x86_cpu_apic_realize. And use the > cc->get_arch_id as the instance id that suggested by Igor to > fix the migration issue. > Besides, also use

Re: [Qemu-devel] [PATCH] Fix typos and misspellings in comments

2014-09-09 Thread zhanghailiang
On 2014/9/9 16:09, Peter Maydell wrote: On 9 September 2014 04:23, zhanghailiang wrote: Found by codespell: occured -> occurred formated -> formatted Comander -> Commander gaurantee -> guarantee Signed-off-by: zhanghailiang --- hw/ppc/spapr.c | 2 +- hw/usb/qu

Re: [Qemu-devel] [PATCH v2 08/12] hpet: fixing saving and loading process

2014-09-09 Thread Paolo Bonzini
Il 28/08/2014 13:58, Paolo Bonzini ha scritto: > This also breaks migration to 2.1, unless you use -no-hpet. Actually, this is also only needed for your record/replay implementation. Paolo

Re: [Qemu-devel] [PATCH v14 2/5] block: don't convert file size to sector size

2014-09-09 Thread Benoît Canet
The Tuesday 09 Sep 2014 à 11:54:28 (+0800), Hu Tao wrote : > and avoid converting it back later. > > Signed-off-by: Hu Tao > Reviewed-by: Max Reitz > --- > block/gluster.c | 9 - > block/qcow.c | 8 > block/qcow2.c | 10 +- > block/raw-posix.c | 12 ++--

[Qemu-devel] Fwd: Re: the userspace process vapp mmap filed // [PULL 13/37] vhost-user: fix regions provied with VHOST_USER_SET_MEM_TABLE message

2014-09-09 Thread linhafieng
Forwarded Message Subject: Re: the userspace process vapp mmap filed //[Qemu-devel] [PULL 13/37] vhost-user: fix regions provied with VHOST_USER_SET_MEM_TABLE message Date: Tue, 09 Sep 2014 19:45:08 +0800 From: linhafieng To: Michael S. Tsirkin CC: n.nikol...@virtualopensyst

Re: [Qemu-devel] [PATCH v2 08/12] hpet: fixing saving and loading process

2014-09-09 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 28/08/2014 13:58, Paolo Bonzini ha scritto: > > This also breaks migration to 2.1, unless you use -no-hpet. > > Actually, this is also only needed for your record/replay implementation. Ok, I'll move it to t

[Qemu-devel] [PATCH 01/10] vl: use QLIST_FOREACH_SAFE to visit change state handlers

2014-09-09 Thread Paolo Bonzini
This lets a handler delete itself. Signed-off-by: Paolo Bonzini --- vl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 9c9acf5..15aea95 100644 --- a/vl.c +++ b/vl.c @@ -1721,11 +1721,11 @@ void qemu_del_vm_change_state_handler(VMChangeStateEntry *e)

[Qemu-devel] [PATCH 02/10] apic_common: vapic_paddr synchronization fix

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch postpones vapic_paddr initialization, which is performed during migration. When vapic_paddr is synchronized within the migration process, apic_common functions could operate with incorrect apic state, if it hadn't loaded yet. This patch postpones the synchronizati

[Qemu-devel] [PATCH 03/10] cpu: init vmstate for ticks and clock offset

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk Ticks and clock offset used by CPU timers have to be saved in vmstate. But vmstate for these fields registered only in icount mode. Missing registration leads to breaking the continuity when vmstate is loaded. This patch introduces new initialization function which fixes thi

[Qemu-devel] [PATCH 05/10] fdc: adding vmstate for save/restore

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk VMState added by this patch preserves correct loading of the FDC device state. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- hw/block/fdc.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/h

[Qemu-devel] [PATCH 00/10] x86: migrate more data

2014-09-09 Thread Paolo Bonzini
Juan, David, Amit, here are Pavel's fixes for x86 migration. Please help applying them, or ack them so that I can merge them through the KVM tree. Thanks, Paolo Paolo Bonzini (1): vl: use QLIST_FOREACH_SAFE to visit change state handlers Pavel Dovgalyuk (9): apic_common: vapic_paddr synchro

[Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk VMState added by this patch preserves correct loading of the PC speaker device state. This breaks migration to 2.1 and earlier. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- hw/audio/pcspk.c | 16 ++-- 1 file changed, 14 insertions(+), 2 de

[Qemu-devel] [PATCH 06/10] parallel: adding vmstate for save/restore

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk VMState added by this patch preserves correct loading of the parallel port controller state. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- hw/char/parallel.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/char/parallel.c b/hw

[Qemu-devel] [PATCH 08/10] pckbd: adding new fields to vmstate

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds outport to VMState to allow correct saving and restoring the state of PC keyboard controller. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- hw/input/pckbd.c | 51 +++ 1 file changed, 51 ins

[Qemu-devel] [PATCH 07/10] serial: fixing vmstate for save/restore

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk Some fields were added to VMState by this patch to preserve correct loading of the serial port controller state. Updating FCR value while loading was also modified to disable generating an interrupt by loadvm. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --

[Qemu-devel] [PATCH 10/10] mc146818rtc: add missed field to vmstate

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch adds irq_reinject_on_ack_count field to VMState to allow correct saving/loading the state of MC146818 RTC. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- hw/timer/mc146818rtc.c | 24 + 1 file changed, 24 insertions(+)

[Qemu-devel] [PATCH 09/10] piix: do not raise irq while loading vmstate

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch disables raising an irq while loading the state of PCI bridge. The aim of this patch is preserving the same behavior while saving and restoring the VM state. IRQ is not raised while saving the state of the bridge. That's why the behavior of the restored system wil

Re: [Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR event with nospace indicator

2014-09-09 Thread Eric Blake
On 09/09/2014 02:27 AM, Kevin Wolf wrote: >>> >>> What was our conclusion wrt the human-readable strerror() string for >>> debugging? Didn't we want to add that as well? >> >> I can do it on top of this patch. So, just adding a new field for this >> is fine? > > I think so. Perhaps we should give

Re: [Qemu-devel] [PATCH v14 3/5] qapi: introduce PreallocMode and new PreallocModes full and falloc.

2014-09-09 Thread Eric Blake
On 09/08/2014 09:54 PM, Hu Tao wrote: > This patch prepares for the subsequent patches. > > Signed-off-by: Hu Tao > Reviewed-by: Max Reitz > Reviewed-by: Kevin Wolf > --- > block/qcow2.c | 23 +++ > qapi/block-core.json | 17 + > tests/qem

Re: [Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR event with nospace indicator

2014-09-09 Thread Luiz Capitulino
On Tue, 09 Sep 2014 06:37:31 -0600 Eric Blake wrote: > On 09/09/2014 02:27 AM, Kevin Wolf wrote: > > >>> > >>> What was our conclusion wrt the human-readable strerror() string for > >>> debugging? Didn't we want to add that as well? > >> > >> I can do it on top of this patch. So, just adding a n

Re: [Qemu-devel] [RFC V2 03/10] cpu: add device_add foo-x86_64-cpu support

2014-09-09 Thread Igor Mammedov
On Thu, 28 Aug 2014 11:36:35 +0800 Gu Zheng wrote: > From: Chen Fan > > Add support to device_add foo-x86_64-cpu, and additional checks of > apic id are added into x86_cpuid_set_apic_id() and x86_cpu_apic_create() > for duplicate. Besides, in order to support "device/device_add foo-x86_64-cpu"

Re: [Qemu-devel] [RFC v1 1/6] stm32f205_timer: Add the stm32f205 SoC Timer2 to 5

2014-09-09 Thread Peter Crosthwaite
On Tue, Sep 9, 2014 at 6:23 PM, Alistair Francis wrote: > This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5 > to QEMU. > > Signed-off-by: Alistair Francis > --- > V2: > - Small changes to functionality and style. Thanks to Peter C > - Rename for the Netduino 2 and it's SoC > > de

Re: [Qemu-devel] [PATCH v14 3/5] qapi: introduce PreallocMode and new PreallocModes full and falloc.

2014-09-09 Thread Benoît Canet
The Tuesday 09 Sep 2014 à 11:54:29 (+0800), Hu Tao wrote : > This patch prepares for the subsequent patches. > > Signed-off-by: Hu Tao > Reviewed-by: Max Reitz > Reviewed-by: Kevin Wolf > --- > block/qcow2.c | 23 +++ > qapi/block-core.json | 17 +

Re: [Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR event with nospace indicator

2014-09-09 Thread Eric Blake
On 09/09/2014 06:43 AM, Luiz Capitulino wrote: >> Enhancing query-block in addition to the event makes sense, if it is >> easy enough to do. At this point, we are talking about debugging aids, >> so as long as they are documented appropriately, I won't be too fussy. > > OK, but I'm wondering if

Re: [Qemu-devel] [PATCH 10/10] mc146818rtc: add missed field to vmstate

2014-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > This patch adds irq_reinject_on_ack_count field to VMState to allow correct > saving/loading the state of MC146818 RTC. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Paolo Bonzini Acked-by: Juan Quintela > --- > hw/timer/mc146818rtc.c |

Re: [Qemu-devel] [PATCH 08/10] pckbd: adding new fields to vmstate

2014-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > This patch adds outport to VMState to allow correct saving and restoring > the state of PC keyboard controller. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Paolo Bonzini Acked-by: Juan Quintela > --- > hw/input/pckbd.c | 51 +++

Re: [Qemu-devel] [PATCH 01/10] vl: use QLIST_FOREACH_SAFE to visit change state handlers

2014-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > This lets a handler delete itself. > > Signed-off-by: Paolo Bonzini Acked-by: Juan Quintela

Re: [Qemu-devel] [PATCH 02/10] apic_common: vapic_paddr synchronization fix

2014-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > This patch postpones vapic_paddr initialization, which is performed > during migration. When vapic_paddr is synchronized within the migration > process, apic_common functions could operate with incorrect apic state, > if it hadn't loaded yet. This

Re: [Qemu-devel] [PATCH 1/1] xhci PCIe endpoint migration compatibility fix

2014-09-09 Thread Michael S. Tsirkin
On Tue, Sep 09, 2014 at 11:19:43AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add back the PCIe config capabilities on XHCI cards in non-PCIe slots, > but only for machine types before 2.1. You can clear cmask for these bits to at least make it work one way.

Re: [Qemu-devel] [RFC v1 2/6] stm32f205_USART: Add the stm32f205 SoC USART Controller

2014-09-09 Thread Peter Crosthwaite
On Tue, Sep 9, 2014 at 6:24 PM, Alistair Francis wrote: > This patch adds the stm32f205 USART controller > (UART also uses the same controller). > > Signed-off-by: Alistair Francis > --- > V2: > - Small changes thanks to Peter C > - Rename for the Netduino 2 and it's SoC > > hw/char/Makefile.o

Re: [Qemu-devel] [PATCH v14 4/5] raw-posix: Add falloc and full preallocation option

2014-09-09 Thread Benoît Canet
The Tuesday 09 Sep 2014 à 11:54:30 (+0800), Hu Tao wrote : > This patch adds a new option preallocation for raw format, and implements > falloc and full preallocation. > > Signed-off-by: Hu Tao > Reviewed-by: Max Reitz > --- > block/raw-posix.c | 93 > ++

Re: [Qemu-devel] [PATCH] block: extend BLOCK_IO_ERROR event with nospace indicator

2014-09-09 Thread Kevin Wolf
Am 09.09.2014 um 14:53 hat Eric Blake geschrieben: > On 09/09/2014 06:43 AM, Luiz Capitulino wrote: > > >> Enhancing query-block in addition to the event makes sense, if it is > >> easy enough to do. At this point, we are talking about debugging aids, > >> so as long as they are documented approp

  1   2   3   >