[Qemu-devel] [Bug 1361912] [NEW] qemu-mips64 Segmentation fault

2014-08-27 Thread Hill
Public bug reported: When I ran qemu-mips64 for any mips 64 executable , I got this error: $ ./qemu-mips64 ../lang qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped) Is this a known issue? ** Affects: qemu Importance: Undecided Sta

[Qemu-devel] pert stat in KVM guest can not get LLC-loads hardware cache event

2014-08-27 Thread Hui Kang
[Sorry about the repeated message. ] Dear KVM developers: I am trying use perf stat inside a VM to obtain some hardware cache performance counter values. The perf stat can report some numbers for L1 and TLB related counters. But for the LLC-loads and LLC-load-misses, the numbers are always 0. It s

Re: [Qemu-devel] [PATCH] qemu-char: fix terminal crash when using "-monitor stdio -nographic"

2014-08-27 Thread Li Liu
On 2014/8/27 14:44, Markus Armbruster wrote: > "john.liuli" writes: > >> From: Li Liu >> >> Eeay to reproduce, just try "qemu -monitor stdio -nographic" >> and type "quit", then the terminal will be crashed. >> >> There are two pathes try to call tcgetattr of stdio in vl.c: >> >> 1) Monitor_pa

Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-27 Thread Richard W.M. Jones
On Tue, Aug 26, 2014 at 08:57:30PM -0600, Eric Blake wrote: > On 08/26/2014 08:38 PM, Fam Zheng wrote: > > On Tue, 08/26 21:48, Richard W.M. Jones wrote: > >> Some servers (notably VMware ESX) accept range requests, but don't > >> send back the Accept-Ranges: bytes header in their initial response.

[Qemu-devel] [PATCH 1/1] Rename piix4_acpi_system_hot_add_init() to piix4_acpi_system_hotplug_init().

2014-08-27 Thread Tang Chen
piix4_acpi_system_hot_add_init() handles not only memory hot add initialization, but the whole memory hotplug initialization. So rename it to piix4_acpi_system_hotplug_init(). Signed-off-by: Tang Chen --- hw/acpi/piix4.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/h

[Qemu-devel] [RESEND PATCH v3 0/8] QEmu memory hot unplug support.

2014-08-27 Thread Tang Chen
This patch-set implements memory hot-remove for QEmu. Approach: QEmu sets GPE status bit, then triggers SCI to notify guest os. Guest os checks device status, and free memory resource if possible, then generate OST. Finally, qemu handles OST events to free dimm device. Change log v2 -> v3: 1. Div

[Qemu-devel] [RESEND PATCH v3 2/8] acpi, ich9: Add memory hot unplug support for ich9.

2014-08-27 Thread Tang Chen
Implement ich9_pm_device_unplug_cb() to support memory hot-remove, calling acpi_memory_unplug_cb(). And itself will be called in ich9_device_unplug_cb(). Signed-off-by: Tang Chen --- hw/acpi/ich9.c | 12 hw/isa/lpc_ich9.c | 5 +++-- include/hw/acpi/ich9.h | 2 ++ 3 fi

[Qemu-devel] [RESEND PATCH v3 1/8] acpi, piix4: Add memory hot unplug support for piix4.

2014-08-27 Thread Tang Chen
From: Hu Tao Implement acpi_memory_unplug_cb(), sending an sci to guest to trigger memory hot-remove, and call it in piix4_device_unplug_cb(). Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 25 + hw/acpi/piix4.c |

[Qemu-devel] [RESEND PATCH v3 4/8] qdev: Add memory hot unplug support for bus-less devices.

2014-08-27 Thread Tang Chen
From: Hu Tao Implement bus-less device hot-remove in qdev_unplug(). It will call PCMachine callback introduced in previous patch. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/core/qdev.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index

[Qemu-devel] [RESEND PATCH v3 3/8] pc: Add memory hot unplug support for pc machine.

2014-08-27 Thread Tang Chen
From: Hu Tao Implement device unplug callback for PCMachine. And it now only support pc-dimm hot-remove. The callback will call piix4 or ich9 callbacks introduced in previous patches. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/i386/pc.c | 32 1 file

[Qemu-devel] [RFC PATCH v1 2/4] Add event handling for memory device insertion.

2014-08-27 Thread Tang Chen
Define device insertion OST event and status, and add a function to handle memory insertion. Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 18 ++ include/hw/acpi/acpi.h | 10 +- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/hw/acpi/memory_hotp

[Qemu-devel] [RESEND PATCH v3 8/8] monitor: Add memory hot unplug support for device_del command.

2014-08-27 Thread Tang Chen
From: Hu Tao Implement find_peripheral_device() to find bus-less device, and call it in qmp_device_del() so that device_del command will be able to remove memory device. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- include/qom/object.h | 1 + qdev-monitor.c | 23 +

[Qemu-devel] [RFC PATCH v1 0/4] Handle memory hotplug errors from guest OS.

2014-08-27 Thread Tang Chen
When doing memory hotplug, QEmu is not aware of guest OS error when hotplugging memory devices. Even if guest OS failed to hot-add memory, the pc-dimm device will be added to QEmu. Even if guest OS failed to hot-remove memory, QEmu will remove the pc-dimm device. An example is: for a Linux guest,

[Qemu-devel] [RESEND PATCH v3 5/8] pc-dimm: Add pc_dimm_unrealize() for memory hot unplug support.

2014-08-27 Thread Tang Chen
From: Hu Tao Implement unrealize function for pc-dimm device. It delete subregion from hotplug region, and delete ram address range from guest ram list. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/mem/pc-dimm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/mem/p

[Qemu-devel] [RFC PATCH v1 4/4] Handle memory hotplug error from guest OS in QEmu.

2014-08-27 Thread Tang Chen
Before this patch, QEmu is not aware of guest OS error when hotplugging memory devices. Even if guest OS failed to hot-add memory, the pc-dimm device will be added to QEmu. Even if guest OS failed to hot-remove memory, QEmu will remove the pc-dimm device. For example, for a Linux guest, the Linux

[Qemu-devel] [RESEND PATCH v3 6/8] acpi: Add hardware implementation for memory hot unplug.

2014-08-27 Thread Tang Chen
This patch adds a bool member named "is_removing" to MemStatus indicating if the memory device is being removed. It is set to true in acpi_memory_unplug_cb() when doing memory hot-remove with device_del command, or write an ACPI_EJECTION_IN_PROGRESS status to ACPI register when triggering memory ho

[Qemu-devel] [RFC PATCH v1 3/4] Introduce wait condition to catch guest OS memory hotplug error.

2014-08-27 Thread Tang Chen
When acpi_memory_plug_cb() sends a SCI to guest OS, vcpu thread will handle it. And QEmu thread will return, who is not able to catch the error if guest OS failed to handle the SCI. Of course, if guest OS failed to handle SCI, it will give error messages. But QEmu will not output anything. Furthe

[Qemu-devel] [RESEND PATCH v3 7/8] pc, acpi bios: Add memory hot unplug interface.

2014-08-27 Thread Tang Chen
From: Hu Tao This patch implements MEMORY_SLOT_EJECT_METHOD according to ACPI spec. Signed-off-by: Hu Tao Signed-off-by: Tang Chen --- hw/i386/ssdt-mem.dsl | 5 + hw/i386/ssdt-misc.dsl| 15 ++- include/hw/acpi/pc-hotplug.h | 2 ++ 3 files changed, 21 insertio

[Qemu-devel] [RFC PATCH v1 1/4] Use macro to define ACPI notification event.

2014-08-27 Thread Tang Chen
According to ACPI spec, device object notification values define insertion request (Device Check) as 1, and ejection request as 3. Use macro to define them. Signed-off-by: Tang Chen --- hw/acpi/memory_hotplug.c | 7 +-- include/hw/acpi/acpi.h | 5 - 2 files changed, 9 insertions(+), 3

Re: [Qemu-devel] [RFC PATCH v1 0/4] Handle memory hotplug errors from guest OS.

2014-08-27 Thread tangchen
Forgot to mention, this patch-set is based on the following patch-set: [RESEND PATCH v3 0/8] QEmu memory hot unplug support. https://www.mail-archive.com/qemu-devel@nongnu.org/msg253018.html Thanks. On 08/27/2014 04:09 PM, Tang Chen wrote: When doing memory hotplug, QEmu is not aware of guest

Re: [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies

2014-08-27 Thread David Gibson
On Tue, Aug 26, 2014 at 10:34:10AM +0200, Paolo Bonzini wrote: > Il 26/08/2014 06:30, David Gibson ha scritto: > > These 3 patches fix some places where things ought to depend on an > > existing config variable, but don't. > > Which header provdides the #defines? Ah, crap, none does. So effectiv

Re: [Qemu-devel] [RFC PATCH v2 11/13] spapr_pci_vfio: Enable DDW

2014-08-27 Thread David Gibson
On Tue, Aug 26, 2014 at 06:16:51PM +1000, Alexey Kardashevskiy wrote: > On 08/26/2014 05:19 PM, David Gibson wrote: > > On Fri, Aug 15, 2014 at 08:12:33PM +1000, Alexey Kardashevskiy wrote: > >> This implements DDW for VFIO. Host kernel support is required for this. > >> > >> Signed-off-by: Alexey

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-27 Thread tangchen
On 08/26/2014 10:24 PM, Andrey Korolyov wrote: .. Just to remind - Windows will not add pc dimms without populated SRAT, so imho forcing NUMA topology to be set (and whose support is required anyway from guest linux kernel in order to support ACPI hotplug) is better than approach proposed by

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-27 Thread tangchen
On 08/26/2014 10:24 PM, Andrey Korolyov wrote: .. Just to remind - Windows will not add pc dimms without populated SRAT, so imho forcing NUMA topology to be set (and whose support is required anyway from guest linux kernel in order to support ACPI hotplug) is better than approach proposed by

Re: [Qemu-devel] [RFC PATCH v2 12/13] vfio: Enable DDW ioctls to VFIO IOMMU driver

2014-08-27 Thread David Gibson
On Tue, Aug 26, 2014 at 06:20:51PM +1000, Alexey Kardashevskiy wrote: > On 08/26/2014 05:20 PM, David Gibson wrote: > > On Fri, Aug 15, 2014 at 08:12:34PM +1000, Alexey Kardashevskiy wrote: > >> This enables DDW RTAS-related ioctls in VFIO. > >> > >> Signed-off-by: Alexey Kardashevskiy > > > > Th

Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotests: Add 093 for IO throttling

2014-08-27 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 02:19:44PM +0800, Fam Zheng wrote: > On Tue, 08/26 14:50, Stefan Hajnoczi wrote: > > On Thu, Jun 05, 2014 at 04:47:46PM +0800, Fam Zheng wrote: > > > +result = self.vm.qmp("block_set_io_throttle", conv_keys=False, > > > **limits) > > > +self.assert_qmp(resul

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-27 Thread Andrey Korolyov
On Wed, Aug 27, 2014 at 12:39 PM, tangchen wrote: > > On 08/26/2014 10:24 PM, Andrey Korolyov wrote: >> >> .. >> >> Just to remind - Windows will not add pc dimms without populated SRAT, >> so imho forcing NUMA topology to be set (and whose support is required >> anyway from guest linux kernel

Re: [Qemu-devel] [PATCH 0/2] pflash (UEFI varstore) migration shortcut for libvirt

2014-08-27 Thread Daniel P. Berrange
On Sat, Aug 23, 2014 at 12:19:05PM +0200, Laszlo Ersek wrote: > Libvirt is growing support for x86_64 OVMF guests: > > http://www.redhat.com/archives/libvir-list/2014-August/msg01045.html > > An important feature of such guests is the persistent store for > non-volatile UEFI variables. This is im

Re: [Qemu-devel] [PATCH 1/2] qapi.py: avoid Python 2.5+ any() function

2014-08-27 Thread Stefan Hajnoczi
On Fri, Aug 15, 2014 at 10:43:24AM +0300, Riku Voipio wrote: > On Tue, Aug 12, 2014 at 01:37:33PM +0100, Stefan Hajnoczi wrote: > > There is one instance of any() in qapi.py that breaks builds on older > > distros that ship Python 2.4 (like RHEL5): > > > > GEN qmp-commands.h > > Traceback (mos

[Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-08-27 Thread Tiejun Chen
We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen --- hw/i386/kvm/pci-assign.c| 170 +--- include/hw/pci/pci_assign.h | 204 +

[Qemu-devel] [PATCH 0/1] qemu:pci-assign: try to pci-assign.c

2014-08-27 Thread Tiejun Chen
As you know I'm working on supporting IGD passthrough. Here we need load VGABIOS to work out IGD case. Obviously something may be duplicated to kvm codes, we should unify some codes but looks its not easy to finish that in short time. So as Michael suggestion, at least we'd better split assigned_d

Re: [Qemu-devel] [PATCH 0/2] pflash (UEFI varstore) migration shortcut for libvirt

2014-08-27 Thread Laszlo Ersek
On 08/27/14 10:58, Daniel P. Berrange wrote: > On Sat, Aug 23, 2014 at 12:19:05PM +0200, Laszlo Ersek wrote: >> Libvirt is growing support for x86_64 OVMF guests: >> >> http://www.redhat.com/archives/libvir-list/2014-August/msg01045.html >> >> An important feature of such guests is the persistent s

[Qemu-devel] [PATCH] hmp: Add info machines

2014-08-27 Thread zhanghailiang
This is the hmp counterpart of qmp query_machines Signed-off-by: zhanghailiang --- hmp-commands.hx | 2 ++ hmp.c | 22 ++ hmp.h | 1 + monitor.c | 7 +++ 4 files changed, 32 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index d

Re: [Qemu-devel] [RFC PATCH v2 02/13] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows

2014-08-27 Thread Alexander Graf
On 15.08.14 12:12, Alexey Kardashevskiy wrote: > The existing KVM_CREATE_SPAPR_TCE ioctl only support 4G windows max. > We are going to add huge DMA windows support so this will create small > window and unexpectedly fail later. > > This disables KVM_CREATE_SPAPR_TCE for windows bigger that 4GB.

Re: [Qemu-devel] [PATCH 0/1] qemu:pci-assign: try to pci-assign.c

2014-08-27 Thread Laszlo Ersek
On 08/27/14 11:13, Tiejun Chen wrote: > As you know I'm working on supporting IGD passthrough. > > Here we need load VGABIOS to work out IGD case. Obviously something may > be duplicated to kvm codes, we should unify some codes but looks its not > easy to finish that in short time. So as Michael s

Re: [Qemu-devel] [RFC PATCH v2 05/13] spapr_pci: Introduce a liobn number generating macros

2014-08-27 Thread Alexander Graf
On 15.08.14 12:12, Alexey Kardashevskiy wrote: > We are going to have multiple DMA windows per PHB and we want them to > migrate so we need a predictable way of assigning LIOBNs. > > This introduces a macro which makes up a LIOBN from fixed prefix, > PHB index (unique PHB id) and window number.

Re: [Qemu-devel] [PATCH 0/1] qemu:pci-assign: try to pci-assign.c

2014-08-27 Thread Chen, Tiejun
On 2014/8/27 17:29, Laszlo Ersek wrote: On 08/27/14 11:13, Tiejun Chen wrote: As you know I'm working on supporting IGD passthrough. Here we need load VGABIOS to work out IGD case. Obviously something may be duplicated to kvm codes, we should unify some codes but looks its not easy to finish th

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseofits correspondingioapic->irr bit always set

2014-08-27 Thread Zhang Haoyu
>> Hi, all >> >> I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC >> interrupt storm, >> because "if (!ent->fields.mask && (ioapic->irr & (1 << i)))" is always >> true in __kvm_ioapic_update_eoi(). >> >> Any ideas? > We meet this severa

Re: [Qemu-devel] [RFC PATCH v2 07/13] spapr_rtas: Add Dynamic DMA windows (DDW) RTAS calls support

2014-08-27 Thread Alexander Graf
On 15.08.14 12:12, Alexey Kardashevskiy wrote: > This adds support for Dynamic DMA Windows (DDW) option defined by > the SPAPR specification which allows to have additional DMA window(s) > which can support page sizes other than 4K. > > The existing implementation of DDW in the guest tries to cr

Re: [Qemu-devel] [PATCH 0/1] qemu:pci-assign: try to pci-assign.c

2014-08-27 Thread Laszlo Ersek
On 08/27/14 11:34, Chen, Tiejun wrote: > On 2014/8/27 17:29, Laszlo Ersek wrote: >> Just to make it clear: I'm assuming that you CC'd me because >> get-maintainer.pl listed my name, as a committer. I had one series in > > Yes. > >> this area that improved error message propagation and error repo

Re: [Qemu-devel] [PATCH 0/1] qemu:pci-assign: try to pci-assign.c

2014-08-27 Thread Chen, Tiejun
On 2014/8/27 17:39, Laszlo Ersek wrote: On 08/27/14 11:34, Chen, Tiejun wrote: On 2014/8/27 17:29, Laszlo Ersek wrote: Just to make it clear: I'm assuming that you CC'd me because get-maintainer.pl listed my name, as a committer. I had one series in Yes. this area that improved error mess

Re: [Qemu-devel] [PATCH v3] block.curl: timeout option

2014-08-27 Thread Stefan Hajnoczi
On Wed, Aug 13, 2014 at 12:44:26PM -0300, Daniel Henrique Barboza wrote: > Changes in v3: > - changed option name from 'curltimeout' to 'timeout' > > Changes in v2: > - remove double quote from the int value in qemu-options.hx > > Daniel Henrique Barboza (1): > block.curl: adding 'timeout' opti

Re: [Qemu-devel] [RFC PATCH v2 13/13] spapr: Add pseries-2.2 machine with default "ddw" option

2014-08-27 Thread Alexander Graf
On 15.08.14 12:12, Alexey Kardashevskiy wrote: > This defines new "pseries" machine version which is capable of DDW > (dynamic DMA windows) by default. > > Signed-off-by: Alexey Kardashevskiy This machine should also be the new default for -M pseries. Alex

Re: [Qemu-devel] [RFC PATCH v2 13/13] spapr: Add pseries-2.2 machine with default "ddw" option

2014-08-27 Thread Alexander Graf
On 15.08.14 12:12, Alexey Kardashevskiy wrote: > This defines new "pseries" machine version which is capable of DDW > (dynamic DMA windows) by default. > > Signed-off-by: Alexey Kardashevskiy In fact, please reverse the logic. The 2.1 machine should get ddw=off and the 2.2 machine an empty com

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-27 Thread Alexander Graf
On 25.08.14 15:45, Aravinda Prasad wrote: > Whenever there is a physical memory error due to bit > flips, which cannot be corrected by hardware, the error > is passed on to the kernel. If the memory address in > error belongs to guest address space then guest kernel > is responsible to take actio

Re: [Qemu-devel] [PATCH] trace: [ust] Fix format string computation in tcg-enabled events

2014-08-27 Thread Lluís Vilanova
Lluís Vilanova writes: > TCG-enabled events start with two format strings. Delay per-argument format > computation until requested ('Event.formats'). ping Without this fix, QEMU does not compile if an entry in trace-events has the "tcg" property. > Signed-off-by: Lluís Vilanova > --- > scrip

Re: [Qemu-devel] [PATCH] hmp: Add info machines

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 11:24, zhanghailiang ha scritto: > This is the hmp counterpart of qmp query_machines > > Signed-off-by: zhanghailiang > --- > hmp-commands.hx | 2 ++ > hmp.c | 22 ++ > hmp.h | 1 + > monitor.c | 7 +++ > 4 files changed, 32 inse

Re: [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 10:22, David Gibson ha scritto: > Have I mentioned that I really hate the fact that qemu has different > config variables visible to make and C. Yeah, the introduction of config-devices.h was nixed by one of the maintainers a few years ago... > I'll rework, but probably not for a li

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > > This patch adds virtual clock-dependent timers to VMState to allow correct > > saving and restoring the state of RTL8139 network controller. > > > > Signed-off

Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-27 Thread Richard W.M. Jones
On Wed, Aug 27, 2014 at 08:37:22AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > On 08/26/2014 08:38 PM, Fam Zheng wrote: > >> On Tue, 08/26 21:48, Richard W.M. Jones wrote: > >>> Some servers (notably VMware ESX) accept range requests, but don't > >>> send back the Accept-Ranges: by

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto: >> > Again, this is only needed in your record/replay system (and you haven't >> > yet quite explained why the design has this limitation), so it should >> > not be a part of this series. > I see. Updating s->timer and s->TimerExpire in post_load wi

Re: [Qemu-devel] [PATCH V4] net: Forbid dealing with packets when VM is not running

2014-08-27 Thread Juan Quintela
zhanghailiang wrote: > For all NICs(except virtio-net) emulated by qemu, > Such as e1000, rtl8139, pcnet and ne2k_pci, > Qemu can still receive packets when VM is not running. > > If this happened in *migration's* last PAUSE VM stage, but > before the end of the migration, the new receiving packet

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto: > >> > Again, this is only needed in your record/replay system (and you haven't > >> > yet quite explained why the design has this limitation), so it should > >> > not be a part of this series. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-27 Thread Alexander Graf
On 25.08.14 15:45, Aravinda Prasad wrote: > This patch adds FWNMI support in qemu for powerKVM > guests by handling the ibm,nmi-register rtas call. > Whenever OS issues ibm,nmi-register RTAS call, the > machine check notification address is saved and the > machine check interrupt vector 0x200 is

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-27 Thread Alexander Graf
On 25.08.14 15:45, Aravinda Prasad wrote: > It is possible for multi-processors to experience machine > check at or about the same time. As per PAPR, subsequent > processors serialize waiting for the first processor to > issue the ibm,nmi-interlock call. > > The second processor retries if the f

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto: > Again, this is only needed in your record/replay system (and you haven't > yet quite explained why the design has this limitation), so it

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto: > >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > >> Il 27/08/2014 12:15, Pavel Dovgaluk ha scritto: > > Again, this is only needed in your record/replay system (and you haven't > > ye

Re: [Qemu-devel] [PATCH] spapr_pci: turn IOMMU root into an I/O region

2014-08-27 Thread Alexander Graf
On 26.08.14 18:40, Greg Kurz wrote: > On sPAPR, virtio devices are connected to the PCI bus and use MSI-X. > Commit cc943c36faa192cd4b32af8fe5edb31894017d35 has modified MSI-X > so that writes are made using the bus master address space. > Unfortunately, the MSI-X notification hits unassigned_mem

Re: [Qemu-devel] [PATCH] spapr_pci: Fix config space corruption

2014-08-27 Thread Alexander Graf
On 13.08.14 09:20, Alexey Kardashevskiy wrote: > When disabling MSI/MSIX via "ibm,change-msi" RTAS call, no check was made > if MSI or MSIX is actually supported and the MSI message was reset > unconditionally. If this happened on a device which does not support MSI > (but does support MSIX, othe

Re: [Qemu-devel] [PATCH 1/2] qapi.py: avoid Python 2.5+ any() function

2014-08-27 Thread Stefan Hajnoczi
On Fri, Aug 15, 2014 at 10:43:24AM +0300, Riku Voipio wrote: > On Tue, Aug 12, 2014 at 01:37:33PM +0100, Stefan Hajnoczi wrote: > > There is one instance of any() in qapi.py that breaks builds on older > > distros that ship Python 2.4 (like RHEL5): > > > > GEN qmp-commands.h > > Traceback (mos

Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards

2014-08-27 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 08:39:14AM +0200, Gerd Hoffmann wrote: > On Di, 2014-08-05 at 16:05 +0200, Markus Armbruster wrote: > > Ping? > > Back online. What is the state here? I've seen Stefan (Cc'ed) posted a > different patch for the same issue? Anything merged meanwhile? I am sending a v2 of

Re: [Qemu-devel] [PATCH] spapr-vlan: Don't touch last entry in buffer list

2014-08-27 Thread Alexander Graf
On 22.08.14 03:50, Anton Blanchard wrote: > The last 8 bytes of the buffer list is defined to contain the number > of dropped frames. At the moment we use it to store rx entries, > which trips up ethtool -S: > > rx_no_buffer: 9223380832981355136 > > Fix this by skipping the last buffer list ent

[Qemu-devel] [PATCH v2 0/6] Fixes for buildbot failures

2014-08-27 Thread Stefan Hajnoczi
v2: * Use setenv(3) instead of prepending environment variables to shell command-line [Markus] * 'error' should be 'warning' in QEMU_AUDIO_DRV=none commit description [Peter] * Avoid all() in tracetool [Riku] * Avoid GSequence in qemu-img.c (RHEL 5 glib does not support it) I just did a swe

[Qemu-devel] [PATCH v2 1/6] qapi.py: avoid Python 2.5+ any() function

2014-08-27 Thread Stefan Hajnoczi
There is one instance of any() in qapi.py that breaks builds on older distros that ship Python 2.4 (like RHEL5): GEN qmp-commands.h Traceback (most recent call last): File "build/scripts/qapi-commands.py", line 445, in ? exprs = parse_schema(input_file) File "build/scripts/qapi.py", li

[Qemu-devel] [PATCH v2 2/6] libqtest: launch QEMU with QEMU_AUDIO_DRV=none

2014-08-27 Thread Stefan Hajnoczi
No test case actually uses the audio backend. Disable audio to prevent warnings on hosts with no sound hardware present: GTESTER check-qtest-aarch64 sdl: SDL_OpenAudio failed sdl: Reason: No available audio device sdl: SDL_OpenAudio failed sdl: Reason: No available audio device audio:

[Qemu-devel] [PATCH v2 5/6] block: sort formats alphabetically in bdrv_iterate_format()

2014-08-27 Thread Stefan Hajnoczi
Format names are best consumed in alphabetical order. This makes human-readable output easy to produce. bdrv_iterate_format() already has an array of format strings. Sort them before invoking the iteration callback. Signed-off-by: Stefan Hajnoczi --- block.c | 14 +- 1 file change

[Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in tracetool

2014-08-27 Thread Stefan Hajnoczi
Red Hat Enterprise Linux 5 ships Python 2.4.3. The all() function was added in Python 2.5 so we cannot use it. Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/backend/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/tracetool/backend/__init__.py b/

[Qemu-devel] [PATCH v2 4/6] mirror: fix uninitialized variable delay_ns warnings

2014-08-27 Thread Stefan Hajnoczi
The gcc 4.1.2 compiler warns that delay_ns may be uninitialized in mirror_iteration(). There are two break statements in the do ... while loop that skip over the delay_ns assignment. These are probably the cause of the warning. Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 4 +--- 1 file

[Qemu-devel] [PATCH v2 6/6] Revert "qemu-img: sort block formats in help message"

2014-08-27 Thread Stefan Hajnoczi
This reverts commit 1a443c1b8b4314d365e82bddeb1de5b4b1c15fb3 and the later commit 395071a76328189f50c778f4dee6dabb90503dd9. GSequence was introduced in glib 2.14. RHEL 5 fails to compile since it uses glib 2.12.3. Now that bdrv_iterate_format() invokes the iteration callback in sorted order thes

Re: [Qemu-devel] [PATCH 0/6] target-ppc: More Cleanup of FXU Instructions

2014-08-27 Thread Alexander Graf
On 25.08.14 22:21, Richard Henderson wrote: > On 08/25/2014 12:25 PM, Tom Musta wrote: >> This series follows up my previous series of bug fixes to Power fixed point >> instructions >> (http://lists.nongnu.org/archive/html/qemu-ppc/2014-08/msg00068.html). >> Richard Henderson provided additional

Re: [Qemu-devel] [PATCH 3/3] qemu-img: always goto out in img_snapshot() error paths

2014-08-27 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 08:35:33AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > The out label has the qemu_progress_end() and other cleanup calls. > > Always goto out in error paths so the cleanup happens. > > > > Note that bdrv_unref(NULL) is safe. We just need to initialize

Re: [Qemu-devel] [PATCH 0/3] qemu-img: error path fixes

2014-08-27 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 07:17:53PM +0100, Stefan Hajnoczi wrote: > I noticed a few minor issues when looking at cache flag parsing. This series > cleans them up. > > Stefan Hajnoczi (3): > qemu-img: fix img_commit() error return value > qemu-img: fix img_compare() flags error path > qemu-im

[Qemu-devel] [PATCH] dump: let dump_error printf the error reason

2014-08-27 Thread zhanghailiang
The second parameter of dump_error is unused, but one purpose of using this function is to report the error info. Signed-off-by: zhanghailiang --- dump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dump.c b/dump.c index 71d3e94..0f44e9d 100644 --- a/dump.c +++ b/dump.c @@ -83,6 +83,9

Re: [Qemu-devel] [PATCH] spapr_pci: turn IOMMU root into an I/O region

2014-08-27 Thread Alexey Kardashevskiy
On 08/27/2014 08:57 PM, Alexander Graf wrote: > > > On 26.08.14 18:40, Greg Kurz wrote: >> On sPAPR, virtio devices are connected to the PCI bus and use MSI-X. >> Commit cc943c36faa192cd4b32af8fe5edb31894017d35 has modified MSI-X >> so that writes are made using the bus master address space. >> U

Re: [Qemu-devel] [PATCH] block: Always compile virtio-blk dataplane

2014-08-27 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 02:57:19PM +0800, Fam Zheng wrote: > Dataplane doesn't depend on linux-aio any more, so we don't need the > compiling condition now. > > Configure options are kept but just print a message. > > Signed-off-by: Fam Zheng > --- > configure | 21 ++--

Re: [Qemu-devel] [PATCH V4] net: Forbid dealing with packets when VM is not running

2014-08-27 Thread Michael S. Tsirkin
On Tue, Aug 26, 2014 at 04:06:17PM +0800, zhanghailiang wrote: > For all NICs(except virtio-net) emulated by qemu, > Such as e1000, rtl8139, pcnet and ne2k_pci, > Qemu can still receive packets when VM is not running. > > If this happened in *migration's* last PAUSE VM stage, but > before the end

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-27 Thread Michael S. Tsirkin
On Wed, Aug 20, 2014 at 05:23:21PM +0800, Zhangjie (HZ) wrote: > On 2014/8/19 12:56, Jason Wang wrote: > > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > call it before setting > > Zhang Jie, please test this patch to see if it fixes the issue. > > > +static void vhost_net_se

Re: [Qemu-devel] [PATCH V4] net: Forbid dealing with packets when VM is not running

2014-08-27 Thread Michael S. Tsirkin
On Wed, Aug 27, 2014 at 01:53:21PM +0200, Michael S. Tsirkin wrote: > On Tue, Aug 26, 2014 at 04:06:17PM +0800, zhanghailiang wrote: > > For all NICs(except virtio-net) emulated by qemu, > > Such as e1000, rtl8139, pcnet and ne2k_pci, > > Qemu can still receive packets when VM is not running. > >

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > > vapic state should not be synchronized with APIC while loading, > > because APIC state could be not loaded yet at that moment. > > We just save vapic_paddr in

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 14:16, Pavel Dovgaluk ha scritto: >> > Can you use a vm_change_state_handler, or a QEMU_CLOCK_VIRTUAL timer >> > with expiration time in the past (e.g. at time zero) to run the sync >> > code as soon as possible? Then you can preserve the current migration >> > format and avoid using

Re: [Qemu-devel] [PATCH v2] blkdebug: make the fault injection functionality callable from QMP

2014-08-27 Thread Eric Blake
On 08/26/2014 11:34 PM, Hitoshi Mitake wrote: >>> {"execute": "blkdebug-set-rules", "arguments": {"device": "ide0-hd0", >>> "rules":[{"event": "write_aio", "type": "inject-error", "immediately": >> >> Why 'write_aoi'? New QMP commands should prefer dashes (write-aio) if >> there is no compelling r

Re: [Qemu-devel] [PATCH] block: Introduce "null" driver

2014-08-27 Thread Eric Blake
On 08/27/2014 12:22 AM, Fam Zheng wrote: > This is an analogue to Linux null_blk. It can be used for testing block > device emulation and general block layer functionalities such as > coroutines and throttling, where disk IO is not necessary or wanted. > > Signed-off-by: Fam Zheng > --- > block/

Re: [Qemu-devel] [PATCH] curl: Add override_accept_ranges flag to force sending range requests.

2014-08-27 Thread Daniel H Barboza
On 08/26/2014 05:48 PM, Richard W.M. Jones wrote: Some servers (notably VMware ESX) accept range requests, but don't send back the Accept-Ranges: bytes header in their initial response. For these servers you can set override_accept_ranges to 'on' which forces this block driver to send range req

Re: [Qemu-devel] [PATCH v2 2/6] libqtest: launch QEMU with QEMU_AUDIO_DRV=none

2014-08-27 Thread Gerd Hoffmann
On Mi, 2014-08-27 at 12:08 +0100, Stefan Hajnoczi wrote: > No test case actually uses the audio backend. Disable audio to > prevent > warnings on hosts with no sound hardware present: > > GTESTER check-qtest-aarch64 > sdl: SDL_OpenAudio failed > sdl: Reason: No available audio device > s

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-08-27 Thread Michael S. Tsirkin
On Thu, Aug 21, 2014 at 03:42:53PM +0800, Zhangjie (HZ) wrote: > On 2014/8/21 14:53, Jason Wang wrote: > > On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: > >> > >> After migration, vhost is not disabled, virtual nic became unreachable > >> because vhost is not awakened. > >> By the logical of EVENT

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-08-27 Thread Michael S. Tsirkin
On Wed, Aug 27, 2014 at 05:13:07PM +0800, Tiejun Chen wrote: > We will try to reuse assign_dev_load_option_rom in xen side, and > especially its a good beginning to unify pci assign codes both on > kvm and xen in the future. > > Signed-off-by: Tiejun Chen > --- > hw/i386/kvm/pci-assign.c| 17

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 27/08/2014 14:16, Pavel Dovgaluk ha scritto: > >> > Can you use a vm_change_state_handler, or a QEMU_CLOCK_VIRTUAL timer > >> > with expiration time in the past (e.g. at time zero) to run the sync > >> > code as soon as possible? Then you can

Re: [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error

2014-08-27 Thread Luiz Capitulino
On Thu, 21 Aug 2014 21:03:09 +0800 wrote: > From: Gonglei > > error: 'i' undeclared (first use in this function) > > Signed-off-by: Gonglei Applied to the qmp branch, thanks. > --- > v2: > avoid to mix code and declarations, add a pair of {}, thanks Peter. > --- > monitor.c | 7 +-- >

Re: [Qemu-devel] [RFC PATCH 2/2] VFIO: Clear stale MSIx table during EEH reset

2014-08-27 Thread Gavin Shan
On Tue, Aug 26, 2014 at 02:25:47PM -0600, Alex Williamson wrote: >On Wed, 2014-08-20 at 19:52 +1000, Gavin Shan wrote: >> The PCI device MSIx table is cleaned out in hardware after EEH PE >> reset. However, we still hold the stale MSIx entries in QEMU, which >> should be cleared accordingly. Otherw

Re: [Qemu-devel] [PATCH] dump: let dump_error printf the error reason

2014-08-27 Thread Luiz Capitulino
On Wed, 27 Aug 2014 19:18:53 +0800 zhanghailiang wrote: > The second parameter of dump_error is unused, but one purpose of > using this function is to report the error info. > > Signed-off-by: zhanghailiang > --- > dump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dump.c b/du

Re: [Qemu-devel] [PATCH v7 0/4] s390: Support for Hotplug of Standby Memory

2014-08-27 Thread Matthew Rosato
On 07/30/2014 02:15 PM, Matthew Rosato wrote: > This patchset adds support in s390 for a pool of standby memory, > which can be set online/offline by the guest (ie, via chmem). > The standby pool of memory is allocated as the difference between > the initial memory setting and the maxmem setting.

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 15:03, Pavel Dovgaluk ha scritto: >> > Hmm, probably not. The bug would not be other timers accessing the >> > APIC, because that would also call apic_sync_vapic and the only effect >> > would be an extra useless synchronization. The bug would happen if the >> > APIC is accessed by

Re: [Qemu-devel] [PATCH] block: Introduce "null" driver

2014-08-27 Thread Markus Armbruster
Eric Blake writes: > On 08/27/2014 12:22 AM, Fam Zheng wrote: >> This is an analogue to Linux null_blk. It can be used for testing block >> device emulation and general block layer functionalities such as >> coroutines and throttling, where disk IO is not necessary or wanted. >> >> Signed-off-by

Re: [Qemu-devel] [RFC PATCH 2/2] VFIO: Clear stale MSIx table during EEH reset

2014-08-27 Thread Alex Williamson
On Wed, 2014-08-27 at 23:15 +1000, Gavin Shan wrote: > On Tue, Aug 26, 2014 at 02:25:47PM -0600, Alex Williamson wrote: > >On Wed, 2014-08-20 at 19:52 +1000, Gavin Shan wrote: > >> The PCI device MSIx table is cleaned out in hardware after EEH PE > >> reset. However, we still hold the stale MSIx en

[Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message

2014-08-27 Thread Stefan Hajnoczi
Name the 'granularity' parameter and give its expected value range. Previously the device name was mistakingly reported as the parameter name. Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR. Reported-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- blockdev.c | 5 +++--

Re: [Qemu-devel] bad error message in drive-mirror

2014-08-27 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 05:26:31PM -0600, Eric Blake wrote: > I just noticed today that passing "granularity":1 to QMP drive-mirror > results in this confusing error message: > > Invalid parameter 'drive-virtio-disk0' > > because the code mistakenly did > error_set(errp, QERR_INVALID_PARA

Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message

2014-08-27 Thread Eric Blake
On 08/27/2014 07:29 AM, Stefan Hajnoczi wrote: > Name the 'granularity' parameter and give its expected value range. > Previously the device name was mistakingly reported as the parameter s/mistakingly/mistakenly/ > name. > > Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR.

Re: [Qemu-devel] [PATCH] vl: process -object after other backend options

2014-08-27 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 02:17:04PM +0200, Paolo Bonzini wrote: > QOM backends can refer to chardevs, but not vice versa. So > process -chardev and -fsdev options before -object > > This fixes the rng-egd backend to virtio-rng. > > Reported-by: Amos Kong > Cc: qemu-sta...@nongnu.org > Signed-off

Re: [Qemu-devel] [PATCH v2 0/6] target-i386: Make most CPU models work with "enforce" out of the box

2014-08-27 Thread Paolo Bonzini
Il 26/08/2014 20:01, Eduardo Habkost ha scritto: > On Tue, Aug 26, 2014 at 02:56:21PM +0200, Paolo Bonzini wrote: >> Il 25/08/2014 22:45, Eduardo Habkost ha scritto: >>> >>> TCG users expect the default CPU model to contain most TCG-supported >>> features >>> (and it makes sense). See, for example

Re: [Qemu-devel] [PATCH] vl: process -object after other backend options

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 15:34, Stefan Hajnoczi ha scritto: > Option ordering is a bad idea. With an option as generic as -object, > who can say that there will never be a non-object that depends on an > -object? > > We should process the command-line left-to-right instead of ordering by > option type. May

  1   2   3   >