Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later

2014-08-26 Thread Paolo Bonzini
Il 25/08/2014 20:13, Andrew Martin ha scritto: > Even if the python daemon or apache2 did not fsync the modified files, isn't > there some action that the OS takes periodically to flush dirty pages to > disk? > This seems to be implied in the SuSE documentation: > https://www.suse.com/documentat

Re: [Qemu-devel] [RFC PATCH v2 06/13] spapr_iommu: Implement free_table() helper

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 04:16 PM, David Gibson wrote: > On Fri, Aug 15, 2014 at 08:12:28PM +1000, Alexey Kardashevskiy wrote: >> Every sPAPRTCETable object holds an IOMMU memory region which holds >> a referenced to the sPAPRTCETable instance. So if we want to free >> an sPAPRTCETable instance, calling objec

Re: [Qemu-devel] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-26 Thread Aravinda Prasad
On Tuesday 26 August 2014 11:34 AM, David Gibson wrote: > On Mon, Aug 25, 2014 at 07:15:54PM +0530, Aravinda Prasad wrote: >> It is possible for multi-processors to experience machine >> check at or about the same time. As per PAPR, subsequent >> processors serialize waiting for the first process

Re: [Qemu-devel] [PATCH] spapr_pci: Fix config space corruption

2014-08-26 Thread Alexey Kardashevskiy
On 08/13/2014 05:20 PM, Alexey Kardashevskiy wrote: > When disabling MSI/MSIX via "ibm,change-msi" RTAS call, no check was made > if MSI or MSIX is actually supported and the MSI message was reset > unconditionally. If this happened on a device which does not support MSI > (but does support MSIX, o

[Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the PC speaker device state. Signed-off-by: Pavel Dovgalyuk --- hw/audio/pcspk.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index 1d81bbe..8b22dbf 100644 -

[Qemu-devel] [PATCH 04/12] parallel: adding vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the parallel port controller state. Signed-off-by: Pavel Dovgalyuk --- hw/char/parallel.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index 7ac90a5..2

[Qemu-devel] [PATCH 00/12] Fixing hardware migration issues

2014-08-26 Thread Pavel Dovgalyuk
This set of patches is related to migration issues in hardware devices. Some of the devices had fields in their states that didn't saved and restored. These patches add missed fields to the new subsections of the vmstates. For several devices (like integratorcp) the patches add new vmstates, that d

[Qemu-devel] [PATCH 01/12] integratorcp: adding vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the integratorcp device state. Signed-off-by: Pavel Dovgalyuk --- hw/arm/integratorcp.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integrato

[Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds virtual clock-dependent timers to VMState to allow correct saving and restoring the state of RTL8139 network controller. Signed-off-by: Pavel Dovgalyuk --- hw/net/rtl8139.c | 50 -- 1 files changed, 48 insertions(+), 2 deletions(-

[Qemu-devel] [PATCH 05/12] serial: fixing vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
Some fields were added to VMState by this patch to preserve correct loading of the serial port controller state. Updating FCR value while loading was also modified to disable generating an interrupt by loadvm. Signed-off-by: Pavel Dovgalyuk --- hw/char/serial.c | 264 +++

[Qemu-devel] [PATCH 07/12] hpet: fixing saving and loading process

2014-08-26 Thread Pavel Dovgalyuk
VM clock does not run while saving, so there is no need for saving the ticks in HPET. Also added saving of hpet_offset field. Signed-off-by: Pavel Dovgalyuk --- hw/timer/hpet.c | 15 ++- 1 files changed, 2 insertions(+), 13 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet

[Qemu-devel] [PATCH 03/12] fdc: adding vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the FDC device state. Signed-off-by: Pavel Dovgalyuk --- hw/block/fdc.c | 81 1 files changed, 81 insertions(+), 0 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index

[Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-26 Thread Pavel Dovgalyuk
vapic state should not be synchronized with APIC while loading, because APIC state could be not loaded yet at that moment. We just save vapic_paddr in APIC VMState instead of synchronization. Signed-off-by: Pavel Dovgalyuk --- hw/i386/kvmvapic.c | 22 +++- hw/intc/

[Qemu-devel] [PATCH] coroutine: Drop co_sleep_ns

2014-08-26 Thread Fam Zheng
block_job_sleep_ns is the only user. Since we are moving towards AioContext aware code, it's better to use the explict version and drop the old one. Signed-off-by: Fam Zheng --- blockjob.c| 2 +- include/block/coroutine.h | 8 qemu-coroutine-sleep.c| 12 ---

[Qemu-devel] [PATCH 08/12] pckbd: adding new fields to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds outport to VMState to allow correct saving and restoring the state of PC keyboard controller. Signed-off-by: Pavel Dovgalyuk --- hw/input/pckbd.c | 51 +++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/hw/input/p

Re: [Qemu-devel] [RFC PATCH v2 09/13] spapr_pci_vfio: Call spapr_pci::reset on reset

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:31PM +1000, Alexey Kardashevskiy wrote: > This enables use of the parent class rest() callback in VFIO. > > Signed-off-by: Alexey Kardashevskiy > --- > > I honestly do not remember why I did not do this when I added VFIO > at the first place... This or equivalent p

Re: [Qemu-devel] [RFC PATCH v2 08/13] spapr_pci: Enable DDW

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:30PM +1000, Alexey Kardashevskiy wrote: > This implements DDW for emulated PHB. > > This advertises DDW in device tree. > > Since QEMU does not implement any 64bit DMA capable device, this hack > has been used to enable 64bit DMA on E1000: > > diff --git a/hw/net/e1

[Qemu-devel] [PATCH 12/12] pl031: add missed field to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds timer which uses virtual clock to the VMState. Such timers are required for saving because virtual clock is the part of the virtual machine state. Signed-off-by: Pavel Dovgalyuk --- hw/timer/pl031.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/tim

[Qemu-devel] [PATCH 10/12] piix: do not raise irq while loading vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch disables raising an irq while loading the state of PCI bridge. Signed-off-by: Pavel Dovgalyuk --- hw/pci-host/piix.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index e0e0946..86d6d20 100644 ---

Re: [Qemu-devel] [RFC PATCH v2 07/13] spapr_rtas: Add Dynamic DMA windows (DDW) RTAS calls support

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:29PM +1000, Alexey Kardashevskiy wrote: > This adds support for Dynamic DMA Windows (DDW) option defined by > the SPAPR specification which allows to have additional DMA window(s) > which can support page sizes other than 4K. > > The existing implementation of DDW in

Re: [Qemu-devel] [RFC PATCH v2 12/13] vfio: Enable DDW ioctls to VFIO IOMMU driver

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:34PM +1000, Alexey Kardashevskiy wrote: > This enables DDW RTAS-related ioctls in VFIO. > > Signed-off-by: Alexey Kardashevskiy This should probably just be folded into the previous patch. It's broken without this change. -- David Gibson| I'll

[Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds irq_reinject_on_ack_count field to VMState to allow correct saving/loading the state of MC146818 RTC. Signed-off-by: Pavel Dovgalyuk --- hw/timer/mc146818rtc.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/hw/timer/mc1468

Re: [Qemu-devel] [RFC PATCH v2 11/13] spapr_pci_vfio: Enable DDW

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:33PM +1000, Alexey Kardashevskiy wrote: > This implements DDW for VFIO. Host kernel support is required for this. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * remove()/reset() callbacks use spapr_pci's ones > --- > hw/ppc/spapr_pci_vfio.c | 86

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-26 Thread David Gibson
On Tue, Aug 26, 2014 at 12:04:27PM +0530, Aravinda Prasad wrote: > > > On Tuesday 26 August 2014 11:08 AM, David Gibson wrote: > > On Mon, Aug 25, 2014 at 07:15:16PM +0530, Aravinda Prasad wrote: > >> Extend rtas-blob to accommodate error log. Error log > >> structure is saved in rtas space upon

Re: [Qemu-devel] [PATCH 2/5] target-ppc: Register and handle HCALL to receive updated RTAS region

2014-08-26 Thread David Gibson
On Tue, Aug 26, 2014 at 04:15:40PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2014-08-26 at 15:39 +1000, David Gibson wrote: > > On Mon, Aug 25, 2014 at 07:15:26PM +0530, Aravinda Prasad wrote: > > > Receive updates from SLOF about the updated rtas-base. > > > A separate patch for SLOF [1] adds

Re: [Qemu-devel] [PATCH v6 0/3] linux-aio: introduce submit I/O asa batch

2014-08-26 Thread Zhang Haoyu
>> Hi, >> >> The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) >> introduces ~40% throughput regression on virtio-blk dataplane, and >> one of causes is that submitting I/O as a batch is removed. >> >> This patchset trys to introduce this mechanism on block, at least, >> linux-ai

Re: [Qemu-devel] [PATCH v6 0/3] linux-aio: introduce submit I/O asa batch

2014-08-26 Thread Fam Zheng
On Tue, 08/26 15:31, Zhang Haoyu wrote: > Can we use the queued io data as caches, > io write will directly return and tell the guest the io is completed after > the io is enqueued, > better user experience for burst io, > and io-read will firstly search the io queue, if matched data found, dire

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > From: Nathan Fontenot > > This add entries to the root OF node to advertise our PHBs as being > DR-capable in according with PAPR specification. > > Each PHB is given a name of PHB, advertised as a PHB type, > and associated with a power domain of -1

Re: [Qemu-devel] [PATCH v6 0/3] linux-aio: introduce submit I/O as a batch

2014-08-26 Thread Zhang Haoyu
>>> Hi, >>> >>> The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) >>> introduces ~40% throughput regression on virtio-blk dataplane, and >>> one of causes is that submitting I/O as a batch is removed. >>> >>> This patchset trys to introduce this mechanism on block, at least, >>>

Re: [Qemu-devel] [RFC PATCH v3 15/49] softmmu: fixing usage of cpu_st/ld* from helpers

2014-08-26 Thread Pavel Dovgaluk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > > MMU helper functions are called from generated code and other helper > > functions. In both cases they try to get function's return address for > > using it while restoring virtual CPU state. > > > > When MMU helpe

[Qemu-devel] [PATCH V4] net: Forbid dealing with packets when VM is not running

2014-08-26 Thread zhanghailiang
For all NICs(except virtio-net) emulated by qemu, Such as e1000, rtl8139, pcnet and ne2k_pci, Qemu can still receive packets when VM is not running. If this happened in *migration's* last PAUSE VM stage, but before the end of the migration, the new receiving packets will possibly dirty parts of RA

Re: [Qemu-devel] [RFC PATCH v2 08/13] spapr_pci: Enable DDW

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 05:14 PM, David Gibson wrote: > On Fri, Aug 15, 2014 at 08:12:30PM +1000, Alexey Kardashevskiy wrote: >> This implements DDW for emulated PHB. >> >> This advertises DDW in device tree. >> >> Since QEMU does not implement any 64bit DMA capable device, this hack >> has been used to enab

Re: [Qemu-devel] [RFC PATCH v2 11/13] spapr_pci_vfio: Enable DDW

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 05:19 PM, David Gibson wrote: > On Fri, Aug 15, 2014 at 08:12:33PM +1000, Alexey Kardashevskiy wrote: >> This implements DDW for VFIO. Host kernel support is required for this. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> Changes: >> v2: >> * remove()/reset() callbacks use spa

Re: [Qemu-devel] [RFC PATCH v2 12/13] vfio: Enable DDW ioctls to VFIO IOMMU driver

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 05:20 PM, David Gibson wrote: > On Fri, Aug 15, 2014 at 08:12:34PM +1000, Alexey Kardashevskiy wrote: >> This enables DDW RTAS-related ioctls in VFIO. >> >> Signed-off-by: Alexey Kardashevskiy > > This should probably just be folded into the previous patch. It's > broken without th

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 05:55 PM, Alexey Kardashevskiy wrote: > On 08/19/2014 10:21 AM, Michael Roth wrote: >> From: Nathan Fontenot >> >> This add entries to the root OF node to advertise our PHBs as being >> DR-capable in according with PAPR specification. >> >> Each PHB is given a name of PHB, advertised

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: populate DRC dt entries for PHBs

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > Reserve 32 entries of type PCI in each PHB's initial FDT. This > advertises to guests that each PHB is DR-capable device with > physical hotpluggable slots. This is necessary for allowing > hotplugging of devices to it later via bus rescan or guest rpap

Re: [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 06:30, David Gibson ha scritto: > These 3 patches fix some places where things ought to depend on an > existing config variable, but don't. Which header provdides the #defines? Paolo

Re: [Qemu-devel] [PATCH v6 0/3] linux-aio: introduce submit I/O asabatch

2014-08-26 Thread Zhang Haoyu
>> Can we use the queued io data as caches, >> io write will directly return and tell the guest the io is completed after >> the io is enqueued, >> better user experience for burst io, >> and io-read will firstly search the io queue, if matched data found, >> directly get the data from the queu

Re: [Qemu-devel] [RFC PATCH v2 5/8] thread-pool: Implement .cancel_async

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 08:08, Fam Zheng ha scritto: > +qemu_mutex_lock(&pool->lock); > +if (thread_pool_cancel_from_queue(elem)) { > +elem->state = THREAD_CANCELED_ASYNC; > +} Can you simply set it to THREAD_DONE (and set elem->ret to -ECANCELED)? Paolo

Re: [Qemu-devel] [RFC PATCH v2 6/8] dma: Implement .cancel_async

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 08:08, Fam Zheng ha scritto: > +if (dbs->cancelled) { > +ret = -ECANCELED; > +} Why is dbs->cancelled necessary? > dma_bdrv_unmap(dbs); > if (dbs->common.cb) { > dbs->common.cb(dbs->common.opaque, ret); > @@ -141,6 +148,9 @@ static void dma_bdrv_cb

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > This patch adds virtual clock-dependent timers to VMState to allow correct > saving and restoring the state of RTL8139 network controller. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/net/rtl8139.c | 50 +++

Re: [Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > +static int rtc_pre_load(void *opaque) > +{ > +RTCState *s = (RTCState *)opaque; > +s->irq_reinject_on_ack_count = 0; > +return 0; > +} > + You found a real bug here, in that the field has to be cleared at reset time. But reinitializi

Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting

2014-08-26 Thread Gonglei (Arei)
Hi, Gerd Nice to meet you again in maillist. :) > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Tuesday, August 26, 2014 2:36 PM > Subject: Re: [PATCH v5 0/8] modify boot order of guest, and take effect after > rebooting > > > The patchsets add one qmp inte

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: populate DRC dt entries for PHBs

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > Reserve 32 entries of type PCI in each PHB's initial FDT. This > advertises to guests that each PHB is DR-capable device with > physical hotpluggable slots. This is necessary for allowing > hotplugging of devices to it later via bus rescan or guest rpap

Re: [Qemu-devel] [PATCH 03/12] fdc: adding vmstate for save/restore

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:14, Pavel Dovgalyuk ha scritto: > +static int fdc_pre_load(void *opaque) > +{ > +FDCtrl *s = opaque; > +s->reset_sensei = 0; > +timer_del(s->result_timer); > +return 0; > +} This should be in fdctrl_reset. Paolo

Re: [Qemu-devel] [PATCH 04/12] parallel: adding vmstate for save/restore

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:14, Pavel Dovgalyuk ha scritto: > VMState added by this patch preserves correct > loading of the parallel port controller state. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/char/parallel.c | 20 > 1 files changed, 20 insertions(+), 0 deletions(-) > > di

Re: [Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:14, Pavel Dovgalyuk ha scritto: > VMState added by this patch preserves correct > loading of the PC speaker device state. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/audio/pcspk.c | 18 -- > 1 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH 08/12] pckbd: adding new fields to vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > This patch adds outport to VMState to allow correct saving and restoring > the state of PC keyboard controller. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/input/pckbd.c | 51 +++ > 1 files cha

Re: [Qemu-devel] [PATCH 07/12] spapr_pci: add ibm, configure-connector RTAS interface

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > Signed-off-by: Michael Roth I have totally no idea what this patch actually does :) When is this rtas call made? Once after the guest received the check exception interrupt? Is it all it does is fetching the copy of the device tree made by spapr_creat

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > Some kernels program a 0 address for io regions. PCI 3.0 spec > section 6.2.5.1 doesn't seem to disallow this. I remember there was discussion about it but I forgot :) Why does it have to be a part of this patchset? Worth mentioning in the commit log

Re: [Qemu-devel] [RFC PATCH v2 6/8] dma: Implement .cancel_async

2014-08-26 Thread Fam Zheng
On Tue, 08/26 10:46, Paolo Bonzini wrote: > Il 26/08/2014 08:08, Fam Zheng ha scritto: > > +if (dbs->cancelled) { > > +ret = -ECANCELED; > > +} > > Why is dbs->cancelled necessary? Request may complete after bdrv_aio_cancel_async with other status, this flag is checked to fix the

Re: [Qemu-devel] [PATCH 10/12] piix: do not raise irq while loading vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > This patch disables raising an irq while loading the state of PCI bridge. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/pci-host/piix.c | 22 -- > 1 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/hw/pci-h

Re: [Qemu-devel] [PATCH v3 00/12] spapr: add support for pci hotplug

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > These patches are based on ppc-next, and can also be obtained from: > > https://github.com/mdroth/qemu/commits/spapr-pci-hotplug-v3-ppc-next > > v3: > * dropped emulation of firmware-managed BAR allocation. this will be >introduced via a follow-u

Re: [Qemu-devel] [RFC PATCH v2 5/8] thread-pool: Implement .cancel_async

2014-08-26 Thread Fam Zheng
On Tue, 08/26 10:42, Paolo Bonzini wrote: > Il 26/08/2014 08:08, Fam Zheng ha scritto: > > +qemu_mutex_lock(&pool->lock); > > +if (thread_pool_cancel_from_queue(elem)) { > > +elem->state = THREAD_CANCELED_ASYNC; > > +} > > Can you simply set it to THREAD_DONE (and set elem->ret

Re: [Qemu-devel] [PATCH 10/12] spapr_events: re-use EPOW event infrastructure for hotplug events

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > From: Nathan Fontenot > > This extends the data structures currently used to report EPOW events to > gets via the check-exception RTAS interfaces to also include event types > for hotplug/unplug events. > > This is currently undocumented and being fi

Re: [Qemu-devel] [PATCH 11/12] spapr_events: event-scan RTAS interface

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > From: Tyrel Datwyler > > We don't actually rely on this interface to surface hotplug events, and > instead rely on the similar-but-interrupt-driven check-exception RTAS > interface used for EPOW events. However, the existence of this interface > is ne

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseof its correspondingioapic->irr bit always set

2014-08-26 Thread Zhang Haoyu
Hi, all I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC interrupt storm, because "if (!ent->fields.mask && (ioapic->irr & (1 << i)))" is always true in __kvm_ioapic_update_eoi(). Any ideas? >>> We meet this several times: search th

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1.

2014-08-26 Thread tangchen
Hi , Would anybody help to review this patch ? Thanks. :) On 08/19/2014 09:55 AM, Tang Chen wrote: If user doesn't specify numa options, nb_numa_nodes will be 0. But PCDIMMDevice->node is also initialized to 0. As a result, the following check will fail: pc_dimm_realize() { ..

Re: [Qemu-devel] [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya wrote: > - Original Message - >> From: "Stefan Hajnoczi" >> To: "Martin Kletzander" >> Cc: "qemu-devel" , libvir-l...@redhat.com, "kvm" >> , "Marina >> Zhurakhinskaya" >> Sent: Monday, August 25, 2014 12:29:27 PM >> Subject: Re: [l

Re: [Qemu-devel] [PATCH 12/12] spapr_pci: emit hotplug add/remove events during hotplug

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > From: Tyrel Datwyler > > This uses extension of existing EPOW interrupt/event mechanism > to notify userspace tools like librtas/drmgr to handle > in-guest configuration/cleanup operations in response to > device_add/device_del. > > Userspace tools t

Re: [Qemu-devel] [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Martin Kletzander
On Tue, Aug 26, 2014 at 10:33:27AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya wrote: - Original Message - From: "Stefan Hajnoczi" To: "Martin Kletzander" Cc: "qemu-devel" , libvir-l...@redhat.com, "kvm" , "Marina Zhurakhinskaya" Sent: Monda

Re: [Qemu-devel] [PATCH 09/12] spapr_pci: enable basic hotplug operations

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: > This enables hotplug for PHB bridges. Upon hotplug we generate the > OF-nodes required by PAPR specification and IEEE 1275-1994 > "PCI Bus Binding to Open Firmware" for the device. > > We associate the corresponding FDT for these nodes with the DrcEntr

Re: [Qemu-devel] [RFC PATCH v2 6/8] dma: Implement .cancel_async

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 11:21, Fam Zheng ha scritto: > On Tue, 08/26 10:46, Paolo Bonzini wrote: >> Il 26/08/2014 08:08, Fam Zheng ha scritto: >>> +if (dbs->cancelled) { >>> +ret = -ECANCELED; >>> +} >> >> Why is dbs->cancelled necessary? > > Request may complete after bdrv_aio_cancel_async

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > vapic state should not be synchronized with APIC while loading, > because APIC state could be not loaded yet at that moment. > We just save vapic_paddr in APIC VMState instead of synchronization. Can you use a vm_change_state_handler, or a QEMU_CL

Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting

2014-08-26 Thread Gerd Hoffmann
On Di, 2014-08-26 at 09:07 +, Gonglei (Arei) wrote: > Hi, Gerd > > Nice to meet you again in maillist. :) > > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Tuesday, August 26, 2014 2:36 PM > > Subject: Re: [PATCH v5 0/8] modify boot order of guest,

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-26 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [PATCH v2 2/2] pci: add check for pcie root ports and downstream > ports > > On Thu, Aug 21, 2014 at 05:47:46PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > If ARI Forwarding is disabled, according to PCIe spec

Re: [Qemu-devel] [PATCH 05/12] serial: fixing vmstate for save/restore

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:14, Pavel Dovgalyuk ha scritto: > +static int serial_pre_load(void *opaque) > +{ > +SerialState *s = (SerialState *)opaque; > +s->thr_ipending = -1; > +timer_del(s->fifo_timeout_timer); > +s->timeout_ipending = 0; > +s->poll_msl = -1; > +timer_del(s->modem_s

Re: [Qemu-devel] [RFC PATCH 2/2] VFIO: Clear stale MSIx table during EEH reset

2014-08-26 Thread Alexey Kardashevskiy
On 08/20/2014 07:52 PM, Gavin Shan wrote: > The PCI device MSIx table is cleaned out in hardware after EEH PE > reset. However, we still hold the stale MSIx entries in QEMU, which > should be cleared accordingly. Otherwise, we will run into another > (recursive) EEH error and the PCI devices contai

Re: [Qemu-devel] [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 10:39 AM, Martin Kletzander wrote: > On Tue, Aug 26, 2014 at 10:33:27AM +0100, Stefan Hajnoczi wrote: >> >> On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya >> wrote: >>> >>> - Original Message - From: "Stefan Hajnoczi" To: "Martin Kletzander"

Re: [Qemu-devel] [RFC PATCH 1/2] VFIO: Drop vfio_container_do_ioctl()

2014-08-26 Thread Alexey Kardashevskiy
On 08/20/2014 07:52 PM, Gavin Shan wrote: > The patch drops vfio_container_do_ioctl() and merges its logic to > parent function call vfio_container_ioctl() so that the subsequent > patches can reused the found VFIO group in vfio_container_ioctl(). > > Signed-off-by: Gavin Shan > --- > hw/misc/vf

Re: [Qemu-devel] [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Martin Kletzander
On Tue, Aug 26, 2014 at 11:27:41AM +0100, Stefan Hajnoczi wrote: On Tue, Aug 26, 2014 at 10:39 AM, Martin Kletzander wrote: On Tue, Aug 26, 2014 at 10:33:27AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya wrote: - Original Message - From: "S

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-26 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 09:35:15AM +0800, Hu Tao wrote: > On Fri, Aug 22, 2014 at 12:54:29PM +0200, Kevin Wolf wrote: > > Am 28.07.2014 um 10:48 hat Hu Tao geschrieben: > > > ping... > > > > > > All the 6 patches have reviewed-by now. > > > > Looks mostly good to me, I have only a few minor comme

Re: [Qemu-devel] [PATCH 2/2] ide: Fix bootindex for bus_id > 9

2014-08-26 Thread Stefan Hajnoczi
On Fri, Aug 15, 2014 at 01:32:37PM +0200, Markus Armbruster wrote: > We identify devices by their Open Firmware device paths. The encoding > of bus numbers is incorrect: idebus_get_fw_dev_path() formats them in > decimal, while SeaBIOS uses hexadecimal. With bus number > 9, SeaBIOS > will miss th

Re: [Qemu-devel] [PATCH] block: Always compile virtio-blk dataplane

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 08:57, Fam Zheng ha scritto: > Dataplane doesn't depend on linux-aio any more, so we don't need the > compiling condition now. > > Configure options are kept but just print a message. > > Signed-off-by: Fam Zheng > --- > configure | 21 ++--- >

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 08:47, David Marchand ha scritto: > > Using a version message supposes we want to keep ivshmem-server and QEMU > separated (for example, in two distribution packages) while we can avoid > this, so why would we do so ? > > If we want the ivshmem-server to come with QEMU, then both ar

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Alexander Graf
On 19.08.14 02:21, Michael Roth wrote: > From: Nathan Fontenot > > This add entries to the root OF node to advertise our PHBs as being > DR-capable in according with PAPR specification. > > Each PHB is given a name of PHB, advertised as a PHB type, > and associated with a power domain of -1 (i

Re: [Qemu-devel] [PATCH] checkpatch.pl: adjust typedef definition to QEMU coding style

2014-08-26 Thread Markus Armbruster
Paolo Bonzini writes: > Most QEMU typedefs are camelcase, starting with one uppercase letter > and containing at least one lowercase letter. There are a few > all-uppercase types, add the most common too. > > This fixes recognition of types in lines such as > > static __attribute__((unused))

Re: [Qemu-devel] [PATCH] virtio-scsi: Report error if num_queues is 0 or too large

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 08:30, Fam Zheng ha scritto: > No cmd vq surprises guest (Linux panics in virtscsi_probe), too many > queues abort qemu (in the following virtio_add_queue). > > Signed-off-by: Fam Zheng > --- > hw/scsi/virtio-scsi.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hw

Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting

2014-08-26 Thread Markus Armbruster
Gerd Hoffmann writes: > On Di, 2014-08-26 at 09:07 +, Gonglei (Arei) wrote: >> Hi, Gerd >> >> Nice to meet you again in maillist. :) >> >> > -Original Message- >> > From: Gerd Hoffmann [mailto:kra...@redhat.com] >> > Sent: Tuesday, August 26, 2014 2:36 PM >> > Subject: Re: [PATCH v

Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards

2014-08-26 Thread Markus Armbruster
Gerd Hoffmann writes: > On Di, 2014-08-05 at 16:05 +0200, Markus Armbruster wrote: >> Ping? > > Back online. What is the state here? I've seen Stefan (Cc'ed) posted a > different patch for the same issue? Anything merged meanwhile? Neither patch has been merged. Either would do for me :)

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: populate DRC dt entries for PHBs

2014-08-26 Thread Alexander Graf
On 19.08.14 02:21, Michael Roth wrote: > Reserve 32 entries of type PCI in each PHB's initial FDT. This > advertises to guests that each PHB is DR-capable device with > physical hotpluggable slots. This is necessary for allowing > hotplugging of devices to it later via bus rescan or guest rpaphp

Re: [Qemu-devel] [PULL 0/1] VFIO pull request

2014-08-26 Thread Peter Maydell
On 25 August 2014 20:39, Alex Williamson wrote: > The following changes since commit 3dd359c2d34c6abf385d58da863f337b39702585: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-08-24' > into staging (2014-08-25 17:34:30 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH] Revert "virtio_rng: replace custom backend API with UserCreatable.complete() callback"

2014-08-26 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Sat, Aug 16, 2014 at 12:23:52AM +0800, Amos Kong wrote: >> This reverts commit 57d3e1b3f52d07d215ed96df946ee01f8d9f9526. >> >> The commit introduced a regression bug, the initialization order of >> virtio-rng >> backend was changed. >> >> # x86_64-softmmu/qemu-sys

Re: [Qemu-devel] [PATCH 04/12] spapr_pci: add set-indicator RTAS interface

2014-08-26 Thread Alexander Graf
On 19.08.14 02:21, Michael Roth wrote: > From: Mike Day > > Signed-off-by: Mike Day > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 119 > + > include/hw/ppc/spapr.h | 3 ++ > 2 files changed, 122 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH 07/12] spapr_pci: add ibm, configure-connector RTAS interface

2014-08-26 Thread Alexander Graf
On 19.08.14 02:21, Michael Roth wrote: > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 111 > + > 1 file changed, 111 insertions(+) > > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index 8d1351d..96a57be 100644 > --- a/h

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2014-08-26 Thread Alexander Graf
On 19.08.14 02:21, Michael Roth wrote: > Some kernels program a 0 address for io regions. PCI 3.0 spec > section 6.2.5.1 doesn't seem to disallow this. > > Signed-off-by: Michael Roth This patch does not need to be inside of this patch set. It also should go via Michael's tree. Alex > --- >

Re: [Qemu-devel] [PATCH] device_tree.c: redirect load_device_tree err message to stderr

2014-08-26 Thread Markus Armbruster
"john.liuli" writes: > From: Li Liu > > Signed-off-by: Li Liu > --- > device_tree.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/device_tree.c b/device_tree.c > index ca83504..ccdb039 100644 > --- a/device_tree.c > +++ b/device_tree.c > @@ -79,7 +79,7 @@

Re: [Qemu-devel] [PATCH 06/15] hw/intc/arm_gic: Make ICDDCR/GICD_CTLR banked

2014-08-26 Thread Sergey Fedorov
On 22.08.2014 14:29, Fabian Aggeler wrote: > ICDDCR/GICD_CTLR is banked in GICv1 implementations with Security > Extensions or in GICv2 in independent from Security Extensions. > This makes it possible to enable forwarding of interrupts from > Distributor to the CPU interfaces for Group0 and Group1

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2014-08-26 Thread Peter Maydell
On 26 August 2014 10:14, Alexey Kardashevskiy wrote: > On 08/19/2014 10:21 AM, Michael Roth wrote: >> Some kernels program a 0 address for io regions. PCI 3.0 spec >> section 6.2.5.1 doesn't seem to disallow this. > > > I remember there was discussion about it but I forgot :) I think the conclusi

Re: [Qemu-devel] [PATCH] device_tree.c: redirect load_device_tree err message to stderr

2014-08-26 Thread Markus Armbruster
Markus Armbruster writes: [...] > A welcome improvement. Further improvement would be using > error_report(). Ah, you did that already in v2. Sorry for the noise!

Re: [Qemu-devel] [PATCH 09/12] spapr_pci: enable basic hotplug operations

2014-08-26 Thread Alexander Graf
On 19.08.14 02:21, Michael Roth wrote: > This enables hotplug for PHB bridges. Upon hotplug we generate the > OF-nodes required by PAPR specification and IEEE 1275-1994 > "PCI Bus Binding to Open Firmware" for the device. > > We associate the corresponding FDT for these nodes with the DrcEntry >

Re: [Qemu-devel] [PATCH] pc: reserve more memory for ACPI for new machine types

2014-08-26 Thread Stefan Hajnoczi
On Wed, Aug 20, 2014 at 10:55:38PM +0200, Michael S. Tsirkin wrote: > commit 868270f23d8db2cce83e4f082fe75e8625a5fbf9 > acpi-build: tweak acpi migration limits > broke kernel loading with -kernel/-initrd: it doubled > the size of ACPI tables but did not reserve > enough memory. > > As a result

Re: [Qemu-devel] [12/16] linux-user: support {name_to, open_by}_handle_at syscalls

2014-08-26 Thread Riku Voipio
Hi Paul, On Sun, Jun 15, 2014 at 05:18:29PM +0100, Paul Burton wrote: > Implement support for the name_to_handle_at and open_by_handle_at > syscalls, allowing their use by the target program. What was your testcase for these syscalls? I usually use LTP for testing syscalls, but there is no testc

Re: [Qemu-devel] [PATCH 12/12] spapr_pci: emit hotplug add/remove events during hotplug

2014-08-26 Thread Alexander Graf
On 19.08.14 02:21, Michael Roth wrote: > From: Tyrel Datwyler > > This uses extension of existing EPOW interrupt/event mechanism > to notify userspace tools like librtas/drmgr to handle > in-guest configuration/cleanup operations in response to > device_add/device_del. > > Userspace tools that

Re: [Qemu-devel] [PATCH] kvm: run cpu state synchronization on target vcpu thread

2014-08-26 Thread Christian Borntraeger
On 20/08/14 14:55, David Hildenbrand wrote: > As already done for kvm_cpu_synchronize_state(), let's trigger > kvm_arch_put_registers() via run_on_cpu() for kvm_cpu_synchronize_post_reset() > and kvm_cpu_synchronize_post_init(). > > This way, we make sure that the register synchronizing ioctls are

Re: [Qemu-devel] [PATCH] kvm: run cpu state synchronization on target vcpu thread

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 14:43, Christian Borntraeger ha scritto: > Acked-by: Christian Borntraeger > > Paolo, will you take that via the kvm tree? Yes, I will. Paolo

Re: [Qemu-devel] [PATCH memory v2 3/3] memory: Lazy init name from QOM name as needed

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 05:10, Peter Crosthwaite ha scritto: > To support name retrieval of MemoryRegions that were created > dynamically (that is, not via memory_region_init and friends). We > cache the name in MemoryRegion's state as > object_get_canonical_path_component mallocs the returned value > so it'

Re: [Qemu-devel] [PATCH v2 0/2] target-i386: tsc_adjust and mpx feature names

2014-08-26 Thread Paolo Bonzini
Il 25/08/2014 22:02, Eduardo Habkost ha scritto: > Add feature names that are missing on the x86 CPU feature name tables. Both > had > migration support implemented many months ago. > > Changes v1 -> v2: > * Commit message changes only. Added reference to migration support commit > IDs. > > No

Re: [Qemu-devel] [PATCH v2 0/6] target-i386: Make most CPU models work with "enforce" out of the box

2014-08-26 Thread Paolo Bonzini
Il 25/08/2014 22:45, Eduardo Habkost ha scritto: > > TCG users expect the default CPU model to contain most TCG-supported features > (and it makes sense). See, for example, commit > f1e00a9cf326acc1f2386a72525af8859852e1df. It doesn't though (SMAP is the most egregious omission, and probably the

Re: [Qemu-devel] [PATCH v3 05/10] qcow2: Fix refcount blocks beyond image end

2014-08-26 Thread Eric Blake
On 08/22/2014 10:31 AM, Max Reitz wrote: > If the qcow2 check function detects a refcount block located beyond the > image end, grow the image appropriately. This cannot break anything and > is the logical fix for such a case. Does the testsuite cover this one? I didn't see it mentioned in patch 1

  1   2   3   >